Merge branch 'server-cluster-locking-api' of git://linux-nfs.org/~bfields/linux

[linux-2.6-omap-h63xx.git] / arch / um / drivers / pcap_user.c

diff --git a/arch/um/drivers/pcap_user.c b/arch/um/drivers/pcap_user.c
index 2ef641ded960a96670456b5d2f1b56914a689c42..dc0a903ef9a6fa547032bc1d7bbdfb70c7c3013f 100644 (file)
--- a/arch/um/drivers/pcap_user.c
+++ b/arch/um/drivers/pcap_user.c
@@ -12,12 +12,13 @@
 #include "net_user.h"
 #include "pcap_user.h"
 #include "user.h"
+#include "um_malloc.h"
 
 #define MAX_PACKET (ETH_MAX_PACKET + ETH_HEADER_OTHER)
 
 #define PCAP_FD(p) (*(int *)(p))
 
-static void pcap_user_init(void *data, void *dev)
+static int pcap_user_init(void *data, void *dev)
 {
        struct pcap_data *pri = data;
        pcap_t *p;
@@ -27,11 +28,12 @@ static void pcap_user_init(void *data, void *dev)
        if(p == NULL){
                printk("pcap_user_init : pcap_open_live failed - '%s'\n", 
                       errors);
-               return;
+               return -EINVAL;
        }
 
        pri->dev = dev;
        pri->pcap = p;
+       return 0;
 }
 
 static int pcap_open(void *data)
@@ -41,39 +43,39 @@ static int pcap_open(void *data)
        int err;
 
        if(pri->pcap == NULL)
-               return(-ENODEV);
+               return -ENODEV;
 
        if(pri->filter != NULL){
                err = dev_netmask(pri->dev, &netmask);
                if(err < 0){
                        printk("pcap_open : dev_netmask failed\n");
-                       return(-EIO);
+                       return -EIO;
                }
 
                pri->compiled = um_kmalloc(sizeof(struct bpf_program));
                if(pri->compiled == NULL){
                        printk("pcap_open : kmalloc failed\n");
-                       return(-ENOMEM);
+                       return -ENOMEM;
                }
-               
+
                err = pcap_compile(pri->pcap, 
                                   (struct bpf_program *) pri->compiled, 
                                   pri->filter, pri->optimize, netmask);
                if(err < 0){
                        printk("pcap_open : pcap_compile failed - '%s'\n", 
                               pcap_geterr(pri->pcap));
-                       return(-EIO);
+                       return -EIO;
                }
 
                err = pcap_setfilter(pri->pcap, pri->compiled);
                if(err < 0){
                        printk("pcap_open : pcap_setfilter failed - '%s'\n", 
                               pcap_geterr(pri->pcap));
-                       return(-EIO);
+                       return -EIO;
                }
        }
-       
-       return(PCAP_FD(pri->pcap));
+
+       return PCAP_FD(pri->pcap);
 }
 
 static void pcap_remove(void *data)
@@ -113,11 +115,11 @@ int pcap_user_read(int fd, void *buffer, int len, struct pcap_data *pri)
        n = pcap_dispatch(pri->pcap, 1, handler, (u_char *) &hdata);
        if(n < 0){
                printk("pcap_dispatch failed - %s\n", pcap_geterr(pri->pcap));
-               return(-EIO);
+               return -EIO;
        }
        else if(n == 0) 
-               return(0);
-       return(hdata.len);
+               return 0;
+       return hdata.len;
 }
 
 const struct net_user_info pcap_user_info = {
@@ -130,14 +132,3 @@ const struct net_user_info pcap_user_info = {
        .delete_address = NULL,
        .max_packet     = MAX_PACKET - ETH_HEADER_OTHER
 };
-
-/*
- * Overrides for Emacs so that we follow Linus's tabbing style.
- * Emacs will notice this stuff at the end of the file and automatically
- * adjust the settings for this buffer only.  This must remain at the end
- * of the file.
- * ---------------------------------------------------------------------------
- * Local variables:
- * c-file-style: "linux"
- * End:
- */