]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/cpufreq/cpufreq.c
[PATCH] Rewritten backlight infrastructure for portable Apple computers
[linux-2.6-omap-h63xx.git] / drivers / cpufreq / cpufreq.c
index aed80e6aec6dd3dd96b63034136670757b3e40b8..44d1eca83a7250748bf27c637998c3c2973f9657 100644 (file)
@@ -52,9 +52,8 @@ static void handle_update(void *data);
  * changes to devices when the CPU clock speed changes.
  * The mutex locks both lists.
  */
-static struct notifier_block *cpufreq_policy_notifier_list;
-static struct notifier_block *cpufreq_transition_notifier_list;
-static DECLARE_RWSEM (cpufreq_notifier_rwsem);
+static BLOCKING_NOTIFIER_HEAD(cpufreq_policy_notifier_list);
+static BLOCKING_NOTIFIER_HEAD(cpufreq_transition_notifier_list);
 
 
 static LIST_HEAD(cpufreq_governor_list);
@@ -247,8 +246,6 @@ void cpufreq_notify_transition(struct cpufreq_freqs *freqs, unsigned int state)
        dprintk("notification %u of frequency transition to %u kHz\n",
                state, freqs->new);
 
-       down_read(&cpufreq_notifier_rwsem);
-
        policy = cpufreq_cpu_data[freqs->cpu];
        switch (state) {
 
@@ -260,26 +257,25 @@ void cpufreq_notify_transition(struct cpufreq_freqs *freqs, unsigned int state)
                if (!(cpufreq_driver->flags & CPUFREQ_CONST_LOOPS)) {
                        if ((policy) && (policy->cpu == freqs->cpu) &&
                            (policy->cur) && (policy->cur != freqs->old)) {
-                               dprintk(KERN_WARNING "Warning: CPU frequency is"
+                               dprintk("Warning: CPU frequency is"
                                        " %u, cpufreq assumed %u kHz.\n",
                                        freqs->old, policy->cur);
                                freqs->old = policy->cur;
                        }
                }
-               notifier_call_chain(&cpufreq_transition_notifier_list,
-                                       CPUFREQ_PRECHANGE, freqs);
+               blocking_notifier_call_chain(&cpufreq_transition_notifier_list,
+                               CPUFREQ_PRECHANGE, freqs);
                adjust_jiffies(CPUFREQ_PRECHANGE, freqs);
                break;
 
        case CPUFREQ_POSTCHANGE:
                adjust_jiffies(CPUFREQ_POSTCHANGE, freqs);
-               notifier_call_chain(&cpufreq_transition_notifier_list,
-                                       CPUFREQ_POSTCHANGE, freqs);
+               blocking_notifier_call_chain(&cpufreq_transition_notifier_list,
+                               CPUFREQ_POSTCHANGE, freqs);
                if (likely(policy) && likely(policy->cpu == freqs->cpu))
                        policy->cur = freqs->new;
                break;
        }
-       up_read(&cpufreq_notifier_rwsem);
 }
 EXPORT_SYMBOL_GPL(cpufreq_notify_transition);
 
@@ -323,7 +319,6 @@ out:
        }
        return -EINVAL;
 }
-EXPORT_SYMBOL_GPL(cpufreq_parse_governor);
 
 
 /* drivers/base/cpu.c */
@@ -350,6 +345,8 @@ show_one(scaling_min_freq, min);
 show_one(scaling_max_freq, max);
 show_one(scaling_cur_freq, cur);
 
+static int __cpufreq_set_policy(struct cpufreq_policy *data, struct cpufreq_policy *policy);
+
 /**
  * cpufreq_per_cpu_attr_write() / store_##file_name() - sysfs write access
  */
@@ -368,7 +365,10 @@ static ssize_t store_##file_name                                   \
        if (ret != 1)                                                   \
                return -EINVAL;                                         \
                                                                        \
-       ret = cpufreq_set_policy(&new_policy);                          \
+       mutex_lock(&policy->lock);                                      \
+       ret = __cpufreq_set_policy(policy, &new_policy);                \
+       policy->user_policy.object = policy->object;                    \
+       mutex_unlock(&policy->lock);                                    \
                                                                        \
        return ret ? ret : count;                                       \
 }
@@ -424,7 +424,15 @@ static ssize_t store_scaling_governor (struct cpufreq_policy * policy,
        if (cpufreq_parse_governor(str_governor, &new_policy.policy, &new_policy.governor))
                return -EINVAL;
 
-       ret = cpufreq_set_policy(&new_policy);
+       /* Do not use cpufreq_set_policy here or the user_policy.max
+          will be wrongly overridden */
+       mutex_lock(&policy->lock);
+       ret = __cpufreq_set_policy(policy, &new_policy);
+
+       policy->user_policy.policy = policy->policy;
+       policy->user_policy.governor = policy->governor;
+       mutex_unlock(&policy->lock);
+
        return ret ? ret : count;
 }
 
@@ -689,7 +697,7 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
                if (!cpu_online(j))
                        continue;
 
-               dprintk("CPU already managed, adding link\n");
+               dprintk("CPU %u already managed, adding link\n", j);
                cpufreq_cpu_get(cpu);
                cpu_sys_dev = get_cpu_sysdev(j);
                sysfs_create_link(&cpu_sys_dev->kobj, &policy->kobj,
@@ -699,9 +707,8 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
        policy->governor = NULL; /* to assure that the starting sequence is
                                  * run in cpufreq_set_policy */
        mutex_unlock(&policy->lock);
-       
+
        /* set default policy */
-       
        ret = cpufreq_set_policy(&new_policy);
        if (ret) {
                dprintk("setting policy failed\n");
@@ -711,7 +718,7 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
        module_put(cpufreq_driver->owner);
        dprintk("initialization complete\n");
        cpufreq_debug_enable_ratelimit();
-       
+
        return 0;
 
 
@@ -867,7 +874,7 @@ static void cpufreq_out_of_sync(unsigned int cpu, unsigned int old_freq, unsigne
 {
        struct cpufreq_freqs freqs;
 
-       dprintk(KERN_WARNING "Warning: CPU frequency out of sync: cpufreq and timing "
+       dprintk("Warning: CPU frequency out of sync: cpufreq and timing "
               "core thinks of %u, is %u kHz.\n", old_freq, new_freq);
 
        freqs.cpu = cpu;
@@ -999,7 +1006,7 @@ static int cpufreq_suspend(struct sys_device * sysdev, pm_message_t pmsg)
                struct cpufreq_freqs freqs;
 
                if (!(cpufreq_driver->flags & CPUFREQ_PM_NO_WARN))
-                       dprintk(KERN_DEBUG "Warning: CPU frequency is %u, "
+                       dprintk("Warning: CPU frequency is %u, "
                               "cpufreq assumed %u kHz.\n",
                               cur_freq, cpu_policy->cur);
 
@@ -1007,7 +1014,7 @@ static int cpufreq_suspend(struct sys_device * sysdev, pm_message_t pmsg)
                freqs.old = cpu_policy->cur;
                freqs.new = cur_freq;
 
-               notifier_call_chain(&cpufreq_transition_notifier_list,
+               blocking_notifier_call_chain(&cpufreq_transition_notifier_list,
                                    CPUFREQ_SUSPENDCHANGE, &freqs);
                adjust_jiffies(CPUFREQ_SUSPENDCHANGE, &freqs);
 
@@ -1080,7 +1087,7 @@ static int cpufreq_resume(struct sys_device * sysdev)
                        struct cpufreq_freqs freqs;
 
                        if (!(cpufreq_driver->flags & CPUFREQ_PM_NO_WARN))
-                               dprintk(KERN_WARNING "Warning: CPU frequency"
+                               dprintk("Warning: CPU frequency"
                                       "is %u, cpufreq assumed %u kHz.\n",
                                       cur_freq, cpu_policy->cur);
 
@@ -1088,7 +1095,8 @@ static int cpufreq_resume(struct sys_device * sysdev)
                        freqs.old = cpu_policy->cur;
                        freqs.new = cur_freq;
 
-                       notifier_call_chain(&cpufreq_transition_notifier_list,
+                       blocking_notifier_call_chain(
+                                       &cpufreq_transition_notifier_list,
                                        CPUFREQ_RESUMECHANGE, &freqs);
                        adjust_jiffies(CPUFREQ_RESUMECHANGE, &freqs);
 
@@ -1125,24 +1133,24 @@ static struct sysdev_driver cpufreq_sysdev_driver = {
  *      changes in cpufreq policy.
  *
  *     This function may sleep, and has the same return conditions as
- *     notifier_chain_register.
+ *     blocking_notifier_chain_register.
  */
 int cpufreq_register_notifier(struct notifier_block *nb, unsigned int list)
 {
        int ret;
 
-       down_write(&cpufreq_notifier_rwsem);
        switch (list) {
        case CPUFREQ_TRANSITION_NOTIFIER:
-               ret = notifier_chain_register(&cpufreq_transition_notifier_list, nb);
+               ret = blocking_notifier_chain_register(
+                               &cpufreq_transition_notifier_list, nb);
                break;
        case CPUFREQ_POLICY_NOTIFIER:
-               ret = notifier_chain_register(&cpufreq_policy_notifier_list, nb);
+               ret = blocking_notifier_chain_register(
+                               &cpufreq_policy_notifier_list, nb);
                break;
        default:
                ret = -EINVAL;
        }
-       up_write(&cpufreq_notifier_rwsem);
 
        return ret;
 }
@@ -1157,24 +1165,24 @@ EXPORT_SYMBOL(cpufreq_register_notifier);
  *     Remove a driver from the CPU frequency notifier list.
  *
  *     This function may sleep, and has the same return conditions as
- *     notifier_chain_unregister.
+ *     blocking_notifier_chain_unregister.
  */
 int cpufreq_unregister_notifier(struct notifier_block *nb, unsigned int list)
 {
        int ret;
 
-       down_write(&cpufreq_notifier_rwsem);
        switch (list) {
        case CPUFREQ_TRANSITION_NOTIFIER:
-               ret = notifier_chain_unregister(&cpufreq_transition_notifier_list, nb);
+               ret = blocking_notifier_chain_unregister(
+                               &cpufreq_transition_notifier_list, nb);
                break;
        case CPUFREQ_POLICY_NOTIFIER:
-               ret = notifier_chain_unregister(&cpufreq_policy_notifier_list, nb);
+               ret = blocking_notifier_chain_unregister(
+                               &cpufreq_policy_notifier_list, nb);
                break;
        default:
                ret = -EINVAL;
        }
-       up_write(&cpufreq_notifier_rwsem);
 
        return ret;
 }
@@ -1346,29 +1354,23 @@ static int __cpufreq_set_policy(struct cpufreq_policy *data, struct cpufreq_poli
        if (ret)
                goto error_out;
 
-       down_read(&cpufreq_notifier_rwsem);
-
        /* adjust if necessary - all reasons */
-       notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_ADJUST,
-                           policy);
+       blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
+                       CPUFREQ_ADJUST, policy);
 
        /* adjust if necessary - hardware incompatibility*/
-       notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_INCOMPATIBLE,
-                           policy);
+       blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
+                       CPUFREQ_INCOMPATIBLE, policy);
 
        /* verify the cpu speed can be set within this limit,
           which might be different to the first one */
        ret = cpufreq_driver->verify(policy);
-       if (ret) {
-               up_read(&cpufreq_notifier_rwsem);
+       if (ret)
                goto error_out;
-       }
 
        /* notification of the new policy */
-       notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_NOTIFY,
-                           policy);
-
-       up_read(&cpufreq_notifier_rwsem);
+       blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
+                       CPUFREQ_NOTIFY, policy);
 
        data->min = policy->min;
        data->max = policy->max;
@@ -1495,7 +1497,7 @@ int cpufreq_update_policy(unsigned int cpu)
 }
 EXPORT_SYMBOL(cpufreq_update_policy);
 
-static int __cpuinit cpufreq_cpu_callback(struct notifier_block *nfb,
+static int cpufreq_cpu_callback(struct notifier_block *nfb,
                                        unsigned long action, void *hcpu)
 {
        unsigned int cpu = (unsigned long)hcpu;