]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/hwmon/f71805f.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fix
[linux-2.6-omap-h63xx.git] / drivers / hwmon / f71805f.c
index ba5e7b70f8cc0f8aa6e2137e1ecac240c9fdd30b..cdbe309b8fc41275a64ee5bd906504f2bb808220 100644 (file)
@@ -35,6 +35,7 @@
 #include <linux/err.h>
 #include <linux/mutex.h>
 #include <linux/sysfs.h>
+#include <linux/ioport.h>
 #include <asm/io.h>
 
 static struct platform_device *pdev;
@@ -102,9 +103,9 @@ superio_exit(int base)
  * ISA constants
  */
 
-#define REGION_LENGTH          2
-#define ADDR_REG_OFFSET                0
-#define DATA_REG_OFFSET                1
+#define REGION_LENGTH          8
+#define ADDR_REG_OFFSET                5
+#define DATA_REG_OFFSET                6
 
 /*
  * Registers
@@ -132,7 +133,6 @@ superio_exit(int base)
 #define F71805F_REG_STATUS(nr)         (0x36 + (nr))
 
 /* individual register bits */
-#define FAN_CTRL_SKIP                  0x80
 #define FAN_CTRL_DC_MODE               0x10
 #define FAN_CTRL_LATCH_FULL            0x08
 #define FAN_CTRL_MODE_MASK             0x03
@@ -147,7 +147,6 @@ superio_exit(int base)
 struct f71805f_data {
        unsigned short addr;
        const char *name;
-       struct mutex lock;
        struct class_device *class_dev;
 
        struct mutex update_lock;
@@ -272,50 +271,42 @@ static inline u8 temp_to_reg(long val)
  * Device I/O access
  */
 
+/* Must be called with data->update_lock held, except during initialization */
 static u8 f71805f_read8(struct f71805f_data *data, u8 reg)
 {
-       u8 val;
-
-       mutex_lock(&data->lock);
        outb(reg, data->addr + ADDR_REG_OFFSET);
-       val = inb(data->addr + DATA_REG_OFFSET);
-       mutex_unlock(&data->lock);
-
-       return val;
+       return inb(data->addr + DATA_REG_OFFSET);
 }
 
+/* Must be called with data->update_lock held, except during initialization */
 static void f71805f_write8(struct f71805f_data *data, u8 reg, u8 val)
 {
-       mutex_lock(&data->lock);
        outb(reg, data->addr + ADDR_REG_OFFSET);
        outb(val, data->addr + DATA_REG_OFFSET);
-       mutex_unlock(&data->lock);
 }
 
 /* It is important to read the MSB first, because doing so latches the
-   value of the LSB, so we are sure both bytes belong to the same value. */
+   value of the LSB, so we are sure both bytes belong to the same value.
+   Must be called with data->update_lock held, except during initialization */
 static u16 f71805f_read16(struct f71805f_data *data, u8 reg)
 {
        u16 val;
 
-       mutex_lock(&data->lock);
        outb(reg, data->addr + ADDR_REG_OFFSET);
        val = inb(data->addr + DATA_REG_OFFSET) << 8;
        outb(++reg, data->addr + ADDR_REG_OFFSET);
        val |= inb(data->addr + DATA_REG_OFFSET);
-       mutex_unlock(&data->lock);
 
        return val;
 }
 
+/* Must be called with data->update_lock held, except during initialization */
 static void f71805f_write16(struct f71805f_data *data, u8 reg, u16 val)
 {
-       mutex_lock(&data->lock);
        outb(reg, data->addr + ADDR_REG_OFFSET);
        outb(val >> 8, data->addr + DATA_REG_OFFSET);
        outb(++reg, data->addr + ADDR_REG_OFFSET);
        outb(val & 0xff, data->addr + DATA_REG_OFFSET);
-       mutex_unlock(&data->lock);
 }
 
 static struct f71805f_data *f71805f_update_device(struct device *dev)
@@ -337,8 +328,6 @@ static struct f71805f_data *f71805f_update_device(struct device *dev)
                                           F71805F_REG_IN_LOW(nr));
                }
                for (nr = 0; nr < 3; nr++) {
-                       if (data->fan_ctrl[nr] & FAN_CTRL_SKIP)
-                               continue;
                        data->fan_low[nr] = f71805f_read16(data,
                                            F71805F_REG_FAN_LOW(nr));
                        data->fan_target[nr] = f71805f_read16(data,
@@ -367,8 +356,6 @@ static struct f71805f_data *f71805f_update_device(struct device *dev)
                                       F71805F_REG_IN(nr));
                }
                for (nr = 0; nr < 3; nr++) {
-                       if (data->fan_ctrl[nr] & FAN_CTRL_SKIP)
-                               continue;
                        data->fan[nr] = f71805f_read16(data,
                                        F71805F_REG_FAN(nr));
                        data->fan_ctrl[nr] = f71805f_read8(data,
@@ -991,6 +978,29 @@ static struct attribute *f71805f_attributes[] = {
        &sensor_dev_attr_in7_max.dev_attr.attr,
        &sensor_dev_attr_in7_min.dev_attr.attr,
 
+       &sensor_dev_attr_fan1_input.dev_attr.attr,
+       &sensor_dev_attr_fan1_min.dev_attr.attr,
+       &sensor_dev_attr_fan1_alarm.dev_attr.attr,
+       &sensor_dev_attr_fan1_target.dev_attr.attr,
+       &sensor_dev_attr_fan2_input.dev_attr.attr,
+       &sensor_dev_attr_fan2_min.dev_attr.attr,
+       &sensor_dev_attr_fan2_alarm.dev_attr.attr,
+       &sensor_dev_attr_fan2_target.dev_attr.attr,
+       &sensor_dev_attr_fan3_input.dev_attr.attr,
+       &sensor_dev_attr_fan3_min.dev_attr.attr,
+       &sensor_dev_attr_fan3_alarm.dev_attr.attr,
+       &sensor_dev_attr_fan3_target.dev_attr.attr,
+
+       &sensor_dev_attr_pwm1.dev_attr.attr,
+       &sensor_dev_attr_pwm1_enable.dev_attr.attr,
+       &sensor_dev_attr_pwm1_mode.dev_attr.attr,
+       &sensor_dev_attr_pwm2.dev_attr.attr,
+       &sensor_dev_attr_pwm2_enable.dev_attr.attr,
+       &sensor_dev_attr_pwm2_mode.dev_attr.attr,
+       &sensor_dev_attr_pwm3.dev_attr.attr,
+       &sensor_dev_attr_pwm3_enable.dev_attr.attr,
+       &sensor_dev_attr_pwm3_mode.dev_attr.attr,
+
        &sensor_dev_attr_temp1_input.dev_attr.attr,
        &sensor_dev_attr_temp1_max.dev_attr.attr,
        &sensor_dev_attr_temp1_max_hyst.dev_attr.attr,
@@ -1061,43 +1071,6 @@ static const struct attribute_group f71805f_group_optin[4] = {
        { .attrs = f71805f_attributes_optin[3] },
 };
 
-static struct attribute *f71805f_attributes_fan[3][8] = {
-       {
-               &sensor_dev_attr_fan1_input.dev_attr.attr,
-               &sensor_dev_attr_fan1_min.dev_attr.attr,
-               &sensor_dev_attr_fan1_alarm.dev_attr.attr,
-               &sensor_dev_attr_fan1_target.dev_attr.attr,
-               &sensor_dev_attr_pwm1.dev_attr.attr,
-               &sensor_dev_attr_pwm1_enable.dev_attr.attr,
-               &sensor_dev_attr_pwm1_mode.dev_attr.attr,
-               NULL
-       }, {
-               &sensor_dev_attr_fan2_input.dev_attr.attr,
-               &sensor_dev_attr_fan2_min.dev_attr.attr,
-               &sensor_dev_attr_fan2_alarm.dev_attr.attr,
-               &sensor_dev_attr_fan2_target.dev_attr.attr,
-               &sensor_dev_attr_pwm2.dev_attr.attr,
-               &sensor_dev_attr_pwm2_enable.dev_attr.attr,
-               &sensor_dev_attr_pwm2_mode.dev_attr.attr,
-               NULL
-       }, {
-               &sensor_dev_attr_fan3_input.dev_attr.attr,
-               &sensor_dev_attr_fan3_min.dev_attr.attr,
-               &sensor_dev_attr_fan3_alarm.dev_attr.attr,
-               &sensor_dev_attr_fan3_target.dev_attr.attr,
-               &sensor_dev_attr_pwm3.dev_attr.attr,
-               &sensor_dev_attr_pwm3_enable.dev_attr.attr,
-               &sensor_dev_attr_pwm3_mode.dev_attr.attr,
-               NULL
-       }
-};
-
-static const struct attribute_group f71805f_group_fan[3] = {
-       { .attrs = f71805f_attributes_fan[0] },
-       { .attrs = f71805f_attributes_fan[1] },
-       { .attrs = f71805f_attributes_fan[2] },
-};
-
 /* We don't include pwm_freq files in the arrays above, because they must be
    created conditionally (only if pwm_mode is 1 == PWM) */
 static struct attribute *f71805f_attributes_pwm_freq[] = {
@@ -1168,8 +1141,14 @@ static int __devinit f71805f_probe(struct platform_device *pdev)
        }
 
        res = platform_get_resource(pdev, IORESOURCE_IO, 0);
+       if (!request_region(res->start + ADDR_REG_OFFSET, 2, DRVNAME)) {
+               err = -EBUSY;
+               dev_err(&pdev->dev, "Failed to request region 0x%lx-0x%lx\n",
+                       (unsigned long)(res->start + ADDR_REG_OFFSET),
+                       (unsigned long)(res->start + ADDR_REG_OFFSET + 1));
+               goto exit_free;
+       }
        data->addr = res->start;
-       mutex_init(&data->lock);
        data->name = names[sio_data->kind];
        mutex_init(&data->update_lock);
 
@@ -1194,7 +1173,7 @@ static int __devinit f71805f_probe(struct platform_device *pdev)
 
        /* Register sysfs interface files */
        if ((err = sysfs_create_group(&pdev->dev.kobj, &f71805f_group)))
-               goto exit_free;
+               goto exit_release_region;
        if (data->has_in & (1 << 4)) { /* in4 */
                if ((err = sysfs_create_group(&pdev->dev.kobj,
                                              &f71805f_group_optin[0])))
@@ -1216,11 +1195,6 @@ static int __devinit f71805f_probe(struct platform_device *pdev)
                        goto exit_remove_files;
        }
        for (i = 0; i < 3; i++) {
-               if (data->fan_ctrl[i] & FAN_CTRL_SKIP)
-                       continue;
-               if ((err = sysfs_create_group(&pdev->dev.kobj,
-                                             &f71805f_group_fan[i])))
-                       goto exit_remove_files;
                /* If control mode is PWM, create pwm_freq file */
                if (!(data->fan_ctrl[i] & FAN_CTRL_DC_MODE)) {
                        if ((err = sysfs_create_file(&pdev->dev.kobj,
@@ -1252,9 +1226,9 @@ exit_remove_files:
        sysfs_remove_group(&pdev->dev.kobj, &f71805f_group);
        for (i = 0; i < 4; i++)
                sysfs_remove_group(&pdev->dev.kobj, &f71805f_group_optin[i]);
-       for (i = 0; i < 3; i++)
-               sysfs_remove_group(&pdev->dev.kobj, &f71805f_group_fan[i]);
        sysfs_remove_group(&pdev->dev.kobj, &f71805f_group_pwm_freq);
+exit_release_region:
+       release_region(res->start + ADDR_REG_OFFSET, 2);
 exit_free:
        platform_set_drvdata(pdev, NULL);
        kfree(data);
@@ -1265,6 +1239,7 @@ exit:
 static int __devexit f71805f_remove(struct platform_device *pdev)
 {
        struct f71805f_data *data = platform_get_drvdata(pdev);
+       struct resource *res;
        int i;
 
        platform_set_drvdata(pdev, NULL);
@@ -1272,11 +1247,12 @@ static int __devexit f71805f_remove(struct platform_device *pdev)
        sysfs_remove_group(&pdev->dev.kobj, &f71805f_group);
        for (i = 0; i < 4; i++)
                sysfs_remove_group(&pdev->dev.kobj, &f71805f_group_optin[i]);
-       for (i = 0; i < 3; i++)
-               sysfs_remove_group(&pdev->dev.kobj, &f71805f_group_fan[i]);
        sysfs_remove_group(&pdev->dev.kobj, &f71805f_group_pwm_freq);
        kfree(data);
 
+       res = platform_get_resource(pdev, IORESOURCE_IO, 0);
+       release_region(res->start + ADDR_REG_OFFSET, 2);
+
        return 0;
 }
 
@@ -1328,14 +1304,11 @@ static int __init f71805f_device_add(unsigned short address,
        if (err) {
                printk(KERN_ERR DRVNAME ": Device addition failed (%d)\n",
                       err);
-               goto exit_kfree_data;
+               goto exit_device_put;
        }
 
        return 0;
 
-exit_kfree_data:
-       kfree(pdev->dev.platform_data);
-       pdev->dev.platform_data = NULL;
 exit_device_put:
        platform_device_put(pdev);
 exit:
@@ -1387,6 +1360,7 @@ static int __init f71805f_find(int sioaddr, unsigned short *address,
                       "skipping\n");
                goto exit;
        }
+       *address &= ~(REGION_LENGTH - 1);       /* Ignore 3 LSB */
 
        err = 0;
        printk(KERN_INFO DRVNAME ": Found %s chip at %#x, revision %u\n",
@@ -1427,10 +1401,7 @@ exit:
 
 static void __exit f71805f_exit(void)
 {
-       kfree(pdev->dev.platform_data);
-       pdev->dev.platform_data = NULL;
        platform_device_unregister(pdev);
-
        platform_driver_unregister(&f71805f_driver);
 }