]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/ide/ide-cd.c
ide-cd: cleanup ide_cdrom_update_speed()
[linux-2.6-omap-h63xx.git] / drivers / ide / ide-cd.c
index 92ac658dac33458fba3b97f296df67556c7195e4..0f6d2e065b9a2dc055b4f3912d5afa09afddb024 100644 (file)
  * -Make it so that Pioneer CD DR-A24X and friends don't get screwed up on
  *   boot
  *
- * ----------------------------------
- * 1.00  Oct 31, 1994 -- Initial version.
- * 1.01  Nov  2, 1994 -- Fixed problem with starting request in
- *                       cdrom_check_status.
- * 1.03  Nov 25, 1994 -- leaving unmask_intr[] as a user-setting (as for disks)
- * (from mlord)       -- minor changes to cdrom_setup()
- *                    -- renamed ide_dev_s to ide_drive_t, enable irq on command
- * 2.00  Nov 27, 1994 -- Generalize packet command interface;
- *                       add audio ioctls.
- * 2.01  Dec  3, 1994 -- Rework packet command interface to handle devices
- *                       which send an interrupt when ready for a command.
- * 2.02  Dec 11, 1994 -- Cache the TOC in the driver.
- *                       Don't use SCMD_PLAYAUDIO_TI; it's not included
- *                       in the current version of ATAPI.
- *                       Try to use LBA instead of track or MSF addressing
- *                       when possible.
- *                       Don't wait for READY_STAT.
- * 2.03  Jan 10, 1995 -- Rewrite block read routines to handle block sizes
- *                       other than 2k and to move multiple sectors in a
- *                       single transaction.
- * 2.04  Apr 21, 1995 -- Add work-around for Creative Labs CD220E drives.
- *                       Thanks to Nick Saw <cwsaw@pts7.pts.mot.com> for
- *                       help in figuring this out.  Ditto for Acer and
- *                       Aztech drives, which seem to have the same problem.
- * 2.04b May 30, 1995 -- Fix to match changes in ide.c version 3.16 -ml
- * 2.05  Jun  8, 1995 -- Don't attempt to retry after an illegal request
- *                        or data protect error.
- *                       Use HWIF and DEV_HWIF macros as in ide.c.
- *                       Always try to do a request_sense after
- *                        a failed command.
- *                       Include an option to give textual descriptions
- *                        of ATAPI errors.
- *                       Fix a bug in handling the sector cache which
- *                        showed up if the drive returned data in 512 byte
- *                        blocks (like Pioneer drives).  Thanks to
- *                        Richard Hirst <srh@gpt.co.uk> for diagnosing this.
- *                       Properly supply the page number field in the
- *                        MODE_SELECT command.
- *                       PLAYAUDIO12 is broken on the Aztech; work around it.
- * 2.05x Aug 11, 1995 -- lots of data structure renaming/restructuring in ide.c
- *                       (my apologies to Scott, but now ide-cd.c is independent)
- * 3.00  Aug 22, 1995 -- Implement CDROMMULTISESSION ioctl.
- *                       Implement CDROMREADAUDIO ioctl (UNTESTED).
- *                       Use input_ide_data() and output_ide_data().
- *                       Add door locking.
- *                       Fix usage count leak in cdrom_open, which happened
- *                        when a read-write mount was attempted.
- *                       Try to load the disk on open.
- *                       Implement CDROMEJECT_SW ioctl (off by default).
- *                       Read total cdrom capacity during open.
- *                       Rearrange logic in cdrom_decode_status.  Issue
- *                        request sense commands for failed packet commands
- *                        from here instead of from cdrom_queue_packet_command.
- *                        Fix a race condition in retrieving error information.
- *                       Suppress printing normal unit attention errors and
- *                        some drive not ready errors.
- *                       Implement CDROMVOLREAD ioctl.
- *                       Implement CDROMREADMODE1/2 ioctls.
- *                       Fix race condition in setting up interrupt handlers
- *                        when the `serialize' option is used.
- * 3.01  Sep  2, 1995 -- Fix ordering of reenabling interrupts in
- *                        cdrom_queue_request.
- *                       Another try at using ide_[input,output]_data.
- * 3.02  Sep 16, 1995 -- Stick total disk capacity in partition table as well.
- *                       Make VERBOSE_IDE_CD_ERRORS dump failed command again.
- *                       Dump out more information for ILLEGAL REQUEST errs.
- *                       Fix handling of errors occurring before the
- *                        packet command is transferred.
- *                       Fix transfers with odd bytelengths.
- * 3.03  Oct 27, 1995 -- Some Creative drives have an id of just `CD'.
- *                       `DCI-2S10' drives are broken too.
- * 3.04  Nov 20, 1995 -- So are Vertos drives.
- * 3.05  Dec  1, 1995 -- Changes to go with overhaul of ide.c and ide-tape.c
- * 3.06  Dec 16, 1995 -- Add support needed for partitions.
- *                       More workarounds for Vertos bugs (based on patches
- *                        from Holger Dietze <dietze@aix520.informatik.uni-leipzig.de>).
- *                       Try to eliminate byteorder assumptions.
- *                       Use atapi_cdrom_subchnl struct definition.
- *                       Add STANDARD_ATAPI compilation option.
- * 3.07  Jan 29, 1996 -- More twiddling for broken drives: Sony 55D,
- *                        Vertos 300.
- *                       Add NO_DOOR_LOCKING configuration option.
- *                       Handle drive_cmd requests w/NULL args (for hdparm -t).
- *                       Work around sporadic Sony55e audio play problem.
- * 3.07a Feb 11, 1996 -- check drive->id for NULL before dereferencing, to fix
- *                        problem with "hde=cdrom" with no drive present.  -ml
- * 3.08  Mar  6, 1996 -- More Vertos workarounds.
- * 3.09  Apr  5, 1996 -- Add CDROMCLOSETRAY ioctl.
- *                       Switch to using MSF addressing for audio commands.
- *                       Reformat to match kernel tabbing style.
- *                       Add CDROM_GET_UPC ioctl.
- * 3.10  Apr 10, 1996 -- Fix compilation error with STANDARD_ATAPI.
- * 3.11  Apr 29, 1996 -- Patch from Heiko Eißfeldt <heiko@colossus.escape.de>
- *                       to remove redundant verify_area calls.
- * 3.12  May  7, 1996 -- Rudimentary changer support.  Based on patches
- *                        from Gerhard Zuber <zuber@berlin.snafu.de>.
- *                       Let open succeed even if there's no loaded disc.
- * 3.13  May 19, 1996 -- Fixes for changer code.
- * 3.14  May 29, 1996 -- Add work-around for Vertos 600.
- *                        (From Hennus Bergman <hennus@sky.ow.nl>.)
- * 3.15  July 2, 1996 -- Added support for Sanyo 3 CD changers
- *                        from Ben Galliart <bgallia@luc.edu> with 
- *                        special help from Jeff Lightfoot 
- *                        <jeffml@pobox.com>
- * 3.15a July 9, 1996 -- Improved Sanyo 3 CD changer identification
- * 3.16  Jul 28, 1996 -- Fix from Gadi to reduce kernel stack usage for ioctl.
- * 3.17  Sep 17, 1996 -- Tweak audio reads for some drives.
- *                       Start changing CDROMLOADFROMSLOT to CDROM_SELECT_DISC.
- * 3.18  Oct 31, 1996 -- Added module and DMA support.
- *                       
- *                       
- * 4.00  Nov 5, 1996   -- New ide-cd maintainer,
- *                                 Erik B. Andersen <andersee@debian.org>
- *                     -- Newer Creative drives don't always set the error
- *                          register correctly.  Make sure we see media changes
- *                          regardless.
- *                     -- Integrate with generic cdrom driver.
- *                     -- CDROMGETSPINDOWN and CDROMSETSPINDOWN ioctls, based on
- *                          a patch from Ciro Cattuto <>.
- *                     -- Call set_device_ro.
- *                     -- Implement CDROMMECHANISMSTATUS and CDROMSLOTTABLE
- *                          ioctls, based on patch by Erik Andersen
- *                     -- Add some probes of drive capability during setup.
- *
- * 4.01  Nov 11, 1996  -- Split into ide-cd.c and ide-cd.h
- *                     -- Removed CDROMMECHANISMSTATUS and CDROMSLOTTABLE 
- *                          ioctls in favor of a generalized approach 
- *                          using the generic cdrom driver.
- *                     -- Fully integrated with the 2.1.X kernel.
- *                     -- Other stuff that I forgot (lots of changes)
- *
- * 4.02  Dec 01, 1996  -- Applied patch from Gadi Oxman <gadio@netvision.net.il>
- *                          to fix the drive door locking problems.
- *
- * 4.03  Dec 04, 1996  -- Added DSC overlap support.
- * 4.04  Dec 29, 1996  -- Added CDROMREADRAW ioclt based on patch 
- *                          by Ales Makarov (xmakarov@sun.felk.cvut.cz)
- *
- * 4.05  Nov 20, 1997  -- Modified to print more drive info on init
- *                        Minor other changes
- *                        Fix errors on CDROMSTOP (If you have a "Dolphin",
- *                          you must define IHAVEADOLPHIN)
- *                        Added identifier so new Sanyo CD-changer works
- *                        Better detection if door locking isn't supported
- *
- * 4.06  Dec 17, 1997  -- fixed endless "tray open" messages  -ml
- * 4.07  Dec 17, 1997  -- fallback to set pc->stat on "tray open"
- * 4.08  Dec 18, 1997  -- spew less noise when tray is empty
- *                     -- fix speed display for ACER 24X, 18X
- * 4.09  Jan 04, 1998  -- fix handling of the last block so we return
- *                         an end of file instead of an I/O error (Gadi)
- * 4.10  Jan 24, 1998  -- fixed a bug so now changers can change to a new
- *                         slot when there is no disc in the current slot.
- *                     -- Fixed a memory leak where info->changer_info was
- *                         malloc'ed but never free'd when closing the device.
- *                     -- Cleaned up the global namespace a bit by making more
- *                         functions static that should already have been.
- * 4.11  Mar 12, 1998  -- Added support for the CDROM_SELECT_SPEED ioctl
- *                         based on a patch for 2.0.33 by Jelle Foks 
- *                         <jelle@scintilla.utwente.nl>, a patch for 2.0.33
- *                         by Toni Giorgino <toni@pcape2.pi.infn.it>, the SCSI
- *                         version, and my own efforts.  -erik
- *                     -- Fixed a stupid bug which egcs was kind enough to
- *                         inform me of where "Illegal mode for this track"
- *                         was never returned due to a comparison on data
- *                         types of limited range.
- * 4.12  Mar 29, 1998  -- Fixed bug in CDROM_SELECT_SPEED so write speed is 
- *                         now set ionly for CD-R and CD-RW drives.  I had 
- *                         removed this support because it produced errors.
- *                         It produced errors _only_ for non-writers. duh.
- * 4.13  May 05, 1998  -- Suppress useless "in progress of becoming ready"
- *                         messages, since this is not an error.
- *                     -- Change error messages to be const
- *                     -- Remove a "\t" which looks ugly in the syslogs
- * 4.14  July 17, 1998 -- Change to pointing to .ps version of ATAPI spec
- *                         since the .pdf version doesn't seem to work...
- *                     -- Updated the TODO list to something more current.
- *
- * 4.15  Aug 25, 1998  -- Updated ide-cd.h to respect mechine endianess, 
- *                         patch thanks to "Eddie C. Dost" <ecd@skynet.be>
- *
- * 4.50  Oct 19, 1998  -- New maintainers!
- *                         Jens Axboe <axboe@image.dk>
- *                         Chris Zwilling <chris@cloudnet.com>
- *
- * 4.51  Dec 23, 1998  -- Jens Axboe <axboe@image.dk>
- *                      - ide_cdrom_reset enabled since the ide subsystem
- *                         handles resets fine now. <axboe@image.dk>
- *                      - Transfer size fix for Samsung CD-ROMs, thanks to
- *                        "Ville Hallik" <ville.hallik@mail.ee>.
- *                      - other minor stuff.
- *
- * 4.52  Jan 19, 1999  -- Jens Axboe <axboe@image.dk>
- *                      - Detect DVD-ROM/RAM drives
- *
- * 4.53  Feb 22, 1999   - Include other model Samsung and one Goldstar
- *                         drive in transfer size limit.
- *                      - Fix the I/O error when doing eject without a medium
- *                         loaded on some drives.
- *                      - CDROMREADMODE2 is now implemented through
- *                         CDROMREADRAW, since many drives don't support
- *                         MODE2 (even though ATAPI 2.6 says they must).
- *                      - Added ignore parameter to ide-cd (as a module), eg
- *                             insmod ide-cd ignore='hda hdb'
- *                         Useful when using ide-cd in conjunction with
- *                         ide-scsi. TODO: non-modular way of doing the
- *                         same.
- *
- * 4.54  Aug 5, 1999   - Support for MMC2 class commands through the generic
- *                       packet interface to cdrom.c.
- *                     - Unified audio ioctl support, most of it.
- *                     - cleaned up various deprecated verify_area().
- *                     - Added ide_cdrom_packet() as the interface for
- *                       the Uniform generic_packet().
- *                     - bunch of other stuff, will fill in logs later.
- *                     - report 1 slot for non-changers, like the other
- *                       cd-rom drivers. don't report select disc for
- *                       non-changers as well.
- *                     - mask out audio playing, if the device can't do it.
- *
- * 4.55  Sep 1, 1999   - Eliminated the rest of the audio ioctls, except
- *                       for CDROMREADTOC[ENTRY|HEADER]. Some of the drivers
- *                       use this independently of the actual audio handling.
- *                       They will disappear later when I get the time to
- *                       do it cleanly.
- *                     - Minimize the TOC reading - only do it when we
- *                       know a media change has occurred.
- *                     - Moved all the CDROMREADx ioctls to the Uniform layer.
- *                     - Heiko Eißfeldt <heiko@colossus.escape.de> supplied
- *                       some fixes for CDI.
- *                     - CD-ROM leaving door locked fix from Andries
- *                       Brouwer <Andries.Brouwer@cwi.nl>
- *                     - Erik Andersen <andersen@xmission.com> unified
- *                       commands across the various drivers and how
- *                       sense errors are handled.
- *
- * 4.56  Sep 12, 1999  - Removed changer support - it is now in the
- *                       Uniform layer.
- *                     - Added partition based multisession handling.
- *                     - Mode sense and mode select moved to the
- *                       Uniform layer.
- *                     - Fixed a problem with WPI CDS-32X drive - it
- *                       failed the capabilities 
- *
- * 4.57  Apr 7, 2000   - Fixed sense reporting.
- *                     - Fixed possible oops in ide_cdrom_get_last_session()
- *                     - Fix locking mania and make ide_cdrom_reset relock
- *                     - Stop spewing errors to log when magicdev polls with
- *                       TEST_UNIT_READY on some drives.
- *                     - Various fixes from Tobias Ringstrom:
- *                       tray if it was locked prior to the reset.
- *                       - cdrom_read_capacity returns one frame too little.
- *                       - Fix real capacity reporting.
- *
- * 4.58  May 1, 2000   - Clean up ACER50 stuff.
- *                     - Fix small problem with ide_cdrom_capacity
- *
- * 4.59  Aug 11, 2000  - Fix changer problem in cdrom_read_toc, we weren't
- *                       correctly sensing a disc change.
- *                     - Rearranged some code
- *                     - Use extended sense on drives that support it for
- *                       correctly reporting tray status -- from
- *                       Michael D Johnson <johnsom@orst.edu>
- * 4.60  Dec 17, 2003  - Add mt rainier support
- *                     - Bump timeout for packet commands, matches sr
- *                     - Odd stuff
- * 4.61  Jan 22, 2004  - support hardware sector sizes other than 2kB,
- *                       Pascal Schmidt <der.eremit@email.de>
- *
- *************************************************************************/
+ * For historical changelog please see:
+ *     Documentation/ide/ChangeLog.ide-cd.1994-2004
+ */
+
 #define IDECD_VERSION "4.61"
 
 #include <linux/module.h>
@@ -655,9 +388,9 @@ static void cdrom_end_request (ide_drive_t *drive, int uptodate)
                                        BUG();
                        } else {
                                spin_lock_irqsave(&ide_lock, flags);
-                               end_that_request_chunk(failed, 0,
-                                                       failed->data_len);
-                               end_that_request_last(failed, 0);
+                               if (__blk_end_request(failed, -EIO,
+                                                     failed->data_len))
+                                       BUG();
                                spin_unlock_irqrestore(&ide_lock, flags);
                        }
                } else
@@ -917,19 +650,13 @@ static ide_startstop_t cdrom_start_packet_command(ide_drive_t *drive,
        if (ide_wait_stat(&startstop, drive, 0, BUSY_STAT, WAIT_READY))
                return startstop;
 
+       /* FIXME: for Virtual DMA we must check harder */
        if (info->dma)
                info->dma = !hwif->dma_setup(drive);
 
        /* Set up the controller registers. */
-       /* FIXME: for Virtual DMA we must check harder */
-       HWIF(drive)->OUTB(info->dma, IDE_FEATURE_REG);
-       HWIF(drive)->OUTB(0, IDE_IREASON_REG);
-       HWIF(drive)->OUTB(0, IDE_SECTOR_REG);
-
-       HWIF(drive)->OUTB(xferlen & 0xff, IDE_BCOUNTL_REG);
-       HWIF(drive)->OUTB(xferlen >> 8  , IDE_BCOUNTH_REG);
-       if (IDE_CONTROL_REG)
-               HWIF(drive)->OUTB(drive->ctl, IDE_CONTROL_REG);
+       ide_pktcmd_tf_load(drive, IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL |
+                          IDE_TFLAG_NO_SELECT_MASK, xferlen, info->dma);
  
        if (CDROM_CONFIG_FLAGS (drive)->drq_interrupt) {
                /* waiting for CDB interrupt, not DMA yet. */
@@ -957,10 +684,6 @@ static ide_startstop_t cdrom_start_packet_command(ide_drive_t *drive,
    by cdrom_start_packet_command.
    HANDLER is the interrupt handler to call when the command completes
    or there's data ready. */
-/*
- * changed 5 parameters to 3 for dvd-ram
- * struct packet_command *pc; now packet_command_t *pc;
- */
 #define ATAPI_MIN_CDB_BYTES 12
 static ide_startstop_t cdrom_transfer_packet_command (ide_drive_t *drive,
                                          struct request *rq,
@@ -1011,6 +734,17 @@ static ide_startstop_t cdrom_transfer_packet_command (ide_drive_t *drive,
  * Block read functions.
  */
 
+typedef void (xfer_func_t)(ide_drive_t *, void *, u32);
+
+static void ide_cd_pad_transfer(ide_drive_t *drive, xfer_func_t *xf, int len)
+{
+       while (len > 0) {
+               int dum = 0;
+               xf(drive, &dum, sizeof(dum));
+               len -= sizeof(dum);
+       }
+}
+
 /*
  * Buffer up to SECTORS_TO_TRANSFER sectors from the drive in our sector
  * buffer.  Once the first sector is added, any subsequent sectors are
@@ -1067,17 +801,15 @@ int cdrom_read_check_ireason (ide_drive_t *drive, int len, int ireason)
        if (ireason == 2)
                return 0;
        else if (ireason == 0) {
+               ide_hwif_t *hwif = drive->hwif;
+
                /* Whoops... The drive is expecting to receive data from us! */
-               printk(KERN_ERR "%s: read_intr: Drive wants to transfer data the "
-                                               "wrong way!\n", drive->name);
+               printk(KERN_ERR "%s: %s: wrong transfer direction!\n",
+                               drive->name, __FUNCTION__);
 
                /* Throw some data at the drive so it doesn't hang
                   and quit this request. */
-               while (len > 0) {
-                       int dum = 0;
-                       HWIF(drive)->atapi_output_bytes(drive, &dum, sizeof (dum));
-                       len -= sizeof (dum);
-               }
+               ide_cd_pad_transfer(drive, hwif->atapi_output_bytes, len);
        } else  if (ireason == 1) {
                /* Some drives (ASUS) seem to tell us that status
                 * info is available. just get it and ignore.
@@ -1086,8 +818,8 @@ int cdrom_read_check_ireason (ide_drive_t *drive, int len, int ireason)
                return 0;
        } else {
                /* Drive wants a command packet, or invalid ireason... */
-               printk(KERN_ERR "%s: read_intr: bad interrupt reason %x\n", drive->name,
-                                                               ireason);
+               printk(KERN_ERR "%s: %s: bad interrupt reason 0x%02x\n",
+                               drive->name, __FUNCTION__, ireason);
        }
 
        cdrom_end_request(drive, 0);
@@ -1112,8 +844,11 @@ static ide_startstop_t cdrom_read_intr (ide_drive_t *drive)
         */
        if (dma) {
                info->dma = 0;
-               if ((dma_error = HWIF(drive)->ide_dma_end(drive)))
+               dma_error = HWIF(drive)->ide_dma_end(drive);
+               if (dma_error) {
+                       printk(KERN_ERR "%s: DMA read error\n", drive->name);
                        ide_dma_off(drive);
+               }
        }
 
        if (cdrom_decode_status(drive, 0, &stat))
@@ -1433,17 +1168,17 @@ static ide_startstop_t cdrom_start_read (ide_drive_t *drive, unsigned int block)
 /* Interrupt routine for packet command completion. */
 static ide_startstop_t cdrom_pc_intr (ide_drive_t *drive)
 {
-       int ireason, len, thislen;
        struct request *rq = HWGROUP(drive)->rq;
+       xfer_func_t *xferfunc = NULL;
+       int stat, ireason, len, thislen, write;
        u8 lowcyl = 0, highcyl = 0;
-       int stat;
 
        /* Check for errors. */
        if (cdrom_decode_status(drive, 0, &stat))
                return ide_stopped;
 
        /* Read the interrupt reason and the transfer length. */
-       ireason = HWIF(drive)->INB(IDE_IREASON_REG);
+       ireason = HWIF(drive)->INB(IDE_IREASON_REG) & 0x3;
        lowcyl  = HWIF(drive)->INB(IDE_BCOUNTL_REG);
        highcyl = HWIF(drive)->INB(IDE_BCOUNTH_REG);
 
@@ -1466,13 +1201,6 @@ static ide_startstop_t cdrom_pc_intr (ide_drive_t *drive)
                if (rq->data_len == 0)
                        cdrom_end_request(drive, 1);
                else {
-                       /* Comment this out, because this always happens 
-                          right after a reset occurs, and it is annoying to 
-                          always print expected stuff.  */
-                       /*
-                       printk ("%s: cdrom_pc_intr: data underrun %d\n",
-                               drive->name, pc->buflen);
-                       */
                        rq->cmd_flags |= REQ_FAILED;
                        cdrom_end_request(drive, 0);
                }
@@ -1481,55 +1209,36 @@ static ide_startstop_t cdrom_pc_intr (ide_drive_t *drive)
 
        /* Figure out how much data to transfer. */
        thislen = rq->data_len;
-       if (thislen > len) thislen = len;
-
-       /* The drive wants to be written to. */
-       if ((ireason & 3) == 0) {
-               if (!rq->data) {
-                       blk_dump_rq_flags(rq, "cdrom_pc_intr, write");
-                       goto confused;
-               }
-               /* Transfer the data. */
-               HWIF(drive)->atapi_output_bytes(drive, rq->data, thislen);
-
-               /* If we haven't moved enough data to satisfy the drive,
-                  add some padding. */
-               while (len > thislen) {
-                       int dum = 0;
-                       HWIF(drive)->atapi_output_bytes(drive, &dum, sizeof(dum));
-                       len -= sizeof(dum);
-               }
+       if (thislen > len)
+               thislen = len;
 
-               /* Keep count of how much data we've moved. */
-               rq->data += thislen;
-               rq->data_len -= thislen;
+       if (ireason == 0) {
+               write = 1;
+               xferfunc = HWIF(drive)->atapi_output_bytes;
+       } else if (ireason == 2) {
+               write = 0;
+               xferfunc = HWIF(drive)->atapi_input_bytes;
        }
 
-       /* Same drill for reading. */
-       else if ((ireason & 3) == 2) {
+       if (xferfunc) {
                if (!rq->data) {
-                       blk_dump_rq_flags(rq, "cdrom_pc_intr, write");
-                       goto confused;
+                       printk(KERN_ERR "%s: confused, missing data\n",
+                                       drive->name);
+                       blk_dump_rq_flags(rq, write ? "cdrom_pc_intr, write"
+                                                   : "cdrom_pc_intr, read");
+                       goto pad;
                }
                /* Transfer the data. */
-               HWIF(drive)->atapi_input_bytes(drive, rq->data, thislen);
-
-               /* If we haven't moved enough data to satisfy the drive,
-                  add some padding. */
-               while (len > thislen) {
-                       int dum = 0;
-                       HWIF(drive)->atapi_input_bytes(drive, &dum, sizeof(dum));
-                       len -= sizeof(dum);
-               }
+               xferfunc(drive, rq->data, thislen);
 
                /* Keep count of how much data we've moved. */
+               len -= thislen;
                rq->data += thislen;
                rq->data_len -= thislen;
 
-               if (blk_sense_request(rq))
+               if (write && blk_sense_request(rq))
                        rq->sense_len += thislen;
        } else {
-confused:
                printk (KERN_ERR "%s: cdrom_pc_intr: The drive "
                        "appears confused (ireason = 0x%02x). "
                        "Trying to recover by ending request.\n",
@@ -1538,6 +1247,13 @@ confused:
                cdrom_end_request(drive, 0);
                return ide_stopped;
        }
+pad:
+       /*
+        * If we haven't moved enough data to satisfy the drive,
+        * add some padding.
+        */
+       if (len > 0)
+               ide_cd_pad_transfer(drive, xferfunc, len);
 
        /* Now we wait for another interrupt. */
        ide_set_handler(drive, &cdrom_pc_intr, ATAPI_WAIT_PC, cdrom_timer_expiry);
@@ -1631,26 +1347,33 @@ static int cdrom_write_check_ireason(ide_drive_t *drive, int len, int ireason)
        if (ireason == 0)
                return 0;
        else if (ireason == 2) {
+               ide_hwif_t *hwif = drive->hwif;
+
                /* Whoops... The drive wants to send data. */
-               printk(KERN_ERR "%s: write_intr: wrong transfer direction!\n",
-                                                       drive->name);
+               printk(KERN_ERR "%s: %s: wrong transfer direction!\n",
+                               drive->name, __FUNCTION__);
 
-               while (len > 0) {
-                       int dum = 0;
-                       HWIF(drive)->atapi_input_bytes(drive, &dum, sizeof(dum));
-                       len -= sizeof(dum);
-               }
+               ide_cd_pad_transfer(drive, hwif->atapi_input_bytes, len);
        } else {
                /* Drive wants a command packet, or invalid ireason... */
-               printk(KERN_ERR "%s: write_intr: bad interrupt reason %x\n",
-                                                       drive->name, ireason);
+               printk(KERN_ERR "%s: %s: bad interrupt reason 0x%02x\n",
+                               drive->name, __FUNCTION__, ireason);
        }
 
        cdrom_end_request(drive, 0);
        return 1;
 }
 
-typedef void (xfer_func_t)(ide_drive_t *, void *, u32);
+/*
+ * Called from blk_end_request_callback() after the data of the request
+ * is completed and before the request is completed.
+ * By returning value '1', blk_end_request_callback() returns immediately
+ * without completing the request.
+ */
+static int cdrom_newpc_intr_dummy_cb(struct request *rq)
+{
+       return 1;
+}
 
 /*
  * best way to deal with dma that is not sector aligned right now... note
@@ -1673,6 +1396,11 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
        if (dma) {
                info->dma = 0;
                dma_error = HWIF(drive)->ide_dma_end(drive);
+               if (dma_error) {
+                       printk(KERN_ERR "%s: DMA %s error\n", drive->name,
+                                       rq_data_dir(rq) ? "write" : "read");
+                       ide_dma_off(drive);
+               }
        }
 
        if (cdrom_decode_status(drive, 0, &stat))
@@ -1682,15 +1410,16 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
         * using dma, transfer is complete now
         */
        if (dma) {
-               if (dma_error) {
-                       printk(KERN_ERR "ide-cd: dma error\n");
-                       ide_dma_off(drive);
+               if (dma_error)
                        return ide_error(drive, "dma error", stat);
-               }
 
-               end_that_request_chunk(rq, 1, rq->data_len);
-               rq->data_len = 0;
-               goto end_request;
+               spin_lock_irqsave(&ide_lock, flags);
+               if (__blk_end_request(rq, 0, rq->data_len))
+                       BUG();
+               HWGROUP(drive)->rq = NULL;
+               spin_unlock_irqrestore(&ide_lock, flags);
+
+               return ide_stopped;
        }
 
        /*
@@ -1708,8 +1437,15 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
        /*
         * If DRQ is clear, the command has completed.
         */
-       if ((stat & DRQ_STAT) == 0)
-               goto end_request;
+       if ((stat & DRQ_STAT) == 0) {
+               spin_lock_irqsave(&ide_lock, flags);
+               if (__blk_end_request(rq, 0, rq->data_len))
+                       BUG();
+               HWGROUP(drive)->rq = NULL;
+               spin_unlock_irqrestore(&ide_lock, flags);
+
+               return ide_stopped;
+       }
 
        /*
         * check which way to transfer data
@@ -1762,7 +1498,14 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
                rq->data_len -= blen;
 
                if (rq->bio)
-                       end_that_request_chunk(rq, 1, blen);
+                       /*
+                        * The request can't be completed until DRQ is cleared.
+                        * So complete the data, but don't complete the request
+                        * using the dummy function for the callback feature
+                        * of blk_end_request_callback().
+                        */
+                       blk_end_request_callback(rq, 0, blen,
+                                                cdrom_newpc_intr_dummy_cb);
                else
                        rq->data += blen;
        }
@@ -1770,27 +1513,13 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
        /*
         * pad, if necessary
         */
-       if (len > 0) {
-               while (len > 0) {
-                       int pad = 0;
-
-                       xferfunc(drive, &pad, sizeof(pad));
-                       len -= sizeof(pad);
-               }
-       }
+       if (len > 0)
+               ide_cd_pad_transfer(drive, xferfunc, len);
 
        BUG_ON(HWGROUP(drive)->handler != NULL);
 
        ide_set_handler(drive, cdrom_newpc_intr, rq->timeout, NULL);
        return ide_started;
-
-end_request:
-       spin_lock_irqsave(&ide_lock, flags);
-       blkdev_dequeue_request(rq);
-       end_that_request_last(rq, 1);
-       HWGROUP(drive)->rq = NULL;
-       spin_unlock_irqrestore(&ide_lock, flags);
-       return ide_stopped;
 }
 
 static ide_startstop_t cdrom_write_intr(ide_drive_t *drive)
@@ -1805,8 +1534,9 @@ static ide_startstop_t cdrom_write_intr(ide_drive_t *drive)
        /* Check for errors. */
        if (dma) {
                info->dma = 0;
-               if ((dma_error = HWIF(drive)->ide_dma_end(drive))) {
-                       printk(KERN_ERR "ide-cd: write dma error\n");
+               dma_error = HWIF(drive)->ide_dma_end(drive);
+               if (dma_error) {
+                       printk(KERN_ERR "%s: DMA write error\n", drive->name);
                        ide_dma_off(drive);
                }
        }
@@ -1826,7 +1556,7 @@ static ide_startstop_t cdrom_write_intr(ide_drive_t *drive)
        }
 
        /* Read the interrupt reason and the transfer length. */
-       ireason = HWIF(drive)->INB(IDE_IREASON_REG);
+       ireason = HWIF(drive)->INB(IDE_IREASON_REG) & 0x3;
        lowcyl  = HWIF(drive)->INB(IDE_BCOUNTL_REG);
        highcyl = HWIF(drive)->INB(IDE_BCOUNTH_REG);
 
@@ -1839,8 +1569,9 @@ static ide_startstop_t cdrom_write_intr(ide_drive_t *drive)
                 */
                uptodate = 1;
                if (rq->current_nr_sectors > 0) {
-                       printk(KERN_ERR "%s: write_intr: data underrun (%d blocks)\n",
-                       drive->name, rq->current_nr_sectors);
+                       printk(KERN_ERR "%s: %s: data underrun (%d blocks)\n",
+                                       drive->name, __FUNCTION__,
+                                       rq->current_nr_sectors);
                        uptodate = 0;
                }
                cdrom_end_request(drive, uptodate);
@@ -1860,7 +1591,8 @@ static ide_startstop_t cdrom_write_intr(ide_drive_t *drive)
                int this_transfer;
 
                if (!rq->current_nr_sectors) {
-                       printk(KERN_ERR "ide-cd: write_intr: oops\n");
+                       printk(KERN_ERR "%s: %s: confused, missing data\n",
+                                       drive->name, __FUNCTION__);
                        break;
                }
 
@@ -2684,19 +2416,20 @@ int ide_cdrom_get_capabilities(ide_drive_t *drive, struct atapi_capabilities_pag
 static
 void ide_cdrom_update_speed (ide_drive_t *drive, struct atapi_capabilities_page *cap)
 {
+       u16 curspeed, maxspeed;
+
        /* The ACER/AOpen 24X cdrom has the speed fields byte-swapped */
        if (!drive->id->model[0] &&
            !strncmp(drive->id->fw_rev, "241N", 4)) {
-               CDROM_STATE_FLAGS(drive)->current_speed  =
-                       (((unsigned int)cap->curspeed) + (176/2)) / 176;
-               CDROM_CONFIG_FLAGS(drive)->max_speed =
-                       (((unsigned int)cap->maxspeed) + (176/2)) / 176;
+               curspeed = le16_to_cpu(cap->curspeed);
+               maxspeed = le16_to_cpu(cap->maxspeed);
        } else {
-               CDROM_STATE_FLAGS(drive)->current_speed  =
-                       (ntohs(cap->curspeed) + (176/2)) / 176;
-               CDROM_CONFIG_FLAGS(drive)->max_speed =
-                       (ntohs(cap->maxspeed) + (176/2)) / 176;
+               curspeed = be16_to_cpu(cap->curspeed);
+               maxspeed = be16_to_cpu(cap->maxspeed);
        }
+
+       CDROM_STATE_FLAGS(drive)->current_speed = (curspeed + (176/2)) / 176;
+       CDROM_CONFIG_FLAGS(drive)->max_speed = (maxspeed + (176/2)) / 176;
 }
 
 static
@@ -2909,6 +2642,9 @@ static int ide_cdrom_register (ide_drive_t *drive, int nslots)
        if (!CDROM_CONFIG_FLAGS(drive)->ram)
                devinfo->mask |= CDC_RAM;
 
+       if (CDROM_CONFIG_FLAGS(drive)->no_speed_select)
+               devinfo->mask |= CDC_SELECT_SPEED;
+
        devinfo->disk = info->disk;
        return register_cdrom(devinfo);
 }
@@ -2958,8 +2694,6 @@ int ide_cdrom_probe_capabilities (ide_drive_t *drive)
                CDROM_CONFIG_FLAGS(drive)->cd_rw = 1;
                CDROM_CONFIG_FLAGS(drive)->ram = 1;
        }
-       if (cap.test_write)
-               CDROM_CONFIG_FLAGS(drive)->test_write = 1;
        if (cap.dvd_ram_read || cap.dvd_r_read || cap.dvd_rom)
                CDROM_CONFIG_FLAGS(drive)->dvd = 1;
        if (cap.dvd_ram_write) {
@@ -2992,10 +2726,9 @@ int ide_cdrom_probe_capabilities (ide_drive_t *drive)
 #endif /* not STANDARD_ATAPI */
        if (cap.mechtype == mechtype_individual_changer ||
            cap.mechtype == mechtype_cartridge_changer) {
-               if ((nslots = cdrom_number_of_slots(cdi)) > 1) {
+               nslots = cdrom_number_of_slots(cdi);
+               if (nslots > 1)
                        CDROM_CONFIG_FLAGS(drive)->is_changer = 1;
-                       CDROM_CONFIG_FLAGS(drive)->supp_disc_present = 1;
-               }
        }
 
        ide_cdrom_update_speed(drive, &cap);
@@ -3130,30 +2863,16 @@ int ide_cdrom_setup (ide_drive_t *drive)
        drive->special.all      = 0;
 
        CDROM_STATE_FLAGS(drive)->media_changed = 1;
-       CDROM_STATE_FLAGS(drive)->toc_valid     = 0;
-       CDROM_STATE_FLAGS(drive)->door_locked   = 0;
 
 #if NO_DOOR_LOCKING
        CDROM_CONFIG_FLAGS(drive)->no_doorlock = 1;
-#else
-       CDROM_CONFIG_FLAGS(drive)->no_doorlock = 0;
 #endif
-
-       CDROM_CONFIG_FLAGS(drive)->drq_interrupt = ((drive->id->config & 0x0060) == 0x20);
-       CDROM_CONFIG_FLAGS(drive)->is_changer = 0;
-       CDROM_CONFIG_FLAGS(drive)->cd_r = 0;
-       CDROM_CONFIG_FLAGS(drive)->cd_rw = 0;
-       CDROM_CONFIG_FLAGS(drive)->test_write = 0;
-       CDROM_CONFIG_FLAGS(drive)->dvd = 0;
-       CDROM_CONFIG_FLAGS(drive)->dvd_r = 0;
-       CDROM_CONFIG_FLAGS(drive)->dvd_ram = 0;
+       if ((drive->id->config & 0x0060) == 0x20)
+               CDROM_CONFIG_FLAGS(drive)->drq_interrupt = 1;
        CDROM_CONFIG_FLAGS(drive)->no_eject = 1;
-       CDROM_CONFIG_FLAGS(drive)->supp_disc_present = 0;
-       CDROM_CONFIG_FLAGS(drive)->audio_play = 0;
        CDROM_CONFIG_FLAGS(drive)->close_tray = 1;
-       
+
        /* limit transfer size per interrupt. */
-       CDROM_CONFIG_FLAGS(drive)->limit_nframes = 0;
        /* a testament to the nice quality of Samsung drives... */
        if (!strcmp(drive->id->model, "SAMSUNG CD-ROM SCR-2430"))
                CDROM_CONFIG_FLAGS(drive)->limit_nframes = 1;
@@ -3161,19 +2880,9 @@ int ide_cdrom_setup (ide_drive_t *drive)
                CDROM_CONFIG_FLAGS(drive)->limit_nframes = 1;
        /* the 3231 model does not support the SET_CD_SPEED command */
        else if (!strcmp(drive->id->model, "SAMSUNG CD-ROM SCR-3231"))
-               cdi->mask |= CDC_SELECT_SPEED;
+               CDROM_CONFIG_FLAGS(drive)->no_speed_select = 1;
 
 #if ! STANDARD_ATAPI
-       /* by default Sanyo 3 CD changer support is turned off and
-           ATAPI Rev 2.2+ standard support for CD changers is used */
-       cdi->sanyo_slot = 0;
-
-       CDROM_CONFIG_FLAGS(drive)->nec260 = 0;
-       CDROM_CONFIG_FLAGS(drive)->toctracks_as_bcd = 0;
-       CDROM_CONFIG_FLAGS(drive)->tocaddr_as_bcd = 0;
-       CDROM_CONFIG_FLAGS(drive)->playmsf_as_bcd = 0;
-       CDROM_CONFIG_FLAGS(drive)->subchan_as_bcd = 0;
-
        if (strcmp (drive->id->model, "V003S0DS") == 0 &&
            drive->id->fw_rev[4] == '1' &&
            drive->id->fw_rev[6] <= '2') {
@@ -3181,10 +2890,7 @@ int ide_cdrom_setup (ide_drive_t *drive)
                   Some versions of this drive like to talk BCD. */
                CDROM_CONFIG_FLAGS(drive)->toctracks_as_bcd = 1;
                CDROM_CONFIG_FLAGS(drive)->tocaddr_as_bcd = 1;
-               CDROM_CONFIG_FLAGS(drive)->playmsf_as_bcd = 1;
-               CDROM_CONFIG_FLAGS(drive)->subchan_as_bcd = 1;
        }
-
        else if (strcmp (drive->id->model, "V006E0DS") == 0 &&
            drive->id->fw_rev[4] == '1' &&
            drive->id->fw_rev[6] <= '2') {
@@ -3197,18 +2903,12 @@ int ide_cdrom_setup (ide_drive_t *drive)
                   This drive was released before the 1.2 version
                   of the spec. */
                CDROM_CONFIG_FLAGS(drive)->tocaddr_as_bcd = 1;
-               CDROM_CONFIG_FLAGS(drive)->playmsf_as_bcd = 1;
-               CDROM_CONFIG_FLAGS(drive)->subchan_as_bcd = 1;
                CDROM_CONFIG_FLAGS(drive)->nec260         = 1;
        }
-       else if (strcmp(drive->id->model, "WEARNES CDD-120") == 0 &&
-                strncmp(drive->id->fw_rev, "A1.1", 4) == 0) { /* FIXME */
-               /* Wearnes */
-               CDROM_CONFIG_FLAGS(drive)->playmsf_as_bcd = 1;
-               CDROM_CONFIG_FLAGS(drive)->subchan_as_bcd = 1;
-       }
-        /* Sanyo 3 CD changer uses a non-standard command
-           for CD changing */
+       /*
+        * Sanyo 3 CD changer uses a non-standard command for CD changing
+        * (by default standard ATAPI support for CD changers is used).
+        */
         else if ((strcmp(drive->id->model, "CD-ROM CDR-C3 G") == 0) ||
                  (strcmp(drive->id->model, "CD-ROM CDR-C3G") == 0) ||
                  (strcmp(drive->id->model, "CD-ROM CDR_C36") == 0)) {
@@ -3217,14 +2917,6 @@ int ide_cdrom_setup (ide_drive_t *drive)
         }
 #endif /* not STANDARD_ATAPI */
 
-       info->toc               = NULL;
-       info->buffer            = NULL;
-       info->sector_buffered   = 0;
-       info->nsectors_buffered = 0;
-       info->changer_info      = NULL;
-       info->last_block        = 0;
-       info->start_seek        = 0;
-
        nslots = ide_cdrom_probe_capabilities (drive);
 
        /*
@@ -3278,7 +2970,6 @@ static void ide_cd_release(struct kref *kref)
 
        kfree(info->buffer);
        kfree(info->toc);
-       kfree(info->changer_info);
        if (devinfo->handle == drive && unregister_cdrom(devinfo))
                printk(KERN_ERR "%s: %s failed to unregister device from the cdrom "
                                "driver.\n", __FUNCTION__, drive->name);
@@ -3504,15 +3195,8 @@ static int ide_cd_probe(ide_drive_t *drive)
        g->driverfs_dev = &drive->gendev;
        g->flags = GENHD_FL_CD | GENHD_FL_REMOVABLE;
        if (ide_cdrom_setup(drive)) {
-               struct cdrom_device_info *devinfo = &info->devinfo;
                ide_proc_unregister_driver(drive, &ide_cdrom_driver);
-               kfree(info->buffer);
-               kfree(info->toc);
-               kfree(info->changer_info);
-               if (devinfo->handle == drive && unregister_cdrom(devinfo))
-                       printk (KERN_ERR "%s: ide_cdrom_cleanup failed to unregister device from the cdrom driver.\n", drive->name);
-               kfree(info);
-               drive->driver_data = NULL;
+               ide_cd_release(&info->kref);
                goto failed;
        }