]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/net/wireless/libertas/assoc.c
libertas: convert GET_LOG to a direct command
[linux-2.6-omap-h63xx.git] / drivers / net / wireless / libertas / assoc.c
index b61b176e9d07a9e234f41444db7c618030772bb4..95d98203eb4ebdccbf9936b7a29a745a8715161e 100644 (file)
@@ -9,39 +9,18 @@
 #include "decl.h"
 #include "hostcmd.h"
 #include "host.h"
+#include "cmd.h"
 
 
-static const u8 bssid_any[ETH_ALEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
-static const u8 bssid_off[ETH_ALEN] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
-
-static void print_assoc_req(const char * extra, struct assoc_request * assoc_req)
-{
-       DECLARE_MAC_BUF(mac);
-       lbs_deb_assoc(
-              "#### Association Request: %s\n"
-              "       flags:      0x%08lX\n"
-              "       SSID:       '%s'\n"
-              "       channel:    %d\n"
-              "       band:       %d\n"
-              "       mode:       %d\n"
-              "       BSSID:      %s\n"
-              "       Encryption:%s%s%s\n"
-              "       auth:       %d\n",
-              extra, assoc_req->flags,
-              escape_essid(assoc_req->ssid, assoc_req->ssid_len),
-              assoc_req->channel, assoc_req->band, assoc_req->mode,
-              print_mac(mac, assoc_req->bssid),
-              assoc_req->secinfo.WPAenabled ? " WPA" : "",
-              assoc_req->secinfo.WPA2enabled ? " WPA2" : "",
-              assoc_req->secinfo.wep_enabled ? " WEP" : "",
-              assoc_req->secinfo.auth_mode);
-}
+static const u8 bssid_any[ETH_ALEN]  __attribute__ ((aligned (2))) =
+       { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
+static const u8 bssid_off[ETH_ALEN]  __attribute__ ((aligned (2))) =
+       { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
 
 
-static int assoc_helper_essid(wlan_private *priv,
+static int assoc_helper_essid(struct lbs_private *priv,
                               struct assoc_request * assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
        struct bss_descriptor * bss;
        int channel = -1;
@@ -55,18 +34,17 @@ static int assoc_helper_essid(wlan_private *priv,
        if (test_bit(ASSOC_FLAG_CHANNEL, &assoc_req->flags))
                channel = assoc_req->channel;
 
-       lbs_deb_assoc("New SSID requested: '%s'\n",
+       lbs_deb_assoc("SSID '%s' requested\n",
                      escape_essid(assoc_req->ssid, assoc_req->ssid_len));
        if (assoc_req->mode == IW_MODE_INFRA) {
-               libertas_send_specific_ssid_scan(priv, assoc_req->ssid,
-                       assoc_req->ssid_len, 0);
+               lbs_send_specific_ssid_scan(priv, assoc_req->ssid,
+                       assoc_req->ssid_len);
 
-               bss = libertas_find_ssid_in_list(adapter, assoc_req->ssid,
+               bss = lbs_find_ssid_in_list(priv, assoc_req->ssid,
                                assoc_req->ssid_len, NULL, IW_MODE_INFRA, channel);
                if (bss != NULL) {
-                       lbs_deb_assoc("SSID found in scan list, associating\n");
                        memcpy(&assoc_req->bss, bss, sizeof(struct bss_descriptor));
-                       ret = wlan_associate(priv, assoc_req);
+                       ret = lbs_associate(priv, assoc_req);
                } else {
                        lbs_deb_assoc("SSID not found; cannot associate\n");
                }
@@ -74,23 +52,23 @@ static int assoc_helper_essid(wlan_private *priv,
                /* Scan for the network, do not save previous results.  Stale
                 *   scan data will cause us to join a non-existant adhoc network
                 */
-               libertas_send_specific_ssid_scan(priv, assoc_req->ssid,
-                       assoc_req->ssid_len, 1);
+               lbs_send_specific_ssid_scan(priv, assoc_req->ssid,
+                       assoc_req->ssid_len);
 
                /* Search for the requested SSID in the scan table */
-               bss = libertas_find_ssid_in_list(adapter, assoc_req->ssid,
+               bss = lbs_find_ssid_in_list(priv, assoc_req->ssid,
                                assoc_req->ssid_len, NULL, IW_MODE_ADHOC, channel);
                if (bss != NULL) {
                        lbs_deb_assoc("SSID found, will join\n");
                        memcpy(&assoc_req->bss, bss, sizeof(struct bss_descriptor));
-                       libertas_join_adhoc_network(priv, assoc_req);
+                       lbs_join_adhoc_network(priv, assoc_req);
                } else {
                        /* else send START command */
                        lbs_deb_assoc("SSID not found, creating adhoc network\n");
                        memcpy(&assoc_req->bss.ssid, &assoc_req->ssid,
                                IW_ESSID_MAX_SIZE);
                        assoc_req->bss.ssid_len = assoc_req->ssid_len;
-                       libertas_start_adhoc_network(priv, assoc_req);
+                       lbs_start_adhoc_network(priv, assoc_req);
                }
        }
 
@@ -99,10 +77,9 @@ static int assoc_helper_essid(wlan_private *priv,
 }
 
 
-static int assoc_helper_bssid(wlan_private *priv,
+static int assoc_helper_bssid(struct lbs_private *priv,
                               struct assoc_request * assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
        struct bss_descriptor * bss;
        DECLARE_MAC_BUF(mac);
@@ -111,7 +88,7 @@ static int assoc_helper_bssid(wlan_private *priv,
                print_mac(mac, assoc_req->bssid));
 
        /* Search for index position in list for requested MAC */
-       bss = libertas_find_bssid_in_list(adapter, assoc_req->bssid,
+       bss = lbs_find_bssid_in_list(priv, assoc_req->bssid,
                            assoc_req->mode);
        if (bss == NULL) {
                lbs_deb_assoc("ASSOC: WAP: BSSID %s not found, "
@@ -121,10 +98,10 @@ static int assoc_helper_bssid(wlan_private *priv,
 
        memcpy(&assoc_req->bss, bss, sizeof(struct bss_descriptor));
        if (assoc_req->mode == IW_MODE_INFRA) {
-               ret = wlan_associate(priv, assoc_req);
-               lbs_deb_assoc("ASSOC: wlan_associate(bssid) returned %d\n", ret);
+               ret = lbs_associate(priv, assoc_req);
+               lbs_deb_assoc("ASSOC: lbs_associate(bssid) returned %d\n", ret);
        } else if (assoc_req->mode == IW_MODE_ADHOC) {
-               libertas_join_adhoc_network(priv, assoc_req);
+               lbs_join_adhoc_network(priv, assoc_req);
        }
 
 out:
@@ -133,11 +110,13 @@ out:
 }
 
 
-static int assoc_helper_associate(wlan_private *priv,
+static int assoc_helper_associate(struct lbs_private *priv,
                                   struct assoc_request * assoc_req)
 {
        int ret = 0, done = 0;
 
+       lbs_deb_enter(LBS_DEB_ASSOC);
+
        /* If we're given and 'any' BSSID, try associating based on SSID */
 
        if (test_bit(ASSOC_FLAG_BSSID, &assoc_req->flags)) {
@@ -145,42 +124,36 @@ static int assoc_helper_associate(wlan_private *priv,
                    && compare_ether_addr(bssid_off, assoc_req->bssid)) {
                        ret = assoc_helper_bssid(priv, assoc_req);
                        done = 1;
-                       if (ret) {
-                               lbs_deb_assoc("ASSOC: bssid: ret = %d\n", ret);
-                       }
                }
        }
 
        if (!done && test_bit(ASSOC_FLAG_SSID, &assoc_req->flags)) {
                ret = assoc_helper_essid(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC: bssid: ret = %d\n", ret);
-               }
        }
 
+       lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
        return ret;
 }
 
 
-static int assoc_helper_mode(wlan_private *priv,
+static int assoc_helper_mode(struct lbs_private *priv,
                              struct assoc_request * assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_ASSOC);
 
-       if (assoc_req->mode == adapter->mode)
+       if (assoc_req->mode == priv->mode)
                goto done;
 
        if (assoc_req->mode == IW_MODE_INFRA) {
-               if (adapter->psstate != PS_STATE_FULL_POWER)
-                       libertas_ps_wakeup(priv, CMD_OPTION_WAITFORRSP);
-               adapter->psmode = WLAN802_11POWERMODECAM;
+               if (priv->psstate != PS_STATE_FULL_POWER)
+                       lbs_ps_wakeup(priv, CMD_OPTION_WAITFORRSP);
+               priv->psmode = LBS802_11POWERMODECAM;
        }
 
-       adapter->mode = assoc_req->mode;
-       ret = libertas_prepare_and_send_command(priv,
+       priv->mode = assoc_req->mode;
+       ret = lbs_prepare_and_send_command(priv,
                                    CMD_802_11_SNMP_MIB,
                                    0, CMD_OPTION_WAITFORRSP,
                                    OID_802_11_INFRASTRUCTURE_MODE,
@@ -192,57 +165,65 @@ done:
 }
 
 
-static int update_channel(wlan_private * priv)
+int lbs_update_channel(struct lbs_private *priv)
 {
-       /* the channel in f/w could be out of sync, get the current channel */
-       return libertas_prepare_and_send_command(priv, CMD_802_11_RF_CHANNEL,
-                                   CMD_OPT_802_11_RF_CHANNEL_GET,
-                                   CMD_OPTION_WAITFORRSP, 0, NULL);
-}
+       int ret;
 
-void libertas_sync_channel(struct work_struct *work)
-{
-       wlan_private *priv = container_of(work, wlan_private, sync_channel);
+       /* the channel in f/w could be out of sync; get the current channel */
+       lbs_deb_enter(LBS_DEB_ASSOC);
 
-       if (update_channel(priv) != 0)
-               lbs_pr_info("Channel synchronization failed.");
+       ret = lbs_get_channel(priv);
+       if (ret > 0) {
+               priv->curbssparams.channel = ret;
+               ret = 0;
+       }
+       lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
+       return ret;
 }
 
-static int assoc_helper_channel(wlan_private *priv,
+static int assoc_helper_channel(struct lbs_private *priv,
                                 struct assoc_request * assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_ASSOC);
 
-       ret = update_channel(priv);
-       if (ret < 0) {
-               lbs_deb_assoc("ASSOC: channel: error getting channel.");
+       ret = lbs_update_channel(priv);
+       if (ret) {
+               lbs_deb_assoc("ASSOC: channel: error getting channel.\n");
+               goto done;
        }
 
-       if (assoc_req->channel == adapter->curbssparams.channel)
+       if (assoc_req->channel == priv->curbssparams.channel)
                goto done;
 
+       if (priv->mesh_dev) {
+               /* Change mesh channel first; 21.p21 firmware won't let
+                  you change channel otherwise (even though it'll return
+                  an error to this */
+               lbs_mesh_config(priv, 0, assoc_req->channel);
+       }
+
        lbs_deb_assoc("ASSOC: channel: %d -> %d\n",
-              adapter->curbssparams.channel, assoc_req->channel);
+                     priv->curbssparams.channel, assoc_req->channel);
 
-       ret = libertas_prepare_and_send_command(priv, CMD_802_11_RF_CHANNEL,
-                               CMD_OPT_802_11_RF_CHANNEL_SET,
-                               CMD_OPTION_WAITFORRSP, 0, &assoc_req->channel);
-       if (ret < 0) {
-               lbs_deb_assoc("ASSOC: channel: error setting channel.");
-       }
+       ret = lbs_set_channel(priv, assoc_req->channel);
+       if (ret < 0)
+               lbs_deb_assoc("ASSOC: channel: error setting channel.\n");
 
-       ret = update_channel(priv);
-       if (ret < 0) {
-               lbs_deb_assoc("ASSOC: channel: error getting channel.");
+       /* FIXME: shouldn't need to grab the channel _again_ after setting
+        * it since the firmware is supposed to return the new channel, but
+        * whatever... */
+       ret = lbs_update_channel(priv);
+       if (ret) {
+               lbs_deb_assoc("ASSOC: channel: error getting channel.\n");
+               goto done;
        }
 
-       if (assoc_req->channel != adapter->curbssparams.channel) {
-               lbs_deb_assoc("ASSOC: channel: failed to update channel to %d",
+       if (assoc_req->channel != priv->curbssparams.channel) {
+               lbs_deb_assoc("ASSOC: channel: failed to update channel to %d\n",
                              assoc_req->channel);
-               goto done;
+               goto restore_mesh;
        }
 
        if (   assoc_req->secinfo.wep_enabled
@@ -255,85 +236,73 @@ static int assoc_helper_channel(wlan_private *priv,
        }
 
        /* Must restart/rejoin adhoc networks after channel change */
-       set_bit(ASSOC_FLAG_SSID, &assoc_req->flags);
+       set_bit(ASSOC_FLAG_SSID, &assoc_req->flags);
 
-done:
+ restore_mesh:
+       if (priv->mesh_dev)
+               lbs_mesh_config(priv, 1, priv->curbssparams.channel);
+
+ done:
        lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
        return ret;
 }
 
 
-static int assoc_helper_wep_keys(wlan_private *priv,
-                                 struct assoc_request * assoc_req)
+static int assoc_helper_wep_keys(struct lbs_private *priv,
+                                struct assoc_request *assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int i;
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_ASSOC);
 
        /* Set or remove WEP keys */
-       if (   assoc_req->wep_keys[0].len
-           || assoc_req->wep_keys[1].len
-           || assoc_req->wep_keys[2].len
-           || assoc_req->wep_keys[3].len) {
-               ret = libertas_prepare_and_send_command(priv,
-                                           CMD_802_11_SET_WEP,
-                                           CMD_ACT_ADD,
-                                           CMD_OPTION_WAITFORRSP,
-                                           0, assoc_req);
-       } else {
-               ret = libertas_prepare_and_send_command(priv,
-                                           CMD_802_11_SET_WEP,
-                                           CMD_ACT_REMOVE,
-                                           CMD_OPTION_WAITFORRSP,
-                                           0, NULL);
-       }
+       if (assoc_req->wep_keys[0].len || assoc_req->wep_keys[1].len ||
+           assoc_req->wep_keys[2].len || assoc_req->wep_keys[3].len)
+               ret = lbs_cmd_802_11_set_wep(priv, CMD_ACT_ADD, assoc_req);
+       else
+               ret = lbs_cmd_802_11_set_wep(priv, CMD_ACT_REMOVE, assoc_req);
 
        if (ret)
                goto out;
 
        /* enable/disable the MAC's WEP packet filter */
        if (assoc_req->secinfo.wep_enabled)
-               adapter->currentpacketfilter |= CMD_ACT_MAC_WEP_ENABLE;
+               priv->mac_control |= CMD_ACT_MAC_WEP_ENABLE;
        else
-               adapter->currentpacketfilter &= ~CMD_ACT_MAC_WEP_ENABLE;
-       ret = libertas_set_mac_packet_filter(priv);
-       if (ret)
-               goto out;
+               priv->mac_control &= ~CMD_ACT_MAC_WEP_ENABLE;
+
+       lbs_set_mac_control(priv);
 
-       mutex_lock(&adapter->lock);
+       mutex_lock(&priv->lock);
 
-       /* Copy WEP keys into adapter wep key fields */
+       /* Copy WEP keys into priv wep key fields */
        for (i = 0; i < 4; i++) {
-               memcpy(&adapter->wep_keys[i], &assoc_req->wep_keys[i],
-                       sizeof(struct enc_key));
+               memcpy(&priv->wep_keys[i], &assoc_req->wep_keys[i],
+                      sizeof(struct enc_key));
        }
-       adapter->wep_tx_keyidx = assoc_req->wep_tx_keyidx;
+       priv->wep_tx_keyidx = assoc_req->wep_tx_keyidx;
 
-       mutex_unlock(&adapter->lock);
+       mutex_unlock(&priv->lock);
 
 out:
        lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
        return ret;
 }
 
-static int assoc_helper_secinfo(wlan_private *priv,
+static int assoc_helper_secinfo(struct lbs_private *priv,
                                 struct assoc_request * assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
-       u32 do_wpa;
-       u32 rsn = 0;
+       uint16_t do_wpa;
+       uint16_t rsn = 0;
 
        lbs_deb_enter(LBS_DEB_ASSOC);
 
-       memcpy(&adapter->secinfo, &assoc_req->secinfo,
-               sizeof(struct wlan_802_11_security));
+       memcpy(&priv->secinfo, &assoc_req->secinfo,
+               sizeof(struct lbs_802_11_security));
 
-       ret = libertas_set_mac_packet_filter(priv);
-       if (ret)
-               goto out;
+       lbs_set_mac_control(priv);
 
        /* If RSN is already enabled, don't try to enable it again, since
         * ENABLE_RSN resets internal state machines and will clobber the
@@ -341,28 +310,19 @@ static int assoc_helper_secinfo(wlan_private *priv,
         */
 
        /* Get RSN enabled/disabled */
-       ret = libertas_prepare_and_send_command(priv,
-                                   CMD_802_11_ENABLE_RSN,
-                                   CMD_ACT_GET,
-                                   CMD_OPTION_WAITFORRSP,
-                                   0, &rsn);
+       ret = lbs_cmd_802_11_enable_rsn(priv, CMD_ACT_GET, &rsn);
        if (ret) {
-               lbs_deb_assoc("Failed to get RSN status: %d", ret);
+               lbs_deb_assoc("Failed to get RSN status: %d\n", ret);
                goto out;
        }
 
        /* Don't re-enable RSN if it's already enabled */
-       do_wpa = (assoc_req->secinfo.WPAenabled || assoc_req->secinfo.WPA2enabled);
+       do_wpa = assoc_req->secinfo.WPAenabled || assoc_req->secinfo.WPA2enabled;
        if (do_wpa == rsn)
                goto out;
 
        /* Set RSN enabled/disabled */
-       rsn = do_wpa;
-       ret = libertas_prepare_and_send_command(priv,
-                                   CMD_802_11_ENABLE_RSN,
-                                   CMD_ACT_SET,
-                                   CMD_OPTION_WAITFORRSP,
-                                   0, &rsn);
+       ret = lbs_cmd_802_11_enable_rsn(priv, CMD_ACT_SET, &do_wpa);
 
 out:
        lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
@@ -370,7 +330,7 @@ out:
 }
 
 
-static int assoc_helper_wpa_keys(wlan_private *priv,
+static int assoc_helper_wpa_keys(struct lbs_private *priv,
                                  struct assoc_request * assoc_req)
 {
        int ret = 0;
@@ -385,11 +345,7 @@ static int assoc_helper_wpa_keys(wlan_private *priv,
 
        if (test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
                clear_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags);
-               ret = libertas_prepare_and_send_command(priv,
-                                       CMD_802_11_KEY_MATERIAL,
-                                       CMD_ACT_SET,
-                                       CMD_OPTION_WAITFORRSP,
-                                       0, assoc_req);
+               ret = lbs_cmd_802_11_key_material(priv, CMD_ACT_SET, assoc_req);
                assoc_req->flags = flags;
        }
 
@@ -399,11 +355,7 @@ static int assoc_helper_wpa_keys(wlan_private *priv,
        if (test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags)) {
                clear_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags);
 
-               ret = libertas_prepare_and_send_command(priv,
-                                       CMD_802_11_KEY_MATERIAL,
-                                       CMD_ACT_SET,
-                                       CMD_OPTION_WAITFORRSP,
-                                       0, assoc_req);
+               ret = lbs_cmd_802_11_key_material(priv, CMD_ACT_SET, assoc_req);
                assoc_req->flags = flags;
        }
 
@@ -413,20 +365,19 @@ out:
 }
 
 
-static int assoc_helper_wpa_ie(wlan_private *priv,
+static int assoc_helper_wpa_ie(struct lbs_private *priv,
                                struct assoc_request * assoc_req)
 {
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_ASSOC);
 
        if (assoc_req->secinfo.WPAenabled || assoc_req->secinfo.WPA2enabled) {
-               memcpy(&adapter->wpa_ie, &assoc_req->wpa_ie, assoc_req->wpa_ie_len);
-               adapter->wpa_ie_len = assoc_req->wpa_ie_len;
+               memcpy(&priv->wpa_ie, &assoc_req->wpa_ie, assoc_req->wpa_ie_len);
+               priv->wpa_ie_len = assoc_req->wpa_ie_len;
        } else {
-               memset(&adapter->wpa_ie, 0, MAX_WPA_IE_LEN);
-               adapter->wpa_ie_len = 0;
+               memset(&priv->wpa_ie, 0, MAX_WPA_IE_LEN);
+               priv->wpa_ie_len = 0;
        }
 
        lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
@@ -434,55 +385,67 @@ static int assoc_helper_wpa_ie(wlan_private *priv,
 }
 
 
-static int should_deauth_infrastructure(wlan_adapter *adapter,
+static int should_deauth_infrastructure(struct lbs_private *priv,
                                         struct assoc_request * assoc_req)
 {
-       if (adapter->connect_status != LIBERTAS_CONNECTED)
+       int ret = 0;
+
+       if (priv->connect_status != LBS_CONNECTED)
                return 0;
 
+       lbs_deb_enter(LBS_DEB_ASSOC);
        if (test_bit(ASSOC_FLAG_SSID, &assoc_req->flags)) {
-               lbs_deb_assoc("Deauthenticating due to new SSID in "
-                       " configuration request.\n");
-               return 1;
+               lbs_deb_assoc("Deauthenticating due to new SSID\n");
+               ret = 1;
+               goto out;
        }
 
        if (test_bit(ASSOC_FLAG_SECINFO, &assoc_req->flags)) {
-               if (adapter->secinfo.auth_mode != assoc_req->secinfo.auth_mode) {
-                       lbs_deb_assoc("Deauthenticating due to updated security "
-                               "info in configuration request.\n");
-                       return 1;
+               if (priv->secinfo.auth_mode != assoc_req->secinfo.auth_mode) {
+                       lbs_deb_assoc("Deauthenticating due to new security\n");
+                       ret = 1;
+                       goto out;
                }
        }
 
        if (test_bit(ASSOC_FLAG_BSSID, &assoc_req->flags)) {
-               lbs_deb_assoc("Deauthenticating due to new BSSID in "
-                       " configuration request.\n");
-               return 1;
+               lbs_deb_assoc("Deauthenticating due to new BSSID\n");
+               ret = 1;
+               goto out;
        }
 
        if (test_bit(ASSOC_FLAG_CHANNEL, &assoc_req->flags)) {
-               lbs_deb_assoc("Deauthenticating due to channel switch.\n");
-               return 1;
+               lbs_deb_assoc("Deauthenticating due to channel switch\n");
+               ret = 1;
+               goto out;
        }
 
        /* FIXME: deal with 'auto' mode somehow */
        if (test_bit(ASSOC_FLAG_MODE, &assoc_req->flags)) {
-               if (assoc_req->mode != IW_MODE_INFRA)
-                       return 1;
+               if (assoc_req->mode != IW_MODE_INFRA) {
+                       lbs_deb_assoc("Deauthenticating due to leaving "
+                               "infra mode\n");
+                       ret = 1;
+                       goto out;
+               }
        }
 
-       return 0;
+out:
+       lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
+       return ret;
 }
 
 
-static int should_stop_adhoc(wlan_adapter *adapter,
+static int should_stop_adhoc(struct lbs_private *priv,
                              struct assoc_request * assoc_req)
 {
-       if (adapter->connect_status != LIBERTAS_CONNECTED)
+       lbs_deb_enter(LBS_DEB_ASSOC);
+
+       if (priv->connect_status != LBS_CONNECTED)
                return 0;
 
-       if (libertas_ssid_cmp(adapter->curbssparams.ssid,
-                             adapter->curbssparams.ssid_len,
+       if (lbs_ssid_cmp(priv->curbssparams.ssid,
+                             priv->curbssparams.ssid_len,
                              assoc_req->ssid, assoc_req->ssid_len) != 0)
                return 1;
 
@@ -493,18 +456,19 @@ static int should_stop_adhoc(wlan_adapter *adapter,
        }
 
        if (test_bit(ASSOC_FLAG_CHANNEL, &assoc_req->flags)) {
-               if (assoc_req->channel != adapter->curbssparams.channel)
+               if (assoc_req->channel != priv->curbssparams.channel)
                        return 1;
        }
 
+       lbs_deb_leave(LBS_DEB_ASSOC);
        return 0;
 }
 
 
-void libertas_association_worker(struct work_struct *work)
+void lbs_association_worker(struct work_struct *work)
 {
-       wlan_private *priv = container_of(work, wlan_private, assoc_work.work);
-       wlan_adapter *adapter = priv->adapter;
+       struct lbs_private *priv = container_of(work, struct lbs_private,
+               assoc_work.work);
        struct assoc_request * assoc_req = NULL;
        int ret = 0;
        int find_any_ssid = 0;
@@ -512,16 +476,33 @@ void libertas_association_worker(struct work_struct *work)
 
        lbs_deb_enter(LBS_DEB_ASSOC);
 
-       mutex_lock(&adapter->lock);
-       assoc_req = adapter->pending_assoc_req;
-       adapter->pending_assoc_req = NULL;
-       adapter->in_progress_assoc_req = assoc_req;
-       mutex_unlock(&adapter->lock);
+       mutex_lock(&priv->lock);
+       assoc_req = priv->pending_assoc_req;
+       priv->pending_assoc_req = NULL;
+       priv->in_progress_assoc_req = assoc_req;
+       mutex_unlock(&priv->lock);
 
        if (!assoc_req)
                goto done;
 
-       print_assoc_req(__func__, assoc_req);
+       lbs_deb_assoc(
+               "Association Request:\n"
+               "    flags:     0x%08lx\n"
+               "    SSID:      '%s'\n"
+               "    chann:     %d\n"
+               "    band:      %d\n"
+               "    mode:      %d\n"
+               "    BSSID:     %s\n"
+               "    secinfo:  %s%s%s\n"
+               "    auth_mode: %d\n",
+               assoc_req->flags,
+               escape_essid(assoc_req->ssid, assoc_req->ssid_len),
+               assoc_req->channel, assoc_req->band, assoc_req->mode,
+               print_mac(mac, assoc_req->bssid),
+               assoc_req->secinfo.WPAenabled ? " WPA" : "",
+               assoc_req->secinfo.WPA2enabled ? " WPA2" : "",
+               assoc_req->secinfo.wep_enabled ? " WEP" : "",
+               assoc_req->secinfo.auth_mode);
 
        /* If 'any' SSID was specified, find an SSID to associate with */
        if (test_bit(ASSOC_FLAG_SSID, &assoc_req->flags)
@@ -538,7 +519,7 @@ void libertas_association_worker(struct work_struct *work)
        if (find_any_ssid) {
                u8 new_mode;
 
-               ret = libertas_find_best_network_ssid(priv, assoc_req->ssid,
+               ret = lbs_find_best_network_ssid(priv, assoc_req->ssid,
                                &assoc_req->ssid_len, assoc_req->mode, &new_mode);
                if (ret) {
                        lbs_deb_assoc("Could not find best network\n");
@@ -557,18 +538,18 @@ void libertas_association_worker(struct work_struct *work)
         * Check if the attributes being changing require deauthentication
         * from the currently associated infrastructure access point.
         */
-       if (adapter->mode == IW_MODE_INFRA) {
-               if (should_deauth_infrastructure(adapter, assoc_req)) {
-                       ret = libertas_send_deauthentication(priv);
+       if (priv->mode == IW_MODE_INFRA) {
+               if (should_deauth_infrastructure(priv, assoc_req)) {
+                       ret = lbs_send_deauthentication(priv);
                        if (ret) {
                                lbs_deb_assoc("Deauthentication due to new "
                                        "configuration request failed: %d\n",
                                        ret);
                        }
                }
-       } else if (adapter->mode == IW_MODE_ADHOC) {
-               if (should_stop_adhoc(adapter, assoc_req)) {
-                       ret = libertas_stop_adhoc_network(priv);
+       } else if (priv->mode == IW_MODE_ADHOC) {
+               if (should_stop_adhoc(priv, assoc_req)) {
+                       ret = lbs_stop_adhoc_network(priv);
                        if (ret) {
                                lbs_deb_assoc("Teardown of AdHoc network due to "
                                        "new configuration request failed: %d\n",
@@ -581,58 +562,40 @@ void libertas_association_worker(struct work_struct *work)
        /* Send the various configuration bits to the firmware */
        if (test_bit(ASSOC_FLAG_MODE, &assoc_req->flags)) {
                ret = assoc_helper_mode(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC(:%d) mode: ret = %d\n",
-                                     __LINE__, ret);
+               if (ret)
                        goto out;
-               }
        }
 
        if (test_bit(ASSOC_FLAG_CHANNEL, &assoc_req->flags)) {
                ret = assoc_helper_channel(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC(:%d) channel: ret = %d\n",
-                                     __LINE__, ret);
+               if (ret)
                        goto out;
-               }
        }
 
        if (   test_bit(ASSOC_FLAG_WEP_KEYS, &assoc_req->flags)
            || test_bit(ASSOC_FLAG_WEP_TX_KEYIDX, &assoc_req->flags)) {
                ret = assoc_helper_wep_keys(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC(:%d) wep_keys: ret = %d\n",
-                                     __LINE__, ret);
+               if (ret)
                        goto out;
-               }
        }
 
        if (test_bit(ASSOC_FLAG_SECINFO, &assoc_req->flags)) {
                ret = assoc_helper_secinfo(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC(:%d) secinfo: ret = %d\n",
-                                     __LINE__, ret);
+               if (ret)
                        goto out;
-               }
        }
 
        if (test_bit(ASSOC_FLAG_WPA_IE, &assoc_req->flags)) {
                ret = assoc_helper_wpa_ie(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC(:%d) wpa_ie: ret = %d\n",
-                                     __LINE__, ret);
+               if (ret)
                        goto out;
-               }
        }
 
        if (test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags)
            || test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
                ret = assoc_helper_wpa_keys(priv, assoc_req);
-               if (ret) {
-                       lbs_deb_assoc("ASSOC(:%d) wpa_keys: ret = %d\n",
-                                     __LINE__, ret);
+               if (ret)
                        goto out;
-               }
        }
 
        /* SSID/BSSID should be the _last_ config option set, because they
@@ -644,30 +607,23 @@ void libertas_association_worker(struct work_struct *work)
 
                ret = assoc_helper_associate(priv, assoc_req);
                if (ret) {
-                       lbs_deb_assoc("ASSOC: association attempt unsuccessful: %d\n",
+                       lbs_deb_assoc("ASSOC: association unsuccessful: %d\n",
                                ret);
                        success = 0;
                }
 
-               if (adapter->connect_status != LIBERTAS_CONNECTED) {
-                       lbs_deb_assoc("ASSOC: association attempt unsuccessful, "
-                               "not connected.\n");
+               if (priv->connect_status != LBS_CONNECTED) {
+                       lbs_deb_assoc("ASSOC: association unsuccessful, "
+                               "not connected\n");
                        success = 0;
                }
 
                if (success) {
-                       lbs_deb_assoc("ASSOC: association attempt successful. "
-                               "Associated to '%s' (%s)\n",
-                               escape_essid(adapter->curbssparams.ssid,
-                                            adapter->curbssparams.ssid_len),
-                               print_mac(mac, adapter->curbssparams.bssid));
-                       libertas_prepare_and_send_command(priv,
+                       lbs_deb_assoc("associated to %s\n",
+                               print_mac(mac, priv->curbssparams.bssid));
+                       lbs_prepare_and_send_command(priv,
                                CMD_802_11_RSSI,
                                0, CMD_OPTION_WAITFORRSP, 0, NULL);
-
-                       libertas_prepare_and_send_command(priv,
-                               CMD_802_11_GET_LOG,
-                               0, CMD_OPTION_WAITFORRSP, 0, NULL);
                } else {
                        ret = -1;
                }
@@ -679,9 +635,9 @@ out:
                        ret);
        }
 
-       mutex_lock(&adapter->lock);
-       adapter->in_progress_assoc_req = NULL;
-       mutex_unlock(&adapter->lock);
+       mutex_lock(&priv->lock);
+       priv->in_progress_assoc_req = NULL;
+       mutex_unlock(&priv->lock);
        kfree(assoc_req);
 
 done:
@@ -692,14 +648,15 @@ done:
 /*
  * Caller MUST hold any necessary locks
  */
-struct assoc_request * wlan_get_association_request(wlan_adapter *adapter)
+struct assoc_request *lbs_get_association_request(struct lbs_private *priv)
 {
        struct assoc_request * assoc_req;
 
-       if (!adapter->pending_assoc_req) {
-               adapter->pending_assoc_req = kzalloc(sizeof(struct assoc_request),
+       lbs_deb_enter(LBS_DEB_ASSOC);
+       if (!priv->pending_assoc_req) {
+               priv->pending_assoc_req = kzalloc(sizeof(struct assoc_request),
                                                     GFP_KERNEL);
-               if (!adapter->pending_assoc_req) {
+               if (!priv->pending_assoc_req) {
                        lbs_pr_info("Not enough memory to allocate association"
                                " request!\n");
                        return NULL;
@@ -709,60 +666,59 @@ struct assoc_request * wlan_get_association_request(wlan_adapter *adapter)
        /* Copy current configuration attributes to the association request,
         * but don't overwrite any that are already set.
         */
-       assoc_req = adapter->pending_assoc_req;
+       assoc_req = priv->pending_assoc_req;
        if (!test_bit(ASSOC_FLAG_SSID, &assoc_req->flags)) {
-               memcpy(&assoc_req->ssid, &adapter->curbssparams.ssid,
+               memcpy(&assoc_req->ssid, &priv->curbssparams.ssid,
                       IW_ESSID_MAX_SIZE);
-               assoc_req->ssid_len = adapter->curbssparams.ssid_len;
+               assoc_req->ssid_len = priv->curbssparams.ssid_len;
        }
 
        if (!test_bit(ASSOC_FLAG_CHANNEL, &assoc_req->flags))
-               assoc_req->channel = adapter->curbssparams.channel;
+               assoc_req->channel = priv->curbssparams.channel;
 
        if (!test_bit(ASSOC_FLAG_BAND, &assoc_req->flags))
-               assoc_req->band = adapter->curbssparams.band;
+               assoc_req->band = priv->curbssparams.band;
 
        if (!test_bit(ASSOC_FLAG_MODE, &assoc_req->flags))
-               assoc_req->mode = adapter->mode;
+               assoc_req->mode = priv->mode;
 
        if (!test_bit(ASSOC_FLAG_BSSID, &assoc_req->flags)) {
-               memcpy(&assoc_req->bssid, adapter->curbssparams.bssid,
+               memcpy(&assoc_req->bssid, priv->curbssparams.bssid,
                        ETH_ALEN);
        }
 
        if (!test_bit(ASSOC_FLAG_WEP_KEYS, &assoc_req->flags)) {
                int i;
                for (i = 0; i < 4; i++) {
-                       memcpy(&assoc_req->wep_keys[i], &adapter->wep_keys[i],
+                       memcpy(&assoc_req->wep_keys[i], &priv->wep_keys[i],
                                sizeof(struct enc_key));
                }
        }
 
        if (!test_bit(ASSOC_FLAG_WEP_TX_KEYIDX, &assoc_req->flags))
-               assoc_req->wep_tx_keyidx = adapter->wep_tx_keyidx;
+               assoc_req->wep_tx_keyidx = priv->wep_tx_keyidx;
 
        if (!test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags)) {
-               memcpy(&assoc_req->wpa_mcast_key, &adapter->wpa_mcast_key,
+               memcpy(&assoc_req->wpa_mcast_key, &priv->wpa_mcast_key,
                        sizeof(struct enc_key));
        }
 
        if (!test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
-               memcpy(&assoc_req->wpa_unicast_key, &adapter->wpa_unicast_key,
+               memcpy(&assoc_req->wpa_unicast_key, &priv->wpa_unicast_key,
                        sizeof(struct enc_key));
        }
 
        if (!test_bit(ASSOC_FLAG_SECINFO, &assoc_req->flags)) {
-               memcpy(&assoc_req->secinfo, &adapter->secinfo,
-                       sizeof(struct wlan_802_11_security));
+               memcpy(&assoc_req->secinfo, &priv->secinfo,
+                       sizeof(struct lbs_802_11_security));
        }
 
        if (!test_bit(ASSOC_FLAG_WPA_IE, &assoc_req->flags)) {
-               memcpy(&assoc_req->wpa_ie, &adapter->wpa_ie,
+               memcpy(&assoc_req->wpa_ie, &priv->wpa_ie,
                        MAX_WPA_IE_LEN);
-               assoc_req->wpa_ie_len = adapter->wpa_ie_len;
+               assoc_req->wpa_ie_len = priv->wpa_ie_len;
        }
 
-       print_assoc_req(__func__, assoc_req);
-
+       lbs_deb_leave(LBS_DEB_ASSOC);
        return assoc_req;
 }