]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/net/wireless/p54/p54common.c
Merge branches 'topic/fixes', 'topic/cleanups' and 'topic/documentation' into for...
[linux-2.6-omap-h63xx.git] / drivers / net / wireless / p54 / p54common.c
index 6bf5123c10b2f501975a3d988233cc06cb53dbef..82354b974a04773e752307f45f393bed8a89763c 100644 (file)
@@ -25,6 +25,9 @@
 #include "p54.h"
 #include "p54common.h"
 
+static int modparam_nohwcrypt;
+module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
+MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
 MODULE_AUTHOR("Michael Wu <flamingice@sourmilk.net>");
 MODULE_DESCRIPTION("Softmac Prism54 common code");
 MODULE_LICENSE("GPL");
@@ -155,21 +158,21 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw)
                        priv->fw_interface = be32_to_cpup((__be32 *)
                                             bootrec->data);
                        switch (priv->fw_interface) {
-                       case FW_FMAC:
-                               printk(KERN_INFO "p54: FreeMAC firmware\n");
-                               break;
-                       case FW_LM20:
-                               printk(KERN_INFO "p54: LM20 firmware\n");
-                               break;
                        case FW_LM86:
-                               printk(KERN_INFO "p54: LM86 firmware\n");
-                               break;
-                       case FW_LM87:
-                               printk(KERN_INFO "p54: LM87 firmware\n");
+                       case FW_LM20:
+                       case FW_LM87: {
+                               char *iftype = (char *)bootrec->data;
+                               printk(KERN_INFO "%s: p54 detected a LM%c%c "
+                                                "firmware\n",
+                                       wiphy_name(dev->wiphy),
+                                       iftype[2], iftype[3]);
                                break;
+                               }
+                       case FW_FMAC:
                        default:
-                               printk(KERN_INFO "p54: unknown firmware\n");
-                               break;
+                               printk(KERN_ERR "%s: unsupported firmware\n",
+                                       wiphy_name(dev->wiphy));
+                               return -ENODEV;
                        }
                        break;
                case BR_CODE_COMPONENT_VERSION:
@@ -185,6 +188,8 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw)
                        priv->rx_end = le32_to_cpu(desc->rx_end) - 0x3500;
                        priv->headroom = desc->headroom;
                        priv->tailroom = desc->tailroom;
+                       priv->privacy_caps = desc->privacy_caps;
+                       priv->rx_keycache_size = desc->rx_keycache_size;
                        if (le32_to_cpu(bootrec->len) == 11)
                                priv->rx_mtu = le16_to_cpu(desc->rx_mtu);
                        else
@@ -211,13 +216,15 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw)
        }
 
        if (fw_version)
-               printk(KERN_INFO "p54: FW rev %s - Softmac protocol %x.%x\n",
-                       fw_version, priv->fw_var >> 8, priv->fw_var & 0xff);
+               printk(KERN_INFO "%s: FW rev %s - Softmac protocol %x.%x\n",
+                       wiphy_name(dev->wiphy), fw_version,
+                       priv->fw_var >> 8, priv->fw_var & 0xff);
 
        if (priv->fw_var < 0x500)
-               printk(KERN_INFO "p54: you are using an obsolete firmware. "
+               printk(KERN_INFO "%s: you are using an obsolete firmware. "
                       "visit http://wireless.kernel.org/en/users/Drivers/p54 "
-                      "and grab one for \"kernel >= 2.6.28\"!\n");
+                      "and grab one for \"kernel >= 2.6.28\"!\n",
+                       wiphy_name(dev->wiphy));
 
        if (priv->fw_var >= 0x300) {
                /* Firmware supports QoS, use it! */
@@ -228,6 +235,16 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw)
                dev->queues = 4;
        }
 
+       if (!modparam_nohwcrypt)
+               printk(KERN_INFO "%s: cryptographic accelerator "
+                                "WEP:%s, TKIP:%s, CCMP:%s\n",
+                       wiphy_name(dev->wiphy),
+                       (priv->privacy_caps & BR_DESC_PRIV_CAP_WEP) ? "YES" :
+                       "no", (priv->privacy_caps & (BR_DESC_PRIV_CAP_TKIP |
+                        BR_DESC_PRIV_CAP_MICHAEL)) ? "YES" : "no",
+                       (priv->privacy_caps & BR_DESC_PRIV_CAP_AESCCMP) ?
+                       "YES" : "no");
+
        return 0;
 }
 EXPORT_SYMBOL_GPL(p54_parse_firmware);
@@ -318,6 +335,36 @@ static const char *p54_rf_chips[] = { "NULL", "Duette3", "Duette2",
                               "Frisbee", "Xbow", "Longbow", "NULL", "NULL" };
 static int p54_init_xbow_synth(struct ieee80211_hw *dev);
 
+static void p54_parse_rssical(struct ieee80211_hw *dev, void *data, int len,
+                            u16 type)
+{
+       struct p54_common *priv = dev->priv;
+       int offset = (type == PDR_RSSI_LINEAR_APPROXIMATION_EXTENDED) ? 2 : 0;
+       int entry_size = sizeof(struct pda_rssi_cal_entry) + offset;
+       int num_entries = (type == PDR_RSSI_LINEAR_APPROXIMATION) ? 1 : 2;
+       int i;
+
+       if (len != (entry_size * num_entries)) {
+               printk(KERN_ERR "%s: unknown rssi calibration data packing "
+                                " type:(%x) len:%d.\n",
+                      wiphy_name(dev->wiphy), type, len);
+
+               print_hex_dump_bytes("rssical:", DUMP_PREFIX_NONE,
+                                    data, len);
+
+               printk(KERN_ERR "%s: please report this issue.\n",
+                       wiphy_name(dev->wiphy));
+               return;
+       }
+
+       for (i = 0; i < num_entries; i++) {
+               struct pda_rssi_cal_entry *cal = data +
+                                                (offset + i * entry_size);
+               priv->rssical_db[i].mul = (s16) le16_to_cpu(cal->mul);
+               priv->rssical_db[i].add = (s16) le16_to_cpu(cal->add);
+       }
+}
+
 static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
 {
        struct p54_common *priv = dev->priv;
@@ -384,8 +431,9 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
                                err = p54_convert_rev1(dev, curve_data);
                                break;
                        default:
-                               printk(KERN_ERR "p54: unknown curve data "
+                               printk(KERN_ERR "%s: unknown curve data "
                                                "revision %d\n",
+                                               wiphy_name(dev->wiphy),
                                                curve_data->cal_method_rev);
                                err = -ENODEV;
                                break;
@@ -416,6 +464,12 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
                case PDR_HARDWARE_PLATFORM_COMPONENT_ID:
                        priv->version = *(u8 *)(entry->data + 1);
                        break;
+               case PDR_RSSI_LINEAR_APPROXIMATION:
+               case PDR_RSSI_LINEAR_APPROXIMATION_DUAL_BAND:
+               case PDR_RSSI_LINEAR_APPROXIMATION_EXTENDED:
+                       p54_parse_rssical(dev, entry->data, data_len,
+                                         le16_to_cpu(entry->code));
+                       break;
                case PDR_END:
                        /* make it overrun */
                        entry_len = len;
@@ -435,17 +489,15 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
                case PDR_DEFAULT_COUNTRY:
                case PDR_ANTENNA_GAIN:
                case PDR_PRISM_INDIGO_PA_CALIBRATION_DATA:
-               case PDR_RSSI_LINEAR_APPROXIMATION:
-               case PDR_RSSI_LINEAR_APPROXIMATION_DUAL_BAND:
                case PDR_REGULATORY_POWER_LIMITS:
-               case PDR_RSSI_LINEAR_APPROXIMATION_EXTENDED:
                case PDR_RADIATED_TRANSMISSION_CORRECTION:
                case PDR_PRISM_TX_IQ_CALIBRATION:
                case PDR_BASEBAND_REGISTERS:
                case PDR_PER_CHANNEL_BASEBAND_REGISTERS:
                        break;
                default:
-                       printk(KERN_INFO "p54: unknown eeprom code : 0x%x\n",
+                       printk(KERN_INFO "%s: unknown eeprom code : 0x%x\n",
+                               wiphy_name(dev->wiphy),
                                le16_to_cpu(entry->code));
                        break;
                }
@@ -455,7 +507,8 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
 
        if (!synth || !priv->iq_autocal || !priv->output_limit ||
            !priv->curve_data) {
-               printk(KERN_ERR "p54: not all required entries found in eeprom!\n");
+               printk(KERN_ERR "%s: not all required entries found in eeprom!\n",
+                       wiphy_name(dev->wiphy));
                err = -EINVAL;
                goto err;
        }
@@ -500,14 +553,18 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
                priv->curve_data = NULL;
        }
 
-       printk(KERN_ERR "p54: eeprom parse failed!\n");
+       printk(KERN_ERR "%s: eeprom parse failed!\n",
+               wiphy_name(dev->wiphy));
        return err;
 }
 
 static int p54_rssi_to_dbm(struct ieee80211_hw *dev, int rssi)
 {
-       /* TODO: get the rssi_add & rssi_mul data from the eeprom */
-       return ((rssi * 0x83) / 64 - 400) / 4;
+       struct p54_common *priv = dev->priv;
+       int band = dev->conf.channel->band;
+
+       return ((rssi * priv->rssical_db[band].mul) / 64 +
+                        priv->rssical_db[band].add) / 4;
 }
 
 static int p54_rx_data(struct ieee80211_hw *dev, struct sk_buff *skb)
@@ -519,6 +576,14 @@ static int p54_rx_data(struct ieee80211_hw *dev, struct sk_buff *skb)
        size_t header_len = sizeof(*hdr);
        u32 tsf32;
 
+       /*
+        * If the device is in a unspecified state we have to
+        * ignore all data frames. Else we could end up with a
+        * nasty crash.
+        */
+       if (unlikely(priv->mode == NL80211_IFTYPE_UNSPECIFIED))
+               return 0;
+
        if (!(hdr->flags & cpu_to_le16(P54_HDR_FLAG_DATA_IN_FCS_GOOD))) {
                if (priv->filter_flags & FIF_FCSFAIL)
                        rx_status.flag |= RX_FLAG_FAILED_FCS_CRC;
@@ -526,6 +591,12 @@ static int p54_rx_data(struct ieee80211_hw *dev, struct sk_buff *skb)
                        return 0;
        }
 
+       if (hdr->decrypt_status == P54_DECRYPT_OK)
+               rx_status.flag |= RX_FLAG_DECRYPTED;
+       if ((hdr->decrypt_status == P54_DECRYPT_FAIL_MICHAEL) ||
+           (hdr->decrypt_status == P54_DECRYPT_FAIL_TKIP))
+               rx_status.flag |= RX_FLAG_MMIC_ERROR;
+
        rx_status.signal = p54_rssi_to_dbm(dev, hdr->rssi);
        rx_status.noise = priv->noise;
        /* XX correct? */
@@ -554,6 +625,9 @@ static int p54_rx_data(struct ieee80211_hw *dev, struct sk_buff *skb)
 
        ieee80211_rx_irqsafe(dev, skb, &rx_status);
 
+       queue_delayed_work(dev->workqueue, &priv->work,
+                          msecs_to_jiffies(P54_STATISTICS_UPDATE));
+
        return -1;
 }
 
@@ -581,6 +655,12 @@ void p54_free_skb(struct ieee80211_hw *dev, struct sk_buff *skb)
        if (unlikely(!skb || !dev || !skb_queue_len(&priv->tx_queue)))
                return;
 
+       /*
+        * don't try to free an already unlinked skb
+        */
+       if (unlikely((!skb->next) || (!skb->prev)))
+               return;
+
        spin_lock_irqsave(&priv->tx_queue.lock, flags);
        info = IEEE80211_SKB_CB(skb);
        range = (void *)info->rate_driver_data;
@@ -603,7 +683,7 @@ void p54_free_skb(struct ieee80211_hw *dev, struct sk_buff *skb)
                freed = priv->rx_end - last_addr;
        __skb_unlink(skb, &priv->tx_queue);
        spin_unlock_irqrestore(&priv->tx_queue.lock, flags);
-       kfree_skb(skb);
+       dev_kfree_skb_any(skb);
 
        if (freed >= priv->headroom + sizeof(struct p54_hdr) + 48 +
                     IEEE80211_MAX_RTS_THRESHOLD + priv->tailroom)
@@ -611,6 +691,27 @@ void p54_free_skb(struct ieee80211_hw *dev, struct sk_buff *skb)
 }
 EXPORT_SYMBOL_GPL(p54_free_skb);
 
+static struct sk_buff *p54_find_tx_entry(struct ieee80211_hw *dev,
+                                          __le32 req_id)
+{
+       struct p54_common *priv = dev->priv;
+       struct sk_buff *entry = priv->tx_queue.next;
+       unsigned long flags;
+
+       spin_lock_irqsave(&priv->tx_queue.lock, flags);
+       while (entry != (struct sk_buff *)&priv->tx_queue) {
+               struct p54_hdr *hdr = (struct p54_hdr *) entry->data;
+
+               if (hdr->req_id == req_id) {
+                       spin_unlock_irqrestore(&priv->tx_queue.lock, flags);
+                       return entry;
+               }
+               entry = entry->next;
+       }
+       spin_unlock_irqrestore(&priv->tx_queue.lock, flags);
+       return NULL;
+}
+
 static void p54_rx_frame_sent(struct ieee80211_hw *dev, struct sk_buff *skb)
 {
        struct p54_common *priv = dev->priv;
@@ -652,6 +753,11 @@ static void p54_rx_frame_sent(struct ieee80211_hw *dev, struct sk_buff *skb)
                __skb_unlink(entry, &priv->tx_queue);
                spin_unlock_irqrestore(&priv->tx_queue.lock, flags);
 
+               entry_hdr = (struct p54_hdr *) entry->data;
+               entry_data = (struct p54_tx_data *) entry_hdr->data;
+               priv->tx_stats[entry_data->hw_queue].len--;
+               priv->stats.dot11ACKFailureCount += payload->tries - 1;
+
                if (unlikely(entry == priv->cached_beacon)) {
                        kfree_skb(entry);
                        priv->cached_beacon = NULL;
@@ -668,8 +774,6 @@ static void p54_rx_frame_sent(struct ieee80211_hw *dev, struct sk_buff *skb)
                BUILD_BUG_ON(offsetof(struct ieee80211_tx_info,
                                      status.ampdu_ack_len) != 23);
 
-               entry_hdr = (struct p54_hdr *) entry->data;
-               entry_data = (struct p54_tx_data *) entry_hdr->data;
                if (entry_hdr->flags & cpu_to_le16(P54_HDR_FLAG_DATA_ALIGN))
                        pad = entry_data->align[0];
 
@@ -687,7 +791,6 @@ static void p54_rx_frame_sent(struct ieee80211_hw *dev, struct sk_buff *skb)
                        }
                }
 
-               priv->tx_stats[entry_data->hw_queue].len--;
                if (!(info->flags & IEEE80211_TX_CTL_NO_ACK) &&
                     (!payload->status))
                        info->flags |= IEEE80211_TX_STAT_ACK;
@@ -717,7 +820,13 @@ static void p54_rx_eeprom_readback(struct ieee80211_hw *dev,
        if (!priv->eeprom)
                return ;
 
-       memcpy(priv->eeprom, eeprom->data, le16_to_cpu(eeprom->len));
+       if (priv->fw_var >= 0x509) {
+               memcpy(priv->eeprom, eeprom->v2.data,
+                      le16_to_cpu(eeprom->v2.len));
+       } else {
+               memcpy(priv->eeprom, eeprom->v1.data,
+                      le16_to_cpu(eeprom->v1.len));
+       }
 
        complete(&priv->eeprom_comp);
 }
@@ -727,8 +836,12 @@ static void p54_rx_stats(struct ieee80211_hw *dev, struct sk_buff *skb)
        struct p54_common *priv = dev->priv;
        struct p54_hdr *hdr = (struct p54_hdr *) skb->data;
        struct p54_statistics *stats = (struct p54_statistics *) hdr->data;
-       u32 tsf32 = le32_to_cpu(stats->tsf32);
+       u32 tsf32;
+
+       if (unlikely(priv->mode == NL80211_IFTYPE_UNSPECIFIED))
+               return ;
 
+       tsf32 = le32_to_cpu(stats->tsf32);
        if (tsf32 < priv->tsf_low32)
                priv->tsf_high32++;
        priv->tsf_low32 = tsf32;
@@ -738,9 +851,8 @@ static void p54_rx_stats(struct ieee80211_hw *dev, struct sk_buff *skb)
        priv->stats.dot11FCSErrorCount = le32_to_cpu(stats->rx_bad_fcs);
 
        priv->noise = p54_rssi_to_dbm(dev, le32_to_cpu(stats->noise));
-       complete(&priv->stats_comp);
 
-       mod_timer(&priv->stats_timer, jiffies + 5 * HZ);
+       p54_free_skb(dev, p54_find_tx_entry(dev, hdr->req_id));
 }
 
 static void p54_rx_trap(struct ieee80211_hw *dev, struct sk_buff *skb)
@@ -840,7 +952,29 @@ static int p54_assign_address(struct ieee80211_hw *dev, struct sk_buff *skb,
                return -EINVAL;
 
        spin_lock_irqsave(&priv->tx_queue.lock, flags);
+
        left = skb_queue_len(&priv->tx_queue);
+       if (unlikely(left >= 28)) {
+               /*
+                * The tx_queue is nearly full!
+                * We have throttle normal data traffic, because we must
+                * have a few spare slots for control frames left.
+                */
+               ieee80211_stop_queues(dev);
+               queue_delayed_work(dev->workqueue, &priv->work,
+                                  msecs_to_jiffies(P54_TX_TIMEOUT));
+
+               if (unlikely(left == 32)) {
+                       /*
+                        * The tx_queue is now really full.
+                        *
+                        * TODO: check if the device has crashed and reset it.
+                        */
+                       spin_unlock_irqrestore(&priv->tx_queue.lock, flags);
+                       return -ENOSPC;
+               }
+       }
+
        while (left--) {
                u32 hole_size;
                info = IEEE80211_SKB_CB(entry);
@@ -869,7 +1003,7 @@ static int p54_assign_address(struct ieee80211_hw *dev, struct sk_buff *skb,
        if (!target_skb) {
                spin_unlock_irqrestore(&priv->tx_queue.lock, flags);
                ieee80211_stop_queues(dev);
-               return -ENOMEM;
+               return -ENOSPC;
        }
 
        info = IEEE80211_SKB_CB(skb);
@@ -918,12 +1052,18 @@ int p54_read_eeprom(struct ieee80211_hw *dev)
        struct p54_hdr *hdr = NULL;
        struct p54_eeprom_lm86 *eeprom_hdr;
        struct sk_buff *skb;
-       size_t eeprom_size = 0x2020, offset = 0, blocksize;
+       size_t eeprom_size = 0x2020, offset = 0, blocksize, maxblocksize;
        int ret = -ENOMEM;
        void *eeprom = NULL;
 
-       skb = p54_alloc_skb(dev, 0x8000, sizeof(*hdr) + sizeof(*eeprom_hdr) +
-                           EEPROM_READBACK_LEN,
+       maxblocksize = EEPROM_READBACK_LEN;
+       if (priv->fw_var >= 0x509)
+               maxblocksize -= 0xc;
+       else
+               maxblocksize -= 0x4;
+
+       skb = p54_alloc_skb(dev, P54_HDR_FLAG_CONTROL, sizeof(*hdr) +
+                           sizeof(*eeprom_hdr) + maxblocksize,
                            P54_CONTROL_TYPE_EEPROM_READBACK, GFP_KERNEL);
        if (!skb)
                goto free;
@@ -935,13 +1075,20 @@ int p54_read_eeprom(struct ieee80211_hw *dev)
                goto free;
 
        eeprom_hdr = (struct p54_eeprom_lm86 *) skb_put(skb,
-                    sizeof(*eeprom_hdr) + EEPROM_READBACK_LEN);
+                    sizeof(*eeprom_hdr) + maxblocksize);
 
        while (eeprom_size) {
-               blocksize = min(eeprom_size, (size_t)EEPROM_READBACK_LEN);
-               eeprom_hdr->offset = cpu_to_le16(offset);
-               eeprom_hdr->len = cpu_to_le16(blocksize);
-               priv->tx(dev, skb, 0);
+               blocksize = min(eeprom_size, maxblocksize);
+               if (priv->fw_var < 0x509) {
+                       eeprom_hdr->v1.offset = cpu_to_le16(offset);
+                       eeprom_hdr->v1.len = cpu_to_le16(blocksize);
+               } else {
+                       eeprom_hdr->v2.offset = cpu_to_le32(offset);
+                       eeprom_hdr->v2.len = cpu_to_le16(blocksize);
+                       eeprom_hdr->v2.magic2 = 0xf;
+                       memcpy(eeprom_hdr->v2.magic, (const char *)"LOCK", 4);
+               }
+               priv->tx(dev, skb);
 
                if (!wait_for_completion_interruptible_timeout(&priv->eeprom_comp, HZ)) {
                        printk(KERN_ERR "%s: device does not respond!\n",
@@ -982,7 +1129,7 @@ static int p54_set_tim(struct ieee80211_hw *dev, struct ieee80211_sta *sta,
        tim = (struct p54_tim *) skb_put(skb, sizeof(*tim));
        tim->count = 1;
        tim->entry[0] = cpu_to_le16(set ? (sta->aid | 0x8000) : sta->aid);
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 }
 
@@ -1000,10 +1147,33 @@ static int p54_sta_unlock(struct ieee80211_hw *dev, u8 *addr)
 
        sta = (struct p54_sta_unlock *)skb_put(skb, sizeof(*sta));
        memcpy(sta->addr, addr, ETH_ALEN);
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 }
 
+static void p54_sta_notify(struct ieee80211_hw *dev, struct ieee80211_vif *vif,
+                             enum sta_notify_cmd notify_cmd,
+                             struct ieee80211_sta *sta)
+{
+       switch (notify_cmd) {
+       case STA_NOTIFY_ADD:
+       case STA_NOTIFY_REMOVE:
+               /*
+                * Notify the firmware that we don't want or we don't
+                * need to buffer frames for this station anymore.
+                */
+
+               p54_sta_unlock(dev, sta->addr);
+               break;
+       case STA_NOTIFY_AWAKE:
+               /* update the firmware's filter table */
+               p54_sta_unlock(dev, sta->addr);
+               break;
+       default:
+               break;
+       }
+}
+
 static int p54_tx_cancel(struct ieee80211_hw *dev, struct sk_buff *entry)
 {
        struct p54_common *priv = dev->priv;
@@ -1020,7 +1190,7 @@ static int p54_tx_cancel(struct ieee80211_hw *dev, struct sk_buff *entry)
        hdr = (void *)entry->data;
        cancel = (struct p54_txcancel *)skb_put(skb, sizeof(*cancel));
        cancel->req_id = hdr->req_id;
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 }
 
@@ -1069,11 +1239,25 @@ static int p54_tx_fill(struct ieee80211_hw *dev, struct sk_buff *skb,
                if (info->control.sta)
                        *aid = info->control.sta->aid;
                else
-                       *flags = P54_HDR_FLAG_DATA_OUT_NOCANCEL;
+                       *flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL;
        }
        return ret;
 }
 
+static u8 p54_convert_algo(enum ieee80211_key_alg alg)
+{
+       switch (alg) {
+       case ALG_WEP:
+               return P54_CRYPTO_WEP;
+       case ALG_TKIP:
+               return P54_CRYPTO_TKIPMICHAEL;
+       case ALG_CCMP:
+               return P54_CRYPTO_AESCCMP;
+       default:
+               return 0;
+       }
+}
+
 static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
 {
        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
@@ -1082,9 +1266,9 @@ static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
        struct p54_hdr *hdr;
        struct p54_tx_data *txhdr;
        size_t padding, len, tim_len = 0;
-       int i, j, ridx;
+       int i, j, ridx, ret;
        u16 hdr_flags = 0, aid = 0;
-       u8 rate, queue;
+       u8 rate, queue, crypt_offset = 0;
        u8 cts_rate = 0x20;
        u8 rc_flags;
        u8 calculated_tries[4];
@@ -1092,28 +1276,30 @@ static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
 
        queue = skb_get_queue_mapping(skb);
 
-       if (p54_tx_fill(dev, skb, info, &queue, &tim_len, &hdr_flags, &aid)) {
-               current_queue = &priv->tx_stats[queue];
-               if (unlikely(current_queue->len > current_queue->limit))
-                       return NETDEV_TX_BUSY;
-               current_queue->len++;
-               current_queue->count++;
-               if (current_queue->len == current_queue->limit)
-                       ieee80211_stop_queue(dev, skb_get_queue_mapping(skb));
-       }
+       ret = p54_tx_fill(dev, skb, info, &queue, &tim_len, &hdr_flags, &aid);
+       current_queue = &priv->tx_stats[queue];
+       if (unlikely((current_queue->len > current_queue->limit) && ret))
+               return NETDEV_TX_BUSY;
+       current_queue->len++;
+       current_queue->count++;
+       if ((current_queue->len == current_queue->limit) && ret)
+               ieee80211_stop_queue(dev, skb_get_queue_mapping(skb));
 
        padding = (unsigned long)(skb->data - (sizeof(*hdr) + sizeof(*txhdr))) & 3;
        len = skb->len;
 
-       if (info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT) {
-               if (info->control.sta)
-                       if (p54_sta_unlock(dev, info->control.sta->addr)) {
-                               if (current_queue) {
-                                       current_queue->len--;
-                                       current_queue->count--;
-                               }
-                               return NETDEV_TX_BUSY;
-                       }
+       if (info->control.hw_key) {
+               crypt_offset = ieee80211_get_hdrlen_from_skb(skb);
+               if (info->control.hw_key->alg == ALG_TKIP) {
+                       u8 *iv = (u8 *)(skb->data + crypt_offset);
+                       /*
+                        * The firmware excepts that the IV has to have
+                        * this special format
+                        */
+                       iv[1] = iv[0];
+                       iv[0] = iv[2];
+                       iv[2] = 0;
+               }
        }
 
        txhdr = (struct p54_tx_data *) skb_push(skb, sizeof(*txhdr) + padding);
@@ -1121,7 +1307,6 @@ static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
 
        if (padding)
                hdr_flags |= P54_HDR_FLAG_DATA_ALIGN;
-       hdr->len = cpu_to_le16(len);
        hdr->type = cpu_to_le16(aid);
        hdr->rts_tries = info->control.rates[0].count;
 
@@ -1196,10 +1381,27 @@ static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
        /* TODO: enable bursting */
        hdr->flags = cpu_to_le16(hdr_flags);
        hdr->tries = ridx;
-       txhdr->crypt_offset = 0;
        txhdr->rts_rate_idx = 0;
-       txhdr->key_type = 0;
-       txhdr->key_len = 0;
+       if (info->control.hw_key) {
+               crypt_offset += info->control.hw_key->iv_len;
+               txhdr->key_type = p54_convert_algo(info->control.hw_key->alg);
+               txhdr->key_len = min((u8)16, info->control.hw_key->keylen);
+               memcpy(txhdr->key, info->control.hw_key->key, txhdr->key_len);
+               if (info->control.hw_key->alg == ALG_TKIP) {
+                       if (unlikely(skb_tailroom(skb) < 12))
+                               goto err;
+                       /* reserve space for the MIC key */
+                       len += 8;
+                       memcpy(skb_put(skb, 8), &(info->control.hw_key->key
+                               [NL80211_TKIP_DATA_OFFSET_TX_MIC_KEY]), 8);
+               }
+               /* reserve some space for ICV */
+               len += info->control.hw_key->icv_len;
+       } else {
+               txhdr->key_type = 0;
+               txhdr->key_len = 0;
+       }
+       txhdr->crypt_offset = crypt_offset;
        txhdr->hw_queue = queue;
        if (current_queue)
                txhdr->backlog = current_queue->len;
@@ -1213,24 +1415,32 @@ static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
        if (padding)
                txhdr->align[0] = padding;
 
+       hdr->len = cpu_to_le16(len);
        /* modifies skb->cb and with it info, so must be last! */
-       if (unlikely(p54_assign_address(dev, skb, hdr, skb->len + tim_len))) {
-               skb_pull(skb, sizeof(*hdr) + sizeof(*txhdr) + padding);
-               if (current_queue) {
-                       current_queue->len--;
-                       current_queue->count--;
-               }
-               return NETDEV_TX_BUSY;
-       }
-       priv->tx(dev, skb, 0);
+       if (unlikely(p54_assign_address(dev, skb, hdr, skb->len + tim_len)))
+               goto err;
+       priv->tx(dev, skb);
+
+       queue_delayed_work(dev->workqueue, &priv->work,
+                          msecs_to_jiffies(P54_TX_FRAME_LIFETIME));
+
        return 0;
+
+ err:
+       skb_pull(skb, sizeof(*hdr) + sizeof(*txhdr) + padding);
+       if (current_queue) {
+               current_queue->len--;
+               current_queue->count--;
+       }
+       return NETDEV_TX_BUSY;
 }
 
-static int p54_setup_mac(struct ieee80211_hw *dev, u16 mode, const u8 *bssid)
+static int p54_setup_mac(struct ieee80211_hw *dev)
 {
        struct p54_common *priv = dev->priv;
        struct sk_buff *skb;
        struct p54_setup_mac *setup;
+       u16 mode;
 
        skb = p54_alloc_skb(dev, P54_HDR_FLAG_CONTROL_OPSET, sizeof(*setup) +
                            sizeof(struct p54_hdr), P54_CONTROL_TYPE_SETUP,
@@ -1239,30 +1449,47 @@ static int p54_setup_mac(struct ieee80211_hw *dev, u16 mode, const u8 *bssid)
                return -ENOMEM;
 
        setup = (struct p54_setup_mac *) skb_put(skb, sizeof(*setup));
-       priv->mac_mode = mode;
+       if (dev->conf.radio_enabled) {
+               switch (priv->mode) {
+               case NL80211_IFTYPE_STATION:
+                       mode = P54_FILTER_TYPE_STATION;
+                       break;
+               case NL80211_IFTYPE_AP:
+                       mode = P54_FILTER_TYPE_AP;
+                       break;
+               case NL80211_IFTYPE_ADHOC:
+               case NL80211_IFTYPE_MESH_POINT:
+                       mode = P54_FILTER_TYPE_IBSS;
+                       break;
+               default:
+                       mode = P54_FILTER_TYPE_NONE;
+                       break;
+               }
+               if (priv->filter_flags & FIF_PROMISC_IN_BSS)
+                       mode |= P54_FILTER_TYPE_TRANSPARENT;
+       } else
+               mode = P54_FILTER_TYPE_RX_DISABLED;
+
        setup->mac_mode = cpu_to_le16(mode);
        memcpy(setup->mac_addr, priv->mac_addr, ETH_ALEN);
-       if (!bssid)
-               memset(setup->bssid, ~0, ETH_ALEN);
-       else
-               memcpy(setup->bssid, bssid, ETH_ALEN);
-       setup->rx_antenna = priv->rx_antenna;
+       memcpy(setup->bssid, priv->bssid, ETH_ALEN);
+       setup->rx_antenna = 2; /* automatic */
        setup->rx_align = 0;
        if (priv->fw_var < 0x500) {
-               setup->v1.basic_rate_mask = cpu_to_le32(0x15f);
+               setup->v1.basic_rate_mask = cpu_to_le32(priv->basic_rate_mask);
                memset(setup->v1.rts_rates, 0, 8);
                setup->v1.rx_addr = cpu_to_le32(priv->rx_end);
                setup->v1.max_rx = cpu_to_le16(priv->rx_mtu);
                setup->v1.rxhw = cpu_to_le16(priv->rxhw);
-               setup->v1.wakeup_timer = cpu_to_le16(500);
+               setup->v1.wakeup_timer = cpu_to_le16(priv->wakeup_timer);
                setup->v1.unalloc0 = cpu_to_le16(0);
        } else {
                setup->v2.rx_addr = cpu_to_le32(priv->rx_end);
                setup->v2.max_rx = cpu_to_le16(priv->rx_mtu);
                setup->v2.rxhw = cpu_to_le16(priv->rxhw);
-               setup->v2.timer = cpu_to_le16(1000);
+               setup->v2.timer = cpu_to_le16(priv->wakeup_timer);
                setup->v2.truncate = cpu_to_le16(48896);
-               setup->v2.basic_rate_mask = cpu_to_le32(0x15f);
+               setup->v2.basic_rate_mask = cpu_to_le32(priv->basic_rate_mask);
                setup->v2.sbss_offset = 0;
                setup->v2.mcast_window = 0;
                setup->v2.rx_rssi_threshold = 0;
@@ -1271,18 +1498,19 @@ static int p54_setup_mac(struct ieee80211_hw *dev, u16 mode, const u8 *bssid)
                setup->v2.lpf_bandwidth = cpu_to_le16(65535);
                setup->v2.osc_start_delay = cpu_to_le16(65535);
        }
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 }
 
-static int p54_set_freq(struct ieee80211_hw *dev, u16 frequency)
+static int p54_scan(struct ieee80211_hw *dev, u16 mode, u16 dwell)
 {
        struct p54_common *priv = dev->priv;
        struct sk_buff *skb;
        struct p54_scan *chan;
        unsigned int i;
        void *entry;
-       __le16 freq = cpu_to_le16(frequency);
+       __le16 freq = cpu_to_le16(dev->conf.channel->center_freq);
+       int band = dev->conf.channel->band;
 
        skb = p54_alloc_skb(dev, P54_HDR_FLAG_CONTROL_OPSET, sizeof(*chan) +
                            sizeof(struct p54_hdr), P54_CONTROL_TYPE_SCAN,
@@ -1292,8 +1520,8 @@ static int p54_set_freq(struct ieee80211_hw *dev, u16 frequency)
 
        chan = (struct p54_scan *) skb_put(skb, sizeof(*chan));
        memset(chan->padding1, 0, sizeof(chan->padding1));
-       chan->mode = cpu_to_le16(P54_SCAN_EXIT);
-       chan->dwell = cpu_to_le16(0x0);
+       chan->mode = cpu_to_le16(mode);
+       chan->dwell = cpu_to_le16(dwell);
 
        for (i = 0; i < priv->iq_autocal_len; i++) {
                if (priv->iq_autocal[i].freq != freq)
@@ -1343,15 +1571,15 @@ static int p54_set_freq(struct ieee80211_hw *dev, u16 frequency)
        }
 
        if (priv->fw_var < 0x500) {
-               chan->v1.rssical_mul = cpu_to_le16(130);
-               chan->v1.rssical_add = cpu_to_le16(0xfe70);
+               chan->v1_rssi.mul = cpu_to_le16(priv->rssical_db[band].mul);
+               chan->v1_rssi.add = cpu_to_le16(priv->rssical_db[band].add);
        } else {
-               chan->v2.rssical_mul = cpu_to_le16(130);
-               chan->v2.rssical_add = cpu_to_le16(0xfe70);
-               chan->v2.basic_rate_mask = cpu_to_le32(0x15f);
+               chan->v2.rssi.mul = cpu_to_le16(priv->rssical_db[band].mul);
+               chan->v2.rssi.add = cpu_to_le16(priv->rssical_db[band].add);
+               chan->v2.basic_rate_mask = cpu_to_le32(priv->basic_rate_mask);
                memset(chan->v2.rts_rates, 0, 8);
        }
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 
  err:
@@ -1377,7 +1605,7 @@ static int p54_set_leds(struct ieee80211_hw *dev, int mode, int link, int act)
        led->led_permanent = cpu_to_le16(link);
        led->led_temporary = cpu_to_le16(act);
        led->duration = cpu_to_le16(1000);
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 }
 
@@ -1417,21 +1645,7 @@ static int p54_set_edcf(struct ieee80211_hw *dev)
        edcf->flags = 0;
        memset(edcf->mapping, 0, sizeof(edcf->mapping));
        memcpy(edcf->queue, priv->qos_params, sizeof(edcf->queue));
-       priv->tx(dev, skb, 1);
-       return 0;
-}
-
-static int p54_init_stats(struct ieee80211_hw *dev)
-{
-       struct p54_common *priv = dev->priv;
-
-       priv->cached_stats = p54_alloc_skb(dev, P54_HDR_FLAG_CONTROL,
-                       sizeof(struct p54_hdr) + sizeof(struct p54_statistics),
-                       P54_CONTROL_TYPE_STAT_READBACK, GFP_KERNEL);
-       if (!priv->cached_stats)
-                       return -ENOMEM;
-
-       mod_timer(&priv->stats_timer, jiffies + HZ);
+       priv->tx(dev, skb);
        return 0;
 }
 
@@ -1446,28 +1660,23 @@ static int p54_beacon_tim(struct sk_buff *skb)
        struct ieee80211_mgmt *mgmt = (void *)skb->data;
        u8 *pos, *end;
 
-       if (skb->len <= sizeof(mgmt)) {
-               printk(KERN_ERR "p54: beacon is too short!\n");
+       if (skb->len <= sizeof(mgmt))
                return -EINVAL;
-       }
 
        pos = (u8 *)mgmt->u.beacon.variable;
        end = skb->data + skb->len;
        while (pos < end) {
-               if (pos + 2 + pos[1] > end) {
-                       printk(KERN_ERR "p54: parsing beacon failed\n");
+               if (pos + 2 + pos[1] > end)
                        return -EINVAL;
-               }
 
                if (pos[0] == WLAN_EID_TIM) {
                        u8 dtim_len = pos[1];
                        u8 dtim_period = pos[3];
                        u8 *next = pos + 2 + dtim_len;
 
-                       if (dtim_len < 3) {
-                               printk(KERN_ERR "p54: invalid dtim len!\n");
+                       if (dtim_len < 3)
                                return -EINVAL;
-                       }
+
                        memmove(pos, next, end - next);
 
                        if (dtim_len > 3)
@@ -1524,16 +1733,27 @@ static int p54_start(struct ieee80211_hw *dev)
 
        mutex_lock(&priv->conf_mutex);
        err = priv->open(dev);
-       if (!err)
-               priv->mode = NL80211_IFTYPE_MONITOR;
+       if (err)
+               goto out;
        P54_SET_QUEUE(priv->qos_params[0], 0x0002, 0x0003, 0x0007, 47);
        P54_SET_QUEUE(priv->qos_params[1], 0x0002, 0x0007, 0x000f, 94);
        P54_SET_QUEUE(priv->qos_params[2], 0x0003, 0x000f, 0x03ff, 0);
        P54_SET_QUEUE(priv->qos_params[3], 0x0007, 0x000f, 0x03ff, 0);
        err = p54_set_edcf(dev);
-       if (!err)
-               err = p54_init_stats(dev);
+       if (err)
+               goto out;
+
+       memset(priv->bssid, ~0, ETH_ALEN);
+       priv->mode = NL80211_IFTYPE_MONITOR;
+       err = p54_setup_mac(dev);
+       if (err) {
+               priv->mode = NL80211_IFTYPE_UNSPECIFIED;
+               goto out;
+       }
+
+       queue_delayed_work(dev->workqueue, &priv->work, 0);
 
+out:
        mutex_unlock(&priv->conf_mutex);
        return err;
 }
@@ -1544,19 +1764,16 @@ static void p54_stop(struct ieee80211_hw *dev)
        struct sk_buff *skb;
 
        mutex_lock(&priv->conf_mutex);
-       del_timer(&priv->stats_timer);
-       p54_free_skb(dev, priv->cached_stats);
-       priv->cached_stats = NULL;
+       priv->mode = NL80211_IFTYPE_UNSPECIFIED;
+       cancel_delayed_work_sync(&priv->work);
        if (priv->cached_beacon)
                p54_tx_cancel(dev, priv->cached_beacon);
 
+       priv->stop(dev);
        while ((skb = skb_dequeue(&priv->tx_queue)))
                kfree_skb(skb);
-
        priv->cached_beacon = NULL;
-       priv->stop(dev);
        priv->tsf_high32 = priv->tsf_low32 = 0;
-       priv->mode = NL80211_IFTYPE_UNSPECIFIED;
        mutex_unlock(&priv->conf_mutex);
 }
 
@@ -1584,27 +1801,8 @@ static int p54_add_interface(struct ieee80211_hw *dev,
        }
 
        memcpy(priv->mac_addr, conf->mac_addr, ETH_ALEN);
-
-       p54_setup_mac(dev, P54_FILTER_TYPE_NONE, NULL);
-
-       switch (conf->type) {
-       case NL80211_IFTYPE_STATION:
-               p54_setup_mac(dev, P54_FILTER_TYPE_STATION, NULL);
-               break;
-       case NL80211_IFTYPE_AP:
-               p54_setup_mac(dev, P54_FILTER_TYPE_AP, priv->mac_addr);
-               break;
-       case NL80211_IFTYPE_ADHOC:
-       case NL80211_IFTYPE_MESH_POINT:
-               p54_setup_mac(dev, P54_FILTER_TYPE_IBSS, NULL);
-               break;
-       default:
-               BUG();  /* impossible */
-               break;
-       }
-
+       p54_setup_mac(dev);
        p54_set_leds(dev, 1, 0, 0);
-
        mutex_unlock(&priv->conf_mutex);
        return 0;
 }
@@ -1617,9 +1815,10 @@ static void p54_remove_interface(struct ieee80211_hw *dev,
        mutex_lock(&priv->conf_mutex);
        if (priv->cached_beacon)
                p54_tx_cancel(dev, priv->cached_beacon);
-       p54_setup_mac(dev, P54_FILTER_TYPE_NONE, NULL);
        priv->mode = NL80211_IFTYPE_MONITOR;
        memset(priv->mac_addr, 0, ETH_ALEN);
+       memset(priv->bssid, 0, ETH_ALEN);
+       p54_setup_mac(dev);
        mutex_unlock(&priv->conf_mutex);
 }
 
@@ -1630,11 +1829,20 @@ static int p54_config(struct ieee80211_hw *dev, u32 changed)
        struct ieee80211_conf *conf = &dev->conf;
 
        mutex_lock(&priv->conf_mutex);
-       priv->rx_antenna = 2; /* automatic */
-       priv->output_power = conf->power_level << 2;
-       ret = p54_set_freq(dev, conf->channel->center_freq);
-       if (!ret)
-               ret = p54_set_edcf(dev);
+       if (changed & IEEE80211_CONF_CHANGE_POWER)
+               priv->output_power = conf->power_level << 2;
+       if (changed & IEEE80211_CONF_CHANGE_RADIO_ENABLED) {
+               ret = p54_setup_mac(dev);
+               if (ret)
+                       goto out;
+       }
+       if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
+               ret = p54_scan(dev, P54_SCAN_EXIT, 0);
+               if (ret)
+                       goto out;
+       }
+
+out:
        mutex_unlock(&priv->conf_mutex);
        return ret;
 }
@@ -1647,36 +1855,30 @@ static int p54_config_interface(struct ieee80211_hw *dev,
        int ret = 0;
 
        mutex_lock(&priv->conf_mutex);
-       switch (priv->mode) {
-       case NL80211_IFTYPE_STATION:
-               ret = p54_setup_mac(dev, P54_FILTER_TYPE_STATION, conf->bssid);
+       if (conf->changed & IEEE80211_IFCC_BSSID) {
+               memcpy(priv->bssid, conf->bssid, ETH_ALEN);
+               ret = p54_setup_mac(dev);
                if (ret)
                        goto out;
-               ret = p54_set_leds(dev, 1,
-                                  !is_multicast_ether_addr(conf->bssid), 0);
+       }
+
+       if (conf->changed & IEEE80211_IFCC_BEACON) {
+               ret = p54_scan(dev, P54_SCAN_EXIT, 0);
                if (ret)
                        goto out;
-               memcpy(priv->bssid, conf->bssid, ETH_ALEN);
-               break;
-       case NL80211_IFTYPE_AP:
-       case NL80211_IFTYPE_ADHOC:
-       case NL80211_IFTYPE_MESH_POINT:
-               memcpy(priv->bssid, conf->bssid, ETH_ALEN);
-               ret = p54_set_freq(dev, dev->conf.channel->center_freq);
+               ret = p54_setup_mac(dev);
                if (ret)
                        goto out;
-               ret = p54_setup_mac(dev, priv->mac_mode, priv->bssid);
+               ret = p54_beacon_update(dev, vif);
+               if (ret)
+                       goto out;
+               ret = p54_set_edcf(dev);
                if (ret)
                        goto out;
-               if (conf->changed & IEEE80211_IFCC_BEACON) {
-                       ret = p54_beacon_update(dev, vif);
-                       if (ret)
-                               goto out;
-                       ret = p54_set_edcf(dev);
-                       if (ret)
-                               goto out;
-               }
        }
+
+       ret = p54_set_leds(dev, 1, !is_multicast_ether_addr(priv->bssid), 0);
+
 out:
        mutex_unlock(&priv->conf_mutex);
        return ret;
@@ -1689,25 +1891,14 @@ static void p54_configure_filter(struct ieee80211_hw *dev,
 {
        struct p54_common *priv = dev->priv;
 
-       *total_flags &= FIF_BCN_PRBRESP_PROMISC |
-                       FIF_PROMISC_IN_BSS |
-                       FIF_FCSFAIL;
+       *total_flags &= FIF_PROMISC_IN_BSS |
+                       (*total_flags & FIF_PROMISC_IN_BSS) ?
+                               FIF_FCSFAIL : 0;
 
        priv->filter_flags = *total_flags;
 
-       if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
-               if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
-                       p54_setup_mac(dev, priv->mac_mode, NULL);
-               else
-                       p54_setup_mac(dev, priv->mac_mode, priv->bssid);
-       }
-
-       if (changed_flags & FIF_PROMISC_IN_BSS) {
-               if (*total_flags & FIF_PROMISC_IN_BSS)
-                       p54_setup_mac(dev, priv->mac_mode | 0x8, NULL);
-               else
-                       p54_setup_mac(dev, priv->mac_mode & ~0x8, priv->bssid);
-       }
+       if (changed_flags & FIF_PROMISC_IN_BSS)
+               p54_setup_mac(dev);
 }
 
 static int p54_conf_tx(struct ieee80211_hw *dev, u16 queue,
@@ -1720,10 +1911,9 @@ static int p54_conf_tx(struct ieee80211_hw *dev, u16 queue,
        if ((params) && !(queue > 4)) {
                P54_SET_QUEUE(priv->qos_params[queue], params->aifs,
                        params->cw_min, params->cw_max, params->txop);
+               ret = p54_set_edcf(dev);
        } else
                ret = -EINVAL;
-       if (!ret)
-               ret = p54_set_edcf(dev);
        mutex_unlock(&priv->conf_mutex);
        return ret;
 }
@@ -1746,18 +1936,33 @@ static int p54_init_xbow_synth(struct ieee80211_hw *dev)
        xbow->magic2 = cpu_to_le16(0x2);
        xbow->freq = cpu_to_le16(5390);
        memset(xbow->padding, 0, sizeof(xbow->padding));
-       priv->tx(dev, skb, 1);
+       priv->tx(dev, skb);
        return 0;
 }
 
-static void p54_statistics_timer(unsigned long data)
+static void p54_work(struct work_struct *work)
 {
-       struct ieee80211_hw *dev = (struct ieee80211_hw *) data;
-       struct p54_common *priv = dev->priv;
+       struct p54_common *priv = container_of(work, struct p54_common,
+                                              work.work);
+       struct ieee80211_hw *dev = priv->hw;
+       struct sk_buff *skb;
+
+       if (unlikely(priv->mode == NL80211_IFTYPE_UNSPECIFIED))
+               return ;
+
+       /*
+        * TODO: walk through tx_queue and do the following tasks
+        *      1. initiate bursts.
+        *      2. cancel stuck frames / reset the device if necessary.
+        */
 
-       BUG_ON(!priv->cached_stats);
+       skb = p54_alloc_skb(dev, P54_HDR_FLAG_CONTROL, sizeof(struct p54_hdr) +
+                           sizeof(struct p54_statistics),
+                           P54_CONTROL_TYPE_STAT_READBACK, GFP_KERNEL);
+       if (!skb)
+               return ;
 
-       priv->tx(dev, priv->cached_stats, 0);
+       priv->tx(dev, skb);
 }
 
 static int p54_get_stats(struct ieee80211_hw *dev,
@@ -1765,17 +1970,7 @@ static int p54_get_stats(struct ieee80211_hw *dev,
 {
        struct p54_common *priv = dev->priv;
 
-       del_timer(&priv->stats_timer);
-       p54_statistics_timer((unsigned long)dev);
-
-       if (!wait_for_completion_interruptible_timeout(&priv->stats_comp, HZ)) {
-               printk(KERN_ERR "%s: device does not respond!\n",
-                       wiphy_name(dev->wiphy));
-               return -EBUSY;
-       }
-
        memcpy(stats, &priv->stats, sizeof(*stats));
-
        return 0;
 }
 
@@ -1800,6 +1995,108 @@ static void p54_bss_info_changed(struct ieee80211_hw *dev,
                priv->use_short_slot = info->use_short_slot;
                p54_set_edcf(dev);
        }
+       if (changed & BSS_CHANGED_BASIC_RATES) {
+               if (dev->conf.channel->band == IEEE80211_BAND_5GHZ)
+                       priv->basic_rate_mask = (info->basic_rates << 4);
+               else
+                       priv->basic_rate_mask = info->basic_rates;
+               p54_setup_mac(dev);
+               if (priv->fw_var >= 0x500)
+                       p54_scan(dev, P54_SCAN_EXIT, 0);
+       }
+       if (changed & BSS_CHANGED_ASSOC) {
+               if (info->assoc) {
+                       priv->aid = info->aid;
+                       priv->wakeup_timer = info->beacon_int *
+                                            info->dtim_period * 5;
+                       p54_setup_mac(dev);
+               }
+       }
+
+}
+
+static int p54_set_key(struct ieee80211_hw *dev, enum set_key_cmd cmd,
+                      const u8 *local_address, const u8 *address,
+                      struct ieee80211_key_conf *key)
+{
+       struct p54_common *priv = dev->priv;
+       struct sk_buff *skb;
+       struct p54_keycache *rxkey;
+       u8 algo = 0;
+
+       if (modparam_nohwcrypt)
+               return -EOPNOTSUPP;
+
+       if (cmd == DISABLE_KEY)
+               algo = 0;
+       else {
+               switch (key->alg) {
+               case ALG_TKIP:
+                       if (!(priv->privacy_caps & (BR_DESC_PRIV_CAP_MICHAEL |
+                             BR_DESC_PRIV_CAP_TKIP)))
+                               return -EOPNOTSUPP;
+                       key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
+                       algo = P54_CRYPTO_TKIPMICHAEL;
+                       break;
+               case ALG_WEP:
+                       if (!(priv->privacy_caps & BR_DESC_PRIV_CAP_WEP))
+                               return -EOPNOTSUPP;
+                       key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
+                       algo = P54_CRYPTO_WEP;
+                       break;
+               case ALG_CCMP:
+                       if (!(priv->privacy_caps & BR_DESC_PRIV_CAP_AESCCMP))
+                               return -EOPNOTSUPP;
+                       key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
+                       algo = P54_CRYPTO_AESCCMP;
+                       break;
+               default:
+                       return -EINVAL;
+               }
+       }
+
+       if (key->keyidx > priv->rx_keycache_size) {
+               /*
+                * The device supports the choosen algorithm, but the firmware
+                * does not provide enough key slots to store all of them.
+                * So, incoming frames have to be decoded by the mac80211 stack,
+                * but we can still offload encryption for outgoing frames.
+                */
+
+               return 0;
+       }
+
+       mutex_lock(&priv->conf_mutex);
+       skb = p54_alloc_skb(dev, P54_HDR_FLAG_CONTROL_OPSET, sizeof(*rxkey) +
+                       sizeof(struct p54_hdr), P54_CONTROL_TYPE_RX_KEYCACHE,
+                       GFP_ATOMIC);
+       if (!skb) {
+               mutex_unlock(&priv->conf_mutex);
+               return -ENOMEM;
+       }
+
+       /* TODO: some devices have 4 more free slots for rx keys */
+       rxkey = (struct p54_keycache *)skb_put(skb, sizeof(*rxkey));
+       rxkey->entry = key->keyidx;
+       rxkey->key_id = key->keyidx;
+       rxkey->key_type = algo;
+       if (address)
+               memcpy(rxkey->mac, address, ETH_ALEN);
+       else
+               memset(rxkey->mac, ~0, ETH_ALEN);
+       if (key->alg != ALG_TKIP) {
+               rxkey->key_len = min((u8)16, key->keylen);
+               memcpy(rxkey->key, key->key, rxkey->key_len);
+       } else {
+               rxkey->key_len = 24;
+               memcpy(rxkey->key, key->key, 16);
+               memcpy(&(rxkey->key[16]), &(key->key
+                       [NL80211_TKIP_DATA_OFFSET_RX_MIC_KEY]), 8);
+       }
+
+       priv->tx(dev, skb);
+       mutex_unlock(&priv->conf_mutex);
+       return 0;
 }
 
 static const struct ieee80211_ops p54_ops = {
@@ -1809,6 +2106,8 @@ static const struct ieee80211_ops p54_ops = {
        .add_interface          = p54_add_interface,
        .remove_interface       = p54_remove_interface,
        .set_tim                = p54_set_tim,
+       .sta_notify             = p54_sta_notify,
+       .set_key                = p54_set_key,
        .config                 = p54_config,
        .config_interface       = p54_config_interface,
        .bss_info_changed       = p54_bss_info_changed,
@@ -1828,7 +2127,9 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
                return NULL;
 
        priv = dev->priv;
+       priv->hw = dev;
        priv->mode = NL80211_IFTYPE_UNSPECIFIED;
+       priv->basic_rate_mask = 0x15f;
        skb_queue_head_init(&priv->tx_queue);
        dev->flags = IEEE80211_HW_RX_INCLUDES_FCS |
                     IEEE80211_HW_SIGNAL_DBM |
@@ -1862,9 +2163,7 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
 
        mutex_init(&priv->conf_mutex);
        init_completion(&priv->eeprom_comp);
-       init_completion(&priv->stats_comp);
-       setup_timer(&priv->stats_timer, p54_statistics_timer,
-               (unsigned long)dev);
+       INIT_DELAYED_WORK(&priv->work, p54_work);
 
        return dev;
 }
@@ -1873,8 +2172,6 @@ EXPORT_SYMBOL_GPL(p54_init_common);
 void p54_free_common(struct ieee80211_hw *dev)
 {
        struct p54_common *priv = dev->priv;
-       del_timer(&priv->stats_timer);
-       kfree_skb(priv->cached_stats);
        kfree(priv->iq_autocal);
        kfree(priv->output_limit);
        kfree(priv->curve_data);