#include <linux/writeback.h>
#include <linux/statfs.h>
#include <linux/compat.h>
+#include <linux/bit_spinlock.h>
#include "ctree.h"
#include "disk-io.h"
#include "transaction.h"
path = btrfs_alloc_path();
BUG_ON(!path);
- btrfs_init_path(path);
mutex_lock(&root->fs_info->fs_mutex);
memcpy(&location, &BTRFS_I(inode)->location, sizeof(location));
path = btrfs_alloc_path();
BUG_ON(!path);
- btrfs_init_path(path);
ret = btrfs_lookup_inode(trans, root, path,
&BTRFS_I(inode)->location, 1);
if (ret) {
struct btrfs_dir_item *di;
path = btrfs_alloc_path();
- BUG_ON(!path);
- btrfs_init_path(path);
+ if (!path) {
+ ret = -ENOMEM;
+ goto err;
+ }
+
di = btrfs_lookup_dir_item(trans, root, path, dir->i_ino,
name, name_len, -1);
if (IS_ERR(di)) {
}
objectid = btrfs_disk_key_objectid(&di->location);
ret = btrfs_delete_one_dir_name(trans, root, path, di);
- BUG_ON(ret);
+ if (ret)
+ goto err;
btrfs_release_path(root, path);
di = btrfs_lookup_dir_index_item(trans, root, path, dir->i_ino,
goto err;
}
ret = btrfs_delete_one_dir_name(trans, root, path, di);
- BUG_ON(ret);
dentry->d_inode->i_ctime = dir->i_ctime;
err:
dir->i_size -= name_len * 2;
btrfs_update_inode(trans, root, dir);
drop_nlink(dentry->d_inode);
- btrfs_update_inode(trans, root, dentry->d_inode);
+ ret = btrfs_update_inode(trans, root, dentry->d_inode);
dir->i_sb->s_dirt = 1;
}
return ret;
path = btrfs_alloc_path();
BUG_ON(!path);
- btrfs_init_path(path);
mutex_lock(&root->fs_info->fs_mutex);
trans = btrfs_start_transaction(root, 1);
btrfs_set_trans_block_group(trans, dir);
path = btrfs_alloc_path();
BUG_ON(!path);
- btrfs_init_path(path);
ret = btrfs_lookup_inode(trans, root, path,
&BTRFS_I(inode)->location, -1);
- BUG_ON(ret);
- ret = btrfs_del_item(trans, root, path);
- BUG_ON(ret);
+ if (ret > 0)
+ ret = -ENOENT;
+ if (!ret)
+ ret = btrfs_del_item(trans, root, path);
btrfs_free_path(path);
return ret;
}
}
if (del_item) {
ret = btrfs_del_item(trans, root, path);
- BUG_ON(ret);
+ if (ret)
+ goto error;
} else {
break;
}
goto out;
if (!PageUptodate(page)) {
- ret = mpage_readpage(page, btrfs_get_block);
+ ret = btrfs_readpage(NULL, page);
lock_page(page);
if (!PageUptodate(page)) {
ret = -EIO;
page->index << PAGE_CACHE_SHIFT,
(page->index + 1) << PAGE_CACHE_SHIFT,
&alloc_hint);
- BUG_ON(ret);
+ if (ret)
+ goto out;
ret = btrfs_alloc_extent(trans, root, inode->i_ino, 1,
alloc_hint, (u64)-1, &ins, 1);
- BUG_ON(ret);
+ if (ret)
+ goto out;
ret = btrfs_insert_file_extent(trans, root, inode->i_ino,
page->index << PAGE_CACHE_SHIFT,
ins.objectid, 1, 1);
- BUG_ON(ret);
+ if (ret)
+ goto out;
SetPageChecked(page);
kaddr = kmap(page);
memset(kaddr + offset, 0, PAGE_CACHE_SIZE - offset);
flush_dcache_page(page);
- btrfs_csum_file_block(trans, root, inode->i_ino,
+ ret = btrfs_csum_file_block(trans, root, inode->i_ino,
page->index << PAGE_CACHE_SHIFT,
kaddr, PAGE_CACHE_SIZE);
kunmap(page);
btrfs_set_trans_block_group(trans, inode);
err = btrfs_insert_file_extent(trans, root, inode->i_ino,
pos, 0, 0, hole_size);
- BUG_ON(err);
btrfs_end_transaction(trans, root);
mutex_unlock(&root->fs_info->fs_mutex);
+ if (err)
+ return err;
}
out:
err = inode_setattr(inode, attr);
trans = btrfs_start_transaction(root, 1);
btrfs_set_trans_block_group(trans, inode);
ret = btrfs_truncate_in_trans(trans, root, inode);
- BUG_ON(ret);
- btrfs_free_inode(trans, root, inode);
+ if (ret)
+ goto no_delete_lock;
+ ret = btrfs_free_inode(trans, root, inode);
+ if (ret)
+ goto no_delete_lock;
btrfs_end_transaction(trans, root);
mutex_unlock(&root->fs_info->fs_mutex);
btrfs_btree_balance_dirty(root);
return;
+
+no_delete_lock:
+ btrfs_end_transaction(trans, root);
+ mutex_unlock(&root->fs_info->fs_mutex);
+ btrfs_btree_balance_dirty(root);
no_delete:
clear_inode(inode);
}
path = btrfs_alloc_path();
BUG_ON(!path);
- btrfs_init_path(path);
di = btrfs_lookup_dir_item(NULL, root, path, dir->i_ino, name,
namelen, 0);
if (!di || IS_ERR(di)) {
btrfs_set_key_type(&key, key_type);
key.offset = filp->f_pos;
path = btrfs_alloc_path();
- btrfs_init_path(path);
ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
if (ret < 0)
goto err;
}
/*
- * This is somewhat expense, updating the tree every time the
+ * This is somewhat expensive, updating the tree every time the
* inode changes. But, it is most likely to find the inode in cache.
* FIXME, needs more benchmarking...there are no reasons other than performance
* to keep or drop this code.
btrfs_update_inode(trans, root, inode);
btrfs_end_transaction(trans, root);
mutex_unlock(&root->fs_info->fs_mutex);
- btrfs_btree_balance_dirty(root);
}
static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
btrfs_set_key_type(location, BTRFS_INODE_ITEM_KEY);
ret = btrfs_insert_inode(trans, root, objectid, &inode_item);
- BUG_ON(ret);
-
+ if (ret)
+ return ERR_PTR(ret);
insert_inode_hash(inode);
return inode;
}
drop_inode = 1;
dir->i_sb->s_dirt = 1;
btrfs_update_inode_block_group(trans, dir);
- btrfs_update_inode(trans, root, inode);
+ err = btrfs_update_inode(trans, root, inode);
+ if (err)
+ drop_inode = 1;
btrfs_end_transaction(trans, root);
mutex_unlock(&root->fs_info->fs_mutex);
path = btrfs_alloc_path();
BUG_ON(!path);
- btrfs_init_path(path);
if (create & BTRFS_GET_BLOCK_CREATE) {
- WARN_ON(1);
- /* this almost but not quite works */
+ /*
+ * danger!, this only works if the page is properly up
+ * to date somehow
+ */
trans = btrfs_start_transaction(root, 1);
if (!trans) {
err = -ENOMEM;
}
ret = btrfs_lookup_file_extent(NULL, root, path,
- inode->i_ino,
+ objectid,
iblock << inode->i_blkbits, 0);
if (ret < 0) {
err = ret;
ret = btrfs_alloc_extent(trans, root, inode->i_ino,
1, alloc_hint, (u64)-1,
&ins, 1);
- BUG_ON(ret);
+ if (ret) {
+ err = ret;
+ goto out;
+ }
ret = btrfs_insert_file_extent(trans, root, inode->i_ino,
iblock << inode->i_blkbits,
ins.objectid, ins.offset,
ins.offset);
- BUG_ON(ret);
- SetPageChecked(result->b_page);
+ if (ret) {
+ err = ret;
+ goto out;
+ }
btrfs_map_bh_to_logical(root, result, ins.objectid);
}
out:
- if (trans)
- err = btrfs_end_transaction(trans, root);
+ if (trans) {
+ ret = btrfs_end_transaction(trans, root);
+ if (!err)
+ err = ret;
+ }
btrfs_free_path(path);
return err;
}
return err;
}
+static int btrfs_get_block_csum(struct inode *inode, sector_t iblock,
+ struct buffer_head *result, int create)
+{
+ int ret;
+ struct btrfs_root *root = BTRFS_I(inode)->root;
+ struct page *page = result->b_page;
+ u64 offset = (page->index << PAGE_CACHE_SHIFT) + bh_offset(result);
+ struct btrfs_csum_item *item;
+ struct btrfs_path *path = NULL;
+
+ mutex_lock(&root->fs_info->fs_mutex);
+ ret = btrfs_get_block_lock(inode, iblock, result, create);
+ if (ret)
+ goto out;
+
+ path = btrfs_alloc_path();
+ item = btrfs_lookup_csum(NULL, root, path, inode->i_ino, offset, 0);
+ if (IS_ERR(item)) {
+ ret = PTR_ERR(item);
+ /* a csum that isn't present is a preallocated region. */
+ if (ret == -ENOENT || ret == -EFBIG)
+ ret = 0;
+ result->b_private = NULL;
+ goto out;
+ }
+ memcpy((char *)&result->b_private, &item->csum, BTRFS_CRC32_SIZE);
+out:
+ if (path)
+ btrfs_free_path(path);
+ mutex_unlock(&root->fs_info->fs_mutex);
+ return ret;
+}
+
static int btrfs_get_block_bmap(struct inode *inode, sector_t iblock,
struct buffer_head *result, int create)
{
return block_prepare_write(page, from, to, btrfs_get_block);
}
-static int btrfs_readpage(struct file *file, struct page *page)
+static void buffer_io_error(struct buffer_head *bh)
{
- return mpage_readpage(page, btrfs_get_block);
+ char b[BDEVNAME_SIZE];
+
+ printk(KERN_ERR "Buffer I/O error on device %s, logical block %Lu\n",
+ bdevname(bh->b_bdev, b),
+ (unsigned long long)bh->b_blocknr);
+}
+
+/*
+ * I/O completion handler for block_read_full_page() - pages
+ * which come unlocked at the end of I/O.
+ */
+static void btrfs_end_buffer_async_read(struct buffer_head *bh, int uptodate)
+{
+ unsigned long flags;
+ struct buffer_head *first;
+ struct buffer_head *tmp;
+ struct page *page;
+ int page_uptodate = 1;
+ struct inode *inode;
+ int ret;
+
+ BUG_ON(!buffer_async_read(bh));
+
+ page = bh->b_page;
+ inode = page->mapping->host;
+ if (uptodate) {
+ void *kaddr;
+ struct btrfs_root *root = BTRFS_I(page->mapping->host)->root;
+ if (bh->b_private) {
+ char csum[BTRFS_CRC32_SIZE];
+ kaddr = kmap_atomic(page, KM_IRQ0);
+ ret = btrfs_csum_data(root, kaddr + bh_offset(bh),
+ bh->b_size, csum);
+ BUG_ON(ret);
+ if (memcmp(csum, &bh->b_private, BTRFS_CRC32_SIZE)) {
+ u64 offset;
+ offset = (page->index << PAGE_CACHE_SHIFT) +
+ bh_offset(bh);
+ printk("btrfs csum failed ino %lu off %llu\n",
+ page->mapping->host->i_ino,
+ (unsigned long long)offset);
+ memset(kaddr + bh_offset(bh), 1, bh->b_size);
+ flush_dcache_page(page);
+ }
+ kunmap_atomic(kaddr, KM_IRQ0);
+ }
+ set_buffer_uptodate(bh);
+ } else {
+ clear_buffer_uptodate(bh);
+ if (printk_ratelimit())
+ buffer_io_error(bh);
+ SetPageError(page);
+ }
+
+ /*
+ * Be _very_ careful from here on. Bad things can happen if
+ * two buffer heads end IO at almost the same time and both
+ * decide that the page is now completely done.
+ */
+ first = page_buffers(page);
+ local_irq_save(flags);
+ bit_spin_lock(BH_Uptodate_Lock, &first->b_state);
+ clear_buffer_async_read(bh);
+ unlock_buffer(bh);
+ tmp = bh;
+ do {
+ if (!buffer_uptodate(tmp))
+ page_uptodate = 0;
+ if (buffer_async_read(tmp)) {
+ BUG_ON(!buffer_locked(tmp));
+ goto still_busy;
+ }
+ tmp = tmp->b_this_page;
+ } while (tmp != bh);
+ bit_spin_unlock(BH_Uptodate_Lock, &first->b_state);
+ local_irq_restore(flags);
+
+ /*
+ * If none of the buffers had errors and they are all
+ * uptodate then we can set the page uptodate.
+ */
+ if (page_uptodate && !PageError(page))
+ SetPageUptodate(page);
+ unlock_page(page);
+ return;
+
+still_busy:
+ bit_spin_unlock(BH_Uptodate_Lock, &first->b_state);
+ local_irq_restore(flags);
+ return;
+}
+
+/*
+ * Generic "read page" function for block devices that have the normal
+ * get_block functionality. This is most of the block device filesystems.
+ * Reads the page asynchronously --- the unlock_buffer() and
+ * set/clear_buffer_uptodate() functions propagate buffer state into the
+ * page struct once IO has completed.
+ */
+int btrfs_readpage(struct file *file, struct page *page)
+{
+ struct inode *inode = page->mapping->host;
+ sector_t iblock, lblock;
+ struct buffer_head *bh, *head, *arr[MAX_BUF_PER_PAGE];
+ unsigned int blocksize;
+ int nr, i;
+ int fully_mapped = 1;
+
+ BUG_ON(!PageLocked(page));
+ blocksize = 1 << inode->i_blkbits;
+ if (!page_has_buffers(page))
+ create_empty_buffers(page, blocksize, 0);
+ head = page_buffers(page);
+
+ iblock = (sector_t)page->index << (PAGE_CACHE_SHIFT - inode->i_blkbits);
+ lblock = (i_size_read(inode)+blocksize-1) >> inode->i_blkbits;
+ bh = head;
+ nr = 0;
+ i = 0;
+
+ do {
+ if (buffer_uptodate(bh))
+ continue;
+
+ if (!buffer_mapped(bh)) {
+ int err = 0;
+
+ fully_mapped = 0;
+ if (iblock < lblock) {
+ WARN_ON(bh->b_size != blocksize);
+ err = btrfs_get_block_csum(inode, iblock,
+ bh, 0);
+ if (err)
+ SetPageError(page);
+ }
+ if (!buffer_mapped(bh)) {
+ void *kaddr = kmap_atomic(page, KM_USER0);
+ memset(kaddr + i * blocksize, 0, blocksize);
+ flush_dcache_page(page);
+ kunmap_atomic(kaddr, KM_USER0);
+ if (!err)
+ set_buffer_uptodate(bh);
+ continue;
+ }
+ /*
+ * get_block() might have updated the buffer
+ * synchronously
+ */
+ if (buffer_uptodate(bh))
+ continue;
+ }
+ arr[nr++] = bh;
+ } while (i++, iblock++, (bh = bh->b_this_page) != head);
+
+ if (fully_mapped)
+ SetPageMappedToDisk(page);
+
+ if (!nr) {
+ /*
+ * All buffers are uptodate - we can set the page uptodate
+ * as well. But not if get_block() returned an error.
+ */
+ if (!PageError(page))
+ SetPageUptodate(page);
+ unlock_page(page);
+ return 0;
+ }
+
+ /* Stage two: lock the buffers */
+ for (i = 0; i < nr; i++) {
+ bh = arr[i];
+ lock_buffer(bh);
+ bh->b_end_io = btrfs_end_buffer_async_read;
+ set_buffer_async_read(bh);
+ }
+
+ /*
+ * Stage 3: start the IO. Check for uptodateness
+ * inside the buffer lock in case another process reading
+ * the underlying blockdev brought it uptodate (the sct fix).
+ */
+ for (i = 0; i < nr; i++) {
+ bh = arr[i];
+ if (buffer_uptodate(bh))
+ btrfs_end_buffer_async_read(bh, 1);
+ else
+ submit_bh(READ, bh);
+ }
+ return 0;
}
/*
struct buffer_head *bh, *head;
const unsigned blocksize = 1 << inode->i_blkbits;
int nr_underway = 0;
+ struct btrfs_root *root = BTRFS_I(inode)->root;
BUG_ON(!PageLocked(page));
last_block = (i_size_read(inode) - 1) >> inode->i_blkbits;
+ /* no csumming allowed when from PF_MEMALLOC */
+ if (current->flags & PF_MEMALLOC) {
+ redirty_page_for_writepage(wbc, page);
+ unlock_page(page);
+ return 0;
+ }
+
if (!page_has_buffers(page)) {
create_empty_buffers(page, blocksize,
(1 << BH_Dirty)|(1 << BH_Uptodate));
continue;
}
if (test_clear_buffer_dirty(bh) && bh->b_blocknr != 0) {
+ struct btrfs_trans_handle *trans;
+ int ret;
+ u64 off = page->index << PAGE_CACHE_SHIFT;
+ char *kaddr;
+
+ off += bh_offset(bh);
+ mutex_lock(&root->fs_info->fs_mutex);
+ trans = btrfs_start_transaction(root, 1);
+ btrfs_set_trans_block_group(trans, inode);
+ kaddr = kmap(page);
+ btrfs_csum_file_block(trans, root, inode->i_ino,
+ off, kaddr + bh_offset(bh),
+ bh->b_size);
+ kunmap(page);
+ ret = btrfs_end_transaction(trans, root);
+ BUG_ON(ret);
+ mutex_unlock(&root->fs_info->fs_mutex);
mark_buffer_async_write(bh);
} else {
unlock_buffer(bh);
return __btrfs_write_full_page(inode, page, wbc);
}
+/*
+ * btrfs_page_mkwrite() is not allowed to change the file size as it gets
+ * called from a page fault handler when a page is first dirtied. Hence we must
+ * be careful to check for EOF conditions here. We set the page up correctly
+ * for a written page which means we get ENOSPC checking when writing into
+ * holes and correct delalloc and unwritten extent mapping on filesystems that
+ * support these features.
+ *
+ * We are not allowed to take the i_mutex here so we have to play games to
+ * protect against truncate races as the page could now be beyond EOF. Because
+ * vmtruncate() writes the inode size before removing pages, once we have the
+ * page lock we can determine safely if the page is beyond EOF. If it is not
+ * beyond EOF, then the page is guaranteed safe against truncation until we
+ * unlock the page.
+ */
+int btrfs_page_mkwrite(struct vm_area_struct *vma, struct page *page)
+{
+ struct inode *inode = vma->vm_file->f_path.dentry->d_inode;
+ unsigned long end;
+ loff_t size;
+ int ret = -EINVAL;
+
+ lock_page(page);
+ wait_on_page_writeback(page);
+ size = i_size_read(inode);
+ if ((page->mapping != inode->i_mapping) ||
+ ((page->index << PAGE_CACHE_SHIFT) > size)) {
+ /* page got truncated out from underneath us */
+ goto out_unlock;
+ }
+
+ /* page is wholly or partially inside EOF */
+ if (((page->index + 1) << PAGE_CACHE_SHIFT) > size)
+ end = size & ~PAGE_CACHE_MASK;
+ else
+ end = PAGE_CACHE_SIZE;
+
+ ret = btrfs_prepare_write(NULL, page, 0, end);
+ if (!ret)
+ ret = btrfs_commit_write(NULL, page, 0, end);
+
+out_unlock:
+ unlock_page(page);
+ return ret;
+}
+
static void btrfs_truncate(struct inode *inode)
{
struct btrfs_root *root = BTRFS_I(inode)->root;
/* FIXME, add redo link to tree so we don't leak on crash */
ret = btrfs_truncate_in_trans(trans, root, inode);
- BUG_ON(ret);
btrfs_update_inode(trans, root, inode);
ret = btrfs_end_transaction(trans, root);
BUG_ON(ret);
struct inode *inode;
struct inode *dir;
int ret;
+ int err;
u64 objectid;
u64 new_dirid = BTRFS_FIRST_FREE_OBJECTID;
BUG_ON(!trans);
subvol = btrfs_alloc_free_block(trans, root, 0);
- if (subvol == NULL)
- return -ENOSPC;
+ if (IS_ERR(subvol))
+ return PTR_ERR(subvol);
leaf = btrfs_buffer_leaf(subvol);
btrfs_set_header_nritems(&leaf->header, 0);
btrfs_set_header_level(&leaf->header, 0);
btrfs_set_root_blocknr(&root_item, bh_blocknr(subvol));
btrfs_set_root_refs(&root_item, 1);
+ memset(&root_item.drop_progress, 0, sizeof(root_item.drop_progress));
+ root_item.drop_level = 0;
brelse(subvol);
subvol = NULL;
ret = btrfs_find_free_objectid(trans, root->fs_info->tree_root,
0, &objectid);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
btrfs_set_root_dirid(&root_item, new_dirid);
btrfs_set_key_type(&key, BTRFS_ROOT_ITEM_KEY);
ret = btrfs_insert_root(trans, root->fs_info->tree_root, &key,
&root_item);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
/*
* insert the directory item
ret = btrfs_insert_dir_item(trans, root->fs_info->tree_root,
name, namelen, dir->i_ino, &key,
BTRFS_FT_DIR);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
ret = btrfs_commit_transaction(trans, root);
- BUG_ON(ret);
+ if (ret)
+ goto fail_commit;
new_root = btrfs_read_fs_root(root->fs_info, &key);
BUG_ON(!new_root);
inode = btrfs_new_inode(trans, new_root, new_dirid,
BTRFS_I(dir)->block_group, S_IFDIR | 0700);
+ if (IS_ERR(inode))
+ goto fail;
inode->i_op = &btrfs_dir_inode_operations;
inode->i_fop = &btrfs_dir_file_operations;
new_root->inode = inode;
ret = btrfs_make_empty_dir(trans, new_root, new_dirid, new_dirid);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
inode->i_nlink = 1;
inode->i_size = 6;
ret = btrfs_update_inode(trans, new_root, inode);
- BUG_ON(ret);
-
- ret = btrfs_commit_transaction(trans, new_root);
- BUG_ON(ret);
-
+ if (ret)
+ goto fail;
+fail:
+ err = btrfs_commit_transaction(trans, root);
+ if (err && !ret)
+ ret = err;
+fail_commit:
mutex_unlock(&root->fs_info->fs_mutex);
btrfs_btree_balance_dirty(root);
- return 0;
+ return ret;
}
static int create_snapshot(struct btrfs_root *root, char *name, int namelen)
struct btrfs_key key;
struct btrfs_root_item new_root_item;
int ret;
+ int err;
u64 objectid;
if (!root->ref_cows)
BUG_ON(!trans);
ret = btrfs_update_inode(trans, root, root->inode);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
ret = btrfs_find_free_objectid(trans, root->fs_info->tree_root,
0, &objectid);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
memcpy(&new_root_item, &root->root_item,
sizeof(new_root_item));
ret = btrfs_insert_root(trans, root->fs_info->tree_root, &key,
&new_root_item);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
/*
* insert the directory item
root->fs_info->sb->s_root->d_inode->i_ino,
&key, BTRFS_FT_DIR);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
ret = btrfs_inc_root_ref(trans, root);
- BUG_ON(ret);
+ if (ret)
+ goto fail;
- ret = btrfs_commit_transaction(trans, root);
- BUG_ON(ret);
+fail:
+ err = btrfs_commit_transaction(trans, root);
+ if (err && !ret)
+ ret = err;
mutex_unlock(&root->fs_info->fs_mutex);
btrfs_btree_balance_dirty(root);
- return 0;
+ return ret;
}
int btrfs_ioctl(struct inode *inode, struct file *filp, unsigned int
btrfs_free_path(path);
if (di && !IS_ERR(di))
return -EEXIST;
+ if (IS_ERR(di))
+ return PTR_ERR(di);
if (root == root->fs_info->tree_root)
ret = create_subvol(root, vol_args.name, namelen);
else
ret = create_snapshot(root, vol_args.name, namelen);
- WARN_ON(ret);
break;
default:
return -ENOTTY;
old_parent_oid = btrfs_disk_key_objectid(&di->location);
ret = btrfs_del_item(trans, root, path);
if (ret) {
- ret = -EIO;
goto out_fail;
}
btrfs_release_path(root, path);
}
ret = btrfs_del_item(trans, root, path);
if (ret) {
- ret = -EIO;
goto out_fail;
}
btrfs_release_path(root, path);
clear_nlink(new_inode);
else
drop_nlink(new_inode);
- btrfs_update_inode(trans, root, new_inode);
+ ret = btrfs_update_inode(trans, root, new_inode);
+ if (ret)
+ goto out_fail;
}
ret = btrfs_add_link(trans, new_dentry, old_inode);
if (ret)
datasize = btrfs_file_extent_calc_inline_size(name_len);
err = btrfs_insert_empty_item(trans, root, path, &key,
datasize);
- BUG_ON(err);
+ if (err) {
+ drop_inode = 1;
+ goto out_unlock;
+ }
ei = btrfs_item_ptr(btrfs_buffer_leaf(path->nodes[0]),
path->slots[0], struct btrfs_file_extent_item);
btrfs_set_file_extent_generation(ei, trans->transid);
inode->i_op = &btrfs_symlink_inode_operations;
inode->i_mapping->a_ops = &btrfs_symlink_aops;
inode->i_size = name_len - 1;
- btrfs_update_inode(trans, root, inode);
- err = 0;
+ err = btrfs_update_inode(trans, root, inode);
+ if (err)
+ drop_inode = 1;
out_unlock:
btrfs_end_transaction(trans, root);
mutex_unlock(&root->fs_info->fs_mutex);
-
if (drop_inode) {
inode_dec_link_count(inode);
iput(inode);
projects / linux-2.6-omap-h63xx.git / blobdiff