]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - fs/gfs2/ops_address.c
[GFS2] Fix a case where we didn't get unstuffing right
[linux-2.6-omap-h63xx.git] / fs / gfs2 / ops_address.c
index d352b3528f5e23fd66cef38842a0408f9b4f753b..1ccc264268214b7886a80b69756dfd1330dd5561 100644 (file)
 #include <linux/completion.h>
 #include <linux/buffer_head.h>
 #include <linux/pagemap.h>
+#include <linux/mpage.h>
+#include <linux/fs.h>
 #include <asm/semaphore.h>
 
 #include "gfs2.h"
 #include "bmap.h"
 #include "glock.h"
 #include "inode.h"
-#include "jdata.h"
 #include "log.h"
 #include "meta_io.h"
 #include "ops_address.h"
 #include "page.h"
 #include "quota.h"
 #include "trans.h"
+#include "rgrp.h"
+#include "ops_file.h"
 
 /**
- * get_block - Fills in a buffer head with details about a block
+ * gfs2_get_block - Fills in a buffer head with details about a block
  * @inode: The inode
  * @lblock: The block number to look up
  * @bh_result: The buffer head to return the result in
@@ -37,8 +40,8 @@
  * Returns: errno
  */
 
-static int get_block(struct inode *inode, sector_t lblock,
-                    struct buffer_head *bh_result, int create)
+int gfs2_get_block(struct inode *inode, sector_t lblock,
+                  struct buffer_head *bh_result, int create)
 {
        struct gfs2_inode *ip = get_v2ip(inode);
        int new = create;
@@ -148,33 +151,55 @@ static int get_blocks_noalloc(struct inode *inode, sector_t lblock,
  *
  * Returns: errno
  *
- * Use Linux VFS block_write_full_page() to write one page,
- *   using GFS2's get_block_noalloc to find which blocks to write.
+ * Some of this is copied from block_write_full_page() although we still
+ * call it to do most of the work.
  */
 
 static int gfs2_writepage(struct page *page, struct writeback_control *wbc)
 {
+       struct inode *inode = page->mapping->host;
        struct gfs2_inode *ip = get_v2ip(page->mapping->host);
        struct gfs2_sbd *sdp = ip->i_sbd;
+       loff_t i_size = i_size_read(inode);
+       pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT;
+       unsigned offset;
        int error;
+       int done_trans = 0;
 
        atomic_inc(&sdp->sd_ops_address);
-
        if (gfs2_assert_withdraw(sdp, gfs2_glock_is_held_excl(ip->i_gl))) {
                unlock_page(page);
                return -EIO;
        }
-       if (get_transaction) {
-               redirty_page_for_writepage(wbc, page);
+       if (get_transaction)
+               goto out_ignore;
+
+       /* Is the page fully outside i_size? (truncate in progress) */
+        offset = i_size & (PAGE_CACHE_SIZE-1);
+       if (page->index >= end_index+1 || !offset) {
+               page->mapping->a_ops->invalidatepage(page, 0);
                unlock_page(page);
-               return 0;
+               return 0; /* don't care */
        }
 
-       error = block_write_full_page(page, get_block_noalloc, wbc);
+       if (sdp->sd_args.ar_data == GFS2_DATA_ORDERED || gfs2_is_jdata(ip)) {
+               error = gfs2_trans_begin(sdp, RES_DINODE + 1, 0);
+               if (error)
+                       goto out_ignore;
+               gfs2_page_add_databufs(ip, page, 0, sdp->sd_vfs->s_blocksize-1);
+               done_trans = 1;
+       }
 
+       error = block_write_full_page(page, get_block_noalloc, wbc);
+       if (done_trans)
+               gfs2_trans_end(sdp);
        gfs2_meta_cache_flush(ip);
-
        return error;
+
+out_ignore:
+       redirty_page_for_writepage(wbc, page);
+       unlock_page(page);
+       return 0;
 }
 
 /**
@@ -195,14 +220,14 @@ static int stuffed_readpage(struct gfs2_inode *ip, struct page *page)
        if (error)
                return error;
 
-       kaddr = kmap(page);
+       kaddr = kmap_atomic(page, KM_USER0);
        memcpy((char *)kaddr,
               dibh->b_data + sizeof(struct gfs2_dinode),
               ip->i_di.di_size);
        memset((char *)kaddr + ip->i_di.di_size,
               0,
               PAGE_CACHE_SIZE - ip->i_di.di_size);
-       kunmap(page);
+       kunmap_atomic(page, KM_USER0);
 
        brelse(dibh);
 
@@ -215,9 +240,9 @@ static int zero_readpage(struct page *page)
 {
        void *kaddr;
 
-       kaddr = kmap(page);
+       kaddr = kmap_atomic(page, KM_USER0);
        memset(kaddr, 0, PAGE_CACHE_SIZE);
-       kunmap(page);
+       kunmap_atomic(page, KM_USER0);
 
        SetPageUptodate(page);
        unlock_page(page);
@@ -225,41 +250,10 @@ static int zero_readpage(struct page *page)
        return 0;
 }
 
-/**
- * jdata_readpage - readpage that goes through gfs2_jdata_read_mem()
- * @ip:
- * @page: The page to read
- *
- * Returns: errno
- */
-
-static int jdata_readpage(struct gfs2_inode *ip, struct page *page)
-{
-       void *kaddr;
-       int ret;
-
-       kaddr = kmap(page);
-
-       ret = gfs2_jdata_read_mem(ip, kaddr,
-                                 (uint64_t)page->index << PAGE_CACHE_SHIFT,
-                                 PAGE_CACHE_SIZE);
-       if (ret >= 0) {
-               if (ret < PAGE_CACHE_SIZE)
-                       memset(kaddr + ret, 0, PAGE_CACHE_SIZE - ret);
-               SetPageUptodate(page);
-               ret = 0;
-       }
-
-       kunmap(page);
-
-       unlock_page(page);
-
-       return ret;
-}
-
 /**
  * gfs2_readpage - readpage with locking
- * @file: The file to read a page for
+ * @file: The file to read a page for. N.B. This may be NULL if we are
+ * reading an internal file.
  * @page: The page to read
  *
  * Returns: errno
@@ -269,31 +263,39 @@ static int gfs2_readpage(struct file *file, struct page *page)
 {
        struct gfs2_inode *ip = get_v2ip(page->mapping->host);
        struct gfs2_sbd *sdp = ip->i_sbd;
+       struct gfs2_holder gh;
        int error;
 
        atomic_inc(&sdp->sd_ops_address);
 
-       if (gfs2_assert_warn(sdp, gfs2_glock_is_locked_by_me(ip->i_gl))) {
-               unlock_page(page);
-               return -EOPNOTSUPP;
+       if (file != &gfs2_internal_file_sentinal) {
+               gfs2_holder_init(ip->i_gl, LM_ST_SHARED, GL_ATIME, &gh);
+               error = gfs2_glock_nq_m_atime(1, &gh);
+               if (error)
+                       goto out_unlock;
        }
 
-       if (!gfs2_is_jdata(ip)) {
-               if (gfs2_is_stuffed(ip)) {
-                       if (!page->index) {
-                               error = stuffed_readpage(ip, page);
-                               unlock_page(page);
-                       } else
-                               error = zero_readpage(page);
+       if (gfs2_is_stuffed(ip)) {
+               if (!page->index) {
+                       error = stuffed_readpage(ip, page);
+                       unlock_page(page);
                } else
-                       error = block_read_full_page(page, get_block);
+                       error = zero_readpage(page);
        } else
-               error = jdata_readpage(ip, page);
+               error = mpage_readpage(page, gfs2_get_block);
 
        if (unlikely(test_bit(SDF_SHUTDOWN, &sdp->sd_flags)))
                error = -EIO;
 
+       if (file != &gfs2_internal_file_sentinal) {
+               gfs2_glock_dq_m(1, &gh);
+               gfs2_holder_uninit(&gh);
+       }
+out:
        return error;
+out_unlock:
+       unlock_page(page);
+       goto out;
 }
 
 /**
@@ -311,28 +313,82 @@ static int gfs2_prepare_write(struct file *file, struct page *page,
 {
        struct gfs2_inode *ip = get_v2ip(page->mapping->host);
        struct gfs2_sbd *sdp = ip->i_sbd;
+       unsigned int data_blocks, ind_blocks, rblocks;
+       int alloc_required;
        int error = 0;
+       loff_t pos = ((loff_t)page->index << PAGE_CACHE_SHIFT) + from;
+       loff_t end = ((loff_t)page->index << PAGE_CACHE_SHIFT) + to;
+       struct gfs2_alloc *al;
 
        atomic_inc(&sdp->sd_ops_address);
 
-       if (gfs2_assert_warn(sdp, gfs2_glock_is_locked_by_me(ip->i_gl)))
-               return -EOPNOTSUPP;
+       gfs2_holder_init(ip->i_gl, LM_ST_EXCLUSIVE, GL_ATIME, &ip->i_gh);
+       error = gfs2_glock_nq_m_atime(1, &ip->i_gh);
+       if (error)
+               goto out_uninit;
 
-       if (gfs2_is_stuffed(ip)) {
-               uint64_t file_size;
-               file_size = ((uint64_t)page->index << PAGE_CACHE_SHIFT) + to;
+       gfs2_write_calc_reserv(ip, to - from, &data_blocks, &ind_blocks);
+
+       error = gfs2_write_alloc_required(ip, pos, from - to, &alloc_required);
+       if (error)
+               goto out_unlock;
+
+
+       if (alloc_required) {
+               al = gfs2_alloc_get(ip);
 
-               if (file_size > sdp->sd_sb.sb_bsize -
-                               sizeof(struct gfs2_dinode)) {
-                       error = gfs2_unstuff_dinode(ip, gfs2_unstuffer_page,
-                                                   page);
-                       if (!error)
-                               error = block_prepare_write(page, from, to,
-                                                           get_block);
+               error = gfs2_quota_lock(ip, NO_QUOTA_CHANGE, NO_QUOTA_CHANGE);
+               if (error)
+                       goto out_alloc_put;
+
+               error = gfs2_quota_check(ip, ip->i_di.di_uid, ip->i_di.di_gid);
+               if (error)
+                       goto out_qunlock;
+
+               al->al_requested = data_blocks + ind_blocks;
+               error = gfs2_inplace_reserve(ip);
+               if (error)
+                       goto out_qunlock;
+       }
+
+       rblocks = RES_DINODE + ind_blocks;
+       if (gfs2_is_jdata(ip))
+               rblocks += data_blocks ? data_blocks : 1;
+       if (ind_blocks || data_blocks)
+               rblocks += RES_STATFS + RES_QUOTA;
+
+       error = gfs2_trans_begin(sdp, rblocks, 0);
+       if (error)
+               goto out;
+
+       if (gfs2_is_stuffed(ip)) {
+               if (end > sdp->sd_sb.sb_bsize - sizeof(struct gfs2_dinode)) {
+                       error = gfs2_unstuff_dinode(ip, gfs2_unstuffer_page, page);
+                       if (error == 0)
+                               goto prepare_write;
                } else if (!PageUptodate(page))
                        error = stuffed_readpage(ip, page);
-       } else
-               error = block_prepare_write(page, from, to, get_block);
+               goto out;
+       }
+
+prepare_write:
+       error = block_prepare_write(page, from, to, gfs2_get_block);
+
+out:
+       if (error) {
+               gfs2_trans_end(sdp);
+               if (alloc_required) {
+                       gfs2_inplace_release(ip);
+out_qunlock:
+                       gfs2_quota_unlock(ip);
+out_alloc_put:
+                       gfs2_alloc_put(ip);
+               }
+out_unlock:
+               gfs2_glock_dq_m(1, &ip->i_gh);
+out_uninit:
+               gfs2_holder_uninit(&ip->i_gh);
+       }
 
        return error;
 }
@@ -353,48 +409,73 @@ static int gfs2_commit_write(struct file *file, struct page *page,
        struct inode *inode = page->mapping->host;
        struct gfs2_inode *ip = get_v2ip(inode);
        struct gfs2_sbd *sdp = ip->i_sbd;
-       int error;
+       int error = -EOPNOTSUPP;
+       struct buffer_head *dibh;
+       struct gfs2_alloc *al = &ip->i_alloc;;
 
        atomic_inc(&sdp->sd_ops_address);
 
+
+       if (gfs2_assert_withdraw(sdp, gfs2_glock_is_locked_by_me(ip->i_gl)))
+                goto fail_nounlock;
+
+       error = gfs2_meta_inode_buffer(ip, &dibh);
+       if (error)
+               goto fail_endtrans;
+
+       gfs2_trans_add_bh(ip->i_gl, dibh, 1);
+
        if (gfs2_is_stuffed(ip)) {
-               struct buffer_head *dibh;
                uint64_t file_size;
                void *kaddr;
 
                file_size = ((uint64_t)page->index << PAGE_CACHE_SHIFT) + to;
 
-               error = gfs2_meta_inode_buffer(ip, &dibh);
-               if (error)
-                       goto fail;
-
-               gfs2_trans_add_bh(ip->i_gl, dibh, 1);
-
-               kaddr = kmap(page);
+               kaddr = kmap_atomic(page, KM_USER0);
                memcpy(dibh->b_data + sizeof(struct gfs2_dinode) + from,
-                      (char *)kaddr + from,
-                      to - from);
-               kunmap(page);
-
-               brelse(dibh);
+                      (char *)kaddr + from, to - from);
+               kunmap_atomic(page, KM_USER0);
 
                SetPageUptodate(page);
 
                if (inode->i_size < file_size)
                        i_size_write(inode, file_size);
        } else {
-               if (sdp->sd_args.ar_data == GFS2_DATA_ORDERED)
-                       gfs2_page_add_databufs(sdp, page, from, to);
+               if (sdp->sd_args.ar_data == GFS2_DATA_ORDERED || gfs2_is_jdata(ip))
+                       gfs2_page_add_databufs(ip, page, from, to);
                error = generic_commit_write(file, page, from, to);
                if (error)
                        goto fail;
        }
 
+       if (ip->i_di.di_size < inode->i_size)
+               ip->i_di.di_size = inode->i_size;
+
+       gfs2_dinode_out(&ip->i_di, dibh->b_data);
+       brelse(dibh);
+       gfs2_trans_end(sdp);
+       if (al->al_requested) {
+               gfs2_inplace_release(ip);
+               gfs2_quota_unlock(ip);
+               gfs2_alloc_put(ip);
+       }
+       gfs2_glock_dq_m(1, &ip->i_gh);
+       gfs2_holder_uninit(&ip->i_gh);
        return 0;
 
- fail:
+fail:
+       brelse(dibh);
+fail_endtrans:
+       gfs2_trans_end(sdp);
+       if (al->al_requested) {
+               gfs2_inplace_release(ip);
+               gfs2_quota_unlock(ip);
+               gfs2_alloc_put(ip);
+       }
+       gfs2_glock_dq_m(1, &ip->i_gh);
+       gfs2_holder_uninit(&ip->i_gh);
+fail_nounlock:
        ClearPageUptodate(page);
-
        return error;
 }
 
@@ -420,7 +501,7 @@ static sector_t gfs2_bmap(struct address_space *mapping, sector_t lblock)
                return 0;
 
        if (!gfs2_is_stuffed(ip))
-               dblock = generic_block_bmap(mapping, lblock, get_block);
+               dblock = generic_block_bmap(mapping, lblock, gfs2_get_block);
 
        gfs2_glock_dq_uninit(&i_gh);
 
@@ -429,13 +510,13 @@ static sector_t gfs2_bmap(struct address_space *mapping, sector_t lblock)
 
 static void discard_buffer(struct gfs2_sbd *sdp, struct buffer_head *bh)
 {
-       struct gfs2_databuf *db;
+       struct gfs2_bufdata *bd;
 
        gfs2_log_lock(sdp);
-       db = get_v2db(bh);
-       if (db) {
-               db->db_bh = NULL;
-               set_v2db(bh, NULL);
+       bd = get_v2bd(bh);
+       if (bd) {
+               bd->bd_bh = NULL;
+               set_v2bd(bh, NULL);
                gfs2_log_unlock(sdp);
                brelse(bh);
        } else
@@ -480,26 +561,73 @@ static int gfs2_invalidatepage(struct page *page, unsigned long offset)
        return ret;
 }
 
-static ssize_t gfs2_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov,
-                         loff_t offset, unsigned long nr_segs)
+static ssize_t gfs2_direct_IO_write(struct kiocb *iocb, const struct iovec *iov,
+                                   loff_t offset, unsigned long nr_segs)
+{
+       struct file *file = iocb->ki_filp;
+       struct inode *inode = file->f_mapping->host;
+       struct gfs2_inode *ip = get_v2ip(inode);
+       struct gfs2_holder gh;
+       int rv;
+
+       /*
+        * Shared lock, even though its write, since we do no allocation
+        * on this path. All we need change is atime.
+        */
+       gfs2_holder_init(ip->i_gl, LM_ST_SHARED, GL_ATIME, &gh);
+       rv = gfs2_glock_nq_m_atime(1, &gh);
+       if (rv)
+               goto out;
+
+       /*
+        * Should we return an error here? I can't see that O_DIRECT for
+        * a journaled file makes any sense. For now we'll silently fall
+        * back to buffered I/O, likewise we do the same for stuffed
+        * files since they are (a) small and (b) unaligned.
+        */
+       if (gfs2_is_jdata(ip))
+               goto out;
+
+       if (gfs2_is_stuffed(ip))
+               goto out;
+
+       rv = __blockdev_direct_IO(WRITE, iocb, inode, inode->i_sb->s_bdev,
+                                 iov, offset, nr_segs, get_blocks_noalloc,
+                                 NULL, DIO_OWN_LOCKING);
+out:
+       gfs2_glock_dq_m(1, &gh);
+       gfs2_holder_uninit(&gh);
+
+       return rv;
+}
+
+/**
+ * gfs2_direct_IO
+ *
+ * This is called with a shared lock already held for the read path.
+ * Currently, no locks are held when the write path is called.
+ */
+static ssize_t gfs2_direct_IO(int rw, struct kiocb *iocb,
+                             const struct iovec *iov, loff_t offset,
+                             unsigned long nr_segs)
 {
        struct file *file = iocb->ki_filp;
        struct inode *inode = file->f_mapping->host;
        struct gfs2_inode *ip = get_v2ip(inode);
        struct gfs2_sbd *sdp = ip->i_sbd;
-       get_blocks_t *gb = get_blocks;
 
        atomic_inc(&sdp->sd_ops_address);
 
+       if (rw == WRITE)
+               return gfs2_direct_IO_write(iocb, iov, offset, nr_segs);
+
        if (gfs2_assert_warn(sdp, gfs2_glock_is_locked_by_me(ip->i_gl)) ||
            gfs2_assert_warn(sdp, !gfs2_is_stuffed(ip)))
                return -EINVAL;
 
-       if (rw == WRITE && !get_transaction)
-               gb = get_blocks_noalloc;
-
-       return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov,
-                                 offset, nr_segs, gb, NULL);
+       return __blockdev_direct_IO(READ, iocb, inode, inode->i_sb->s_bdev, iov,
+                                   offset, nr_segs, get_blocks, NULL,
+                                   DIO_OWN_LOCKING);
 }
 
 struct address_space_operations gfs2_file_aops = {