]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - kernel/signal.c
signals: move handle_stop_signal() into send_signal()
[linux-2.6-omap-h63xx.git] / kernel / signal.c
index cc8303cd093dd5f05e7218b7f35d77d340bddc09..b3dedf1f932367ca09062d69a3ee6852984d34a8 100644 (file)
 
 static struct kmem_cache *sigqueue_cachep;
 
+static int __sig_ignored(struct task_struct *t, int sig)
+{
+       void __user *handler;
+
+       /* Is it explicitly or implicitly ignored? */
+
+       handler = t->sighand->action[sig - 1].sa.sa_handler;
+       return handler == SIG_IGN ||
+               (handler == SIG_DFL && sig_kernel_ignore(sig));
+}
 
 static int sig_ignored(struct task_struct *t, int sig)
 {
-       void __user * handler;
-
        /*
         * Tracers always want to know about signals..
         */
@@ -58,10 +66,7 @@ static int sig_ignored(struct task_struct *t, int sig)
        if (sigismember(&t->blocked, sig) || sigismember(&t->real_blocked, sig))
                return 0;
 
-       /* Is it explicitly or implicitly ignored? */
-       handler = t->sighand->action[sig-1].sa.sa_handler;
-       return   handler == SIG_IGN ||
-               (handler == SIG_DFL && sig_kernel_ignore(sig));
+       return __sig_ignored(t, sig);
 }
 
 /*
@@ -220,7 +225,7 @@ void flush_signals(struct task_struct *t)
        unsigned long flags;
 
        spin_lock_irqsave(&t->sighand->siglock, flags);
-       clear_tsk_thread_flag(t,TIF_SIGPENDING);
+       clear_tsk_thread_flag(t, TIF_SIGPENDING);
        flush_sigqueue(&t->pending);
        flush_sigqueue(&t->signal->shared_pending);
        spin_unlock_irqrestore(&t->sighand->siglock, flags);
@@ -372,7 +377,7 @@ static int __dequeue_signal(struct sigpending *pending, sigset_t *mask,
  */
 int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info)
 {
-       int signr = 0;
+       int signr;
 
        /* We only dequeue private signals from ourselves, we don't let
         * signalfd steal them
@@ -405,8 +410,12 @@ int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info)
                        }
                }
        }
+
        recalc_sigpending();
-       if (signr && unlikely(sig_kernel_stop(signr))) {
+       if (!signr)
+               return 0;
+
+       if (unlikely(sig_kernel_stop(signr))) {
                /*
                 * Set a marker that we have dequeued a stop signal.  Our
                 * caller might release the siglock and then the pending
@@ -422,9 +431,7 @@ int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info)
                if (!(tsk->signal->flags & SIGNAL_GROUP_EXIT))
                        tsk->signal->flags |= SIGNAL_STOP_DEQUEUED;
        }
-       if (signr &&
-            ((info->si_code & __SI_MASK) == __SI_TIMER) &&
-            info->si_sys_private){
+       if ((info->si_code & __SI_MASK) == __SI_TIMER && info->si_sys_private) {
                /*
                 * Release the siglock to ensure proper locking order
                 * of timer locks outside of siglocks.  Note, we leave
@@ -526,22 +533,23 @@ static int rm_from_queue(unsigned long mask, struct sigpending *s)
 static int check_kill_permission(int sig, struct siginfo *info,
                                 struct task_struct *t)
 {
-       int error = -EINVAL;
+       int error;
+
        if (!valid_signal(sig))
-               return error;
+               return -EINVAL;
 
-       if (info == SEND_SIG_NOINFO || (!is_si_special(info) && SI_FROMUSER(info))) {
-               error = audit_signal_info(sig, t); /* Let audit system see the signal */
-               if (error)
-                       return error;
-               error = -EPERM;
-               if (((sig != SIGCONT) ||
-                       (task_session_nr(current) != task_session_nr(t)))
-                   && (current->euid ^ t->suid) && (current->euid ^ t->uid)
-                   && (current->uid ^ t->suid) && (current->uid ^ t->uid)
-                   && !capable(CAP_KILL))
+       if (info != SEND_SIG_NOINFO && (is_si_special(info) || SI_FROMKERNEL(info)))
+               return 0;
+
+       error = audit_signal_info(sig, t); /* Let audit system see the signal */
+       if (error)
                return error;
-       }
+
+       if (((sig != SIGCONT) || (task_session_nr(current) != task_session_nr(t)))
+           && (current->euid ^ t->suid) && (current->euid ^ t->uid)
+           && (current->uid ^ t->suid) && (current->uid ^ t->uid)
+           && !capable(CAP_KILL))
+               return -EPERM;
 
        return security_task_kill(t, info, sig, 0);
 }
@@ -558,9 +566,10 @@ static void do_notify_parent_cldstop(struct task_struct *tsk, int why);
  */
 static void handle_stop_signal(int sig, struct task_struct *p)
 {
+       struct signal_struct *signal = p->signal;
        struct task_struct *t;
 
-       if (p->signal->flags & SIGNAL_GROUP_EXIT)
+       if (signal->flags & SIGNAL_GROUP_EXIT)
                /*
                 * The process is in the middle of dying already.
                 */
@@ -570,42 +579,22 @@ static void handle_stop_signal(int sig, struct task_struct *p)
                /*
                 * This is a stop signal.  Remove SIGCONT from all queues.
                 */
-               rm_from_queue(sigmask(SIGCONT), &p->signal->shared_pending);
+               rm_from_queue(sigmask(SIGCONT), &signal->shared_pending);
                t = p;
                do {
                        rm_from_queue(sigmask(SIGCONT), &t->pending);
-                       t = next_thread(t);
-               } while (t != p);
+               } while_each_thread(p, t);
        } else if (sig == SIGCONT) {
+               unsigned int why;
                /*
                 * Remove all stop signals from all queues,
                 * and wake all threads.
                 */
-               if (unlikely(p->signal->group_stop_count > 0)) {
-                       /*
-                        * There was a group stop in progress.  We'll
-                        * pretend it finished before we got here.  We are
-                        * obliged to report it to the parent: if the
-                        * SIGSTOP happened "after" this SIGCONT, then it
-                        * would have cleared this pending SIGCONT.  If it
-                        * happened "before" this SIGCONT, then the parent
-                        * got the SIGCHLD about the stop finishing before
-                        * the continue happened.  We do the notification
-                        * now, and it's as if the stop had finished and
-                        * the SIGCHLD was pending on entry to this kill.
-                        */
-                       p->signal->group_stop_count = 0;
-                       p->signal->flags = SIGNAL_STOP_CONTINUED;
-                       spin_unlock(&p->sighand->siglock);
-                       do_notify_parent_cldstop(p, CLD_STOPPED);
-                       spin_lock(&p->sighand->siglock);
-               }
-               rm_from_queue(SIG_KERNEL_STOP_MASK, &p->signal->shared_pending);
+               rm_from_queue(SIG_KERNEL_STOP_MASK, &signal->shared_pending);
                t = p;
                do {
                        unsigned int state;
                        rm_from_queue(SIG_KERNEL_STOP_MASK, &t->pending);
-                       
                        /*
                         * If there is a handler for SIGCONT, we must make
                         * sure that no thread returns to user mode before
@@ -615,7 +604,7 @@ static void handle_stop_signal(int sig, struct task_struct *p)
                         * running the handler.  With the TIF_SIGPENDING
                         * flag set, the thread will pause and acquire the
                         * siglock that we hold now and until we've queued
-                        * the pending signal. 
+                        * the pending signal.
                         *
                         * Wake up the stopped thread _after_ setting
                         * TIF_SIGPENDING
@@ -626,42 +615,62 @@ static void handle_stop_signal(int sig, struct task_struct *p)
                                state |= TASK_INTERRUPTIBLE;
                        }
                        wake_up_state(t, state);
+               } while_each_thread(p, t);
 
-                       t = next_thread(t);
-               } while (t != p);
-
-               if (p->signal->flags & SIGNAL_STOP_STOPPED) {
-                       /*
-                        * We were in fact stopped, and are now continued.
-                        * Notify the parent with CLD_CONTINUED.
-                        */
-                       p->signal->flags = SIGNAL_STOP_CONTINUED;
-                       p->signal->group_exit_code = 0;
-                       spin_unlock(&p->sighand->siglock);
-                       do_notify_parent_cldstop(p, CLD_CONTINUED);
-                       spin_lock(&p->sighand->siglock);
+               /*
+                * Notify the parent with CLD_CONTINUED if we were stopped.
+                *
+                * If we were in the middle of a group stop, we pretend it
+                * was already finished, and then continued. Since SIGCHLD
+                * doesn't queue we report only CLD_STOPPED, as if the next
+                * CLD_CONTINUED was dropped.
+                */
+               why = 0;
+               if (signal->flags & SIGNAL_STOP_STOPPED)
+                       why |= SIGNAL_CLD_CONTINUED;
+               else if (signal->group_stop_count)
+                       why |= SIGNAL_CLD_STOPPED;
+
+               if (why) {
+                       signal->flags = why | SIGNAL_STOP_CONTINUED;
+                       signal->group_stop_count = 0;
+                       signal->group_exit_code = 0;
                } else {
                        /*
                         * We are not stopped, but there could be a stop
                         * signal in the middle of being processed after
                         * being removed from the queue.  Clear that too.
                         */
-                       p->signal->flags = 0;
+                       signal->flags &= ~SIGNAL_STOP_DEQUEUED;
                }
        } else if (sig == SIGKILL) {
                /*
                 * Make sure that any pending stop signal already dequeued
                 * is undone by the wakeup for SIGKILL.
                 */
-               p->signal->flags = 0;
+               signal->flags &= ~SIGNAL_STOP_DEQUEUED;
        }
 }
 
+static inline int legacy_queue(struct sigpending *signals, int sig)
+{
+       return (sig < SIGRTMIN) && sigismember(&signals->signal, sig);
+}
+
 static int send_signal(int sig, struct siginfo *info, struct task_struct *t,
                        struct sigpending *signals)
 {
-       struct sigqueue * q = NULL;
-       int ret = 0;
+       struct sigqueue *q;
+
+       assert_spin_locked(&t->sighand->siglock);
+       handle_stop_signal(sig, t);
+       /*
+        * Short-circuit ignored signals and support queuing
+        * exactly one non-rt signal, so that we can get more
+        * detailed information about the cause of the signal.
+        */
+       if (sig_ignored(t, sig) || legacy_queue(signals, sig))
+               return 0;
 
        /*
         * Deliver the signal to listening signalfds. This must be called
@@ -719,12 +728,9 @@ static int send_signal(int sig, struct siginfo *info, struct task_struct *t,
 
 out_set:
        sigaddset(&signals->signal, sig);
-       return ret;
+       return 1;
 }
 
-#define LEGACY_QUEUE(sigptr, sig) \
-       (((sig) < SIGRTMIN) && sigismember(&(sigptr)->signal, (sig)))
-
 int print_fatal_signals;
 
 static void print_fatal_signal(struct pt_regs *regs, int signr)
@@ -760,26 +766,15 @@ __setup("print-fatal-signals=", setup_print_fatal_signals);
 static int
 specific_send_sig_info(int sig, struct siginfo *info, struct task_struct *t)
 {
-       int ret = 0;
-
-       BUG_ON(!irqs_disabled());
-       assert_spin_locked(&t->sighand->siglock);
-
-       /* Short-circuit ignored signals.  */
-       if (sig_ignored(t, sig))
-               goto out;
-
-       /* Support queueing exactly one non-rt signal, so that we
-          can get more detailed information about the cause of
-          the signal. */
-       if (LEGACY_QUEUE(&t->pending, sig))
-               goto out;
+       int ret;
 
        ret = send_signal(sig, info, t, &t->pending);
-       if (!ret && !sigismember(&t->blocked, sig))
+       if (ret <= 0)
+               return ret;
+
+       if (!sigismember(&t->blocked, sig))
                signal_wake_up(t, sig == SIGKILL);
-out:
-       return ret;
+       return 0;
 }
 
 /*
@@ -846,6 +841,7 @@ static inline int wants_signal(int sig, struct task_struct *p)
 static void
 __group_complete_signal(int sig, struct task_struct *p)
 {
+       struct signal_struct *signal = p->signal;
        struct task_struct *t;
 
        /*
@@ -866,14 +862,14 @@ __group_complete_signal(int sig, struct task_struct *p)
                /*
                 * Otherwise try to find a suitable thread.
                 */
-               t = p->signal->curr_target;
+               t = signal->curr_target;
                if (t == NULL)
                        /* restart balancing at this thread */
-                       t = p->signal->curr_target = p;
+                       t = signal->curr_target = p;
 
                while (!wants_signal(sig, t)) {
                        t = next_thread(t);
-                       if (t == p->signal->curr_target)
+                       if (t == signal->curr_target)
                                /*
                                 * No thread needs to be woken.
                                 * Any eligible threads will see
@@ -881,14 +877,14 @@ __group_complete_signal(int sig, struct task_struct *p)
                                 */
                                return;
                }
-               p->signal->curr_target = t;
+               signal->curr_target = t;
        }
 
        /*
         * Found a killable thread.  If the signal will be fatal,
         * then start taking the whole group down immediately.
         */
-       if (sig_fatal(p, sig) && !(p->signal->flags & SIGNAL_GROUP_EXIT) &&
+       if (sig_fatal(p, sig) && !(signal->flags & SIGNAL_GROUP_EXIT) &&
            !sigismember(&t->real_blocked, sig) &&
            (sig == SIGKILL || !(t->ptrace & PT_PTRACED))) {
                /*
@@ -901,9 +897,9 @@ __group_complete_signal(int sig, struct task_struct *p)
                         * running and doing things after a slower
                         * thread has the fatal signal pending.
                         */
-                       p->signal->flags = SIGNAL_GROUP_EXIT;
-                       p->signal->group_exit_code = sig;
-                       p->signal->group_stop_count = 0;
+                       signal->flags = SIGNAL_GROUP_EXIT;
+                       signal->group_exit_code = sig;
+                       signal->group_stop_count = 0;
                        t = p;
                        do {
                                sigaddset(&t->pending.signal, SIGKILL);
@@ -924,18 +920,7 @@ __group_complete_signal(int sig, struct task_struct *p)
 int
 __group_send_sig_info(int sig, struct siginfo *info, struct task_struct *p)
 {
-       int ret = 0;
-
-       assert_spin_locked(&p->sighand->siglock);
-       handle_stop_signal(sig, p);
-
-       /* Short-circuit ignored signals.  */
-       if (sig_ignored(p, sig))
-               return ret;
-
-       if (LEGACY_QUEUE(&p->signal->shared_pending, sig))
-               /* This is a non-RT signal and we already have one queued.  */
-               return ret;
+       int ret;
 
        /*
         * Put this signal on the shared-pending queue, or fail with EAGAIN.
@@ -943,7 +928,7 @@ __group_send_sig_info(int sig, struct siginfo *info, struct task_struct *p)
         * to avoid several races.
         */
        ret = send_signal(sig, info, p, &p->signal->shared_pending);
-       if (unlikely(ret))
+       if (ret <= 0)
                return ret;
 
        __group_complete_signal(sig, p);
@@ -978,13 +963,11 @@ int __fatal_signal_pending(struct task_struct *tsk)
 }
 EXPORT_SYMBOL(__fatal_signal_pending);
 
-/*
- * Must be called under rcu_read_lock() or with tasklist_lock read-held.
- */
 struct sighand_struct *lock_task_sighand(struct task_struct *tsk, unsigned long *flags)
 {
        struct sighand_struct *sighand;
 
+       rcu_read_lock();
        for (;;) {
                sighand = rcu_dereference(tsk->sighand);
                if (unlikely(sighand == NULL))
@@ -995,6 +978,7 @@ struct sighand_struct *lock_task_sighand(struct task_struct *tsk, unsigned long
                        break;
                spin_unlock_irqrestore(&sighand->siglock, *flags);
        }
+       rcu_read_unlock();
 
        return sighand;
 }
@@ -1043,9 +1027,6 @@ int kill_pid_info(int sig, struct siginfo *info, struct pid *pid)
        struct task_struct *p;
 
        rcu_read_lock();
-       if (unlikely(sig_needs_tasklist(sig)))
-               read_lock(&tasklist_lock);
-
 retry:
        p = pid_task(pid, PIDTYPE_PID);
        if (p) {
@@ -1059,10 +1040,8 @@ retry:
                         */
                        goto retry;
        }
-
-       if (unlikely(sig_needs_tasklist(sig)))
-               read_unlock(&tasklist_lock);
        rcu_read_unlock();
+
        return error;
 }
 
@@ -1291,10 +1270,35 @@ void sigqueue_free(struct sigqueue *q)
        __sigqueue_free(q);
 }
 
+static int do_send_sigqueue(int sig, struct sigqueue *q, struct task_struct *t,
+                               struct sigpending *pending)
+{
+       handle_stop_signal(sig, t);
+
+       if (unlikely(!list_empty(&q->list))) {
+               /*
+                * If an SI_TIMER entry is already queue just increment
+                * the overrun count.
+                */
+
+               BUG_ON(q->info.si_code != SI_TIMER);
+               q->info.si_overrun++;
+               return 0;
+       }
+
+       if (sig_ignored(t, sig))
+               return 1;
+
+       signalfd_notify(t, sig);
+       list_add_tail(&q->list, &pending->list);
+       sigaddset(&pending->signal, sig);
+       return 0;
+}
+
 int send_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)
 {
        unsigned long flags;
-       int ret = 0;
+       int ret = -1;
 
        BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
 
@@ -1306,43 +1310,16 @@ int send_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)
         * We return -1, when the task is marked exiting, so
         * posix_timer_event can redirect it to the group leader
         */
-       rcu_read_lock();
-
-       if (!likely(lock_task_sighand(p, &flags))) {
-               ret = -1;
+       if (!likely(lock_task_sighand(p, &flags)))
                goto out_err;
-       }
 
-       if (unlikely(!list_empty(&q->list))) {
-               /*
-                * If an SI_TIMER entry is already queue just increment
-                * the overrun count.
-                */
-               BUG_ON(q->info.si_code != SI_TIMER);
-               q->info.si_overrun++;
-               goto out;
-       }
-       /* Short-circuit ignored signals.  */
-       if (sig_ignored(p, sig)) {
-               ret = 1;
-               goto out;
-       }
-       /*
-        * Deliver the signal to listening signalfds. This must be called
-        * with the sighand lock held.
-        */
-       signalfd_notify(p, sig);
+       ret = do_send_sigqueue(sig, q, p, &p->pending);
 
-       list_add_tail(&q->list, &p->pending.list);
-       sigaddset(&p->pending.signal, sig);
        if (!sigismember(&p->blocked, sig))
                signal_wake_up(p, sig == SIGKILL);
 
-out:
        unlock_task_sighand(p, &flags);
 out_err:
-       rcu_read_unlock();
-
        return ret;
 }
 
@@ -1350,49 +1327,19 @@ int
 send_group_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)
 {
        unsigned long flags;
-       int ret = 0;
+       int ret;
 
        BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
 
-       read_lock(&tasklist_lock);
        /* Since it_lock is held, p->sighand cannot be NULL. */
        spin_lock_irqsave(&p->sighand->siglock, flags);
-       handle_stop_signal(sig, p);
 
-       /* Short-circuit ignored signals.  */
-       if (sig_ignored(p, sig)) {
-               ret = 1;
-               goto out;
-       }
-
-       if (unlikely(!list_empty(&q->list))) {
-               /*
-                * If an SI_TIMER entry is already queue just increment
-                * the overrun count.  Other uses should not try to
-                * send the signal multiple times.
-                */
-               BUG_ON(q->info.si_code != SI_TIMER);
-               q->info.si_overrun++;
-               goto out;
-       } 
-       /*
-        * Deliver the signal to listening signalfds. This must be called
-        * with the sighand lock held.
-        */
-       signalfd_notify(p, sig);
-
-       /*
-        * Put this signal on the shared-pending queue.
-        * We always use the shared queue for process-wide signals,
-        * to avoid several races.
-        */
-       list_add_tail(&q->list, &p->signal->shared_pending.list);
-       sigaddset(&p->signal->shared_pending.signal, sig);
+       ret = do_send_sigqueue(sig, q, p, &p->signal->shared_pending);
 
        __group_complete_signal(sig, p);
-out:
+
        spin_unlock_irqrestore(&p->sighand->siglock, flags);
-       read_unlock(&tasklist_lock);
+
        return ret;
 }
 
@@ -1724,7 +1671,7 @@ static int do_signal_stop(int signr)
                struct task_struct *t;
 
                if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
-                   unlikely(sig->group_exit_task))
+                   unlikely(signal_group_exit(sig)))
                        return 0;
                /*
                 * There is no group stop already in progress.
@@ -1799,8 +1746,9 @@ static int ptrace_signal(int signr, siginfo_t *info,
 int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka,
                          struct pt_regs *regs, void *cookie)
 {
-       sigset_t *mask = &current->blocked;
-       int signr = 0;
+       struct sighand_struct *sighand = current->sighand;
+       struct signal_struct *signal = current->signal;
+       int signr;
 
 relock:
        /*
@@ -1811,16 +1759,28 @@ relock:
         */
        try_to_freeze();
 
-       spin_lock_irq(&current->sighand->siglock);
+       spin_lock_irq(&sighand->siglock);
+
+       if (unlikely(signal->flags & SIGNAL_CLD_MASK)) {
+               int why = (signal->flags & SIGNAL_STOP_CONTINUED)
+                               ? CLD_CONTINUED : CLD_STOPPED;
+               signal->flags &= ~SIGNAL_CLD_MASK;
+               spin_unlock_irq(&sighand->siglock);
+
+               read_lock(&tasklist_lock);
+               do_notify_parent_cldstop(current->group_leader, why);
+               read_unlock(&tasklist_lock);
+               goto relock;
+       }
+
        for (;;) {
                struct k_sigaction *ka;
 
-               if (unlikely(current->signal->group_stop_count > 0) &&
+               if (unlikely(signal->group_stop_count > 0) &&
                    do_signal_stop(0))
                        goto relock;
 
-               signr = dequeue_signal(current, mask, info);
-
+               signr = dequeue_signal(current, &current->blocked, info);
                if (!signr)
                        break; /* will return 0 */
 
@@ -1830,7 +1790,7 @@ relock:
                                continue;
                }
 
-               ka = &current->sighand->action[signr-1];
+               ka = &sighand->action[signr-1];
                if (ka->sa.sa_handler == SIG_IGN) /* Do nothing.  */
                        continue;
                if (ka->sa.sa_handler != SIG_DFL) {
@@ -1867,14 +1827,14 @@ relock:
                         * We need to check for that and bail out if necessary.
                         */
                        if (signr != SIGSTOP) {
-                               spin_unlock_irq(&current->sighand->siglock);
+                               spin_unlock_irq(&sighand->siglock);
 
                                /* signals can be posted during this window */
 
                                if (is_current_pgrp_orphaned())
                                        goto relock;
 
-                               spin_lock_irq(&current->sighand->siglock);
+                               spin_lock_irq(&sighand->siglock);
                        }
 
                        if (likely(do_signal_stop(signr))) {
@@ -1889,7 +1849,7 @@ relock:
                        continue;
                }
 
-               spin_unlock_irq(&current->sighand->siglock);
+               spin_unlock_irq(&sighand->siglock);
 
                /*
                 * Anything else is fatal, maybe with a core dump.
@@ -1915,7 +1875,7 @@ relock:
                do_group_exit(signr);
                /* NOTREACHED */
        }
-       spin_unlock_irq(&current->sighand->siglock);
+       spin_unlock_irq(&sighand->siglock);
        return signr;
 }
 
@@ -2277,7 +2237,6 @@ static int do_tkill(int tgid, int pid, int sig)
                 */
                if (!error && sig && p->sighand) {
                        spin_lock_irq(&p->sighand->siglock);
-                       handle_stop_signal(sig, p);
                        error = specific_send_sig_info(sig, &info, p);
                        spin_unlock_irq(&p->sighand->siglock);
                }
@@ -2339,13 +2298,14 @@ sys_rt_sigqueueinfo(int pid, int sig, siginfo_t __user *uinfo)
 
 int do_sigaction(int sig, struct k_sigaction *act, struct k_sigaction *oact)
 {
+       struct task_struct *t = current;
        struct k_sigaction *k;
        sigset_t mask;
 
        if (!valid_signal(sig) || sig < 1 || (act && sig_kernel_only(sig)))
                return -EINVAL;
 
-       k = &current->sighand->action[sig-1];
+       k = &t->sighand->action[sig-1];
 
        spin_lock_irq(&current->sighand->siglock);
        if (oact)
@@ -2366,9 +2326,7 @@ int do_sigaction(int sig, struct k_sigaction *act, struct k_sigaction *oact)
                 *   (for example, SIGCHLD), shall cause the pending signal to
                 *   be discarded, whether or not it is blocked"
                 */
-               if (act->sa.sa_handler == SIG_IGN ||
-                  (act->sa.sa_handler == SIG_DFL && sig_kernel_ignore(sig))) {
-                       struct task_struct *t = current;
+               if (__sig_ignored(t, sig)) {
                        sigemptyset(&mask);
                        sigaddset(&mask, sig);
                        rm_from_queue_full(&mask, &t->signal->shared_pending);