X-Git-Url: http://pilppa.org/gitweb/?a=blobdiff_plain;f=list.c;h=661ecc6ded8f3a334cae1eeb4ef961d4d550cd27;hb=HEAD;hp=1a080fa9000d68d4f726e9ae17db5b2301b36bf5;hpb=853f586e4894aba060372b4655334921cda10464;p=uci.git diff --git a/list.c b/list.c index 1a080fa..661ecc6 100644 --- a/list.c +++ b/list.c @@ -36,7 +36,7 @@ static inline void uci_list_fixup(struct uci_list *ptr) * uci_alloc_generic allocates a new uci_element with payload * payload is appended to the struct to save memory and reduce fragmentation */ -static struct uci_element * +__private struct uci_element * uci_alloc_generic(struct uci_context *ctx, int type, const char *name, int size) { struct uci_element *e; @@ -62,7 +62,7 @@ done: return e; } -static void +__private void uci_free_element(struct uci_element *e) { if (e->name) @@ -72,8 +72,7 @@ uci_free_element(struct uci_element *e) free(e); } -static struct uci_option * -uci_alloc_option(struct uci_section *s, const char *name, const char *value) +struct uci_option *uci_alloc_option(struct uci_section *s, const char *name, const char *value) { struct uci_package *p = s->package; struct uci_context *ctx = p->ctx; @@ -224,8 +223,8 @@ uci_alloc_package(struct uci_context *ctx, const char *name) p = uci_alloc_element(ctx, package, name, 0); p->ctx = ctx; uci_list_init(&p->sections); - uci_list_init(&p->history); - uci_list_init(&p->saved_history); + uci_list_init(&p->delta); + uci_list_init(&p->saved_delta); return p; } @@ -243,11 +242,11 @@ uci_free_package(struct uci_package **package) uci_foreach_element_safe(&p->sections, tmp, e) { uci_free_section(uci_to_section(e)); } - uci_foreach_element_safe(&p->history, tmp, e) { - uci_free_history(uci_to_history(e)); + uci_foreach_element_safe(&p->delta, tmp, e) { + uci_free_delta(uci_to_delta(e)); } - uci_foreach_element_safe(&p->saved_history, tmp, e) { - uci_free_history(uci_to_history(e)); + uci_foreach_element_safe(&p->saved_delta, tmp, e) { + uci_free_delta(uci_to_delta(e)); } uci_free_element(&p->e); *package = NULL; @@ -357,6 +356,18 @@ done: return e; } +int +uci_lookup_next(struct uci_context *ctx, struct uci_element **e, struct uci_list *list, const char *name) +{ + UCI_HANDLE_ERR(ctx); + + *e = uci_lookup_list(list, name); + if (!*e) + UCI_THROW(ctx, UCI_ERR_NOTFOUND); + + return 0; +} + int uci_lookup_ptr(struct uci_context *ctx, struct uci_ptr *ptr, char *str, bool extended) { @@ -371,7 +382,11 @@ uci_lookup_ptr(struct uci_context *ctx, struct uci_ptr *ptr, char *str, bool ext ptr->flags |= UCI_LOOKUP_DONE; /* look up the package first */ - e = uci_lookup_list(&ctx->root, ptr->package); + if (ptr->p) + e = &ptr->p->e; + else + e = uci_lookup_list(&ctx->root, ptr->package); + if (!e) { UCI_INTERNAL(uci_load, ctx, ptr->package, &ptr->p); if (!ptr->p) @@ -382,15 +397,21 @@ uci_lookup_ptr(struct uci_context *ctx, struct uci_ptr *ptr, char *str, bool ext ptr->last = e; } - if (!ptr->section) + if (!ptr->section && !ptr->s) goto complete; /* if the section name validates as a regular name, pass through * to the regular uci_lookup function call */ - if (ptr->flags & UCI_LOOKUP_EXTENDED) - e = uci_lookup_ext_section(ctx, ptr); - else + if (ptr->s) { + e = &ptr->s->e; + } else if (ptr->flags & UCI_LOOKUP_EXTENDED) { + if (extended) + e = uci_lookup_ext_section(ctx, ptr); + else + UCI_THROW(ctx, UCI_ERR_INVAL); + } else { e = uci_lookup_list(&ptr->p->sections, ptr->section); + } if (!e) goto abort; @@ -417,8 +438,8 @@ notfound: return 0; } -static struct uci_element * -expand_ptr(struct uci_context *ctx, struct uci_ptr *ptr, bool complete) +__private struct uci_element * +uci_expand_ptr(struct uci_context *ctx, struct uci_ptr *ptr, bool complete) { UCI_ASSERT(ctx, ptr != NULL); @@ -452,8 +473,8 @@ static void uci_add_element_list(struct uci_context *ctx, struct uci_ptr *ptr, b struct uci_package *p; p = ptr->p; - if (!internal && p->has_history) - uci_add_history(ctx, &p->history, UCI_CMD_LIST_ADD, ptr->section, ptr->option, ptr->value); + if (!internal && p->has_delta) + uci_add_delta(ctx, &p->delta, UCI_CMD_LIST_ADD, ptr->section, ptr->option, ptr->value); e = uci_alloc_generic(ctx, UCI_TYPE_ITEM, ptr->value, sizeof(struct uci_option)); uci_list_add(&ptr->o->v.list, &e->list); @@ -461,7 +482,7 @@ static void uci_add_element_list(struct uci_context *ctx, struct uci_ptr *ptr, b int uci_rename(struct uci_context *ctx, struct uci_ptr *ptr) { - /* NB: UCI_INTERNAL use means without history tracking */ + /* NB: UCI_INTERNAL use means without delta tracking */ bool internal = ctx->internal; struct uci_element *e; struct uci_package *p; @@ -469,14 +490,14 @@ int uci_rename(struct uci_context *ctx, struct uci_ptr *ptr) UCI_HANDLE_ERR(ctx); - e = expand_ptr(ctx, ptr, true); + e = uci_expand_ptr(ctx, ptr, true); p = ptr->p; UCI_ASSERT(ctx, ptr->s); UCI_ASSERT(ctx, ptr->value); - if (!internal && p->has_history) - uci_add_history(ctx, &p->history, UCI_CMD_RENAME, ptr->section, ptr->option, ptr->value); + if (!internal && p->has_delta) + uci_add_delta(ctx, &p->delta, UCI_CMD_RENAME, ptr->section, ptr->option, ptr->value); n = uci_strdup(ctx, ptr->value); if (e->name) @@ -497,9 +518,9 @@ int uci_reorder_section(struct uci_context *ctx, struct uci_section *s, int pos) UCI_HANDLE_ERR(ctx); uci_list_set_pos(&s->package->sections, &s->e.list, pos); - if (!ctx->internal && p->has_history) { + if (!ctx->internal && p->has_delta) { sprintf(order, "%d", pos); - uci_add_history(ctx, &p->history, UCI_CMD_REORDER, s->e.name, NULL, order); + uci_add_delta(ctx, &p->delta, UCI_CMD_REORDER, s->e.name, NULL, order); } return 0; @@ -515,8 +536,24 @@ int uci_add_section(struct uci_context *ctx, struct uci_package *p, const char * s = uci_alloc_section(p, type, NULL); uci_fixup_section(ctx, s); *res = s; - if (!internal && p->has_history) - uci_add_history(ctx, &p->history, UCI_CMD_ADD, s->e.name, NULL, type); + if (!internal && p->has_delta) + uci_add_delta(ctx, &p->delta, UCI_CMD_ADD, s->e.name, NULL, type); + + return 0; +} + +int uci_add_named_section(struct uci_context *ctx, struct uci_package *p, const char *type, const char *name, struct uci_section **res) +{ + bool internal = ctx->internal; + struct uci_section *s; + + UCI_HANDLE_ERR(ctx); + UCI_ASSERT(ctx, p != NULL); + s = uci_alloc_section(p, type, name); + uci_fixup_section(ctx, s); + *res = s; + if (!internal && p->has_delta) + uci_add_delta(ctx, &p->delta, UCI_CMD_ADD, s->e.name, NULL, type); return 0; } @@ -530,13 +567,13 @@ int uci_delete(struct uci_context *ctx, struct uci_ptr *ptr) UCI_HANDLE_ERR(ctx); - e = expand_ptr(ctx, ptr, true); + e = uci_expand_ptr(ctx, ptr, true); p = ptr->p; UCI_ASSERT(ctx, ptr->s); - if (!internal && p->has_history) - uci_add_history(ctx, &p->history, UCI_CMD_REMOVE, ptr->section, ptr->option, NULL); + if (!internal && p->has_delta) + uci_add_delta(ctx, &p->delta, UCI_CMD_REMOVE, ptr->section, ptr->option, NULL); uci_free_any(&e); @@ -550,14 +587,14 @@ int uci_delete(struct uci_context *ctx, struct uci_ptr *ptr) int uci_add_list(struct uci_context *ctx, struct uci_ptr *ptr) { - /* NB: UCI_INTERNAL use means without history tracking */ + /* NB: UCI_INTERNAL use means without delta tracking */ bool internal = ctx->internal; struct uci_option *prev = NULL; const char *value2 = NULL; UCI_HANDLE_ERR(ctx); - expand_ptr(ctx, ptr, false); + uci_expand_ptr(ctx, ptr, false); UCI_ASSERT(ctx, ptr->s); UCI_ASSERT(ctx, ptr->value); @@ -591,11 +628,11 @@ int uci_add_list(struct uci_context *ctx, struct uci_ptr *ptr) int uci_set(struct uci_context *ctx, struct uci_ptr *ptr) { - /* NB: UCI_INTERNAL use means without history tracking */ + /* NB: UCI_INTERNAL use means without delta tracking */ bool internal = ctx->internal; UCI_HANDLE_ERR(ctx); - expand_ptr(ctx, ptr, false); + uci_expand_ptr(ctx, ptr, false); UCI_ASSERT(ctx, ptr->value); UCI_ASSERT(ctx, ptr->s || (!ptr->option && ptr->section)); if (!ptr->option && ptr->value[0]) { @@ -644,8 +681,8 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr) UCI_THROW(ctx, UCI_ERR_INVAL); } - if (!internal && ptr->p->has_history) - uci_add_history(ctx, &ptr->p->history, UCI_CMD_CHANGE, ptr->section, ptr->option, ptr->value); + if (!internal && ptr->p->has_delta) + uci_add_delta(ctx, &ptr->p->delta, UCI_CMD_CHANGE, ptr->section, ptr->option, ptr->value); return 0; }