]> pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] ehea: Nullpointer dereferencation fix
authorThomas Klein <osstklei@de.ibm.com>
Fri, 3 Nov 2006 16:47:20 +0000 (17:47 +0100)
committerJeff Garzik <jeff@garzik.org>
Mon, 6 Nov 2006 07:55:07 +0000 (02:55 -0500)
Fix: Must check for nullpointer before dereferencing it - not afterwards.

Signed-off-by: Thomas Klein <tklein@de.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/ehea/ehea_qmr.c

index 3e1862326c886cc0c0a3798fa87a9427c6234ed6..161559315c0e2ef0a68bc5404e799dc58124f9e8 100644 (file)
@@ -209,11 +209,11 @@ int ehea_destroy_cq(struct ehea_cq *cq)
 {
        u64 adapter_handle, hret;
 
-       adapter_handle = cq->adapter->handle;
-
        if (!cq)
                return 0;
 
+       adapter_handle = cq->adapter->handle;
+
        /* deregister all previous registered pages */
        hret = ehea_h_free_resource(adapter_handle, cq->fw_handle);
        if (hret != H_SUCCESS) {