ehea: Reworked rcv queue handling to log only fatal errors

Prevent driver from brawly logging packet checksum errors.

Signed-off-by: Thomas Klein <tklein@de.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index ea67615320c23a309d20088167dadc9a1a846d7e..5f82a4647eee4dcec3240be6ec51932926efae16 100644 (file)
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -40,7 +40,7 @@
 #include <asm/io.h>
 
 #define DRV_NAME       "ehea"
-#define DRV_VERSION    "EHEA_0082"
+#define DRV_VERSION    "EHEA_0083"
 
 /* eHEA capability flags */
 #define DLPAR_PORT_ADD_REM 1

diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index d2f715d80077e2436f7cc09cdbbbe47e697685c7..869e1604b16ea0e4b5555acbe77dff969f42cb5b 100644 (file)
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -410,11 +410,6 @@ static int ehea_treat_poll_error(struct ehea_port_res *pr, int rq,
        if (cqe->status & EHEA_CQE_STAT_ERR_CRC)
                pr->p_stats.err_frame_crc++;
 
-       if (netif_msg_rx_err(pr->port)) {
-               ehea_error("CQE Error for QP %d", pr->qp->init_attr.qp_nr);
-               ehea_dump(cqe, sizeof(*cqe), "CQE");
-       }
-
        if (rq == 2) {
                *processed_rq2 += 1;
                skb = get_skb_by_index(pr->rq2_skba.arr, pr->rq2_skba.len, cqe);
@@ -426,7 +421,11 @@ static int ehea_treat_poll_error(struct ehea_port_res *pr, int rq,
        }
 
        if (cqe->status & EHEA_CQE_STAT_FAT_ERR_MASK) {
-               ehea_error("Critical receive error. Resetting port.");
+               if (netif_msg_rx_err(pr->port)) {
+                       ehea_error("Critical receive error for QP %d. "
+                                  "Resetting port.", pr->qp->init_attr.qp_nr);
+                       ehea_dump(cqe, sizeof(*cqe), "CQE");
+               }
                schedule_work(&pr->port->reset_task);
                return 1;
        }

diff --git a/drivers/net/ehea/ehea_qmr.h b/drivers/net/ehea/ehea_qmr.h
index 562de0ebdd851a3e3e3cabee9f41df66fcaa4e1a..bc62d389c166578fe179567968009bc8b6752b60 100644 (file)
--- a/drivers/net/ehea/ehea_qmr.h
+++ b/drivers/net/ehea/ehea_qmr.h
@@ -145,8 +145,8 @@ struct ehea_rwqe {
 #define EHEA_CQE_VLAN_TAG_XTRACT   0x0400
 
 #define EHEA_CQE_TYPE_RQ           0x60
-#define EHEA_CQE_STAT_ERR_MASK     0x720F
-#define EHEA_CQE_STAT_FAT_ERR_MASK 0x1F
+#define EHEA_CQE_STAT_ERR_MASK     0x700F
+#define EHEA_CQE_STAT_FAT_ERR_MASK 0xF
 #define EHEA_CQE_STAT_ERR_TCP      0x4000
 #define EHEA_CQE_STAT_ERR_IP       0x2000
 #define EHEA_CQE_STAT_ERR_CRC      0x1000