From: Andrea Merello Date: Sat, 10 May 2008 11:30:12 +0000 (+0200) Subject: rtl8180: fix wrong parameter in sa2400_rf_set_channel X-Git-Tag: v2.6.26-rc5~34^2~2^2~19 X-Git-Url: http://pilppa.org/gitweb/?a=commitdiff_plain;h=0823b2c3c10a4db21cd39a8c72cda96b4dd6d914;hp=6f6c218f68e632e4596cae6e6d43658d26a5e0fe;p=linux-2.6-omap-h63xx.git rtl8180: fix wrong parameter in sa2400_rf_set_channel The sa2400 RF code needs to invoke sa2400_write_phy_antenna every time the channel is being switch. This should be done passing the channel number to that function. Incorrectly we were passing the same value that is written on the channel RF register. This may cause problems when operating on ch 14. This patch fixes it. Thanks to Alessandro Di Marco who found this issue! Signed-off-by: Andrea Merello Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/rtl8180_sa2400.c b/drivers/net/wireless/rtl8180_sa2400.c index 0311b4ea124..cea4e0ccb92 100644 --- a/drivers/net/wireless/rtl8180_sa2400.c +++ b/drivers/net/wireless/rtl8180_sa2400.c @@ -86,7 +86,7 @@ static void sa2400_rf_set_channel(struct ieee80211_hw *dev, write_sa2400(dev, 7, txpw); - sa2400_write_phy_antenna(dev, chan); + sa2400_write_phy_antenna(dev, channel); write_sa2400(dev, 0, chan); write_sa2400(dev, 1, 0xbb50);