]> pilppa.org Git - linux-2.6-omap-h63xx.git/blob - drivers/usb/host/ehci-hub.c
EHCI: don't hide ports owned by the companion
[linux-2.6-omap-h63xx.git] / drivers / usb / host / ehci-hub.c
1 /*
2  * Copyright (C) 2001-2004 by David Brownell
3  *
4  * This program is free software; you can redistribute it and/or modify it
5  * under the terms of the GNU General Public License as published by the
6  * Free Software Foundation; either version 2 of the License, or (at your
7  * option) any later version.
8  *
9  * This program is distributed in the hope that it will be useful, but
10  * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
11  * or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
12  * for more details.
13  *
14  * You should have received a copy of the GNU General Public License
15  * along with this program; if not, write to the Free Software Foundation,
16  * Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
17  */
18
19 /* this file is part of ehci-hcd.c */
20
21 /*-------------------------------------------------------------------------*/
22
23 /*
24  * EHCI Root Hub ... the nonsharable stuff
25  *
26  * Registers don't need cpu_to_le32, that happens transparently
27  */
28
29 /*-------------------------------------------------------------------------*/
30
31 #ifdef  CONFIG_PM
32
33 static int ehci_bus_suspend (struct usb_hcd *hcd)
34 {
35         struct ehci_hcd         *ehci = hcd_to_ehci (hcd);
36         int                     port;
37         int                     mask;
38
39         if (time_before (jiffies, ehci->next_statechange))
40                 msleep(5);
41
42         port = HCS_N_PORTS (ehci->hcs_params);
43         spin_lock_irq (&ehci->lock);
44
45         /* stop schedules, clean any completed work */
46         if (HC_IS_RUNNING(hcd->state)) {
47                 ehci_quiesce (ehci);
48                 hcd->state = HC_STATE_QUIESCING;
49         }
50         ehci->command = ehci_readl(ehci, &ehci->regs->command);
51         if (ehci->reclaim)
52                 ehci->reclaim_ready = 1;
53         ehci_work(ehci);
54
55         /* Unlike other USB host controller types, EHCI doesn't have
56          * any notion of "global" or bus-wide suspend.  The driver has
57          * to manually suspend all the active unsuspended ports, and
58          * then manually resume them in the bus_resume() routine.
59          */
60         ehci->bus_suspended = 0;
61         while (port--) {
62                 u32 __iomem     *reg = &ehci->regs->port_status [port];
63                 u32             t1 = ehci_readl(ehci, reg) & ~PORT_RWC_BITS;
64                 u32             t2 = t1;
65
66                 /* keep track of which ports we suspend */
67                 if ((t1 & PORT_PE) && !(t1 & PORT_OWNER) &&
68                                 !(t1 & PORT_SUSPEND)) {
69                         t2 |= PORT_SUSPEND;
70                         set_bit(port, &ehci->bus_suspended);
71                 }
72
73                 /* enable remote wakeup on all ports */
74                 if (device_may_wakeup(&hcd->self.root_hub->dev))
75                         t2 |= PORT_WKOC_E|PORT_WKDISC_E|PORT_WKCONN_E;
76                 else
77                         t2 &= ~(PORT_WKOC_E|PORT_WKDISC_E|PORT_WKCONN_E);
78
79                 if (t1 != t2) {
80                         ehci_vdbg (ehci, "port %d, %08x -> %08x\n",
81                                 port + 1, t1, t2);
82                         ehci_writel(ehci, t2, reg);
83                 }
84         }
85
86         /* turn off now-idle HC */
87         del_timer_sync (&ehci->watchdog);
88         ehci_halt (ehci);
89         hcd->state = HC_STATE_SUSPENDED;
90
91         /* allow remote wakeup */
92         mask = INTR_MASK;
93         if (!device_may_wakeup(&hcd->self.root_hub->dev))
94                 mask &= ~STS_PCD;
95         ehci_writel(ehci, mask, &ehci->regs->intr_enable);
96         ehci_readl(ehci, &ehci->regs->intr_enable);
97
98         ehci->next_statechange = jiffies + msecs_to_jiffies(10);
99         spin_unlock_irq (&ehci->lock);
100         return 0;
101 }
102
103
104 /* caller has locked the root hub, and should reset/reinit on error */
105 static int ehci_bus_resume (struct usb_hcd *hcd)
106 {
107         struct ehci_hcd         *ehci = hcd_to_ehci (hcd);
108         u32                     temp;
109         int                     i;
110
111         if (time_before (jiffies, ehci->next_statechange))
112                 msleep(5);
113         spin_lock_irq (&ehci->lock);
114
115         /* Ideally and we've got a real resume here, and no port's power
116          * was lost.  (For PCI, that means Vaux was maintained.)  But we
117          * could instead be restoring a swsusp snapshot -- so that BIOS was
118          * the last user of the controller, not reset/pm hardware keeping
119          * state we gave to it.
120          */
121         temp = ehci_readl(ehci, &ehci->regs->intr_enable);
122         ehci_dbg(ehci, "resume root hub%s\n", temp ? "" : " after power loss");
123
124         /* at least some APM implementations will try to deliver
125          * IRQs right away, so delay them until we're ready.
126          */
127         ehci_writel(ehci, 0, &ehci->regs->intr_enable);
128
129         /* re-init operational registers */
130         ehci_writel(ehci, 0, &ehci->regs->segment);
131         ehci_writel(ehci, ehci->periodic_dma, &ehci->regs->frame_list);
132         ehci_writel(ehci, (u32) ehci->async->qh_dma, &ehci->regs->async_next);
133
134         /* restore CMD_RUN, framelist size, and irq threshold */
135         ehci_writel(ehci, ehci->command, &ehci->regs->command);
136
137         /* manually resume the ports we suspended during bus_suspend() */
138         i = HCS_N_PORTS (ehci->hcs_params);
139         while (i--) {
140                 temp = ehci_readl(ehci, &ehci->regs->port_status [i]);
141                 temp &= ~(PORT_RWC_BITS
142                         | PORT_WKOC_E | PORT_WKDISC_E | PORT_WKCONN_E);
143                 if (test_bit(i, &ehci->bus_suspended) &&
144                                 (temp & PORT_SUSPEND)) {
145                         ehci->reset_done [i] = jiffies + msecs_to_jiffies (20);
146                         temp |= PORT_RESUME;
147                 }
148                 ehci_writel(ehci, temp, &ehci->regs->port_status [i]);
149         }
150         i = HCS_N_PORTS (ehci->hcs_params);
151         mdelay (20);
152         while (i--) {
153                 temp = ehci_readl(ehci, &ehci->regs->port_status [i]);
154                 if (test_bit(i, &ehci->bus_suspended) &&
155                                 (temp & PORT_SUSPEND)) {
156                         temp &= ~(PORT_RWC_BITS | PORT_RESUME);
157                         ehci_writel(ehci, temp, &ehci->regs->port_status [i]);
158                         ehci_vdbg (ehci, "resumed port %d\n", i + 1);
159                 }
160         }
161         (void) ehci_readl(ehci, &ehci->regs->command);
162
163         /* maybe re-activate the schedule(s) */
164         temp = 0;
165         if (ehci->async->qh_next.qh)
166                 temp |= CMD_ASE;
167         if (ehci->periodic_sched)
168                 temp |= CMD_PSE;
169         if (temp) {
170                 ehci->command |= temp;
171                 ehci_writel(ehci, ehci->command, &ehci->regs->command);
172         }
173
174         ehci->next_statechange = jiffies + msecs_to_jiffies(5);
175         hcd->state = HC_STATE_RUNNING;
176
177         /* Now we can safely re-enable irqs */
178         ehci_writel(ehci, INTR_MASK, &ehci->regs->intr_enable);
179
180         spin_unlock_irq (&ehci->lock);
181         return 0;
182 }
183
184 #else
185
186 #define ehci_bus_suspend        NULL
187 #define ehci_bus_resume         NULL
188
189 #endif  /* CONFIG_PM */
190
191 /*-------------------------------------------------------------------------*/
192
193 static int check_reset_complete (
194         struct ehci_hcd *ehci,
195         int             index,
196         u32 __iomem     *status_reg,
197         int             port_status
198 ) {
199         if (!(port_status & PORT_CONNECT)) {
200                 ehci->reset_done [index] = 0;
201                 return port_status;
202         }
203
204         /* if reset finished and it's still not enabled -- handoff */
205         if (!(port_status & PORT_PE)) {
206
207                 /* with integrated TT, there's nobody to hand it to! */
208                 if (ehci_is_TDI(ehci)) {
209                         ehci_dbg (ehci,
210                                 "Failed to enable port %d on root hub TT\n",
211                                 index+1);
212                         return port_status;
213                 }
214
215                 ehci_dbg (ehci, "port %d full speed --> companion\n",
216                         index + 1);
217
218                 // what happens if HCS_N_CC(params) == 0 ?
219                 port_status |= PORT_OWNER;
220                 port_status &= ~PORT_RWC_BITS;
221                 ehci_writel(ehci, port_status, status_reg);
222
223         } else
224                 ehci_dbg (ehci, "port %d high speed\n", index + 1);
225
226         return port_status;
227 }
228
229 /*-------------------------------------------------------------------------*/
230
231
232 /* build "status change" packet (one or two bytes) from HC registers */
233
234 static int
235 ehci_hub_status_data (struct usb_hcd *hcd, char *buf)
236 {
237         struct ehci_hcd *ehci = hcd_to_ehci (hcd);
238         u32             temp, status = 0;
239         u32             mask;
240         int             ports, i, retval = 1;
241         unsigned long   flags;
242
243         /* if !USB_SUSPEND, root hub timers won't get shut down ... */
244         if (!HC_IS_RUNNING(hcd->state))
245                 return 0;
246
247         /* init status to no-changes */
248         buf [0] = 0;
249         ports = HCS_N_PORTS (ehci->hcs_params);
250         if (ports > 7) {
251                 buf [1] = 0;
252                 retval++;
253         }
254
255         /* Some boards (mostly VIA?) report bogus overcurrent indications,
256          * causing massive log spam unless we completely ignore them.  It
257          * may be relevant that VIA VT8235 controlers, where PORT_POWER is
258          * always set, seem to clear PORT_OCC and PORT_CSC when writing to
259          * PORT_POWER; that's surprising, but maybe within-spec.
260          */
261         if (!ignore_oc)
262                 mask = PORT_CSC | PORT_PEC | PORT_OCC;
263         else
264                 mask = PORT_CSC | PORT_PEC;
265         // PORT_RESUME from hardware ~= PORT_STAT_C_SUSPEND
266
267         /* no hub change reports (bit 0) for now (power, ...) */
268
269         /* port N changes (bit N)? */
270         spin_lock_irqsave (&ehci->lock, flags);
271         for (i = 0; i < ports; i++) {
272                 temp = ehci_readl(ehci, &ehci->regs->port_status [i]);
273
274                 /*
275                  * Return status information even for ports with OWNER set.
276                  * Otherwise khubd wouldn't see the disconnect event when a
277                  * high-speed device is switched over to the companion
278                  * controller by the user.
279                  */
280
281                 if (!(temp & PORT_CONNECT))
282                         ehci->reset_done [i] = 0;
283                 if ((temp & mask) != 0
284                                 || ((temp & PORT_RESUME) != 0
285                                         && time_after (jiffies,
286                                                 ehci->reset_done [i]))) {
287                         if (i < 7)
288                             buf [0] |= 1 << (i + 1);
289                         else
290                             buf [1] |= 1 << (i - 7);
291                         status = STS_PCD;
292                 }
293         }
294         /* FIXME autosuspend idle root hubs */
295         spin_unlock_irqrestore (&ehci->lock, flags);
296         return status ? retval : 0;
297 }
298
299 /*-------------------------------------------------------------------------*/
300
301 static void
302 ehci_hub_descriptor (
303         struct ehci_hcd                 *ehci,
304         struct usb_hub_descriptor       *desc
305 ) {
306         int             ports = HCS_N_PORTS (ehci->hcs_params);
307         u16             temp;
308
309         desc->bDescriptorType = 0x29;
310         desc->bPwrOn2PwrGood = 10;      /* ehci 1.0, 2.3.9 says 20ms max */
311         desc->bHubContrCurrent = 0;
312
313         desc->bNbrPorts = ports;
314         temp = 1 + (ports / 8);
315         desc->bDescLength = 7 + 2 * temp;
316
317         /* two bitmaps:  ports removable, and usb 1.0 legacy PortPwrCtrlMask */
318         memset (&desc->bitmap [0], 0, temp);
319         memset (&desc->bitmap [temp], 0xff, temp);
320
321         temp = 0x0008;                  /* per-port overcurrent reporting */
322         if (HCS_PPC (ehci->hcs_params))
323                 temp |= 0x0001;         /* per-port power control */
324         else
325                 temp |= 0x0002;         /* no power switching */
326 #if 0
327 // re-enable when we support USB_PORT_FEAT_INDICATOR below.
328         if (HCS_INDICATOR (ehci->hcs_params))
329                 temp |= 0x0080;         /* per-port indicators (LEDs) */
330 #endif
331         desc->wHubCharacteristics = (__force __u16)cpu_to_le16 (temp);
332 }
333
334 /*-------------------------------------------------------------------------*/
335
336 #define PORT_WAKE_BITS  (PORT_WKOC_E|PORT_WKDISC_E|PORT_WKCONN_E)
337
338 static int ehci_hub_control (
339         struct usb_hcd  *hcd,
340         u16             typeReq,
341         u16             wValue,
342         u16             wIndex,
343         char            *buf,
344         u16             wLength
345 ) {
346         struct ehci_hcd *ehci = hcd_to_ehci (hcd);
347         int             ports = HCS_N_PORTS (ehci->hcs_params);
348         u32 __iomem     *status_reg = &ehci->regs->port_status[wIndex - 1];
349         u32             temp, status;
350         unsigned long   flags;
351         int             retval = 0;
352         unsigned        selector;
353
354         /*
355          * FIXME:  support SetPortFeatures USB_PORT_FEAT_INDICATOR.
356          * HCS_INDICATOR may say we can change LEDs to off/amber/green.
357          * (track current state ourselves) ... blink for diagnostics,
358          * power, "this is the one", etc.  EHCI spec supports this.
359          */
360
361         spin_lock_irqsave (&ehci->lock, flags);
362         switch (typeReq) {
363         case ClearHubFeature:
364                 switch (wValue) {
365                 case C_HUB_LOCAL_POWER:
366                 case C_HUB_OVER_CURRENT:
367                         /* no hub-wide feature/status flags */
368                         break;
369                 default:
370                         goto error;
371                 }
372                 break;
373         case ClearPortFeature:
374                 if (!wIndex || wIndex > ports)
375                         goto error;
376                 wIndex--;
377                 temp = ehci_readl(ehci, status_reg);
378
379                 /*
380                  * Even if OWNER is set, so the port is owned by the
381                  * companion controller, khubd needs to be able to clear
382                  * the port-change status bits (especially
383                  * USB_PORT_FEAT_C_CONNECTION).
384                  */
385
386                 switch (wValue) {
387                 case USB_PORT_FEAT_ENABLE:
388                         ehci_writel(ehci, temp & ~PORT_PE, status_reg);
389                         break;
390                 case USB_PORT_FEAT_C_ENABLE:
391                         ehci_writel(ehci, (temp & ~PORT_RWC_BITS) | PORT_PEC,
392                                         status_reg);
393                         break;
394                 case USB_PORT_FEAT_SUSPEND:
395                         if (temp & PORT_RESET)
396                                 goto error;
397                         if (ehci->no_selective_suspend)
398                                 break;
399                         if (temp & PORT_SUSPEND) {
400                                 if ((temp & PORT_PE) == 0)
401                                         goto error;
402                                 /* resume signaling for 20 msec */
403                                 temp &= ~(PORT_RWC_BITS | PORT_WAKE_BITS);
404                                 ehci_writel(ehci, temp | PORT_RESUME,
405                                                 status_reg);
406                                 ehci->reset_done [wIndex] = jiffies
407                                                 + msecs_to_jiffies (20);
408                         }
409                         break;
410                 case USB_PORT_FEAT_C_SUSPEND:
411                         /* we auto-clear this feature */
412                         break;
413                 case USB_PORT_FEAT_POWER:
414                         if (HCS_PPC (ehci->hcs_params))
415                                 ehci_writel(ehci,
416                                           temp & ~(PORT_RWC_BITS | PORT_POWER),
417                                           status_reg);
418                         break;
419                 case USB_PORT_FEAT_C_CONNECTION:
420                         ehci_writel(ehci, (temp & ~PORT_RWC_BITS) | PORT_CSC,
421                                         status_reg);
422                         break;
423                 case USB_PORT_FEAT_C_OVER_CURRENT:
424                         ehci_writel(ehci, (temp & ~PORT_RWC_BITS) | PORT_OCC,
425                                         status_reg);
426                         break;
427                 case USB_PORT_FEAT_C_RESET:
428                         /* GetPortStatus clears reset */
429                         break;
430                 default:
431                         goto error;
432                 }
433                 ehci_readl(ehci, &ehci->regs->command); /* unblock posted write */
434                 break;
435         case GetHubDescriptor:
436                 ehci_hub_descriptor (ehci, (struct usb_hub_descriptor *)
437                         buf);
438                 break;
439         case GetHubStatus:
440                 /* no hub-wide feature/status flags */
441                 memset (buf, 0, 4);
442                 //cpu_to_le32s ((u32 *) buf);
443                 break;
444         case GetPortStatus:
445                 if (!wIndex || wIndex > ports)
446                         goto error;
447                 wIndex--;
448                 status = 0;
449                 temp = ehci_readl(ehci, status_reg);
450
451                 // wPortChange bits
452                 if (temp & PORT_CSC)
453                         status |= 1 << USB_PORT_FEAT_C_CONNECTION;
454                 if (temp & PORT_PEC)
455                         status |= 1 << USB_PORT_FEAT_C_ENABLE;
456                 if ((temp & PORT_OCC) && !ignore_oc)
457                         status |= 1 << USB_PORT_FEAT_C_OVER_CURRENT;
458
459                 /* whoever resumes must GetPortStatus to complete it!! */
460                 if ((temp & PORT_RESUME)
461                                 && time_after (jiffies,
462                                         ehci->reset_done [wIndex])) {
463                         status |= 1 << USB_PORT_FEAT_C_SUSPEND;
464                         ehci->reset_done [wIndex] = 0;
465
466                         /* stop resume signaling */
467                         temp = ehci_readl(ehci, status_reg);
468                         ehci_writel(ehci,
469                                         temp & ~(PORT_RWC_BITS | PORT_RESUME),
470                                         status_reg);
471                         retval = handshake(ehci, status_reg,
472                                            PORT_RESUME, 0, 2000 /* 2msec */);
473                         if (retval != 0) {
474                                 ehci_err (ehci, "port %d resume error %d\n",
475                                         wIndex + 1, retval);
476                                 goto error;
477                         }
478                         temp &= ~(PORT_SUSPEND|PORT_RESUME|(3<<10));
479                 }
480
481                 /* whoever resets must GetPortStatus to complete it!! */
482                 if ((temp & PORT_RESET)
483                                 && time_after (jiffies,
484                                         ehci->reset_done [wIndex])) {
485                         status |= 1 << USB_PORT_FEAT_C_RESET;
486                         ehci->reset_done [wIndex] = 0;
487
488                         /* force reset to complete */
489                         ehci_writel(ehci, temp & ~(PORT_RWC_BITS | PORT_RESET),
490                                         status_reg);
491                         /* REVISIT:  some hardware needs 550+ usec to clear
492                          * this bit; seems too long to spin routinely...
493                          */
494                         retval = handshake(ehci, status_reg,
495                                         PORT_RESET, 0, 750);
496                         if (retval != 0) {
497                                 ehci_err (ehci, "port %d reset error %d\n",
498                                         wIndex + 1, retval);
499                                 goto error;
500                         }
501
502                         /* see what we found out */
503                         temp = check_reset_complete (ehci, wIndex, status_reg,
504                                         ehci_readl(ehci, status_reg));
505                 }
506
507                 /*
508                  * Even if OWNER is set, there's no harm letting khubd
509                  * see the wPortStatus values (they should all be 0 except
510                  * for PORT_POWER anyway).
511                  */
512
513                 if (temp & PORT_CONNECT) {
514                         status |= 1 << USB_PORT_FEAT_CONNECTION;
515                         // status may be from integrated TT
516                         status |= ehci_port_speed(ehci, temp);
517                 }
518                 if (temp & PORT_PE)
519                         status |= 1 << USB_PORT_FEAT_ENABLE;
520                 if (temp & (PORT_SUSPEND|PORT_RESUME))
521                         status |= 1 << USB_PORT_FEAT_SUSPEND;
522                 if (temp & PORT_OC)
523                         status |= 1 << USB_PORT_FEAT_OVER_CURRENT;
524                 if (temp & PORT_RESET)
525                         status |= 1 << USB_PORT_FEAT_RESET;
526                 if (temp & PORT_POWER)
527                         status |= 1 << USB_PORT_FEAT_POWER;
528
529 #ifndef EHCI_VERBOSE_DEBUG
530         if (status & ~0xffff)   /* only if wPortChange is interesting */
531 #endif
532                 dbg_port (ehci, "GetStatus", wIndex + 1, temp);
533                 // we "know" this alignment is good, caller used kmalloc()...
534                 *((__le32 *) buf) = cpu_to_le32 (status);
535                 break;
536         case SetHubFeature:
537                 switch (wValue) {
538                 case C_HUB_LOCAL_POWER:
539                 case C_HUB_OVER_CURRENT:
540                         /* no hub-wide feature/status flags */
541                         break;
542                 default:
543                         goto error;
544                 }
545                 break;
546         case SetPortFeature:
547                 selector = wIndex >> 8;
548                 wIndex &= 0xff;
549                 if (!wIndex || wIndex > ports)
550                         goto error;
551                 wIndex--;
552                 temp = ehci_readl(ehci, status_reg);
553                 if (temp & PORT_OWNER)
554                         break;
555
556                 temp &= ~PORT_RWC_BITS;
557                 switch (wValue) {
558                 case USB_PORT_FEAT_SUSPEND:
559                         if (ehci->no_selective_suspend)
560                                 break;
561                         if ((temp & PORT_PE) == 0
562                                         || (temp & PORT_RESET) != 0)
563                                 goto error;
564                         if (device_may_wakeup(&hcd->self.root_hub->dev))
565                                 temp |= PORT_WAKE_BITS;
566                         ehci_writel(ehci, temp | PORT_SUSPEND, status_reg);
567                         break;
568                 case USB_PORT_FEAT_POWER:
569                         if (HCS_PPC (ehci->hcs_params))
570                                 ehci_writel(ehci, temp | PORT_POWER,
571                                                 status_reg);
572                         break;
573                 case USB_PORT_FEAT_RESET:
574                         if (temp & PORT_RESUME)
575                                 goto error;
576                         /* line status bits may report this as low speed,
577                          * which can be fine if this root hub has a
578                          * transaction translator built in.
579                          */
580                         if ((temp & (PORT_PE|PORT_CONNECT)) == PORT_CONNECT
581                                         && !ehci_is_TDI(ehci)
582                                         && PORT_USB11 (temp)) {
583                                 ehci_dbg (ehci,
584                                         "port %d low speed --> companion\n",
585                                         wIndex + 1);
586                                 temp |= PORT_OWNER;
587                         } else {
588                                 ehci_vdbg (ehci, "port %d reset\n", wIndex + 1);
589                                 temp |= PORT_RESET;
590                                 temp &= ~PORT_PE;
591
592                                 /*
593                                  * caller must wait, then call GetPortStatus
594                                  * usb 2.0 spec says 50 ms resets on root
595                                  */
596                                 ehci->reset_done [wIndex] = jiffies
597                                                 + msecs_to_jiffies (50);
598                         }
599                         ehci_writel(ehci, temp, status_reg);
600                         break;
601
602                 /* For downstream facing ports (these):  one hub port is put
603                  * into test mode according to USB2 11.24.2.13, then the hub
604                  * must be reset (which for root hub now means rmmod+modprobe,
605                  * or else system reboot).  See EHCI 2.3.9 and 4.14 for info
606                  * about the EHCI-specific stuff.
607                  */
608                 case USB_PORT_FEAT_TEST:
609                         if (!selector || selector > 5)
610                                 goto error;
611                         ehci_quiesce(ehci);
612                         ehci_halt(ehci);
613                         temp |= selector << 16;
614                         ehci_writel(ehci, temp, status_reg);
615                         break;
616
617                 default:
618                         goto error;
619                 }
620                 ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */
621                 break;
622
623         default:
624 error:
625                 /* "stall" on error */
626                 retval = -EPIPE;
627         }
628         spin_unlock_irqrestore (&ehci->lock, flags);
629         return retval;
630 }