]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/i2c/chips/twl4030-core.c
i2c: switch twl4030-usb to use a resource for irq
[linux-2.6-omap-h63xx.git] / drivers / i2c / chips / twl4030-core.c
index 99cc143b988df0485bf49310cde3bef85184e8da..43424a85750cd1359e583eaa2d5b0289934616f2 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * twl4030_core.c - driver for TWL4030 PM and audio CODEC device
+ * twl4030_core.c - driver for TWL4030/TPS659x0 PM and audio CODEC devices
  *
  * Copyright (C) 2005-2006 Texas Instruments, Inc.
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
- *
  */
 
-#include <linux/module.h>
 #include <linux/kernel_stat.h>
 #include <linux/init.h>
-#include <linux/time.h>
 #include <linux/mutex.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
 #include <linux/random.h>
-#include <linux/syscalls.h>
 #include <linux/kthread.h>
+#include <linux/platform_device.h>
+#include <linux/clk.h>
 
 #include <linux/i2c.h>
 #include <linux/i2c/twl4030.h>
-#include <linux/slab.h>
-#include <linux/clk.h>
-#include <linux/device.h>
-#include <linux/irq.h>
-
-#include <asm/mach/irq.h>
-
-#include <asm/arch/gpio.h>
-#include <asm/arch/mux.h>
+#include <linux/i2c/twl4030-gpio.h>
+#include <linux/i2c/twl4030-madc.h>
+#include <linux/i2c/twl4030-pwrirq.h>
 
 #define DRIVER_NAME                    "twl4030"
 
-/* Macro Definitions */
-#define TWL_CLIENT_STRING              "TWL4030-ID"
-#define TWL_CLIENT_USED                        1
-#define TWL_CLIENT_FREE                        0
-
-/* IRQ Flags */
-#define FREE                           0
-#define USED                           1
+#if defined(CONFIG_KEYBOARD_TWL4030) || defined(CONFIG_KEYBOARD_TWL4030_MODULE)
+#define twl_has_keypad()       true
+#else
+#define twl_has_keypad()       false
+#endif
+
+#if defined(CONFIG_GPIO_TWL4030) || defined(CONFIG_GPIO_TWL4030_MODULE)
+#define twl_has_gpio() true
+#else
+#define twl_has_gpio() false
+#endif
+
+#if defined(CONFIG_TWL4030_MADC) || defined(CONFIG_TWL4030_MADC_MODULE)
+#define twl_has_madc() true
+#else
+#define twl_has_madc() false
+#endif
+
+#if defined(CONFIG_RTC_DRV_TWL4030) || defined(CONFIG_RTC_DRV_TWL4030_MODULE)
+#define twl_has_rtc()  true
+#else
+#define twl_has_rtc()  false
+#endif
+
+#if defined(CONFIG_TWL4030_USB) || defined(CONFIG_TWL4030_USB_MODULE)
+#define twl_has_usb()  true
+#else
+#define twl_has_usb()  false
+#endif
 
 /* Primary Interrupt Handler on TWL4030 Registers */
 
 /* Last - for index max*/
 #define TWL4030_MODULE_LAST            TWL4030_MODULE_SECURED_REG
 
+#define TWL4030_NUM_SLAVES             4
+
 /* Slave address */
-#define TWL4030_NUM_SLAVES             0x04
 #define TWL4030_SLAVENUM_NUM0          0x00
 #define TWL4030_SLAVENUM_NUM1          0x01
 #define TWL4030_SLAVENUM_NUM2          0x02
 #define TWL4030_SLAVENUM_NUM3          0x03
-#define TWL4030_SLAVEID_ID0            0x48
-#define TWL4030_SLAVEID_ID1            0x49
-#define TWL4030_SLAVEID_ID2            0x4A
-#define TWL4030_SLAVEID_ID3            0x4B
 
 /* Base Address defns */
 /* USB ID */
 #define TWL4030_BASEADD_RTC            0x001C
 #define TWL4030_BASEADD_SECURED_REG    0x0000
 
+/* TWL4030 BCI registers */
+#define TWL4030_INTERRUPTS_BCIIMR1A    0x2
+#define TWL4030_INTERRUPTS_BCIIMR2A    0x3
+#define TWL4030_INTERRUPTS_BCIIMR1B    0x6
+#define TWL4030_INTERRUPTS_BCIIMR2B    0x7
+#define TWL4030_INTERRUPTS_BCIISR1A    0x0
+#define TWL4030_INTERRUPTS_BCIISR2A    0x1
+#define TWL4030_INTERRUPTS_BCIISR1B    0x4
+#define TWL4030_INTERRUPTS_BCIISR2B    0x5
+
+/* TWL4030 keypad registers */
+#define TWL4030_KEYPAD_KEYP_IMR1       0x12
+#define TWL4030_KEYPAD_KEYP_IMR2       0x14
+#define TWL4030_KEYPAD_KEYP_ISR1       0x11
+#define TWL4030_KEYPAD_KEYP_ISR2       0x13
+
+
 /* Triton Core internal information (END) */
 
 /* Few power values */
 #define HFCLK_FREQ_38p4_MHZ            (3 << 0)
 #define HIGH_PERF_SQ                   (1 << 3)
 
-/* on I2C-1 for 2430SDP */
-#define CONFIG_I2C_TWL4030_ID          1
-
-/* SIH_CTRL registers */
-#define TWL4030_INT_PWR_SIH_CTRL       0x07
+/* SIH_CTRL registers that aren't defined elsewhere */
 #define TWL4030_INTERRUPTS_BCISIHCTRL  0x0d
 #define TWL4030_MADC_MADC_SIH_CTRL     0x67
 #define TWL4030_KEYPAD_KEYP_SIH_CTRL   0x17
-#define TWL4030_GPIO_GPIO_SIH_CTRL     0x2d
 
 #define TWL4030_SIH_CTRL_COR_MASK      (1 << 2)
 
+/**
+ * struct twl4030_mod_iregs - TWL module IMR/ISR regs to mask/clear at init
+ * @mod_no: TWL4030 module number (e.g., TWL4030_MODULE_GPIO)
+ * @sih_ctrl: address of module SIH_CTRL register
+ * @reg_cnt: number of IMR/ISR regs
+ * @imrs: pointer to array of TWL module interrupt mask register indices
+ * @isrs: pointer to array of TWL module interrupt status register indices
+ *
+ * Ties together TWL4030 modules and lists of IMR/ISR registers to mask/clear
+ * during twl_init_irq().
+ */
+struct twl4030_mod_iregs {
+       const u8 mod_no;
+       const u8 sih_ctrl;
+       const u8 reg_cnt;
+       const u8 *imrs;
+       const u8 *isrs;
+};
 
-/* Helper functions */
-static int
-twl4030_detect_client(struct i2c_adapter *adapter, unsigned char sid);
-static int twl4030_attach_adapter(struct i2c_adapter *adapter);
-static int twl4030_detach_client(struct i2c_client *client);
-static void do_twl4030_irq(unsigned int irq, irq_desc_t *desc);
+/* TWL4030 INT module interrupt mask registers */
+static const u8 __initconst twl4030_int_imr_regs[] = {
+       TWL4030_INT_PWR_IMR1,
+       TWL4030_INT_PWR_IMR2,
+};
+
+/* TWL4030 INT module interrupt status registers */
+static const u8 __initconst twl4030_int_isr_regs[] = {
+       TWL4030_INT_PWR_ISR1,
+       TWL4030_INT_PWR_ISR2,
+};
+
+/* TWL4030 INTERRUPTS module interrupt mask registers */
+static const u8 __initconst twl4030_interrupts_imr_regs[] = {
+       TWL4030_INTERRUPTS_BCIIMR1A,
+       TWL4030_INTERRUPTS_BCIIMR1B,
+       TWL4030_INTERRUPTS_BCIIMR2A,
+       TWL4030_INTERRUPTS_BCIIMR2B,
+};
+
+/* TWL4030 INTERRUPTS module interrupt status registers */
+static const u8 __initconst twl4030_interrupts_isr_regs[] = {
+       TWL4030_INTERRUPTS_BCIISR1A,
+       TWL4030_INTERRUPTS_BCIISR1B,
+       TWL4030_INTERRUPTS_BCIISR2A,
+       TWL4030_INTERRUPTS_BCIISR2B,
+};
+
+/* TWL4030 MADC module interrupt mask registers */
+static const u8 __initconst twl4030_madc_imr_regs[] = {
+       TWL4030_MADC_IMR1,
+       TWL4030_MADC_IMR2,
+};
+
+/* TWL4030 MADC module interrupt status registers */
+static const u8 __initconst twl4030_madc_isr_regs[] = {
+       TWL4030_MADC_ISR1,
+       TWL4030_MADC_ISR2,
+};
+
+/* TWL4030 keypad module interrupt mask registers */
+static const u8 __initconst twl4030_keypad_imr_regs[] = {
+       TWL4030_KEYPAD_KEYP_IMR1,
+       TWL4030_KEYPAD_KEYP_IMR2,
+};
+
+/* TWL4030 keypad module interrupt status registers */
+static const u8 __initconst twl4030_keypad_isr_regs[] = {
+       TWL4030_KEYPAD_KEYP_ISR1,
+       TWL4030_KEYPAD_KEYP_ISR2,
+};
+
+/* TWL4030 GPIO module interrupt mask registers */
+static const u8 __initconst twl4030_gpio_imr_regs[] = {
+       REG_GPIO_IMR1A,
+       REG_GPIO_IMR1B,
+       REG_GPIO_IMR2A,
+       REG_GPIO_IMR2B,
+       REG_GPIO_IMR3A,
+       REG_GPIO_IMR3B,
+};
+
+/* TWL4030 GPIO module interrupt status registers */
+static const u8 __initconst twl4030_gpio_isr_regs[] = {
+       REG_GPIO_ISR1A,
+       REG_GPIO_ISR1B,
+       REG_GPIO_ISR2A,
+       REG_GPIO_ISR2B,
+       REG_GPIO_ISR3A,
+       REG_GPIO_ISR3B,
+};
+
+/* TWL4030 modules that have IMR/ISR registers that must be masked/cleared */
+static const struct twl4030_mod_iregs __initconst twl4030_mod_regs[] = {
+       {
+               .mod_no   = TWL4030_MODULE_INT,
+               .sih_ctrl = TWL4030_INT_PWR_SIH_CTRL,
+               .reg_cnt  = ARRAY_SIZE(twl4030_int_imr_regs),
+               .imrs     = twl4030_int_imr_regs,
+               .isrs     = twl4030_int_isr_regs,
+       },
+       {
+               .mod_no   = TWL4030_MODULE_INTERRUPTS,
+               .sih_ctrl = TWL4030_INTERRUPTS_BCISIHCTRL,
+               .reg_cnt  = ARRAY_SIZE(twl4030_interrupts_imr_regs),
+               .imrs     = twl4030_interrupts_imr_regs,
+               .isrs     = twl4030_interrupts_isr_regs,
+       },
+       {
+               .mod_no   = TWL4030_MODULE_MADC,
+               .sih_ctrl = TWL4030_MADC_MADC_SIH_CTRL,
+               .reg_cnt  = ARRAY_SIZE(twl4030_madc_imr_regs),
+               .imrs     = twl4030_madc_imr_regs,
+               .isrs     = twl4030_madc_isr_regs,
+       },
+       {
+               .mod_no   = TWL4030_MODULE_KEYPAD,
+               .sih_ctrl = TWL4030_KEYPAD_KEYP_SIH_CTRL,
+               .reg_cnt  = ARRAY_SIZE(twl4030_keypad_imr_regs),
+               .imrs     = twl4030_keypad_imr_regs,
+               .isrs     = twl4030_keypad_isr_regs,
+       },
+       {
+               .mod_no   = TWL4030_MODULE_GPIO,
+               .sih_ctrl = REG_GPIO_SIH_CTRL,
+               .reg_cnt  = ARRAY_SIZE(twl4030_gpio_imr_regs),
+               .imrs     = twl4030_gpio_imr_regs,
+               .isrs     = twl4030_gpio_isr_regs,
+       },
+};
 
-static void twl_init_irq(void);
 
 /* Data Structures */
 /* To have info on T2 IRQ substem activated or not */
-static unsigned char twl_irq_used = FREE;
 static struct completion irq_event;
 
 /* Structure to define on TWL4030 Slave ID */
 struct twl4030_client {
-       struct i2c_client client;
-       const char client_name[sizeof(TWL_CLIENT_STRING) + 1];
-       const unsigned char address;
-       const char adapter_index;
-       unsigned char inuse;
+       struct i2c_client *client;
+       u8 address;
+       bool inuse;
 
        /* max numb of i2c_msg required is for read =2 */
        struct i2c_msg xfer_msg[2];
@@ -204,47 +345,24 @@ static struct twl4030mapping twl4030_map[TWL4030_MODULE_LAST + 1] = {
        { TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_SECURED_REG },
 };
 
-static struct twl4030_client twl4030_modules[TWL4030_NUM_SLAVES] = {
-       {
-               .address        = TWL4030_SLAVEID_ID0,
-               .client_name    = TWL_CLIENT_STRING "0",
-               .adapter_index  = CONFIG_I2C_TWL4030_ID,
-       },
-       {
-               .address        = TWL4030_SLAVEID_ID1,
-               .client_name    = TWL_CLIENT_STRING "1",
-               .adapter_index  = CONFIG_I2C_TWL4030_ID,
-       },
-       {
-               .address        = TWL4030_SLAVEID_ID2,
-               .client_name    = TWL_CLIENT_STRING "2",
-               .adapter_index  = CONFIG_I2C_TWL4030_ID,
-       },
-       {
-               .address        = TWL4030_SLAVEID_ID3,
-               .client_name    = TWL_CLIENT_STRING "3",
-               .adapter_index  = CONFIG_I2C_TWL4030_ID,
-       },
-};
-
-/* One Client Driver , 4 Clients */
-static struct i2c_driver twl4030_driver = {
-       .driver = {
-               .name   = DRIVER_NAME,
-               .owner  = THIS_MODULE,
-       },
-       .attach_adapter = twl4030_attach_adapter,
-       .detach_client  = twl4030_detach_client,
-};
+static struct twl4030_client twl4030_modules[TWL4030_NUM_SLAVES];
 
 /*
  * TWL4030 doesn't have PIH mask, hence dummy function for mask
  * and unmask.
  */
 
-static void twl4030_i2c_ackirq(unsigned int irq) {}
-static void twl4030_i2c_disableint(unsigned int irq) {}
-static void twl4030_i2c_enableint(unsigned int irq) {}
+static void twl4030_i2c_ackirq(unsigned int irq)
+{
+}
+
+static void twl4030_i2c_disableint(unsigned int irq)
+{
+}
+
+static void twl4030_i2c_enableint(unsigned int irq)
+{
+}
 
 /* information for processing in the Work Item */
 static struct irq_chip twl4030_irq_chip = {
@@ -255,17 +373,18 @@ static struct irq_chip twl4030_irq_chip = {
 };
 
 /* Global Functions */
-/*
- * @brief twl4030_i2c_write - Writes a n bit register in TWL4030
+
+/**
+ * twl4030_i2c_write - Writes a n bit register in TWL4030
+ * @mod_no: module number
+ * @value: an array of num_bytes+1 containing data to write
+ * @reg: register address (just offset will do)
+ * @num_bytes: number of bytes to transfer
  *
- * @param mod_no - module number
- * @param *value - an array of num_bytes+1 containing data to write
- * IMPORTANT - Allocate value num_bytes+1 and valid data starts at
- *              Offset 1.
- * @param reg - register address (just offset will do)
- * @param num_bytes - number of bytes to transfer
+ * IMPORTANT: for 'value' parameter: Allocate value num_bytes+1 and
+ * valid data starts at Offset 1.
  *
- * @return result of operation - 0 is success
+ * Returns the result of operation - 0 is success
  */
 int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
 {
@@ -275,15 +394,14 @@ int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
        struct i2c_msg *msg;
 
        if (unlikely(mod_no > TWL4030_MODULE_LAST)) {
-               pr_err("Invalid module Number\n");
+               pr_err("%s: invalid module number %d\n", DRIVER_NAME, mod_no);
                return -EPERM;
        }
        sid = twl4030_map[mod_no].sid;
        twl = &twl4030_modules[sid];
 
-       if (unlikely(twl->inuse != TWL_CLIENT_USED)) {
-               pr_err("I2C Client[%d] is not initialized[%d]\n",
-                      sid, __LINE__);
+       if (unlikely(!twl->inuse)) {
+               pr_err("%s: client %d is not initialized\n", DRIVER_NAME, sid);
                return -EPERM;
        }
        mutex_lock(&twl->xfer_lock);
@@ -298,7 +416,7 @@ int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
        msg->buf = value;
        /* over write the first byte of buffer with the register address */
        *value = twl4030_map[mod_no].base + reg;
-       ret = i2c_transfer(twl->client.adapter, twl->xfer_msg, 1);
+       ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 1);
        mutex_unlock(&twl->xfer_lock);
 
        /* i2cTransfer returns num messages.translate it pls.. */
@@ -309,14 +427,13 @@ int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
 EXPORT_SYMBOL(twl4030_i2c_write);
 
 /**
- * @brief twl4030_i2c_read - Reads a n bit register in TWL4030
- *
- * @param mod_no - module number
- * @param *value - an array of num_bytes containing data to be read
- * @param reg - register address (just offset will do)
- * @param num_bytes - number of bytes to transfer
+ * twl4030_i2c_read - Reads a n bit register in TWL4030
+ * @mod_no: module number
+ * @value: an array of num_bytes containing data to be read
+ * @reg: register address (just offset will do)
+ * @num_bytes: number of bytes to transfer
  *
- * @return result of operation - num_bytes is success else failure.
+ * Returns result of operation - num_bytes is success else failure.
  */
 int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
 {
@@ -327,15 +444,14 @@ int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
        struct i2c_msg *msg;
 
        if (unlikely(mod_no > TWL4030_MODULE_LAST)) {
-               pr_err("Invalid module Number\n");
+               pr_err("%s: invalid module number %d\n", DRIVER_NAME, mod_no);
                return -EPERM;
        }
        sid = twl4030_map[mod_no].sid;
        twl = &twl4030_modules[sid];
 
-       if (unlikely(twl->inuse != TWL_CLIENT_USED)) {
-               pr_err("I2C Client[%d] is not initialized[%d]\n", sid,
-                      __LINE__);
+       if (unlikely(!twl->inuse)) {
+               pr_err("%s: client %d is not initialized\n", DRIVER_NAME, sid);
                return -EPERM;
        }
        mutex_lock(&twl->xfer_lock);
@@ -352,7 +468,7 @@ int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
        msg->flags = I2C_M_RD;  /* Read the register value */
        msg->len = num_bytes;   /* only n bytes */
        msg->buf = value;
-       ret = i2c_transfer(twl->client.adapter, twl->xfer_msg, 2);
+       ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 2);
        mutex_unlock(&twl->xfer_lock);
 
        /* i2cTransfer returns num messages.translate it pls.. */
@@ -363,13 +479,12 @@ int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
 EXPORT_SYMBOL(twl4030_i2c_read);
 
 /**
- * @brief twl4030_i2c_write_u8 - Writes a 8 bit register in TWL4030
+ * twl4030_i2c_write_u8 - Writes a 8 bit register in TWL4030
+ * @mod_no: module number
+ * @value: the value to be written 8 bit
+ * @reg: register address (just offset will do)
  *
- * @param mod_no - module number
- * @param value - the value to be written 8 bit
- * @param reg - register address (just offset will do)
- *
- * @return result of operation - 0 is success
+ * Returns result of operation - 0 is success
  */
 int twl4030_i2c_write_u8(u8 mod_no, u8 value, u8 reg)
 {
@@ -383,13 +498,12 @@ int twl4030_i2c_write_u8(u8 mod_no, u8 value, u8 reg)
 EXPORT_SYMBOL(twl4030_i2c_write_u8);
 
 /**
- * @brief twl4030_i2c_read_u8 - Reads a 8 bit register from TWL4030
- *
- * @param mod_no - module number
- * @param *value - the value read 8 bit
- * @param reg - register address (just offset will do)
+ * twl4030_i2c_read_u8 - Reads a 8 bit register from TWL4030
+ * @mod_no: module number
+ * @value: the value read 8 bit
+ * @reg: register address (just offset will do)
  *
- * @return result of operation - 0 is success
+ * Returns result of operation - 0 is success
  */
 int twl4030_i2c_read_u8(u8 mod_no, u8 *value, u8 reg)
 {
@@ -461,6 +575,8 @@ static void do_twl4030_module_irq(unsigned int irq, irq_desc_t *desc)
                                " be masked!\n", irq);
 }
 
+static unsigned twl4030_irq_base;
+
 /*
  * twl4030_irq_thread() runs as a kernel thread.  It queries the twl4030
  * interrupt controller to see which modules are generating interrupt requests
@@ -497,7 +613,7 @@ static int twl4030_irq_thread(void *data)
                        continue;
                }
 
-               for (module_irq = TWL4030_IRQ_BASE; 0 != pih_isr;
+               for (module_irq = twl4030_irq_base; 0 != pih_isr;
                         pih_isr >>= 1, module_irq++) {
                        if (pih_isr & 0x1) {
                                irq_desc_t *d = irq_desc + module_irq;
@@ -546,110 +662,213 @@ static void do_twl4030_irq(unsigned int irq, irq_desc_t *desc)
        }
 }
 
-/* attach a client to the adapter */
-static int twl4030_detect_client(struct i2c_adapter *adapter, unsigned char sid)
+static int add_children(struct twl4030_platform_data *pdata)
 {
-       int err = 0;
-       struct twl4030_client *twl;
+       struct platform_device  *pdev = NULL;
+       struct twl4030_client   *twl = NULL;
+       int                     status = 0;
+
+       if (twl_has_gpio() && pdata->gpio) {
+               twl = &twl4030_modules[TWL4030_SLAVENUM_NUM1];
+
+               pdev = platform_device_alloc("twl4030_gpio", -1);
+               if (!pdev) {
+                       pr_debug("%s: can't alloc gpio dev\n", DRIVER_NAME);
+                       status = -ENOMEM;
+                       goto err;
+               }
 
-       if (unlikely(sid >= TWL4030_NUM_SLAVES)) {
-               pr_err("sid[%d] > MOD_LAST[%d]\n", sid, TWL4030_NUM_SLAVES);
-               return -EPERM;
+               /* more driver model init */
+               if (status == 0) {
+                       pdev->dev.parent = &twl->client->dev;
+                       /* device_init_wakeup(&pdev->dev, 1); */
+
+                       status = platform_device_add_data(pdev, pdata->gpio,
+                                       sizeof(*pdata->gpio));
+                       if (status < 0) {
+                               dev_dbg(&twl->client->dev,
+                                       "can't add gpio data, %d\n",
+                                       status);
+                               goto err;
+                       }
+               }
+
+               /* GPIO module IRQ */
+               if (status == 0) {
+                       struct resource r = {
+                               .start = pdata->irq_base + 0,
+                               .flags = IORESOURCE_IRQ,
+                       };
+
+                       status = platform_device_add_resources(pdev, &r, 1);
+               }
+
+               if (status == 0)
+                       status = platform_device_add(pdev);
+
+               if (status < 0) {
+                       platform_device_put(pdev);
+                       dev_dbg(&twl->client->dev,
+                                       "can't create gpio dev, %d\n",
+                                       status);
+                       goto err;
+               }
        }
 
-       /* Check basic functionality */
-       err = i2c_check_functionality(adapter,
-                       I2C_FUNC_SMBUS_WORD_DATA
-                       | I2C_FUNC_SMBUS_WRITE_BYTE);
-       if (!err) {
-               pr_err("SlaveID=%d functionality check failed\n", sid);
-               return err;
+       if (twl_has_keypad() && pdata->keypad) {
+               pdev = platform_device_alloc("twl4030_keypad", -1);
+               if (pdev) {
+                       twl = &twl4030_modules[TWL4030_SLAVENUM_NUM2];
+                       pdev->dev.parent = &twl->client->dev;
+                       device_init_wakeup(&pdev->dev, 1);
+                       status = platform_device_add_data(pdev, pdata->keypad,
+                                       sizeof(*pdata->keypad));
+                       if (status < 0) {
+                               dev_dbg(&twl->client->dev,
+                                       "can't add keypad data, %d\n",
+                                       status);
+                               platform_device_put(pdev);
+                               goto err;
+                       }
+                       status = platform_device_add(pdev);
+                       if (status < 0) {
+                               platform_device_put(pdev);
+                               dev_dbg(&twl->client->dev,
+                                               "can't create keypad dev, %d\n",
+                                               status);
+                               goto err;
+                       }
+               } else {
+                       pr_debug("%s: can't alloc keypad dev\n", DRIVER_NAME);
+                       status = -ENOMEM;
+                       goto err;
+               }
        }
-       twl = &twl4030_modules[sid];
-       if (unlikely(twl->inuse)) {
-               pr_err("Client %s is already in use\n", twl->client_name);
-               return -EPERM;
+
+       if (twl_has_madc() && pdata->madc) {
+               pdev = platform_device_alloc("twl4030_madc", -1);
+               if (pdev) {
+                       twl = &twl4030_modules[TWL4030_SLAVENUM_NUM2];
+                       pdev->dev.parent = &twl->client->dev;
+                       device_init_wakeup(&pdev->dev, 1);
+                       status = platform_device_add_data(pdev, pdata->madc,
+                                       sizeof(*pdata->madc));
+                       if (status < 0) {
+                               platform_device_put(pdev);
+                               dev_dbg(&twl->client->dev,
+                                       "can't add madc data, %d\n",
+                                       status);
+                               goto err;
+                       }
+                       status = platform_device_add(pdev);
+                       if (status < 0) {
+                               platform_device_put(pdev);
+                               dev_dbg(&twl->client->dev,
+                                               "can't create madc dev, %d\n",
+                                               status);
+                               goto err;
+                       }
+               } else {
+                       pr_debug("%s: can't alloc madc dev\n", DRIVER_NAME);
+                       status = -ENOMEM;
+                       goto err;
+               }
        }
 
-       memset(&twl->client, 0, sizeof(struct i2c_client));
+       if (twl_has_rtc()) {
+               twl = &twl4030_modules[TWL4030_SLAVENUM_NUM3];
 
-       twl->client.addr        = twl->address;
-       twl->client.adapter     = adapter;
-       twl->client.driver      = &twl4030_driver;
+               pdev = platform_device_alloc("twl4030_rtc", -1);
+               if (!pdev) {
+                       pr_debug("%s: can't alloc rtc dev\n", DRIVER_NAME);
+                       status = -ENOMEM;
+               } else {
+                       pdev->dev.parent = &twl->client->dev;
+                       device_init_wakeup(&pdev->dev, 1);
+               }
 
-       memcpy(&twl->client.name, twl->client_name,
-                       sizeof(TWL_CLIENT_STRING) + 1);
+               /*
+                * REVISIT platform_data here currently might use of
+                * "msecure" line ... but for now we just expect board
+                * setup to tell the chip "we are secure" at all times.
+                * Eventually, Linux might become more aware of such
+                * HW security concerns, and "least privilege".
+                */
+
+               /* RTC module IRQ */
+               if (status == 0) {
+                       struct resource r = {
+                               /* REVISIT don't hard-wire this stuff */
+                               .start = TWL4030_PWRIRQ_RTC,
+                               .flags = IORESOURCE_IRQ,
+                       };
+
+                       status = platform_device_add_resources(pdev, &r, 1);
+               }
 
-       pr_info("TWL4030: TRY attach Slave %s on Adapter %s [%x]\n",
-                               twl->client_name, adapter->name, err);
+               if (status == 0)
+                       status = platform_device_add(pdev);
 
-       err = i2c_attach_client(&twl->client);
-       if (err) {
-               pr_err("Couldn't attach Slave %s on Adapter"
-                      "%s [%x]\n", twl->client_name, adapter->name, err);
-       } else {
-               twl->inuse = TWL_CLIENT_USED;
-               mutex_init(&twl->xfer_lock);
+               if (status < 0) {
+                       platform_device_put(pdev);
+                       dev_dbg(&twl->client->dev,
+                                       "can't create rtc dev, %d\n",
+                                       status);
+                       goto err;
+               }
        }
 
-       return err;
-}
+       if (twl_has_usb() && pdata->usb) {
+               twl = &twl4030_modules[TWL4030_SLAVENUM_NUM0];
 
-/* adapter callback */
-static int twl4030_attach_adapter(struct i2c_adapter *adapter)
-{
-       int i;
-       int ret = 0;
-       static int twl_i2c_adapter = 1;
+               pdev = platform_device_alloc("twl4030_usb", -1);
+               if (!pdev) {
+                       pr_debug("%s: can't alloc usb dev\n", DRIVER_NAME);
+                       status = -ENOMEM;
+                       goto err;
+               }
 
-       for (i = 0; i < TWL4030_NUM_SLAVES; i++) {
-               /* Check if I need to hook on to this adapter or not */
-               if (twl4030_modules[i].adapter_index == twl_i2c_adapter) {
-                       ret = twl4030_detect_client(adapter, i);
-                       if (ret)
-                               goto free_client;
+               if (status == 0) {
+                       pdev->dev.parent = &twl->client->dev;
+                       device_init_wakeup(&pdev->dev, 1);
+                       status = platform_device_add_data(pdev, pdata->usb,
+                                       sizeof(*pdata->usb));
+                       if (status < 0) {
+                               platform_device_put(pdev);
+                               dev_dbg(&twl->client->dev,
+                                       "can't add usb data, %d\n",
+                                       status);
+                               goto err;
+                       }
                }
-       }
-       twl_i2c_adapter++;
 
-       /*
-        * Check if the PIH module is initialized, if yes, then init
-        * the T2 Interrupt subsystem
-        */
-       if ((twl4030_modules[twl4030_map[TWL4030_MODULE_PIH].sid].inuse ==
-               TWL_CLIENT_USED) && (twl_irq_used != USED)) {
-               twl_init_irq();
-               twl_irq_used = USED;
-       }
-       return 0;
+               if (status == 0) {
+                       struct resource r = {
+                               .start = TWL4030_PWRIRQ_USB_PRES,
+                               .flags = IORESOURCE_IRQ,
+                       };
 
-free_client:
-       pr_err("TWL_CLIENT(Idx=%d] registration failed[0x%x]\n", i, ret);
+                       status = platform_device_add_resources(pdev, &r, 1);
+               }
 
-       /* ignore current slave..it never got registered */
-       i--;
-       while (i >= 0) {
-               /* now remove all those from the current adapter... */
-               if (twl4030_modules[i].adapter_index == twl_i2c_adapter)
-                       (void)twl4030_detach_client(&twl4030_modules[i].client);
-               i--;
-       }
-       return ret;
-}
+               if (status == 0)
+                       status = platform_device_add(pdev);
 
-/* adapter's callback */
-static int twl4030_detach_client(struct i2c_client *client)
-{
-       int err;
-       err = i2c_detach_client(client);
-       if (err) {
-               pr_err("Client detach failed\n");
-               return err;
+               if (status < 0) {
+                       platform_device_put(pdev);
+                       dev_dbg(&twl->client->dev,
+                                       "can't create usb dev, %d\n",
+                                       status);
+               }
        }
-       return 0;
+
+err:
+       if (status)
+               pr_err("failed to add twl4030's children (status %d)\n", status);
+       return status;
 }
 
-static struct task_struct *start_twl4030_irq_thread(int irq)
+static struct task_struct * __init start_twl4030_irq_thread(int irq)
 {
        struct task_struct *thread;
 
@@ -658,7 +877,7 @@ static struct task_struct *start_twl4030_irq_thread(int irq)
                             "twl4030 irq %d", irq);
        if (!thread)
                pr_err("%s: could not create twl4030 irq %d thread!\n",
-                      __func__, irq);
+                      DRIVER_NAME, irq);
 
        return thread;
 }
@@ -667,7 +886,7 @@ static struct task_struct *start_twl4030_irq_thread(int irq)
  * These three functions should be part of Voltage frame work
  * added here to complete the functionality for now.
  */
-static int protect_pm_master(void)
+static int __init protect_pm_master(void)
 {
        int e = 0;
 
@@ -676,7 +895,7 @@ static int protect_pm_master(void)
        return e;
 }
 
-static int unprotect_pm_master(void)
+static int __init unprotect_pm_master(void)
 {
        int e = 0;
 
@@ -687,19 +906,21 @@ static int unprotect_pm_master(void)
        return e;
 }
 
-static int power_companion_init(void)
+static int __init power_companion_init(void)
 {
+       int e = 0;
+
+#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
        struct clk *osc;
        u32 rate;
        u8 ctrl = HFCLK_FREQ_26_MHZ;
-       int e = 0;
 
        if (cpu_is_omap2430())
                osc = clk_get(NULL, "osc_ck");
        else
                osc = clk_get(NULL, "osc_sys_ck");
        if (IS_ERR(osc)) {
-               printk(KERN_WARNING "Skipping twl3040 internal clock init and "
+               printk(KERN_WARNING "Skipping twl4030 internal clock init and "
                                "using bootloader value (unknown osc rate)\n");
                return 0;
        }
@@ -708,9 +929,15 @@ static int power_companion_init(void)
        clk_put(osc);
 
        switch (rate) {
-       case 19200000 : ctrl = HFCLK_FREQ_19p2_MHZ; break;
-       case 26000000 : ctrl = HFCLK_FREQ_26_MHZ; break;
-       case 38400000 : ctrl = HFCLK_FREQ_38p4_MHZ; break;
+       case 19200000:
+               ctrl = HFCLK_FREQ_19p2_MHZ;
+               break;
+       case 26000000:
+               ctrl = HFCLK_FREQ_26_MHZ;
+               break;
+       case 38400000:
+               ctrl = HFCLK_FREQ_38p4_MHZ;
+               break;
        }
 
        ctrl |= HIGH_PERF_SQ;
@@ -718,6 +945,7 @@ static int power_companion_init(void)
        /* effect->MADC+USB ck en */
        e |= twl4030_i2c_write_u8(TWL4030_MODULE_PM_MASTER, ctrl, R_CFG_BOOT);
        e |= protect_pm_master();
+#endif /* OMAP */
 
        return e;
 }
@@ -732,7 +960,7 @@ static int power_companion_init(void)
  * status register to ensure that any prior interrupts are cleared.
  * Returns the status from the I2C read operation.
  */
-static int twl4030_i2c_clear_isr(u8 mod_no, u8 reg, u8 cor)
+static int __init twl4030_i2c_clear_isr(u8 mod_no, u8 reg, u8 cor)
 {
        u8 tmp;
 
@@ -761,185 +989,203 @@ static int twl4030_read_cor_bit(u8 mod_no, u8 reg)
        return tmp;
 }
 
-static void twl_init_irq(void)
+/**
+ * twl4030_mask_clear_intrs - mask and clear all TWL4030 interrupts
+ * @t: pointer to twl4030_mod_iregs array
+ * @t_sz: ARRAY_SIZE(t) (starting at 1)
+ *
+ * Mask all TWL4030 interrupt mask registers (IMRs) and clear all
+ * interrupt status registers (ISRs).  No return value, but will WARN if
+ * any I2C operations fail.
+ */
+static void __init twl4030_mask_clear_intrs(const struct twl4030_mod_iregs *t,
+                                           const u8 t_sz)
 {
-       int     i = 0;
-       int     res = 0;
-       int cor;
-       char    *msg = "Unable to register interrupt subsystem";
-       unsigned int irq_num;
+       int i, j;
 
        /*
-        * For each TWL4030 module with ISR/IMR registers, mask all
-        * interrupts and then clear any existing interrupt status bits,
-        * since we initially do not have any TWL4030 module interrupt
-        * handlers present.
+        * N.B. - further efficiency is possible here.  Eight I2C
+        * operations on BCI and GPIO modules are avoidable if I2C
+        * burst read/write transactions were implemented.  Would
+        * probably save about 1ms of boot time and a small amount of
+        * power.
         */
+       for (i = 0; i < t_sz; i++) {
+               const struct twl4030_mod_iregs tmr = t[i];
+               int cor;
 
+               /* Are ISRs cleared by reads or writes? */
+               cor = twl4030_read_cor_bit(tmr.mod_no, tmr.sih_ctrl);
+               WARN_ON(cor < 0);
 
-       /* PWR_IMR1 */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_INT, 0xff, 0x1) < 0);
+               for (j = 0; j < tmr.reg_cnt; j++) {
 
-       /* PWR_IMR2 */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_INT, 0xff, 0x3) < 0);
+                       /* Mask interrupts at the TWL4030 */
+                       WARN_ON(twl4030_i2c_write_u8(tmr.mod_no, 0xff,
+                                                    tmr.imrs[j]) < 0);
 
-       /* Clear off any other pending interrupts on power */
-
-       /* Are PWR interrupt status bits cleared by reads or writes? */
-       cor = twl4030_read_cor_bit(TWL4030_MODULE_INT,
-                                  TWL4030_INT_PWR_SIH_CTRL);
-       WARN_ON(cor < 0);
-
-       /* PWR_ISR1 */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_INT, 0x00, cor) < 0);
-
-       /* PWR_ISR2 */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_INT, 0x02, cor) < 0);
-
-       /* Slave address 0x4A */
-
-       /* BCIIMR1A */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xff, 0x2) < 0);
-
-       /* BCIIMR2A  */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xff, 0x3) < 0);
-
-       /* BCIIMR2A */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xff, 0x6) < 0);
-
-       /* BCIIMR2B */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xff, 0x7) < 0);
-
-       /* Are BCI interrupt status bits cleared by reads or writes? */
-       cor = twl4030_read_cor_bit(TWL4030_MODULE_INTERRUPTS,
-                                  TWL4030_INTERRUPTS_BCISIHCTRL);
-       WARN_ON(cor < 0);
-
-       /* BCIISR1A */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_INTERRUPTS, 0x0, cor) < 0);
-
-       /* BCIISR2A */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_INTERRUPTS, 0x1, cor) < 0);
-
-       /* BCIISR1B */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_INTERRUPTS, 0x4, cor) < 0);
-
-       /* BCIISR2B */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_INTERRUPTS, 0x5, cor) < 0);
-
-       /* MAD C */
-       /* MADC_IMR1 */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_MADC, 0xff, 0x62) < 0);
-
-       /* MADC_IMR2 */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_MADC, 0xff, 0x64) < 0);
-
-       /* Are MADC interrupt status bits cleared by reads or writes? */
-       cor = twl4030_read_cor_bit(TWL4030_MODULE_MADC,
-                                  TWL4030_MADC_MADC_SIH_CTRL);
-       WARN_ON(cor < 0);
-
-       /* MADC_ISR1 */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_MADC, 0x61, cor) < 0);
-
-       /* MADC_ISR2 */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_MADC, 0x63, cor) < 0);
+                       /* Clear TWL4030 ISRs */
+                       WARN_ON(twl4030_i2c_clear_isr(tmr.mod_no,
+                                                     tmr.isrs[j], cor) < 0);
+               }
+       }
 
-       /* key Pad */
-       /* KEYPAD - IMR1 */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_KEYPAD, 0xff, 0x12) < 0);
+       return;
+}
 
-       /* Are keypad interrupt status bits cleared by reads or writes? */
-       cor = twl4030_read_cor_bit(TWL4030_MODULE_KEYPAD,
-                                  TWL4030_KEYPAD_KEYP_SIH_CTRL);
-       WARN_ON(cor < 0);
 
-       /* KEYPAD - ISR1 */
-       /* XXX does this still need to be done twice for some reason? */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_KEYPAD, 0x11, cor) < 0);
+static void twl_init_irq(int irq_num, unsigned irq_base, unsigned irq_end)
+{
+       int     i;
+       int     res = 0;
+       char    *msg = "Unable to register interrupt subsystem";
 
-       /* KEYPAD - IMR2 */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_KEYPAD, 0xff, 0x14) < 0);
+       /*
+        * Mask and clear all TWL4030 interrupts since initially we do
+        * not have any TWL4030 module interrupt handlers present
+        */
+       twl4030_mask_clear_intrs(twl4030_mod_regs,
+                                ARRAY_SIZE(twl4030_mod_regs));
 
-       /* KEYPAD - ISR2 */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_KEYPAD, 0x13, cor) < 0);
+       twl4030_irq_base = irq_base;
 
-       /* Slave address 0x49 */
-       /* GPIO_IMR1A */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x1c) < 0);
+       /* install an irq handler for each of the PIH modules */
+       for (i = irq_base; i < irq_end; i++) {
+               set_irq_chip(i, &twl4030_irq_chip);
+               set_irq_handler(i, do_twl4030_module_irq);
+               set_irq_flags(i, IRQF_VALID);
+       }
 
-       /* GPIO_IMR2A */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x1d) < 0);
+       /* install an irq handler to demultiplex the TWL4030 interrupt */
+       set_irq_data(irq_num, start_twl4030_irq_thread(irq_num));
+       set_irq_type(irq_num, IRQ_TYPE_EDGE_FALLING);
+       set_irq_chained_handler(irq_num, do_twl4030_irq);
 
-       /* GPIO_IMR3A */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x1e) < 0);
+       res = power_companion_init();
+       if (res < 0)
+               pr_err("%s: %s[%d]\n", DRIVER_NAME, msg, res);
+}
 
-       /* GPIO_IMR1B */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x22) < 0);
+/*----------------------------------------------------------------------*/
 
-       /* GPIO_IMR2B */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x23) < 0);
+static int twl4030_remove(struct i2c_client *client)
+{
+       unsigned i;
 
-       /* GPIO_IMR3B */
-       WARN_ON(twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x24) < 0);
+       /* FIXME undo twl_init_irq() */
+       if (twl4030_irq_base) {
+               dev_err(&client->dev, "can't yet clean up IRQs?\n");
+               return -ENOSYS;
+       }
 
-       /* Are GPIO interrupt status bits cleared by reads or writes? */
-       cor = twl4030_read_cor_bit(TWL4030_MODULE_GPIO,
-                                  TWL4030_GPIO_GPIO_SIH_CTRL);
-       WARN_ON(cor < 0);
+       for (i = 0; i < TWL4030_NUM_SLAVES; i++) {
+               struct twl4030_client   *twl = &twl4030_modules[i];
 
-       /* GPIO_ISR1A */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_GPIO, 0x19, cor) < 0);
+               if (twl->client && twl->client != client)
+                       i2c_unregister_device(twl->client);
+               twl4030_modules[i].client = NULL;
+               twl4030_modules[i].inuse = false;
+       }
+       return 0;
+}
 
-       /* GPIO_ISR2A */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_GPIO, 0x1a, cor) < 0);
+/* NOTE:  this driver only handles a single twl4030/tps659x0 chip */
+static int
+twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
+{
+       int                             status;
+       unsigned                        i;
+       struct twl4030_platform_data    *pdata = client->dev.platform_data;
 
-       /* GPIO_ISR3A */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_GPIO, 0x1b, cor) < 0);
+       if (!pdata) {
+               dev_dbg(&client->dev, "no platform data?\n");
+               return -EINVAL;
+       }
 
-       /* GPIO_ISR1B */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_GPIO, 0x1f, cor) < 0);
+       if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C) == 0) {
+               dev_dbg(&client->dev, "can't talk I2C?\n");
+               return -EIO;
+       }
 
-       /* GPIO_ISR2B */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_GPIO, 0x20, cor) < 0);
+       for (i = 0; i < TWL4030_NUM_SLAVES; i++) {
+               if (twl4030_modules[i].inuse || twl4030_irq_base) {
+                       dev_dbg(&client->dev, "driver is already in use\n");
+                       return -EBUSY;
+               }
+       }
 
-       /* GPIO_ISR3B */
-       WARN_ON(twl4030_i2c_clear_isr(TWL4030_MODULE_GPIO, 0x21, cor) < 0);
+       for (i = 0; i < TWL4030_NUM_SLAVES; i++) {
+               struct twl4030_client   *twl = &twl4030_modules[i];
+
+               twl->address = client->addr + i;
+               if (i == 0)
+                       twl->client = client;
+               else {
+                       twl->client = i2c_new_dummy(client->adapter,
+                                       twl->address);
+                       if (!twl->client) {
+                               dev_err(&twl->client->dev,
+                                       "can't attach client %d\n", i);
+                               status = -ENOMEM;
+                               goto fail;
+                       }
+                       strlcpy(twl->client->name, id->name,
+                                       sizeof(twl->client->name));
+               }
+               twl->inuse = true;
+               mutex_init(&twl->xfer_lock);
+       }
 
-       /* install an irq handler for each of the PIH modules */
-       for (i = TWL4030_IRQ_BASE; i < TWL4030_IRQ_END; i++) {
-               set_irq_chip(i, &twl4030_irq_chip);
-               set_irq_handler(i, do_twl4030_module_irq);
-               set_irq_flags(i, IRQF_VALID);
+       /*
+        * Check if the PIH module is initialized, if yes, then init
+        * the T2 Interrupt subsystem
+        */
+       if (twl4030_modules[twl4030_map[TWL4030_MODULE_PIH].sid].inuse
+                       && twl4030_irq_base == 0
+                       && client->irq
+                       && pdata->irq_base
+                       && pdata->irq_end > pdata->irq_base) {
+               twl_init_irq(client->irq, pdata->irq_base, pdata->irq_end);
+               dev_info(&client->dev, "IRQ %d chains IRQs %d..%d\n",
+                               client->irq, pdata->irq_base, pdata->irq_end - 1);
        }
 
-       irq_num = (cpu_is_omap2430()) ? INT_24XX_SYS_NIRQ : INT_34XX_SYS_NIRQ;
+       status = add_children(pdata);
+fail:
+       if (status < 0)
+               twl4030_remove(client);
+       return status;
+}
 
-       /* install an irq handler to demultiplex the TWL4030 interrupt */
-       set_irq_data(irq_num, start_twl4030_irq_thread(irq_num));
-       set_irq_type(irq_num, IRQT_FALLING);
-       set_irq_chained_handler(irq_num, do_twl4030_irq);
+static const struct i2c_device_id twl4030_ids[] = {
+       { "twl4030", 0 },       /* "Triton 2" */
+       { "tps65950", 0 },      /* catalog version of twl4030 */
+       { "tps65930", 0 },      /* fewer LDOs and DACs; no charger */
+       { "tps65920", 0 },      /* fewer LDOs; no codec or charger */
+       { /* end of list */ },
+};
+MODULE_DEVICE_TABLE(i2c, twl4030_ids);
 
-       res = power_companion_init();
-       if (res < 0)
-               pr_err("%s[%d][%d]\n", msg, res, __LINE__);
-}
+/* One Client Driver , 4 Clients */
+static struct i2c_driver twl4030_driver = {
+       .driver.name    = DRIVER_NAME,
+       .id_table       = twl4030_ids,
+       .probe          = twl4030_probe,
+       .remove         = twl4030_remove,
+};
 
 static int __init twl4030_init(void)
 {
        return i2c_add_driver(&twl4030_driver);
 }
+subsys_initcall(twl4030_init);
 
 static void __exit twl4030_exit(void)
 {
        i2c_del_driver(&twl4030_driver);
-       twl_irq_used = FREE;
 }
-
-subsys_initcall(twl4030_init);
 module_exit(twl4030_exit);
 
-MODULE_ALIAS("i2c:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments, Inc.");
 MODULE_DESCRIPTION("I2C Core interface for TWL4030");
 MODULE_LICENSE("GPL");