]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/ide/ide-io.c
ide: remove hwif->intrproc
[linux-2.6-omap-h63xx.git] / drivers / ide / ide-io.c
index c89f0d3058e934767bc1c2a3b8b7e2231b43a587..6ee7458d34edf8b06cd359edb151c4e1c30d0aa5 100644 (file)
@@ -189,18 +189,14 @@ static ide_startstop_t ide_start_power_step(ide_drive_t *drive, struct request *
                        return ide_stopped;
                }
                if (ide_id_has_flush_cache_ext(drive->id))
-                       args->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE_EXT;
+                       args->tf.command = WIN_FLUSH_CACHE_EXT;
                else
-                       args->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE;
-               args->command_type = IDE_DRIVE_TASK_NO_DATA;
-               args->handler      = &task_no_data_intr;
-               return do_rw_taskfile(drive, args);
+                       args->tf.command = WIN_FLUSH_CACHE;
+               goto out_do_tf;
 
        case idedisk_pm_standby:        /* Suspend step 2 (standby) */
-               args->tfRegister[IDE_COMMAND_OFFSET] = WIN_STANDBYNOW1;
-               args->command_type = IDE_DRIVE_TASK_NO_DATA;
-               args->handler      = &task_no_data_intr;
-               return do_rw_taskfile(drive, args);
+               args->tf.command = WIN_STANDBYNOW1;
+               goto out_do_tf;
 
        case idedisk_pm_restore_pio:    /* Resume step 1 (restore PIO) */
                ide_set_max_pio(drive);
@@ -214,10 +210,8 @@ static ide_startstop_t ide_start_power_step(ide_drive_t *drive, struct request *
                return ide_stopped;
 
        case idedisk_pm_idle:           /* Resume step 2 (idle) */
-               args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
-               args->command_type = IDE_DRIVE_TASK_NO_DATA;
-               args->handler = task_no_data_intr;
-               return do_rw_taskfile(drive, args);
+               args->tf.command = WIN_IDLEIMMEDIATE;
+               goto out_do_tf;
 
        case ide_pm_restore_dma:        /* Resume step 3 (restore DMA) */
                /*
@@ -236,6 +230,12 @@ static ide_startstop_t ide_start_power_step(ide_drive_t *drive, struct request *
        }
        pm->pm_step = ide_pm_state_completed;
        return ide_stopped;
+
+out_do_tf:
+       args->tf_flags = IDE_TFLAG_OUT_TF | IDE_TFLAG_OUT_DEVICE;
+       args->command_type = IDE_DRIVE_TASK_NO_DATA;
+       args->handler      = task_no_data_intr;
+       return do_rw_taskfile(drive, args);
 }
 
 /**
@@ -332,48 +332,37 @@ void ide_end_drive_cmd (ide_drive_t *drive, u8 stat, u8 err)
                        args[1] = err;
                        args[2] = hwif->INB(IDE_NSECTOR_REG);
                }
-       } else if (rq->cmd_type == REQ_TYPE_ATA_TASK) {
-               u8 *args = (u8 *) rq->buffer;
-               if (rq->errors == 0)
-                       rq->errors = !OK_STAT(stat,READY_STAT,BAD_STAT);
-
-               if (args) {
-                       args[0] = stat;
-                       args[1] = err;
-                       args[2] = hwif->INB(IDE_NSECTOR_REG);
-                       args[3] = hwif->INB(IDE_SECTOR_REG);
-                       args[4] = hwif->INB(IDE_LCYL_REG);
-                       args[5] = hwif->INB(IDE_HCYL_REG);
-                       args[6] = hwif->INB(IDE_SELECT_REG);
-               }
        } else if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE) {
                ide_task_t *args = (ide_task_t *) rq->special;
                if (rq->errors == 0)
                        rq->errors = !OK_STAT(stat,READY_STAT,BAD_STAT);
                        
                if (args) {
+                       struct ide_taskfile *tf = &args->tf;
+
                        if (args->tf_in_flags.b.data) {
-                               u16 data                                = hwif->INW(IDE_DATA_REG);
-                               args->tfRegister[IDE_DATA_OFFSET]       = (data) & 0xFF;
-                               args->hobRegister[IDE_DATA_OFFSET]      = (data >> 8) & 0xFF;
+                               u16 data = hwif->INW(IDE_DATA_REG);
+
+                               tf->data = data & 0xff;
+                               tf->hob_data = (data >> 8) & 0xff;
                        }
-                       args->tfRegister[IDE_ERROR_OFFSET]   = err;
+                       tf->error = err;
                        /* be sure we're looking at the low order bits */
                        hwif->OUTB(drive->ctl & ~0x80, IDE_CONTROL_REG);
-                       args->tfRegister[IDE_NSECTOR_OFFSET] = hwif->INB(IDE_NSECTOR_REG);
-                       args->tfRegister[IDE_SECTOR_OFFSET]  = hwif->INB(IDE_SECTOR_REG);
-                       args->tfRegister[IDE_LCYL_OFFSET]    = hwif->INB(IDE_LCYL_REG);
-                       args->tfRegister[IDE_HCYL_OFFSET]    = hwif->INB(IDE_HCYL_REG);
-                       args->tfRegister[IDE_SELECT_OFFSET]  = hwif->INB(IDE_SELECT_REG);
-                       args->tfRegister[IDE_STATUS_OFFSET]  = stat;
-
-                       if (drive->addressing == 1) {
+                       tf->nsect  = hwif->INB(IDE_NSECTOR_REG);
+                       tf->lbal   = hwif->INB(IDE_SECTOR_REG);
+                       tf->lbam   = hwif->INB(IDE_LCYL_REG);
+                       tf->lbah   = hwif->INB(IDE_HCYL_REG);
+                       tf->device = hwif->INB(IDE_SELECT_REG);
+                       tf->status = stat;
+
+                       if (args->tf_flags & IDE_TFLAG_LBA48) {
                                hwif->OUTB(drive->ctl|0x80, IDE_CONTROL_REG);
-                               args->hobRegister[IDE_FEATURE_OFFSET]   = hwif->INB(IDE_FEATURE_REG);
-                               args->hobRegister[IDE_NSECTOR_OFFSET]   = hwif->INB(IDE_NSECTOR_REG);
-                               args->hobRegister[IDE_SECTOR_OFFSET]    = hwif->INB(IDE_SECTOR_REG);
-                               args->hobRegister[IDE_LCYL_OFFSET]      = hwif->INB(IDE_LCYL_REG);
-                               args->hobRegister[IDE_HCYL_OFFSET]      = hwif->INB(IDE_HCYL_REG);
+                               tf->hob_feature = hwif->INB(IDE_FEATURE_REG);
+                               tf->hob_nsect   = hwif->INB(IDE_NSECTOR_REG);
+                               tf->hob_lbal    = hwif->INB(IDE_SECTOR_REG);
+                               tf->hob_lbam    = hwif->INB(IDE_LCYL_REG);
+                               tf->hob_lbah    = hwif->INB(IDE_HCYL_REG);
                        }
                }
        } else if (blk_pm_request(rq)) {
@@ -613,28 +602,6 @@ ide_startstop_t ide_abort(ide_drive_t *drive, const char *msg)
                return __ide_abort(drive, rq);
 }
 
-/**
- *     ide_cmd         -       issue a simple drive command
- *     @drive: drive the command is for
- *     @cmd: command byte
- *     @nsect: sector byte
- *     @handler: handler for the command completion
- *
- *     Issue a simple drive command with interrupts.
- *     The drive must be selected beforehand.
- */
-
-static void ide_cmd (ide_drive_t *drive, u8 cmd, u8 nsect,
-               ide_handler_t *handler)
-{
-       ide_hwif_t *hwif = HWIF(drive);
-       if (IDE_CONTROL_REG)
-               hwif->OUTB(drive->ctl,IDE_CONTROL_REG); /* clear nIEN */
-       SELECT_MASK(drive,0);
-       hwif->OUTB(nsect,IDE_NSECTOR_REG);
-       ide_execute_command(drive, cmd, handler, WAIT_CMD, NULL);
-}
-
 /**
  *     drive_cmd_intr          -       drive command completion interrupt
  *     @drive: drive the completion interrupt occurred on
@@ -654,7 +621,8 @@ static ide_startstop_t drive_cmd_intr (ide_drive_t *drive)
        int retries = 10;
 
        local_irq_enable_in_hardirq();
-       if ((stat & DRQ_STAT) && args && args[3]) {
+       if (rq->cmd_type == REQ_TYPE_ATA_CMD &&
+           (stat & DRQ_STAT) && args && args[3]) {
                u8 io_32bit = drive->io_32bit;
                drive->io_32bit = 0;
                hwif->ata_input_data(drive, &args[4], args[3] * SECTOR_WORDS);
@@ -672,28 +640,28 @@ static ide_startstop_t drive_cmd_intr (ide_drive_t *drive)
 
 static void ide_init_specify_cmd(ide_drive_t *drive, ide_task_t *task)
 {
-       task->tfRegister[IDE_NSECTOR_OFFSET] = drive->sect;
-       task->tfRegister[IDE_SECTOR_OFFSET]  = drive->sect;
-       task->tfRegister[IDE_LCYL_OFFSET]    = drive->cyl;
-       task->tfRegister[IDE_HCYL_OFFSET]    = drive->cyl>>8;
-       task->tfRegister[IDE_SELECT_OFFSET]  = ((drive->head-1)|drive->select.all)&0xBF;
-       task->tfRegister[IDE_COMMAND_OFFSET] = WIN_SPECIFY;
+       task->tf.nsect   = drive->sect;
+       task->tf.lbal    = drive->sect;
+       task->tf.lbam    = drive->cyl;
+       task->tf.lbah    = drive->cyl >> 8;
+       task->tf.device  = ((drive->head - 1) | drive->select.all) & ~ATA_LBA;
+       task->tf.command = WIN_SPECIFY;
 
        task->handler = &set_geometry_intr;
 }
 
 static void ide_init_restore_cmd(ide_drive_t *drive, ide_task_t *task)
 {
-       task->tfRegister[IDE_NSECTOR_OFFSET] = drive->sect;
-       task->tfRegister[IDE_COMMAND_OFFSET] = WIN_RESTORE;
+       task->tf.nsect   = drive->sect;
+       task->tf.command = WIN_RESTORE;
 
        task->handler = &recal_intr;
 }
 
 static void ide_init_setmult_cmd(ide_drive_t *drive, ide_task_t *task)
 {
-       task->tfRegister[IDE_NSECTOR_OFFSET] = drive->mult_req;
-       task->tfRegister[IDE_COMMAND_OFFSET] = WIN_SETMULT;
+       task->tf.nsect   = drive->mult_req;
+       task->tf.command = WIN_SETMULT;
 
        task->handler = &set_multmode_intr;
 }
@@ -724,6 +692,8 @@ static ide_startstop_t ide_disk_special(ide_drive_t *drive)
                return ide_stopped;
        }
 
+       args.tf_flags = IDE_TFLAG_OUT_TF | IDE_TFLAG_OUT_DEVICE;
+
        do_rw_taskfile(drive, &args);
 
        return ide_started;
@@ -858,13 +828,17 @@ static ide_startstop_t execute_drive_cmd (ide_drive_t *drive,
                struct request *rq)
 {
        ide_hwif_t *hwif = HWIF(drive);
+       u8 *args = rq->buffer;
+       ide_task_t ltask;
+       struct ide_taskfile *tf = &ltask.tf;
+
        if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE) {
-               ide_task_t *args = rq->special;
+               ide_task_t *task = rq->special;
  
-               if (!args)
+               if (task == NULL)
                        goto done;
 
-               hwif->data_phase = args->data_phase;
+               hwif->data_phase = task->data_phase;
 
                switch (hwif->data_phase) {
                case TASKFILE_MULTI_OUT:
@@ -877,59 +851,37 @@ static ide_startstop_t execute_drive_cmd (ide_drive_t *drive,
                        break;
                }
 
-               if (args->tf_out_flags.all != 0) 
-                       return flagged_taskfile(drive, args);
-               return do_rw_taskfile(drive, args);
-       } else if (rq->cmd_type == REQ_TYPE_ATA_TASK) {
-               u8 *args = rq->buffer;
-               u8 sel;
-               if (!args)
-                       goto done;
-#ifdef DEBUG
-               printk("%s: DRIVE_TASK_CMD ", drive->name);
-               printk("cmd=0x%02x ", args[0]);
-               printk("fr=0x%02x ", args[1]);
-               printk("ns=0x%02x ", args[2]);
-               printk("sc=0x%02x ", args[3]);
-               printk("lcyl=0x%02x ", args[4]);
-               printk("hcyl=0x%02x ", args[5]);
-               printk("sel=0x%02x\n", args[6]);
-#endif
-               hwif->OUTB(args[1], IDE_FEATURE_REG);
-               hwif->OUTB(args[3], IDE_SECTOR_REG);
-               hwif->OUTB(args[4], IDE_LCYL_REG);
-               hwif->OUTB(args[5], IDE_HCYL_REG);
-               sel = (args[6] & ~0x10);
-               if (drive->select.b.unit)
-                       sel |= 0x10;
-               hwif->OUTB(sel, IDE_SELECT_REG);
-               ide_cmd(drive, args[0], args[2], &drive_cmd_intr);
-               return ide_started;
-       } else if (rq->cmd_type == REQ_TYPE_ATA_CMD) {
-               u8 *args = rq->buffer;
-
-               if (!args)
-                       goto done;
+               if (task->tf_flags & IDE_TFLAG_FLAGGED)
+                       return flagged_taskfile(drive, task);
+
+               return do_rw_taskfile(drive, task);
+       }
+
+       if (args == NULL)
+               goto done;
+
+       memset(&ltask, 0, sizeof(ltask));
+       if (rq->cmd_type == REQ_TYPE_ATA_CMD) {
 #ifdef DEBUG
-               printk("%s: DRIVE_CMD ", drive->name);
-               printk("cmd=0x%02x ", args[0]);
-               printk("sc=0x%02x ", args[1]);
-               printk("fr=0x%02x ", args[2]);
-               printk("xx=0x%02x\n", args[3]);
+               printk("%s: DRIVE_CMD\n", drive->name);
 #endif
-               if (args[0] == WIN_SMART) {
-                       hwif->OUTB(0x4f, IDE_LCYL_REG);
-                       hwif->OUTB(0xc2, IDE_HCYL_REG);
-                       hwif->OUTB(args[2],IDE_FEATURE_REG);
-                       hwif->OUTB(args[1],IDE_SECTOR_REG);
-                       ide_cmd(drive, args[0], args[3], &drive_cmd_intr);
-                       return ide_started;
-               }
-               hwif->OUTB(args[2],IDE_FEATURE_REG);
-               ide_cmd(drive, args[0], args[1], &drive_cmd_intr);
-               return ide_started;
+               tf->feature = args[2];
+               if (args[0] == WIN_SMART) {
+                       tf->nsect = args[3];
+                       tf->lbal  = args[1];
+                       tf->lbam  = 0x4f;
+                       tf->lbah  = 0xc2;
+                       ltask.tf_flags = IDE_TFLAG_OUT_TF;
+               } else {
+                       tf->nsect = args[1];
+                       ltask.tf_flags = IDE_TFLAG_OUT_FEATURE |
+                                        IDE_TFLAG_OUT_NSECT;
+               }
        }
+       tf->command = args[0];
+       ide_tf_load(drive, &ltask);
+       ide_execute_command(drive, args[0], &drive_cmd_intr, WAIT_WORSTCASE, NULL);
+       return ide_started;
 
 done:
        /*
@@ -971,7 +923,8 @@ static void ide_check_pm_state(ide_drive_t *drive, struct request *rq)
                if (rc)
                        printk(KERN_WARNING "%s: bus not ready on wakeup\n", drive->name);
                SELECT_DRIVE(drive);
-               HWIF(drive)->OUTB(8, HWIF(drive)->io_ports[IDE_CONTROL_OFFSET]);
+               if (IDE_CONTROL_REG)
+                       HWIF(drive)->OUTB(drive->ctl, IDE_CONTROL_REG);
                rc = ide_wait_not_busy(HWIF(drive), 100000);
                if (rc)
                        printk(KERN_WARNING "%s: drive not ready on wakeup\n", drive->name);
@@ -1003,6 +956,7 @@ static ide_startstop_t start_request (ide_drive_t *drive, struct request *rq)
 
        /* bail early if we've exceeded max_failures */
        if (drive->max_failures && (drive->failures > drive->max_failures)) {
+               rq->cmd_flags |= REQ_FAILED;
                goto kill_rq;
        }
 
@@ -1035,7 +989,6 @@ static ide_startstop_t start_request (ide_drive_t *drive, struct request *rq)
                        ide_config_drive_speed(drive, drive->desired_speed);
 
                if (rq->cmd_type == REQ_TYPE_ATA_CMD ||
-                   rq->cmd_type == REQ_TYPE_ATA_TASK ||
                    rq->cmd_type == REQ_TYPE_ATA_TASKFILE)
                        return execute_drive_cmd(drive, rq);
                else if (blk_pm_request(rq)) {
@@ -1247,8 +1200,12 @@ static void ide_do_request (ide_hwgroup_t *hwgroup, int masked_irq)
                if (hwgroup->hwif->sharing_irq &&
                    hwif != hwgroup->hwif &&
                    hwif->io_ports[IDE_CONTROL_OFFSET]) {
-                       /* set nIEN for previous hwif */
-                       SELECT_INTERRUPT(drive);
+                       /*
+                        * set nIEN for previous hwif, drives in the
+                        * quirk_list may not like intr setups/cleanups
+                        */
+                       if (drive->quirk_list != 1)
+                               hwif->OUTB(drive->ctl | 2, IDE_CONTROL_REG);
                }
                hwgroup->hwif = hwif;
                hwgroup->drive = drive;
@@ -1454,12 +1411,8 @@ void ide_timer_expiry (unsigned long data)
                         */
                        spin_unlock(&ide_lock);
                        hwif  = HWIF(drive);
-#if DISABLE_IRQ_NOSYNC
-                       disable_irq_nosync(hwif->irq);
-#else
                        /* disable_irq_nosync ?? */
                        disable_irq(hwif->irq);
-#endif /* DISABLE_IRQ_NOSYNC */
                        /* local CPU only,
                         * as if we were handling an interrupt */
                        local_irq_disable();
@@ -1785,3 +1738,19 @@ int ide_do_drive_cmd (ide_drive_t *drive, struct request *rq, ide_action_t actio
 }
 
 EXPORT_SYMBOL(ide_do_drive_cmd);
+
+void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount, u8 dma)
+{
+       ide_task_t task;
+
+       memset(&task, 0, sizeof(task));
+       task.tf_flags = IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM |
+                       IDE_TFLAG_OUT_FEATURE | tf_flags;
+       task.tf.feature = dma;          /* Use PIO/DMA */
+       task.tf.lbam    = bcount & 0xff;
+       task.tf.lbah    = (bcount >> 8) & 0xff;
+
+       ide_tf_load(drive, &task);
+}
+
+EXPORT_SYMBOL_GPL(ide_pktcmd_tf_load);