]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/media/video/cx18/cx18-queue.c
V4L/DVB (9800): cx18: Eliminate q_io from stream buffer handling
[linux-2.6-omap-h63xx.git] / drivers / media / video / cx18 / cx18-queue.c
index a33ba04a2686aa3ec73d0d705ddc1aa1bb3abad8..fdfc83ee3d4e20521dfcd2f31416f60a03b3eff1 100644 (file)
@@ -4,6 +4,7 @@
  *  Derived from ivtv-queue.c
  *
  *  Copyright (C) 2007  Hans Verkuil <hverkuil@xs4all.nl>
+ *  Copyright (C) 2008  Andy Walls <awalls@radix.net>
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -41,93 +42,126 @@ void cx18_queue_init(struct cx18_queue *q)
        q->bytesused = 0;
 }
 
-void cx18_enqueue(struct cx18_stream *s, struct cx18_buffer *buf,
-               struct cx18_queue *q)
+void _cx18_enqueue(struct cx18_stream *s, struct cx18_buffer *buf,
+                  struct cx18_queue *q, int to_front)
 {
-       unsigned long flags = 0;
-
        /* clear the buffer if it is going to be enqueued to the free queue */
        if (q == &s->q_free) {
                buf->bytesused = 0;
                buf->readpos = 0;
                buf->b_flags = 0;
+               buf->skipped = 0;
        }
-       spin_lock_irqsave(&s->qlock, flags);
-       list_add_tail(&buf->list, &q->list);
+       mutex_lock(&s->qlock);
+       if (to_front)
+               list_add(&buf->list, &q->list); /* LIFO */
+       else
+               list_add_tail(&buf->list, &q->list); /* FIFO */
        atomic_inc(&q->buffers);
        q->bytesused += buf->bytesused - buf->readpos;
-       spin_unlock_irqrestore(&s->qlock, flags);
+       mutex_unlock(&s->qlock);
 }
 
 struct cx18_buffer *cx18_dequeue(struct cx18_stream *s, struct cx18_queue *q)
 {
        struct cx18_buffer *buf = NULL;
-       unsigned long flags = 0;
 
-       spin_lock_irqsave(&s->qlock, flags);
+       mutex_lock(&s->qlock);
        if (!list_empty(&q->list)) {
                buf = list_entry(q->list.next, struct cx18_buffer, list);
                list_del_init(q->list.next);
                atomic_dec(&q->buffers);
                q->bytesused -= buf->bytesused - buf->readpos;
+               buf->skipped = 0;
        }
-       spin_unlock_irqrestore(&s->qlock, flags);
+       mutex_unlock(&s->qlock);
        return buf;
 }
 
-struct cx18_buffer *cx18_queue_get_buf_irq(struct cx18_stream *s, u32 id,
+struct cx18_buffer *cx18_queue_get_buf(struct cx18_stream *s, u32 id,
        u32 bytesused)
 {
        struct cx18 *cx = s->cx;
-       struct list_head *p;
-
-       spin_lock(&s->qlock);
-       list_for_each(p, &s->q_free.list) {
-               struct cx18_buffer *buf =
-                       list_entry(p, struct cx18_buffer, list);
-
-               if (buf->id != id)
+       struct cx18_buffer *buf;
+       struct cx18_buffer *ret = NULL;
+       struct list_head *p, *t;
+       LIST_HEAD(r);
+
+       mutex_lock(&s->qlock);
+       list_for_each_safe(p, t, &s->q_free.list) {
+               buf = list_entry(p, struct cx18_buffer, list);
+
+               if (buf->id != id) {
+                       buf->skipped++;
+                       if (buf->skipped >= atomic_read(&s->q_free.buffers)-1) {
+                               /* buffer must have fallen out of rotation */
+                               atomic_dec(&s->q_free.buffers);
+                               list_move_tail(&buf->list, &r);
+                               CX18_WARN("Skipped %s, buffer %d, %d "
+                                         "times - it must have dropped out of "
+                                         "rotation\n", s->name, buf->id,
+                                         buf->skipped);
+                       }
                        continue;
+               }
+
                buf->bytesused = bytesused;
-               /* the transport buffers are handled differently,
-                  they are not moved to the full queue */
-               if (s->type != CX18_ENC_STREAM_TYPE_TS) {
-                       atomic_dec(&s->q_free.buffers);
+               atomic_dec(&s->q_free.buffers);
+               if (s->type == CX18_ENC_STREAM_TYPE_TS) {
+                       /*
+                        * TS doesn't use q_full, but for sweeping up lost
+                        * buffers, we want the TS to requeue the buffer just
+                        * before sending the MDL back to the firmware, so we
+                        * pull it off the list here.
+                        */
+                       list_del_init(&buf->list);
+               } else {
                        atomic_inc(&s->q_full.buffers);
                        s->q_full.bytesused += buf->bytesused;
                        list_move_tail(&buf->list, &s->q_full.list);
                }
-               spin_unlock(&s->qlock);
-               return buf;
+
+               ret = buf;
+               break;
+       }
+       mutex_unlock(&s->qlock);
+
+       /* Put lost buffers back into firmware transfer rotation */
+       while (!list_empty(&r)) {
+               buf = list_entry(r.next, struct cx18_buffer, list);
+               list_del_init(r.next);
+               cx18_enqueue(s, buf, &s->q_free);
+               cx18_vapi(cx, CX18_CPU_DE_SET_MDL, 5, s->handle,
+                      (void __iomem *)&cx->scb->cpu_mdl[buf->id] - cx->enc_mem,
+                      1, buf->id, s->buf_size);
+               CX18_INFO("Returning %s, buffer %d back to transfer rotation\n",
+                         s->name, buf->id);
+               /* and there was much rejoicing... */
        }
-       spin_unlock(&s->qlock);
-       CX18_ERR("Cannot find buffer %d for stream %s\n", id, s->name);
-       return NULL;
+       return ret;
 }
 
 /* Move all buffers of a queue to q_free, while flushing the buffers */
 static void cx18_queue_flush(struct cx18_stream *s, struct cx18_queue *q)
 {
-       unsigned long flags;
        struct cx18_buffer *buf;
 
        if (q == &s->q_free)
                return;
 
-       spin_lock_irqsave(&s->qlock, flags);
+       mutex_lock(&s->qlock);
        while (!list_empty(&q->list)) {
                buf = list_entry(q->list.next, struct cx18_buffer, list);
                list_move_tail(q->list.next, &s->q_free.list);
-               buf->bytesused = buf->readpos = buf->b_flags = 0;
+               buf->bytesused = buf->readpos = buf->b_flags = buf->skipped = 0;
                atomic_inc(&s->q_free.buffers);
        }
        cx18_queue_init(q);
-       spin_unlock_irqrestore(&s->qlock, flags);
+       mutex_unlock(&s->qlock);
 }
 
 void cx18_flush_queues(struct cx18_stream *s)
 {
-       cx18_queue_flush(s, &s->q_io);
        cx18_queue_flush(s, &s->q_full);
 }