]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/media/video/gspca/gspca.c
V4L/DVB (8458): gspca_sonixb remove one more no longer needed special case from the...
[linux-2.6-omap-h63xx.git] / drivers / media / video / gspca / gspca.c
index 4fe082ff7074f729847158d32a5e131a29d09d19..0f09784631adb41ddb6a83fbf99bb73f9fc5548b 100644 (file)
 #include <linux/mm.h>
 #include <linux/string.h>
 #include <linux/pagemap.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <asm/page.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 #include <linux/jiffies.h>
+#include <media/v4l2-ioctl.h>
 
 #include "gspca.h"
 
+/* global values */
+#define DEF_NURBS 2            /* default number of URBs */
+
 MODULE_AUTHOR("Jean-Francois Moine <http://moinejf.free.fr>");
 MODULE_DESCRIPTION("GSPCA USB Camera Driver");
 MODULE_LICENSE("GPL");
 
-#define DRIVER_VERSION_NUMBER  KERNEL_VERSION(0, 0, 26)
-static const char version[] = "0.0.26";
+#define DRIVER_VERSION_NUMBER  KERNEL_VERSION(2, 2, 0)
 
 static int video_nr = -1;
 
-static int comp_fac = 30;      /* Buffer size ratio when compressed in % */
-
-#ifdef GSPCA_DEBUG
+#ifdef CONFIG_VIDEO_ADV_DEBUG
 int gspca_debug = D_ERR | D_PROBE;
 EXPORT_SYMBOL(gspca_debug);
 
@@ -71,6 +72,12 @@ static void PDEBUG_MODE(char *txt, __u32 pixfmt, int w, int h)
 #define PDEBUG_MODE(txt, pixfmt, w, h)
 #endif
 
+/* specific memory types - !! should different from V4L2_MEMORY_xxx */
+#define GSPCA_MEMORY_NO 0      /* V4L2_MEMORY_xxx starts from 1 */
+#define GSPCA_MEMORY_READ 7
+
+#define BUF_ALL_FLAGS (V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE)
+
 /*
  * VMA operations.
  */
@@ -96,22 +103,20 @@ static struct vm_operations_struct gspca_vm_ops = {
 };
 
 /*
- * ISOC message interrupt from the USB device
- *
- * Analyse each packet and call the subdriver for doing the copy
- * to the frame buffer.
+ * fill a video frame from an URB and resubmit
  */
-static void isoc_irq(struct urb *urb)
+static void fill_frame(struct gspca_dev *gspca_dev,
+                       struct urb *urb)
 {
-       struct gspca_dev *gspca_dev = (struct gspca_dev *) urb->context;
        struct gspca_frame *frame;
-       unsigned char *data;    /* address of data in the iso message */
+       __u8 *data;             /* address of data in the iso message */
        int i, j, len, st;
        cam_pkt_op pkt_scan;
 
-       PDEBUG(D_PACK, "isoc irq");
-       if (!gspca_dev->streaming)
-               return;
+       if (urb->status != 0) {
+               PDEBUG(D_ERR|D_PACK, "urb status: %d", urb->status);
+               return;         /* disconnection ? */
+       }
        pkt_scan = gspca_dev->sd_desc->pkt_scan;
        for (i = 0; i < urb->number_of_packets; i++) {
 
@@ -119,8 +124,7 @@ static void isoc_irq(struct urb *urb)
                j = gspca_dev->fr_i;
                j = gspca_dev->fr_queue[j];
                frame = &gspca_dev->frame[j];
-               if ((frame->v4l2_buf.flags
-                               & (V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE))
+               if ((frame->v4l2_buf.flags & BUF_ALL_FLAGS)
                                        != V4L2_BUF_FLAG_QUEUED) {
                        gspca_dev->last_packet_type = DISCARD_PACKET;
                        break;
@@ -128,20 +132,21 @@ static void isoc_irq(struct urb *urb)
 
                /* check the packet status and length */
                len = urb->iso_frame_desc[i].actual_length;
+               if (len == 0)
+                       continue;
                st = urb->iso_frame_desc[i].status;
                if (st) {
-                       PDEBUG(D_ERR, "ISOC data error: [%d] len=%d, status=%d",
+                       PDEBUG(D_ERR,
+                               "ISOC data error: [%d] len=%d, status=%d",
                                i, len, st);
                        gspca_dev->last_packet_type = DISCARD_PACKET;
                        continue;
                }
-               if (len == 0)
-                       continue;
 
                /* let the packet be analyzed by the subdriver */
                PDEBUG(D_PACK, "packet [%d] o:%d l:%d",
                        i, urb->iso_frame_desc[i].offset, len);
-               data = (unsigned char *) urb->transfer_buffer
+               data = (__u8 *) urb->transfer_buffer
                                        + urb->iso_frame_desc[i].offset;
                pkt_scan(gspca_dev, frame, data, len);
        }
@@ -153,10 +158,27 @@ static void isoc_irq(struct urb *urb)
                PDEBUG(D_ERR|D_PACK, "usb_submit_urb() ret %d", st);
 }
 
+/*
+ * ISOC message interrupt from the USB device
+ *
+ * Analyse each packet and call the subdriver for copy to the frame buffer.
+ */
+static void isoc_irq(struct urb *urb
+)
+{
+       struct gspca_dev *gspca_dev = (struct gspca_dev *) urb->context;
+
+       PDEBUG(D_PACK, "isoc irq");
+       if (!gspca_dev->streaming)
+               return;
+       fill_frame(gspca_dev, urb);
+}
+
 /*
  * add data to the current frame
  *
  * This function is called by the subdrivers at interrupt level.
+ *
  * To build a frame, these ones must add
  *     - one FIRST_PACKET
  *     - 0 or many INTER_PACKETs
@@ -167,20 +189,18 @@ static void isoc_irq(struct urb *urb)
 struct gspca_frame *gspca_frame_add(struct gspca_dev *gspca_dev,
                                    int packet_type,
                                    struct gspca_frame *frame,
-                                   unsigned char *data,
+                                   const __u8 *data,
                                    int len)
 {
        int i, j;
 
-       PDEBUG(D_PACK, "add t:%d l:%d %02x %02x %02x %02x...",
-               packet_type, len, data[0], data[1], data[2], data[3]);
+       PDEBUG(D_PACK, "add t:%d l:%d", packet_type, len);
 
        /* when start of a new frame, if the current frame buffer
         * is not queued, discard the whole frame */
        if (packet_type == FIRST_PACKET) {
-               if ((frame->v4l2_buf.flags
-                               & (V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE))
-                                       != V4L2_BUF_FLAG_QUEUED) {
+               if ((frame->v4l2_buf.flags & BUF_ALL_FLAGS)
+                                               != V4L2_BUF_FLAG_QUEUED) {
                        gspca_dev->last_packet_type = DISCARD_PACKET;
                        return frame;
                }
@@ -188,22 +208,22 @@ struct gspca_frame *gspca_frame_add(struct gspca_dev *gspca_dev,
                jiffies_to_timeval(get_jiffies_64(),
                                   &frame->v4l2_buf.timestamp);
                frame->v4l2_buf.sequence = ++gspca_dev->sequence;
-       } else if (gspca_dev->last_packet_type == DISCARD_PACKET)
+       } else if (gspca_dev->last_packet_type == DISCARD_PACKET) {
+               if (packet_type == LAST_PACKET)
+                       gspca_dev->last_packet_type = packet_type;
                return frame;
+       }
 
-       /* append the packet in the frame buffer */
+       /* append the packet to the frame buffer */
        if (len > 0) {
                if (frame->data_end - frame->data + len
                                                 > frame->v4l2_buf.length) {
-                       PDEBUG(D_ERR|D_PACK, "frame overflow %d > %d",
+                       PDEBUG(D_ERR|D_PACK, "frame overflow %zd > %d",
                                frame->data_end - frame->data + len,
                                frame->v4l2_buf.length);
                        packet_type = DISCARD_PACKET;
                } else {
-                       if (frame->v4l2_buf.memory != V4L2_MEMORY_USERPTR)
-                               memcpy(frame->data_end, data, len);
-                       else
-                               copy_to_user(frame->data_end, data, len);
+                       memcpy(frame->data_end, data, len);
                        frame->data_end += len;
                }
        }
@@ -216,8 +236,8 @@ struct gspca_frame *gspca_frame_add(struct gspca_dev *gspca_dev,
                frame->v4l2_buf.flags |= V4L2_BUF_FLAG_DONE;
                atomic_inc(&gspca_dev->nevent);
                wake_up_interruptible(&gspca_dev->wq);  /* event = new frame */
-               i = gspca_dev->fr_i;
-               i = (i + 1) % gspca_dev->nframes;
+               i = (gspca_dev->fr_i + 1) % gspca_dev->nframes;
+               gspca_dev->fr_i = i;
                PDEBUG(D_FRAM, "frame complete len:%d q:%d i:%d o:%d",
                        frame->v4l2_buf.bytesused,
                        gspca_dev->fr_q,
@@ -225,7 +245,6 @@ struct gspca_frame *gspca_frame_add(struct gspca_dev *gspca_dev,
                        gspca_dev->fr_o);
                j = gspca_dev->fr_queue[i];
                frame = &gspca_dev->frame[j];
-               gspca_dev->fr_i = i;
        }
        return frame;
 }
@@ -236,6 +255,8 @@ static int gspca_is_compressed(__u32 format)
        switch (format) {
        case V4L2_PIX_FMT_MJPEG:
        case V4L2_PIX_FMT_JPEG:
+       case V4L2_PIX_FMT_SPCA561:
+       case V4L2_PIX_FMT_PAC207:
                return 1;
        }
        return 0;
@@ -246,10 +267,9 @@ static void *rvmalloc(unsigned long size)
        void *mem;
        unsigned long adr;
 
-       size = PAGE_ALIGN(size);
+/*     size = PAGE_ALIGN(size);        (already done) */
        mem = vmalloc_32(size);
-       if (mem != 0) {
-               memset(mem, 0, size);
+       if (mem != NULL) {
                adr = (unsigned long) mem;
                while ((long) size > 0) {
                        SetPageReserved(vmalloc_to_page((void *) adr));
@@ -260,14 +280,12 @@ static void *rvmalloc(unsigned long size)
        return mem;
 }
 
-static void rvfree(void *mem, unsigned long size)
+static void rvfree(void *mem, long size)
 {
        unsigned long adr;
 
-       if (!mem)
-               return;
        adr = (unsigned long) mem;
-       while ((long) size > 0) {
+       while (size > 0) {
                ClearPageReserved(vmalloc_to_page((void *) adr));
                adr += PAGE_SIZE;
                size -= PAGE_SIZE;
@@ -276,53 +294,43 @@ static void rvfree(void *mem, unsigned long size)
 }
 
 static int frame_alloc(struct gspca_dev *gspca_dev,
-                       unsigned int count,
-                       unsigned int frsz,
-                       enum v4l2_memory memory)
+                       unsigned int count)
 {
-       int i, ret = 0;
+       struct gspca_frame *frame;
+       unsigned int frsz;
+       int i;
 
+       i = gspca_dev->curr_mode;
+       frsz = gspca_dev->cam.cam_mode[i].sizeimage;
        PDEBUG(D_STREAM, "frame alloc frsz: %d", frsz);
-       if (gspca_dev->nframes != 0) {
-               PDEBUG(D_ERR|D_STREAM, "alloc frame already done");
-               return -EBUSY;
-       }
-       if (count > GSPCA_MAX_FRAMES)
-               count = GSPCA_MAX_FRAMES;
-       /* if compressed, reduce the buffer size */
-       if (gspca_is_compressed(gspca_dev->pixfmt))
-               frsz = (frsz * comp_fac) / 100;
        frsz = PAGE_ALIGN(frsz);
-       PDEBUG(D_STREAM, "new fr_sz: %d", frsz);
        gspca_dev->frsz = frsz;
-       if (memory == V4L2_MEMORY_MMAP) {
-               gspca_dev->frbuf = rvmalloc(frsz * count);
-               if (!gspca_dev->frbuf) {
-                       err("frame alloc failed");
-                       return -ENOMEM;
-               }
+       if (count > GSPCA_MAX_FRAMES)
+               count = GSPCA_MAX_FRAMES;
+       gspca_dev->frbuf = rvmalloc(frsz * count);
+       if (!gspca_dev->frbuf) {
+               err("frame alloc failed");
+               return -ENOMEM;
        }
        gspca_dev->nframes = count;
        for (i = 0; i < count; i++) {
-               gspca_dev->frame[i].v4l2_buf.index = i;
-               gspca_dev->frame[i].v4l2_buf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               gspca_dev->frame[i].v4l2_buf.flags = 0;
-               gspca_dev->frame[i].v4l2_buf.field = V4L2_FIELD_NONE;
-               gspca_dev->frame[i].v4l2_buf.length = frsz;
-               gspca_dev->frame[i].v4l2_buf.memory = memory;
-               if (memory == V4L2_MEMORY_MMAP) {
-                       gspca_dev->frame[i].data
-                               = gspca_dev->frame[i].data_end
-                               = gspca_dev->frbuf + i * frsz;
-                       gspca_dev->frame[i].v4l2_buf.m.offset = i * frsz;
-               }
-               gspca_dev->frame[i].v4l2_buf.flags = 0; /* buf in app space */
+               frame = &gspca_dev->frame[i];
+               frame->v4l2_buf.index = i;
+               frame->v4l2_buf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+               frame->v4l2_buf.flags = 0;
+               frame->v4l2_buf.field = V4L2_FIELD_NONE;
+               frame->v4l2_buf.length = frsz;
+               frame->v4l2_buf.memory = gspca_dev->memory;
+               frame->v4l2_buf.sequence = 0;
+               frame->data = frame->data_end =
+                                       gspca_dev->frbuf + i * frsz;
+               frame->v4l2_buf.m.offset = i * frsz;
        }
        gspca_dev->fr_i = gspca_dev->fr_o = gspca_dev->fr_q = 0;
        gspca_dev->last_packet_type = DISCARD_PACKET;
        gspca_dev->sequence = 0;
        atomic_set(&gspca_dev->nevent, 0);
-       return ret;
+       return 0;
 }
 
 static void frame_free(struct gspca_dev *gspca_dev)
@@ -330,7 +338,7 @@ static void frame_free(struct gspca_dev *gspca_dev)
        int i;
 
        PDEBUG(D_STREAM, "frame free");
-       if (gspca_dev->frbuf != 0) {
+       if (gspca_dev->frbuf != NULL) {
                rvfree(gspca_dev->frbuf,
                        gspca_dev->nframes * gspca_dev->frsz);
                gspca_dev->frbuf = NULL;
@@ -340,33 +348,26 @@ static void frame_free(struct gspca_dev *gspca_dev)
        gspca_dev->nframes = 0;
 }
 
-static int gspca_kill_transfer(struct gspca_dev *gspca_dev)
+static void destroy_urbs(struct gspca_dev *gspca_dev)
 {
        struct urb *urb;
        unsigned int i;
 
        PDEBUG(D_STREAM, "kill transfer");
-       gspca_dev->streaming = 0;
-       for (i = 0; i < NURBS; ++i) {
-               urb = gspca_dev->pktbuf[i].urb;
+       for (i = 0; i < MAX_NURBS; ++i) {
+               urb = gspca_dev->urb[i];
                if (urb == NULL)
-                       continue;
+                       break;
 
-               gspca_dev->pktbuf[i].urb = NULL;
+               gspca_dev->urb[i] = NULL;
                usb_kill_urb(urb);
-
-               /* urb->transfer_buffer_length is not touched by USB core,
-                * so we can use it here as the buffer length */
-               if (gspca_dev->pktbuf[i].data) {
+               if (urb->transfer_buffer != NULL)
                        usb_buffer_free(gspca_dev->dev,
                                        urb->transfer_buffer_length,
-                                       gspca_dev->pktbuf[i].data,
+                                       urb->transfer_buffer,
                                        urb->transfer_dma);
-                       gspca_dev->pktbuf[i].data = NULL;
-               }
                usb_free_urb(urb);
        }
-       return 0;
 }
 
 /*
@@ -400,20 +401,21 @@ static struct usb_host_endpoint *alt_isoc(struct usb_host_interface *alt,
  * This routine may be called many times when the bandwidth is too small
  * (the bandwidth is checked on urb submit).
  */
-struct usb_host_endpoint *get_isoc_ep(struct gspca_dev *gspca_dev)
+static struct usb_host_endpoint *get_isoc_ep(struct gspca_dev *gspca_dev)
 {
        struct usb_interface *intf;
        struct usb_host_endpoint *ep;
        int i, ret;
 
        intf = usb_ifnum_to_if(gspca_dev->dev, gspca_dev->iface);
+       ep = NULL;
        i = gspca_dev->alt;                     /* previous alt setting */
        while (--i > 0) {                       /* alt 0 is unusable */
                ep = alt_isoc(&intf->altsetting[i], gspca_dev->cam.epaddr);
                if (ep)
                        break;
        }
-       if (i <= 0) {
+       if (ep == NULL) {
                err("no ISOC endpoint found");
                return NULL;
        }
@@ -424,7 +426,7 @@ struct usb_host_endpoint *get_isoc_ep(struct gspca_dev *gspca_dev)
                err("set interface err %d", ret);
                return NULL;
        }
-       gspca_dev->alt = i;
+       gspca_dev->alt = i;             /* memorize the current alt setting */
        return ep;
 }
 
@@ -435,52 +437,46 @@ static int create_urbs(struct gspca_dev *gspca_dev,
                        struct usb_host_endpoint *ep)
 {
        struct urb *urb;
-       int n, i, psize, npkt, bsize;
+       int n, nurbs, i, psize, npkt, bsize;
 
        /* calculate the packet size and the number of packets */
-       /* the URB buffer size must be a power of 2 */
        psize = le16_to_cpu(ep->desc.wMaxPacketSize);
+
        /* See paragraph 5.9 / table 5-11 of the usb 2.0 spec. */
        psize = (psize & 0x07ff) * (1 + ((psize >> 11) & 3));
        npkt = ISO_MAX_SIZE / psize;
        if (npkt > ISO_MAX_PKT)
                npkt = ISO_MAX_PKT;
        bsize = psize * npkt;
-       for (n = ISO_MAX_SIZE; n > 0; n >>= 1) {
-               if (n & bsize)  /* !! assume ISO_MAX_SIZE is a power of 2 */
-                       break;
-       }
-       if (n != 0) {
-               npkt = n / psize;
-               bsize = psize * npkt;
-       }
        PDEBUG(D_STREAM,
                "isoc %d pkts size %d (bsize:%d)", npkt, psize, bsize);
-       for (n = 0; n < NURBS; n++) {
+       nurbs = DEF_NURBS;
+       gspca_dev->nurbs = nurbs;
+       for (n = 0; n < nurbs; n++) {
                urb = usb_alloc_urb(npkt, GFP_KERNEL);
                if (!urb) {
                        err("usb_alloc_urb failed");
                        return -ENOMEM;
                }
-               gspca_dev->pktbuf[n].data = usb_buffer_alloc(gspca_dev->dev,
+               urb->transfer_buffer = usb_buffer_alloc(gspca_dev->dev,
                                                bsize,
                                                GFP_KERNEL,
                                                &urb->transfer_dma);
 
-               if (gspca_dev->pktbuf[n].data == NULL) {
+               if (urb->transfer_buffer == NULL) {
                        usb_free_urb(urb);
-                       gspca_kill_transfer(gspca_dev);
+                       destroy_urbs(gspca_dev);
                        err("usb_buffer_urb failed");
                        return -ENOMEM;
                }
-               gspca_dev->pktbuf[n].urb = urb;
+               gspca_dev->urb[n] = urb;
                urb->dev = gspca_dev->dev;
                urb->context = gspca_dev;
                urb->pipe = usb_rcvisocpipe(gspca_dev->dev,
                                            ep->desc.bEndpointAddress);
-               urb->transfer_flags = URB_ISO_ASAP | URB_NO_TRANSFER_DMA_MAP;
+               urb->transfer_flags = URB_ISO_ASAP
+                                       | URB_NO_TRANSFER_DMA_MAP;
                urb->interval = ep->desc.bInterval;
-               urb->transfer_buffer = gspca_dev->pktbuf[n].data;
                urb->complete = isoc_irq;
                urb->number_of_packets = npkt;
                urb->transfer_buffer_length = bsize;
@@ -497,19 +493,17 @@ static int create_urbs(struct gspca_dev *gspca_dev,
  */
 static int gspca_init_transfer(struct gspca_dev *gspca_dev)
 {
-       struct usb_interface *intf;
        struct usb_host_endpoint *ep;
        int n, ret;
 
-       ret = mutex_lock_interruptible(&gspca_dev->usb_lock);
-       if (ret < 0)
-               return ret;
+       if (mutex_lock_interruptible(&gspca_dev->usb_lock))
+               return -ERESTARTSYS;
 
-       /* set the max alternate setting and loop until urb submit succeeds */
-       intf = usb_ifnum_to_if(gspca_dev->dev, gspca_dev->iface);
-       gspca_dev->alt = intf->num_altsetting;
+       /* set the higher alternate setting and
+        * loop until urb submit succeeds */
+       gspca_dev->alt = gspca_dev->nbalt;
        for (;;) {
-               PDEBUG(D_STREAM, "init transfer nbalt %d", gspca_dev->alt);
+               PDEBUG(D_STREAM, "init transfer alt %d", gspca_dev->alt);
                ep = get_isoc_ep(gspca_dev);
                if (ep == NULL) {
                        ret = -EIO;
@@ -525,13 +519,13 @@ static int gspca_init_transfer(struct gspca_dev *gspca_dev)
                atomic_set(&gspca_dev->nevent, 0);
 
                /* submit the URBs */
-               for (n = 0; n < NURBS; n++) {
-                       ret = usb_submit_urb(gspca_dev->pktbuf[n].urb,
-                                                GFP_KERNEL);
+               for (n = 0; n < gspca_dev->nurbs; n++) {
+                       ret = usb_submit_urb(gspca_dev->urb[n], GFP_KERNEL);
                        if (ret < 0) {
                                PDEBUG(D_ERR|D_STREAM,
                                        "usb_submit_urb [%d] err %d", n, ret);
-                               gspca_kill_transfer(gspca_dev);
+                               gspca_dev->streaming = 0;
+                               destroy_urbs(gspca_dev);
                                if (ret == -ENOSPC)
                                        break;  /* try the previous alt */
                                goto out;
@@ -555,26 +549,21 @@ static int gspca_set_alt0(struct gspca_dev *gspca_dev)
        return ret;
 }
 
+/* Note both the queue and the usb lock should be hold when calling this */
 static void gspca_stream_off(struct gspca_dev *gspca_dev)
 {
-       mutex_lock_interruptible(&gspca_dev->usb_lock);
        gspca_dev->streaming = 0;
+       atomic_set(&gspca_dev->nevent, 0);
        if (gspca_dev->present) {
                gspca_dev->sd_desc->stopN(gspca_dev);
-               gspca_kill_transfer(gspca_dev);
+               destroy_urbs(gspca_dev);
                gspca_set_alt0(gspca_dev);
                gspca_dev->sd_desc->stop0(gspca_dev);
                PDEBUG(D_STREAM, "stream off OK");
-       } else {
-               gspca_kill_transfer(gspca_dev);
-               atomic_inc(&gspca_dev->nevent);
-               wake_up_interruptible(&gspca_dev->wq);
-               PDEBUG(D_ERR|D_STREAM, "stream off no device ??");
        }
-       mutex_unlock(&gspca_dev->usb_lock);
 }
 
-static int gspca_set_default_mode(struct gspca_dev *gspca_dev)
+static void gspca_set_default_mode(struct gspca_dev *gspca_dev)
 {
        int i;
 
@@ -582,8 +571,7 @@ static int gspca_set_default_mode(struct gspca_dev *gspca_dev)
        gspca_dev->curr_mode = i;
        gspca_dev->width = gspca_dev->cam.cam_mode[i].width;
        gspca_dev->height = gspca_dev->cam.cam_mode[i].height;
-       gspca_dev->pixfmt = gspca_dev->cam.cam_mode[i].pixfmt;
-       return 0;
+       gspca_dev->pixfmt = gspca_dev->cam.cam_mode[i].pixelformat;
 }
 
 static int wxh_to_mode(struct gspca_dev *gspca_dev,
@@ -591,46 +579,14 @@ static int wxh_to_mode(struct gspca_dev *gspca_dev,
 {
        int i;
 
-       for (i = gspca_dev->cam.nmodes - 1; --i >= 0; ) {
-               if (width > gspca_dev->cam.cam_mode[i].width)
+       for (i = gspca_dev->cam.nmodes; --i > 0; ) {
+               if (width >= gspca_dev->cam.cam_mode[i].width
+                   && height >= gspca_dev->cam.cam_mode[i].height)
                        break;
        }
-       i++;
-       while (i < gspca_dev->cam.nmodes - 1
-              && width == gspca_dev->cam.cam_mode[i + 1].width
-              && height < gspca_dev->cam.cam_mode[i + 1].height)
-               i++;
        return i;
 }
 
-static __u32 get_v4l2_depth(__u32 pixfmt)
-{
-       switch (pixfmt) {
-       case V4L2_PIX_FMT_BGR32:
-       case V4L2_PIX_FMT_RGB32:
-               return 32;
-       case V4L2_PIX_FMT_RGB24:
-       case V4L2_PIX_FMT_BGR24:
-               return 24;
-       case V4L2_PIX_FMT_RGB565:
-       case V4L2_PIX_FMT_YUYV:         /* packed 4.2.2 */
-       case V4L2_PIX_FMT_YYUV:
-               return 16;
-       case V4L2_PIX_FMT_YUV420:       /* planar 4.2.0 */
-               return 12;
-       case V4L2_PIX_FMT_MJPEG:
-       case V4L2_PIX_FMT_JPEG:
-       case V4L2_PIX_FMT_SBGGR8:       /* Bayer */
-               return 8;
-       }
-       PDEBUG(D_ERR|D_CONF, "Unknown pixel format %c%c%c%c",
-               pixfmt & 0xff,
-               (pixfmt >> 8) & 0xff,
-               (pixfmt >> 16) & 0xff,
-               pixfmt >> 24);
-       return -EINVAL;
-}
-
 /*
  * search a mode with the right pixel format
  */
@@ -643,31 +599,31 @@ static int gspca_get_mode(struct gspca_dev *gspca_dev,
        modeU = modeD = mode;
        while ((modeU < gspca_dev->cam.nmodes) || modeD >= 0) {
                if (--modeD >= 0) {
-                       if (gspca_dev->cam.cam_mode[modeD].pixfmt == pixfmt)
+                       if (gspca_dev->cam.cam_mode[modeD].pixelformat
+                                                               == pixfmt)
                                return modeD;
                }
                if (++modeU < gspca_dev->cam.nmodes) {
-                       if (gspca_dev->cam.cam_mode[modeU].pixfmt == pixfmt)
+                       if (gspca_dev->cam.cam_mode[modeU].pixelformat
+                                                               == pixfmt)
                                return modeU;
                }
        }
        return -EINVAL;
 }
 
-static int vidioc_enum_fmt_cap(struct file *file, void  *priv,
+static int vidioc_enum_fmt_vid_cap(struct file *file, void  *priv,
                                struct v4l2_fmtdesc *fmtdesc)
 {
        struct gspca_dev *gspca_dev = priv;
        int i, j, index;
        __u32 fmt_tb[8];
 
-       PDEBUG(D_CONF, "enum fmt cap");
-
        /* give an index to each format */
        index = 0;
        j = 0;
        for (i = gspca_dev->cam.nmodes; --i >= 0; ) {
-               fmt_tb[index] = gspca_dev->cam.cam_mode[i].pixfmt;
+               fmt_tb[index] = gspca_dev->cam.cam_mode[i].pixelformat;
                j = 0;
                for (;;) {
                        if (fmt_tb[j] == fmt_tb[index])
@@ -685,10 +641,10 @@ static int vidioc_enum_fmt_cap(struct file *file, void  *priv,
        if (i < 0)
                return -EINVAL;         /* no more format */
 
-       fmtdesc->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
        fmtdesc->pixelformat = fmt_tb[index];
        if (gspca_is_compressed(fmt_tb[index]))
                fmtdesc->flags = V4L2_FMT_FLAG_COMPRESSED;
+       fmtdesc->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
        fmtdesc->description[0] = fmtdesc->pixelformat & 0xff;
        fmtdesc->description[1] = (fmtdesc->pixelformat >> 8) & 0xff;
        fmtdesc->description[2] = (fmtdesc->pixelformat >> 16) & 0xff;
@@ -697,54 +653,31 @@ static int vidioc_enum_fmt_cap(struct file *file, void  *priv,
        return 0;
 }
 
-static int gspca_get_buff_size(struct gspca_dev *gspca_dev)
-{
-       unsigned int size;
-
-       size = gspca_dev->width * gspca_dev->height
-                               * get_v4l2_depth(gspca_dev->pixfmt) / 8;
-       if (!size)
-               return -ENOMEM;
-       return size;
-}
-
-static int vidioc_g_fmt_cap(struct file *file, void *priv,
+static int vidioc_g_fmt_vid_cap(struct file *file, void *priv,
                            struct v4l2_format *fmt)
 {
        struct gspca_dev *gspca_dev = priv;
+       int mode;
 
-       fmt->fmt.pix.width = gspca_dev->width;
-       fmt->fmt.pix.height = gspca_dev->height;
-       fmt->fmt.pix.pixelformat = gspca_dev->pixfmt;
-#ifdef GSPCA_DEBUG
-       if (gspca_debug & D_CONF) {
-               PDEBUG_MODE("get fmt cap",
-                       fmt->fmt.pix.pixelformat,
-                       fmt->fmt.pix.width,
-                       fmt->fmt.pix.height);
-       }
-#endif
-       fmt->fmt.pix.field = V4L2_FIELD_NONE;
-       fmt->fmt.pix.bytesperline = get_v4l2_depth(fmt->fmt.pix.pixelformat)
-                                       * fmt->fmt.pix.width / 8;
-       fmt->fmt.pix.sizeimage = fmt->fmt.pix.bytesperline
-                                       * fmt->fmt.pix.height;
-/* (should be in the subdriver) */
-       fmt->fmt.pix.colorspace = V4L2_COLORSPACE_SRGB;
-       fmt->fmt.pix.priv = 0;
+       if (fmt->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               return -EINVAL;
+       mode = gspca_dev->curr_mode;
+       memcpy(&fmt->fmt.pix, &gspca_dev->cam.cam_mode[mode],
+               sizeof fmt->fmt.pix);
        return 0;
 }
 
-static int try_fmt_cap(struct file *file,
-                       void *priv,
+static int try_fmt_vid_cap(struct gspca_dev *gspca_dev,
                        struct v4l2_format *fmt)
 {
-       struct gspca_dev *gspca_dev = priv;
-       int w, h, mode, mode2, frsz;
+       int w, h, mode, mode2;
+
+       if (fmt->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               return -EINVAL;
+       w = fmt->fmt.pix.width;
+       h = fmt->fmt.pix.height;
 
-       w = (int) fmt->fmt.pix.width;
-       h = (int) fmt->fmt.pix.height;
-#ifdef GSPCA_DEBUG
+#ifdef CONFIG_VIDEO_ADV_DEBUG
        if (gspca_debug & D_CONF)
                PDEBUG_MODE("try fmt cap", fmt->fmt.pix.pixelformat, w, h);
 #endif
@@ -752,82 +685,69 @@ static int try_fmt_cap(struct file *file,
        mode = wxh_to_mode(gspca_dev, w, h);
 
        /* OK if right palette */
-       if (gspca_dev->cam.cam_mode[mode].pixfmt != fmt->fmt.pix.pixelformat) {
+       if (gspca_dev->cam.cam_mode[mode].pixelformat
+                                               != fmt->fmt.pix.pixelformat) {
 
                /* else, search the closest mode with the same pixel format */
                mode2 = gspca_get_mode(gspca_dev, mode,
                                        fmt->fmt.pix.pixelformat);
                if (mode2 >= 0)
                        mode = mode2;
-               else {
-
-                       /* no chance, return this mode */
-                       fmt->fmt.pix.pixelformat
-                               = gspca_dev->cam.cam_mode[mode].pixfmt;
-#ifdef GSPCA_DEBUG
-                       if (gspca_debug & D_CONF) {
-                               PDEBUG_MODE("new format",
-                                       fmt->fmt.pix.pixelformat,
-                                       gspca_dev->cam.cam_mode[mode].width,
-                                       gspca_dev->cam.cam_mode[mode].height);
-                       }
-#endif
-               }
+/*             else
+                       ;                * no chance, return this mode */
        }
-       fmt->fmt.pix.width = gspca_dev->cam.cam_mode[mode].width;
-       fmt->fmt.pix.height = gspca_dev->cam.cam_mode[mode].height;
-       fmt->fmt.pix.bytesperline = get_v4l2_depth(fmt->fmt.pix.pixelformat)
-                                       * fmt->fmt.pix.width / 8;
-       frsz = fmt->fmt.pix.bytesperline * fmt->fmt.pix.height;
-       if (gspca_is_compressed(fmt->fmt.pix.pixelformat))
-               frsz = (frsz * comp_fac) / 100;
-       fmt->fmt.pix.sizeimage = frsz;
+       memcpy(&fmt->fmt.pix, &gspca_dev->cam.cam_mode[mode],
+               sizeof fmt->fmt.pix);
        return mode;                    /* used when s_fmt */
 }
 
-static int vidioc_try_fmt_cap(struct file *file,
+static int vidioc_try_fmt_vid_cap(struct file *file,
                              void *priv,
                              struct v4l2_format *fmt)
 {
+       struct gspca_dev *gspca_dev = priv;
        int ret;
 
-/*     mutex_lock_interruptible(&gspca_dev->queue_lock); */
-       ret = try_fmt_cap(file, priv, fmt);
-/*     mutex_unlock(&gspca_dev->queue_lock); */
+       ret = try_fmt_vid_cap(gspca_dev, fmt);
        if (ret < 0)
                return ret;
        return 0;
 }
 
-static int vidioc_s_fmt_cap(struct file *file, void *priv,
+static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
                            struct v4l2_format *fmt)
 {
        struct gspca_dev *gspca_dev = priv;
-       int ret, was_streaming;
+       int ret;
 
-#ifdef GSPCA_DEBUG
-       if (gspca_debug & D_CONF) {
-               PDEBUG_MODE("set fmt cap",
-                       fmt->fmt.pix.pixelformat,
-                       fmt->fmt.pix.width, fmt->fmt.pix.height);
-       }
-#endif
-       mutex_lock_interruptible(&gspca_dev->queue_lock);
-       ret = try_fmt_cap(file, priv, fmt);
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
+
+       ret = try_fmt_vid_cap(gspca_dev, fmt);
        if (ret < 0)
                goto out;
 
-       if (ret == gspca_dev->curr_mode)
+       if (gspca_dev->nframes != 0
+           && fmt->fmt.pix.sizeimage > gspca_dev->frsz) {
+               ret = -EINVAL;
+               goto out;
+       }
+
+       if (ret == gspca_dev->curr_mode) {
+               ret = 0;
                goto out;                       /* same mode */
-       was_streaming = gspca_dev->streaming;
-       if (was_streaming != 0)
-               gspca_stream_off(gspca_dev);
-       gspca_dev->width = (int) fmt->fmt.pix.width;
-       gspca_dev->height = (int) fmt->fmt.pix.height;
+       }
+
+       if (gspca_dev->streaming) {
+               ret = -EBUSY;
+               goto out;
+       }
+       gspca_dev->width = fmt->fmt.pix.width;
+       gspca_dev->height = fmt->fmt.pix.height;
        gspca_dev->pixfmt = fmt->fmt.pix.pixelformat;
        gspca_dev->curr_mode = ret;
-       if (was_streaming)
-               ret = gspca_init_transfer(gspca_dev);
+
+       ret = 0;
 out:
        mutex_unlock(&gspca_dev->queue_lock);
        return ret;
@@ -838,11 +758,10 @@ static int dev_open(struct inode *inode, struct file *file)
        struct gspca_dev *gspca_dev;
        int ret;
 
-       PDEBUG(D_STREAM, "opening");
+       PDEBUG(D_STREAM, "%s open", current->comm);
        gspca_dev = (struct gspca_dev *) video_devdata(file);
-       ret = mutex_lock_interruptible(&gspca_dev->queue_lock);
-       if (ret < 0)
-               return ret;
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
        if (!gspca_dev->present) {
                ret = -ENODEV;
                goto out;
@@ -850,24 +769,25 @@ static int dev_open(struct inode *inode, struct file *file)
 
        /* if not done yet, initialize the sensor */
        if (gspca_dev->users == 0) {
-               ret = mutex_lock_interruptible(&gspca_dev->usb_lock);
-               if (ret < 0)
+               if (mutex_lock_interruptible(&gspca_dev->usb_lock)) {
+                       ret = -ERESTARTSYS;
                        goto out;
+               }
                ret = gspca_dev->sd_desc->open(gspca_dev);
                mutex_unlock(&gspca_dev->usb_lock);
                if (ret != 0) {
                        PDEBUG(D_ERR|D_CONF, "init device failed %d", ret);
                        goto out;
                }
-       } else if (gspca_dev->users > 8) {      /* (arbitrary value) */
+       } else if (gspca_dev->users > 4) {      /* (arbitrary value) */
                ret = -EBUSY;
                goto out;
        }
        gspca_dev->users++;
        file->private_data = gspca_dev;
-#ifdef GSPCA_DEBUG
+#ifdef CONFIG_VIDEO_ADV_DEBUG
        /* activate the v4l2 debug */
-       if (gspca_debug & D_CONF)
+       if (gspca_debug & D_V4L2)
                gspca_dev->vdev.debug |= 3;
        else
                gspca_dev->vdev.debug &= ~3;
@@ -877,7 +797,7 @@ out:
        if (ret != 0)
                PDEBUG(D_ERR|D_STREAM, "open failed err %d", ret);
        else
-               PDEBUG(D_STREAM, "open OK");
+               PDEBUG(D_STREAM, "open done");
        return ret;
 }
 
@@ -885,24 +805,25 @@ static int dev_close(struct inode *inode, struct file *file)
 {
        struct gspca_dev *gspca_dev = file->private_data;
 
-       PDEBUG(D_STREAM, "closing");
-       if (gspca_dev->streaming) {
-               mutex_lock_interruptible(&gspca_dev->queue_lock);
-               gspca_stream_off(gspca_dev);
-               mutex_unlock(&gspca_dev->queue_lock);
+       PDEBUG(D_STREAM, "%s close", current->comm);
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
+       gspca_dev->users--;
+
+       /* if the file did the capture, free the streaming resources */
+       if (gspca_dev->capt_file == file) {
+               mutex_lock(&gspca_dev->usb_lock);
+               if (gspca_dev->streaming)
+                       gspca_stream_off(gspca_dev);
+               gspca_dev->sd_desc->close(gspca_dev);
+               mutex_unlock(&gspca_dev->usb_lock);
+               frame_free(gspca_dev);
+               gspca_dev->capt_file = NULL;
+               gspca_dev->memory = GSPCA_MEMORY_NO;
        }
-       mutex_lock_interruptible(&gspca_dev->usb_lock);
-       gspca_dev->sd_desc->close(gspca_dev);
-       mutex_unlock(&gspca_dev->usb_lock);
-       atomic_inc(&gspca_dev->nevent);
-       wake_up_interruptible(&gspca_dev->wq);  /* wake blocked processes */
-       schedule();
-       mutex_lock_interruptible(&gspca_dev->queue_lock);
-       frame_free(gspca_dev);
        file->private_data = NULL;
-       gspca_dev->users--;
        mutex_unlock(&gspca_dev->queue_lock);
-       PDEBUG(D_STREAM, "closed");
+       PDEBUG(D_STREAM, "close done");
        return 0;
 }
 
@@ -911,7 +832,6 @@ static int vidioc_querycap(struct file *file, void  *priv,
 {
        struct gspca_dev *gspca_dev = priv;
 
-       PDEBUG(D_CONF, "querycap");
        memset(cap, 0, sizeof *cap);
        strncpy(cap->driver, gspca_dev->sd_desc->name, sizeof cap->driver);
        strncpy(cap->card, gspca_dev->cam.dev_name, sizeof cap->card);
@@ -924,23 +844,38 @@ static int vidioc_querycap(struct file *file, void  *priv,
        return 0;
 }
 
+/* the use of V4L2_CTRL_FLAG_NEXT_CTRL asks for the controls to be sorted */
 static int vidioc_queryctrl(struct file *file, void *priv,
                           struct v4l2_queryctrl *q_ctrl)
 {
        struct gspca_dev *gspca_dev = priv;
        int i;
-
-       PDEBUG(D_CONF, "queryctrl");
+       u32 id;
+
+       id = q_ctrl->id;
+       if (id & V4L2_CTRL_FLAG_NEXT_CTRL) {
+               id &= V4L2_CTRL_ID_MASK;
+               id++;
+               for (i = 0; i < gspca_dev->sd_desc->nctrls; i++) {
+                       if (id >= gspca_dev->sd_desc->ctrls[i].qctrl.id) {
+                               memcpy(q_ctrl,
+                                       &gspca_dev->sd_desc->ctrls[i].qctrl,
+                                       sizeof *q_ctrl);
+                               return 0;
+                       }
+               }
+               return -EINVAL;
+       }
        for (i = 0; i < gspca_dev->sd_desc->nctrls; i++) {
-               if (q_ctrl->id == gspca_dev->sd_desc->ctrls[i].qctrl.id) {
+               if (id == gspca_dev->sd_desc->ctrls[i].qctrl.id) {
                        memcpy(q_ctrl,
                                &gspca_dev->sd_desc->ctrls[i].qctrl,
                                sizeof *q_ctrl);
                        return 0;
                }
        }
-       if (q_ctrl->id >= V4L2_CID_BASE
-           && q_ctrl->id <= V4L2_CID_LASTP1) {
+       if (id >= V4L2_CID_BASE
+           && id <= V4L2_CID_LASTP1) {
                q_ctrl->flags |= V4L2_CTRL_FLAG_DISABLED;
                return 0;
        }
@@ -951,10 +886,9 @@ static int vidioc_s_ctrl(struct file *file, void *priv,
                         struct v4l2_control *ctrl)
 {
        struct gspca_dev *gspca_dev = priv;
-       struct ctrl *ctrls;
+       const struct ctrl *ctrls;
        int i, ret;
 
-       PDEBUG(D_CONF, "set ctrl");
        for (i = 0, ctrls = gspca_dev->sd_desc->ctrls;
             i < gspca_dev->sd_desc->nctrls;
             i++, ctrls++) {
@@ -964,7 +898,8 @@ static int vidioc_s_ctrl(struct file *file, void *priv,
                    && ctrl->value > ctrls->qctrl.maximum)
                        return -ERANGE;
                PDEBUG(D_CONF, "set ctrl [%08x] = %d", ctrl->id, ctrl->value);
-               mutex_lock_interruptible(&gspca_dev->usb_lock);
+               if (mutex_lock_interruptible(&gspca_dev->usb_lock))
+                       return -ERESTARTSYS;
                ret = ctrls->set(gspca_dev, ctrl->value);
                mutex_unlock(&gspca_dev->usb_lock);
                return ret;
@@ -977,7 +912,7 @@ static int vidioc_g_ctrl(struct file *file, void *priv,
 {
        struct gspca_dev *gspca_dev = priv;
 
-       struct ctrl *ctrls;
+       const struct ctrl *ctrls;
        int i, ret;
 
        for (i = 0, ctrls = gspca_dev->sd_desc->ctrls;
@@ -985,7 +920,8 @@ static int vidioc_g_ctrl(struct file *file, void *priv,
             i++, ctrls++) {
                if (ctrl->id != ctrls->qctrl.id)
                        continue;
-               mutex_lock_interruptible(&gspca_dev->usb_lock);
+               if (mutex_lock_interruptible(&gspca_dev->usb_lock))
+                       return -ERESTARTSYS;
                ret = ctrls->get(gspca_dev, &ctrl->value);
                mutex_unlock(&gspca_dev->usb_lock);
                return ret;
@@ -1034,28 +970,63 @@ static int vidioc_reqbufs(struct file *file, void *priv,
                          struct v4l2_requestbuffers *rb)
 {
        struct gspca_dev *gspca_dev = priv;
-       int frsz, ret;
+       int i, ret = 0;
 
-       PDEBUG(D_STREAM, "reqbufs %d", rb->count);
        if (rb->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
-       if (rb->memory != V4L2_MEMORY_MMAP
-           && rb->memory != V4L2_MEMORY_USERPTR)
+       switch (rb->memory) {
+       case GSPCA_MEMORY_READ:                 /* (internal call) */
+       case V4L2_MEMORY_MMAP:
+       case V4L2_MEMORY_USERPTR:
+               break;
+       default:
                return -EINVAL;
-       if (rb->count == 0)
-               return -EINVAL;
-       frsz = gspca_get_buff_size(gspca_dev);
-       if (frsz < 0)
-               return frsz;
-       ret = mutex_lock_interruptible(&gspca_dev->queue_lock);
-       if (ret < 0)
-               return ret;
-       ret = frame_alloc(gspca_dev,
-                               rb->count,
-                               (unsigned int) frsz,
-                               rb->memory);
-       if (ret == 0)
+       }
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
+
+       if (gspca_dev->memory != GSPCA_MEMORY_NO
+           && gspca_dev->memory != rb->memory) {
+               ret = -EBUSY;
+               goto out;
+       }
+
+       /* only one file may do the capture */
+       if (gspca_dev->capt_file != NULL
+           && gspca_dev->capt_file != file) {
+               ret = -EBUSY;
+               goto out;
+       }
+
+       /* if allocated, the buffers must not be mapped */
+       for (i = 0; i < gspca_dev->nframes; i++) {
+               if (gspca_dev->frame[i].vma_use_count) {
+                       ret = -EBUSY;
+                       goto out;
+               }
+       }
+
+       /* stop streaming */
+       if (gspca_dev->streaming) {
+               mutex_lock(&gspca_dev->usb_lock);
+               gspca_stream_off(gspca_dev);
+               mutex_unlock(&gspca_dev->usb_lock);
+       }
+
+       /* free the previous allocated buffers, if any */
+       if (gspca_dev->nframes != 0) {
+               frame_free(gspca_dev);
+               gspca_dev->capt_file = NULL;
+       }
+       if (rb->count == 0)                     /* unrequest */
+               goto out;
+       gspca_dev->memory = rb->memory;
+       ret = frame_alloc(gspca_dev, rb->count);
+       if (ret == 0) {
                rb->count = gspca_dev->nframes;
+               gspca_dev->capt_file = file;
+       }
+out:
        mutex_unlock(&gspca_dev->queue_lock);
        PDEBUG(D_STREAM, "reqbufs st:%d c:%d", ret, rb->count);
        return ret;
@@ -1067,7 +1038,6 @@ static int vidioc_querybuf(struct file *file, void *priv,
        struct gspca_dev *gspca_dev = priv;
        struct gspca_frame *frame;
 
-       PDEBUG(D_STREAM, "querybuf");
        if (v4l2_buf->type != V4L2_BUF_TYPE_VIDEO_CAPTURE
            || v4l2_buf->index < 0
            || v4l2_buf->index >= gspca_dev->nframes)
@@ -1084,12 +1054,10 @@ static int vidioc_streamon(struct file *file, void *priv,
        struct gspca_dev *gspca_dev = priv;
        int ret;
 
-       PDEBUG(D_STREAM, "stream on");
        if (buf_type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
-       ret = mutex_lock_interruptible(&gspca_dev->queue_lock);
-       if (ret < 0)
-               return ret;
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
        if (!gspca_dev->present) {
                ret = -ENODEV;
                goto out;
@@ -1103,7 +1071,7 @@ static int vidioc_streamon(struct file *file, void *priv,
                if (ret < 0)
                        goto out;
        }
-#ifdef GSPCA_DEBUG
+#ifdef CONFIG_VIDEO_ADV_DEBUG
        if (gspca_debug & D_STREAM) {
                PDEBUG_MODE("stream on OK",
                        gspca_dev->pixfmt,
@@ -1111,6 +1079,7 @@ static int vidioc_streamon(struct file *file, void *priv,
                        gspca_dev->height);
        }
 #endif
+       ret = 0;
 out:
        mutex_unlock(&gspca_dev->queue_lock);
        return ret;
@@ -1120,16 +1089,34 @@ static int vidioc_streamoff(struct file *file, void *priv,
                                enum v4l2_buf_type buf_type)
 {
        struct gspca_dev *gspca_dev = priv;
+       int i, ret;
 
-       PDEBUG(D_STREAM, "stream off");
        if (buf_type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
-       if (gspca_dev->streaming) {
-               mutex_lock_interruptible(&gspca_dev->queue_lock);
-               gspca_stream_off(gspca_dev);
-               mutex_unlock(&gspca_dev->queue_lock);
+       if (!gspca_dev->streaming)
+               return 0;
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
+
+       /* stop streaming */
+       if (mutex_lock_interruptible(&gspca_dev->usb_lock)) {
+               ret = -ERESTARTSYS;
+               goto out;
        }
-       return 0;
+       gspca_stream_off(gspca_dev);
+       mutex_unlock(&gspca_dev->usb_lock);
+
+       /* empty the application queues */
+       for (i = 0; i < gspca_dev->nframes; i++)
+               gspca_dev->frame[i].v4l2_buf.flags &= ~BUF_ALL_FLAGS;
+       gspca_dev->fr_i = gspca_dev->fr_o = gspca_dev->fr_q = 0;
+       gspca_dev->last_packet_type = DISCARD_PACKET;
+       gspca_dev->sequence = 0;
+       atomic_set(&gspca_dev->nevent, 0);
+       ret = 0;
+out:
+       mutex_unlock(&gspca_dev->queue_lock);
+       return ret;
 }
 
 static int vidioc_g_jpegcomp(struct file *file, void *priv,
@@ -1140,7 +1127,8 @@ static int vidioc_g_jpegcomp(struct file *file, void *priv,
 
        if (!gspca_dev->sd_desc->get_jcomp)
                return -EINVAL;
-       mutex_lock_interruptible(&gspca_dev->usb_lock);
+       if (mutex_lock_interruptible(&gspca_dev->usb_lock))
+               return -ERESTARTSYS;
        ret = gspca_dev->sd_desc->get_jcomp(gspca_dev, jpegcomp);
        mutex_unlock(&gspca_dev->usb_lock);
        return ret;
@@ -1152,7 +1140,8 @@ static int vidioc_s_jpegcomp(struct file *file, void *priv,
        struct gspca_dev *gspca_dev = priv;
        int ret;
 
-       mutex_lock_interruptible(&gspca_dev->usb_lock);
+       if (mutex_lock_interruptible(&gspca_dev->usb_lock))
+               return -ERESTARTSYS;
        if (!gspca_dev->sd_desc->set_jcomp)
                return -EINVAL;
        ret = gspca_dev->sd_desc->set_jcomp(gspca_dev, jpegcomp);
@@ -1165,7 +1154,7 @@ static int vidioc_g_parm(struct file *filp, void *priv,
 {
        struct gspca_dev *gspca_dev = priv;
 
-       memset(parm, 0, sizeof parm);
+       memset(parm, 0, sizeof *parm);
        parm->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
        parm->parm.capture.readbuffers = gspca_dev->nbufread;
        return 0;
@@ -1177,13 +1166,17 @@ static int vidioc_s_parm(struct file *filp, void *priv,
        struct gspca_dev *gspca_dev = priv;
        int n;
 
-       mutex_lock_interruptible(&gspca_dev->usb_lock);
        n = parm->parm.capture.readbuffers;
        if (n == 0 || n > GSPCA_MAX_FRAMES)
                parm->parm.capture.readbuffers = gspca_dev->nbufread;
        else
                gspca_dev->nbufread = n;
-       mutex_unlock(&gspca_dev->usb_lock);
+       return 0;
+}
+
+static int vidioc_s_std(struct file *filp, void *priv,
+                       v4l2_std_id *parm)
+{
        return 0;
 }
 
@@ -1196,16 +1189,32 @@ static int vidiocgmbuf(struct file *file, void *priv,
 
        PDEBUG(D_STREAM, "cgmbuf");
        if (gspca_dev->nframes == 0) {
-               struct v4l2_requestbuffers rb;
                int ret;
 
-               memset(&rb, 0, sizeof rb);
-               rb.count = 4;
-               rb.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               rb.memory = V4L2_MEMORY_MMAP;
-               ret = vidioc_reqbufs(file, priv, &rb);
-               if (ret != 0)
-                       return ret;
+               {
+                       struct v4l2_format fmt;
+
+                       memset(&fmt, 0, sizeof fmt);
+                       fmt.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+                       i = gspca_dev->cam.nmodes - 1;  /* highest mode */
+                       fmt.fmt.pix.width = gspca_dev->cam.cam_mode[i].width;
+                       fmt.fmt.pix.height = gspca_dev->cam.cam_mode[i].height;
+                       fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_BGR24;
+                       ret = vidioc_s_fmt_vid_cap(file, priv, &fmt);
+                       if (ret != 0)
+                               return ret;
+               }
+               {
+                       struct v4l2_requestbuffers rb;
+
+                       memset(&rb, 0, sizeof rb);
+                       rb.count = 4;
+                       rb.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+                       rb.memory = V4L2_MEMORY_MMAP;
+                       ret = vidioc_reqbufs(file, priv, &rb);
+                       if (ret != 0)
+                               return ret;
+               }
        }
        mbuf->frames = gspca_dev->nframes;
        mbuf->size = gspca_dev->frsz * gspca_dev->nframes;
@@ -1218,27 +1227,27 @@ static int vidiocgmbuf(struct file *file, void *priv,
 static int dev_mmap(struct file *file, struct vm_area_struct *vma)
 {
        struct gspca_dev *gspca_dev = file->private_data;
-       struct gspca_frame *frame = 0;
+       struct gspca_frame *frame;
        struct page *page;
        unsigned long addr, start, size;
        int i, ret;
-#ifdef CONFIG_VIDEO_V4L1_COMPAT
-       int compat = 0;
-#endif
 
        start = vma->vm_start;
        size = vma->vm_end - vma->vm_start;
        PDEBUG(D_STREAM, "mmap start:%08x size:%d", (int) start, (int) size);
 
-       ret = mutex_lock_interruptible(&gspca_dev->queue_lock);
-       if (ret < 0)
-               return ret;
-/* sanity check disconnect, in use, no memory available */
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
        if (!gspca_dev->present) {
                ret = -ENODEV;
-               goto done;
+               goto out;
+       }
+       if (gspca_dev->capt_file != file) {
+               ret = -EINVAL;
+               goto out;
        }
 
+       frame = NULL;
        for (i = 0; i < gspca_dev->nframes; ++i) {
                if (gspca_dev->frame[i].v4l2_buf.memory != V4L2_MEMORY_MMAP) {
                        PDEBUG(D_STREAM, "mmap bad memory type");
@@ -1250,20 +1259,20 @@ static int dev_mmap(struct file *file, struct vm_area_struct *vma)
                        break;
                }
        }
-       if (frame == 0) {
+       if (frame == NULL) {
                PDEBUG(D_STREAM, "mmap no frame buffer found");
                ret = -EINVAL;
-               goto done;
+               goto out;
        }
 #ifdef CONFIG_VIDEO_V4L1_COMPAT
-       if (i == 0 && size == frame->v4l2_buf.length * gspca_dev->nframes)
-               compat = 1;
-       else
+       /* v4l1 maps all the buffers */
+       if (i != 0
+           || size != frame->v4l2_buf.length * gspca_dev->nframes)
 #endif
-       if (size != frame->v4l2_buf.length) {
+           if (size != frame->v4l2_buf.length) {
                PDEBUG(D_STREAM, "mmap bad size");
                ret = -EINVAL;
-               goto done;
+               goto out;
        }
 
        /*
@@ -1277,7 +1286,7 @@ static int dev_mmap(struct file *file, struct vm_area_struct *vma)
                page = vmalloc_to_page((void *) addr);
                ret = vm_insert_page(vma, start, page);
                if (ret < 0)
-                       goto done;
+                       goto out;
                start += PAGE_SIZE;
                addr += PAGE_SIZE;
                size -= PAGE_SIZE;
@@ -1286,41 +1295,8 @@ static int dev_mmap(struct file *file, struct vm_area_struct *vma)
        vma->vm_ops = &gspca_vm_ops;
        vma->vm_private_data = frame;
        gspca_vm_open(vma);
-#ifdef CONFIG_VIDEO_V4L1_COMPAT
-       if (compat) {
-/*fixme: ugly*/
-               for (i = 1; i < gspca_dev->nframes; ++i)
-                       gspca_dev->frame[i].v4l2_buf.flags |=
-                                               V4L2_BUF_FLAG_MAPPED;
-       }
-#endif
-done:
-       mutex_unlock(&gspca_dev->queue_lock);
-       return ret;
-}
-
-static unsigned int dev_poll(struct file *file, poll_table * wait)
-{
-       struct gspca_dev *gspca_dev = file->private_data;
-       int i, ret;
-
-       PDEBUG(D_FRAM, "poll");
-
-       poll_wait(file, &gspca_dev->wq, wait);
-
-       if (mutex_lock_interruptible(&gspca_dev->queue_lock) != 0)
-               return POLLERR;
-       if (gspca_dev->dev == 0
-           || !gspca_dev->streaming)                   /* if not streaming */
-               ret = POLLERR;
-       else {
-               i = gspca_dev->fr_o;
-               i = gspca_dev->fr_queue[i];
-               if (gspca_dev->frame[i].v4l2_buf.flags & V4L2_BUF_FLAG_DONE)
-                       ret = POLLIN | POLLRDNORM;      /* something to read */
-               else
-                       ret = 0;
-       }
+       ret = 0;
+out:
        mutex_unlock(&gspca_dev->queue_lock);
        return ret;
 }
@@ -1330,40 +1306,54 @@ static unsigned int dev_poll(struct file *file, poll_table * wait)
  *
  * If a frame is ready, its index is returned.
  */
-static int gspca_frame_wait(struct gspca_dev *gspca_dev,
+static int frame_wait(struct gspca_dev *gspca_dev,
                        int nonblock_ing)
 {
        struct gspca_frame *frame;
        int i, j, ret;
 
+       /* check if a frame is ready */
        i = gspca_dev->fr_o;
        j = gspca_dev->fr_queue[i];
        frame = &gspca_dev->frame[j];
-       if (frame->v4l2_buf.flags & V4L2_BUF_FLAG_DONE)
+       if (frame->v4l2_buf.flags & V4L2_BUF_FLAG_DONE) {
+               atomic_dec(&gspca_dev->nevent);
                goto ok;
+       }
        if (nonblock_ing)                       /* no frame yet */
                return -EAGAIN;
 
        /* wait till a frame is ready */
        for (;;) {
-               ret = wait_event_interruptible(gspca_dev->wq,
-                                       atomic_read(&gspca_dev->nevent) > 0);
-               if (ret != 0)
-                       return ret;
+               ret = wait_event_interruptible_timeout(gspca_dev->wq,
+                                       atomic_read(&gspca_dev->nevent) > 0,
+                                       msecs_to_jiffies(3000));
+               if (ret <= 0) {
+                       if (ret < 0)
+                               return ret;     /* interrupt */
+                       return -EIO;            /* timeout */
+               }
+               atomic_dec(&gspca_dev->nevent);
+               if (!gspca_dev->streaming || !gspca_dev->present)
+                       return -EIO;
                i = gspca_dev->fr_o;
                j = gspca_dev->fr_queue[i];
                frame = &gspca_dev->frame[j];
                if (frame->v4l2_buf.flags & V4L2_BUF_FLAG_DONE)
                        break;
        }
-
 ok:
-       atomic_dec(&gspca_dev->nevent);
        gspca_dev->fr_o = (i + 1) % gspca_dev->nframes;
        PDEBUG(D_FRAM, "frame wait q:%d i:%d o:%d",
                gspca_dev->fr_q,
                gspca_dev->fr_i,
                gspca_dev->fr_o);
+
+       if (gspca_dev->sd_desc->dq_callback) {
+               mutex_lock(&gspca_dev->usb_lock);
+               gspca_dev->sd_desc->dq_callback(gspca_dev);
+               mutex_unlock(&gspca_dev->usb_lock);
+       }
        return j;
 }
 
@@ -1380,27 +1370,44 @@ static int vidioc_dqbuf(struct file *file, void *priv,
        int i, ret;
 
        PDEBUG(D_FRAM, "dqbuf");
-       if (v4l2_buf->type != V4L2_BUF_TYPE_VIDEO_CAPTURE
-           || (v4l2_buf->memory != V4L2_MEMORY_MMAP
-               && v4l2_buf->memory != V4L2_MEMORY_USERPTR))
+       if (v4l2_buf->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
-       if (!gspca_dev->streaming)
+       if (v4l2_buf->memory != gspca_dev->memory)
                return -EINVAL;
 
-       /* only one read */
+       /* if not streaming, be sure the application will not loop forever */
+       if (!(file->f_flags & O_NONBLOCK)
+           && !gspca_dev->streaming && gspca_dev->users == 1)
+               return -EINVAL;
+
+       /* only the capturing file may dequeue */
+       if (gspca_dev->capt_file != file)
+               return -EINVAL;
+
+       /* only one dequeue / read at a time */
        if (mutex_lock_interruptible(&gspca_dev->read_lock))
                return -ERESTARTSYS;
 
-       ret = gspca_frame_wait(gspca_dev, file->f_flags & O_NONBLOCK);
+       ret = frame_wait(gspca_dev, file->f_flags & O_NONBLOCK);
        if (ret < 0)
-               goto done;
+               goto out;
        i = ret;                                /* frame index */
        frame = &gspca_dev->frame[i];
+       if (gspca_dev->memory == V4L2_MEMORY_USERPTR) {
+               if (copy_to_user((__u8 *) frame->v4l2_buf.m.userptr,
+                                frame->data,
+                                frame->v4l2_buf.bytesused)) {
+                       PDEBUG(D_ERR|D_STREAM,
+                               "dqbuf cp to user failed");
+                       ret = -EFAULT;
+                       goto out;
+               }
+       }
        frame->v4l2_buf.flags &= ~V4L2_BUF_FLAG_DONE;
        memcpy(v4l2_buf, &frame->v4l2_buf, sizeof *v4l2_buf);
        PDEBUG(D_FRAM, "dqbuf %d", i);
        ret = 0;
-done:
+out:
        mutex_unlock(&gspca_dev->read_lock);
        return ret;
 }
@@ -1422,35 +1429,33 @@ static int vidioc_qbuf(struct file *file, void *priv,
        if (v4l2_buf->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
 
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock))
+               return -ERESTARTSYS;
+
        index = v4l2_buf->index;
        if ((unsigned) index >= gspca_dev->nframes) {
-               PDEBUG(D_STREAM,
+               PDEBUG(D_FRAM,
                        "qbuf idx %d >= %d", index, gspca_dev->nframes);
-               return -EINVAL;
+               ret = -EINVAL;
+               goto out;
        }
-       frame = &gspca_dev->frame[index];
-
-       if (v4l2_buf->memory != frame->v4l2_buf.memory) {
-               PDEBUG(D_STREAM, "qbuf bad memory type");
-               return -EINVAL;
+       if (v4l2_buf->memory != gspca_dev->memory) {
+               PDEBUG(D_FRAM, "qbuf bad memory type");
+               ret = -EINVAL;
+               goto out;
        }
 
-       ret = mutex_lock_interruptible(&gspca_dev->queue_lock);
-       if (ret < 0)
-               return ret;
-       if (frame->v4l2_buf.flags
-                       & (V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE)) {
-               PDEBUG(D_STREAM, "qbuf bad state");
+       frame = &gspca_dev->frame[index];
+       if (frame->v4l2_buf.flags & BUF_ALL_FLAGS) {
+               PDEBUG(D_FRAM, "qbuf bad state");
                ret = -EINVAL;
                goto out;
        }
 
        frame->v4l2_buf.flags |= V4L2_BUF_FLAG_QUEUED;
-       frame->v4l2_buf.flags &= ~V4L2_BUF_FLAG_DONE;
+/*     frame->v4l2_buf.flags &= ~V4L2_BUF_FLAG_DONE; */
 
-       if (v4l2_buf->memory == V4L2_MEMORY_USERPTR) {
-               frame->data = frame->data_end =
-                               (unsigned char *) v4l2_buf->m.userptr;
+       if (frame->v4l2_buf.memory == V4L2_MEMORY_USERPTR) {
                frame->v4l2_buf.m.userptr = v4l2_buf->m.userptr;
                frame->v4l2_buf.length = v4l2_buf->length;
        }
@@ -1472,59 +1477,122 @@ out:
        return ret;
 }
 
-static ssize_t dev_read(struct file *file, char __user *data,
-                   size_t count, loff_t *ppos)
+/*
+ * allocate the resources for read()
+ */
+static int read_alloc(struct gspca_dev *gspca_dev,
+                       struct file *file)
 {
-       struct gspca_dev *gspca_dev = file->private_data;
-       struct gspca_frame *frame;
        struct v4l2_buffer v4l2_buf;
-       struct timeval timestamp;
-       int i, ret, ret2;
+       int i, ret;
 
-       PDEBUG(D_FRAM, "read (%p, %d)", data, count);
+       PDEBUG(D_STREAM, "read alloc");
        if (gspca_dev->nframes == 0) {
                struct v4l2_requestbuffers rb;
 
                memset(&rb, 0, sizeof rb);
                rb.count = gspca_dev->nbufread;
                rb.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               rb.memory = V4L2_MEMORY_MMAP;
+               rb.memory = GSPCA_MEMORY_READ;
                ret = vidioc_reqbufs(file, gspca_dev, &rb);
                if (ret != 0) {
-                       PDEBUG(D_STREAM, "read reqbuf err: %d", ret);
+                       PDEBUG(D_STREAM, "read reqbuf err %d", ret);
                        return ret;
                }
                memset(&v4l2_buf, 0, sizeof v4l2_buf);
                v4l2_buf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               v4l2_buf.memory = V4L2_MEMORY_MMAP;
+               v4l2_buf.memory = GSPCA_MEMORY_READ;
                for (i = 0; i < gspca_dev->nbufread; i++) {
                        v4l2_buf.index = i;
-/*fixme: ugly!*/
-                       gspca_dev->frame[i].v4l2_buf.flags |=
-                                                       V4L2_BUF_FLAG_MAPPED;
                        ret = vidioc_qbuf(file, gspca_dev, &v4l2_buf);
                        if (ret != 0) {
                                PDEBUG(D_STREAM, "read qbuf err: %d", ret);
                                return ret;
                        }
                }
+               gspca_dev->memory = GSPCA_MEMORY_READ;
        }
-       if (!gspca_dev->streaming) {
-               ret = vidioc_streamon(file, gspca_dev,
-                                       V4L2_BUF_TYPE_VIDEO_CAPTURE);
-               if (ret != 0) {
-                       PDEBUG(D_STREAM, "read streamon err %d", ret);
+
+       /* start streaming */
+       ret = vidioc_streamon(file, gspca_dev, V4L2_BUF_TYPE_VIDEO_CAPTURE);
+       if (ret != 0)
+               PDEBUG(D_STREAM, "read streamon err %d", ret);
+       return ret;
+}
+
+static unsigned int dev_poll(struct file *file, poll_table *wait)
+{
+       struct gspca_dev *gspca_dev = file->private_data;
+       int i, ret;
+
+       PDEBUG(D_FRAM, "poll");
+
+       poll_wait(file, &gspca_dev->wq, wait);
+       if (!gspca_dev->present)
+               return POLLERR;
+
+       /* if reqbufs is not done, the user would use read() */
+       if (gspca_dev->nframes == 0) {
+               if (gspca_dev->memory != GSPCA_MEMORY_NO)
+                       return POLLERR;         /* not the 1st time */
+               ret = read_alloc(gspca_dev, file);
+               if (ret != 0)
+                       return POLLERR;
+       }
+
+       if (mutex_lock_interruptible(&gspca_dev->queue_lock) != 0)
+               return POLLERR;
+       if (!gspca_dev->present) {
+               ret = POLLERR;
+               goto out;
+       }
+
+       /* check the next incoming buffer */
+       i = gspca_dev->fr_o;
+       i = gspca_dev->fr_queue[i];
+       if (gspca_dev->frame[i].v4l2_buf.flags & V4L2_BUF_FLAG_DONE)
+               ret = POLLIN | POLLRDNORM;      /* something to read */
+       else
+               ret = 0;
+out:
+       mutex_unlock(&gspca_dev->queue_lock);
+       return ret;
+}
+
+static ssize_t dev_read(struct file *file, char __user *data,
+                   size_t count, loff_t *ppos)
+{
+       struct gspca_dev *gspca_dev = file->private_data;
+       struct gspca_frame *frame;
+       struct v4l2_buffer v4l2_buf;
+       struct timeval timestamp;
+       int n, ret, ret2;
+
+       PDEBUG(D_FRAM, "read (%zd)", count);
+       if (!gspca_dev->present)
+               return -ENODEV;
+       switch (gspca_dev->memory) {
+       case GSPCA_MEMORY_NO:                   /* first time */
+               ret = read_alloc(gspca_dev, file);
+               if (ret != 0)
                        return ret;
-               }
+               break;
+       case GSPCA_MEMORY_READ:
+               if (gspca_dev->capt_file == file)
+                       break;
+               /* fall thru */
+       default:
+               return -EINVAL;
        }
 
        /* get a frame */
        jiffies_to_timeval(get_jiffies_64(), &timestamp);
        timestamp.tv_sec--;
-       for (i = 0; i < 2; i++) {
+       n = 2;
+       for (;;) {
                memset(&v4l2_buf, 0, sizeof v4l2_buf);
                v4l2_buf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               v4l2_buf.memory = V4L2_MEMORY_MMAP;
+               v4l2_buf.memory = GSPCA_MEMORY_READ;
                ret = vidioc_dqbuf(file, gspca_dev, &v4l2_buf);
                if (ret != 0) {
                        PDEBUG(D_STREAM, "read dqbuf err %d", ret);
@@ -1532,8 +1600,10 @@ static ssize_t dev_read(struct file *file, char __user *data,
                }
 
                /* if the process slept for more than 1 second,
-                * get a brand new frame */
+                * get anewer frame */
                frame = &gspca_dev->frame[v4l2_buf.index];
+               if (--n < 0)
+                       break;                  /* avoid infinite loop */
                if (frame->v4l2_buf.timestamp.tv_sec >= timestamp.tv_sec)
                        break;
                ret = vidioc_qbuf(file, gspca_dev, &v4l2_buf);
@@ -1544,18 +1614,12 @@ static ssize_t dev_read(struct file *file, char __user *data,
        }
 
        /* copy the frame */
-       if (count < frame->v4l2_buf.bytesused) {
-               PDEBUG(D_STREAM, "read bad count: %d < %d",
-                       count, frame->v4l2_buf.bytesused);
-/*fixme: special errno?*/
-               ret = -EINVAL;
-               goto out;
-       }
-       count = frame->v4l2_buf.bytesused;
+       if (count > frame->v4l2_buf.bytesused)
+               count = frame->v4l2_buf.bytesused;
        ret = copy_to_user(data, frame->data, count);
        if (ret != 0) {
                PDEBUG(D_ERR|D_STREAM,
-                       "read cp to user lack %d / %d", ret, count);
+                       "read cp to user lack %d / %zd", ret, count);
                ret = -EFAULT;
                goto out;
        }
@@ -1568,7 +1632,7 @@ out:
        return ret;
 }
 
-static void gspca_dev_release(struct video_device *vfd)
+static void dev_release(struct video_device *vfd)
 {
        /* nothing */
 }
@@ -1580,6 +1644,9 @@ static struct file_operations dev_fops = {
        .read = dev_read,
        .mmap = dev_mmap,
        .ioctl = video_ioctl2,
+#ifdef CONFIG_COMPAT
+       .compat_ioctl = v4l_compat_ioctl32,
+#endif
        .llseek = no_llseek,
        .poll   = dev_poll,
 };
@@ -1588,15 +1655,15 @@ static struct video_device gspca_template = {
        .name = "gspca main driver",
        .type = VID_TYPE_CAPTURE,
        .fops = &dev_fops,
-       .release = gspca_dev_release,   /* mandatory */
+       .release = dev_release,         /* mandatory */
        .minor = -1,
        .vidioc_querycap        = vidioc_querycap,
        .vidioc_dqbuf           = vidioc_dqbuf,
        .vidioc_qbuf            = vidioc_qbuf,
-       .vidioc_enum_fmt_cap    = vidioc_enum_fmt_cap,
-       .vidioc_try_fmt_cap     = vidioc_try_fmt_cap,
-       .vidioc_g_fmt_cap       = vidioc_g_fmt_cap,
-       .vidioc_s_fmt_cap       = vidioc_s_fmt_cap,
+       .vidioc_enum_fmt_vid_cap = vidioc_enum_fmt_vid_cap,
+       .vidioc_try_fmt_vid_cap = vidioc_try_fmt_vid_cap,
+       .vidioc_g_fmt_vid_cap   = vidioc_g_fmt_vid_cap,
+       .vidioc_s_fmt_vid_cap   = vidioc_s_fmt_vid_cap,
        .vidioc_streamon        = vidioc_streamon,
        .vidioc_queryctrl       = vidioc_queryctrl,
        .vidioc_g_ctrl          = vidioc_g_ctrl,
@@ -1612,6 +1679,7 @@ static struct video_device gspca_template = {
        .vidioc_s_jpegcomp      = vidioc_s_jpegcomp,
        .vidioc_g_parm          = vidioc_g_parm,
        .vidioc_s_parm          = vidioc_s_parm,
+       .vidioc_s_std           = vidioc_s_std,
 #ifdef CONFIG_VIDEO_V4L1_COMPAT
        .vidiocgmbuf          = vidiocgmbuf,
 #endif
@@ -1626,18 +1694,15 @@ static struct video_device gspca_template = {
 int gspca_dev_probe(struct usb_interface *intf,
                const struct usb_device_id *id,
                const struct sd_desc *sd_desc,
-               int dev_size)
+               int dev_size,
+               struct module *module)
 {
        struct usb_interface_descriptor *interface;
        struct gspca_dev *gspca_dev;
        struct usb_device *dev = interface_to_usbdev(intf);
        int ret;
-       __u16 vendor;
-       __u16 product;
 
-       vendor = le16_to_cpu(dev->descriptor.idVendor);
-       product = le16_to_cpu(dev->descriptor.idProduct);
-       PDEBUG(D_PROBE, "probing %04x:%04x", vendor, product);
+       PDEBUG(D_PROBE, "probing %04x:%04x", id->idVendor, id->idProduct);
 
        /* we don't handle multi-config cameras */
        if (dev->descriptor.bNumConfigurations != 1)
@@ -1656,6 +1721,7 @@ int gspca_dev_probe(struct usb_interface *intf,
        }
        gspca_dev->dev = dev;
        gspca_dev->iface = interface->bInterfaceNumber;
+       gspca_dev->nbalt = intf->num_altsetting;
        gspca_dev->sd_desc = sd_desc;
 /*     gspca_dev->users = 0;                   (done by kzalloc) */
        gspca_dev->nbufread = 2;
@@ -1676,7 +1742,10 @@ int gspca_dev_probe(struct usb_interface *intf,
 
        /* init video stuff */
        memcpy(&gspca_dev->vdev, &gspca_template, sizeof gspca_template);
-       gspca_dev->vdev.dev = &dev->dev;
+       gspca_dev->vdev.parent = &dev->dev;
+       memcpy(&gspca_dev->fops, &dev_fops, sizeof gspca_dev->fops);
+       gspca_dev->vdev.fops = &gspca_dev->fops;
+       gspca_dev->fops.owner = module;         /* module protection */
        ret = video_register_device(&gspca_dev->vdev,
                                  VFL_TYPE_GRABBER,
                                  video_nr);
@@ -1703,16 +1772,17 @@ EXPORT_SYMBOL(gspca_dev_probe);
  */
 void gspca_disconnect(struct usb_interface *intf)
 {
-       struct gspca_dev *gspca_dev  = usb_get_intfdata(intf);
+       struct gspca_dev *gspca_dev = usb_get_intfdata(intf);
 
        if (!gspca_dev)
                return;
        gspca_dev->present = 0;
-       mutex_lock_interruptible(&gspca_dev->queue_lock);
-       mutex_lock_interruptible(&gspca_dev->usb_lock);
-       gspca_kill_transfer(gspca_dev);
-       mutex_unlock(&gspca_dev->queue_lock);
+       mutex_lock(&gspca_dev->queue_lock);
+       mutex_lock(&gspca_dev->usb_lock);
+       gspca_dev->streaming = 0;
+       destroy_urbs(gspca_dev);
        mutex_unlock(&gspca_dev->usb_lock);
+       mutex_unlock(&gspca_dev->queue_lock);
        while (gspca_dev->users != 0) {         /* wait until fully closed */
                atomic_inc(&gspca_dev->nevent);
                wake_up_interruptible(&gspca_dev->wq);  /* wake processes */
@@ -1726,10 +1796,101 @@ void gspca_disconnect(struct usb_interface *intf)
 }
 EXPORT_SYMBOL(gspca_disconnect);
 
+/* -- cam driver utility functions -- */
+
+/* auto gain and exposure algorithm based on the knee algorithm described here:
+   http://ytse.tricolour.net/docs/LowLightOptimization.html
+
+   Returns 0 if no changes were made, 1 if the gain and or exposure settings
+   where changed. */
+int gspca_auto_gain_n_exposure(struct gspca_dev *gspca_dev, int avg_lum,
+       int desired_avg_lum, int deadzone, int gain_knee, int exposure_knee)
+{
+       int i, steps, gain, orig_gain, exposure, orig_exposure, autogain;
+       const struct ctrl *gain_ctrl = NULL;
+       const struct ctrl *exposure_ctrl = NULL;
+       const struct ctrl *autogain_ctrl = NULL;
+       int retval = 0;
+
+       for (i = 0; i < gspca_dev->sd_desc->nctrls; i++) {
+               if (gspca_dev->sd_desc->ctrls[i].qctrl.id == V4L2_CID_GAIN)
+                       gain_ctrl = &gspca_dev->sd_desc->ctrls[i];
+               if (gspca_dev->sd_desc->ctrls[i].qctrl.id == V4L2_CID_EXPOSURE)
+                       exposure_ctrl = &gspca_dev->sd_desc->ctrls[i];
+               if (gspca_dev->sd_desc->ctrls[i].qctrl.id == V4L2_CID_AUTOGAIN)
+                       autogain_ctrl = &gspca_dev->sd_desc->ctrls[i];
+       }
+       if (!gain_ctrl || !exposure_ctrl || !autogain_ctrl) {
+               PDEBUG(D_ERR, "Error: gspca_auto_gain_n_exposure called "
+                       "on cam without (auto)gain/exposure");
+               return 0;
+       }
+
+       if (gain_ctrl->get(gspca_dev, &gain) ||
+                       exposure_ctrl->get(gspca_dev, &exposure) ||
+                       autogain_ctrl->get(gspca_dev, &autogain) || !autogain)
+               return 0;
+
+       orig_gain = gain;
+       orig_exposure = exposure;
+
+       /* If we are of a multiple of deadzone, do multiple steps to reach the
+          desired lumination fast (with the risc of a slight overshoot) */
+       steps = abs(desired_avg_lum - avg_lum) / deadzone;
+
+       PDEBUG(D_FRAM, "autogain: lum: %d, desired: %d, steps: %d\n",
+               avg_lum, desired_avg_lum, steps);
+
+       for (i = 0; i < steps; i++) {
+               if (avg_lum > desired_avg_lum) {
+                       if (gain > gain_knee)
+                               gain--;
+                       else if (exposure > exposure_knee)
+                               exposure--;
+                       else if (gain > gain_ctrl->qctrl.default_value)
+                               gain--;
+                       else if (exposure > exposure_ctrl->qctrl.minimum)
+                               exposure--;
+                       else if (gain > gain_ctrl->qctrl.minimum)
+                               gain--;
+                       else
+                               break;
+               } else {
+                       if (gain < gain_ctrl->qctrl.default_value)
+                               gain++;
+                       else if (exposure < exposure_knee)
+                               exposure++;
+                       else if (gain < gain_knee)
+                               gain++;
+                       else if (exposure < exposure_ctrl->qctrl.maximum)
+                               exposure++;
+                       else if (gain < gain_ctrl->qctrl.maximum)
+                               gain++;
+                       else
+                               break;
+               }
+       }
+
+       if (gain != orig_gain) {
+               gain_ctrl->set(gspca_dev, gain);
+               retval = 1;
+       }
+       if (exposure != orig_exposure) {
+               exposure_ctrl->set(gspca_dev, exposure);
+               retval = 1;
+       }
+
+       return retval;
+}
+EXPORT_SYMBOL(gspca_auto_gain_n_exposure);
+
 /* -- module insert / remove -- */
 static int __init gspca_init(void)
 {
-       info("main v%s registered", version);
+       info("main v%d.%d.%d registered",
+               (DRIVER_VERSION_NUMBER >> 16) & 0xff,
+               (DRIVER_VERSION_NUMBER >> 8) & 0xff,
+               DRIVER_VERSION_NUMBER & 0xff);
        return 0;
 }
 static void __exit gspca_exit(void)
@@ -1740,11 +1901,10 @@ static void __exit gspca_exit(void)
 module_init(gspca_init);
 module_exit(gspca_exit);
 
+#ifdef CONFIG_VIDEO_ADV_DEBUG
 module_param_named(debug, gspca_debug, int, 0644);
 MODULE_PARM_DESC(debug,
                "Debug (bit) 0x01:error 0x02:probe 0x04:config"
-               " 0x08:stream 0x10:frame 0x20:packet 0x40:USBin 0x80:USBout");
-
-module_param(comp_fac, int, 0644);
-MODULE_PARM_DESC(comp_fac,
-               "Buffer size ratio when compressed in percent");
+               " 0x08:stream 0x10:frame 0x20:packet 0x40:USBin 0x80:USBout"
+               " 0x0100: v4l2");
+#endif