]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/net/saa9730.c
pasemi_mac: use buffer index pointer in clean_rx()
[linux-2.6-omap-h63xx.git] / drivers / net / saa9730.c
index b269513cde456290ba637d9aaad354789f5ff9f3..14361e885415ca583c7bcc2eddd8a113120702ab 100644 (file)
@@ -64,37 +64,37 @@ static unsigned int pci_irq_line;
 
 static void evm_saa9730_enable_lan_int(struct lan_saa9730_private *lp)
 {
-       outl(readl(&lp->evm_saa9730_regs->InterruptBlock1) | EVM_LAN_INT,
-            &lp->evm_saa9730_regs->InterruptBlock1);
-       outl(readl(&lp->evm_saa9730_regs->InterruptStatus1) | EVM_LAN_INT,
-            &lp->evm_saa9730_regs->InterruptStatus1);
-       outl(readl(&lp->evm_saa9730_regs->InterruptEnable1) | EVM_LAN_INT |
-            EVM_MASTER_EN, &lp->evm_saa9730_regs->InterruptEnable1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptBlock1) | EVM_LAN_INT,
+              &lp->evm_saa9730_regs->InterruptBlock1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptStatus1) | EVM_LAN_INT,
+              &lp->evm_saa9730_regs->InterruptStatus1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptEnable1) | EVM_LAN_INT |
+              EVM_MASTER_EN, &lp->evm_saa9730_regs->InterruptEnable1);
 }
 
 static void evm_saa9730_disable_lan_int(struct lan_saa9730_private *lp)
 {
-       outl(readl(&lp->evm_saa9730_regs->InterruptBlock1) & ~EVM_LAN_INT,
-            &lp->evm_saa9730_regs->InterruptBlock1);
-       outl(readl(&lp->evm_saa9730_regs->InterruptEnable1) & ~EVM_LAN_INT,
-            &lp->evm_saa9730_regs->InterruptEnable1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptBlock1) & ~EVM_LAN_INT,
+              &lp->evm_saa9730_regs->InterruptBlock1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptEnable1) & ~EVM_LAN_INT,
+              &lp->evm_saa9730_regs->InterruptEnable1);
 }
 
 static void evm_saa9730_clear_lan_int(struct lan_saa9730_private *lp)
 {
-       outl(EVM_LAN_INT, &lp->evm_saa9730_regs->InterruptStatus1);
+       writel(EVM_LAN_INT, &lp->evm_saa9730_regs->InterruptStatus1);
 }
 
 static void evm_saa9730_block_lan_int(struct lan_saa9730_private *lp)
 {
-       outl(readl(&lp->evm_saa9730_regs->InterruptBlock1) & ~EVM_LAN_INT,
-            &lp->evm_saa9730_regs->InterruptBlock1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptBlock1) & ~EVM_LAN_INT,
+              &lp->evm_saa9730_regs->InterruptBlock1);
 }
 
 static void evm_saa9730_unblock_lan_int(struct lan_saa9730_private *lp)
 {
-       outl(readl(&lp->evm_saa9730_regs->InterruptBlock1) | EVM_LAN_INT,
-            &lp->evm_saa9730_regs->InterruptBlock1);
+       writel(readl(&lp->evm_saa9730_regs->InterruptBlock1) | EVM_LAN_INT,
+              &lp->evm_saa9730_regs->InterruptBlock1);
 }
 
 static void __attribute_used__ show_saa9730_regs(struct lan_saa9730_private *lp)
@@ -147,34 +147,34 @@ static void __attribute_used__ show_saa9730_regs(struct lan_saa9730_private *lp)
        printk("lp->lan_saa9730_regs->RxStatus = %x\n",
               readl(&lp->lan_saa9730_regs->RxStatus));
        for (i = 0; i < LAN_SAA9730_CAM_DWORDS; i++) {
-               outl(i, &lp->lan_saa9730_regs->CamAddress);
+               writel(i, &lp->lan_saa9730_regs->CamAddress);
                printk("lp->lan_saa9730_regs->CamData = %x\n",
                       readl(&lp->lan_saa9730_regs->CamData));
        }
-       printk("lp->stats.tx_packets = %lx\n", lp->stats.tx_packets);
-       printk("lp->stats.tx_errors = %lx\n", lp->stats.tx_errors);
-       printk("lp->stats.tx_aborted_errors = %lx\n",
-              lp->stats.tx_aborted_errors);
-       printk("lp->stats.tx_window_errors = %lx\n",
-              lp->stats.tx_window_errors);
-       printk("lp->stats.tx_carrier_errors = %lx\n",
-              lp->stats.tx_carrier_errors);
-       printk("lp->stats.tx_fifo_errors = %lx\n",
-              lp->stats.tx_fifo_errors);
-       printk("lp->stats.tx_heartbeat_errors = %lx\n",
-              lp->stats.tx_heartbeat_errors);
-       printk("lp->stats.collisions = %lx\n", lp->stats.collisions);
-
-       printk("lp->stats.rx_packets = %lx\n", lp->stats.rx_packets);
-       printk("lp->stats.rx_errors = %lx\n", lp->stats.rx_errors);
-       printk("lp->stats.rx_dropped = %lx\n", lp->stats.rx_dropped);
-       printk("lp->stats.rx_crc_errors = %lx\n", lp->stats.rx_crc_errors);
-       printk("lp->stats.rx_frame_errors = %lx\n",
-              lp->stats.rx_frame_errors);
-       printk("lp->stats.rx_fifo_errors = %lx\n",
-              lp->stats.rx_fifo_errors);
-       printk("lp->stats.rx_length_errors = %lx\n",
-              lp->stats.rx_length_errors);
+       printk("dev->stats.tx_packets = %lx\n", dev->stats.tx_packets);
+       printk("dev->stats.tx_errors = %lx\n", dev->stats.tx_errors);
+       printk("dev->stats.tx_aborted_errors = %lx\n",
+              dev->stats.tx_aborted_errors);
+       printk("dev->stats.tx_window_errors = %lx\n",
+              dev->stats.tx_window_errors);
+       printk("dev->stats.tx_carrier_errors = %lx\n",
+              dev->stats.tx_carrier_errors);
+       printk("dev->stats.tx_fifo_errors = %lx\n",
+              dev->stats.tx_fifo_errors);
+       printk("dev->stats.tx_heartbeat_errors = %lx\n",
+              dev->stats.tx_heartbeat_errors);
+       printk("dev->stats.collisions = %lx\n", dev->stats.collisions);
+
+       printk("dev->stats.rx_packets = %lx\n", dev->stats.rx_packets);
+       printk("dev->stats.rx_errors = %lx\n", dev->stats.rx_errors);
+       printk("dev->stats.rx_dropped = %lx\n", dev->stats.rx_dropped);
+       printk("dev->stats.rx_crc_errors = %lx\n", dev->stats.rx_crc_errors);
+       printk("dev->stats.rx_frame_errors = %lx\n",
+              dev->stats.rx_frame_errors);
+       printk("dev->stats.rx_fifo_errors = %lx\n",
+              dev->stats.rx_fifo_errors);
+       printk("dev->stats.rx_length_errors = %lx\n",
+              dev->stats.rx_length_errors);
 
        printk("lp->lan_saa9730_regs->DebugPCIMasterAddr = %x\n",
               readl(&lp->lan_saa9730_regs->DebugPCIMasterAddr));
@@ -288,28 +288,27 @@ static int lan_saa9730_allocate_buffers(struct pci_dev *pdev,
         * Set rx buffer A and rx buffer B to point to the first two buffer
         * spaces.
         */
-       outl(lp->dma_addr + rxoffset,
-            &lp->lan_saa9730_regs->RxBuffA);
-       outl(lp->dma_addr + rxoffset +
-            LAN_SAA9730_PACKET_SIZE * LAN_SAA9730_RCV_Q_SIZE,
-            &lp->lan_saa9730_regs->RxBuffB);
+       writel(lp->dma_addr + rxoffset, &lp->lan_saa9730_regs->RxBuffA);
+       writel(lp->dma_addr + rxoffset +
+              LAN_SAA9730_PACKET_SIZE * LAN_SAA9730_RCV_Q_SIZE,
+              &lp->lan_saa9730_regs->RxBuffB);
 
        /*
         * Set txm_buf_a and txm_buf_b to point to the first two buffer
         * space
         */
-       outl(lp->dma_addr + txoffset,
-            &lp->lan_saa9730_regs->TxBuffA);
-       outl(lp->dma_addr + txoffset +
-            LAN_SAA9730_PACKET_SIZE * LAN_SAA9730_TXM_Q_SIZE,
-            &lp->lan_saa9730_regs->TxBuffB);
+       writel(lp->dma_addr + txoffset,
+              &lp->lan_saa9730_regs->TxBuffA);
+       writel(lp->dma_addr + txoffset +
+              LAN_SAA9730_PACKET_SIZE * LAN_SAA9730_TXM_Q_SIZE,
+              &lp->lan_saa9730_regs->TxBuffB);
 
        /* Set packet number */
-       outl((lp->DmaRcvPackets << PK_COUNT_RX_A_SHF) |
-            (lp->DmaRcvPackets << PK_COUNT_RX_B_SHF) |
-            (lp->DmaTxmPackets << PK_COUNT_TX_A_SHF) |
-            (lp->DmaTxmPackets << PK_COUNT_TX_B_SHF),
-            &lp->lan_saa9730_regs->PacketCount);
+       writel((lp->DmaRcvPackets << PK_COUNT_RX_A_SHF) |
+              (lp->DmaRcvPackets << PK_COUNT_RX_B_SHF) |
+              (lp->DmaTxmPackets << PK_COUNT_TX_A_SHF) |
+              (lp->DmaTxmPackets << PK_COUNT_TX_B_SHF),
+              &lp->lan_saa9730_regs->PacketCount);
 
        return 0;
 
@@ -326,10 +325,10 @@ static int lan_saa9730_cam_load(struct lan_saa9730_private *lp)
 
        for (i = 0; i < LAN_SAA9730_CAM_DWORDS; i++) {
                /* First set address to where data is written */
-               outl(i, &lp->lan_saa9730_regs->CamAddress);
-               outl((NetworkAddress[0] << 24) | (NetworkAddress[1] << 16)
-                    | (NetworkAddress[2] << 8) | NetworkAddress[3],
-                    &lp->lan_saa9730_regs->CamData);
+               writel(i, &lp->lan_saa9730_regs->CamAddress);
+               writel((NetworkAddress[0] << 24) | (NetworkAddress[1] << 16) |
+                      (NetworkAddress[2] << 8) | NetworkAddress[3],
+                      &lp->lan_saa9730_regs->CamData);
                NetworkAddress += 4;
        }
        return 0;
@@ -365,8 +364,8 @@ static int lan_saa9730_mii_init(struct lan_saa9730_private *lp)
        }
 
        /* Now set the control and address register. */
-       outl(MD_CA_BUSY | PHY_STATUS | PHY_ADDRESS << MD_CA_PHY_SHF,
-            &lp->lan_saa9730_regs->StationMgmtCtl);
+       writel(MD_CA_BUSY | PHY_STATUS | PHY_ADDRESS << MD_CA_PHY_SHF,
+              &lp->lan_saa9730_regs->StationMgmtCtl);
 
        /* check link status, spin here till station is not busy */
        i = 0;
@@ -391,23 +390,23 @@ static int lan_saa9730_mii_init(struct lan_saa9730_private *lp)
                /* Link is down, reset the PHY first. */
 
                /* set PHY address = 'CONTROL' */
-               outl(PHY_ADDRESS << MD_CA_PHY_SHF | MD_CA_WR | PHY_CONTROL,
-                    &lp->lan_saa9730_regs->StationMgmtCtl);
+               writel(PHY_ADDRESS << MD_CA_PHY_SHF | MD_CA_WR | PHY_CONTROL,
+                      &lp->lan_saa9730_regs->StationMgmtCtl);
 
                /* Wait for 1 ms. */
                mdelay(1);
 
                /* set 'CONTROL' = force reset and renegotiate */
-               outl(PHY_CONTROL_RESET | PHY_CONTROL_AUTO_NEG |
-                    PHY_CONTROL_RESTART_AUTO_NEG,
-                    &lp->lan_saa9730_regs->StationMgmtData);
+               writel(PHY_CONTROL_RESET | PHY_CONTROL_AUTO_NEG |
+                      PHY_CONTROL_RESTART_AUTO_NEG,
+                      &lp->lan_saa9730_regs->StationMgmtData);
 
                /* Wait for 50 ms. */
                mdelay(50);
 
                /* set 'BUSY' to start operation */
-               outl(MD_CA_BUSY | PHY_ADDRESS << MD_CA_PHY_SHF | MD_CA_WR |
-                    PHY_CONTROL, &lp->lan_saa9730_regs->StationMgmtCtl);
+               writel(MD_CA_BUSY | PHY_ADDRESS << MD_CA_PHY_SHF | MD_CA_WR |
+                      PHY_CONTROL, &lp->lan_saa9730_regs->StationMgmtCtl);
 
                /* await completion */
                i = 0;
@@ -427,9 +426,9 @@ static int lan_saa9730_mii_init(struct lan_saa9730_private *lp)
 
                for (l = 0; l < 2; l++) {
                        /* set PHY address = 'STATUS' */
-                       outl(MD_CA_BUSY | PHY_ADDRESS << MD_CA_PHY_SHF |
-                            PHY_STATUS,
-                            &lp->lan_saa9730_regs->StationMgmtCtl);
+                       writel(MD_CA_BUSY | PHY_ADDRESS << MD_CA_PHY_SHF |
+                              PHY_STATUS,
+                              &lp->lan_saa9730_regs->StationMgmtCtl);
 
                        /* await completion */
                        i = 0;
@@ -462,35 +461,35 @@ static int lan_saa9730_mii_init(struct lan_saa9730_private *lp)
 static int lan_saa9730_control_init(struct lan_saa9730_private *lp)
 {
        /* Initialize DMA control register. */
-       outl((LANMB_ANY << DMA_CTL_MAX_XFER_SHF) |
-            (LANEND_LITTLE << DMA_CTL_ENDIAN_SHF) |
-            (LAN_SAA9730_RCV_Q_INT_THRESHOLD << DMA_CTL_RX_INT_COUNT_SHF)
-            | DMA_CTL_RX_INT_TO_EN | DMA_CTL_RX_INT_EN |
-            DMA_CTL_MAC_RX_INT_EN | DMA_CTL_MAC_TX_INT_EN,
-            &lp->lan_saa9730_regs->LanDmaCtl);
+       writel((LANMB_ANY << DMA_CTL_MAX_XFER_SHF) |
+              (LANEND_LITTLE << DMA_CTL_ENDIAN_SHF) |
+              (LAN_SAA9730_RCV_Q_INT_THRESHOLD << DMA_CTL_RX_INT_COUNT_SHF)
+              | DMA_CTL_RX_INT_TO_EN | DMA_CTL_RX_INT_EN |
+              DMA_CTL_MAC_RX_INT_EN | DMA_CTL_MAC_TX_INT_EN,
+              &lp->lan_saa9730_regs->LanDmaCtl);
 
        /* Initial MAC control register. */
-       outl((MACCM_MII << MAC_CONTROL_CONN_SHF) | MAC_CONTROL_FULL_DUP,
-            &lp->lan_saa9730_regs->MacCtl);
+       writel((MACCM_MII << MAC_CONTROL_CONN_SHF) | MAC_CONTROL_FULL_DUP,
+              &lp->lan_saa9730_regs->MacCtl);
 
        /* Initialize CAM control register. */
-       outl(CAM_CONTROL_COMP_EN | CAM_CONTROL_BROAD_ACC,
-            &lp->lan_saa9730_regs->CamCtl);
+       writel(CAM_CONTROL_COMP_EN | CAM_CONTROL_BROAD_ACC,
+              &lp->lan_saa9730_regs->CamCtl);
 
        /*
         * Initialize CAM enable register, only turn on first entry, should
         * contain own addr.
         */
-       outl(0x0001, &lp->lan_saa9730_regs->CamEnable);
+       writel(0x0001, &lp->lan_saa9730_regs->CamEnable);
 
        /* Initialize Tx control register */
-       outl(TX_CTL_EN_COMP, &lp->lan_saa9730_regs->TxCtl);
+       writel(TX_CTL_EN_COMP, &lp->lan_saa9730_regs->TxCtl);
 
        /* Initialize Rcv control register */
-       outl(RX_CTL_STRIP_CRC, &lp->lan_saa9730_regs->RxCtl);
+       writel(RX_CTL_STRIP_CRC, &lp->lan_saa9730_regs->RxCtl);
 
        /* Reset DMA engine */
-       outl(DMA_TEST_SW_RESET, &lp->lan_saa9730_regs->DmaTest);
+       writel(DMA_TEST_SW_RESET, &lp->lan_saa9730_regs->DmaTest);
 
        return 0;
 }
@@ -500,14 +499,14 @@ static int lan_saa9730_stop(struct lan_saa9730_private *lp)
        int i;
 
        /* Stop DMA first */
-       outl(readl(&lp->lan_saa9730_regs->LanDmaCtl) &
-            ~(DMA_CTL_EN_TX_DMA | DMA_CTL_EN_RX_DMA),
-            &lp->lan_saa9730_regs->LanDmaCtl);
+       writel(readl(&lp->lan_saa9730_regs->LanDmaCtl) &
+              ~(DMA_CTL_EN_TX_DMA | DMA_CTL_EN_RX_DMA),
+              &lp->lan_saa9730_regs->LanDmaCtl);
 
        /* Set the SW Reset bits in DMA and MAC control registers */
-       outl(DMA_TEST_SW_RESET, &lp->lan_saa9730_regs->DmaTest);
-       outl(readl(&lp->lan_saa9730_regs->MacCtl) | MAC_CONTROL_RESET,
-            &lp->lan_saa9730_regs->MacCtl);
+       writel(DMA_TEST_SW_RESET, &lp->lan_saa9730_regs->DmaTest);
+       writel(readl(&lp->lan_saa9730_regs->MacCtl) | MAC_CONTROL_RESET,
+              &lp->lan_saa9730_regs->MacCtl);
 
        /*
         * Wait for MAC reset to have finished. The reset bit is auto cleared
@@ -532,8 +531,8 @@ static int lan_saa9730_dma_init(struct lan_saa9730_private *lp)
        /* Stop lan controller. */
        lan_saa9730_stop(lp);
 
-       outl(LAN_SAA9730_DEFAULT_TIME_OUT_CNT,
-            &lp->lan_saa9730_regs->Timeout);
+       writel(LAN_SAA9730_DEFAULT_TIME_OUT_CNT,
+              &lp->lan_saa9730_regs->Timeout);
 
        return 0;
 }
@@ -552,19 +551,19 @@ static int lan_saa9730_start(struct lan_saa9730_private *lp)
        lp->PendingTxmPacketIndex = 0;
        lp->PendingTxmBufferIndex = 0;
 
-       outl(readl(&lp->lan_saa9730_regs->LanDmaCtl) | DMA_CTL_EN_TX_DMA |
-            DMA_CTL_EN_RX_DMA, &lp->lan_saa9730_regs->LanDmaCtl);
+       writel(readl(&lp->lan_saa9730_regs->LanDmaCtl) | DMA_CTL_EN_TX_DMA |
+              DMA_CTL_EN_RX_DMA, &lp->lan_saa9730_regs->LanDmaCtl);
 
        /* For Tx, turn on MAC then DMA */
-       outl(readl(&lp->lan_saa9730_regs->TxCtl) | TX_CTL_TX_EN,
-            &lp->lan_saa9730_regs->TxCtl);
+       writel(readl(&lp->lan_saa9730_regs->TxCtl) | TX_CTL_TX_EN,
+              &lp->lan_saa9730_regs->TxCtl);
 
        /* For Rx, turn on DMA then MAC */
-       outl(readl(&lp->lan_saa9730_regs->RxCtl) | RX_CTL_RX_EN,
-            &lp->lan_saa9730_regs->RxCtl);
+       writel(readl(&lp->lan_saa9730_regs->RxCtl) | RX_CTL_RX_EN,
+              &lp->lan_saa9730_regs->RxCtl);
 
        /* Set Ok2Use to let hardware own the buffers.  */
-       outl(OK2USE_RX_A | OK2USE_RX_B, &lp->lan_saa9730_regs->Ok2Use);
+       writel(OK2USE_RX_A | OK2USE_RX_B, &lp->lan_saa9730_regs->Ok2Use);
 
        return 0;
 }
@@ -587,7 +586,7 @@ static int lan_saa9730_tx(struct net_device *dev)
                printk("lan_saa9730_tx interrupt\n");
 
        /* Clear interrupt. */
-       outl(DMA_STATUS_MAC_TX_INT, &lp->lan_saa9730_regs->DmaStatus);
+       writel(DMA_STATUS_MAC_TX_INT, &lp->lan_saa9730_regs->DmaStatus);
 
        while (1) {
                pPacket = lp->TxmBuffer[lp->PendingTxmBufferIndex]
@@ -606,24 +605,24 @@ static int lan_saa9730_tx(struct net_device *dev)
                                printk("lan_saa9730_tx: tx error = %x\n",
                                       tx_status);
 
-                       lp->stats.tx_errors++;
+                       dev->stats.tx_errors++;
                        if (tx_status &
                            (TX_STATUS_EX_COLL << TX_STAT_CTL_STATUS_SHF))
-                               lp->stats.tx_aborted_errors++;
+                               dev->stats.tx_aborted_errors++;
                        if (tx_status &
                            (TX_STATUS_LATE_COLL << TX_STAT_CTL_STATUS_SHF))
-                               lp->stats.tx_window_errors++;
+                               dev->stats.tx_window_errors++;
                        if (tx_status &
                            (TX_STATUS_L_CARR << TX_STAT_CTL_STATUS_SHF))
-                               lp->stats.tx_carrier_errors++;
+                               dev->stats.tx_carrier_errors++;
                        if (tx_status &
                            (TX_STATUS_UNDER << TX_STAT_CTL_STATUS_SHF))
-                               lp->stats.tx_fifo_errors++;
+                               dev->stats.tx_fifo_errors++;
                        if (tx_status &
                            (TX_STATUS_SQ_ERR << TX_STAT_CTL_STATUS_SHF))
-                               lp->stats.tx_heartbeat_errors++;
+                               dev->stats.tx_heartbeat_errors++;
 
-                       lp->stats.collisions +=
+                       dev->stats.collisions +=
                                tx_status & TX_STATUS_TX_COLL_MSK;
                }
 
@@ -660,8 +659,8 @@ static int lan_saa9730_rx(struct net_device *dev)
                printk("lan_saa9730_rx interrupt\n");
 
        /* Clear receive interrupts. */
-       outl(DMA_STATUS_MAC_RX_INT | DMA_STATUS_RX_INT |
-            DMA_STATUS_RX_TO_INT, &lp->lan_saa9730_regs->DmaStatus);
+       writel(DMA_STATUS_MAC_RX_INT | DMA_STATUS_RX_INT |
+              DMA_STATUS_RX_TO_INT, &lp->lan_saa9730_regs->DmaStatus);
 
        /* Address next packet */
        BufferIndex = lp->NextRcvBufferIndex;
@@ -685,16 +684,15 @@ static int lan_saa9730_rx(struct net_device *dev)
                                printk
                                    ("%s: Memory squeeze, deferring packet.\n",
                                     dev->name);
-                               lp->stats.rx_dropped++;
+                               dev->stats.rx_dropped++;
                        } else {
-                               lp->stats.rx_bytes += len;
-                               lp->stats.rx_packets++;
-                               skb->dev = dev;
+                               dev->stats.rx_bytes += len;
+                               dev->stats.rx_packets++;
                                skb_reserve(skb, 2);    /* 16 byte align */
                                skb_put(skb, len);      /* make room */
-                               eth_copy_and_sum(skb,
+                               skb_copy_to_linear_data(skb,
                                                 (unsigned char *) pData,
-                                                len, 0);
+                                                len);
                                skb->protocol = eth_type_trans(skb, dev);
                                netif_rx(skb);
                                dev->last_rx = jiffies;
@@ -706,27 +704,27 @@ static int lan_saa9730_rx(struct net_device *dev)
                                    ("lan_saa9730_rx: We got an error packet = %x\n",
                                     rx_status);
 
-                       lp->stats.rx_errors++;
+                       dev->stats.rx_errors++;
                        if (rx_status &
                            (RX_STATUS_CRC_ERR << RX_STAT_CTL_STATUS_SHF))
-                               lp->stats.rx_crc_errors++;
+                               dev->stats.rx_crc_errors++;
                        if (rx_status &
                            (RX_STATUS_ALIGN_ERR << RX_STAT_CTL_STATUS_SHF))
-                               lp->stats.rx_frame_errors++;
+                               dev->stats.rx_frame_errors++;
                        if (rx_status &
                            (RX_STATUS_OVERFLOW << RX_STAT_CTL_STATUS_SHF))
-                               lp->stats.rx_fifo_errors++;
+                               dev->stats.rx_fifo_errors++;
                        if (rx_status &
                            (RX_STATUS_LONG_ERR << RX_STAT_CTL_STATUS_SHF))
-                               lp->stats.rx_length_errors++;
+                               dev->stats.rx_length_errors++;
                }
 
                /* Indicate we have processed the buffer. */
                *pPacket = cpu_to_le32(RXSF_READY << RX_STAT_CTL_OWNER_SHF);
 
                /* Make sure A or B is available to hardware as appropriate. */
-               outl(BufferIndex ? OK2USE_RX_B : OK2USE_RX_A,
-                    &lp->lan_saa9730_regs->Ok2Use);
+               writel(BufferIndex ? OK2USE_RX_B : OK2USE_RX_A,
+                      &lp->lan_saa9730_regs->Ok2Use);
 
                /* Go to next packet in sequence. */
                lp->NextRcvPacketIndex++;
@@ -844,8 +842,8 @@ static int lan_saa9730_write(struct lan_saa9730_private *lp,
                            (len << TX_STAT_CTL_LENGTH_SHF));
 
        /* Make sure A or B is available to hardware as appropriate. */
-       outl(BufferIndex ? OK2USE_TX_B : OK2USE_TX_A,
-            &lp->lan_saa9730_regs->Ok2Use);
+       writel(BufferIndex ? OK2USE_TX_B : OK2USE_TX_A,
+              &lp->lan_saa9730_regs->Ok2Use);
 
        return 0;
 }
@@ -855,7 +853,7 @@ static void lan_saa9730_tx_timeout(struct net_device *dev)
        struct lan_saa9730_private *lp = netdev_priv(dev);
 
        /* Transmitter timeout, serious problems */
-       lp->stats.tx_errors++;
+       dev->stats.tx_errors++;
        printk("%s: transmit timed out, reset\n", dev->name);
        /*show_saa9730_regs(lp); */
        lan_saa9730_restart(lp);
@@ -888,8 +886,8 @@ static int lan_saa9730_start_xmit(struct sk_buff *skb,
                return -1;
        }
 
-       lp->stats.tx_bytes += len;
-       lp->stats.tx_packets++;
+       dev->stats.tx_bytes += len;
+       dev->stats.tx_packets++;
 
        dev->trans_start = jiffies;
        netif_wake_queue(dev);
@@ -921,14 +919,6 @@ static int lan_saa9730_close(struct net_device *dev)
        return 0;
 }
 
-static struct net_device_stats *lan_saa9730_get_stats(struct net_device
-                                                     *dev)
-{
-       struct lan_saa9730_private *lp = netdev_priv(dev);
-
-       return &lp->stats;
-}
-
 static void lan_saa9730_set_multicast(struct net_device *dev)
 {
        struct lan_saa9730_private *lp = netdev_priv(dev);
@@ -938,19 +928,18 @@ static void lan_saa9730_set_multicast(struct net_device *dev)
 
        if (dev->flags & IFF_PROMISC) {
                /* accept all packets */
-               outl(CAM_CONTROL_COMP_EN | CAM_CONTROL_STATION_ACC |
-                    CAM_CONTROL_GROUP_ACC | CAM_CONTROL_BROAD_ACC,
-                    &lp->lan_saa9730_regs->CamCtl);
+               writel(CAM_CONTROL_COMP_EN | CAM_CONTROL_STATION_ACC |
+                      CAM_CONTROL_GROUP_ACC | CAM_CONTROL_BROAD_ACC,
+                      &lp->lan_saa9730_regs->CamCtl);
        } else {
-               if (dev->flags & IFF_ALLMULTI) {
+               if (dev->flags & IFF_ALLMULTI || dev->mc_count) {
                        /* accept all multicast packets */
-                       outl(CAM_CONTROL_COMP_EN | CAM_CONTROL_GROUP_ACC |
-                            CAM_CONTROL_BROAD_ACC,
-                            &lp->lan_saa9730_regs->CamCtl);
-               } else {
                        /*
                         * Will handle the multicast stuff later. -carstenl
                         */
+                       writel(CAM_CONTROL_COMP_EN | CAM_CONTROL_GROUP_ACC |
+                              CAM_CONTROL_BROAD_ACC,
+                              &lp->lan_saa9730_regs->CamCtl);
                }
        }
 
@@ -1043,7 +1032,6 @@ static int lan_saa9730_init(struct net_device *dev, struct pci_dev *pdev,
        dev->open = lan_saa9730_open;
        dev->hard_start_xmit = lan_saa9730_start_xmit;
        dev->stop = lan_saa9730_close;
-       dev->get_stats = lan_saa9730_get_stats;
        dev->set_multicast_list = lan_saa9730_set_multicast;
        dev->tx_timeout = lan_saa9730_tx_timeout;
        dev->watchdog_timeo = (HZ >> 1);