]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/net/wireless/iwlwifi/iwl-3945-rs.c
iwlwifi: handle shared memory Rx index access
[linux-2.6-omap-h63xx.git] / drivers / net / wireless / iwlwifi / iwl-3945-rs.c
index d79f18c41957a1b87fefc099002d78b47bba17a7..e51eeeff6992bc8af8a0ea04fdc24401b3f47b17 100644 (file)
@@ -1,6 +1,6 @@
 /******************************************************************************
  *
- * Copyright(c) 2005 - 2007 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2008 Intel Corporation. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of version 2 of the GNU General Public License as
@@ -29,7 +29,6 @@
 #include <linux/skbuff.h>
 #include <linux/wireless.h>
 #include <net/mac80211.h>
-#include <net/ieee80211.h>
 
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -37,7 +36,7 @@
 
 #include <linux/workqueue.h>
 
-#include "../net/mac80211/ieee80211_rate.h"
+#include "../net/mac80211/rate.h"
 
 #include "iwl-3945.h"
 
@@ -52,7 +51,7 @@ struct iwl3945_rate_scale_data {
        unsigned long stamp;
 };
 
-struct iwl3945_rate_scale_priv {
+struct iwl3945_rs_sta {
        spinlock_t lock;
        s32 *expected_tpt;
        unsigned long last_partial_flush;
@@ -100,14 +99,6 @@ static struct iwl3945_tpt_entry iwl3945_tpt_table_a[] = {
        {-89, IWL_RATE_6M_INDEX}
 };
 
-static struct iwl3945_tpt_entry iwl3945_tpt_table_b[] = {
-       {-86, IWL_RATE_11M_INDEX},
-       {-88, IWL_RATE_5M_INDEX},
-       {-90, IWL_RATE_2M_INDEX},
-       {-92, IWL_RATE_1M_INDEX}
-
-};
-
 static struct iwl3945_tpt_entry iwl3945_tpt_table_g[] = {
        {-60, IWL_RATE_54M_INDEX},
        {-64, IWL_RATE_48M_INDEX},
@@ -129,7 +120,7 @@ static struct iwl3945_tpt_entry iwl3945_tpt_table_g[] = {
 #define IWL_RATE_MIN_SUCCESS_TH       8
 #define IWL_RATE_DECREASE_TH       1920
 
-static u8 iwl3945_get_rate_index_by_rssi(s32 rssi, u8 mode)
+static u8 iwl3945_get_rate_index_by_rssi(s32 rssi, enum ieee80211_band band)
 {
        u32 index = 0;
        u32 table_size = 0;
@@ -138,21 +129,19 @@ static u8 iwl3945_get_rate_index_by_rssi(s32 rssi, u8 mode)
        if ((rssi < IWL_MIN_RSSI_VAL) || (rssi > IWL_MAX_RSSI_VAL))
                rssi = IWL_MIN_RSSI_VAL;
 
-       switch (mode) {
-       case MODE_IEEE80211G:
+       switch (band) {
+       case IEEE80211_BAND_2GHZ:
                tpt_table = iwl3945_tpt_table_g;
                table_size = ARRAY_SIZE(iwl3945_tpt_table_g);
                break;
 
-       case MODE_IEEE80211A:
+       case IEEE80211_BAND_5GHZ:
                tpt_table = iwl3945_tpt_table_a;
                table_size = ARRAY_SIZE(iwl3945_tpt_table_a);
                break;
 
        default:
-       case MODE_IEEE80211B:
-               tpt_table = iwl3945_tpt_table_b;
-               table_size = ARRAY_SIZE(iwl3945_tpt_table_b);
+               BUG();
                break;
        }
 
@@ -168,9 +157,9 @@ static void iwl3945_clear_window(struct iwl3945_rate_scale_data *window)
 {
        window->data = 0;
        window->success_counter = 0;
-       window->success_ratio = IWL_INVALID_VALUE;
+       window->success_ratio = -1;
        window->counter = 0;
-       window->average_tpt = IWL_INVALID_VALUE;
+       window->average_tpt = IWL_INV_TPT;
        window->stamp = 0;
 }
 
@@ -181,7 +170,7 @@ static void iwl3945_clear_window(struct iwl3945_rate_scale_data *window)
  * not flushed.  If there were any that were not flushed, then
  * reschedule the rate flushing routine.
  */
-static int iwl3945_rate_scale_flush_windows(struct iwl3945_rate_scale_priv *rs_priv)
+static int iwl3945_rate_scale_flush_windows(struct iwl3945_rs_sta *rs_sta)
 {
        int unflushed = 0;
        int i;
@@ -193,19 +182,19 @@ static int iwl3945_rate_scale_flush_windows(struct iwl3945_rate_scale_priv *rs_p
         * since we flushed, clear out the gathered statistics
         */
        for (i = 0; i < IWL_RATE_COUNT; i++) {
-               if (!rs_priv->win[i].counter)
+               if (!rs_sta->win[i].counter)
                        continue;
 
-               spin_lock_irqsave(&rs_priv->lock, flags);
-               if (time_after(jiffies, rs_priv->win[i].stamp +
+               spin_lock_irqsave(&rs_sta->lock, flags);
+               if (time_after(jiffies, rs_sta->win[i].stamp +
                               IWL_RATE_WIN_FLUSH)) {
                        IWL_DEBUG_RATE("flushing %d samples of rate "
                                       "index %d\n",
-                                      rs_priv->win[i].counter, i);
-                       iwl3945_clear_window(&rs_priv->win[i]);
+                                      rs_sta->win[i].counter, i);
+                       iwl3945_clear_window(&rs_sta->win[i]);
                } else
                        unflushed++;
-               spin_unlock_irqrestore(&rs_priv->lock, flags);
+               spin_unlock_irqrestore(&rs_sta->lock, flags);
        }
 
        return unflushed;
@@ -216,28 +205,28 @@ static int iwl3945_rate_scale_flush_windows(struct iwl3945_rate_scale_priv *rs_p
 
 static void iwl3945_bg_rate_scale_flush(unsigned long data)
 {
-       struct iwl3945_rate_scale_priv *rs_priv = (void *)data;
+       struct iwl3945_rs_sta *rs_sta = (void *)data;
        int unflushed = 0;
        unsigned long flags;
        u32 packet_count, duration, pps;
 
        IWL_DEBUG_RATE("enter\n");
 
-       unflushed = iwl3945_rate_scale_flush_windows(rs_priv);
+       unflushed = iwl3945_rate_scale_flush_windows(rs_sta);
 
-       spin_lock_irqsave(&rs_priv->lock, flags);
+       spin_lock_irqsave(&rs_sta->lock, flags);
 
-       rs_priv->flush_pending = 0;
+       rs_sta->flush_pending = 0;
 
        /* Number of packets Rx'd since last time this timer ran */
-       packet_count = (rs_priv->tx_packets - rs_priv->last_tx_packets) + 1;
+       packet_count = (rs_sta->tx_packets - rs_sta->last_tx_packets) + 1;
 
-       rs_priv->last_tx_packets = rs_priv->tx_packets + 1;
+       rs_sta->last_tx_packets = rs_sta->tx_packets + 1;
 
        if (unflushed) {
                duration =
-                   jiffies_to_msecs(jiffies - rs_priv->last_partial_flush);
-/*              duration = jiffies_to_msecs(rs_priv->flush_time); */
+                   jiffies_to_msecs(jiffies - rs_sta->last_partial_flush);
+/*              duration = jiffies_to_msecs(rs_sta->flush_time); */
 
                IWL_DEBUG_RATE("Tx'd %d packets in %dms\n",
                               packet_count, duration);
@@ -255,23 +244,23 @@ static void iwl3945_bg_rate_scale_flush(unsigned long data)
                } else
                        duration = IWL_RATE_FLUSH_MAX;
 
-               rs_priv->flush_time = msecs_to_jiffies(duration);
+               rs_sta->flush_time = msecs_to_jiffies(duration);
 
                IWL_DEBUG_RATE("new flush period: %d msec ave %d\n",
                               duration, packet_count);
 
-               mod_timer(&rs_priv->rate_scale_flush, jiffies +
-                         rs_priv->flush_time);
+               mod_timer(&rs_sta->rate_scale_flush, jiffies +
+                         rs_sta->flush_time);
 
-               rs_priv->last_partial_flush = jiffies;
+               rs_sta->last_partial_flush = jiffies;
        }
 
        /* If there weren't any unflushed entries, we don't schedule the timer
         * to run again */
 
-       rs_priv->last_flush = jiffies;
+       rs_sta->last_flush = jiffies;
 
-       spin_unlock_irqrestore(&rs_priv->lock, flags);
+       spin_unlock_irqrestore(&rs_sta->lock, flags);
 
        IWL_DEBUG_RATE("leave\n");
 }
@@ -283,7 +272,7 @@ static void iwl3945_bg_rate_scale_flush(unsigned long data)
  * at this rate.  window->data contains the bitmask of successful
  * packets.
  */
-static void iwl3945_collect_tx_data(struct iwl3945_rate_scale_priv *rs_priv,
+static void iwl3945_collect_tx_data(struct iwl3945_rs_sta *rs_sta,
                                struct iwl3945_rate_scale_data *window,
                                int success, int retries)
 {
@@ -295,7 +284,7 @@ static void iwl3945_collect_tx_data(struct iwl3945_rate_scale_priv *rs_priv,
        }
 
        while (retries--) {
-               spin_lock_irqsave(&rs_priv->lock, flags);
+               spin_lock_irqsave(&rs_sta->lock, flags);
 
                /* If we have filled up the window then subtract one from the
                 * success counter if the high-bit is counting toward
@@ -323,7 +312,7 @@ static void iwl3945_collect_tx_data(struct iwl3945_rate_scale_priv *rs_priv,
                /* Tag this window as having been updated */
                window->stamp = jiffies;
 
-               spin_unlock_irqrestore(&rs_priv->lock, flags);
+               spin_unlock_irqrestore(&rs_sta->lock, flags);
        }
 }
 
@@ -340,17 +329,17 @@ static void rs_rate_init(void *priv_rate, void *priv_sta,
         * after assoc.. */
 
        for (i = IWL_RATE_COUNT - 1; i >= 0; i--) {
-               if (sta->supp_rates & (1 << i)) {
-                       sta->txrate = i;
+               if (sta->supp_rates[local->hw.conf.channel->band] & (1 << i)) {
+                       sta->txrate_idx = i;
                        break;
                }
        }
 
-       sta->last_txrate = sta->txrate;
+       sta->last_txrate_idx = sta->txrate_idx;
 
-       /* For MODE_IEEE80211A mode it start at IWL_FIRST_OFDM_RATE */
-        if (local->hw.conf.phymode == MODE_IEEE80211A)
-                sta->last_txrate += IWL_FIRST_OFDM_RATE;
+       /* For 5 GHz band it start at IWL_FIRST_OFDM_RATE */
+       if (local->hw.conf.channel->band == IEEE80211_BAND_5GHZ)
+               sta->last_txrate_idx += IWL_FIRST_OFDM_RATE;
 
        IWL_DEBUG_RATE("leave\n");
 }
@@ -373,49 +362,49 @@ static void rs_clear(void *priv)
 
 static void *rs_alloc_sta(void *priv, gfp_t gfp)
 {
-       struct iwl3945_rate_scale_priv *rs_priv;
+       struct iwl3945_rs_sta *rs_sta;
        int i;
 
        IWL_DEBUG_RATE("enter\n");
 
-       rs_priv = kzalloc(sizeof(struct iwl3945_rate_scale_priv), gfp);
-       if (!rs_priv) {
+       rs_sta = kzalloc(sizeof(struct iwl3945_rs_sta), gfp);
+       if (!rs_sta) {
                IWL_DEBUG_RATE("leave: ENOMEM\n");
                return NULL;
        }
 
-       spin_lock_init(&rs_priv->lock);
+       spin_lock_init(&rs_sta->lock);
 
-       rs_priv->start_rate = IWL_RATE_INVALID;
+       rs_sta->start_rate = IWL_RATE_INVALID;
 
        /* default to just 802.11b */
-       rs_priv->expected_tpt = iwl3945_expected_tpt_b;
+       rs_sta->expected_tpt = iwl3945_expected_tpt_b;
 
-       rs_priv->last_partial_flush = jiffies;
-       rs_priv->last_flush = jiffies;
-       rs_priv->flush_time = IWL_RATE_FLUSH;
-       rs_priv->last_tx_packets = 0;
-       rs_priv->ibss_sta_added = 0;
+       rs_sta->last_partial_flush = jiffies;
+       rs_sta->last_flush = jiffies;
+       rs_sta->flush_time = IWL_RATE_FLUSH;
+       rs_sta->last_tx_packets = 0;
+       rs_sta->ibss_sta_added = 0;
 
-       init_timer(&rs_priv->rate_scale_flush);
-       rs_priv->rate_scale_flush.data = (unsigned long)rs_priv;
-       rs_priv->rate_scale_flush.function = &iwl3945_bg_rate_scale_flush;
+       init_timer(&rs_sta->rate_scale_flush);
+       rs_sta->rate_scale_flush.data = (unsigned long)rs_sta;
+       rs_sta->rate_scale_flush.function = &iwl3945_bg_rate_scale_flush;
 
        for (i = 0; i < IWL_RATE_COUNT; i++)
-               iwl3945_clear_window(&rs_priv->win[i]);
+               iwl3945_clear_window(&rs_sta->win[i]);
 
        IWL_DEBUG_RATE("leave\n");
 
-       return rs_priv;
+       return rs_sta;
 }
 
 static void rs_free_sta(void *priv, void *priv_sta)
 {
-       struct iwl3945_rate_scale_priv *rs_priv = priv_sta;
+       struct iwl3945_rs_sta *rs_sta = priv_sta;
 
        IWL_DEBUG_RATE("enter\n");
-       del_timer_sync(&rs_priv->rate_scale_flush);
-       kfree(rs_priv);
+       del_timer_sync(&rs_sta->rate_scale_flush);
+       kfree(rs_sta);
        IWL_DEBUG_RATE("leave\n");
 }
 
@@ -429,17 +418,19 @@ static int rs_adjust_next_rate(struct iwl3945_priv *priv, int rate)
 {
        int next_rate = iwl3945_get_prev_ieee_rate(rate);
 
-       switch (priv->phymode) {
-       case MODE_IEEE80211A:
+       switch (priv->band) {
+       case IEEE80211_BAND_5GHZ:
                if (rate == IWL_RATE_12M_INDEX)
                        next_rate = IWL_RATE_9M_INDEX;
                else if (rate == IWL_RATE_6M_INDEX)
                        next_rate = IWL_RATE_6M_INDEX;
                break;
+/* XXX cannot be invoked in current mac80211 so not a regression
        case MODE_IEEE80211B:
                if (rate == IWL_RATE_11M_INDEX_TABLE)
                        next_rate = IWL_RATE_5M_INDEX_TABLE;
                break;
+ */
        default:
                break;
        }
@@ -464,30 +455,33 @@ static void rs_tx_status(void *priv_rate,
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
        struct iwl3945_priv *priv = (struct iwl3945_priv *)priv_rate;
        struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
-       struct iwl3945_rate_scale_priv *rs_priv;
+       struct iwl3945_rs_sta *rs_sta;
+       struct ieee80211_supported_band *sband;
 
        IWL_DEBUG_RATE("enter\n");
 
-       retries = tx_resp->retry_count;
+       sband = local->hw.wiphy->bands[local->hw.conf.channel->band];
 
-       first_index = tx_resp->control.tx_rate;
+
+       retries = tx_resp->retry_count;
+       first_index = tx_resp->control.tx_rate->hw_value;
        if ((first_index < 0) || (first_index >= IWL_RATE_COUNT)) {
-               IWL_DEBUG_RATE("leave: Rate out of bounds: %0x for %d\n",
-                              tx_resp->control.tx_rate, first_index);
+               IWL_DEBUG_RATE("leave: Rate out of bounds: %d\n", first_index);
                return;
        }
 
+       rcu_read_lock();
+
        sta = sta_info_get(local, hdr->addr1);
        if (!sta || !sta->rate_ctrl_priv) {
-               if (sta)
-                       sta_info_put(sta);
+               rcu_read_unlock();
                IWL_DEBUG_RATE("leave: No STA priv data to update!\n");
                return;
        }
 
-       rs_priv = (void *)sta->rate_ctrl_priv;
+       rs_sta = (void *)sta->rate_ctrl_priv;
 
-       rs_priv->tx_packets++;
+       rs_sta->tx_packets++;
 
        scale_rate_index = first_index;
        last_index = first_index;
@@ -514,8 +508,8 @@ static void rs_tx_status(void *priv_rate,
 
                /* Update this rate accounting for as many retries
                 * as was used for it (per current_count) */
-               iwl3945_collect_tx_data(rs_priv,
-                                   &rs_priv->win[scale_rate_index],
+               iwl3945_collect_tx_data(rs_sta,
+                                   &rs_sta->win[scale_rate_index],
                                    0, current_count);
                IWL_DEBUG_RATE("Update rate %d for %d retries.\n",
                               scale_rate_index, current_count);
@@ -533,42 +527,42 @@ static void rs_tx_status(void *priv_rate,
                       last_index,
                       (tx_resp->flags & IEEE80211_TX_STATUS_ACK) ?
                       "success" : "failure");
-       iwl3945_collect_tx_data(rs_priv,
-                           &rs_priv->win[last_index],
+       iwl3945_collect_tx_data(rs_sta,
+                           &rs_sta->win[last_index],
                            tx_resp->flags & IEEE80211_TX_STATUS_ACK, 1);
 
        /* We updated the rate scale window -- if its been more than
         * flush_time since the last run, schedule the flush
         * again */
-       spin_lock_irqsave(&rs_priv->lock, flags);
+       spin_lock_irqsave(&rs_sta->lock, flags);
 
-       if (!rs_priv->flush_pending &&
-           time_after(jiffies, rs_priv->last_partial_flush +
-                      rs_priv->flush_time)) {
+       if (!rs_sta->flush_pending &&
+           time_after(jiffies, rs_sta->last_partial_flush +
+                      rs_sta->flush_time)) {
 
-               rs_priv->flush_pending = 1;
-               mod_timer(&rs_priv->rate_scale_flush,
-                         jiffies + rs_priv->flush_time);
+               rs_sta->flush_pending = 1;
+               mod_timer(&rs_sta->rate_scale_flush,
+                         jiffies + rs_sta->flush_time);
        }
 
-       spin_unlock_irqrestore(&rs_priv->lock, flags);
+       spin_unlock_irqrestore(&rs_sta->lock, flags);
 
-       sta_info_put(sta);
+       rcu_read_unlock();
 
        IWL_DEBUG_RATE("leave\n");
 
        return;
 }
 
-static u16 iwl3945_get_adjacent_rate(struct iwl3945_rate_scale_priv *rs_priv,
-                                    u8 index, u16 rate_mask, int phymode)
+static u16 iwl3945_get_adjacent_rate(struct iwl3945_rs_sta *rs_sta,
+                                u8 index, u16 rate_mask, enum ieee80211_band band)
 {
        u8 high = IWL_RATE_INVALID;
        u8 low = IWL_RATE_INVALID;
 
        /* 802.11A walks to the next literal adjacent rate in
         * the rate table */
-       if (unlikely(phymode == MODE_IEEE80211A)) {
+       if (unlikely(band == IEEE80211_BAND_5GHZ)) {
                int i;
                u32 mask;
 
@@ -595,7 +589,7 @@ static u16 iwl3945_get_adjacent_rate(struct iwl3945_rate_scale_priv *rs_priv,
 
        low = index;
        while (low != IWL_RATE_INVALID) {
-               if (rs_priv->tgg)
+               if (rs_sta->tgg)
                        low = iwl3945_rates[low].prev_rs_tgg;
                else
                        low = iwl3945_rates[low].prev_rs;
@@ -608,7 +602,7 @@ static u16 iwl3945_get_adjacent_rate(struct iwl3945_rate_scale_priv *rs_priv,
 
        high = index;
        while (high != IWL_RATE_INVALID) {
-               if (rs_priv->tgg)
+               if (rs_sta->tgg)
                        high = iwl3945_rates[high].next_rs_tgg;
                else
                        high = iwl3945_rates[high].next_rs;
@@ -639,18 +633,19 @@ static u16 iwl3945_get_adjacent_rate(struct iwl3945_rate_scale_priv *rs_priv,
  *
  */
 static void rs_get_rate(void *priv_rate, struct net_device *dev,
-                       struct ieee80211_hw_mode *mode, struct sk_buff *skb,
+                       struct ieee80211_supported_band *sband,
+                       struct sk_buff *skb,
                        struct rate_selection *sel)
 {
        u8 low = IWL_RATE_INVALID;
        u8 high = IWL_RATE_INVALID;
        u16 high_low;
        int index;
-       struct iwl3945_rate_scale_priv *rs_priv;
+       struct iwl3945_rs_sta *rs_sta;
        struct iwl3945_rate_scale_data *window = NULL;
-       int current_tpt = IWL_INVALID_VALUE;
-       int low_tpt = IWL_INVALID_VALUE;
-       int high_tpt = IWL_INVALID_VALUE;
+       int current_tpt = IWL_INV_TPT;
+       int low_tpt = IWL_INV_TPT;
+       int high_tpt = IWL_INV_TPT;
        u32 fail_count;
        s8 scale_action = 0;
        unsigned long flags;
@@ -663,6 +658,8 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
 
        IWL_DEBUG_RATE("enter\n");
 
+       rcu_read_lock();
+
        sta = sta_info_get(local, hdr->addr1);
 
        /* Send management frames and broadcast/multicast data using lowest
@@ -672,22 +669,21 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
            is_multicast_ether_addr(hdr->addr1) ||
            !sta || !sta->rate_ctrl_priv) {
                IWL_DEBUG_RATE("leave: No STA priv data to update!\n");
-               sel->rate = rate_lowest(local, local->oper_hw_mode, sta);
-               if (sta)
-                       sta_info_put(sta);
+               sel->rate = rate_lowest(local, sband, sta);
+               rcu_read_unlock();
                return;
        }
 
-       rate_mask = sta->supp_rates;
-       index = min(sta->last_txrate & 0xffff, IWL_RATE_COUNT - 1);
+       rate_mask = sta->supp_rates[sband->band];
+       index = min(sta->last_txrate_idx & 0xffff, IWL_RATE_COUNT - 1);
 
-       if (priv->phymode == (u8) MODE_IEEE80211A)
+       if (sband->band == IEEE80211_BAND_5GHZ)
                rate_mask = rate_mask << IWL_FIRST_OFDM_RATE;
 
-       rs_priv = (void *)sta->rate_ctrl_priv;
+       rs_sta = (void *)sta->rate_ctrl_priv;
 
        if ((priv->iw_mode == IEEE80211_IF_TYPE_IBSS) &&
-           !rs_priv->ibss_sta_added) {
+           !rs_sta->ibss_sta_added) {
                u8 sta_id = iwl3945_hw_find_station(priv, hdr->addr1);
 
                if (sta_id == IWL_INVALID_STATION) {
@@ -697,24 +693,24 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
                                    hdr->addr1, 0, CMD_ASYNC);
                }
                if (sta_id != IWL_INVALID_STATION)
-                       rs_priv->ibss_sta_added = 1;
+                       rs_sta->ibss_sta_added = 1;
        }
 
-       spin_lock_irqsave(&rs_priv->lock, flags);
+       spin_lock_irqsave(&rs_sta->lock, flags);
 
-       if (rs_priv->start_rate != IWL_RATE_INVALID) {
-               index = rs_priv->start_rate;
-               rs_priv->start_rate = IWL_RATE_INVALID;
+       if (rs_sta->start_rate != IWL_RATE_INVALID) {
+               index = rs_sta->start_rate;
+               rs_sta->start_rate = IWL_RATE_INVALID;
        }
 
-       window = &(rs_priv->win[index]);
+       window = &(rs_sta->win[index]);
 
        fail_count = window->counter - window->success_counter;
 
        if (((fail_count <= IWL_RATE_MIN_FAILURE_TH) &&
             (window->success_counter < IWL_RATE_MIN_SUCCESS_TH))) {
-               window->average_tpt = IWL_INVALID_VALUE;
-               spin_unlock_irqrestore(&rs_priv->lock, flags);
+               window->average_tpt = IWL_INV_TPT;
+               spin_unlock_irqrestore(&rs_sta->lock, flags);
 
                IWL_DEBUG_RATE("Invalid average_tpt on rate %d: "
                               "counter: %d, success_counter: %d, "
@@ -722,46 +718,43 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
                               index,
                               window->counter,
                               window->success_counter,
-                              rs_priv->expected_tpt ? "not " : "");
+                              rs_sta->expected_tpt ? "not " : "");
                goto out;
 
        }
 
        window->average_tpt = ((window->success_ratio *
-                               rs_priv->expected_tpt[index] + 64) / 128);
+                               rs_sta->expected_tpt[index] + 64) / 128);
        current_tpt = window->average_tpt;
 
-       high_low = iwl3945_get_adjacent_rate(rs_priv, index, rate_mask,
-                                        local->hw.conf.phymode);
+       high_low = iwl3945_get_adjacent_rate(rs_sta, index, rate_mask,
+                                            sband->band);
        low = high_low & 0xff;
        high = (high_low >> 8) & 0xff;
 
        if (low != IWL_RATE_INVALID)
-               low_tpt = rs_priv->win[low].average_tpt;
+               low_tpt = rs_sta->win[low].average_tpt;
 
        if (high != IWL_RATE_INVALID)
-               high_tpt = rs_priv->win[high].average_tpt;
+               high_tpt = rs_sta->win[high].average_tpt;
 
-       spin_unlock_irqrestore(&rs_priv->lock, flags);
+       spin_unlock_irqrestore(&rs_sta->lock, flags);
 
        scale_action = 1;
 
        if ((window->success_ratio < IWL_RATE_DECREASE_TH) || !current_tpt) {
                IWL_DEBUG_RATE("decrease rate because of low success_ratio\n");
                scale_action = -1;
-       } else if ((low_tpt == IWL_INVALID_VALUE) &&
-                  (high_tpt == IWL_INVALID_VALUE))
+       } else if ((low_tpt == IWL_INV_TPT) && (high_tpt == IWL_INV_TPT))
                scale_action = 1;
-       else if ((low_tpt != IWL_INVALID_VALUE) &&
-                  (high_tpt != IWL_INVALID_VALUE)
-                  && (low_tpt < current_tpt)
-                  && (high_tpt < current_tpt)) {
+       else if ((low_tpt != IWL_INV_TPT) && (high_tpt != IWL_INV_TPT) &&
+                (low_tpt < current_tpt) && (high_tpt < current_tpt)) {
                IWL_DEBUG_RATE("No action -- low [%d] & high [%d] < "
                               "current_tpt [%d]\n",
                               low_tpt, high_tpt, current_tpt);
                scale_action = 0;
        } else {
-               if (high_tpt != IWL_INVALID_VALUE) {
+               if (high_tpt != IWL_INV_TPT) {
                        if (high_tpt > current_tpt)
                                scale_action = 1;
                        else {
@@ -769,7 +762,7 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
                                    ("decrease rate because of high tpt\n");
                                scale_action = -1;
                        }
-               } else if (low_tpt != IWL_INVALID_VALUE) {
+               } else if (low_tpt != IWL_INV_TPT) {
                        if (low_tpt > current_tpt) {
                                IWL_DEBUG_RATE
                                    ("decrease rate because of low tpt\n");
@@ -810,17 +803,17 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
 
  out:
 
-       sta->last_txrate = index;
-       if (priv->phymode == (u8) MODE_IEEE80211A)
-               sta->txrate = sta->last_txrate - IWL_FIRST_OFDM_RATE;
+       sta->last_txrate_idx = index;
+       if (sband->band == IEEE80211_BAND_5GHZ)
+               sta->txrate_idx = sta->last_txrate_idx - IWL_FIRST_OFDM_RATE;
        else
-               sta->txrate = sta->last_txrate;
+               sta->txrate_idx = sta->last_txrate_idx;
 
-       sta_info_put(sta);
+       rcu_read_unlock();
 
        IWL_DEBUG_RATE("leave: %d\n", index);
 
-       sel->rate = &priv->ieee_rates[index];
+       sel->rate = &sband->bitrates[sta->txrate_idx];
 }
 
 static struct rate_control_ops rs_ops = {
@@ -840,7 +833,7 @@ int iwl3945_fill_rs_info(struct ieee80211_hw *hw, char *buf, u8 sta_id)
 {
        struct ieee80211_local *local = hw_to_local(hw);
        struct iwl3945_priv *priv = hw->priv;
-       struct iwl3945_rate_scale_priv *rs_priv;
+       struct iwl3945_rs_sta *rs_sta;
        struct sta_info *sta;
        unsigned long flags;
        int count = 0, i;
@@ -848,18 +841,20 @@ int iwl3945_fill_rs_info(struct ieee80211_hw *hw, char *buf, u8 sta_id)
        unsigned long now = jiffies;
        u32 max_time = 0;
 
+       rcu_read_lock();
+
        sta = sta_info_get(local, priv->stations[sta_id].sta.sta.addr);
        if (!sta || !sta->rate_ctrl_priv) {
-               if (sta) {
-                       sta_info_put(sta);
+               if (sta)
                        IWL_DEBUG_RATE("leave - no private rate data!\n");
-               else
+               else
                        IWL_DEBUG_RATE("leave - no station!\n");
+               rcu_read_unlock();
                return sprintf(buf, "station %d not found\n", sta_id);
        }
 
-       rs_priv = (void *)sta->rate_ctrl_priv;
-       spin_lock_irqsave(&rs_priv->lock, flags);
+       rs_sta = (void *)sta->rate_ctrl_priv;
+       spin_lock_irqsave(&rs_sta->lock, flags);
        i = IWL_RATE_54M_INDEX;
        while (1) {
                u64 mask;
@@ -871,15 +866,16 @@ int iwl3945_fill_rs_info(struct ieee80211_hw *hw, char *buf, u8 sta_id)
                mask = (1ULL << (IWL_RATE_MAX_WINDOW - 1));
                for (j = 0; j < IWL_RATE_MAX_WINDOW; j++, mask >>= 1)
                        buf[count++] =
-                           (rs_priv->win[i].data & mask) ? '1' : '0';
+                           (rs_sta->win[i].data & mask) ? '1' : '0';
 
-               samples += rs_priv->win[i].counter;
-               good += rs_priv->win[i].success_counter;
-               success += rs_priv->win[i].success_counter * iwl3945_rates[i].ieee;
+               samples += rs_sta->win[i].counter;
+               good += rs_sta->win[i].success_counter;
+               success += rs_sta->win[i].success_counter *
+                                               iwl3945_rates[i].ieee;
 
-               if (rs_priv->win[i].stamp) {
+               if (rs_sta->win[i].stamp) {
                        int delta =
-                           jiffies_to_msecs(now - rs_priv->win[i].stamp);
+                           jiffies_to_msecs(now - rs_sta->win[i].stamp);
 
                        if (delta > max_time)
                                max_time = delta;
@@ -893,8 +889,8 @@ int iwl3945_fill_rs_info(struct ieee80211_hw *hw, char *buf, u8 sta_id)
                        break;
                i = j;
        }
-       spin_unlock_irqrestore(&rs_priv->lock, flags);
-       sta_info_put(sta);
+       spin_unlock_irqrestore(&rs_sta->lock, flags);
+       rcu_read_unlock();
 
        /* Display the average rate of all samples taken.
         *
@@ -919,7 +915,7 @@ void iwl3945_rate_scale_init(struct ieee80211_hw *hw, s32 sta_id)
        s32 rssi = 0;
        unsigned long flags;
        struct ieee80211_local *local = hw_to_local(hw);
-       struct iwl3945_rate_scale_priv *rs_priv;
+       struct iwl3945_rs_sta *rs_sta;
        struct sta_info *sta;
 
        IWL_DEBUG_RATE("enter\n");
@@ -931,41 +927,40 @@ void iwl3945_rate_scale_init(struct ieee80211_hw *hw, s32 sta_id)
                return;
        }
 
+       rcu_read_lock();
+
        sta = sta_info_get(local, priv->stations[sta_id].sta.sta.addr);
        if (!sta || !sta->rate_ctrl_priv) {
-               if (sta)
-                       sta_info_put(sta);
                IWL_DEBUG_RATE("leave - no private rate data!\n");
+               rcu_read_unlock();
                return;
        }
 
-       rs_priv = (void *)sta->rate_ctrl_priv;
+       rs_sta = (void *)sta->rate_ctrl_priv;
 
-       spin_lock_irqsave(&rs_priv->lock, flags);
+       spin_lock_irqsave(&rs_sta->lock, flags);
 
-       rs_priv->tgg = 0;
-       switch (priv->phymode) {
-       case MODE_IEEE80211G:
+       rs_sta->tgg = 0;
+       switch (priv->band) {
+       case IEEE80211_BAND_2GHZ:
+               /* TODO: this always does G, not a regression */
                if (priv->active_rxon.flags & RXON_FLG_TGG_PROTECT_MSK) {
-                       rs_priv->tgg = 1;
-                       rs_priv->expected_tpt = iwl3945_expected_tpt_g_prot;
+                       rs_sta->tgg = 1;
+                       rs_sta->expected_tpt = iwl3945_expected_tpt_g_prot;
                } else
-                       rs_priv->expected_tpt = iwl3945_expected_tpt_g;
+                       rs_sta->expected_tpt = iwl3945_expected_tpt_g;
                break;
 
-       case MODE_IEEE80211A:
-               rs_priv->expected_tpt = iwl3945_expected_tpt_a;
+       case IEEE80211_BAND_5GHZ:
+               rs_sta->expected_tpt = iwl3945_expected_tpt_a;
                break;
-
-       default:
-               IWL_WARNING("Invalid phymode.  Defaulting to 802.11b\n");
-       case MODE_IEEE80211B:
-               rs_priv->expected_tpt = iwl3945_expected_tpt_b;
+       case IEEE80211_NUM_BANDS:
+               BUG();
                break;
        }
 
-       sta_info_put(sta);
-       spin_unlock_irqrestore(&rs_priv->lock, flags);
+       rcu_read_unlock();
+       spin_unlock_irqrestore(&rs_sta->lock, flags);
 
        rssi = priv->last_rx_rssi;
        if (rssi == 0)
@@ -973,19 +968,19 @@ void iwl3945_rate_scale_init(struct ieee80211_hw *hw, s32 sta_id)
 
        IWL_DEBUG(IWL_DL_INFO | IWL_DL_RATE, "Network RSSI: %d\n", rssi);
 
-       rs_priv->start_rate = iwl3945_get_rate_index_by_rssi(rssi, priv->phymode);
+       rs_sta->start_rate = iwl3945_get_rate_index_by_rssi(rssi, priv->band);
 
        IWL_DEBUG_RATE("leave: rssi %d assign rate index: "
-                      "%d (plcp 0x%x)\n", rssi, rs_priv->start_rate,
-                      iwl3945_rates[rs_priv->start_rate].plcp);
+                      "%d (plcp 0x%x)\n", rssi, rs_sta->start_rate,
+                      iwl3945_rates[rs_sta->start_rate].plcp);
 }
 
-void iwl3945_rate_control_register(struct ieee80211_hw *hw)
+int iwl3945_rate_control_register(void)
 {
-       ieee80211_rate_control_register(&rs_ops);
+       return ieee80211_rate_control_register(&rs_ops);
 }
 
-void iwl3945_rate_control_unregister(struct ieee80211_hw *hw)
+void iwl3945_rate_control_unregister(void)
 {
        ieee80211_rate_control_unregister(&rs_ops);
 }