]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/net/wireless/libertas/cmd.c
libertas: make lbs_cmd() usage nicer
[linux-2.6-omap-h63xx.git] / drivers / net / wireless / libertas / cmd.c
index 4a8f5dc70239c48a0aebda7e23591b9a5d4bd578..c7c226c09502f05b88f87e54d8ef7df840d2a3ee 100644 (file)
 #include "wext.h"
 
 static void cleanup_cmdnode(struct cmd_ctrl_node *ptempnode);
+struct cmd_ctrl_node *lbs_get_cmd_ctrl_node(struct lbs_private *priv);
+void lbs_set_cmd_ctrl_node(struct lbs_private *priv,
+                   struct cmd_ctrl_node *ptempnode,
+                   u16 wait_option, void *pdata_buf);
+
 
 static u16 commands_allowed_in_ps[] = {
-       cmd_802_11_rssi,
+       CMD_802_11_RSSI,
 };
 
 /**
@@ -37,53 +42,48 @@ static u8 is_command_allowed_in_ps(__le16 command)
        return 0;
 }
 
-static int wlan_cmd_hw_spec(wlan_private * priv, struct cmd_ds_command *cmd)
+static int lbs_cmd_hw_spec(struct lbs_private *priv, struct cmd_ds_command *cmd)
 {
        struct cmd_ds_get_hw_spec *hwspec = &cmd->params.hwspec;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_get_hw_spec);
+       cmd->command = cpu_to_le16(CMD_GET_HW_SPEC);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_get_hw_spec) + S_DS_GEN);
-       memcpy(hwspec->permanentaddr, priv->adapter->current_addr, ETH_ALEN);
+       memcpy(hwspec->permanentaddr, priv->current_addr, ETH_ALEN);
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_ps_mode(wlan_private * priv,
+static int lbs_cmd_802_11_ps_mode(struct lbs_private *priv,
                                   struct cmd_ds_command *cmd,
                                   u16 cmd_action)
 {
        struct cmd_ds_802_11_ps_mode *psm = &cmd->params.psmode;
-       wlan_adapter *adapter = priv->adapter;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_ps_mode);
+       cmd->command = cpu_to_le16(CMD_802_11_PS_MODE);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_ps_mode) +
                                S_DS_GEN);
        psm->action = cpu_to_le16(cmd_action);
        psm->multipledtim = 0;
        switch (cmd_action) {
-       case cmd_subcmd_enter_ps:
+       case CMD_SUBCMD_ENTER_PS:
                lbs_deb_cmd("PS command:" "SubCode- Enter PS\n");
-               lbs_deb_cmd("locallisteninterval = %d\n",
-                      adapter->locallisteninterval);
 
-               psm->locallisteninterval =
-                   cpu_to_le16(adapter->locallisteninterval);
-               psm->nullpktinterval =
-                   cpu_to_le16(adapter->nullpktinterval);
+               psm->locallisteninterval = 0;
+               psm->nullpktinterval = 0;
                psm->multipledtim =
-                   cpu_to_le16(priv->adapter->multipledtim);
+                   cpu_to_le16(MRVDRV_DEFAULT_MULTIPLE_DTIM);
                break;
 
-       case cmd_subcmd_exit_ps:
+       case CMD_SUBCMD_EXIT_PS:
                lbs_deb_cmd("PS command:" "SubCode- Exit PS\n");
                break;
 
-       case cmd_subcmd_sleep_confirmed:
+       case CMD_SUBCMD_SLEEP_CONFIRMED:
                lbs_deb_cmd("PS command: SubCode- sleep confirm\n");
                break;
 
@@ -95,13 +95,15 @@ static int wlan_cmd_802_11_ps_mode(wlan_private * priv,
        return 0;
 }
 
-static int wlan_cmd_802_11_inactivity_timeout(wlan_private * priv,
+static int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
                                              struct cmd_ds_command *cmd,
                                              u16 cmd_action, void *pdata_buf)
 {
        u16 *timeout = pdata_buf;
 
-       cmd->command = cpu_to_le16(cmd_802_11_inactivity_timeout);
+       lbs_deb_enter(LBS_DEB_CMD);
+
+       cmd->command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
        cmd->size =
            cpu_to_le16(sizeof(struct cmd_ds_802_11_inactivity_timeout)
                             + S_DS_GEN);
@@ -113,56 +115,55 @@ static int wlan_cmd_802_11_inactivity_timeout(wlan_private * priv,
        else
                cmd->params.inactivity_timeout.timeout = 0;
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_sleep_params(wlan_private * priv,
+static int lbs_cmd_802_11_sleep_params(struct lbs_private *priv,
                                        struct cmd_ds_command *cmd,
                                        u16 cmd_action)
 {
-       wlan_adapter *adapter = priv->adapter;
        struct cmd_ds_802_11_sleep_params *sp = &cmd->params.sleep_params;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
        cmd->size = cpu_to_le16((sizeof(struct cmd_ds_802_11_sleep_params)) +
                                S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_sleep_params);
+       cmd->command = cpu_to_le16(CMD_802_11_SLEEP_PARAMS);
 
-       if (cmd_action == cmd_act_get) {
-               memset(&adapter->sp, 0, sizeof(struct sleep_params));
+       if (cmd_action == CMD_ACT_GET) {
+               memset(&priv->sp, 0, sizeof(struct sleep_params));
                memset(sp, 0, sizeof(struct cmd_ds_802_11_sleep_params));
                sp->action = cpu_to_le16(cmd_action);
-       } else if (cmd_action == cmd_act_set) {
+       } else if (cmd_action == CMD_ACT_SET) {
                sp->action = cpu_to_le16(cmd_action);
-               sp->error = cpu_to_le16(adapter->sp.sp_error);
-               sp->offset = cpu_to_le16(adapter->sp.sp_offset);
-               sp->stabletime = cpu_to_le16(adapter->sp.sp_stabletime);
-               sp->calcontrol = (u8) adapter->sp.sp_calcontrol;
-               sp->externalsleepclk = (u8) adapter->sp.sp_extsleepclk;
-               sp->reserved = cpu_to_le16(adapter->sp.sp_reserved);
+               sp->error = cpu_to_le16(priv->sp.sp_error);
+               sp->offset = cpu_to_le16(priv->sp.sp_offset);
+               sp->stabletime = cpu_to_le16(priv->sp.sp_stabletime);
+               sp->calcontrol = (u8) priv->sp.sp_calcontrol;
+               sp->externalsleepclk = (u8) priv->sp.sp_extsleepclk;
+               sp->reserved = cpu_to_le16(priv->sp.sp_reserved);
        }
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_set_wep(wlan_private * priv,
+static int lbs_cmd_802_11_set_wep(struct lbs_private *priv,
                                    struct cmd_ds_command *cmd,
                                    u32 cmd_act,
                                    void * pdata_buf)
 {
        struct cmd_ds_802_11_set_wep *wep = &cmd->params.wep;
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
        struct assoc_request * assoc_req = pdata_buf;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_set_wep);
+       cmd->command = cpu_to_le16(CMD_802_11_SET_WEP);
        cmd->size = cpu_to_le16(sizeof(*wep) + S_DS_GEN);
 
-       if (cmd_act == cmd_act_add) {
+       if (cmd_act == CMD_ACT_ADD) {
                int i;
 
                if (!assoc_req) {
@@ -171,48 +172,47 @@ static int wlan_cmd_802_11_set_wep(wlan_private * priv,
                        goto done;
                }
 
-               wep->action = cpu_to_le16(cmd_act_add);
+               wep->action = cpu_to_le16(CMD_ACT_ADD);
 
                /* default tx key index */
                wep->keyindex = cpu_to_le16((u16)(assoc_req->wep_tx_keyidx &
-                                                 (u32)cmd_WEP_KEY_INDEX_MASK));
-
-               lbs_deb_cmd("Tx key Index: %u\n", le16_to_cpu(wep->keyindex));
+                                                 (u32)CMD_WEP_KEY_INDEX_MASK));
 
                /* Copy key types and material to host command structure */
                for (i = 0; i < 4; i++) {
-                       struct WLAN_802_11_KEY * pkey = &assoc_req->wep_keys[i];
+                       struct enc_key * pkey = &assoc_req->wep_keys[i];
 
                        switch (pkey->len) {
                        case KEY_LEN_WEP_40:
-                               wep->keytype[i] =
-                                       cpu_to_le16(cmd_type_wep_40_bit);
+                               wep->keytype[i] = CMD_TYPE_WEP_40_BIT;
                                memmove(&wep->keymaterial[i], pkey->key,
                                        pkey->len);
+                               lbs_deb_cmd("SET_WEP: add key %d (40 bit)\n", i);
                                break;
                        case KEY_LEN_WEP_104:
-                               wep->keytype[i] =
-                                       cpu_to_le16(cmd_type_wep_104_bit);
+                               wep->keytype[i] = CMD_TYPE_WEP_104_BIT;
                                memmove(&wep->keymaterial[i], pkey->key,
                                        pkey->len);
+                               lbs_deb_cmd("SET_WEP: add key %d (104 bit)\n", i);
                                break;
                        case 0:
                                break;
                        default:
-                               lbs_deb_cmd("Invalid WEP key %d length of %d\n",
+                               lbs_deb_cmd("SET_WEP: invalid key %d, length %d\n",
                                       i, pkey->len);
                                ret = -1;
                                goto done;
                                break;
                        }
                }
-       } else if (cmd_act == cmd_act_remove) {
+       } else if (cmd_act == CMD_ACT_REMOVE) {
                /* ACT_REMOVE clears _all_ WEP keys */
-               wep->action = cpu_to_le16(cmd_act_remove);
+               wep->action = cpu_to_le16(CMD_ACT_REMOVE);
 
                /* default tx key index */
-               wep->keyindex = cpu_to_le16((u16)(adapter->wep_tx_keyidx &
-                                                 (u32)cmd_WEP_KEY_INDEX_MASK));
+               wep->keyindex = cpu_to_le16((u16)(priv->wep_tx_keyidx &
+                                                 (u32)CMD_WEP_KEY_INDEX_MASK));
+               lbs_deb_cmd("SET_WEP: remove key %d\n", priv->wep_tx_keyidx);
        }
 
        ret = 0;
@@ -222,7 +222,7 @@ done:
        return ret;
 }
 
-static int wlan_cmd_802_11_enable_rsn(wlan_private * priv,
+static int lbs_cmd_802_11_enable_rsn(struct lbs_private *priv,
                                      struct cmd_ds_command *cmd,
                                      u16 cmd_action,
                                      void * pdata_buf)
@@ -232,15 +232,16 @@ static int wlan_cmd_802_11_enable_rsn(wlan_private * priv,
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_enable_rsn);
+       cmd->command = cpu_to_le16(CMD_802_11_ENABLE_RSN);
        cmd->size = cpu_to_le16(sizeof(*penableRSN) + S_DS_GEN);
        penableRSN->action = cpu_to_le16(cmd_action);
 
-       if (cmd_action == cmd_act_set) {
+       if (cmd_action == CMD_ACT_SET) {
                if (*enable)
-                       penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
+                       penableRSN->enable = cpu_to_le16(CMD_ENABLE_RSN);
                else
-                       penableRSN->enable = cpu_to_le16(cmd_disable_rsn);
+                       penableRSN->enable = cpu_to_le16(CMD_DISABLE_RSN);
+               lbs_deb_cmd("ENABLE_RSN: %d\n", *enable);
        }
 
        lbs_deb_leave(LBS_DEB_CMD);
@@ -248,10 +249,56 @@ static int wlan_cmd_802_11_enable_rsn(wlan_private * priv,
 }
 
 
+static ssize_t lbs_tlv_size(const u8 *tlv, u16 size)
+{
+       ssize_t pos = 0;
+       struct mrvlietypesheader *tlv_h;
+       while (pos < size) {
+               u16 length;
+               tlv_h = (struct mrvlietypesheader *) tlv;
+               if (tlv_h->len == 0)
+                       return pos;
+               length = le16_to_cpu(tlv_h->len) +
+                       sizeof(struct mrvlietypesheader);
+               pos += length;
+               tlv += length;
+       }
+       return pos;
+}
+
+
+static void lbs_cmd_802_11_subscribe_event(struct lbs_private *priv,
+       struct cmd_ds_command *cmd, u16 cmd_action,
+       void *pdata_buf)
+{
+       struct cmd_ds_802_11_subscribe_event *events =
+               (struct cmd_ds_802_11_subscribe_event *) pdata_buf;
+
+       /* pdata_buf points to a struct cmd_ds_802_11_subscribe_event and room
+        * for various Marvell TLVs */
+
+       lbs_deb_enter(LBS_DEB_CMD);
+
+       cmd->size = cpu_to_le16(sizeof(*events)
+                       - sizeof(events->tlv)
+                       + S_DS_GEN);
+       cmd->params.subscribe_event.action = cpu_to_le16(cmd_action);
+       if (cmd_action == CMD_ACT_GET) {
+               cmd->params.subscribe_event.events = 0;
+       } else {
+               ssize_t sz = lbs_tlv_size(events->tlv, sizeof(events->tlv));
+               cmd->size = cpu_to_le16(le16_to_cpu(cmd->size) + sz);
+               cmd->params.subscribe_event.events = events->events;
+               memcpy(cmd->params.subscribe_event.tlv, events->tlv, sz);
+       }
+
+       lbs_deb_leave(LBS_DEB_CMD);
+}
+
 static void set_one_wpa_key(struct MrvlIEtype_keyParamSet * pkeyparamset,
-                            struct WLAN_802_11_KEY * pkey)
+                            struct enc_key * pkey)
 {
-       pkeyparamset->keytypeid = cpu_to_le16(pkey->type);
+       lbs_deb_enter(LBS_DEB_CMD);
 
        if (pkey->flags & KEY_INFO_WPA_ENABLED) {
                pkeyparamset->keyinfo |= cpu_to_le16(KEY_INFO_WPA_ENABLED);
@@ -264,15 +311,17 @@ static void set_one_wpa_key(struct MrvlIEtype_keyParamSet * pkeyparamset,
        }
 
        pkeyparamset->type = cpu_to_le16(TLV_TYPE_KEY_MATERIAL);
+       pkeyparamset->keytypeid = cpu_to_le16(pkey->type);
        pkeyparamset->keylen = cpu_to_le16(pkey->len);
        memcpy(pkeyparamset->key, pkey->key, pkey->len);
        pkeyparamset->length = cpu_to_le16(  sizeof(pkeyparamset->keytypeid)
                                                + sizeof(pkeyparamset->keyinfo)
                                                + sizeof(pkeyparamset->keylen)
                                                + sizeof(pkeyparamset->key));
+       lbs_deb_leave(LBS_DEB_CMD);
 }
 
-static int wlan_cmd_802_11_key_material(wlan_private * priv,
+static int lbs_cmd_802_11_key_material(struct lbs_private *priv,
                                        struct cmd_ds_command *cmd,
                                        u16 cmd_action,
                                        u32 cmd_oid, void *pdata_buf)
@@ -285,10 +334,10 @@ static int wlan_cmd_802_11_key_material(wlan_private * priv,
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_key_material);
+       cmd->command = cpu_to_le16(CMD_802_11_KEY_MATERIAL);
        pkeymaterial->action = cpu_to_le16(cmd_action);
 
-       if (cmd_action == cmd_act_get) {
+       if (cmd_action == CMD_ACT_GET) {
                cmd->size = cpu_to_le16(S_DS_GEN + sizeof (pkeymaterial->action));
                ret = 0;
                goto done;
@@ -319,61 +368,67 @@ done:
        return ret;
 }
 
-static int wlan_cmd_802_11_reset(wlan_private * priv,
+static int lbs_cmd_802_11_reset(struct lbs_private *priv,
                                 struct cmd_ds_command *cmd, int cmd_action)
 {
        struct cmd_ds_802_11_reset *reset = &cmd->params.reset;
 
-       cmd->command = cpu_to_le16(cmd_802_11_reset);
+       lbs_deb_enter(LBS_DEB_CMD);
+
+       cmd->command = cpu_to_le16(CMD_802_11_RESET);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_reset) + S_DS_GEN);
        reset->action = cpu_to_le16(cmd_action);
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_get_log(wlan_private * priv,
+static int lbs_cmd_802_11_get_log(struct lbs_private *priv,
                                   struct cmd_ds_command *cmd)
 {
-       cmd->command = cpu_to_le16(cmd_802_11_get_log);
+       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->command = cpu_to_le16(CMD_802_11_GET_LOG);
        cmd->size =
                cpu_to_le16(sizeof(struct cmd_ds_802_11_get_log) + S_DS_GEN);
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_get_stat(wlan_private * priv,
+static int lbs_cmd_802_11_get_stat(struct lbs_private *priv,
                                    struct cmd_ds_command *cmd)
 {
-       cmd->command = cpu_to_le16(cmd_802_11_get_stat);
+       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->command = cpu_to_le16(CMD_802_11_GET_STAT);
        cmd->size =
            cpu_to_le16(sizeof(struct cmd_ds_802_11_get_stat) + S_DS_GEN);
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
+static int lbs_cmd_802_11_snmp_mib(struct lbs_private *priv,
                                    struct cmd_ds_command *cmd,
                                    int cmd_action,
                                    int cmd_oid, void *pdata_buf)
 {
        struct cmd_ds_802_11_snmp_mib *pSNMPMIB = &cmd->params.smib;
-       wlan_adapter *adapter = priv->adapter;
        u8 ucTemp;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
        lbs_deb_cmd("SNMP_CMD: cmd_oid = 0x%x\n", cmd_oid);
 
-       cmd->command = cpu_to_le16(cmd_802_11_snmp_mib);
+       cmd->command = cpu_to_le16(CMD_802_11_SNMP_MIB);
        cmd->size = cpu_to_le16(sizeof(*pSNMPMIB) + S_DS_GEN);
 
        switch (cmd_oid) {
        case OID_802_11_INFRASTRUCTURE_MODE:
        {
                u8 mode = (u8) (size_t) pdata_buf;
-               pSNMPMIB->querytype = cpu_to_le16(cmd_act_set);
-               pSNMPMIB->oid = cpu_to_le16((u16) desired_bsstype_i);
-               pSNMPMIB->bufsize = sizeof(u8);
+               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
+               pSNMPMIB->oid = cpu_to_le16((u16) DESIRED_BSSTYPE_I);
+               pSNMPMIB->bufsize = cpu_to_le16(sizeof(u8));
                if (mode == IW_MODE_ADHOC) {
                        ucTemp = SNMP_MIB_VALUE_ADHOC;
                } else {
@@ -390,11 +445,11 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                {
                        u32 ulTemp;
 
-                       pSNMPMIB->oid = cpu_to_le16((u16) dot11d_i);
+                       pSNMPMIB->oid = cpu_to_le16((u16) DOT11D_I);
 
-                       if (cmd_action == cmd_act_set) {
-                               pSNMPMIB->querytype = cmd_act_set;
-                               pSNMPMIB->bufsize = sizeof(u16);
+                       if (cmd_action == CMD_ACT_SET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
+                               pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
                                ulTemp = *(u32 *)pdata_buf;
                                *((__le16 *)(pSNMPMIB->value)) =
                                    cpu_to_le16((u16) ulTemp);
@@ -406,12 +461,12 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                {
                        u32 ulTemp;
 
-                       pSNMPMIB->oid = cpu_to_le16((u16) fragthresh_i);
+                       pSNMPMIB->oid = cpu_to_le16((u16) FRAGTHRESH_I);
 
-                       if (cmd_action == cmd_act_get) {
-                               pSNMPMIB->querytype = cpu_to_le16(cmd_act_get);
-                       } else if (cmd_action == cmd_act_set) {
-                               pSNMPMIB->querytype = cpu_to_le16(cmd_act_set);
+                       if (cmd_action == CMD_ACT_GET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_GET);
+                       } else if (cmd_action == CMD_ACT_SET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
                                pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
                                ulTemp = *((u32 *) pdata_buf);
                                *((__le16 *)(pSNMPMIB->value)) =
@@ -426,12 +481,12 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                {
 
                        u32 ulTemp;
-                       pSNMPMIB->oid = le16_to_cpu((u16) rtsthresh_i);
+                       pSNMPMIB->oid = cpu_to_le16(RTSTHRESH_I);
 
-                       if (cmd_action == cmd_act_get) {
-                               pSNMPMIB->querytype = cpu_to_le16(cmd_act_get);
-                       } else if (cmd_action == cmd_act_set) {
-                               pSNMPMIB->querytype = cpu_to_le16(cmd_act_set);
+                       if (cmd_action == CMD_ACT_GET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_GET);
+                       } else if (cmd_action == CMD_ACT_SET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
                                pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
                                ulTemp = *((u32 *)pdata_buf);
                                *(__le16 *)(pSNMPMIB->value) =
@@ -441,15 +496,15 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                        break;
                }
        case OID_802_11_TX_RETRYCOUNT:
-               pSNMPMIB->oid = cpu_to_le16((u16) short_retrylim_i);
+               pSNMPMIB->oid = cpu_to_le16((u16) SHORT_RETRYLIM_I);
 
-               if (cmd_action == cmd_act_get) {
-                       pSNMPMIB->querytype = cpu_to_le16(cmd_act_get);
-               } else if (cmd_action == cmd_act_set) {
-                       pSNMPMIB->querytype = cpu_to_le16(cmd_act_set);
+               if (cmd_action == CMD_ACT_GET) {
+                       pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_GET);
+               } else if (cmd_action == CMD_ACT_SET) {
+                       pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
                        pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
                        *((__le16 *)(pSNMPMIB->value)) =
-                           cpu_to_le16((u16) adapter->txretrycount);
+                           cpu_to_le16((u16) priv->txretrycount);
                }
 
                break;
@@ -463,7 +518,7 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
               le16_to_cpu(cmd->seqnum), le16_to_cpu(cmd->result));
 
        lbs_deb_cmd(
-              "SNMP_CMD: action=0x%x, oid=0x%x, oidsize=0x%x, value=0x%x\n",
+              "SNMP_CMD: action 0x%x, oid 0x%x, oidsize 0x%x, value 0x%x\n",
               le16_to_cpu(pSNMPMIB->querytype), le16_to_cpu(pSNMPMIB->oid),
               le16_to_cpu(pSNMPMIB->bufsize),
               le16_to_cpu(*(__le16 *) pSNMPMIB->value));
@@ -472,11 +527,10 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
        return 0;
 }
 
-static int wlan_cmd_802_11_radio_control(wlan_private * priv,
+static int lbs_cmd_802_11_radio_control(struct lbs_private *priv,
                                         struct cmd_ds_command *cmd,
                                         int cmd_action)
 {
-       wlan_adapter *adapter = priv->adapter;
        struct cmd_ds_802_11_radio_control *pradiocontrol = &cmd->params.radio;
 
        lbs_deb_enter(LBS_DEB_CMD);
@@ -484,26 +538,26 @@ static int wlan_cmd_802_11_radio_control(wlan_private * priv,
        cmd->size =
            cpu_to_le16((sizeof(struct cmd_ds_802_11_radio_control)) +
                             S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_radio_control);
+       cmd->command = cpu_to_le16(CMD_802_11_RADIO_CONTROL);
 
        pradiocontrol->action = cpu_to_le16(cmd_action);
 
-       switch (adapter->preamble) {
-       case cmd_type_short_preamble:
+       switch (priv->preamble) {
+       case CMD_TYPE_SHORT_PREAMBLE:
                pradiocontrol->control = cpu_to_le16(SET_SHORT_PREAMBLE);
                break;
 
-       case cmd_type_long_preamble:
+       case CMD_TYPE_LONG_PREAMBLE:
                pradiocontrol->control = cpu_to_le16(SET_LONG_PREAMBLE);
                break;
 
-       case cmd_type_auto_preamble:
+       case CMD_TYPE_AUTO_PREAMBLE:
        default:
                pradiocontrol->control = cpu_to_le16(SET_AUTO_PREAMBLE);
                break;
        }
 
-       if (adapter->radioon)
+       if (priv->radioon)
                pradiocontrol->control |= cpu_to_le16(TURN_ON_RF);
        else
                pradiocontrol->control &= cpu_to_le16(~TURN_ON_RF);
@@ -512,7 +566,7 @@ static int wlan_cmd_802_11_radio_control(wlan_private * priv,
        return 0;
 }
 
-static int wlan_cmd_802_11_rf_tx_power(wlan_private * priv,
+static int lbs_cmd_802_11_rf_tx_power(struct lbs_private *priv,
                                       struct cmd_ds_command *cmd,
                                       u16 cmd_action, void *pdata_buf)
 {
@@ -523,7 +577,7 @@ static int wlan_cmd_802_11_rf_tx_power(wlan_private * priv,
 
        cmd->size =
            cpu_to_le16((sizeof(struct cmd_ds_802_11_rf_tx_power)) + S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_rf_tx_power);
+       cmd->command = cpu_to_le16(CMD_802_11_RF_TX_POWER);
        prtp->action = cpu_to_le16(cmd_action);
 
        lbs_deb_cmd("RF_TX_POWER_CMD: size:%d cmd:0x%x Act:%d\n",
@@ -531,23 +585,23 @@ static int wlan_cmd_802_11_rf_tx_power(wlan_private * priv,
                    le16_to_cpu(prtp->action));
 
        switch (cmd_action) {
-       case cmd_act_tx_power_opt_get:
-               prtp->action = cpu_to_le16(cmd_act_get);
+       case CMD_ACT_TX_POWER_OPT_GET:
+               prtp->action = cpu_to_le16(CMD_ACT_GET);
                prtp->currentlevel = 0;
                break;
 
-       case cmd_act_tx_power_opt_set_high:
-               prtp->action = cpu_to_le16(cmd_act_set);
-               prtp->currentlevel = cpu_to_le16(cmd_act_tx_power_index_high);
+       case CMD_ACT_TX_POWER_OPT_SET_HIGH:
+               prtp->action = cpu_to_le16(CMD_ACT_SET);
+               prtp->currentlevel = cpu_to_le16(CMD_ACT_TX_POWER_INDEX_HIGH);
                break;
 
-       case cmd_act_tx_power_opt_set_mid:
-               prtp->action = cpu_to_le16(cmd_act_set);
-               prtp->currentlevel = cpu_to_le16(cmd_act_tx_power_index_mid);
+       case CMD_ACT_TX_POWER_OPT_SET_MID:
+               prtp->action = cpu_to_le16(CMD_ACT_SET);
+               prtp->currentlevel = cpu_to_le16(CMD_ACT_TX_POWER_INDEX_MID);
                break;
 
-       case cmd_act_tx_power_opt_set_low:
-               prtp->action = cpu_to_le16(cmd_act_set);
+       case CMD_ACT_TX_POWER_OPT_SET_LOW:
+               prtp->action = cpu_to_le16(CMD_ACT_SET);
                prtp->currentlevel = cpu_to_le16(*((u16 *) pdata_buf));
                break;
        }
@@ -556,148 +610,149 @@ static int wlan_cmd_802_11_rf_tx_power(wlan_private * priv,
        return 0;
 }
 
-static int wlan_cmd_802_11_rf_antenna(wlan_private * priv,
+static int lbs_cmd_802_11_monitor_mode(struct lbs_private *priv,
                                      struct cmd_ds_command *cmd,
                                      u16 cmd_action, void *pdata_buf)
 {
-       struct cmd_ds_802_11_rf_antenna *rant = &cmd->params.rant;
+       struct cmd_ds_802_11_monitor_mode *monitor = &cmd->params.monitor;
 
-       cmd->command = cpu_to_le16(cmd_802_11_rf_antenna);
-       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rf_antenna) +
-                               S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_MONITOR_MODE);
+       cmd->size =
+           cpu_to_le16(sizeof(struct cmd_ds_802_11_monitor_mode) +
+                            S_DS_GEN);
 
-       rant->action = cpu_to_le16(cmd_action);
-       if ((cmd_action == cmd_act_set_rx) || (cmd_action == cmd_act_set_tx)) {
-               rant->antennamode = cpu_to_le16((u16) (*(u32 *) pdata_buf));
+       monitor->action = cpu_to_le16(cmd_action);
+       if (cmd_action == CMD_ACT_SET) {
+               monitor->mode =
+                   cpu_to_le16((u16) (*(u32 *) pdata_buf));
        }
 
        return 0;
 }
 
-static int wlan_cmd_802_11_rate_adapt_rateset(wlan_private * priv,
+static int lbs_cmd_802_11_rate_adapt_rateset(struct lbs_private *priv,
                                              struct cmd_ds_command *cmd,
                                              u16 cmd_action)
 {
        struct cmd_ds_802_11_rate_adapt_rateset
        *rateadapt = &cmd->params.rateset;
-       wlan_adapter *adapter = priv->adapter;
 
+       lbs_deb_enter(LBS_DEB_CMD);
        cmd->size =
            cpu_to_le16(sizeof(struct cmd_ds_802_11_rate_adapt_rateset)
                             + S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_rate_adapt_rateset);
-
-       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->command = cpu_to_le16(CMD_802_11_RATE_ADAPT_RATESET);
 
        rateadapt->action = cpu_to_le16(cmd_action);
-       rateadapt->enablehwauto = cpu_to_le16(adapter->enablehwauto);
-       rateadapt->bitmap = cpu_to_le16(adapter->ratebitmap);
+       rateadapt->enablehwauto = cpu_to_le16(priv->enablehwauto);
+       rateadapt->bitmap = cpu_to_le16(priv->ratebitmap);
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_data_rate(wlan_private * priv,
+static int lbs_cmd_802_11_data_rate(struct lbs_private *priv,
                                     struct cmd_ds_command *cmd,
                                     u16 cmd_action)
 {
        struct cmd_ds_802_11_data_rate *pdatarate = &cmd->params.drate;
-       wlan_adapter *adapter = priv->adapter;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_data_rate) +
                             S_DS_GEN);
-
-       cmd->command = cpu_to_le16(cmd_802_11_data_rate);
-
+       cmd->command = cpu_to_le16(CMD_802_11_DATA_RATE);
        memset(pdatarate, 0, sizeof(struct cmd_ds_802_11_data_rate));
-
        pdatarate->action = cpu_to_le16(cmd_action);
 
-       if (cmd_action == cmd_act_set_tx_fix_rate) {
-               pdatarate->datarate[0] = libertas_data_rate_to_index(adapter->datarate);
-               lbs_deb_cmd("Setting FW for fixed rate 0x%02X\n",
-                      adapter->datarate);
-       } else if (cmd_action == cmd_act_set_tx_auto) {
-               lbs_deb_cmd("Setting FW for AUTO rate\n");
+       if (cmd_action == CMD_ACT_SET_TX_FIX_RATE) {
+               pdatarate->rates[0] = lbs_data_rate_to_fw_index(priv->cur_rate);
+               lbs_deb_cmd("DATA_RATE: set fixed 0x%02X\n",
+                      priv->cur_rate);
+       } else if (cmd_action == CMD_ACT_SET_TX_AUTO) {
+               lbs_deb_cmd("DATA_RATE: setting auto\n");
        }
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_mac_multicast_adr(wlan_private * priv,
+static int lbs_cmd_mac_multicast_adr(struct lbs_private *priv,
                                      struct cmd_ds_command *cmd,
                                      u16 cmd_action)
 {
        struct cmd_ds_mac_multicast_adr *pMCastAdr = &cmd->params.madr;
-       wlan_adapter *adapter = priv->adapter;
 
+       lbs_deb_enter(LBS_DEB_CMD);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mac_multicast_adr) +
                             S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_mac_multicast_adr);
+       cmd->command = cpu_to_le16(CMD_MAC_MULTICAST_ADR);
 
+       lbs_deb_cmd("MULTICAST_ADR: setting %d addresses\n", pMCastAdr->nr_of_adrs);
        pMCastAdr->action = cpu_to_le16(cmd_action);
        pMCastAdr->nr_of_adrs =
-           cpu_to_le16((u16) adapter->nr_of_multicastmacaddr);
-       memcpy(pMCastAdr->maclist, adapter->multicastlist,
-              adapter->nr_of_multicastmacaddr * ETH_ALEN);
+           cpu_to_le16((u16) priv->nr_of_multicastmacaddr);
+       memcpy(pMCastAdr->maclist, priv->multicastlist,
+              priv->nr_of_multicastmacaddr * ETH_ALEN);
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_rf_channel(wlan_private * priv,
+static int lbs_cmd_802_11_rf_channel(struct lbs_private *priv,
                                      struct cmd_ds_command *cmd,
                                      int option, void *pdata_buf)
 {
        struct cmd_ds_802_11_rf_channel *rfchan = &cmd->params.rfchannel;
 
-       cmd->command = cpu_to_le16(cmd_802_11_rf_channel);
+       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->command = cpu_to_le16(CMD_802_11_RF_CHANNEL);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rf_channel) +
                                S_DS_GEN);
 
-       if (option == cmd_opt_802_11_rf_channel_set) {
+       if (option == CMD_OPT_802_11_RF_CHANNEL_SET) {
                rfchan->currentchannel = cpu_to_le16(*((u16 *) pdata_buf));
        }
 
        rfchan->action = cpu_to_le16(option);
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_rssi(wlan_private * priv,
+static int lbs_cmd_802_11_rssi(struct lbs_private *priv,
                                struct cmd_ds_command *cmd)
 {
-       wlan_adapter *adapter = priv->adapter;
 
-       cmd->command = cpu_to_le16(cmd_802_11_rssi);
+       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->command = cpu_to_le16(CMD_802_11_RSSI);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rssi) + S_DS_GEN);
-       cmd->params.rssi.N = cpu_to_le16(priv->adapter->bcn_avg_factor);
+       cmd->params.rssi.N = cpu_to_le16(DEFAULT_BCN_AVG_FACTOR);
 
        /* reset Beacon SNR/NF/RSSI values */
-       adapter->SNR[TYPE_BEACON][TYPE_NOAVG] = 0;
-       adapter->SNR[TYPE_BEACON][TYPE_AVG] = 0;
-       adapter->NF[TYPE_BEACON][TYPE_NOAVG] = 0;
-       adapter->NF[TYPE_BEACON][TYPE_AVG] = 0;
-       adapter->RSSI[TYPE_BEACON][TYPE_NOAVG] = 0;
-       adapter->RSSI[TYPE_BEACON][TYPE_AVG] = 0;
+       priv->SNR[TYPE_BEACON][TYPE_NOAVG] = 0;
+       priv->SNR[TYPE_BEACON][TYPE_AVG] = 0;
+       priv->NF[TYPE_BEACON][TYPE_NOAVG] = 0;
+       priv->NF[TYPE_BEACON][TYPE_AVG] = 0;
+       priv->RSSI[TYPE_BEACON][TYPE_NOAVG] = 0;
+       priv->RSSI[TYPE_BEACON][TYPE_AVG] = 0;
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_reg_access(wlan_private * priv,
+static int lbs_cmd_reg_access(struct lbs_private *priv,
                               struct cmd_ds_command *cmdptr,
                               u8 cmd_action, void *pdata_buf)
 {
-       struct wlan_offset_value *offval;
+       struct lbs_offset_value *offval;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       offval = (struct wlan_offset_value *)pdata_buf;
+       offval = (struct lbs_offset_value *)pdata_buf;
 
-       switch (cmdptr->command) {
-       case cmd_mac_reg_access:
+       switch (le16_to_cpu(cmdptr->command)) {
+       case CMD_MAC_REG_ACCESS:
                {
                        struct cmd_ds_mac_reg_access *macreg;
 
@@ -715,7 +770,7 @@ static int wlan_cmd_reg_access(wlan_private * priv,
                        break;
                }
 
-       case cmd_bbp_reg_access:
+       case CMD_BBP_REG_ACCESS:
                {
                        struct cmd_ds_bbp_reg_access *bbpreg;
 
@@ -734,7 +789,7 @@ static int wlan_cmd_reg_access(wlan_private * priv,
                        break;
                }
 
-       case cmd_rf_reg_access:
+       case CMD_RF_REG_ACCESS:
                {
                        struct cmd_ds_rf_reg_access *rfreg;
 
@@ -761,37 +816,38 @@ static int wlan_cmd_reg_access(wlan_private * priv,
        return 0;
 }
 
-static int wlan_cmd_802_11_mac_address(wlan_private * priv,
+static int lbs_cmd_802_11_mac_address(struct lbs_private *priv,
                                       struct cmd_ds_command *cmd,
                                       u16 cmd_action)
 {
-       wlan_adapter *adapter = priv->adapter;
 
-       cmd->command = cpu_to_le16(cmd_802_11_mac_address);
+       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->command = cpu_to_le16(CMD_802_11_MAC_ADDRESS);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_mac_address) +
                             S_DS_GEN);
        cmd->result = 0;
 
        cmd->params.macadd.action = cpu_to_le16(cmd_action);
 
-       if (cmd_action == cmd_act_set) {
+       if (cmd_action == CMD_ACT_SET) {
                memcpy(cmd->params.macadd.macadd,
-                      adapter->current_addr, ETH_ALEN);
-               lbs_dbg_hex("SET_CMD: MAC ADDRESS-", adapter->current_addr, 6);
+                      priv->current_addr, ETH_ALEN);
+               lbs_deb_hex(LBS_DEB_CMD, "SET_CMD: MAC addr", priv->current_addr, 6);
        }
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_802_11_eeprom_access(wlan_private * priv,
+static int lbs_cmd_802_11_eeprom_access(struct lbs_private *priv,
                                         struct cmd_ds_command *cmd,
                                         int cmd_action, void *pdata_buf)
 {
-       struct wlan_ioctl_regrdwr *ea = pdata_buf;
+       struct lbs_ioctl_regrdwr *ea = pdata_buf;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_eeprom_access);
+       cmd->command = cpu_to_le16(CMD_802_11_EEPROM_ACCESS);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_eeprom_access) +
                                S_DS_GEN);
        cmd->result = 0;
@@ -801,54 +857,56 @@ static int wlan_cmd_802_11_eeprom_access(wlan_private * priv,
        cmd->params.rdeeprom.bytecount = cpu_to_le16(ea->NOB);
        cmd->params.rdeeprom.value = 0;
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_bt_access(wlan_private * priv,
+static int lbs_cmd_bt_access(struct lbs_private *priv,
                               struct cmd_ds_command *cmd,
                               u16 cmd_action, void *pdata_buf)
 {
        struct cmd_ds_bt_access *bt_access = &cmd->params.bt;
-       lbs_deb_cmd("BT CMD(%d)\n", cmd_action);
+       lbs_deb_enter_args(LBS_DEB_CMD, "action %d", cmd_action);
 
-       cmd->command = cpu_to_le16(cmd_bt_access);
+       cmd->command = cpu_to_le16(CMD_BT_ACCESS);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_bt_access) + S_DS_GEN);
        cmd->result = 0;
        bt_access->action = cpu_to_le16(cmd_action);
 
        switch (cmd_action) {
-       case cmd_act_bt_access_add:
+       case CMD_ACT_BT_ACCESS_ADD:
                memcpy(bt_access->addr1, pdata_buf, 2 * ETH_ALEN);
-               lbs_dbg_hex("BT_ADD: blinded mac address-", bt_access->addr1, 6);
+               lbs_deb_hex(LBS_DEB_MESH, "BT_ADD: blinded MAC addr", bt_access->addr1, 6);
                break;
-       case cmd_act_bt_access_del:
+       case CMD_ACT_BT_ACCESS_DEL:
                memcpy(bt_access->addr1, pdata_buf, 1 * ETH_ALEN);
-               lbs_dbg_hex("BT_DEL: blinded mac address-", bt_access->addr1, 6);
+               lbs_deb_hex(LBS_DEB_MESH, "BT_DEL: blinded MAC addr", bt_access->addr1, 6);
                break;
-       case cmd_act_bt_access_list:
+       case CMD_ACT_BT_ACCESS_LIST:
                bt_access->id = cpu_to_le32(*(u32 *) pdata_buf);
                break;
-       case cmd_act_bt_access_reset:
+       case CMD_ACT_BT_ACCESS_RESET:
                break;
-       case cmd_act_bt_access_set_invert:
+       case CMD_ACT_BT_ACCESS_SET_INVERT:
                bt_access->id = cpu_to_le32(*(u32 *) pdata_buf);
                break;
-       case cmd_act_bt_access_get_invert:
+       case CMD_ACT_BT_ACCESS_GET_INVERT:
                break;
        default:
                break;
        }
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_fwt_access(wlan_private * priv,
+static int lbs_cmd_fwt_access(struct lbs_private *priv,
                               struct cmd_ds_command *cmd,
                               u16 cmd_action, void *pdata_buf)
 {
        struct cmd_ds_fwt_access *fwt_access = &cmd->params.fwt;
-       lbs_deb_cmd("FWT CMD(%d)\n", cmd_action);
+       lbs_deb_enter_args(LBS_DEB_CMD, "action %d", cmd_action);
 
-       cmd->command = cpu_to_le16(cmd_fwt_access);
+       cmd->command = cpu_to_le16(CMD_FWT_ACCESS);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_fwt_access) + S_DS_GEN);
        cmd->result = 0;
 
@@ -859,17 +917,18 @@ static int wlan_cmd_fwt_access(wlan_private * priv,
 
        fwt_access->action = cpu_to_le16(cmd_action);
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-static int wlan_cmd_mesh_access(wlan_private * priv,
+static int lbs_cmd_mesh_access(struct lbs_private *priv,
                                struct cmd_ds_command *cmd,
                                u16 cmd_action, void *pdata_buf)
 {
        struct cmd_ds_mesh_access *mesh_access = &cmd->params.mesh;
-       lbs_deb_cmd("FWT CMD(%d)\n", cmd_action);
+       lbs_deb_enter_args(LBS_DEB_CMD, "action %d", cmd_action);
 
-       cmd->command = cpu_to_le16(cmd_mesh_access);
+       cmd->command = cpu_to_le16(CMD_MESH_ACCESS);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mesh_access) + S_DS_GEN);
        cmd->result = 0;
 
@@ -880,152 +939,166 @@ static int wlan_cmd_mesh_access(wlan_private * priv,
 
        mesh_access->action = cpu_to_le16(cmd_action);
 
+       lbs_deb_leave(LBS_DEB_CMD);
+       return 0;
+}
+
+static int lbs_cmd_bcn_ctrl(struct lbs_private * priv,
+                               struct cmd_ds_command *cmd,
+                               u16 cmd_action)
+{
+       struct cmd_ds_802_11_beacon_control
+               *bcn_ctrl = &cmd->params.bcn_ctrl;
+
+       lbs_deb_enter(LBS_DEB_CMD);
+       cmd->size =
+           cpu_to_le16(sizeof(struct cmd_ds_802_11_beacon_control)
+                            + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_BEACON_CTRL);
+
+       bcn_ctrl->action = cpu_to_le16(cmd_action);
+       bcn_ctrl->beacon_enable = cpu_to_le16(priv->beacon_enable);
+       bcn_ctrl->beacon_period = cpu_to_le16(priv->beacon_period);
+
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
-void libertas_queue_cmd(wlan_adapter * adapter, struct cmd_ctrl_node *cmdnode, u8 addtail)
+/*
+ * Note: NEVER use lbs_queue_cmd() with addtail==0 other than for
+ * the command timer, because it does not account for queued commands.
+ */
+void lbs_queue_cmd(struct lbs_private *priv,
+       struct cmd_ctrl_node *cmdnode,
+       u8 addtail)
 {
        unsigned long flags;
        struct cmd_ds_command *cmdptr;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
        if (!cmdnode) {
-               lbs_deb_cmd("QUEUE_CMD: cmdnode is NULL\n");
+               lbs_deb_host("QUEUE_CMD: cmdnode is NULL\n");
                goto done;
        }
 
        cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr;
        if (!cmdptr) {
-               lbs_deb_cmd("QUEUE_CMD: cmdptr is NULL\n");
+               lbs_deb_host("QUEUE_CMD: cmdptr is NULL\n");
                goto done;
        }
 
        /* Exit_PS command needs to be queued in the header always. */
-       if (cmdptr->command == cmd_802_11_ps_mode) {
+       if (le16_to_cpu(cmdptr->command) == CMD_802_11_PS_MODE) {
                struct cmd_ds_802_11_ps_mode *psm = &cmdptr->params.psmode;
-               if (psm->action == cpu_to_le16(cmd_subcmd_exit_ps)) {
-                       if (adapter->psstate != PS_STATE_FULL_POWER)
+               if (psm->action == cpu_to_le16(CMD_SUBCMD_EXIT_PS)) {
+                       if (priv->psstate != PS_STATE_FULL_POWER)
                                addtail = 0;
                }
        }
 
-       spin_lock_irqsave(&adapter->driver_lock, flags);
+       spin_lock_irqsave(&priv->driver_lock, flags);
 
        if (addtail)
-               list_add_tail((struct list_head *)cmdnode,
-                             &adapter->cmdpendingq);
+               list_add_tail(&cmdnode->list, &priv->cmdpendingq);
        else
-               list_add((struct list_head *)cmdnode, &adapter->cmdpendingq);
+               list_add(&cmdnode->list, &priv->cmdpendingq);
 
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
-       lbs_deb_cmd("QUEUE_CMD: Inserted node=%p, cmd=0x%x in cmdpendingq\n",
-              cmdnode,
+       lbs_deb_host("QUEUE_CMD: inserted command 0x%04x into cmdpendingq\n",
               le16_to_cpu(((struct cmd_ds_gen*)cmdnode->bufvirtualaddr)->command));
 
 done:
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_HOST);
 }
 
 /*
  * TODO: Fix the issue when DownloadcommandToStation is being called the
- * second time when the command timesout. All the cmdptr->xxx are in little
+ * second time when the command times out. All the cmdptr->xxx are in little
  * endian and therefore all the comparissions will fail.
  * For now - we are not performing the endian conversion the second time - but
  * for PS and DEEP_SLEEP we need to worry
  */
-static int DownloadcommandToStation(wlan_private * priv,
+static int DownloadcommandToStation(struct lbs_private *priv,
                                    struct cmd_ctrl_node *cmdnode)
 {
        unsigned long flags;
        struct cmd_ds_command *cmdptr;
-       wlan_adapter *adapter = priv->adapter;
-       int ret = 0;
+       int ret = -1;
        u16 cmdsize;
        u16 command;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
-       if (!adapter || !cmdnode) {
-               lbs_deb_cmd("DNLD_CMD: adapter = %p, cmdnode = %p\n",
-                      adapter, cmdnode);
-               if (cmdnode) {
-                       spin_lock_irqsave(&adapter->driver_lock, flags);
-                       __libertas_cleanup_and_insert_cmd(priv, cmdnode);
-                       spin_unlock_irqrestore(&adapter->driver_lock, flags);
-               }
-               ret = -1;
+       if (!priv || !cmdnode) {
+               lbs_deb_host("DNLD_CMD: priv or cmdmode is NULL\n");
                goto done;
        }
 
        cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr;
 
-
-       spin_lock_irqsave(&adapter->driver_lock, flags);
+       spin_lock_irqsave(&priv->driver_lock, flags);
        if (!cmdptr || !cmdptr->size) {
-               lbs_deb_cmd("DNLD_CMD: cmdptr is Null or cmd size is Zero, "
-                      "Not sending\n");
-               __libertas_cleanup_and_insert_cmd(priv, cmdnode);
-               spin_unlock_irqrestore(&adapter->driver_lock, flags);
-               ret = -1;
+               lbs_deb_host("DNLD_CMD: cmdptr is NULL or zero\n");
+               __lbs_cleanup_and_insert_cmd(priv, cmdnode);
+               spin_unlock_irqrestore(&priv->driver_lock, flags);
                goto done;
        }
 
-       adapter->cur_cmd = cmdnode;
-       adapter->cur_cmd_retcode = 0;
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
-       lbs_deb_cmd("DNLD_CMD:: Before download, size of cmd = %d\n",
-                   le16_to_cpu(cmdptr->size));
+       priv->cur_cmd = cmdnode;
+       priv->cur_cmd_retcode = 0;
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
-       cmdsize = cmdptr->size;
+       cmdsize = le16_to_cpu(cmdptr->size);
+       command = le16_to_cpu(cmdptr->command);
 
-       command = cpu_to_le16(cmdptr->command);
+       lbs_deb_host("DNLD_CMD: command 0x%04x, size %d, jiffies %lu\n",
+                   command, cmdsize, jiffies);
+       lbs_deb_hex(LBS_DEB_HOST, "DNLD_CMD", cmdnode->bufvirtualaddr, cmdsize);
 
        cmdnode->cmdwaitqwoken = 0;
-       cmdsize = cpu_to_le16(cmdsize);
 
        ret = priv->hw_host_to_card(priv, MVMS_CMD, (u8 *) cmdptr, cmdsize);
 
        if (ret != 0) {
-               lbs_deb_cmd("DNLD_CMD: Host to Card failed\n");
-               spin_lock_irqsave(&adapter->driver_lock, flags);
-               __libertas_cleanup_and_insert_cmd(priv, adapter->cur_cmd);
-               adapter->cur_cmd = NULL;
-               spin_unlock_irqrestore(&adapter->driver_lock, flags);
-               ret = -1;
+               lbs_deb_host("DNLD_CMD: hw_host_to_card failed\n");
+               spin_lock_irqsave(&priv->driver_lock, flags);
+               priv->cur_cmd_retcode = ret;
+               __lbs_cleanup_and_insert_cmd(priv, priv->cur_cmd);
+               priv->cur_cmd = NULL;
+               spin_unlock_irqrestore(&priv->driver_lock, flags);
                goto done;
        }
 
-       lbs_deb_cmd("DNLD_CMD: Sent command 0x%x @ %lu\n", command, jiffies);
-       lbs_dbg_hex("DNLD_CMD: command", cmdnode->bufvirtualaddr, cmdsize);
+       lbs_deb_cmd("DNLD_CMD: sent command 0x%04x, jiffies %lu\n", command, jiffies);
 
        /* Setup the timer after transmit command */
-       if (command == cmd_802_11_scan || command == cmd_802_11_authenticate
-           || command == cmd_802_11_associate)
-               mod_timer(&adapter->command_timer, jiffies + (10*HZ));
+       if (command == CMD_802_11_SCAN || command == CMD_802_11_AUTHENTICATE
+           || command == CMD_802_11_ASSOCIATE)
+               mod_timer(&priv->command_timer, jiffies + (10*HZ));
        else
-               mod_timer(&adapter->command_timer, jiffies + (5*HZ));
+               mod_timer(&priv->command_timer, jiffies + (5*HZ));
 
        ret = 0;
 
 done:
-       lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
+       lbs_deb_leave_args(LBS_DEB_HOST, "ret %d", ret);
        return ret;
 }
 
-static int wlan_cmd_mac_control(wlan_private * priv,
+static int lbs_cmd_mac_control(struct lbs_private *priv,
                                struct cmd_ds_command *cmd)
 {
        struct cmd_ds_mac_control *mac = &cmd->params.macctrl;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_mac_control);
+       cmd->command = cpu_to_le16(CMD_MAC_CONTROL);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mac_control) + S_DS_GEN);
-       mac->action = cpu_to_le16(priv->adapter->currentpacketfilter);
+       mac->action = cpu_to_le16(priv->currentpacketfilter);
 
-       lbs_deb_cmd("wlan_cmd_mac_control(): action=0x%X size=%d\n",
+       lbs_deb_cmd("MAC_CONTROL: action 0x%x, size %d\n",
                    le16_to_cpu(mac->action), le16_to_cpu(cmd->size));
 
        lbs_deb_leave(LBS_DEB_CMD);
@@ -1034,60 +1107,56 @@ static int wlan_cmd_mac_control(wlan_private * priv,
 
 /**
  *  This function inserts command node to cmdfreeq
- *  after cleans it. Requires adapter->driver_lock held.
+ *  after cleans it. Requires priv->driver_lock held.
  */
-void __libertas_cleanup_and_insert_cmd(wlan_private * priv, struct cmd_ctrl_node *ptempcmd)
+void __lbs_cleanup_and_insert_cmd(struct lbs_private *priv,
+       struct cmd_ctrl_node *ptempcmd)
 {
-       wlan_adapter *adapter = priv->adapter;
 
        if (!ptempcmd)
-               goto done;
+               return;
 
        cleanup_cmdnode(ptempcmd);
-       list_add_tail((struct list_head *)ptempcmd, &adapter->cmdfreeq);
-done:
-       return;
+       list_add_tail(&ptempcmd->list, &priv->cmdfreeq);
 }
 
-void libertas_cleanup_and_insert_cmd(wlan_private * priv, struct cmd_ctrl_node *ptempcmd)
+static void lbs_cleanup_and_insert_cmd(struct lbs_private *priv,
+       struct cmd_ctrl_node *ptempcmd)
 {
        unsigned long flags;
 
-       spin_lock_irqsave(&priv->adapter->driver_lock, flags);
-       __libertas_cleanup_and_insert_cmd(priv, ptempcmd);
-       spin_unlock_irqrestore(&priv->adapter->driver_lock, flags);
+       spin_lock_irqsave(&priv->driver_lock, flags);
+       __lbs_cleanup_and_insert_cmd(priv, ptempcmd);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 }
 
-int libertas_set_radio_control(wlan_private * priv)
+int lbs_set_radio_control(struct lbs_private *priv)
 {
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       ret = libertas_prepare_and_send_command(priv,
-                                   cmd_802_11_radio_control,
-                                   cmd_act_set,
-                                   cmd_option_waitforrsp, 0, NULL);
+       ret = lbs_prepare_and_send_command(priv,
+                                   CMD_802_11_RADIO_CONTROL,
+                                   CMD_ACT_SET,
+                                   CMD_OPTION_WAITFORRSP, 0, NULL);
 
-       lbs_deb_cmd("RADIO_SET: on or off: 0x%X, preamble = 0x%X\n",
-              priv->adapter->radioon, priv->adapter->preamble);
+       lbs_deb_cmd("RADIO_SET: radio %d, preamble %d\n",
+              priv->radioon, priv->preamble);
 
        lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
        return ret;
 }
 
-int libertas_set_mac_packet_filter(wlan_private * priv)
+int lbs_set_mac_packet_filter(struct lbs_private *priv)
 {
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       lbs_deb_cmd("libertas_set_mac_packet_filter value = %x\n",
-              priv->adapter->currentpacketfilter);
-
        /* Send MAC control command to station */
-       ret = libertas_prepare_and_send_command(priv,
-                                   cmd_mac_control, 0, 0, 0, NULL);
+       ret = lbs_prepare_and_send_command(priv,
+                                   CMD_MAC_CONTROL, 0, 0, 0, NULL);
 
        lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
        return ret;
@@ -1096,7 +1165,7 @@ int libertas_set_mac_packet_filter(wlan_private * priv)
 /**
  *  @brief This function prepare the command before send to firmware.
  *
- *  @param priv                A pointer to wlan_private structure
+ *  @param priv                A pointer to struct lbs_private structure
  *  @param cmd_no      command number
  *  @param cmd_action  command action: GET or SET
  *  @param wait_option wait option: wait response or not
@@ -1104,194 +1173,192 @@ int libertas_set_mac_packet_filter(wlan_private * priv)
  *  @param pdata_buf   A pointer to informaion buffer
  *  @return            0 or -1
  */
-int libertas_prepare_and_send_command(wlan_private * priv,
+int lbs_prepare_and_send_command(struct lbs_private *priv,
                          u16 cmd_no,
                          u16 cmd_action,
                          u16 wait_option, u32 cmd_oid, void *pdata_buf)
 {
        int ret = 0;
-       wlan_adapter *adapter = priv->adapter;
        struct cmd_ctrl_node *cmdnode;
        struct cmd_ds_command *cmdptr;
        unsigned long flags;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
-       if (!adapter) {
-               lbs_deb_cmd("PREP_CMD: adapter is Null\n");
+       if (!priv) {
+               lbs_deb_host("PREP_CMD: priv is NULL\n");
                ret = -1;
                goto done;
        }
 
-       if (adapter->surpriseremoved) {
-               lbs_deb_cmd("PREP_CMD: Card is Removed\n");
+       if (priv->surpriseremoved) {
+               lbs_deb_host("PREP_CMD: card removed\n");
                ret = -1;
                goto done;
        }
 
-       cmdnode = libertas_get_free_cmd_ctrl_node(priv);
+       cmdnode = lbs_get_cmd_ctrl_node(priv);
 
        if (cmdnode == NULL) {
-               lbs_deb_cmd("PREP_CMD: No free cmdnode\n");
+               lbs_deb_host("PREP_CMD: cmdnode is NULL\n");
 
                /* Wake up main thread to execute next command */
-               wake_up_interruptible(&priv->mainthread.waitq);
+               wake_up_interruptible(&priv->waitq);
                ret = -1;
                goto done;
        }
 
-       libertas_set_cmd_ctrl_node(priv, cmdnode, cmd_oid, wait_option, pdata_buf);
+       lbs_set_cmd_ctrl_node(priv, cmdnode, wait_option, pdata_buf);
 
        cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr;
 
-       lbs_deb_cmd("PREP_CMD: Val of cmd ptr=%p, command=0x%X\n",
-              cmdptr, cmd_no);
+       lbs_deb_host("PREP_CMD: command 0x%04x\n", cmd_no);
 
        if (!cmdptr) {
-               lbs_deb_cmd("PREP_CMD: bufvirtualaddr of cmdnode is NULL\n");
-               libertas_cleanup_and_insert_cmd(priv, cmdnode);
+               lbs_deb_host("PREP_CMD: cmdptr is NULL\n");
+               lbs_cleanup_and_insert_cmd(priv, cmdnode);
                ret = -1;
                goto done;
        }
 
        /* Set sequence number, command and INT option */
-       adapter->seqnum++;
-       cmdptr->seqnum = cpu_to_le16(adapter->seqnum);
+       priv->seqnum++;
+       cmdptr->seqnum = cpu_to_le16(priv->seqnum);
 
        cmdptr->command = cpu_to_le16(cmd_no);
        cmdptr->result = 0;
 
        switch (cmd_no) {
-       case cmd_get_hw_spec:
-               ret = wlan_cmd_hw_spec(priv, cmdptr);
+       case CMD_GET_HW_SPEC:
+               ret = lbs_cmd_hw_spec(priv, cmdptr);
                break;
-       case cmd_802_11_ps_mode:
-               ret = wlan_cmd_802_11_ps_mode(priv, cmdptr, cmd_action);
+       case CMD_802_11_PS_MODE:
+               ret = lbs_cmd_802_11_ps_mode(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_scan:
-               ret = libertas_cmd_80211_scan(priv, cmdptr, pdata_buf);
+       case CMD_802_11_SCAN:
+               ret = lbs_cmd_80211_scan(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_mac_control:
-               ret = wlan_cmd_mac_control(priv, cmdptr);
+       case CMD_MAC_CONTROL:
+               ret = lbs_cmd_mac_control(priv, cmdptr);
                break;
 
-       case cmd_802_11_associate:
-       case cmd_802_11_reassociate:
-               ret = libertas_cmd_80211_associate(priv, cmdptr, pdata_buf);
+       case CMD_802_11_ASSOCIATE:
+       case CMD_802_11_REASSOCIATE:
+               ret = lbs_cmd_80211_associate(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_802_11_deauthenticate:
-               ret = libertas_cmd_80211_deauthenticate(priv, cmdptr);
+       case CMD_802_11_DEAUTHENTICATE:
+               ret = lbs_cmd_80211_deauthenticate(priv, cmdptr);
                break;
 
-       case cmd_802_11_set_wep:
-               ret = wlan_cmd_802_11_set_wep(priv, cmdptr, cmd_action, pdata_buf);
+       case CMD_802_11_SET_WEP:
+               ret = lbs_cmd_802_11_set_wep(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_ad_hoc_start:
-               ret = libertas_cmd_80211_ad_hoc_start(priv, cmdptr, pdata_buf);
+       case CMD_802_11_AD_HOC_START:
+               ret = lbs_cmd_80211_ad_hoc_start(priv, cmdptr, pdata_buf);
                break;
-       case cmd_code_dnld:
+       case CMD_CODE_DNLD:
                break;
 
-       case cmd_802_11_reset:
-               ret = wlan_cmd_802_11_reset(priv, cmdptr, cmd_action);
+       case CMD_802_11_RESET:
+               ret = lbs_cmd_802_11_reset(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_get_log:
-               ret = wlan_cmd_802_11_get_log(priv, cmdptr);
+       case CMD_802_11_GET_LOG:
+               ret = lbs_cmd_802_11_get_log(priv, cmdptr);
                break;
 
-       case cmd_802_11_authenticate:
-               ret = libertas_cmd_80211_authenticate(priv, cmdptr, pdata_buf);
+       case CMD_802_11_AUTHENTICATE:
+               ret = lbs_cmd_80211_authenticate(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_802_11_get_stat:
-               ret = wlan_cmd_802_11_get_stat(priv, cmdptr);
+       case CMD_802_11_GET_STAT:
+               ret = lbs_cmd_802_11_get_stat(priv, cmdptr);
                break;
 
-       case cmd_802_11_snmp_mib:
-               ret = wlan_cmd_802_11_snmp_mib(priv, cmdptr,
+       case CMD_802_11_SNMP_MIB:
+               ret = lbs_cmd_802_11_snmp_mib(priv, cmdptr,
                                               cmd_action, cmd_oid, pdata_buf);
                break;
 
-       case cmd_mac_reg_access:
-       case cmd_bbp_reg_access:
-       case cmd_rf_reg_access:
-               ret = wlan_cmd_reg_access(priv, cmdptr, cmd_action, pdata_buf);
+       case CMD_MAC_REG_ACCESS:
+       case CMD_BBP_REG_ACCESS:
+       case CMD_RF_REG_ACCESS:
+               ret = lbs_cmd_reg_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_rf_channel:
-               ret = wlan_cmd_802_11_rf_channel(priv, cmdptr,
+       case CMD_802_11_RF_CHANNEL:
+               ret = lbs_cmd_802_11_rf_channel(priv, cmdptr,
                                                 cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_rf_tx_power:
-               ret = wlan_cmd_802_11_rf_tx_power(priv, cmdptr,
+       case CMD_802_11_RF_TX_POWER:
+               ret = lbs_cmd_802_11_rf_tx_power(priv, cmdptr,
                                                  cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_radio_control:
-               ret = wlan_cmd_802_11_radio_control(priv, cmdptr, cmd_action);
-               break;
-
-       case cmd_802_11_rf_antenna:
-               ret = wlan_cmd_802_11_rf_antenna(priv, cmdptr,
-                                                cmd_action, pdata_buf);
+       case CMD_802_11_RADIO_CONTROL:
+               ret = lbs_cmd_802_11_radio_control(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_data_rate:
-               ret = wlan_cmd_802_11_data_rate(priv, cmdptr, cmd_action);
+       case CMD_802_11_DATA_RATE:
+               ret = lbs_cmd_802_11_data_rate(priv, cmdptr, cmd_action);
                break;
-       case cmd_802_11_rate_adapt_rateset:
-               ret = wlan_cmd_802_11_rate_adapt_rateset(priv,
+       case CMD_802_11_RATE_ADAPT_RATESET:
+               ret = lbs_cmd_802_11_rate_adapt_rateset(priv,
                                                         cmdptr, cmd_action);
                break;
 
-       case cmd_mac_multicast_adr:
-               ret = wlan_cmd_mac_multicast_adr(priv, cmdptr, cmd_action);
+       case CMD_MAC_MULTICAST_ADR:
+               ret = lbs_cmd_mac_multicast_adr(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_ad_hoc_join:
-               ret = libertas_cmd_80211_ad_hoc_join(priv, cmdptr, pdata_buf);
+       case CMD_802_11_MONITOR_MODE:
+               ret = lbs_cmd_802_11_monitor_mode(priv, cmdptr,
+                                         cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_rssi:
-               ret = wlan_cmd_802_11_rssi(priv, cmdptr);
+       case CMD_802_11_AD_HOC_JOIN:
+               ret = lbs_cmd_80211_ad_hoc_join(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_802_11_ad_hoc_stop:
-               ret = libertas_cmd_80211_ad_hoc_stop(priv, cmdptr);
+       case CMD_802_11_RSSI:
+               ret = lbs_cmd_802_11_rssi(priv, cmdptr);
                break;
 
-       case cmd_802_11_enable_rsn:
-               ret = wlan_cmd_802_11_enable_rsn(priv, cmdptr, cmd_action,
+       case CMD_802_11_AD_HOC_STOP:
+               ret = lbs_cmd_80211_ad_hoc_stop(priv, cmdptr);
+               break;
+
+       case CMD_802_11_ENABLE_RSN:
+               ret = lbs_cmd_802_11_enable_rsn(priv, cmdptr, cmd_action,
                                pdata_buf);
                break;
 
-       case cmd_802_11_key_material:
-               ret = wlan_cmd_802_11_key_material(priv, cmdptr, cmd_action,
+       case CMD_802_11_KEY_MATERIAL:
+               ret = lbs_cmd_802_11_key_material(priv, cmdptr, cmd_action,
                                cmd_oid, pdata_buf);
                break;
 
-       case cmd_802_11_pairwise_tsc:
+       case CMD_802_11_PAIRWISE_TSC:
                break;
-       case cmd_802_11_group_tsc:
+       case CMD_802_11_GROUP_TSC:
                break;
 
-       case cmd_802_11_mac_address:
-               ret = wlan_cmd_802_11_mac_address(priv, cmdptr, cmd_action);
+       case CMD_802_11_MAC_ADDRESS:
+               ret = lbs_cmd_802_11_mac_address(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_eeprom_access:
-               ret = wlan_cmd_802_11_eeprom_access(priv, cmdptr,
+       case CMD_802_11_EEPROM_ACCESS:
+               ret = lbs_cmd_802_11_eeprom_access(priv, cmdptr,
                                                    cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_set_afc:
-       case cmd_802_11_get_afc:
+       case CMD_802_11_SET_AFC:
+       case CMD_802_11_GET_AFC:
 
                cmdptr->command = cpu_to_le16(cmd_no);
                cmdptr->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_afc) +
@@ -1303,22 +1370,22 @@ int libertas_prepare_and_send_command(wlan_private * priv,
                ret = 0;
                goto done;
 
-       case cmd_802_11d_domain_info:
-               ret = libertas_cmd_802_11d_domain_info(priv, cmdptr,
+       case CMD_802_11D_DOMAIN_INFO:
+               ret = lbs_cmd_802_11d_domain_info(priv, cmdptr,
                                                   cmd_no, cmd_action);
                break;
 
-       case cmd_802_11_sleep_params:
-               ret = wlan_cmd_802_11_sleep_params(priv, cmdptr, cmd_action);
+       case CMD_802_11_SLEEP_PARAMS:
+               ret = lbs_cmd_802_11_sleep_params(priv, cmdptr, cmd_action);
                break;
-       case cmd_802_11_inactivity_timeout:
-               ret = wlan_cmd_802_11_inactivity_timeout(priv, cmdptr,
+       case CMD_802_11_INACTIVITY_TIMEOUT:
+               ret = lbs_cmd_802_11_inactivity_timeout(priv, cmdptr,
                                                         cmd_action, pdata_buf);
-               libertas_set_cmd_ctrl_node(priv, cmdnode, 0, 0, pdata_buf);
+               lbs_set_cmd_ctrl_node(priv, cmdnode, 0, pdata_buf);
                break;
 
-       case cmd_802_11_tpc_cfg:
-               cmdptr->command = cpu_to_le16(cmd_802_11_tpc_cfg);
+       case CMD_802_11_TPC_CFG:
+               cmdptr->command = cpu_to_le16(CMD_802_11_TPC_CFG);
                cmdptr->size =
                    cpu_to_le16(sizeof(struct cmd_ds_802_11_tpc_cfg) +
                                     S_DS_GEN);
@@ -1328,7 +1395,7 @@ int libertas_prepare_and_send_command(wlan_private * priv,
 
                ret = 0;
                break;
-       case cmd_802_11_led_gpio_ctrl:
+       case CMD_802_11_LED_GPIO_CTRL:
                {
                        struct mrvlietypes_ledgpio *gpio =
                            (struct mrvlietypes_ledgpio*)
@@ -1339,19 +1406,24 @@ int libertas_prepare_and_send_command(wlan_private * priv,
                                sizeof(struct cmd_ds_802_11_led_ctrl));
 
                        cmdptr->command =
-                           cpu_to_le16(cmd_802_11_led_gpio_ctrl);
+                           cpu_to_le16(CMD_802_11_LED_GPIO_CTRL);
 
 #define ACTION_NUMLED_TLVTYPE_LEN_FIELDS_LEN 8
                        cmdptr->size =
-                           cpu_to_le16(gpio->header.len + S_DS_GEN +
-                                            ACTION_NUMLED_TLVTYPE_LEN_FIELDS_LEN);
-                       gpio->header.len = cpu_to_le16(gpio->header.len);
+                           cpu_to_le16(le16_to_cpu(gpio->header.len)
+                               + S_DS_GEN
+                               + ACTION_NUMLED_TLVTYPE_LEN_FIELDS_LEN);
+                       gpio->header.len = gpio->header.len;
 
                        ret = 0;
                        break;
                }
-       case cmd_802_11_pwr_cfg:
-               cmdptr->command = cpu_to_le16(cmd_802_11_pwr_cfg);
+       case CMD_802_11_SUBSCRIBE_EVENT:
+               lbs_cmd_802_11_subscribe_event(priv, cmdptr,
+                       cmd_action, pdata_buf);
+               break;
+       case CMD_802_11_PWR_CFG:
+               cmdptr->command = cpu_to_le16(CMD_802_11_PWR_CFG);
                cmdptr->size =
                    cpu_to_le16(sizeof(struct cmd_ds_802_11_pwr_cfg) +
                                     S_DS_GEN);
@@ -1360,108 +1432,100 @@ int libertas_prepare_and_send_command(wlan_private * priv,
 
                ret = 0;
                break;
-       case cmd_bt_access:
-               ret = wlan_cmd_bt_access(priv, cmdptr, cmd_action, pdata_buf);
+       case CMD_BT_ACCESS:
+               ret = lbs_cmd_bt_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_fwt_access:
-               ret = wlan_cmd_fwt_access(priv, cmdptr, cmd_action, pdata_buf);
+       case CMD_FWT_ACCESS:
+               ret = lbs_cmd_fwt_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_mesh_access:
-               ret = wlan_cmd_mesh_access(priv, cmdptr, cmd_action, pdata_buf);
+       case CMD_MESH_ACCESS:
+               ret = lbs_cmd_mesh_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_get_tsf:
-               cmdptr->command = cpu_to_le16(cmd_get_tsf);
+       case CMD_GET_TSF:
+               cmdptr->command = cpu_to_le16(CMD_GET_TSF);
                cmdptr->size = cpu_to_le16(sizeof(struct cmd_ds_get_tsf) +
                                           S_DS_GEN);
                ret = 0;
                break;
-       case cmd_802_11_tx_rate_query:
-               cmdptr->command = cpu_to_le16(cmd_802_11_tx_rate_query);
-               cmdptr->size = cpu_to_le16(sizeof(struct cmd_tx_rate_query) +
-                                          S_DS_GEN);
-               adapter->txrate = 0;
-               ret = 0;
+       case CMD_802_11_BEACON_CTRL:
+               ret = lbs_cmd_bcn_ctrl(priv, cmdptr, cmd_action);
                break;
        default:
-               lbs_deb_cmd("PREP_CMD: unknown command- %#x\n", cmd_no);
+               lbs_deb_host("PREP_CMD: unknown command 0x%04x\n", cmd_no);
                ret = -1;
                break;
        }
 
        /* return error, since the command preparation failed */
        if (ret != 0) {
-               lbs_deb_cmd("PREP_CMD: command preparation failed\n");
-               libertas_cleanup_and_insert_cmd(priv, cmdnode);
+               lbs_deb_host("PREP_CMD: command preparation failed\n");
+               lbs_cleanup_and_insert_cmd(priv, cmdnode);
                ret = -1;
                goto done;
        }
 
        cmdnode->cmdwaitqwoken = 0;
 
-       libertas_queue_cmd(adapter, cmdnode, 1);
-       adapter->nr_cmd_pending++;
-       wake_up_interruptible(&priv->mainthread.waitq);
+       lbs_queue_cmd(priv, cmdnode, 1);
+       wake_up_interruptible(&priv->waitq);
 
-       if (wait_option & cmd_option_waitforrsp) {
-               lbs_deb_cmd("PREP_CMD: Wait for CMD response\n");
+       if (wait_option & CMD_OPTION_WAITFORRSP) {
+               lbs_deb_host("PREP_CMD: wait for response\n");
                might_sleep();
                wait_event_interruptible(cmdnode->cmdwait_q,
                                         cmdnode->cmdwaitqwoken);
        }
 
-       spin_lock_irqsave(&adapter->driver_lock, flags);
-       if (adapter->cur_cmd_retcode) {
-               lbs_deb_cmd("PREP_CMD: command failed with return code=%d\n",
-                      adapter->cur_cmd_retcode);
-               adapter->cur_cmd_retcode = 0;
+       spin_lock_irqsave(&priv->driver_lock, flags);
+       if (priv->cur_cmd_retcode) {
+               lbs_deb_host("PREP_CMD: command failed with return code %d\n",
+                      priv->cur_cmd_retcode);
+               priv->cur_cmd_retcode = 0;
                ret = -1;
        }
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
 done:
-       lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
+       lbs_deb_leave_args(LBS_DEB_HOST, "ret %d", ret);
        return ret;
 }
-EXPORT_SYMBOL_GPL(libertas_prepare_and_send_command);
+EXPORT_SYMBOL_GPL(lbs_prepare_and_send_command);
 
 /**
  *  @brief This function allocates the command buffer and link
  *  it to command free queue.
  *
- *  @param priv                A pointer to wlan_private structure
+ *  @param priv                A pointer to struct lbs_private structure
  *  @return            0 or -1
  */
-int libertas_allocate_cmd_buffer(wlan_private * priv)
+int lbs_allocate_cmd_buffer(struct lbs_private *priv)
 {
        int ret = 0;
        u32 ulbufsize;
        u32 i;
        struct cmd_ctrl_node *tempcmd_array;
        u8 *ptempvirtualaddr;
-       wlan_adapter *adapter = priv->adapter;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
        /* Allocate and initialize cmdCtrlNode */
        ulbufsize = sizeof(struct cmd_ctrl_node) * MRVDRV_NUM_OF_CMD_BUFFER;
 
        if (!(tempcmd_array = kzalloc(ulbufsize, GFP_KERNEL))) {
-               lbs_deb_cmd(
-                      "ALLOC_CMD_BUF: failed to allocate tempcmd_array\n");
+               lbs_deb_host("ALLOC_CMD_BUF: tempcmd_array is NULL\n");
                ret = -1;
                goto done;
        }
-       adapter->cmd_array = tempcmd_array;
+       priv->cmd_array = tempcmd_array;
 
        /* Allocate and initialize command buffers */
        ulbufsize = MRVDRV_SIZE_OF_CMD_BUFFER;
        for (i = 0; i < MRVDRV_NUM_OF_CMD_BUFFER; i++) {
                if (!(ptempvirtualaddr = kzalloc(ulbufsize, GFP_KERNEL))) {
-                       lbs_deb_cmd(
-                              "ALLOC_CMD_BUF: ptempvirtualaddr: out of memory\n");
+                       lbs_deb_host("ALLOC_CMD_BUF: ptempvirtualaddr is NULL\n");
                        ret = -1;
                        goto done;
                }
@@ -1472,58 +1536,55 @@ int libertas_allocate_cmd_buffer(wlan_private * priv)
 
        for (i = 0; i < MRVDRV_NUM_OF_CMD_BUFFER; i++) {
                init_waitqueue_head(&tempcmd_array[i].cmdwait_q);
-               libertas_cleanup_and_insert_cmd(priv, &tempcmd_array[i]);
+               lbs_cleanup_and_insert_cmd(priv, &tempcmd_array[i]);
        }
 
        ret = 0;
 
 done:
-       lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
+       lbs_deb_leave_args(LBS_DEB_HOST, "ret %d", ret);
        return ret;
 }
 
 /**
  *  @brief This function frees the command buffer.
  *
- *  @param priv                A pointer to wlan_private structure
+ *  @param priv                A pointer to struct lbs_private structure
  *  @return            0 or -1
  */
-int libertas_free_cmd_buffer(wlan_private * priv)
+int lbs_free_cmd_buffer(struct lbs_private *priv)
 {
        u32 ulbufsize; /* Someone needs to die for this. Slowly and painfully */
        unsigned int i;
        struct cmd_ctrl_node *tempcmd_array;
-       wlan_adapter *adapter = priv->adapter;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
        /* need to check if cmd array is allocated or not */
-       if (adapter->cmd_array == NULL) {
-               lbs_deb_cmd("FREE_CMD_BUF: cmd_array is Null\n");
+       if (priv->cmd_array == NULL) {
+               lbs_deb_host("FREE_CMD_BUF: cmd_array is NULL\n");
                goto done;
        }
 
-       tempcmd_array = adapter->cmd_array;
+       tempcmd_array = priv->cmd_array;
 
        /* Release shared memory buffers */
        ulbufsize = MRVDRV_SIZE_OF_CMD_BUFFER;
        for (i = 0; i < MRVDRV_NUM_OF_CMD_BUFFER; i++) {
                if (tempcmd_array[i].bufvirtualaddr) {
-                       lbs_deb_cmd("Free all the array\n");
                        kfree(tempcmd_array[i].bufvirtualaddr);
                        tempcmd_array[i].bufvirtualaddr = NULL;
                }
        }
 
        /* Release cmd_ctrl_node */
-       if (adapter->cmd_array) {
-               lbs_deb_cmd("Free cmd_array\n");
-               kfree(adapter->cmd_array);
-               adapter->cmd_array = NULL;
+       if (priv->cmd_array) {
+               kfree(priv->cmd_array);
+               priv->cmd_array = NULL;
        }
 
 done:
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_HOST);
        return 0;
 }
 
@@ -1531,39 +1592,36 @@ done:
  *  @brief This function gets a free command node if available in
  *  command free queue.
  *
- *  @param priv                A pointer to wlan_private structure
+ *  @param priv                A pointer to struct lbs_private structure
  *  @return cmd_ctrl_node A pointer to cmd_ctrl_node structure or NULL
  */
-struct cmd_ctrl_node *libertas_get_free_cmd_ctrl_node(wlan_private * priv)
+struct cmd_ctrl_node *lbs_get_cmd_ctrl_node(struct lbs_private *priv)
 {
        struct cmd_ctrl_node *tempnode;
-       wlan_adapter *adapter = priv->adapter;
        unsigned long flags;
 
-       if (!adapter)
+       lbs_deb_enter(LBS_DEB_HOST);
+
+       if (!priv)
                return NULL;
 
-       spin_lock_irqsave(&adapter->driver_lock, flags);
+       spin_lock_irqsave(&priv->driver_lock, flags);
 
-       if (!list_empty(&adapter->cmdfreeq)) {
-               tempnode = (struct cmd_ctrl_node *)adapter->cmdfreeq.next;
-               list_del((struct list_head *)tempnode);
+       if (!list_empty(&priv->cmdfreeq)) {
+               tempnode = list_first_entry(&priv->cmdfreeq,
+                                           struct cmd_ctrl_node, list);
+               list_del(&tempnode->list);
        } else {
-               lbs_deb_cmd("GET_CMD_NODE: cmd_ctrl_node is not available\n");
+               lbs_deb_host("GET_CMD_NODE: cmd_ctrl_node is not available\n");
                tempnode = NULL;
        }
 
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
-       if (tempnode) {
-               /*
-               lbs_pr_debug(3, "GET_CMD_NODE: cmdCtrlNode available\n");
-               lbs_pr_debug(3, "GET_CMD_NODE: cmdCtrlNode Address = %p\n",
-                      tempnode);
-               */
+       if (tempnode)
                cleanup_cmdnode(tempnode);
-       }
 
+       lbs_deb_leave(LBS_DEB_HOST);
        return tempnode;
 }
 
@@ -1575,44 +1633,47 @@ struct cmd_ctrl_node *libertas_get_free_cmd_ctrl_node(wlan_private * priv)
  */
 static void cleanup_cmdnode(struct cmd_ctrl_node *ptempnode)
 {
+       lbs_deb_enter(LBS_DEB_HOST);
+
        if (!ptempnode)
                return;
        ptempnode->cmdwaitqwoken = 1;
        wake_up_interruptible(&ptempnode->cmdwait_q);
-       ptempnode->status = 0;
-       ptempnode->cmd_oid = (u32) 0;
        ptempnode->wait_option = 0;
        ptempnode->pdata_buf = NULL;
+       ptempnode->callback = NULL;
+       ptempnode->callback_arg = 0;
 
        if (ptempnode->bufvirtualaddr != NULL)
                memset(ptempnode->bufvirtualaddr, 0, MRVDRV_SIZE_OF_CMD_BUFFER);
-       return;
+
+       lbs_deb_leave(LBS_DEB_HOST);
 }
 
 /**
  *  @brief This function initializes the command node.
  *
- *  @param priv                A pointer to wlan_private structure
+ *  @param priv                A pointer to struct lbs_private structure
  *  @param ptempnode   A pointer to cmd_ctrl_node structure
- *  @param cmd_oid     cmd oid: treated as sub command
  *  @param wait_option wait option: wait response or not
  *  @param pdata_buf   A pointer to informaion buffer
  *  @return            0 or -1
  */
-void libertas_set_cmd_ctrl_node(wlan_private * priv,
+void lbs_set_cmd_ctrl_node(struct lbs_private *priv,
                    struct cmd_ctrl_node *ptempnode,
-                   u32 cmd_oid, u16 wait_option, void *pdata_buf)
+                   u16 wait_option, void *pdata_buf)
 {
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
        if (!ptempnode)
                return;
 
-       ptempnode->cmd_oid = cmd_oid;
        ptempnode->wait_option = wait_option;
        ptempnode->pdata_buf = pdata_buf;
+       ptempnode->callback = NULL;
+       ptempnode->callback_arg = 0;
 
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_HOST);
 }
 
 /**
@@ -1620,59 +1681,59 @@ void libertas_set_cmd_ctrl_node(wlan_private * priv,
  *  pending queue. It will put fimware back to PS mode
  *  if applicable.
  *
- *  @param priv     A pointer to wlan_private structure
+ *  @param priv     A pointer to struct lbs_private structure
  *  @return       0 or -1
  */
-int libertas_execute_next_command(wlan_private * priv)
+int lbs_execute_next_command(struct lbs_private *priv)
 {
-       wlan_adapter *adapter = priv->adapter;
        struct cmd_ctrl_node *cmdnode = NULL;
        struct cmd_ds_command *cmdptr;
        unsigned long flags;
        int ret = 0;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       // Debug group is LBS_DEB_THREAD and not LBS_DEB_HOST, because the
+       // only caller to us is lbs_thread() and we get even when a
+       // data packet is received
+       lbs_deb_enter(LBS_DEB_THREAD);
 
-       spin_lock_irqsave(&adapter->driver_lock, flags);
+       spin_lock_irqsave(&priv->driver_lock, flags);
 
-       if (adapter->cur_cmd) {
-               lbs_pr_alert( "EXEC_NEXT_CMD: there is command in processing!\n");
-               spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       if (priv->cur_cmd) {
+               lbs_pr_alert( "EXEC_NEXT_CMD: already processing command!\n");
+               spin_unlock_irqrestore(&priv->driver_lock, flags);
                ret = -1;
                goto done;
        }
 
-       if (!list_empty(&adapter->cmdpendingq)) {
-               cmdnode = (struct cmd_ctrl_node *)
-                   adapter->cmdpendingq.next;
+       if (!list_empty(&priv->cmdpendingq)) {
+               cmdnode = list_first_entry(&priv->cmdpendingq,
+                                          struct cmd_ctrl_node, list);
        }
 
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
        if (cmdnode) {
-               lbs_deb_cmd(
-                      "EXEC_NEXT_CMD: Got next command from cmdpendingq\n");
                cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr;
 
                if (is_command_allowed_in_ps(cmdptr->command)) {
-                       if ((adapter->psstate == PS_STATE_SLEEP) ||
-                           (adapter->psstate == PS_STATE_PRE_SLEEP)) {
-                               lbs_deb_cmd(
-                                      "EXEC_NEXT_CMD: Cannot send cmd 0x%x in psstate %d\n",
+                       if ((priv->psstate == PS_STATE_SLEEP) ||
+                           (priv->psstate == PS_STATE_PRE_SLEEP)) {
+                               lbs_deb_host(
+                                      "EXEC_NEXT_CMD: cannot send cmd 0x%04x in psstate %d\n",
                                       le16_to_cpu(cmdptr->command),
-                                      adapter->psstate);
+                                      priv->psstate);
                                ret = -1;
                                goto done;
                        }
-                       lbs_deb_cmd("EXEC_NEXT_CMD: OK to send command "
-                              "0x%x in psstate %d\n",
+                       lbs_deb_host("EXEC_NEXT_CMD: OK to send command "
+                              "0x%04x in psstate %d\n",
                                    le16_to_cpu(cmdptr->command),
-                                   adapter->psstate);
-               } else if (adapter->psstate != PS_STATE_FULL_POWER) {
+                                   priv->psstate);
+               } else if (priv->psstate != PS_STATE_FULL_POWER) {
                        /*
                         * 1. Non-PS command:
                         * Queue it. set needtowakeup to TRUE if current state
-                        * is SLEEP, otherwise call libertas_ps_wakeup to send Exit_PS.
+                        * is SLEEP, otherwise call lbs_ps_wakeup to send Exit_PS.
                         * 2. PS command but not Exit_PS:
                         * Ignore it.
                         * 3. PS command Exit_PS:
@@ -1681,17 +1742,17 @@ int libertas_execute_next_command(wlan_private * priv)
                         * immediately.
                         */
                        if (cmdptr->command !=
-                           cpu_to_le16(cmd_802_11_ps_mode)) {
+                           cpu_to_le16(CMD_802_11_PS_MODE)) {
                                /*  Prepare to send Exit PS,
                                 *  this non PS command will be sent later */
-                               if ((adapter->psstate == PS_STATE_SLEEP)
-                                   || (adapter->psstate == PS_STATE_PRE_SLEEP)
+                               if ((priv->psstate == PS_STATE_SLEEP)
+                                   || (priv->psstate == PS_STATE_PRE_SLEEP)
                                    ) {
                                        /* w/ new scheme, it will not reach here.
                                           since it is blocked in main_thread. */
-                                       adapter->needtowakeup = 1;
+                                       priv->needtowakeup = 1;
                                } else
-                                       libertas_ps_wakeup(priv, 0);
+                                       lbs_ps_wakeup(priv, 0);
 
                                ret = 0;
                                goto done;
@@ -1703,38 +1764,38 @@ int libertas_execute_next_command(wlan_private * priv)
                                struct cmd_ds_802_11_ps_mode *psm =
                                    &cmdptr->params.psmode;
 
-                               lbs_deb_cmd(
-                                      "EXEC_NEXT_CMD: PS cmd- action=0x%x\n",
+                               lbs_deb_host(
+                                      "EXEC_NEXT_CMD: PS cmd, action 0x%02x\n",
                                       psm->action);
                                if (psm->action !=
-                                   cpu_to_le16(cmd_subcmd_exit_ps)) {
-                                       lbs_deb_cmd(
-                                              "EXEC_NEXT_CMD: Ignore Enter PS cmd\n");
-                                       list_del((struct list_head *)cmdnode);
-                                       libertas_cleanup_and_insert_cmd(priv, cmdnode);
+                                   cpu_to_le16(CMD_SUBCMD_EXIT_PS)) {
+                                       lbs_deb_host(
+                                              "EXEC_NEXT_CMD: ignore ENTER_PS cmd\n");
+                                       list_del(&cmdnode->list);
+                                       lbs_cleanup_and_insert_cmd(priv, cmdnode);
 
                                        ret = 0;
                                        goto done;
                                }
 
-                               if ((adapter->psstate == PS_STATE_SLEEP) ||
-                                   (adapter->psstate == PS_STATE_PRE_SLEEP)) {
-                                       lbs_deb_cmd(
-                                              "EXEC_NEXT_CMD: Ignore ExitPS cmd in sleep\n");
-                                       list_del((struct list_head *)cmdnode);
-                                       libertas_cleanup_and_insert_cmd(priv, cmdnode);
-                                       adapter->needtowakeup = 1;
+                               if ((priv->psstate == PS_STATE_SLEEP) ||
+                                   (priv->psstate == PS_STATE_PRE_SLEEP)) {
+                                       lbs_deb_host(
+                                              "EXEC_NEXT_CMD: ignore EXIT_PS cmd in sleep\n");
+                                       list_del(&cmdnode->list);
+                                       lbs_cleanup_and_insert_cmd(priv, cmdnode);
+                                       priv->needtowakeup = 1;
 
                                        ret = 0;
                                        goto done;
                                }
 
-                               lbs_deb_cmd(
-                                      "EXEC_NEXT_CMD: Sending Exit_PS down...\n");
+                               lbs_deb_host(
+                                      "EXEC_NEXT_CMD: sending EXIT_PS\n");
                        }
                }
-               list_del((struct list_head *)cmdnode);
-               lbs_deb_cmd("EXEC_NEXT_CMD: Sending 0x%04X command\n",
+               list_del(&cmdnode->list);
+               lbs_deb_host("EXEC_NEXT_CMD: sending command 0x%04x\n",
                            le16_to_cpu(cmdptr->command));
                DownloadcommandToStation(priv, cmdnode);
        } else {
@@ -1742,40 +1803,41 @@ int libertas_execute_next_command(wlan_private * priv)
                 * check if in power save mode, if yes, put the device back
                 * to PS mode
                 */
-               if ((adapter->psmode != wlan802_11powermodecam) &&
-                   (adapter->psstate == PS_STATE_FULL_POWER) &&
-                   (adapter->connect_status == libertas_connected)) {
-                       if (adapter->secinfo.WPAenabled ||
-                           adapter->secinfo.WPA2enabled) {
+               if ((priv->psmode != LBS802_11POWERMODECAM) &&
+                   (priv->psstate == PS_STATE_FULL_POWER) &&
+                   ((priv->connect_status == LBS_CONNECTED) ||
+                   (priv->mesh_connect_status == LBS_CONNECTED))) {
+                       if (priv->secinfo.WPAenabled ||
+                           priv->secinfo.WPA2enabled) {
                                /* check for valid WPA group keys */
-                               if (adapter->wpa_mcast_key.len ||
-                                   adapter->wpa_unicast_key.len) {
-                                       lbs_deb_cmd(
+                               if (priv->wpa_mcast_key.len ||
+                                   priv->wpa_unicast_key.len) {
+                                       lbs_deb_host(
                                               "EXEC_NEXT_CMD: WPA enabled and GTK_SET"
                                               " go back to PS_SLEEP");
-                                       libertas_ps_sleep(priv, 0);
+                                       lbs_ps_sleep(priv, 0);
                                }
                        } else {
-                               lbs_deb_cmd(
-                                      "EXEC_NEXT_CMD: command PendQ is empty,"
-                                      " go back to PS_SLEEP");
-                               libertas_ps_sleep(priv, 0);
+                               lbs_deb_host(
+                                      "EXEC_NEXT_CMD: cmdpendingq empty, "
+                                      "go back to PS_SLEEP");
+                               lbs_ps_sleep(priv, 0);
                        }
                }
        }
 
        ret = 0;
 done:
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_THREAD);
        return ret;
 }
 
-void libertas_send_iwevcustom_event(wlan_private * priv, s8 * str)
+void lbs_send_iwevcustom_event(struct lbs_private *priv, s8 *str)
 {
        union iwreq_data iwrq;
        u8 buf[50];
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_WEXT);
 
        memset(&iwrq, 0, sizeof(union iwreq_data));
        memset(buf, 0, sizeof(buf));
@@ -1785,136 +1847,225 @@ void libertas_send_iwevcustom_event(wlan_private * priv, s8 * str)
        iwrq.data.length = strlen(buf) + 1 + IW_EV_LCP_LEN;
 
        /* Send Event to upper layer */
-       lbs_deb_cmd("Event Indication string = %s\n", (char *)buf);
-       lbs_deb_cmd("Event Indication String length = %d\n", iwrq.data.length);
+       lbs_deb_wext("event indication string %s\n", (char *)buf);
+       lbs_deb_wext("event indication length %d\n", iwrq.data.length);
+       lbs_deb_wext("sending wireless event IWEVCUSTOM for %s\n", str);
 
-       lbs_deb_cmd("Sending wireless event IWEVCUSTOM for %s\n", str);
        wireless_send_event(priv->dev, IWEVCUSTOM, &iwrq, buf);
 
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_WEXT);
 }
 
-static int sendconfirmsleep(wlan_private * priv, u8 * cmdptr, u16 size)
+static int sendconfirmsleep(struct lbs_private *priv, u8 *cmdptr, u16 size)
 {
        unsigned long flags;
-       wlan_adapter *adapter = priv->adapter;
        int ret = 0;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
-       lbs_deb_cmd("SEND_SLEEPC_CMD: Before download, size of cmd = %d\n",
+       lbs_deb_host("SEND_SLEEPC_CMD: before download, cmd size %d\n",
               size);
 
-       lbs_dbg_hex("SEND_SLEEPC_CMD: Sleep confirm command", cmdptr, size);
+       lbs_deb_hex(LBS_DEB_HOST, "sleep confirm command", cmdptr, size);
 
        ret = priv->hw_host_to_card(priv, MVMS_CMD, cmdptr, size);
        priv->dnld_sent = DNLD_RES_RECEIVED;
 
-       spin_lock_irqsave(&adapter->driver_lock, flags);
-       if (adapter->intcounter || adapter->currenttxskb)
-               lbs_deb_cmd("SEND_SLEEPC_CMD: intcounter=%d currenttxskb=%p\n",
-                      adapter->intcounter, adapter->currenttxskb);
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       spin_lock_irqsave(&priv->driver_lock, flags);
+       if (priv->intcounter || priv->currenttxskb)
+               lbs_deb_host("SEND_SLEEPC_CMD: intcounter %d, currenttxskb %p\n",
+                      priv->intcounter, priv->currenttxskb);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
        if (ret) {
                lbs_pr_alert(
                       "SEND_SLEEPC_CMD: Host to Card failed for Confirm Sleep\n");
        } else {
-               spin_lock_irqsave(&adapter->driver_lock, flags);
-               if (!adapter->intcounter) {
-                       adapter->psstate = PS_STATE_SLEEP;
+               spin_lock_irqsave(&priv->driver_lock, flags);
+               if (!priv->intcounter) {
+                       priv->psstate = PS_STATE_SLEEP;
                } else {
-                       lbs_deb_cmd("SEND_SLEEPC_CMD: After sent,IntC=%d\n",
-                              adapter->intcounter);
+                       lbs_deb_host("SEND_SLEEPC_CMD: after sent, intcounter %d\n",
+                              priv->intcounter);
                }
-               spin_unlock_irqrestore(&adapter->driver_lock, flags);
+               spin_unlock_irqrestore(&priv->driver_lock, flags);
 
-               lbs_deb_cmd("SEND_SLEEPC_CMD: Sent Confirm Sleep command\n");
-               lbs_deb_cmd("+");
+               lbs_deb_host("SEND_SLEEPC_CMD: sent confirm sleep\n");
        }
 
-       lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
+       lbs_deb_leave_args(LBS_DEB_HOST, "ret %d", ret);
        return ret;
 }
 
-void libertas_ps_sleep(wlan_private * priv, int wait_option)
+void lbs_ps_sleep(struct lbs_private *priv, int wait_option)
 {
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
        /*
         * PS is currently supported only in Infrastructure mode
         * Remove this check if it is to be supported in IBSS mode also
         */
 
-       libertas_prepare_and_send_command(priv, cmd_802_11_ps_mode,
-                             cmd_subcmd_enter_ps, wait_option, 0, NULL);
+       lbs_prepare_and_send_command(priv, CMD_802_11_PS_MODE,
+                             CMD_SUBCMD_ENTER_PS, wait_option, 0, NULL);
 
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_HOST);
 }
 
 /**
- *  @brief This function sends Eixt_PS command to firmware.
+ *  @brief This function sends Exit_PS command to firmware.
  *
- *  @param priv        A pointer to wlan_private structure
+ *  @param priv        A pointer to struct lbs_private structure
  *  @param wait_option wait response or not
  *  @return            n/a
  */
-void libertas_ps_wakeup(wlan_private * priv, int wait_option)
+void lbs_ps_wakeup(struct lbs_private *priv, int wait_option)
 {
        __le32 Localpsmode;
 
-       lbs_deb_enter(LBS_DEB_CMD);
-
-       Localpsmode = cpu_to_le32(wlan802_11powermodecam);
+       lbs_deb_enter(LBS_DEB_HOST);
 
-       lbs_deb_cmd("Exit_PS: Localpsmode = %d\n", wlan802_11powermodecam);
+       Localpsmode = cpu_to_le32(LBS802_11POWERMODECAM);
 
-       libertas_prepare_and_send_command(priv, cmd_802_11_ps_mode,
-                             cmd_subcmd_exit_ps,
+       lbs_prepare_and_send_command(priv, CMD_802_11_PS_MODE,
+                             CMD_SUBCMD_EXIT_PS,
                              wait_option, 0, &Localpsmode);
 
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_HOST);
 }
 
 /**
  *  @brief This function checks condition and prepares to
  *  send sleep confirm command to firmware if ok.
  *
- *  @param priv        A pointer to wlan_private structure
+ *  @param priv        A pointer to struct lbs_private structure
  *  @param psmode      Power Saving mode
  *  @return            n/a
  */
-void libertas_ps_confirm_sleep(wlan_private * priv, u16 psmode)
+void lbs_ps_confirm_sleep(struct lbs_private *priv, u16 psmode)
 {
        unsigned long flags =0;
-       wlan_adapter *adapter = priv->adapter;
        u8 allowed = 1;
 
-       lbs_deb_enter(LBS_DEB_CMD);
+       lbs_deb_enter(LBS_DEB_HOST);
 
        if (priv->dnld_sent) {
                allowed = 0;
-               lbs_deb_cmd("D");
+               lbs_deb_host("dnld_sent was set");
        }
 
-       spin_lock_irqsave(&adapter->driver_lock, flags);
-       if (adapter->cur_cmd) {
+       spin_lock_irqsave(&priv->driver_lock, flags);
+       if (priv->cur_cmd) {
                allowed = 0;
-               lbs_deb_cmd("C");
+               lbs_deb_host("cur_cmd was set");
        }
-       if (adapter->intcounter > 0) {
+       if (priv->intcounter > 0) {
                allowed = 0;
-               lbs_deb_cmd("I%d", adapter->intcounter);
+               lbs_deb_host("intcounter %d", priv->intcounter);
        }
-       spin_unlock_irqrestore(&adapter->driver_lock, flags);
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 
        if (allowed) {
-               lbs_deb_cmd("Sending libertas_ps_confirm_sleep\n");
-               sendconfirmsleep(priv, (u8 *) & adapter->libertas_ps_confirm_sleep,
+               lbs_deb_host("sending lbs_ps_confirm_sleep\n");
+               sendconfirmsleep(priv, (u8 *) & priv->lbs_ps_confirm_sleep,
                                 sizeof(struct PS_CMD_ConfirmSleep));
        } else {
-               lbs_deb_cmd("Sleep Confirm has been delayed\n");
+               lbs_deb_host("sleep confirm has been delayed\n");
        }
 
-       lbs_deb_leave(LBS_DEB_CMD);
+       lbs_deb_leave(LBS_DEB_HOST);
 }
+
+
+/**
+ *  @brief Simple way to call firmware functions
+ *
+ *  @param priv        A pointer to struct lbs_private structure
+ *  @param psmode      one of the many CMD_802_11_xxxx
+ *  @param cmd          pointer to the parameters structure for above command
+ *                      (this should not include the command, size, sequence
+ *                      and result fields from struct cmd_ds_gen)
+ *  @param cmd_size     size structure pointed to by cmd
+ *  @param rsp          pointer to an area where the result should be placed
+ *  @param rsp_size     pointer to the size of the rsp area. If the firmware
+ *                      returns fewer bytes, then this *rsp_size will be
+ *                      changed to the actual size.
+ *  @return            -1 in case of a higher level error, otherwise
+ *                      the result code from the firmware
+ */
+
+int __lbs_cmd(struct lbs_private *priv, uint16_t command, void *cmd, int cmd_size,
+             int (*callback)(struct lbs_private *, unsigned long, struct cmd_ds_command *),
+             unsigned long callback_arg)
+{
+       struct cmd_ctrl_node *cmdnode;
+       struct cmd_ds_gen *cmdptr;
+       unsigned long flags;
+       int ret = 0;
+
+       lbs_deb_enter(LBS_DEB_HOST);
+
+       if (!priv) {
+               lbs_deb_host("PREP_CMD: priv is NULL\n");
+               ret = -1;
+               goto done;
+       }
+
+       if (priv->surpriseremoved) {
+               lbs_deb_host("PREP_CMD: card removed\n");
+               ret = -1;
+               goto done;
+       }
+
+       cmdnode = lbs_get_cmd_ctrl_node(priv);
+
+       if (cmdnode == NULL) {
+               lbs_deb_host("PREP_CMD: cmdnode is NULL\n");
+
+               /* Wake up main thread to execute next command */
+               wake_up_interruptible(&priv->waitq);
+               ret = -1;
+               goto done;
+       }
+
+       cmdptr = (struct cmd_ds_gen *)cmdnode->bufvirtualaddr;
+       cmdnode->wait_option = CMD_OPTION_WAITFORRSP;
+       cmdnode->callback = callback;
+       cmdnode->callback_arg = callback_arg;
+
+       /* Set sequence number, clean result, move to buffer */
+       priv->seqnum++;
+       cmdptr->command = cpu_to_le16(command);
+       cmdptr->size    = cpu_to_le16(cmd_size + S_DS_GEN);
+       cmdptr->seqnum = cpu_to_le16(priv->seqnum);
+       cmdptr->result = 0;
+       memcpy(cmdptr->cmdresp, cmd, cmd_size);
+
+       lbs_deb_host("PREP_CMD: command 0x%04x\n", command);
+
+       /* here was the big old switch() statement, which is now obsolete,
+        * because the caller of lbs_cmd() sets up all of *cmd for us. */
+
+       cmdnode->cmdwaitqwoken = 0;
+       lbs_queue_cmd(priv, cmdnode, 1);
+       wake_up_interruptible(&priv->waitq);
+
+       might_sleep();
+       wait_event_interruptible(cmdnode->cmdwait_q, cmdnode->cmdwaitqwoken);
+
+       spin_lock_irqsave(&priv->driver_lock, flags);
+       if (priv->cur_cmd_retcode) {
+               lbs_deb_host("PREP_CMD: command failed with return code %d\n",
+                      priv->cur_cmd_retcode);
+               priv->cur_cmd_retcode = 0;
+               ret = -1;
+       }
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
+
+done:
+       lbs_deb_leave_args(LBS_DEB_HOST, "ret %d", ret);
+       return ret;
+}
+EXPORT_SYMBOL_GPL(__lbs_cmd);
+
+