]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/net/wireless/libertas/if_usb.c
libertas: rename and re-type bufvirtualaddr to cmdbuf
[linux-2.6-omap-h63xx.git] / drivers / net / wireless / libertas / if_usb.c
index cb59f46ed126471816cee87712f89ee32d2cd4ef..5f2d944312a5c8f0486e7767ba0fe04b8ad59ba7 100644 (file)
@@ -5,7 +5,6 @@
 #include <linux/moduleparam.h>
 #include <linux/firmware.h>
 #include <linux/netdevice.h>
-#include <linux/list.h>
 #include <linux/usb.h>
 
 #define DRV_NAME "usb8xxx"
 #include "decl.h"
 #include "defs.h"
 #include "dev.h"
+#include "cmd.h"
 #include "if_usb.h"
 
 #define MESSAGE_HEADER_LEN     4
 
-static const char usbdriver_name[] = "usb8xxx";
-static u8 *default_fw_name = "usb8388.bin";
-
-static char *libertas_fw_name = NULL;
-module_param_named(fw_name, libertas_fw_name, charp, 0644);
-
-/*
- * We need to send a RESET command to all USB devices before
- * we tear down the USB connection. Otherwise we would not
- * be able to re-init device the device if the module gets
- * loaded again. This is a list of all initialized USB devices,
- * for the reset code see if_usb_reset_device()
-*/
-static LIST_HEAD(usb_devices);
+static char *lbs_fw_name = "usb8388.bin";
+module_param_named(fw_name, lbs_fw_name, charp, 0644);
 
 static struct usb_device_id if_usb_table[] = {
        /* Enter the device signature inside */
@@ -45,9 +33,12 @@ MODULE_DEVICE_TABLE(usb, if_usb_table);
 static void if_usb_receive(struct urb *urb);
 static void if_usb_receive_fwload(struct urb *urb);
 static int if_usb_prog_firmware(struct usb_card_rec *cardp);
-static int if_usb_host_to_card(wlan_private * priv, u8 type, u8 * payload, u16 nb);
-static int if_usb_get_int_status(wlan_private * priv, u8 *);
-static int if_usb_read_event_cause(wlan_private *);
+static int if_usb_host_to_card(struct lbs_private *priv,
+       u8 type,
+       u8 *payload,
+       u16 nb);
+static int if_usb_get_int_status(struct lbs_private *priv, u8 *);
+static int if_usb_read_event_cause(struct lbs_private *);
 static int usb_tx_block(struct usb_card_rec *cardp, u8 *payload, u16 nb);
 static void if_usb_free(struct usb_card_rec *cardp);
 static int if_usb_submit_rx_urb(struct usb_card_rec *cardp);
@@ -65,7 +56,7 @@ static void if_usb_write_bulk_callback(struct urb *urb)
        /* handle the transmission complete validations */
 
        if (urb->status == 0) {
-               wlan_private *priv = cardp->priv;
+               struct lbs_private *priv = cardp->priv;
 
                /*
                lbs_deb_usbd(&urb->dev->dev, "URB status is successfull\n");
@@ -76,21 +67,8 @@ static void if_usb_write_bulk_callback(struct urb *urb)
                /* Used for both firmware TX and regular TX.  priv isn't
                 * valid at firmware load time.
                 */
-               if (priv) {
-                       wlan_adapter *adapter = priv->adapter;
-                       struct net_device *dev = priv->dev;
-
-                       priv->dnld_sent = DNLD_RES_RECEIVED;
-
-                       /* Wake main thread if commands are pending */
-                       if (!adapter->cur_cmd)
-                               wake_up_interruptible(&priv->waitq);
-
-                       if ((adapter->connect_status == LIBERTAS_CONNECTED)) {
-                               netif_wake_queue(dev);
-                               netif_wake_queue(priv->mesh_dev);
-                       }
-               }
+               if (priv)
+                       lbs_host_to_card_done(priv);
        } else {
                /* print the failure status number for debug */
                lbs_pr_info("URB in failure status: %d\n", urb->status);
@@ -124,6 +102,29 @@ static void if_usb_free(struct usb_card_rec *cardp)
        lbs_deb_leave(LBS_DEB_USB);
 }
 
+static void if_usb_set_boot2_ver(struct lbs_private *priv)
+{
+       struct cmd_ds_set_boot2_ver b2_cmd;
+
+       b2_cmd.action = 0;
+       b2_cmd.version = priv->boot2_version;
+
+       if (lbs_cmd(priv, CMD_SET_BOOT2_VER, b2_cmd, NULL, 0))
+               lbs_deb_usb("Setting boot2 version failed\n");
+}
+
+void if_usb_fw_timeo(unsigned long priv)
+{
+       struct usb_card_rec *cardp = (void *)priv;
+
+       if (cardp->fwdnldover) {
+               lbs_deb_usb("Download complete, no event. Assuming success\n");
+       } else {
+               lbs_pr_err("Download timed out\n");
+               cardp->surprise_removed = 1;
+       }
+       wake_up(&cardp->fw_wq);
+}
 /**
  *  @brief sets the configuration values
  *  @param ifnum       interface number
@@ -136,7 +137,7 @@ static int if_usb_probe(struct usb_interface *intf,
        struct usb_device *udev;
        struct usb_host_interface *iface_desc;
        struct usb_endpoint_descriptor *endpoint;
-       wlan_private *priv;
+       struct lbs_private *priv;
        struct usb_card_rec *cardp;
        int i;
 
@@ -148,6 +149,9 @@ static int if_usb_probe(struct usb_interface *intf,
                goto error;
        }
 
+       setup_timer(&cardp->fw_timeout, if_usb_fw_timeo, (unsigned long)cardp);
+       init_waitqueue_head(&cardp->fw_wq);
+                                                                    
        cardp->udev = udev;
        iface_desc = intf->cur_altsetting;
 
@@ -222,12 +226,13 @@ static int if_usb_probe(struct usb_interface *intf,
                goto err_prog_firmware;
        }
 
-       if (!(priv = libertas_add_card(cardp, &udev->dev)))
+       if (!(priv = lbs_add_card(cardp, &udev->dev)))
                goto err_prog_firmware;
 
        cardp->priv = priv;
+       cardp->priv->fw_ready = 1;
 
-       if (libertas_add_mesh(priv, &udev->dev))
+       if (lbs_add_mesh(priv, &udev->dev))
                goto err_add_mesh;
 
        cardp->eth_dev = priv->dev;
@@ -237,15 +242,12 @@ static int if_usb_probe(struct usb_interface *intf,
        priv->hw_read_event_cause = if_usb_read_event_cause;
        priv->boot2_version = udev->descriptor.bcdDevice;
 
-       /* Delay 200 ms to waiting for the FW ready */
        if_usb_submit_rx_urb(cardp);
-       msleep_interruptible(200);
-       priv->adapter->fw_ready = 1;
 
-       if (libertas_start_card(priv))
+       if (lbs_start_card(priv))
                goto err_start_card;
 
-       list_add_tail(&cardp->list, &usb_devices);
+       if_usb_set_boot2_ver(priv);
 
        usb_get_dev(udev);
        usb_set_intfdata(intf, cardp);
@@ -253,9 +255,9 @@ static int if_usb_probe(struct usb_interface *intf,
        return 0;
 
 err_start_card:
-       libertas_remove_mesh(priv);
+       lbs_remove_mesh(priv);
 err_add_mesh:
-       libertas_remove_card(priv);
+       lbs_remove_card(priv);
 err_prog_firmware:
        if_usb_reset_device(cardp);
 dealloc:
@@ -273,24 +275,25 @@ error:
 static void if_usb_disconnect(struct usb_interface *intf)
 {
        struct usb_card_rec *cardp = usb_get_intfdata(intf);
-       wlan_private *priv = (wlan_private *) cardp->priv;
+       struct lbs_private *priv = (struct lbs_private *) cardp->priv;
 
        lbs_deb_enter(LBS_DEB_MAIN);
 
        /* Update Surprise removed to TRUE */
        cardp->surprise_removed = 1;
 
-       list_del(&cardp->list);
-
        if (priv) {
-               wlan_adapter *adapter = priv->adapter;
 
-               adapter->surpriseremoved = 1;
-               libertas_stop_card(priv);
-               libertas_remove_mesh(priv);
-               libertas_remove_card(priv);
+               priv->surpriseremoved = 1;
+               lbs_stop_card(priv);
+               lbs_remove_mesh(priv);
+               lbs_remove_card(priv);
        }
 
+       /* this is (apparently?) necessary for future usage of the device */
+       lbs_prepare_and_send_command(priv, CMD_802_11_RESET, CMD_ACT_HALT,
+                       0, 0, NULL);
+
        /* Unlink and free urb */
        if_usb_free(cardp);
 
@@ -302,10 +305,10 @@ static void if_usb_disconnect(struct usb_interface *intf)
 
 /**
  *  @brief  This function download FW
- *  @param priv                pointer to wlan_private
+ *  @param priv                pointer to struct lbs_private
  *  @return            0
  */
-static int if_prog_firmware(struct usb_card_rec *cardp)
+static int if_usb_send_fw_pkt(struct usb_card_rec *cardp)
 {
        struct FWData *fwdata;
        struct fwheader *fwheader;
@@ -384,20 +387,23 @@ static int if_prog_firmware(struct usb_card_rec *cardp)
 
 static int if_usb_reset_device(struct usb_card_rec *cardp)
 {
+       struct cmd_ds_command *cmd = (void *)&cardp->bulk_out_buffer[4];
        int ret;
-       wlan_private * priv = cardp->priv;
 
        lbs_deb_enter(LBS_DEB_USB);
 
-       /* Try a USB port reset first, if that fails send the reset
-        * command to the firmware.
-        */
+       *(__le32 *)cardp->bulk_out_buffer = cpu_to_le32(CMD_TYPE_REQUEST);
+
+       cmd->command = cpu_to_le16(CMD_802_11_RESET);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_reset) + S_DS_GEN);
+       cmd->result = cpu_to_le16(0);
+       cmd->seqnum = cpu_to_le16(0x5a5a);
+       cmd->params.reset.action = cpu_to_le16(CMD_ACT_HALT);
+       usb_tx_block(cardp, cardp->bulk_out_buffer, 4 + S_DS_GEN + sizeof(struct cmd_ds_802_11_reset));
+
+       msleep(100);
        ret = usb_reset_device(cardp->udev);
-       if (!ret && priv) {
-               msleep(10);
-               ret = libertas_reset_device(priv);
-               msleep(10);
-       }
+       msleep(100);
 
        lbs_deb_leave_args(LBS_DEB_USB, "ret %d", ret);
 
@@ -406,7 +412,7 @@ static int if_usb_reset_device(struct usb_card_rec *cardp)
 
 /**
  *  @brief This function transfer the data to the device.
- *  @param priv        pointer to wlan_private
+ *  @param priv        pointer to struct lbs_private
  *  @param payload     pointer to payload data
  *  @param nb          data length
  *  @return            0 or -1
@@ -430,7 +436,7 @@ static int usb_tx_block(struct usb_card_rec *cardp, u8 * payload, u16 nb)
 
        if ((ret = usb_submit_urb(cardp->tx_urb, GFP_ATOMIC))) {
                /*  transfer failed */
-               lbs_deb_usbd(&cardp->udev->dev, "usb_submit_urb failed\n");
+               lbs_deb_usbd(&cardp->udev->dev, "usb_submit_urb failed: %d\n", ret);
                ret = -1;
        } else {
                /* lbs_deb_usbd(&cardp->udev->dev, "usb_submit_urb success\n"); */
@@ -468,7 +474,9 @@ static int __if_usb_submit_rx_urb(struct usb_card_rec *cardp,
        /* lbs_deb_usbd(&cardp->udev->dev, "Pointer for rx_urb %p\n", cardp->rx_urb); */
        if ((ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC))) {
                /* handle failure conditions */
-               lbs_deb_usbd(&cardp->udev->dev, "Submit Rx URB failed\n");
+               lbs_deb_usbd(&cardp->udev->dev, "Submit Rx URB failed: %d\n", ret);
+               kfree_skb(skb);
+               rinfo->skb = NULL;
                ret = -1;
        } else {
                /* lbs_deb_usbd(&cardp->udev->dev, "Submit Rx URB success\n"); */
@@ -504,7 +512,22 @@ static void if_usb_receive_fwload(struct urb *urb)
                return;
        }
 
-       if (cardp->bootcmdresp == 0) {
+       if (cardp->fwdnldover) {
+               __le32 *tmp = (__le32 *)(skb->data + IPFIELD_ALIGN_OFFSET);
+
+               if (tmp[0] == cpu_to_le32(CMD_TYPE_INDICATION) &&
+                   tmp[1] == cpu_to_le32(MACREG_INT_CODE_FIRMWARE_READY)) {
+                       lbs_pr_info("Firmware ready event received\n");
+                       wake_up(&cardp->fw_wq);
+               } else {
+                       lbs_deb_usb("Waiting for confirmation; got %x %x\n", le32_to_cpu(tmp[0]),
+                                   le32_to_cpu(tmp[1]));
+                       if_usb_submit_rx_urb_fwload(cardp);
+               }
+               kfree_skb(skb);
+               return;
+       }
+       if (cardp->bootcmdresp <= 0) {
                memcpy (&bootcmdresp, skb->data + IPFIELD_ALIGN_OFFSET,
                        sizeof(bootcmdresp));
                if (le16_to_cpu(cardp->udev->descriptor.bcdDevice) < 0x3106) {
@@ -516,9 +539,16 @@ static void if_usb_receive_fwload(struct urb *urb)
                        return;
                }
                if (bootcmdresp.u32magicnumber != cpu_to_le32(BOOT_CMD_MAGIC_NUMBER)) {
-                       lbs_pr_info(
-                               "boot cmd response wrong magic number (0x%x)\n",
-                               le32_to_cpu(bootcmdresp.u32magicnumber));
+                       if (bootcmdresp.u32magicnumber == cpu_to_le32(CMD_TYPE_REQUEST) ||
+                           bootcmdresp.u32magicnumber == cpu_to_le32(CMD_TYPE_DATA) ||
+                           bootcmdresp.u32magicnumber == cpu_to_le32(CMD_TYPE_INDICATION)) {
+                               if (!cardp->bootcmdresp)
+                                       lbs_pr_info("Firmware already seems alive; resetting\n");
+                               cardp->bootcmdresp = -1;
+                       } else {
+                               lbs_pr_info("boot cmd response wrong magic number (0x%x)\n",
+                                           le32_to_cpu(bootcmdresp.u32magicnumber));
+                       }
                } else if (bootcmdresp.u8cmd_tag != BOOT_CMD_FW_BY_USB) {
                        lbs_pr_info(
                                "boot cmd response cmd_tag error (%d)\n",
@@ -564,26 +594,29 @@ static void if_usb_receive_fwload(struct urb *urb)
 
        kfree_skb(skb);
 
+       /* reschedule timer for 200ms hence */
+       mod_timer(&cardp->fw_timeout, jiffies + (HZ/5));
+
        if (cardp->fwfinalblk) {
                cardp->fwdnldover = 1;
                goto exit;
        }
 
-       if_prog_firmware(cardp);
+       if_usb_send_fw_pkt(cardp);
 
+ exit:
        if_usb_submit_rx_urb_fwload(cardp);
-exit:
+
        kfree(syncfwheader);
 
        return;
-
 }
 
 #define MRVDRV_MIN_PKT_LEN     30
 
 static inline void process_cmdtypedata(int recvlength, struct sk_buff *skb,
                                       struct usb_card_rec *cardp,
-                                      wlan_private *priv)
+                                      struct lbs_private *priv)
 {
        if (recvlength > MRVDRV_ETH_RX_PACKET_BUFFER_SIZE +
            MESSAGE_HEADER_LEN || recvlength < MRVDRV_MIN_PKT_LEN) {
@@ -596,17 +629,17 @@ static inline void process_cmdtypedata(int recvlength, struct sk_buff *skb,
        skb_reserve(skb, IPFIELD_ALIGN_OFFSET);
        skb_put(skb, recvlength);
        skb_pull(skb, MESSAGE_HEADER_LEN);
-       libertas_process_rxed_packet(priv, skb);
+       lbs_process_rxed_packet(priv, skb);
        priv->upld_len = (recvlength - MESSAGE_HEADER_LEN);
 }
 
 static inline void process_cmdrequest(int recvlength, u8 *recvbuff,
                                      struct sk_buff *skb,
                                      struct usb_card_rec *cardp,
-                                     wlan_private *priv)
+                                     struct lbs_private *priv)
 {
        u8 *cmdbuf;
-       if (recvlength > MRVDRV_SIZE_OF_CMD_BUFFER) {
+       if (recvlength > LBS_CMD_BUFFER_SIZE) {
                lbs_deb_usbd(&cardp->udev->dev,
                            "The receive buffer is too large\n");
                kfree_skb(skb);
@@ -616,14 +649,14 @@ static inline void process_cmdrequest(int recvlength, u8 *recvbuff,
        if (!in_interrupt())
                BUG();
 
-       spin_lock(&priv->adapter->driver_lock);
+       spin_lock(&priv->driver_lock);
        /* take care of cur_cmd = NULL case by reading the
         * data to clear the interrupt */
-       if (!priv->adapter->cur_cmd) {
+       if (!priv->cur_cmd) {
                cmdbuf = priv->upld_buf;
-               priv->adapter->hisregcpy &= ~MRVDRV_CMD_UPLD_RDY;
+               priv->hisregcpy &= ~MRVDRV_CMD_UPLD_RDY;
        } else
-               cmdbuf = priv->adapter->cur_cmd->bufvirtualaddr;
+               cmdbuf = (u8 *) priv->cur_cmd->cmdbuf;
 
        cardp->usb_int_cause |= MRVDRV_CMD_UPLD_RDY;
        priv->upld_len = (recvlength - MESSAGE_HEADER_LEN);
@@ -631,8 +664,8 @@ static inline void process_cmdrequest(int recvlength, u8 *recvbuff,
               priv->upld_len);
 
        kfree_skb(skb);
-       libertas_interrupt(priv->dev);
-       spin_unlock(&priv->adapter->driver_lock);
+       lbs_interrupt(priv);
+       spin_unlock(&priv->driver_lock);
 
        lbs_deb_usbd(&cardp->udev->dev,
                    "Wake up main thread to handle cmd response\n");
@@ -652,7 +685,7 @@ static void if_usb_receive(struct urb *urb)
        struct read_cb_info *rinfo = (struct read_cb_info *)urb->context;
        struct sk_buff *skb = rinfo->skb;
        struct usb_card_rec *cardp = (struct usb_card_rec *) rinfo->cardp;
-       wlan_private * priv = cardp->priv;
+       struct lbs_private *priv = cardp->priv;
 
        int recvlength = urb->actual_length;
        u8 *recvbuff = NULL;
@@ -676,8 +709,10 @@ static void if_usb_receive(struct urb *urb)
                lbs_deb_usbd(&cardp->udev->dev,
                            "Recv length = 0x%x, Recv type = 0x%X\n",
                            recvlength, recvtype);
-       } else if (urb->status)
+       } else if (urb->status) {
+               kfree_skb(skb);
                goto rx_exit;
+       }
 
        switch (recvtype) {
        case CMD_TYPE_DATA:
@@ -690,20 +725,20 @@ static void if_usb_receive(struct urb *urb)
 
        case CMD_TYPE_INDICATION:
                /* Event cause handling */
-               spin_lock(&priv->adapter->driver_lock);
+               spin_lock(&priv->driver_lock);
                cardp->usb_event_cause = le32_to_cpu(*(__le32 *) (recvbuff + MESSAGE_HEADER_LEN));
                lbs_deb_usbd(&cardp->udev->dev,"**EVENT** 0x%X\n",
                            cardp->usb_event_cause);
                if (cardp->usb_event_cause & 0xffff0000) {
-                       libertas_send_tx_feedback(priv);
-                       spin_unlock(&priv->adapter->driver_lock);
+                       lbs_send_tx_feedback(priv);
+                       spin_unlock(&priv->driver_lock);
                        break;
                }
                cardp->usb_event_cause <<= 3;
                cardp->usb_int_cause |= MRVDRV_CARDEVENT;
                kfree_skb(skb);
-               libertas_interrupt(priv->dev);
-               spin_unlock(&priv->adapter->driver_lock);
+               lbs_interrupt(priv);
+               spin_unlock(&priv->driver_lock);
                goto rx_exit;
        default:
                lbs_deb_usbd(&cardp->udev->dev, "Unknown command type 0x%X\n",
@@ -720,13 +755,16 @@ rx_exit:
 
 /**
  *  @brief This function downloads data to FW
- *  @param priv                pointer to wlan_private structure
+ *  @param priv                pointer to struct lbs_private structure
  *  @param type                type of data
  *  @param buf         pointer to data buffer
  *  @param len         number of bytes
  *  @return            0 or -1
  */
-static int if_usb_host_to_card(wlan_private * priv, u8 type, u8 * payload, u16 nb)
+static int if_usb_host_to_card(struct lbs_private *priv,
+       u8 type,
+       u8 *payload,
+       u16 nb)
 {
        struct usb_card_rec *cardp = (struct usb_card_rec *)priv->card;
 
@@ -752,8 +790,8 @@ static int if_usb_host_to_card(wlan_private * priv, u8 type, u8 * payload, u16 n
                            nb + MESSAGE_HEADER_LEN);
 }
 
-/* called with adapter->driver_lock held */
-static int if_usb_get_int_status(wlan_private * priv, u8 * ireg)
+/* called with priv->driver_lock held */
+static int if_usb_get_int_status(struct lbs_private *priv, u8 *ireg)
 {
        struct usb_card_rec *cardp = priv->card;
 
@@ -765,11 +803,11 @@ static int if_usb_get_int_status(wlan_private * priv, u8 * ireg)
        return 0;
 }
 
-static int if_usb_read_event_cause(wlan_private * priv)
+static int if_usb_read_event_cause(struct lbs_private *priv)
 {
        struct usb_card_rec *cardp = priv->card;
 
-       priv->adapter->eventcause = cardp->usb_event_cause;
+       priv->eventcause = cardp->usb_event_cause;
        /* Re-submit rx urb here to avoid event lost issue */
        if_usb_submit_rx_urb(cardp);
        return 0;
@@ -856,10 +894,10 @@ static int if_usb_prog_firmware(struct usb_card_rec *cardp)
 
        lbs_deb_enter(LBS_DEB_USB);
 
-       if ((ret = request_firmware(&cardp->fw, libertas_fw_name,
+       if ((ret = request_firmware(&cardp->fw, lbs_fw_name,
                                    &cardp->udev->dev)) < 0) {
                lbs_pr_err("request_firmware() failed with %#x\n", ret);
-               lbs_pr_err("firmware %s not found\n", libertas_fw_name);
+               lbs_pr_err("firmware %s not found\n", lbs_fw_name);
                goto done;
        }
 
@@ -886,7 +924,7 @@ restart:
                } while (cardp->bootcmdresp == 0 && j < 10);
        } while (cardp->bootcmdresp == 0 && i < 5);
 
-       if (cardp->bootcmdresp == 0) {
+       if (cardp->bootcmdresp <= 0) {
                if (--reset_count >= 0) {
                        if_usb_reset_device(cardp);
                        goto restart;
@@ -904,15 +942,14 @@ restart:
        cardp->totalbytes = 0;
        cardp->fwfinalblk = 0;
 
-       if_prog_firmware(cardp);
+       /* Send the first firmware packet... */
+       if_usb_send_fw_pkt(cardp);
 
-       do {
-               lbs_deb_usbd(&cardp->udev->dev,"Wlan sched timeout\n");
-               i++;
-               msleep_interruptible(100);
-               if (cardp->surprise_removed || i >= 20)
-                       break;
-       } while (!cardp->fwdnldover);
+       /* ... and wait for the process to complete */
+       wait_event_interruptible(cardp->fw_wq, cardp->surprise_removed || cardp->fwdnldover);
+       
+       del_timer_sync(&cardp->fw_timeout);
+       usb_kill_urb(cardp->rx_urb);
 
        if (!cardp->fwdnldover) {
                lbs_pr_info("failed to load fw, resetting device!\n");
@@ -940,11 +977,11 @@ done:
 static int if_usb_suspend(struct usb_interface *intf, pm_message_t message)
 {
        struct usb_card_rec *cardp = usb_get_intfdata(intf);
-       wlan_private *priv = cardp->priv;
+       struct lbs_private *priv = cardp->priv;
 
        lbs_deb_enter(LBS_DEB_USB);
 
-       if (priv->adapter->psstate != PS_STATE_FULL_POWER)
+       if (priv->psstate != PS_STATE_FULL_POWER)
                return -1;
 
        if (priv->mesh_dev && !priv->mesh_autostart_enabled) {
@@ -954,7 +991,7 @@ static int if_usb_suspend(struct usb_interface *intf, pm_message_t message)
                struct cmd_ds_mesh_access mesh_access;
                memset(&mesh_access, 0, sizeof(mesh_access));
                mesh_access.data[0] = cpu_to_le32(1);
-               libertas_prepare_and_send_command(priv,
+               lbs_prepare_and_send_command(priv,
                                CMD_MESH_ACCESS,
                                CMD_ACT_MESH_SET_AUTOSTART_ENABLED,
                                CMD_OPTION_WAITFORRSP, 0, (void *)&mesh_access);
@@ -976,13 +1013,13 @@ static int if_usb_suspend(struct usb_interface *intf, pm_message_t message)
 static int if_usb_resume(struct usb_interface *intf)
 {
        struct usb_card_rec *cardp = usb_get_intfdata(intf);
-       wlan_private *priv = cardp->priv;
+       struct lbs_private *priv = cardp->priv;
 
        lbs_deb_enter(LBS_DEB_USB);
 
        cardp->rx_urb_recall = 0;
 
-       if_usb_submit_rx_urb(cardp->priv);
+       if_usb_submit_rx_urb(cardp);
 
        netif_device_attach(cardp->eth_dev);
        netif_device_attach(priv->mesh_dev);
@@ -994,7 +1031,7 @@ static int if_usb_resume(struct usb_interface *intf)
                struct cmd_ds_mesh_access mesh_access;
                memset(&mesh_access, 0, sizeof(mesh_access));
                mesh_access.data[0] = cpu_to_le32(0);
-               libertas_prepare_and_send_command(priv,
+               lbs_prepare_and_send_command(priv,
                                CMD_MESH_ACCESS,
                                CMD_ACT_MESH_SET_AUTOSTART_ENABLED,
                                CMD_OPTION_WAITFORRSP, 0, (void *)&mesh_access);
@@ -1009,46 +1046,30 @@ static int if_usb_resume(struct usb_interface *intf)
 #endif
 
 static struct usb_driver if_usb_driver = {
-       /* driver name */
-       .name = usbdriver_name,
-       /* probe function name */
+       .name = DRV_NAME,
        .probe = if_usb_probe,
-       /* disconnect function  name */
        .disconnect = if_usb_disconnect,
-       /* device signature table */
        .id_table = if_usb_table,
        .suspend = if_usb_suspend,
        .resume = if_usb_resume,
 };
 
-static int if_usb_init_module(void)
+static int __init if_usb_init_module(void)
 {
        int ret = 0;
 
        lbs_deb_enter(LBS_DEB_MAIN);
 
-       if (libertas_fw_name == NULL) {
-               libertas_fw_name = default_fw_name;
-       }
-
        ret = usb_register(&if_usb_driver);
 
        lbs_deb_leave_args(LBS_DEB_MAIN, "ret %d", ret);
        return ret;
 }
 
-static void if_usb_exit_module(void)
+static void __exit if_usb_exit_module(void)
 {
-       struct usb_card_rec *cardp, *cardp_temp;
-
        lbs_deb_enter(LBS_DEB_MAIN);
 
-       list_for_each_entry_safe(cardp, cardp_temp, &usb_devices, list) {
-               libertas_prepare_and_send_command(cardp->priv, CMD_802_11_RESET,
-                                                 CMD_ACT_HALT, 0, 0, NULL);
-       }
-
-       /* API unregisters the driver from USB subsystem */
        usb_deregister(&if_usb_driver);
 
        lbs_deb_leave(LBS_DEB_MAIN);