]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/pcmcia/ds.c
[PATCH] blk: Use blk_queue_xxx functions to set parameters
[linux-2.6-omap-h63xx.git] / drivers / pcmcia / ds.c
index 54068f451ee68eabeff15406dc70ca0a1f141d91..43da2e92d50fe67fd633021de9abef67b130bc51 100644 (file)
  * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
  *
  * (C) 1999            David A. Hinds
- * (C) 2003 - 2004     Dominik Brodowski
+ * (C) 2003 - 2005     Dominik Brodowski
  */
 
 #include <linux/config.h>
+#include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/moduleparam.h>
 #include <linux/init.h>
-#include <linux/kernel.h>
-#include <linux/major.h>
-#include <linux/string.h>
 #include <linux/errno.h>
-#include <linux/slab.h>
-#include <linux/mm.h>
-#include <linux/fcntl.h>
-#include <linux/sched.h>
-#include <linux/smp_lock.h>
-#include <linux/timer.h>
-#include <linux/ioctl.h>
-#include <linux/proc_fs.h>
-#include <linux/poll.h>
-#include <linux/pci.h>
 #include <linux/list.h>
 #include <linux/delay.h>
-#include <linux/kref.h>
 #include <linux/workqueue.h>
 #include <linux/crc32.h>
 #include <linux/firmware.h>
 
-#include <asm/atomic.h>
-
 #define IN_CARD_SERVICES
-#include <pcmcia/version.h>
 #include <pcmcia/cs_types.h>
 #include <pcmcia/cs.h>
-#include <pcmcia/bulkmem.h>
 #include <pcmcia/cistpl.h>
 #include <pcmcia/ds.h>
 #include <pcmcia/ss.h>
@@ -75,7 +57,7 @@ module_param_named(pc_debug, ds_pc_debug, int, 0644);
 
 spinlock_t pcmcia_dev_list_lock;
 
-static int unbind_request(struct pcmcia_bus_socket *s);
+static int unbind_request(struct pcmcia_socket *s);
 
 /*====================================================================*/
 
@@ -176,17 +158,15 @@ static const lookup_t service_table[] = {
 };
 
 
-static int pcmcia_report_error(client_handle_t handle, error_info_t *err)
+static int pcmcia_report_error(struct pcmcia_device *p_dev, error_info_t *err)
 {
        int i;
        char *serv;
 
-       if (CHECK_HANDLE(handle))
+       if (!p_dev)
                printk(KERN_NOTICE);
-       else {
-               struct pcmcia_device *p_dev = handle_to_pdev(handle);
+       else
                printk(KERN_NOTICE "%s: ", p_dev->dev.bus_id);
-       }
 
        for (i = 0; i < ARRAY_SIZE(service_table); i++)
                if (service_table[i].key == err->func)
@@ -211,10 +191,10 @@ static int pcmcia_report_error(client_handle_t handle, error_info_t *err)
 
 /*======================================================================*/
 
-void cs_error(client_handle_t handle, int func, int ret)
+void cs_error(struct pcmcia_device *p_dev, int func, int ret)
 {
        error_info_t err = { func, ret };
-       pcmcia_report_error(handle, &err);
+       pcmcia_report_error(p_dev, &err);
 }
 EXPORT_SYMBOL(cs_error);
 
@@ -225,6 +205,10 @@ static void pcmcia_check_driver(struct pcmcia_driver *p_drv)
        unsigned int i;
        u32 hash;
 
+       if (!p_drv->attach || !p_drv->event || !p_drv->detach)
+               printk(KERN_DEBUG "pcmcia: %s lacks a requisite callback "
+                      "function\n", p_drv->drv.name);
+
        while (did && did->match_flags) {
                for (i=0; i<4; i++) {
                        if (!did->prod_id[i])
@@ -313,24 +297,6 @@ static inline int pcmcia_load_firmware(struct pcmcia_device *dev, char * filenam
 /*======================================================================*/
 
 
-void pcmcia_release_bus_socket(struct kref *refcount)
-{
-       struct pcmcia_bus_socket *s = container_of(refcount, struct pcmcia_bus_socket, refcount);
-       pcmcia_put_socket(s->parent);
-       kfree(s);
-}
-
-void pcmcia_put_bus_socket(struct pcmcia_bus_socket *s)
-{
-       kref_put(&s->refcount, pcmcia_release_bus_socket);
-}
-
-struct pcmcia_bus_socket *pcmcia_get_bus_socket(struct pcmcia_bus_socket *s)
-{
-       kref_get(&s->refcount);
-       return (s);
-}
-
 /**
  * pcmcia_register_driver - register a PCMCIA driver with the bus core
  *
@@ -387,7 +353,7 @@ static void pcmcia_release_dev(struct device *dev)
 {
        struct pcmcia_device *p_dev = to_pcmcia_dev(dev);
        ds_dbg(1, "releasing dev %p\n", p_dev);
-       pcmcia_put_bus_socket(p_dev->socket->pcmcia);
+       pcmcia_put_socket(p_dev->socket);
        kfree(p_dev);
 }
 
@@ -412,7 +378,7 @@ static int pcmcia_device_probe(struct device * dev)
 
        if (p_drv->attach) {
                p_dev->instance = p_drv->attach();
-               if ((!p_dev->instance) || (p_dev->client.state & CLIENT_UNBOUND)) {
+               if ((!p_dev->instance) || (p_dev->state & CLIENT_UNBOUND)) {
                        printk(KERN_NOTICE "ds: unable to create instance "
                               "of '%s'!\n", p_drv->drv.name);
                        ret = -EINVAL;
@@ -522,12 +488,12 @@ static int pcmcia_device_query(struct pcmcia_device *p_dev)
  */
 static DECLARE_MUTEX(device_add_lock);
 
-struct pcmcia_device * pcmcia_device_add(struct pcmcia_bus_socket *s, unsigned int function)
+struct pcmcia_device * pcmcia_device_add(struct pcmcia_socket *s, unsigned int function)
 {
        struct pcmcia_device *p_dev;
        unsigned long flags;
 
-       s = pcmcia_get_bus_socket(s);
+       s = pcmcia_get_socket(s);
        if (!s)
                return NULL;
 
@@ -542,20 +508,17 @@ struct pcmcia_device * pcmcia_device_add(struct pcmcia_bus_socket *s, unsigned i
                goto err_put;
        memset(p_dev, 0, sizeof(struct pcmcia_device));
 
-       p_dev->socket = s->parent;
+       p_dev->socket = s;
        p_dev->device_no = (s->device_count++);
        p_dev->func   = function;
 
        p_dev->dev.bus = &pcmcia_bus_type;
-       p_dev->dev.parent = s->parent->dev.dev;
+       p_dev->dev.parent = s->dev.dev;
        p_dev->dev.release = pcmcia_release_dev;
        sprintf (p_dev->dev.bus_id, "%d.%d", p_dev->socket->sock, p_dev->device_no);
 
        /* compat */
-       p_dev->client.client_magic = CLIENT_MAGIC;
-       p_dev->client.Socket = s->parent;
-       p_dev->client.Function = function;
-       p_dev->client.state = CLIENT_UNBOUND;
+       p_dev->state = CLIENT_UNBOUND;
 
        /* Add to the list in pcmcia_bus_socket */
        spin_lock_irqsave(&pcmcia_dev_list_lock, flags);
@@ -581,7 +544,7 @@ struct pcmcia_device * pcmcia_device_add(struct pcmcia_bus_socket *s, unsigned i
        s->device_count--;
  err_put:
        up(&device_add_lock);
-       pcmcia_put_bus_socket(s);
+       pcmcia_put_socket(s);
 
        return NULL;
 }
@@ -609,10 +572,8 @@ static int pcmcia_card_add(struct pcmcia_socket *s)
        else
                no_funcs = 1;
 
-       /* this doesn't handle multifunction devices on one pcmcia function
-        * yet. */
        for (i=0; i < no_funcs; i++)
-               pcmcia_device_add(s->pcmcia, i);
+               pcmcia_device_add(s, i);
 
        return (ret);
 }
@@ -620,16 +581,16 @@ static int pcmcia_card_add(struct pcmcia_socket *s)
 
 static void pcmcia_delayed_add_pseudo_device(void *data)
 {
-       struct pcmcia_bus_socket *s = data;
+       struct pcmcia_socket *s = data;
        pcmcia_device_add(s, 0);
-       s->device_add_pending = 0;
+       s->pcmcia_state.device_add_pending = 0;
 }
 
-static inline void pcmcia_add_pseudo_device(struct pcmcia_bus_socket *s)
+static inline void pcmcia_add_pseudo_device(struct pcmcia_socket *s)
 {
-       if (!s->device_add_pending) {
+       if (!s->pcmcia_state.device_add_pending) {
+               s->pcmcia_state.device_add_pending = 1;
                schedule_work(&s->device_add);
-               s->device_add_pending = 1;
        }
        return;
 }
@@ -650,7 +611,7 @@ static void pcmcia_bus_rescan(struct pcmcia_socket *skt)
 
        /* must be called with skt_sem held */
        spin_lock_irqsave(&pcmcia_dev_list_lock, flags);
-       if (list_empty(&skt->pcmcia->devices_list))
+       if (list_empty(&skt->devices_list))
                no_devices=1;
        spin_unlock_irqrestore(&pcmcia_dev_list_lock, flags);
 
@@ -727,7 +688,7 @@ static inline int pcmcia_devmatch(struct pcmcia_device *dev,
                 * pseudo devices, and if not, add the second one.
                 */
                if (dev->device_no == 0)
-                       pcmcia_add_pseudo_device(dev->socket->pcmcia);
+                       pcmcia_add_pseudo_device(dev->socket);
 
                if (dev->device_no != did->device_no)
                        return 0;
@@ -883,9 +844,29 @@ pcmcia_device_stringattr(prod_id2, prod_id[1]);
 pcmcia_device_stringattr(prod_id3, prod_id[2]);
 pcmcia_device_stringattr(prod_id4, prod_id[3]);
 
+static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+       struct pcmcia_device *p_dev = to_pcmcia_dev(dev);
+       int i;
+       u32 hash[4] = { 0, 0, 0, 0};
 
-static ssize_t pcmcia_store_allow_func_id_match (struct device * dev, struct device_attribute *attr,
-                                                const char * buf, size_t count)
+       /* calculate hashes */
+       for (i=0; i<4; i++) {
+               if (!p_dev->prod_id[i])
+                       continue;
+               hash[i] = crc32(0,p_dev->prod_id[i],strlen(p_dev->prod_id[i]));
+       }
+       return sprintf(buf, "pcmcia:m%04Xc%04Xf%02Xfn%02Xpfn%02X"
+                               "pa%08Xpb%08Xpc%08Xpd%08X\n",
+                               p_dev->has_manf_id ? p_dev->manf_id : 0,
+                               p_dev->has_card_id ? p_dev->card_id : 0,
+                               p_dev->has_func_id ? p_dev->func_id : 0,
+                               p_dev->func, p_dev->device_no,
+                               hash[0], hash[1], hash[2], hash[3]);
+}
+
+static ssize_t pcmcia_store_allow_func_id_match(struct device *dev,
+               struct device_attribute *attr, const char *buf, size_t count)
 {
        struct pcmcia_device *p_dev = to_pcmcia_dev(dev);
         if (!count)
@@ -909,6 +890,7 @@ static struct device_attribute pcmcia_dev_attrs[] = {
        __ATTR_RO(prod_id2),
        __ATTR_RO(prod_id3),
        __ATTR_RO(prod_id4),
+       __ATTR_RO(modalias),
        __ATTR(allow_func_id_match, 0200, NULL, pcmcia_store_allow_func_id_match),
        __ATTR_NULL,
 };
@@ -929,6 +911,7 @@ struct send_event_data {
 static int send_event_callback(struct device *dev, void * _data)
 {
        struct pcmcia_device *p_dev = to_pcmcia_dev(dev);
+       struct pcmcia_driver *p_drv;
        struct send_event_data *data = _data;
 
        /* we get called for all sockets, but may only pass the event
@@ -936,32 +919,29 @@ static int send_event_callback(struct device *dev, void * _data)
        if (p_dev->socket != data->skt)
                return 0;
 
-       if (p_dev->client.state & (CLIENT_UNBOUND|CLIENT_STALE))
+       p_drv = to_pcmcia_drv(p_dev->dev.driver);
+       if (!p_drv)
+               return 0;
+
+       if (p_dev->state & (CLIENT_UNBOUND|CLIENT_STALE))
                return 0;
 
-       if (p_dev->client.EventMask & data->event)
-               return EVENT(&p_dev->client, data->event, data->priority);
+       if (p_drv->event)
+               return p_drv->event(data->event, data->priority,
+                                   &p_dev->event_callback_args);
 
        return 0;
 }
 
 static int send_event(struct pcmcia_socket *s, event_t event, int priority)
 {
-       int ret = 0;
        struct send_event_data private;
-       struct pcmcia_bus_socket *skt = pcmcia_get_bus_socket(s->pcmcia);
-
-       if (!skt)
-               return 0;
 
        private.skt = s;
        private.event = event;
        private.priority = priority;
 
-       ret = bus_for_each_dev(&pcmcia_bus_type, NULL, &private, send_event_callback);
-
-       pcmcia_put_bus_socket(skt);
-       return ret;
+       return bus_for_each_dev(&pcmcia_bus_type, NULL, &private, send_event_callback);
 } /* send_event */
 
 
@@ -972,25 +952,25 @@ static int send_event(struct pcmcia_socket *s, event_t event, int priority)
 
 static int ds_event(struct pcmcia_socket *skt, event_t event, int priority)
 {
-       struct pcmcia_bus_socket *s = skt->pcmcia;
+       struct pcmcia_socket *s = pcmcia_get_socket(skt);
        int ret = 0;
 
        ds_dbg(1, "ds_event(0x%06x, %d, 0x%p)\n",
-              event, priority, s);
+              event, priority, skt);
     
        switch (event) {
 
        case CS_EVENT_CARD_REMOVAL:
-               s->state &= ~DS_SOCKET_PRESENT;
+               s->pcmcia_state.present = 0;
                send_event(skt, event, priority);
-               unbind_request(s);
-               handle_event(s, event);
+               unbind_request(skt);
+               handle_event(skt, event);
                break;
        
        case CS_EVENT_CARD_INSERTION:
-               s->state |= DS_SOCKET_PRESENT;
+               s->pcmcia_state.present = 1;
                pcmcia_card_add(skt);
-               handle_event(s, event);
+               handle_event(skt, event);
                break;
 
        case CS_EVENT_EJECTION_REQUEST:
@@ -998,22 +978,23 @@ static int ds_event(struct pcmcia_socket *skt, event_t event, int priority)
                break;
 
        default:
-               handle_event(s, event);
+               handle_event(skt, event);
                send_event(skt, event, priority);
                break;
     }
 
+    pcmcia_put_socket(s);
+
     return 0;
 } /* ds_event */
 
 
 
-int pcmcia_register_client(client_handle_t *handle, client_reg_t *req)
+int pcmcia_register_client(struct pcmcia_device **handle, client_reg_t *req)
 {
-       client_t *client = NULL;
-       struct pcmcia_socket *s;
-       struct pcmcia_bus_socket *skt = NULL;
+       struct pcmcia_socket *s = NULL;
        struct pcmcia_device *p_dev = NULL;
+       struct pcmcia_driver *p_drv = NULL;
 
        /* Look for unbound client with matching dev_info */
        down_read(&pcmcia_socket_list_rwsem);
@@ -1023,56 +1004,45 @@ int pcmcia_register_client(client_handle_t *handle, client_reg_t *req)
                if (s->state & SOCKET_CARDBUS)
                        continue;
 
-               skt = s->pcmcia;
-               if (!skt)
-                       continue;
-               skt = pcmcia_get_bus_socket(skt);
-               if (!skt)
+               s = pcmcia_get_socket(s);
+               if (!s)
                        continue;
                spin_lock_irqsave(&pcmcia_dev_list_lock, flags);
-               list_for_each_entry(p_dev, &skt->devices_list, socket_device_list) {
-                       struct pcmcia_driver *p_drv;
+               list_for_each_entry(p_dev, &s->devices_list, socket_device_list) {
                        p_dev = pcmcia_get_dev(p_dev);
                        if (!p_dev)
                                continue;
-                       if (!(p_dev->client.state & CLIENT_UNBOUND) ||
+                       if (!(p_dev->state & CLIENT_UNBOUND) ||
                            (!p_dev->dev.driver)) {
                                pcmcia_put_dev(p_dev);
                                continue;
                        }
                        p_drv = to_pcmcia_drv(p_dev->dev.driver);
                        if (!strncmp(p_drv->drv.name, (char *)req->dev_info, DEV_NAME_LEN)) {
-                               client = &p_dev->client;
                                spin_unlock_irqrestore(&pcmcia_dev_list_lock, flags);
                                goto found;
                        }
                        pcmcia_put_dev(p_dev);
                }
                spin_unlock_irqrestore(&pcmcia_dev_list_lock, flags);
-               pcmcia_put_bus_socket(skt);
+               pcmcia_put_socket(s);
        }
  found:
        up_read(&pcmcia_socket_list_rwsem);
-       if (!p_dev || !client)
+       if (!p_dev)
                return -ENODEV;
 
-       pcmcia_put_bus_socket(skt); /* safe, as we already hold a reference from bind_device */
+       pcmcia_put_socket(s); /* safe, as we already hold a reference from bind_device */
 
-       *handle = client;
-       client->state &= ~CLIENT_UNBOUND;
-       client->Socket = s;
-       client->EventMask = req->EventMask;
-       client->event_handler = req->event_handler;
-       client->event_callback_args = req->event_callback_args;
-       client->event_callback_args.client_handle = client;
+       *handle = p_dev;
+       p_dev->state &= ~CLIENT_UNBOUND;
+       p_dev->event_callback_args = req->event_callback_args;
+       p_dev->event_callback_args.client_handle = p_dev;
 
-       if (s->state & SOCKET_CARDBUS)
-               client->state |= CLIENT_CARDBUS;
 
-       if ((!(s->state & SOCKET_CARDBUS)) && (s->functions == 0) &&
-           (client->Function != BIND_FN_ALL)) {
+       if (!s->functions) {
                cistpl_longlink_mfc_t mfc;
-               if (pccard_read_tuple(s, client->Function, CISTPL_LONGLINK_MFC, &mfc)
+               if (pccard_read_tuple(s, p_dev->func, CISTPL_LONGLINK_MFC, &mfc)
                    == CS_SUCCESS)
                        s->functions = mfc.nfn;
                else
@@ -1085,13 +1055,13 @@ int pcmcia_register_client(client_handle_t *handle, client_reg_t *req)
        }
 
        ds_dbg(1, "register_client(): client 0x%p, dev %s\n",
-              client, p_dev->dev.bus_id);
-       if (client->EventMask & CS_EVENT_REGISTRATION_COMPLETE)
-               EVENT(client, CS_EVENT_REGISTRATION_COMPLETE, CS_EVENT_PRI_LOW);
+              p_dev, p_dev->dev.bus_id);
 
        if ((s->state & (SOCKET_PRESENT|SOCKET_CARDBUS)) == SOCKET_PRESENT) {
-               if (client->EventMask & CS_EVENT_CARD_INSERTION)
-                       EVENT(client, CS_EVENT_CARD_INSERTION, CS_EVENT_PRI_LOW);
+               if (p_drv->event)
+                       p_drv->event(CS_EVENT_CARD_INSERTION, CS_EVENT_PRI_LOW,
+                                    &p_dev->event_callback_args);
+
        }
 
        return CS_SUCCESS;
@@ -1106,12 +1076,12 @@ EXPORT_SYMBOL(pcmcia_register_client);
 /* unbind _all_ devices attached to a given pcmcia_bus_socket. The
  * drivers have been called with EVENT_CARD_REMOVAL before.
  */
-static int unbind_request(struct pcmcia_bus_socket *s)
+static int unbind_request(struct pcmcia_socket *s)
 {
        struct pcmcia_device    *p_dev;
        unsigned long           flags;
 
-       ds_dbg(2, "unbind_request(%d)\n", s->parent->sock);
+       ds_dbg(2, "unbind_request(%d)\n", s->sock);
 
        s->device_count = 0;
 
@@ -1124,7 +1094,7 @@ static int unbind_request(struct pcmcia_bus_socket *s)
                }
                p_dev = list_entry((&s->devices_list)->next, struct pcmcia_device, socket_device_list);
                list_del(&p_dev->socket_device_list);
-               p_dev->client.state |= CLIENT_STALE;
+               p_dev->state |= CLIENT_STALE;
                spin_unlock_irqrestore(&pcmcia_dev_list_lock, flags);
 
                device_unregister(&p_dev->dev);
@@ -1133,31 +1103,25 @@ static int unbind_request(struct pcmcia_bus_socket *s)
        return 0;
 } /* unbind_request */
 
-int pcmcia_deregister_client(client_handle_t handle)
+int pcmcia_deregister_client(struct pcmcia_device *p_dev)
 {
        struct pcmcia_socket *s;
        int i;
-       struct pcmcia_device *p_dev = handle_to_pdev(handle);
 
-       if (CHECK_HANDLE(handle))
-               return CS_BAD_HANDLE;
+       s = p_dev->socket;
+       ds_dbg(1, "deregister_client(%p)\n", p_dev);
 
-       s = SOCKET(handle);
-       ds_dbg(1, "deregister_client(%p)\n", handle);
-
-       if (handle->state & (CLIENT_IRQ_REQ|CLIENT_IO_REQ|CLIENT_CONFIG_LOCKED))
+       if (p_dev->state & (CLIENT_IRQ_REQ|CLIENT_IO_REQ|CLIENT_CONFIG_LOCKED))
                goto warn_out;
        for (i = 0; i < MAX_WIN; i++)
-               if (handle->state & CLIENT_WIN_REQ(i))
+               if (p_dev->state & CLIENT_WIN_REQ(i))
                        goto warn_out;
 
-       if (handle->state & CLIENT_STALE) {
-               handle->client_magic = 0;
-               handle->state &= ~CLIENT_STALE;
+       if (p_dev->state & CLIENT_STALE) {
+               p_dev->state &= ~CLIENT_STALE;
                pcmcia_put_dev(p_dev);
        } else {
-               handle->state = CLIENT_UNBOUND;
-               handle->event_handler = NULL;
+               p_dev->state = CLIENT_UNBOUND;
        }
 
        return CS_SUCCESS;
@@ -1176,24 +1140,14 @@ static struct pcmcia_callback pcmcia_bus_callback = {
 static int __devinit pcmcia_bus_add_socket(struct class_device *class_dev)
 {
        struct pcmcia_socket *socket = class_get_devdata(class_dev);
-       struct pcmcia_bus_socket *s;
        int ret;
 
-       s = kmalloc(sizeof(struct pcmcia_bus_socket), GFP_KERNEL);
-       if(!s)
-               return -ENOMEM;
-       memset(s, 0, sizeof(struct pcmcia_bus_socket));
-
-       /* get reference to parent socket */
-       s->parent = pcmcia_get_socket(socket);
-       if (!s->parent) {
+       socket = pcmcia_get_socket(socket);
+       if (!socket) {
                printk(KERN_ERR "PCMCIA obtaining reference to socket %p failed\n", socket);
-               kfree (s);
                return -ENODEV;
        }
 
-       kref_init(&s->refcount);
-    
        /*
         * Ugly. But we want to wait for the socket threads to have started up.
         * We really should let the drivers themselves drive some of this..
@@ -1201,19 +1155,17 @@ static int __devinit pcmcia_bus_add_socket(struct class_device *class_dev)
        msleep(250);
 
 #ifdef CONFIG_PCMCIA_IOCTL
-       init_waitqueue_head(&s->queue);
+       init_waitqueue_head(&socket->queue);
 #endif
-       INIT_LIST_HEAD(&s->devices_list);
-       INIT_WORK(&s->device_add, pcmcia_delayed_add_pseudo_device, s);
-
-       /* Set up hotline to Card Services */
-       socket->pcmcia = s;
+       INIT_LIST_HEAD(&socket->devices_list);
+       INIT_WORK(&socket->device_add, pcmcia_delayed_add_pseudo_device, socket);
+       memset(&socket->pcmcia_state, 0, sizeof(u8));
+       socket->device_count = 0;
 
        ret = pccard_register_pcmcia(socket, &pcmcia_bus_callback);
        if (ret) {
                printk(KERN_ERR "PCMCIA registration PCCard core failed for socket %p\n", socket);
-               pcmcia_put_bus_socket(s);
-               socket->pcmcia = NULL;
+               pcmcia_put_socket(socket);
                return (ret);
        }
 
@@ -1224,14 +1176,13 @@ static void pcmcia_bus_remove_socket(struct class_device *class_dev)
 {
        struct pcmcia_socket *socket = class_get_devdata(class_dev);
 
-       if (!socket || !socket->pcmcia)
+       if (!socket)
                return;
 
+       socket->pcmcia_state.dead = 1;
        pccard_register_pcmcia(socket, NULL);
 
-       socket->pcmcia->state |= DS_SOCKET_DEAD;
-       pcmcia_put_bus_socket(socket->pcmcia);
-       socket->pcmcia = NULL;
+       pcmcia_put_socket(socket);
 
        return;
 }