]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - fs/gfs2/log.c
[GFS2] Tidy up log.c
[linux-2.6-omap-h63xx.git] / fs / gfs2 / log.c
index 9e32e0faaf20ae3b1618a411fe72cf3a3a9641e1..50f88059c3d5aac2a93c8fb46b2437588a167cf3 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Copyright (C) Sistina Software, Inc.  1997-2003 All rights reserved.
- * Copyright (C) 2004-2005 Red Hat, Inc.  All rights reserved.
+ * Copyright (C) 2004-2006 Red Hat, Inc.  All rights reserved.
  *
  * This copyrighted material is made available to anyone wishing to use,
  * modify, copy, or redistribute it subject to the terms and conditions
- * of the GNU General Public License v.2.
+ * of the GNU General Public License version 2.
  */
 
 #include <linux/sched.h>
@@ -14,7 +14,6 @@
 #include <linux/buffer_head.h>
 #include <linux/gfs2_ondisk.h>
 #include <linux/crc32.h>
-#include <asm/semaphore.h>
 
 #include "gfs2.h"
 #include "lm_interface.h"
@@ -48,8 +47,7 @@ unsigned int gfs2_struct2blk(struct gfs2_sbd *sdp, unsigned int nstruct,
        unsigned int first, second;
 
        blks = 1;
-       first = (sdp->sd_sb.sb_bsize - sizeof(struct gfs2_log_descriptor)) /
-               ssize;
+       first = (sdp->sd_sb.sb_bsize - sizeof(struct gfs2_log_descriptor)) / ssize;
 
        if (nstruct > first) {
                second = (sdp->sd_sb.sb_bsize -
@@ -63,7 +61,7 @@ unsigned int gfs2_struct2blk(struct gfs2_sbd *sdp, unsigned int nstruct,
 void gfs2_ail1_start(struct gfs2_sbd *sdp, int flags)
 {
        struct list_head *head = &sdp->sd_ail1_list;
-       uint64_t sync_gen;
+       u64 sync_gen;
        struct list_head *first, *tmp;
        struct gfs2_ail *first_ai, *ai;
 
@@ -178,7 +176,6 @@ int gfs2_log_reserve(struct gfs2_sbd *sdp, unsigned int blks)
                gfs2_log_lock(sdp);
        }
        sdp->sd_log_blks_free -= blks;
-       /* printk(KERN_INFO "reserved %u blocks (%u left)\n", blks, sdp->sd_log_blks_free); */
        gfs2_log_unlock(sdp);
        mutex_unlock(&sdp->sd_log_reserve_mutex);
 
@@ -199,21 +196,22 @@ void gfs2_log_release(struct gfs2_sbd *sdp, unsigned int blks)
 
        gfs2_log_lock(sdp);
        sdp->sd_log_blks_free += blks;
-       /* printk(KERN_INFO "released %u blocks (%u left)\n", blks, sdp->sd_log_blks_free); */
        gfs2_assert_withdraw(sdp,
                             sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
        gfs2_log_unlock(sdp);
        up_read(&sdp->sd_log_flush_lock);
 }
 
-static uint64_t log_bmap(struct gfs2_sbd *sdp, unsigned int lbn)
+static u64 log_bmap(struct gfs2_sbd *sdp, unsigned int lbn)
 {
        int new = 0;
-       uint64_t dbn;
+       u64 dbn;
        int error;
+       int bdy;
 
-       error = gfs2_block_map(sdp->sd_jdesc->jd_inode->u.generic_ip,
-                              lbn, &new, &dbn, NULL);
+       error = gfs2_block_map(sdp->sd_jdesc->jd_inode, lbn, &new, &dbn, &bdy);
+       if (error || !dbn)
+               printk(KERN_INFO "error=%d, dbn=%llu lbn=%u", error, (unsigned long long)dbn, lbn);
        gfs2_assert_withdraw(sdp, !error && dbn);
 
        return dbn;
@@ -231,8 +229,7 @@ static uint64_t log_bmap(struct gfs2_sbd *sdp, unsigned int lbn)
  * Returns: the distance in blocks
  */
 
-static inline unsigned int log_distance(struct gfs2_sbd *sdp,
-                                       unsigned int newer,
+static inline unsigned int log_distance(struct gfs2_sbd *sdp, unsigned int newer,
                                        unsigned int older)
 {
        int dist;
@@ -251,11 +248,10 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
 
        gfs2_log_lock(sdp);
 
-       if (list_empty(&sdp->sd_ail1_list))
+       if (list_empty(&sdp->sd_ail1_list)) {
                tail = sdp->sd_log_head;
-       else {
-               ai = list_entry(sdp->sd_ail1_list.prev,
-                               struct gfs2_ail, ai_list);
+       } else {
+               ai = list_entry(sdp->sd_ail1_list.prev, struct gfs2_ail, ai_list);
                tail = ai->ai_first;
        }
 
@@ -267,8 +263,7 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
 static inline void log_incr_head(struct gfs2_sbd *sdp)
 {
        if (sdp->sd_log_flush_head == sdp->sd_log_tail)
-               gfs2_assert_withdraw(sdp,
-                               sdp->sd_log_flush_head == sdp->sd_log_head);
+               gfs2_assert_withdraw(sdp, sdp->sd_log_flush_head == sdp->sd_log_head);
 
        if (++sdp->sd_log_flush_head == sdp->sd_jdesc->jd_blocks) {
                sdp->sd_log_flush_head = 0;
@@ -285,7 +280,7 @@ static inline void log_incr_head(struct gfs2_sbd *sdp)
 
 struct buffer_head *gfs2_log_get_buf(struct gfs2_sbd *sdp)
 {
-       uint64_t blkno = log_bmap(sdp, sdp->sd_log_flush_head);
+       u64 blkno = log_bmap(sdp, sdp->sd_log_flush_head);
        struct gfs2_log_buf *lb;
        struct buffer_head *bh;
 
@@ -315,7 +310,7 @@ struct buffer_head *gfs2_log_get_buf(struct gfs2_sbd *sdp)
 struct buffer_head *gfs2_log_fake_buf(struct gfs2_sbd *sdp,
                                      struct buffer_head *real)
 {
-       uint64_t blkno = log_bmap(sdp, sdp->sd_log_flush_head);
+       u64 blkno = log_bmap(sdp, sdp->sd_log_flush_head);
        struct gfs2_log_buf *lb;
        struct buffer_head *bh;
 
@@ -343,10 +338,8 @@ static void log_pull_tail(struct gfs2_sbd *sdp, unsigned int new_tail, int pull)
        ail2_empty(sdp, new_tail);
 
        gfs2_log_lock(sdp);
-       sdp->sd_log_blks_free += dist - ((pull) ? 1 : 0);
-       /* printk(KERN_INFO "pull tail refunding %u blocks (%u left) pull=%d\n", dist - ((pull) ? 1 : 0), sdp->sd_log_blks_free, pull); */
-       gfs2_assert_withdraw(sdp,
-                            sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
+       sdp->sd_log_blks_free += dist - (pull ? 1 : 0);
+       gfs2_assert_withdraw(sdp, sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
        gfs2_log_unlock(sdp);
 
        sdp->sd_log_tail = new_tail;
@@ -359,15 +352,13 @@ static void log_pull_tail(struct gfs2_sbd *sdp, unsigned int new_tail, int pull)
  * Returns: the initialized log buffer descriptor
  */
 
-static void log_write_header(struct gfs2_sbd *sdp, uint32_t flags, int pull)
+static void log_write_header(struct gfs2_sbd *sdp, u32 flags, int pull)
 {
-       uint64_t blkno = log_bmap(sdp, sdp->sd_log_flush_head);
+       u64 blkno = log_bmap(sdp, sdp->sd_log_flush_head);
        struct buffer_head *bh;
        struct gfs2_log_header *lh;
        unsigned int tail;
-       uint32_t hash;
-
-       /* printk(KERN_INFO "log write header start (flags=%08x, pull=%d)\n", flags, pull); */
+       u32 hash;
 
        bh = sb_getblk(sdp->sd_vfs, blkno);
        lock_buffer(bh);
@@ -384,10 +375,10 @@ static void log_write_header(struct gfs2_sbd *sdp, uint32_t flags, int pull)
        lh->lh_header.mh_magic = cpu_to_be32(GFS2_MAGIC);
        lh->lh_header.mh_type = cpu_to_be32(GFS2_METATYPE_LH);
        lh->lh_header.mh_format = cpu_to_be32(GFS2_FORMAT_LH);
-       lh->lh_sequence = be64_to_cpu(sdp->sd_log_sequence++);
-       lh->lh_flags = be32_to_cpu(flags);
-       lh->lh_tail = be32_to_cpu(tail);
-       lh->lh_blkno = be32_to_cpu(sdp->sd_log_flush_head);
+       lh->lh_sequence = cpu_to_be64(sdp->sd_log_sequence++);
+       lh->lh_flags = cpu_to_be32(flags);
+       lh->lh_tail = cpu_to_be32(tail);
+       lh->lh_blkno = cpu_to_be32(sdp->sd_log_flush_head);
        hash = gfs2_disk_hash(bh->b_data, sizeof(struct gfs2_log_header));
        lh->lh_hash = cpu_to_be32(hash);
 
@@ -403,8 +394,6 @@ static void log_write_header(struct gfs2_sbd *sdp, uint32_t flags, int pull)
 
        sdp->sd_log_idle = (tail == sdp->sd_log_flush_head);
        log_incr_head(sdp);
-
-       /* printk(KERN_INFO "log write header out\n"); */
 }
 
 static void log_flush_commit(struct gfs2_sbd *sdp)
@@ -412,13 +401,6 @@ static void log_flush_commit(struct gfs2_sbd *sdp)
        struct list_head *head = &sdp->sd_log_flush_list;
        struct gfs2_log_buf *lb;
        struct buffer_head *bh;
-#if 0
-       unsigned int d;
-
-       d = log_distance(sdp, sdp->sd_log_flush_head, sdp->sd_log_head);
-
-       gfs2_assert_withdraw(sdp, d + 1 == sdp->sd_log_blks_reserved);
-#endif
 
        while (!list_empty(head)) {
                lb = list_entry(head->next, struct gfs2_log_buf, lb_list);
@@ -467,8 +449,7 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
        INIT_LIST_HEAD(&ai->ai_ail1_list);
        INIT_LIST_HEAD(&ai->ai_ail2_list);
 
-       gfs2_assert_withdraw(sdp,
-                       sdp->sd_log_num_buf == sdp->sd_log_commited_buf);
+       gfs2_assert_withdraw(sdp, sdp->sd_log_num_buf == sdp->sd_log_commited_buf);
        gfs2_assert_withdraw(sdp,
                        sdp->sd_log_num_revoke == sdp->sd_log_commited_revoke);
 
@@ -484,13 +465,12 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
        lops_after_commit(sdp, ai);
        sdp->sd_log_head = sdp->sd_log_flush_head;
 
-       /* printk(KERN_INFO "sd_log_num_hdrs %u\n", sdp->sd_log_num_hdrs); */
        sdp->sd_log_blks_free -= sdp->sd_log_num_hdrs;
 
-       sdp->sd_log_blks_reserved =
-               sdp->sd_log_commited_buf =
-               sdp->sd_log_num_hdrs = 
-               sdp->sd_log_commited_revoke = 0;
+       sdp->sd_log_blks_reserved = 0;
+       sdp->sd_log_commited_buf = 0;
+       sdp->sd_log_num_hdrs = 0;
+       sdp->sd_log_commited_revoke = 0;
 
        gfs2_log_lock(sdp);
        if (!list_empty(&ai->ai_ail1_list)) {
@@ -507,7 +487,7 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
 
 static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
 {
-       unsigned int reserved = 1;
+       unsigned int reserved = 0;
        unsigned int old;
 
        gfs2_log_lock(sdp);
@@ -521,7 +501,9 @@ static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
                reserved += sdp->sd_log_commited_buf;
        if (sdp->sd_log_commited_revoke)
                reserved += gfs2_struct2blk(sdp, sdp->sd_log_commited_revoke,
-                                           sizeof(uint64_t));
+                                           sizeof(u64));
+       if (reserved)
+               reserved++;
 
        old = sdp->sd_log_blks_free;
        sdp->sd_log_blks_free += tr->tr_reserved -
@@ -557,8 +539,9 @@ void gfs2_log_commit(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
        if (sdp->sd_log_num_buf > gfs2_tune_get(sdp, gt_incore_log_blocks)) {
                gfs2_log_unlock(sdp);
                gfs2_log_flush(sdp, NULL);
-       } else
+       } else {
                gfs2_log_unlock(sdp);
+       }
 }
 
 /**
@@ -586,11 +569,9 @@ void gfs2_log_shutdown(struct gfs2_sbd *sdp)
 
        log_write_header(sdp, GFS2_LOG_HEAD_UNMOUNT, 0);
 
-       /* printk(KERN_INFO "sd_log_blks_free %u, sd_jdesc->jd_blocks %u\n", sdp->sd_log_blks_free, sdp->sd_jdesc->jd_blocks); */
-       gfs2_assert_withdraw(sdp, sdp->sd_log_blks_free ==
-                            sdp->sd_jdesc->jd_blocks);
-       gfs2_assert_withdraw(sdp, sdp->sd_log_head == sdp->sd_log_tail);
-       gfs2_assert_withdraw(sdp, list_empty(&sdp->sd_ail2_list));
+       gfs2_assert_warn(sdp, sdp->sd_log_blks_free == sdp->sd_jdesc->jd_blocks);
+       gfs2_assert_warn(sdp, sdp->sd_log_head == sdp->sd_log_tail);
+       gfs2_assert_warn(sdp, list_empty(&sdp->sd_ail2_list));
 
        sdp->sd_log_head = sdp->sd_log_flush_head;
        sdp->sd_log_tail = sdp->sd_log_head;