]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - fs/ocfs2/dlmglue.c
[patch 2/3] OCFS2 Configurable timeouts
[linux-2.6-omap-h63xx.git] / fs / ocfs2 / dlmglue.c
index c8177d025d25dd594c6f749d56efd406a9423751..e6220137bf691600be76ac97d86868347269d4d1 100644 (file)
@@ -49,6 +49,7 @@
 #include "dcache.h"
 #include "dlmglue.h"
 #include "extent_map.h"
+#include "file.h"
 #include "heartbeat.h"
 #include "inode.h"
 #include "journal.h"
@@ -71,9 +72,9 @@ static struct ocfs2_super *ocfs2_get_dentry_osb(struct ocfs2_lock_res *lockres);
 static struct ocfs2_super *ocfs2_get_inode_osb(struct ocfs2_lock_res *lockres);
 
 /*
- * Return value from ocfs2_convert_worker_t functions.
+ * Return value from ->downconvert_worker functions.
  *
- * These control the precise actions of ocfs2_generic_unblock_lock()
+ * These control the precise actions of ocfs2_unblock_lock()
  * and ocfs2_process_blocked_lock()
  *
  */
@@ -90,20 +91,15 @@ struct ocfs2_unblock_ctl {
        enum ocfs2_unblock_action unblock_action;
 };
 
-static int ocfs2_unblock_meta(struct ocfs2_lock_res *lockres,
-                             struct ocfs2_unblock_ctl *ctl);
 static int ocfs2_check_meta_downconvert(struct ocfs2_lock_res *lockres,
                                        int new_level);
 static void ocfs2_set_meta_lvb(struct ocfs2_lock_res *lockres);
 
-static int ocfs2_unblock_data(struct ocfs2_lock_res *lockres,
-                             struct ocfs2_unblock_ctl *ctl);
-static int ocfs2_unblock_inode_lock(struct ocfs2_lock_res *lockres,
-                                   struct ocfs2_unblock_ctl *ctl);
-static int ocfs2_unblock_dentry_lock(struct ocfs2_lock_res *lockres,
-                                    struct ocfs2_unblock_ctl *ctl);
-static int ocfs2_unblock_osb_lock(struct ocfs2_lock_res *lockres,
-                                 struct ocfs2_unblock_ctl *ctl);
+static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
+                                    int blocking);
+
+static int ocfs2_dentry_convert_worker(struct ocfs2_lock_res *lockres,
+                                      int blocking);
 
 static void ocfs2_dentry_post_unlock(struct ocfs2_super *osb,
                                     struct ocfs2_lock_res *lockres);
@@ -112,6 +108,14 @@ static void ocfs2_dentry_post_unlock(struct ocfs2_super *osb,
  * OCFS2 Lock Resource Operations
  *
  * These fine tune the behavior of the generic dlmglue locking infrastructure.
+ *
+ * The most basic of lock types can point ->l_priv to their respective
+ * struct ocfs2_super and allow the default actions to manage things.
+ *
+ * Right now, each lock type also needs to implement an init function,
+ * and trivial lock/unlock wrappers. ocfs2_simple_drop_lockres()
+ * should be called when the lock is no longer needed (i.e., object
+ * destruction time).
  */
 struct ocfs2_lock_res_ops {
        /*
@@ -119,7 +123,16 @@ struct ocfs2_lock_res_ops {
         * this callback if ->l_priv is not an ocfs2_super pointer
         */
        struct ocfs2_super * (*get_osb)(struct ocfs2_lock_res *);
-       int  (*unblock)(struct ocfs2_lock_res *, struct ocfs2_unblock_ctl *);
+
+       /*
+        * Optionally called in the downconvert (or "vote") thread
+        * after a successful downconvert. The lockres will not be
+        * referenced after this callback is called, so it is safe to
+        * free memory, etc.
+        *
+        * The exact semantics of when this is called are controlled
+        * by ->downconvert_worker()
+        */
        void (*post_unlock)(struct ocfs2_super *, struct ocfs2_lock_res *);
 
        /*
@@ -145,6 +158,17 @@ struct ocfs2_lock_res_ops {
         */
        void (*set_lvb)(struct ocfs2_lock_res *);
 
+       /*
+        * Called from the downconvert thread when it is determined
+        * that a lock will be downconverted. This is called without
+        * any locks held so the function can do work that might
+        * schedule (syncing out data, etc).
+        *
+        * This should return any one of the ocfs2_unblock_action
+        * values, depending on what it wants the thread to do.
+        */
+       int (*downconvert_worker)(struct ocfs2_lock_res *, int);
+
        /*
         * LOCK_TYPE_* flags which describe the specific requirements
         * of a lock type. Descriptions of each individual flag follow.
@@ -168,21 +192,13 @@ struct ocfs2_lock_res_ops {
  */
 #define LOCK_TYPE_USES_LVB             0x2
 
-typedef int (ocfs2_convert_worker_t)(struct ocfs2_lock_res *, int);
-static int ocfs2_generic_unblock_lock(struct ocfs2_super *osb,
-                                     struct ocfs2_lock_res *lockres,
-                                     struct ocfs2_unblock_ctl *ctl,
-                                     ocfs2_convert_worker_t *worker);
-
 static struct ocfs2_lock_res_ops ocfs2_inode_rw_lops = {
        .get_osb        = ocfs2_get_inode_osb,
-       .unblock        = ocfs2_unblock_inode_lock,
        .flags          = 0,
 };
 
 static struct ocfs2_lock_res_ops ocfs2_inode_meta_lops = {
        .get_osb        = ocfs2_get_inode_osb,
-       .unblock        = ocfs2_unblock_meta,
        .check_downconvert = ocfs2_check_meta_downconvert,
        .set_lvb        = ocfs2_set_meta_lvb,
        .flags          = LOCK_TYPE_REQUIRES_REFRESH|LOCK_TYPE_USES_LVB,
@@ -190,24 +206,22 @@ static struct ocfs2_lock_res_ops ocfs2_inode_meta_lops = {
 
 static struct ocfs2_lock_res_ops ocfs2_inode_data_lops = {
        .get_osb        = ocfs2_get_inode_osb,
-       .unblock        = ocfs2_unblock_data,
+       .downconvert_worker = ocfs2_data_convert_worker,
        .flags          = 0,
 };
 
 static struct ocfs2_lock_res_ops ocfs2_super_lops = {
-       .unblock        = ocfs2_unblock_osb_lock,
        .flags          = LOCK_TYPE_REQUIRES_REFRESH,
 };
 
 static struct ocfs2_lock_res_ops ocfs2_rename_lops = {
-       .unblock        = ocfs2_unblock_osb_lock,
        .flags          = 0,
 };
 
 static struct ocfs2_lock_res_ops ocfs2_dentry_lops = {
        .get_osb        = ocfs2_get_dentry_osb,
-       .unblock        = ocfs2_unblock_dentry_lock,
        .post_unlock    = ocfs2_dentry_post_unlock,
+       .downconvert_worker = ocfs2_dentry_convert_worker,
        .flags          = 0,
 };
 
@@ -268,9 +282,6 @@ static int ocfs2_meta_lock_update(struct inode *inode,
                                  struct buffer_head **bh);
 static void ocfs2_drop_osb_locks(struct ocfs2_super *osb);
 static inline int ocfs2_highest_compat_lock_level(int level);
-static inline int ocfs2_can_downconvert_meta_lock(struct inode *inode,
-                                                 struct ocfs2_lock_res *lockres,
-                                                 int new_level);
 
 static void ocfs2_build_lock_name(enum ocfs2_lock_type type,
                                  u64 blkno,
@@ -759,7 +770,7 @@ static int ocfs2_lock_create(struct ocfs2_super *osb,
                             int dlm_flags)
 {
        int ret = 0;
-       enum dlm_status status;
+       enum dlm_status status = DLM_NORMAL;
        unsigned long flags;
 
        mlog_entry_void();
@@ -1053,10 +1064,10 @@ static void ocfs2_cluster_unlock(struct ocfs2_super *osb,
        mlog_exit_void();
 }
 
-int ocfs2_create_new_lock(struct ocfs2_super *osb,
-                         struct ocfs2_lock_res *lockres,
-                         int ex,
-                         int local)
+static int ocfs2_create_new_lock(struct ocfs2_super *osb,
+                                struct ocfs2_lock_res *lockres,
+                                int ex,
+                                int local)
 {
        int level =  ex ? LKM_EXMODE : LKM_PRMODE;
        unsigned long flags;
@@ -1127,6 +1138,7 @@ int ocfs2_rw_lock(struct inode *inode, int write)
 {
        int status, level;
        struct ocfs2_lock_res *lockres;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
 
        BUG_ON(!inode);
 
@@ -1136,6 +1148,9 @@ int ocfs2_rw_lock(struct inode *inode, int write)
             (unsigned long long)OCFS2_I(inode)->ip_blkno,
             write ? "EXMODE" : "PRMODE");
 
+       if (ocfs2_mount_local(osb))
+               return 0;
+
        lockres = &OCFS2_I(inode)->ip_rw_lockres;
 
        level = write ? LKM_EXMODE : LKM_PRMODE;
@@ -1153,6 +1168,7 @@ void ocfs2_rw_unlock(struct inode *inode, int write)
 {
        int level = write ? LKM_EXMODE : LKM_PRMODE;
        struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_rw_lockres;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
 
        mlog_entry_void();
 
@@ -1160,7 +1176,8 @@ void ocfs2_rw_unlock(struct inode *inode, int write)
             (unsigned long long)OCFS2_I(inode)->ip_blkno,
             write ? "EXMODE" : "PRMODE");
 
-       ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level);
+       if (!ocfs2_mount_local(osb))
+               ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level);
 
        mlog_exit_void();
 }
@@ -1171,6 +1188,7 @@ int ocfs2_data_lock_full(struct inode *inode,
 {
        int status = 0, level;
        struct ocfs2_lock_res *lockres;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
 
        BUG_ON(!inode);
 
@@ -1190,6 +1208,9 @@ int ocfs2_data_lock_full(struct inode *inode,
                goto out;
        }
 
+       if (ocfs2_mount_local(osb))
+               goto out;
+
        lockres = &OCFS2_I(inode)->ip_data_lockres;
 
        level = write ? LKM_EXMODE : LKM_PRMODE;
@@ -1258,6 +1279,7 @@ void ocfs2_data_unlock(struct inode *inode,
 {
        int level = write ? LKM_EXMODE : LKM_PRMODE;
        struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_data_lockres;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
 
        mlog_entry_void();
 
@@ -1265,7 +1287,8 @@ void ocfs2_data_unlock(struct inode *inode,
             (unsigned long long)OCFS2_I(inode)->ip_blkno,
             write ? "EXMODE" : "PRMODE");
 
-       if (!ocfs2_is_hard_readonly(OCFS2_SB(inode->i_sb)))
+       if (!ocfs2_is_hard_readonly(OCFS2_SB(inode->i_sb)) &&
+           !ocfs2_mount_local(osb))
                ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level);
 
        mlog_exit_void();
@@ -1456,8 +1479,9 @@ static int ocfs2_meta_lock_update(struct inode *inode,
 {
        int status = 0;
        struct ocfs2_inode_info *oi = OCFS2_I(inode);
-       struct ocfs2_lock_res *lockres;
+       struct ocfs2_lock_res *lockres = NULL;
        struct ocfs2_dinode *fe;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
 
        mlog_entry_void();
 
@@ -1472,10 +1496,12 @@ static int ocfs2_meta_lock_update(struct inode *inode,
        }
        spin_unlock(&oi->ip_lock);
 
-       lockres = &oi->ip_meta_lockres;
+       if (!ocfs2_mount_local(osb)) {
+               lockres = &oi->ip_meta_lockres;
 
-       if (!ocfs2_should_refresh_lock_res(lockres))
-               goto bail;
+               if (!ocfs2_should_refresh_lock_res(lockres))
+                       goto bail;
+       }
 
        /* This will discard any caching information we might have had
         * for the inode metadata. */
@@ -1485,7 +1511,7 @@ static int ocfs2_meta_lock_update(struct inode *inode,
         * map (directories, bitmap files, etc) */
        ocfs2_extent_map_trunc(inode, 0);
 
-       if (ocfs2_meta_lvb_is_trustable(inode, lockres)) {
+       if (lockres && ocfs2_meta_lvb_is_trustable(inode, lockres)) {
                mlog(0, "Trusting LVB on inode %llu\n",
                     (unsigned long long)oi->ip_blkno);
                ocfs2_refresh_inode_from_lvb(inode);
@@ -1532,7 +1558,8 @@ static int ocfs2_meta_lock_update(struct inode *inode,
 
        status = 0;
 bail_refresh:
-       ocfs2_complete_lock_res_refresh(lockres, status);
+       if (lockres)
+               ocfs2_complete_lock_res_refresh(lockres, status);
 bail:
        mlog_exit(status);
        return status;
@@ -1569,13 +1596,12 @@ static int ocfs2_assign_bh(struct inode *inode,
  * the result of the lock will be communicated via the callback.
  */
 int ocfs2_meta_lock_full(struct inode *inode,
-                        struct ocfs2_journal_handle *handle,
                         struct buffer_head **ret_bh,
                         int ex,
                         int arg_flags)
 {
        int status, level, dlm_flags, acquired;
-       struct ocfs2_lock_res *lockres;
+       struct ocfs2_lock_res *lockres = NULL;
        struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
        struct buffer_head *local_bh = NULL;
 
@@ -1597,6 +1623,9 @@ int ocfs2_meta_lock_full(struct inode *inode,
                goto bail;
        }
 
+       if (ocfs2_mount_local(osb))
+               goto local;
+
        if (!(arg_flags & OCFS2_META_LOCK_RECOVERY))
                wait_event(osb->recovery_event,
                           ocfs2_node_map_is_empty(osb, &osb->recovery_map));
@@ -1626,6 +1655,7 @@ int ocfs2_meta_lock_full(struct inode *inode,
                wait_event(osb->recovery_event,
                           ocfs2_node_map_is_empty(osb, &osb->recovery_map));
 
+local:
        /*
         * We only see this flag if we're being called from
         * ocfs2_read_locked_inode(). It means we're locking an inode
@@ -1634,7 +1664,8 @@ int ocfs2_meta_lock_full(struct inode *inode,
         */
        if (inode->i_state & I_NEW) {
                status = 0;
-               ocfs2_complete_lock_res_refresh(lockres, 0);
+               if (lockres)
+                       ocfs2_complete_lock_res_refresh(lockres, 0);
                goto bail;
        }
 
@@ -1658,12 +1689,6 @@ int ocfs2_meta_lock_full(struct inode *inode,
                }
        }
 
-       if (handle) {
-               status = ocfs2_handle_add_lock(handle, inode);
-               if (status < 0)
-                       mlog_errno(status);
-       }
-
 bail:
        if (status < 0) {
                if (ret_bh && (*ret_bh)) {
@@ -1703,18 +1728,16 @@ bail:
  * the lock inversion simply.
  */
 int ocfs2_meta_lock_with_page(struct inode *inode,
-                             struct ocfs2_journal_handle *handle,
                              struct buffer_head **ret_bh,
                              int ex,
                              struct page *page)
 {
        int ret;
 
-       ret = ocfs2_meta_lock_full(inode, handle, ret_bh, ex,
-                                  OCFS2_LOCK_NONBLOCK);
+       ret = ocfs2_meta_lock_full(inode, ret_bh, ex, OCFS2_LOCK_NONBLOCK);
        if (ret == -EAGAIN) {
                unlock_page(page);
-               if (ocfs2_meta_lock(inode, handle, ret_bh, ex) == 0)
+               if (ocfs2_meta_lock(inode, ret_bh, ex) == 0)
                        ocfs2_meta_unlock(inode, ex);
                ret = AOP_TRUNCATED_PAGE;
        }
@@ -1722,11 +1745,50 @@ int ocfs2_meta_lock_with_page(struct inode *inode,
        return ret;
 }
 
+int ocfs2_meta_lock_atime(struct inode *inode,
+                         struct vfsmount *vfsmnt,
+                         int *level)
+{
+       int ret;
+
+       mlog_entry_void();
+       ret = ocfs2_meta_lock(inode, NULL, 0);
+       if (ret < 0) {
+               mlog_errno(ret);
+               return ret;
+       }
+
+       /*
+        * If we should update atime, we will get EX lock,
+        * otherwise we just get PR lock.
+        */
+       if (ocfs2_should_update_atime(inode, vfsmnt)) {
+               struct buffer_head *bh = NULL;
+
+               ocfs2_meta_unlock(inode, 0);
+               ret = ocfs2_meta_lock(inode, &bh, 1);
+               if (ret < 0) {
+                       mlog_errno(ret);
+                       return ret;
+               }
+               *level = 1;
+               if (ocfs2_should_update_atime(inode, vfsmnt))
+                       ocfs2_update_inode_atime(inode, bh);
+               if (bh)
+                       brelse(bh);
+       } else
+               *level = 0;
+
+       mlog_exit(ret);
+       return ret;
+}
+
 void ocfs2_meta_unlock(struct inode *inode,
                       int ex)
 {
        int level = ex ? LKM_EXMODE : LKM_PRMODE;
        struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_meta_lockres;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
 
        mlog_entry_void();
 
@@ -1734,7 +1796,8 @@ void ocfs2_meta_unlock(struct inode *inode,
             (unsigned long long)OCFS2_I(inode)->ip_blkno,
             ex ? "EXMODE" : "PRMODE");
 
-       if (!ocfs2_is_hard_readonly(OCFS2_SB(inode->i_sb)))
+       if (!ocfs2_is_hard_readonly(OCFS2_SB(inode->i_sb)) &&
+           !ocfs2_mount_local(osb))
                ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level);
 
        mlog_exit_void();
@@ -1743,7 +1806,7 @@ void ocfs2_meta_unlock(struct inode *inode,
 int ocfs2_super_lock(struct ocfs2_super *osb,
                     int ex)
 {
-       int status;
+       int status = 0;
        int level = ex ? LKM_EXMODE : LKM_PRMODE;
        struct ocfs2_lock_res *lockres = &osb->osb_super_lockres;
        struct buffer_head *bh;
@@ -1754,6 +1817,9 @@ int ocfs2_super_lock(struct ocfs2_super *osb,
        if (ocfs2_is_hard_readonly(osb))
                return -EROFS;
 
+       if (ocfs2_mount_local(osb))
+               goto bail;
+
        status = ocfs2_cluster_lock(osb, lockres, level, 0, 0);
        if (status < 0) {
                mlog_errno(status);
@@ -1792,7 +1858,8 @@ void ocfs2_super_unlock(struct ocfs2_super *osb,
        int level = ex ? LKM_EXMODE : LKM_PRMODE;
        struct ocfs2_lock_res *lockres = &osb->osb_super_lockres;
 
-       ocfs2_cluster_unlock(osb, lockres, level);
+       if (!ocfs2_mount_local(osb))
+               ocfs2_cluster_unlock(osb, lockres, level);
 }
 
 int ocfs2_rename_lock(struct ocfs2_super *osb)
@@ -1803,6 +1870,9 @@ int ocfs2_rename_lock(struct ocfs2_super *osb)
        if (ocfs2_is_hard_readonly(osb))
                return -EROFS;
 
+       if (ocfs2_mount_local(osb))
+               return 0;
+
        status = ocfs2_cluster_lock(osb, lockres, LKM_EXMODE, 0, 0);
        if (status < 0)
                mlog_errno(status);
@@ -1814,7 +1884,8 @@ void ocfs2_rename_unlock(struct ocfs2_super *osb)
 {
        struct ocfs2_lock_res *lockres = &osb->osb_rename_lockres;
 
-       ocfs2_cluster_unlock(osb, lockres, LKM_EXMODE);
+       if (!ocfs2_mount_local(osb))
+               ocfs2_cluster_unlock(osb, lockres, LKM_EXMODE);
 }
 
 int ocfs2_dentry_lock(struct dentry *dentry, int ex)
@@ -1829,6 +1900,9 @@ int ocfs2_dentry_lock(struct dentry *dentry, int ex)
        if (ocfs2_is_hard_readonly(osb))
                return -EROFS;
 
+       if (ocfs2_mount_local(osb))
+               return 0;
+
        ret = ocfs2_cluster_lock(osb, &dl->dl_lockres, level, 0, 0);
        if (ret < 0)
                mlog_errno(ret);
@@ -1842,7 +1916,8 @@ void ocfs2_dentry_unlock(struct dentry *dentry, int ex)
        struct ocfs2_dentry_lock *dl = dentry->d_fsdata;
        struct ocfs2_super *osb = OCFS2_SB(dentry->d_sb);
 
-       ocfs2_cluster_unlock(osb, &dl->dl_lockres, level);
+       if (!ocfs2_mount_local(osb))
+               ocfs2_cluster_unlock(osb, &dl->dl_lockres, level);
 }
 
 /* Reference counting of the dlm debug structure. We want this because
@@ -2042,7 +2117,7 @@ static int ocfs2_dlm_debug_open(struct inode *inode, struct file *file)
                mlog_errno(ret);
                goto out;
        }
-       osb = (struct ocfs2_super *) inode->u.generic_ip;
+       osb = inode->i_private;
        ocfs2_get_dlm_debug(osb->osb_dlm_debug);
        priv->p_dlm_debug = osb->osb_dlm_debug;
        INIT_LIST_HEAD(&priv->p_iter_res.l_debug_list);
@@ -2105,12 +2180,15 @@ static void ocfs2_dlm_shutdown_debug(struct ocfs2_super *osb)
 
 int ocfs2_dlm_init(struct ocfs2_super *osb)
 {
-       int status;
+       int status = 0;
        u32 dlm_key;
-       struct dlm_ctxt *dlm;
+       struct dlm_ctxt *dlm = NULL;
 
        mlog_entry_void();
 
+       if (ocfs2_mount_local(osb))
+               goto local;
+
        status = ocfs2_dlm_init_debug(osb);
        if (status < 0) {
                mlog_errno(status);
@@ -2138,11 +2216,12 @@ int ocfs2_dlm_init(struct ocfs2_super *osb)
                goto bail;
        }
 
+       dlm_register_eviction_cb(dlm, &osb->osb_eviction_cb);
+
+local:
        ocfs2_super_lock_res_init(&osb->osb_super_lockres, osb);
        ocfs2_rename_lock_res_init(&osb->osb_rename_lockres, osb);
 
-       dlm_register_eviction_cb(dlm, &osb->osb_eviction_cb);
-
        osb->dlm = dlm;
 
        status = 0;
@@ -2237,16 +2316,8 @@ complete_unlock:
        mlog_exit_void();
 }
 
-typedef void (ocfs2_pre_drop_cb_t)(struct ocfs2_lock_res *, void *);
-
-struct drop_lock_cb {
-       ocfs2_pre_drop_cb_t     *drop_func;
-       void                    *drop_data;
-};
-
 static int ocfs2_drop_lock(struct ocfs2_super *osb,
-                          struct ocfs2_lock_res *lockres,
-                          struct drop_lock_cb *dcb)
+                          struct ocfs2_lock_res *lockres)
 {
        enum dlm_status status;
        unsigned long flags;
@@ -2281,8 +2352,12 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb,
                spin_lock_irqsave(&lockres->l_lock, flags);
        }
 
-       if (dcb)
-               dcb->drop_func(lockres, dcb->drop_data);
+       if (lockres->l_ops->flags & LOCK_TYPE_USES_LVB) {
+               if (lockres->l_flags & OCFS2_LOCK_ATTACHED &&
+                   lockres->l_level == LKM_EXMODE &&
+                   !(lockres->l_flags & OCFS2_LOCK_NEEDS_REFRESH))
+                       lockres->l_ops->set_lvb(lockres);
+       }
 
        if (lockres->l_flags & OCFS2_LOCK_BUSY)
                mlog(ML_ERROR, "destroying busy lock: \"%s\"\n",
@@ -2362,7 +2437,7 @@ void ocfs2_simple_drop_lockres(struct ocfs2_super *osb,
        int ret;
 
        ocfs2_mark_lockres_freeing(lockres);
-       ret = ocfs2_drop_lock(osb, lockres, NULL);
+       ret = ocfs2_drop_lock(osb, lockres);
        if (ret)
                mlog_errno(ret);
 }
@@ -2373,22 +2448,9 @@ static void ocfs2_drop_osb_locks(struct ocfs2_super *osb)
        ocfs2_simple_drop_lockres(osb, &osb->osb_rename_lockres);
 }
 
-static void ocfs2_meta_pre_drop(struct ocfs2_lock_res *lockres, void *data)
-{
-       struct inode *inode = data;
-
-       /* the metadata lock requires a bit more work as we have an
-        * LVB to worry about. */
-       if (lockres->l_flags & OCFS2_LOCK_ATTACHED &&
-           lockres->l_level == LKM_EXMODE &&
-           !(lockres->l_flags & OCFS2_LOCK_NEEDS_REFRESH))
-               __ocfs2_stuff_meta_lvb(inode);
-}
-
 int ocfs2_drop_inode_locks(struct inode *inode)
 {
        int status, err;
-       struct drop_lock_cb meta_dcb = { ocfs2_meta_pre_drop, inode, };
 
        mlog_entry_void();
 
@@ -2396,24 +2458,21 @@ int ocfs2_drop_inode_locks(struct inode *inode)
         * ocfs2_clear_inode has done it for us. */
 
        err = ocfs2_drop_lock(OCFS2_SB(inode->i_sb),
-                             &OCFS2_I(inode)->ip_data_lockres,
-                             NULL);
+                             &OCFS2_I(inode)->ip_data_lockres);
        if (err < 0)
                mlog_errno(err);
 
        status = err;
 
        err = ocfs2_drop_lock(OCFS2_SB(inode->i_sb),
-                             &OCFS2_I(inode)->ip_meta_lockres,
-                             &meta_dcb);
+                             &OCFS2_I(inode)->ip_meta_lockres);
        if (err < 0)
                mlog_errno(err);
        if (err < 0 && !status)
                status = err;
 
        err = ocfs2_drop_lock(OCFS2_SB(inode->i_sb),
-                             &OCFS2_I(inode)->ip_rw_lockres,
-                             NULL);
+                             &OCFS2_I(inode)->ip_rw_lockres);
        if (err < 0)
                mlog_errno(err);
        if (err < 0 && !status)
@@ -2538,110 +2597,9 @@ static int ocfs2_cancel_convert(struct ocfs2_super *osb,
        return ret;
 }
 
-static inline int ocfs2_can_downconvert_meta_lock(struct inode *inode,
-                                                 struct ocfs2_lock_res *lockres,
-                                                 int new_level)
-{
-       int ret;
-
-       mlog_entry_void();
-
-       BUG_ON(new_level != LKM_NLMODE && new_level != LKM_PRMODE);
-
-       if (lockres->l_flags & OCFS2_LOCK_REFRESHING) {
-               ret = 0;
-               mlog(0, "lockres %s currently being refreshed -- backing "
-                    "off!\n", lockres->l_name);
-       } else if (new_level == LKM_PRMODE)
-               ret = !lockres->l_ex_holders &&
-                       ocfs2_inode_fully_checkpointed(inode);
-       else /* Must be NLMODE we're converting to. */
-               ret = !lockres->l_ro_holders && !lockres->l_ex_holders &&
-                       ocfs2_inode_fully_checkpointed(inode);
-
-       mlog_exit(ret);
-       return ret;
-}
-
-static int ocfs2_do_unblock_meta(struct inode *inode,
-                                int *requeue)
-{
-       int new_level;
-       int set_lvb = 0;
-       int ret = 0;
-       struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_meta_lockres;
-       unsigned long flags;
-
-       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
-
-       mlog_entry_void();
-
-       spin_lock_irqsave(&lockres->l_lock, flags);
-
-       BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BLOCKED));
-
-       mlog(0, "l_level=%d, l_blocking=%d\n", lockres->l_level,
-            lockres->l_blocking);
-
-       BUG_ON(lockres->l_level != LKM_EXMODE &&
-              lockres->l_level != LKM_PRMODE);
-
-       if (lockres->l_flags & OCFS2_LOCK_BUSY) {
-               *requeue = 1;
-               ret = ocfs2_prepare_cancel_convert(osb, lockres);
-               spin_unlock_irqrestore(&lockres->l_lock, flags);
-               if (ret) {
-                       ret = ocfs2_cancel_convert(osb, lockres);
-                       if (ret < 0)
-                               mlog_errno(ret);
-               }
-               goto leave;
-       }
-
-       new_level = ocfs2_highest_compat_lock_level(lockres->l_blocking);
-
-       mlog(0, "l_level=%d, l_blocking=%d, new_level=%d\n",
-            lockres->l_level, lockres->l_blocking, new_level);
-
-       if (ocfs2_can_downconvert_meta_lock(inode, lockres, new_level)) {
-               if (lockres->l_level == LKM_EXMODE)
-                       set_lvb = 1;
-
-               /* If the lock hasn't been refreshed yet (rare), then
-                * our memory inode values are old and we skip
-                * stuffing the lvb. There's no need to actually clear
-                * out the lvb here as it's value is still valid. */
-               if (!(lockres->l_flags & OCFS2_LOCK_NEEDS_REFRESH)) {
-                       if (set_lvb)
-                               __ocfs2_stuff_meta_lvb(inode);
-               } else
-                       mlog(0, "lockres %s: downconverting stale lock!\n",
-                            lockres->l_name);
-
-               mlog(0, "calling ocfs2_downconvert_lock with l_level=%d, "
-                    "l_blocking=%d, new_level=%d\n",
-                    lockres->l_level, lockres->l_blocking, new_level);
-
-               ocfs2_prepare_downconvert(lockres, new_level);
-               spin_unlock_irqrestore(&lockres->l_lock, flags);
-               ret = ocfs2_downconvert_lock(osb, lockres, new_level, set_lvb);
-               goto leave;
-       }
-       if (!ocfs2_inode_fully_checkpointed(inode))
-               ocfs2_start_checkpoint(osb);
-
-       *requeue = 1;
-       spin_unlock_irqrestore(&lockres->l_lock, flags);
-       ret = 0;
-leave:
-       mlog_exit(ret);
-       return ret;
-}
-
-static int ocfs2_generic_unblock_lock(struct ocfs2_super *osb,
-                                     struct ocfs2_lock_res *lockres,
-                                     struct ocfs2_unblock_ctl *ctl,
-                                     ocfs2_convert_worker_t *worker)
+static int ocfs2_unblock_lock(struct ocfs2_super *osb,
+                             struct ocfs2_lock_res *lockres,
+                             struct ocfs2_unblock_ctl *ctl)
 {
        unsigned long flags;
        int blocking;
@@ -2697,7 +2655,7 @@ recheck:
        /* If we get here, then we know that there are no more
         * incompatible holders (and anyone asking for an incompatible
         * lock is blocked). We can now downconvert the lock */
-       if (!worker)
+       if (!lockres->l_ops->downconvert_worker)
                goto downconvert;
 
        /* Some lockres types want to do a bit of work before
@@ -2707,7 +2665,7 @@ recheck:
        blocking = lockres->l_blocking;
        spin_unlock_irqrestore(&lockres->l_lock, flags);
 
-       ctl->unblock_action = worker(lockres, blocking);
+       ctl->unblock_action = lockres->l_ops->downconvert_worker(lockres, blocking);
 
        if (ctl->unblock_action == UNBLOCK_STOP_POST)
                goto leave;
@@ -2780,54 +2738,6 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
        return UNBLOCK_CONTINUE;
 }
 
-int ocfs2_unblock_data(struct ocfs2_lock_res *lockres,
-                      struct ocfs2_unblock_ctl *ctl)
-{
-       int status;
-       struct inode *inode;
-       struct ocfs2_super *osb;
-
-       mlog_entry_void();
-
-       inode = ocfs2_lock_res_inode(lockres);
-       osb = OCFS2_SB(inode->i_sb);
-
-       mlog(0, "unblock inode %llu\n",
-            (unsigned long long)OCFS2_I(inode)->ip_blkno);
-
-       status = ocfs2_generic_unblock_lock(osb, lockres, ctl,
-                                           ocfs2_data_convert_worker);
-       if (status < 0)
-               mlog_errno(status);
-
-       mlog(0, "inode %llu, requeue = %d\n",
-            (unsigned long long)OCFS2_I(inode)->ip_blkno, ctl->requeue);
-
-       mlog_exit(status);
-       return status;
-}
-
-static int ocfs2_unblock_inode_lock(struct ocfs2_lock_res *lockres,
-                                   struct ocfs2_unblock_ctl *ctl)
-{
-       int status;
-       struct inode *inode;
-
-       mlog_entry_void();
-
-       mlog(0, "Unblock lockres %s\n", lockres->l_name);
-
-       inode  = ocfs2_lock_res_inode(lockres);
-
-       status = ocfs2_generic_unblock_lock(OCFS2_SB(inode->i_sb),
-                                           lockres, ctl, NULL);
-       if (status < 0)
-               mlog_errno(status);
-
-       mlog_exit(status);
-       return status;
-}
-
 static int ocfs2_check_meta_downconvert(struct ocfs2_lock_res *lockres,
                                        int new_level)
 {
@@ -2851,31 +2761,6 @@ static void ocfs2_set_meta_lvb(struct ocfs2_lock_res *lockres)
        __ocfs2_stuff_meta_lvb(inode);
 }
 
-static int ocfs2_unblock_meta(struct ocfs2_lock_res *lockres,
-                             struct ocfs2_unblock_ctl *ctl)
-{
-       int status;
-       struct inode *inode;
-
-       mlog_entry_void();
-
-               inode = ocfs2_lock_res_inode(lockres);
-
-       mlog(0, "unblock inode %llu\n",
-            (unsigned long long)OCFS2_I(inode)->ip_blkno);
-
-       status = ocfs2_generic_unblock_lock(OCFS2_SB(inode->i_sb),
-                                           lockres, ctl, NULL);
-       if (status < 0)
-               mlog_errno(status);
-
-       mlog(0, "inode %llu, requeue = %d\n",
-            (unsigned long long)OCFS2_I(inode)->ip_blkno, ctl->requeue);
-
-       mlog_exit(status);
-       return status;
-}
-
 /*
  * Does the final reference drop on our dentry lock. Right now this
  * happens in the vote thread, but we could choose to simplify the
@@ -2998,53 +2883,6 @@ static int ocfs2_dentry_convert_worker(struct ocfs2_lock_res *lockres,
        return UNBLOCK_CONTINUE_POST;
 }
 
-static int ocfs2_unblock_dentry_lock(struct ocfs2_lock_res *lockres,
-                                    struct ocfs2_unblock_ctl *ctl)
-{
-       int ret;
-       struct ocfs2_dentry_lock *dl = ocfs2_lock_res_dl(lockres);
-       struct ocfs2_super *osb = OCFS2_SB(dl->dl_inode->i_sb);
-
-       mlog(0, "unblock dentry lock: %llu\n",
-            (unsigned long long)OCFS2_I(dl->dl_inode)->ip_blkno);
-
-       ret = ocfs2_generic_unblock_lock(osb,
-                                        lockres,
-                                        ctl,
-                                        ocfs2_dentry_convert_worker);
-       if (ret < 0)
-               mlog_errno(ret);
-
-       mlog(0, "requeue = %d, post = %d\n", ctl->requeue, ctl->unblock_action);
-
-       return ret;
-}
-
-/* Generic unblock function for any lockres whose private data is an
- * ocfs2_super pointer. */
-static int ocfs2_unblock_osb_lock(struct ocfs2_lock_res *lockres,
-                                 struct ocfs2_unblock_ctl *ctl)
-{
-       int status;
-       struct ocfs2_super *osb;
-
-       mlog_entry_void();
-
-       mlog(0, "Unblock lockres %s\n", lockres->l_name);
-
-       osb = ocfs2_get_lockres_osb(lockres);
-
-       status = ocfs2_generic_unblock_lock(osb,
-                                           lockres,
-                                           ctl,
-                                           NULL);
-       if (status < 0)
-               mlog_errno(status);
-
-       mlog_exit(status);
-       return status;
-}
-
 void ocfs2_process_blocked_lock(struct ocfs2_super *osb,
                                struct ocfs2_lock_res *lockres)
 {
@@ -3060,7 +2898,6 @@ void ocfs2_process_blocked_lock(struct ocfs2_super *osb,
 
        BUG_ON(!lockres);
        BUG_ON(!lockres->l_ops);
-       BUG_ON(!lockres->l_ops->unblock);
 
        mlog(0, "lockres %s blocked.\n", lockres->l_name);
 
@@ -3074,7 +2911,7 @@ void ocfs2_process_blocked_lock(struct ocfs2_super *osb,
                goto unqueue;
        spin_unlock_irqrestore(&lockres->l_lock, flags);
 
-       status = lockres->l_ops->unblock(lockres, &ctl);
+       status = ocfs2_unblock_lock(osb, lockres, &ctl);
        if (status < 0)
                mlog_errno(status);