]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - fs/udf/super.c
[IPV6] route: kill some bloat
[linux-2.6-omap-h63xx.git] / fs / udf / super.c
index 72097ee6b75284c6d3b06a3cf90084a918052ee3..4360c7a05743727a3f7b94753057a5a831eb2b0b 100644 (file)
@@ -89,7 +89,7 @@ static int udf_find_fileset(struct super_block *, kernel_lb_addr *,
 static void udf_load_pvoldesc(struct super_block *, struct buffer_head *);
 static void udf_load_fileset(struct super_block *, struct buffer_head *,
                             kernel_lb_addr *);
-static void udf_load_partdesc(struct super_block *, struct buffer_head *);
+static int udf_load_partdesc(struct super_block *, struct buffer_head *);
 static void udf_open_lvid(struct super_block *);
 static void udf_close_lvid(struct super_block *);
 static unsigned int udf_count_free(struct super_block *);
@@ -104,11 +104,11 @@ static int udf_get_sb(struct file_system_type *fs_type,
 }
 
 static struct file_system_type udf_fstype = {
-       .owner = THIS_MODULE,
-       .name = "udf",
-       .get_sb = udf_get_sb,
-       .kill_sb = kill_block_super,
-       .fs_flags = FS_REQUIRES_DEV,
+       .owner          = THIS_MODULE,
+       .name           = "udf",
+       .get_sb         = udf_get_sb,
+       .kill_sb        = kill_block_super,
+       .fs_flags       = FS_REQUIRES_DEV,
 };
 
 static struct kmem_cache *udf_inode_cachep;
@@ -116,8 +116,7 @@ static struct kmem_cache *udf_inode_cachep;
 static struct inode *udf_alloc_inode(struct super_block *sb)
 {
        struct udf_inode_info *ei;
-       ei = (struct udf_inode_info *)kmem_cache_alloc(udf_inode_cachep,
-                                                      GFP_KERNEL);
+       ei = (struct udf_inode_info *)kmem_cache_alloc(udf_inode_cachep, GFP_KERNEL);
        if (!ei)
                return NULL;
 
@@ -135,7 +134,7 @@ static void udf_destroy_inode(struct inode *inode)
        kmem_cache_free(udf_inode_cachep, UDF_I(inode));
 }
 
-static void init_once(void *foo, struct kmem_cache *cachep, unsigned long flags)
+static void init_once(struct kmem_cache *cachep, void *foo)
 {
        struct udf_inode_info *ei = (struct udf_inode_info *)foo;
 
@@ -150,7 +149,7 @@ static int init_inodecache(void)
                                             0, (SLAB_RECLAIM_ACCOUNT |
                                                 SLAB_MEM_SPREAD),
                                             init_once);
-       if (udf_inode_cachep == NULL)
+       if (!udf_inode_cachep)
                return -ENOMEM;
        return 0;
 }
@@ -162,15 +161,15 @@ static void destroy_inodecache(void)
 
 /* Superblock operations */
 static const struct super_operations udf_sb_ops = {
-       .alloc_inode = udf_alloc_inode,
-       .destroy_inode = udf_destroy_inode,
-       .write_inode = udf_write_inode,
-       .delete_inode = udf_delete_inode,
-       .clear_inode = udf_clear_inode,
-       .put_super = udf_put_super,
-       .write_super = udf_write_super,
-       .statfs = udf_statfs,
-       .remount_fs = udf_remount_fs,
+       .alloc_inode    = udf_alloc_inode,
+       .destroy_inode  = udf_destroy_inode,
+       .write_inode    = udf_write_inode,
+       .delete_inode   = udf_delete_inode,
+       .clear_inode    = udf_clear_inode,
+       .put_super      = udf_put_super,
+       .write_super    = udf_write_super,
+       .statfs         = udf_statfs,
+       .remount_fs     = udf_remount_fs,
 };
 
 struct udf_options {
@@ -193,16 +192,20 @@ struct udf_options {
 static int __init init_udf_fs(void)
 {
        int err;
+
        err = init_inodecache();
        if (err)
                goto out1;
        err = register_filesystem(&udf_fstype);
        if (err)
                goto out;
+
        return 0;
-      out:
+
+out:
        destroy_inodecache();
-      out1:
+
+out1:
        return err;
 }
 
@@ -213,7 +216,7 @@ static void __exit exit_udf_fs(void)
 }
 
 module_init(init_udf_fs)
-    module_exit(exit_udf_fs)
+module_exit(exit_udf_fs)
 
 /*
  * udf_parse_options
@@ -239,7 +242,7 @@ module_init(init_udf_fs)
  *
  *     The remaining are for debugging and disaster recovery:
  *
- *     novrs           Skip volume sequence recognition 
+ *     novrs           Skip volume sequence recognition
  *
  *     The following expect a offset from 0.
  *
@@ -268,6 +271,7 @@ module_init(init_udf_fs)
  *     July 1, 1997 - Andrew E. Mileski
  *     Written, tested, and released.
  */
+
 enum {
        Opt_novrs, Opt_nostrict, Opt_bs, Opt_unhide, Opt_undelete,
        Opt_noadinicb, Opt_adinicb, Opt_shortad, Opt_longad,
@@ -278,32 +282,32 @@ enum {
 };
 
 static match_table_t tokens = {
-       {Opt_novrs, "novrs"},
-       {Opt_nostrict, "nostrict"},
-       {Opt_bs, "bs=%u"},
-       {Opt_unhide, "unhide"},
-       {Opt_undelete, "undelete"},
-       {Opt_noadinicb, "noadinicb"},
-       {Opt_adinicb, "adinicb"},
-       {Opt_shortad, "shortad"},
-       {Opt_longad, "longad"},
-       {Opt_uforget, "uid=forget"},
-       {Opt_uignore, "uid=ignore"},
-       {Opt_gforget, "gid=forget"},
-       {Opt_gignore, "gid=ignore"},
-       {Opt_gid, "gid=%u"},
-       {Opt_uid, "uid=%u"},
-       {Opt_umask, "umask=%o"},
-       {Opt_session, "session=%u"},
-       {Opt_lastblock, "lastblock=%u"},
-       {Opt_anchor, "anchor=%u"},
-       {Opt_volume, "volume=%u"},
-       {Opt_partition, "partition=%u"},
-       {Opt_fileset, "fileset=%u"},
-       {Opt_rootdir, "rootdir=%u"},
-       {Opt_utf8, "utf8"},
-       {Opt_iocharset, "iocharset=%s"},
-       {Opt_err, NULL}
+       {Opt_novrs,     "novrs"},
+       {Opt_nostrict,  "nostrict"},
+       {Opt_bs,        "bs=%u"},
+       {Opt_unhide,    "unhide"},
+       {Opt_undelete,  "undelete"},
+       {Opt_noadinicb, "noadinicb"},
+       {Opt_adinicb,   "adinicb"},
+       {Opt_shortad,   "shortad"},
+       {Opt_longad,    "longad"},
+       {Opt_uforget,   "uid=forget"},
+       {Opt_uignore,   "uid=ignore"},
+       {Opt_gforget,   "gid=forget"},
+       {Opt_gignore,   "gid=ignore"},
+       {Opt_gid,       "gid=%u"},
+       {Opt_uid,       "uid=%u"},
+       {Opt_umask,     "umask=%o"},
+       {Opt_session,   "session=%u"},
+       {Opt_lastblock, "lastblock=%u"},
+       {Opt_anchor,    "anchor=%u"},
+       {Opt_volume,    "volume=%u"},
+       {Opt_partition, "partition=%u"},
+       {Opt_fileset,   "fileset=%u"},
+       {Opt_rootdir,   "rootdir=%u"},
+       {Opt_utf8,      "utf8"},
+       {Opt_iocharset, "iocharset=%s"},
+       {Opt_err,       NULL}
 };
 
 static int udf_parse_options(char *options, struct udf_options *uopt)
@@ -362,11 +366,13 @@ static int udf_parse_options(char *options, struct udf_options *uopt)
                        if (match_int(args, &option))
                                return 0;
                        uopt->gid = option;
+                       uopt->flags |= (1 << UDF_FLAG_GID_SET);
                        break;
                case Opt_uid:
                        if (match_int(args, &option))
                                return 0;
                        uopt->uid = option;
+                       uopt->flags |= (1 << UDF_FLAG_UID_SET);
                        break;
                case Opt_umask:
                        if (match_octal(args, &option))
@@ -444,9 +450,11 @@ static int udf_parse_options(char *options, struct udf_options *uopt)
 void udf_write_super(struct super_block *sb)
 {
        lock_kernel();
+
        if (!(sb->s_flags & MS_RDONLY))
                udf_open_lvid(sb);
        sb->s_dirt = 0;
+
        unlock_kernel();
 }
 
@@ -455,16 +463,16 @@ static int udf_remount_fs(struct super_block *sb, int *flags, char *options)
        struct udf_options uopt;
 
        uopt.flags = UDF_SB(sb)->s_flags;
-       uopt.uid = UDF_SB(sb)->s_uid;
-       uopt.gid = UDF_SB(sb)->s_gid;
+       uopt.uid   = UDF_SB(sb)->s_uid;
+       uopt.gid   = UDF_SB(sb)->s_gid;
        uopt.umask = UDF_SB(sb)->s_umask;
 
        if (!udf_parse_options(options, &uopt))
                return -EINVAL;
 
        UDF_SB(sb)->s_flags = uopt.flags;
-       UDF_SB(sb)->s_uid = uopt.uid;
-       UDF_SB(sb)->s_gid = uopt.gid;
+       UDF_SB(sb)->s_uid   = uopt.uid;
+       UDF_SB(sb)->s_gid   = uopt.gid;
        UDF_SB(sb)->s_umask = uopt.umask;
 
        if (UDF_SB_LVIDBH(sb)) {
@@ -517,6 +525,7 @@ static int udf_set_blocksize(struct super_block *sb, int bsize)
                printk(KERN_ERR "udf: bad block size (%d)\n", bsize);
                return 0;
        }
+
        return sb->s_blocksize;
 }
 
@@ -552,15 +561,12 @@ static int udf_vrs(struct super_block *sb, int silent)
 
                /* Look for ISO  descriptors */
                vsd = (struct volStructDesc *)(bh->b_data +
-                                              (sector &
-                                               (sb->s_blocksize - 1)));
+                                              (sector & (sb->s_blocksize - 1)));
 
                if (vsd->stdIdent[0] == 0) {
                        brelse(bh);
                        break;
-               } else
-                   if (!strncmp
-                       (vsd->stdIdent, VSD_STD_ID_CD001, VSD_STD_ID_LEN)) {
+               } else if (!strncmp(vsd->stdIdent, VSD_STD_ID_CD001, VSD_STD_ID_LEN)) {
                        iso9660 = sector;
                        switch (vsd->structType) {
                        case 0:
@@ -587,21 +593,13 @@ static int udf_vrs(struct super_block *sb, int silent)
                                          vsd->structType);
                                break;
                        }
-               } else
-                   if (!strncmp
-                       (vsd->stdIdent, VSD_STD_ID_BEA01, VSD_STD_ID_LEN)) {
-               } else
-                   if (!strncmp
-                       (vsd->stdIdent, VSD_STD_ID_TEA01, VSD_STD_ID_LEN)) {
+               } else if (!strncmp(vsd->stdIdent, VSD_STD_ID_BEA01, VSD_STD_ID_LEN)) {
+               } else if (!strncmp(vsd->stdIdent, VSD_STD_ID_TEA01, VSD_STD_ID_LEN)) {
                        brelse(bh);
                        break;
-               } else
-                   if (!strncmp
-                       (vsd->stdIdent, VSD_STD_ID_NSR02, VSD_STD_ID_LEN)) {
+               } else if (!strncmp(vsd->stdIdent, VSD_STD_ID_NSR02, VSD_STD_ID_LEN)) {
                        nsr02 = sector;
-               } else
-                   if (!strncmp
-                       (vsd->stdIdent, VSD_STD_ID_NSR03, VSD_STD_ID_LEN)) {
+               } else if (!strncmp(vsd->stdIdent, VSD_STD_ID_NSR03, VSD_STD_ID_LEN)) {
                        nsr03 = sector;
                }
                brelse(bh);
@@ -644,11 +642,10 @@ static void udf_find_anchor(struct super_block *sb)
 
        if (lastblock) {
                int varlastblock = udf_variable_to_fixed(lastblock);
-               int last[] = { lastblock, lastblock - 2,
-                       lastblock - 150, lastblock - 152,
-                       varlastblock, varlastblock - 2,
-                       varlastblock - 150, varlastblock - 152
-               };
+               int last[] =  { lastblock, lastblock - 2,
+                               lastblock - 150, lastblock - 152,
+                               varlastblock, varlastblock - 2,
+                               varlastblock - 150, varlastblock - 152 };
 
                lastblock = 0;
 
@@ -664,88 +661,54 @@ static void udf_find_anchor(struct super_block *sb)
                        if (last[i] < 0 || !(bh = sb_bread(sb, last[i]))) {
                                ident = location = 0;
                        } else {
-                               ident =
-                                   le16_to_cpu(((tag *) bh->b_data)->tagIdent);
-                               location =
-                                   le32_to_cpu(((tag *) bh->b_data)->
-                                               tagLocation);
+                               ident = le16_to_cpu(((tag *)bh->b_data)->tagIdent);
+                               location = le32_to_cpu(((tag *)bh->b_data)->tagLocation);
                                brelse(bh);
                        }
 
                        if (ident == TAG_IDENT_AVDP) {
                                if (location == last[i] - UDF_SB_SESSION(sb)) {
-                                       lastblock = UDF_SB_ANCHOR(sb)[0] =
-                                           last[i] - UDF_SB_SESSION(sb);
-                                       UDF_SB_ANCHOR(sb)[1] =
-                                           last[i] - 256 - UDF_SB_SESSION(sb);
-                               } else if (location ==
-                                          udf_variable_to_fixed(last[i]) -
-                                          UDF_SB_SESSION(sb)) {
+                                       lastblock = UDF_SB_ANCHOR(sb)[0] = last[i] - UDF_SB_SESSION(sb);
+                                       UDF_SB_ANCHOR(sb)[1] = last[i] - 256 - UDF_SB_SESSION(sb);
+                               } else if (location == udf_variable_to_fixed(last[i]) - UDF_SB_SESSION(sb)) {
                                        UDF_SET_FLAG(sb, UDF_FLAG_VARCONV);
-                                       lastblock = UDF_SB_ANCHOR(sb)[0] =
-                                           udf_variable_to_fixed(last[i]) -
-                                           UDF_SB_SESSION(sb);
-                                       UDF_SB_ANCHOR(sb)[1] =
-                                           lastblock - 256 -
-                                           UDF_SB_SESSION(sb);
-                               } else
-                                       udf_debug
-                                           ("Anchor found at block %d, location mismatch %d.\n",
-                                            last[i], location);
-                       } else if (ident == TAG_IDENT_FE
-                                  || ident == TAG_IDENT_EFE) {
+                                       lastblock = UDF_SB_ANCHOR(sb)[0] = udf_variable_to_fixed(last[i]) - UDF_SB_SESSION(sb);
+                                       UDF_SB_ANCHOR(sb)[1] = lastblock - 256 - UDF_SB_SESSION(sb);
+                               } else {
+                                       udf_debug("Anchor found at block %d, location mismatch %d.\n",
+                                                 last[i], location);
+                               }
+                       } else if (ident == TAG_IDENT_FE || ident == TAG_IDENT_EFE) {
                                lastblock = last[i];
                                UDF_SB_ANCHOR(sb)[3] = 512;
                        } else {
-                               if (last[i] < 256
-                                   || !(bh = sb_bread(sb, last[i] - 256))) {
+                               if (last[i] < 256 || !(bh = sb_bread(sb, last[i] - 256))) {
                                        ident = location = 0;
                                } else {
-                                       ident =
-                                           le16_to_cpu(((tag *) bh->b_data)->
-                                                       tagIdent);
-                                       location =
-                                           le32_to_cpu(((tag *) bh->b_data)->
-                                                       tagLocation);
+                                       ident = le16_to_cpu(((tag *)bh->b_data)->tagIdent);
+                                       location = le32_to_cpu(((tag *)bh->b_data)->tagLocation);
                                        brelse(bh);
                                }
 
                                if (ident == TAG_IDENT_AVDP &&
-                                   location ==
-                                   last[i] - 256 - UDF_SB_SESSION(sb)) {
+                                   location == last[i] - 256 - UDF_SB_SESSION(sb)) {
                                        lastblock = last[i];
                                        UDF_SB_ANCHOR(sb)[1] = last[i] - 256;
                                } else {
-                                       if (last[i] < 312 + UDF_SB_SESSION(sb)
-                                           || !(bh =
-                                                sb_bread(sb,
-                                                         last[i] - 312 -
-                                                         UDF_SB_SESSION(sb))))
-                                       {
+                                       if (last[i] < 312 + UDF_SB_SESSION(sb) ||
+                                           !(bh = sb_bread(sb, last[i] - 312 - UDF_SB_SESSION(sb)))) {
                                                ident = location = 0;
                                        } else {
-                                               ident =
-                                                   le16_to_cpu(((tag *) bh->
-                                                                b_data)->
-                                                               tagIdent);
-                                               location =
-                                                   le32_to_cpu(((tag *) bh->
-                                                                b_data)->
-                                                               tagLocation);
+                                               ident = le16_to_cpu(((tag *)bh->b_data)->tagIdent);
+                                               location = le32_to_cpu(((tag *)bh->b_data)->tagLocation);
                                                brelse(bh);
                                        }
 
                                        if (ident == TAG_IDENT_AVDP &&
-                                           location ==
-                                           udf_variable_to_fixed(last[i]) -
-                                           256) {
-                                               UDF_SET_FLAG(sb,
-                                                            UDF_FLAG_VARCONV);
-                                               lastblock =
-                                                   udf_variable_to_fixed(last
-                                                                         [i]);
-                                               UDF_SB_ANCHOR(sb)[1] =
-                                                   lastblock - 256;
+                                           location == udf_variable_to_fixed(last[i]) - 256) {
+                                               UDF_SET_FLAG(sb, UDF_FLAG_VARCONV);
+                                               lastblock = udf_variable_to_fixed(last[i]);
+                                               UDF_SB_ANCHOR(sb)[1] = lastblock - 256;
                                        }
                                }
                        }
@@ -755,9 +718,8 @@ static void udf_find_anchor(struct super_block *sb)
        if (!lastblock) {
                /* We havn't found the lastblock. check 312 */
                if ((bh = sb_bread(sb, 312 + UDF_SB_SESSION(sb)))) {
-                       ident = le16_to_cpu(((tag *) bh->b_data)->tagIdent);
-                       location =
-                           le32_to_cpu(((tag *) bh->b_data)->tagLocation);
+                       ident = le16_to_cpu(((tag *)bh->b_data)->tagIdent);
+                       location = le32_to_cpu(((tag *)bh->b_data)->tagLocation);
                        brelse(bh);
 
                        if (ident == TAG_IDENT_AVDP && location == 256)
@@ -767,19 +729,13 @@ static void udf_find_anchor(struct super_block *sb)
 
        for (i = 0; i < ARRAY_SIZE(UDF_SB_ANCHOR(sb)); i++) {
                if (UDF_SB_ANCHOR(sb)[i]) {
-                       if (!(bh = udf_read_tagged(sb,
-                                                  UDF_SB_ANCHOR(sb)[i],
-                                                  UDF_SB_ANCHOR(sb)[i],
-                                                  &ident))) {
+                       if (!(bh = udf_read_tagged(sb, UDF_SB_ANCHOR(sb)[i],
+                                                  UDF_SB_ANCHOR(sb)[i], &ident))) {
                                UDF_SB_ANCHOR(sb)[i] = 0;
                        } else {
                                brelse(bh);
-                               if ((ident != TAG_IDENT_AVDP) && (i ||
-                                                                 (ident !=
-                                                                  TAG_IDENT_FE
-                                                                  && ident !=
-                                                                  TAG_IDENT_EFE)))
-                               {
+                               if ((ident != TAG_IDENT_AVDP) &&
+                                   (i || (ident != TAG_IDENT_FE && ident != TAG_IDENT_EFE))) {
                                        UDF_SB_ANCHOR(sb)[i] = 0;
                                }
                        }
@@ -789,9 +745,7 @@ static void udf_find_anchor(struct super_block *sb)
        UDF_SB_LASTBLOCK(sb) = lastblock;
 }
 
-static int
-udf_find_fileset(struct super_block *sb, kernel_lb_addr * fileset,
-                kernel_lb_addr * root)
+static int udf_find_fileset(struct super_block *sb, kernel_lb_addr *fileset, kernel_lb_addr *root)
 {
        struct buffer_head *bh = NULL;
        long lastblock;
@@ -801,18 +755,19 @@ udf_find_fileset(struct super_block *sb, kernel_lb_addr * fileset,
            fileset->partitionReferenceNum != 0xFFFF) {
                bh = udf_read_ptagged(sb, *fileset, 0, &ident);
 
-               if (!bh)
+               if (!bh) {
                        return 1;
-               else if (ident != TAG_IDENT_FSD) {
+               else if (ident != TAG_IDENT_FSD) {
                        brelse(bh);
                        return 1;
                }
 
        }
 
-       if (!bh) {              /* Search backwards through the partitions */
+       if (!bh) { /* Search backwards through the partitions */
                kernel_lb_addr newfileset;
 
+/* --> cvg: FIXME - is it reasonable? */
                return 1;
 
                for (newfileset.partitionReferenceNum = UDF_SB_NUMPARTS(sb) - 1;
@@ -820,14 +775,11 @@ udf_find_fileset(struct super_block *sb, kernel_lb_addr * fileset,
                      fileset->logicalBlockNum == 0xFFFFFFFF &&
                      fileset->partitionReferenceNum == 0xFFFF);
                     newfileset.partitionReferenceNum--) {
-                       lastblock =
-                           UDF_SB_PARTLEN(sb,
-                                          newfileset.partitionReferenceNum);
+                       lastblock = UDF_SB_PARTLEN(sb, newfileset.partitionReferenceNum);
                        newfileset.logicalBlockNum = 0;
 
                        do {
-                               bh = udf_read_ptagged(sb, newfileset, 0,
-                                                     &ident);
+                               bh = udf_read_ptagged(sb, newfileset, 0, &ident);
                                if (!bh) {
                                        newfileset.logicalBlockNum++;
                                        continue;
@@ -835,38 +787,28 @@ udf_find_fileset(struct super_block *sb, kernel_lb_addr * fileset,
 
                                switch (ident) {
                                case TAG_IDENT_SBD:
-                                       {
-                                               struct spaceBitmapDesc *sp;
-                                               sp = (struct spaceBitmapDesc *)
-                                                   bh->b_data;
-                                               newfileset.logicalBlockNum +=
-                                                   1 +
-                                                   ((le32_to_cpu
-                                                     (sp->numOfBytes) +
-                                                     sizeof(struct
-                                                            spaceBitmapDesc) -
-                                                     1)
-                                                    >> sb->s_blocksize_bits);
-                                               brelse(bh);
-                                               break;
-                                       }
+                               {
+                                       struct spaceBitmapDesc *sp;
+                                       sp = (struct spaceBitmapDesc *)bh->b_data;
+                                       newfileset.logicalBlockNum += 1 +
+                                               ((le32_to_cpu(sp->numOfBytes) +
+                                                 sizeof(struct spaceBitmapDesc) - 1)
+                                                >> sb->s_blocksize_bits);
+                                       brelse(bh);
+                                       break;
+                               }
                                case TAG_IDENT_FSD:
-                                       {
-                                               *fileset = newfileset;
-                                               break;
-                                       }
+                                       *fileset = newfileset;
+                                       break;
                                default:
-                                       {
-                                               newfileset.logicalBlockNum++;
-                                               brelse(bh);
-                                               bh = NULL;
-                                               break;
-                                       }
+                                       newfileset.logicalBlockNum++;
+                                       brelse(bh);
+                                       bh = NULL;
+                                       break;
                                }
-                       }
-                       while (newfileset.logicalBlockNum < lastblock &&
-                              fileset->logicalBlockNum == 0xFFFFFFFF &&
-                              fileset->partitionReferenceNum == 0xFFFF);
+                       } while (newfileset.logicalBlockNum < lastblock &&
+                                fileset->logicalBlockNum == 0xFFFFFFFF &&
+                                fileset->partitionReferenceNum == 0xFFFF);
                }
        }
 
@@ -898,10 +840,10 @@ static void udf_load_pvoldesc(struct super_block *sb, struct buffer_head *bh)
                              lets_to_cpu(pvoldesc->recordingDateAndTime))) {
                kernel_timestamp ts;
                ts = lets_to_cpu(pvoldesc->recordingDateAndTime);
-               udf_debug
-                   ("recording time %ld/%ld, %04u/%02u/%02u %02u:%02u (%x)\n",
-                    recording, recording_usec, ts.year, ts.month, ts.day,
-                    ts.hour, ts.minute, ts.typeAndTimezone);
+               udf_debug("recording time %ld/%ld, %04u/%02u/%02u %02u:%02u (%x)\n",
+                         recording, recording_usec,
+                         ts.year, ts.month, ts.day, ts.hour,
+                         ts.minute, ts.typeAndTimezone);
                UDF_SB_RECORDTIME(sb).tv_sec = recording;
                UDF_SB_RECORDTIME(sb).tv_nsec = recording_usec * 1000;
        }
@@ -920,9 +862,8 @@ static void udf_load_pvoldesc(struct super_block *sb, struct buffer_head *bh)
        }
 }
 
-static void
-udf_load_fileset(struct super_block *sb, struct buffer_head *bh,
-                kernel_lb_addr * root)
+static void udf_load_fileset(struct super_block *sb, struct buffer_head *bh,
+                            kernel_lb_addr *root)
 {
        struct fileSetDesc *fset;
 
@@ -936,7 +877,7 @@ udf_load_fileset(struct super_block *sb, struct buffer_head *bh,
                  root->logicalBlockNum, root->partitionReferenceNum);
 }
 
-static void udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
+static int udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
 {
        struct partitionDesc *p;
        int i;
@@ -945,121 +886,80 @@ static void udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
 
        for (i = 0; i < UDF_SB_NUMPARTS(sb); i++) {
                udf_debug("Searching map: (%d == %d)\n",
-                         UDF_SB_PARTMAPS(sb)[i].s_partition_num,
-                         le16_to_cpu(p->partitionNumber));
-               if (UDF_SB_PARTMAPS(sb)[i].s_partition_num ==
-                   le16_to_cpu(p->partitionNumber)) {
-                       UDF_SB_PARTLEN(sb, i) = le32_to_cpu(p->partitionLength);        /* blocks */
-                       UDF_SB_PARTROOT(sb, i) =
-                           le32_to_cpu(p->partitionStartingLocation);
-                       if (le32_to_cpu(p->accessType) ==
-                           PD_ACCESS_TYPE_READ_ONLY)
-                               UDF_SB_PARTFLAGS(sb, i) |=
-                                   UDF_PART_FLAG_READ_ONLY;
-                       if (le32_to_cpu(p->accessType) ==
-                           PD_ACCESS_TYPE_WRITE_ONCE)
-                               UDF_SB_PARTFLAGS(sb, i) |=
-                                   UDF_PART_FLAG_WRITE_ONCE;
-                       if (le32_to_cpu(p->accessType) ==
-                           PD_ACCESS_TYPE_REWRITABLE)
-                               UDF_SB_PARTFLAGS(sb, i) |=
-                                   UDF_PART_FLAG_REWRITABLE;
-                       if (le32_to_cpu(p->accessType) ==
-                           PD_ACCESS_TYPE_OVERWRITABLE)
-                               UDF_SB_PARTFLAGS(sb, i) |=
-                                   UDF_PART_FLAG_OVERWRITABLE;
-
-                       if (!strcmp
-                           (p->partitionContents.ident,
-                            PD_PARTITION_CONTENTS_NSR02)
-                           || !strcmp(p->partitionContents.ident,
-                                      PD_PARTITION_CONTENTS_NSR03)) {
+                         UDF_SB_PARTMAPS(sb)[i].s_partition_num, le16_to_cpu(p->partitionNumber));
+               if (UDF_SB_PARTMAPS(sb)[i].s_partition_num == le16_to_cpu(p->partitionNumber)) {
+                       UDF_SB_PARTLEN(sb,i) = le32_to_cpu(p->partitionLength); /* blocks */
+                       UDF_SB_PARTROOT(sb,i) = le32_to_cpu(p->partitionStartingLocation);
+                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_READ_ONLY)
+                               UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_READ_ONLY;
+                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_WRITE_ONCE)
+                               UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_WRITE_ONCE;
+                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_REWRITABLE)
+                               UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_REWRITABLE;
+                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_OVERWRITABLE)
+                               UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_OVERWRITABLE;
+
+                       if (!strcmp(p->partitionContents.ident, PD_PARTITION_CONTENTS_NSR02) ||
+                           !strcmp(p->partitionContents.ident, PD_PARTITION_CONTENTS_NSR03)) {
                                struct partitionHeaderDesc *phd;
 
-                               phd =
-                                   (struct partitionHeaderDesc *)(p->
-                                                                  partitionContentsUse);
+                               phd = (struct partitionHeaderDesc *)(p->partitionContentsUse);
                                if (phd->unallocSpaceTable.extLength) {
-                                       kernel_lb_addr loc =
-                                           { le32_to_cpu(phd->
-                                                         unallocSpaceTable.
-                                                         extPosition), i };
-
-                                       UDF_SB_PARTMAPS(sb)[i].s_uspace.
-                                           s_table = udf_iget(sb, loc);
-                                       UDF_SB_PARTFLAGS(sb, i) |=
-                                           UDF_PART_FLAG_UNALLOC_TABLE;
-                                       udf_debug
-                                           ("unallocSpaceTable (part %d) @ %ld\n",
-                                            i,
-                                            UDF_SB_PARTMAPS(sb)[i].s_uspace.
-                                            s_table->i_ino);
+                                       kernel_lb_addr loc = {
+                                               .logicalBlockNum = le32_to_cpu(phd->unallocSpaceTable.extPosition),
+                                               .partitionReferenceNum = i,
+                                       };
+
+                                       UDF_SB_PARTMAPS(sb)[i].s_uspace.s_table =
+                                               udf_iget(sb, loc);
+                                       if (!UDF_SB_PARTMAPS(sb)[i].s_uspace.s_table) {
+                                               udf_debug("cannot load unallocSpaceTable (part %d)\n", i);
+                                               return 1;
+                                       }
+                                       UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_UNALLOC_TABLE;
+                                       udf_debug("unallocSpaceTable (part %d) @ %ld\n",
+                                                 i, UDF_SB_PARTMAPS(sb)[i].s_uspace.s_table->i_ino);
                                }
                                if (phd->unallocSpaceBitmap.extLength) {
                                        UDF_SB_ALLOC_BITMAP(sb, i, s_uspace);
-                                       if (UDF_SB_PARTMAPS(sb)[i].s_uspace.
-                                           s_bitmap != NULL) {
-                                               UDF_SB_PARTMAPS(sb)[i].s_uspace.
-                                                   s_bitmap->s_extLength =
-                                                   le32_to_cpu(phd->
-                                                               unallocSpaceBitmap.
-                                                               extLength);
-                                               UDF_SB_PARTMAPS(sb)[i].s_uspace.
-                                                   s_bitmap->s_extPosition =
-                                                   le32_to_cpu(phd->
-                                                               unallocSpaceBitmap.
-                                                               extPosition);
-                                               UDF_SB_PARTFLAGS(sb, i) |=
-                                                   UDF_PART_FLAG_UNALLOC_BITMAP;
-                                               udf_debug
-                                                   ("unallocSpaceBitmap (part %d) @ %d\n",
-                                                    i,
-                                                    UDF_SB_PARTMAPS(sb)[i].
-                                                    s_uspace.s_bitmap->
-                                                    s_extPosition);
+                                       if (UDF_SB_PARTMAPS(sb)[i].s_uspace.s_bitmap != NULL) {
+                                               UDF_SB_PARTMAPS(sb)[i].s_uspace.s_bitmap->s_extLength =
+                                                       le32_to_cpu(phd->unallocSpaceBitmap.extLength);
+                                               UDF_SB_PARTMAPS(sb)[i].s_uspace.s_bitmap->s_extPosition =
+                                                       le32_to_cpu(phd->unallocSpaceBitmap.extPosition);
+                                               UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_UNALLOC_BITMAP;
+                                               udf_debug("unallocSpaceBitmap (part %d) @ %d\n",
+                                                         i, UDF_SB_PARTMAPS(sb)[i].s_uspace.s_bitmap->s_extPosition);
                                        }
                                }
                                if (phd->partitionIntegrityTable.extLength)
-                                       udf_debug
-                                           ("partitionIntegrityTable (part %d)\n",
-                                            i);
+                                       udf_debug("partitionIntegrityTable (part %d)\n", i);
                                if (phd->freedSpaceTable.extLength) {
-                                       kernel_lb_addr loc =
-                                           { le32_to_cpu(phd->freedSpaceTable.
-                                                         extPosition), i };
-
-                                       UDF_SB_PARTMAPS(sb)[i].s_fspace.
-                                           s_table = udf_iget(sb, loc);
-                                       UDF_SB_PARTFLAGS(sb, i) |=
-                                           UDF_PART_FLAG_FREED_TABLE;
-                                       udf_debug
-                                           ("freedSpaceTable (part %d) @ %ld\n",
-                                            i,
-                                            UDF_SB_PARTMAPS(sb)[i].s_fspace.
-                                            s_table->i_ino);
+                                       kernel_lb_addr loc = {
+                                               .logicalBlockNum = le32_to_cpu(phd->freedSpaceTable.extPosition),
+                                               .partitionReferenceNum = i,
+                                       };
+
+                                       UDF_SB_PARTMAPS(sb)[i].s_fspace.s_table =
+                                               udf_iget(sb, loc);
+                                       if (!UDF_SB_PARTMAPS(sb)[i].s_fspace.s_table) {
+                                               udf_debug("cannot load freedSpaceTable (part %d)\n", i);
+                                               return 1;
+                                       }
+                                       UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_FREED_TABLE;
+                                       udf_debug("freedSpaceTable (part %d) @ %ld\n",
+                                                 i, UDF_SB_PARTMAPS(sb)[i].s_fspace.s_table->i_ino);
                                }
                                if (phd->freedSpaceBitmap.extLength) {
                                        UDF_SB_ALLOC_BITMAP(sb, i, s_fspace);
-                                       if (UDF_SB_PARTMAPS(sb)[i].s_fspace.
-                                           s_bitmap != NULL) {
-                                               UDF_SB_PARTMAPS(sb)[i].s_fspace.
-                                                   s_bitmap->s_extLength =
-                                                   le32_to_cpu(phd->
-                                                               freedSpaceBitmap.
-                                                               extLength);
-                                               UDF_SB_PARTMAPS(sb)[i].s_fspace.
-                                                   s_bitmap->s_extPosition =
-                                                   le32_to_cpu(phd->
-                                                               freedSpaceBitmap.
-                                                               extPosition);
-                                               UDF_SB_PARTFLAGS(sb, i) |=
-                                                   UDF_PART_FLAG_FREED_BITMAP;
-                                               udf_debug
-                                                   ("freedSpaceBitmap (part %d) @ %d\n",
-                                                    i,
-                                                    UDF_SB_PARTMAPS(sb)[i].
-                                                    s_fspace.s_bitmap->
-                                                    s_extPosition);
+                                       if (UDF_SB_PARTMAPS(sb)[i].s_fspace.s_bitmap != NULL) {
+                                               UDF_SB_PARTMAPS(sb)[i].s_fspace.s_bitmap->s_extLength =
+                                                       le32_to_cpu(phd->freedSpaceBitmap.extLength);
+                                               UDF_SB_PARTMAPS(sb)[i].s_fspace.s_bitmap->s_extPosition =
+                                                       le32_to_cpu(phd->freedSpaceBitmap.extPosition);
+                                               UDF_SB_PARTFLAGS(sb,i) |= UDF_PART_FLAG_FREED_BITMAP;
+                                               udf_debug("freedSpaceBitmap (part %d) @ %d\n",
+                                                         i, UDF_SB_PARTMAPS(sb)[i].s_fspace.s_bitmap->s_extPosition);
                                        }
                                }
                        }
@@ -1070,16 +970,15 @@ static void udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
                udf_debug("Partition (%d) not found in partition map\n",
                          le16_to_cpu(p->partitionNumber));
        } else {
-               udf_debug
-                   ("Partition (%d:%d type %x) starts at physical %d, block length %d\n",
-                    le16_to_cpu(p->partitionNumber), i, UDF_SB_PARTTYPE(sb, i),
-                    UDF_SB_PARTROOT(sb, i), UDF_SB_PARTLEN(sb, i));
+               udf_debug("Partition (%d:%d type %x) starts at physical %d, block length %d\n",
+                         le16_to_cpu(p->partitionNumber), i, UDF_SB_PARTTYPE(sb,i),
+                         UDF_SB_PARTROOT(sb,i), UDF_SB_PARTLEN(sb,i));
        }
+       return 0;
 }
 
-static int
-udf_load_logicalvol(struct super_block *sb, struct buffer_head *bh,
-                   kernel_lb_addr * fileset)
+static int udf_load_logicalvol(struct super_block *sb, struct buffer_head *bh,
+                              kernel_lb_addr *fileset)
 {
        struct logicalVolDesc *lvd;
        int i, j, offset;
@@ -1090,116 +989,69 @@ udf_load_logicalvol(struct super_block *sb, struct buffer_head *bh,
        UDF_SB_ALLOC_PARTMAPS(sb, le32_to_cpu(lvd->numPartitionMaps));
 
        for (i = 0, offset = 0;
-            i < UDF_SB_NUMPARTS(sb)
-            && offset < le32_to_cpu(lvd->mapTableLength);
-            i++, offset +=
-            ((struct genericPartitionMap *)&(lvd->partitionMaps[offset]))->
-            partitionMapLength) {
-               type =
-                   ((struct genericPartitionMap *)
-                    &(lvd->partitionMaps[offset]))->partitionMapType;
+            i < UDF_SB_NUMPARTS(sb) && offset < le32_to_cpu(lvd->mapTableLength);
+            i++, offset += ((struct genericPartitionMap *)&(lvd->partitionMaps[offset]))->partitionMapLength) {
+               type = ((struct genericPartitionMap *)&(lvd->partitionMaps[offset]))->partitionMapType;
                if (type == 1) {
-                       struct genericPartitionMap1 *gpm1 =
-                           (struct genericPartitionMap1 *)&(lvd->
-                                                            partitionMaps
-                                                            [offset]);
-                       UDF_SB_PARTTYPE(sb, i) = UDF_TYPE1_MAP15;
-                       UDF_SB_PARTVSN(sb, i) = le16_to_cpu(gpm1->volSeqNum);
-                       UDF_SB_PARTNUM(sb, i) = le16_to_cpu(gpm1->partitionNum);
-                       UDF_SB_PARTFUNC(sb, i) = NULL;
+                       struct genericPartitionMap1 *gpm1 = (struct genericPartitionMap1 *)&(lvd->partitionMaps[offset]);
+                       UDF_SB_PARTTYPE(sb,i) = UDF_TYPE1_MAP15;
+                       UDF_SB_PARTVSN(sb,i) = le16_to_cpu(gpm1->volSeqNum);
+                       UDF_SB_PARTNUM(sb,i) = le16_to_cpu(gpm1->partitionNum);
+                       UDF_SB_PARTFUNC(sb,i) = NULL;
                } else if (type == 2) {
-                       struct udfPartitionMap2 *upm2 =
-                           (struct udfPartitionMap2 *)&(lvd->
-                                                        partitionMaps[offset]);
-                       if (!strncmp
-                           (upm2->partIdent.ident, UDF_ID_VIRTUAL,
-                            strlen(UDF_ID_VIRTUAL))) {
-                               if (le16_to_cpu
-                                   (((__le16 *) upm2->partIdent.
-                                     identSuffix)[0]) == 0x0150) {
-                                       UDF_SB_PARTTYPE(sb, i) =
-                                           UDF_VIRTUAL_MAP15;
-                                       UDF_SB_PARTFUNC(sb, i) =
-                                           udf_get_pblock_virt15;
-                               } else
-                                   if (le16_to_cpu
-                                       (((__le16 *) upm2->partIdent.
-                                         identSuffix)[0]) == 0x0200) {
-                                       UDF_SB_PARTTYPE(sb, i) =
-                                           UDF_VIRTUAL_MAP20;
-                                       UDF_SB_PARTFUNC(sb, i) =
-                                           udf_get_pblock_virt20;
+                       struct udfPartitionMap2 *upm2 = (struct udfPartitionMap2 *)&(lvd->partitionMaps[offset]);
+                       if (!strncmp(upm2->partIdent.ident, UDF_ID_VIRTUAL, strlen(UDF_ID_VIRTUAL))) {
+                               if (le16_to_cpu(((__le16 *)upm2->partIdent.identSuffix)[0]) == 0x0150) {
+                                       UDF_SB_PARTTYPE(sb,i) = UDF_VIRTUAL_MAP15;
+                                       UDF_SB_PARTFUNC(sb,i) = udf_get_pblock_virt15;
+                               } else if (le16_to_cpu(((__le16 *)upm2->partIdent.identSuffix)[0]) == 0x0200) {
+                                       UDF_SB_PARTTYPE(sb,i) = UDF_VIRTUAL_MAP20;
+                                       UDF_SB_PARTFUNC(sb,i) = udf_get_pblock_virt20;
                                }
-                       } else
-                           if (!strncmp
-                               (upm2->partIdent.ident, UDF_ID_SPARABLE,
-                                strlen(UDF_ID_SPARABLE))) {
+                       } else if (!strncmp(upm2->partIdent.ident, UDF_ID_SPARABLE, strlen(UDF_ID_SPARABLE))) {
                                uint32_t loc;
                                uint16_t ident;
                                struct sparingTable *st;
-                               struct sparablePartitionMap *spm =
-                                   (struct sparablePartitionMap *)&(lvd->
-                                                                    partitionMaps
-                                                                    [offset]);
-
-                               UDF_SB_PARTTYPE(sb, i) = UDF_SPARABLE_MAP15;
-                               UDF_SB_TYPESPAR(sb, i).s_packet_len =
-                                   le16_to_cpu(spm->packetLength);
+                               struct sparablePartitionMap *spm = (struct sparablePartitionMap *)&(lvd->partitionMaps[offset]);
+
+                               UDF_SB_PARTTYPE(sb,i) = UDF_SPARABLE_MAP15;
+                               UDF_SB_TYPESPAR(sb,i).s_packet_len = le16_to_cpu(spm->packetLength);
                                for (j = 0; j < spm->numSparingTables; j++) {
-                                       loc =
-                                           le32_to_cpu(spm->
-                                                       locSparingTable[j]);
-                                       UDF_SB_TYPESPAR(sb, i).s_spar_map[j] =
-                                           udf_read_tagged(sb, loc, loc,
-                                                           &ident);
-                                       if (UDF_SB_TYPESPAR(sb, i).
-                                           s_spar_map[j] != NULL) {
-                                               st = (struct sparingTable *)
-                                                   UDF_SB_TYPESPAR(sb,
-                                                                   i).
-                                                   s_spar_map[j]->b_data;
-                                               if (ident != 0
-                                                   || strncmp(st->sparingIdent.
-                                                              ident,
-                                                              UDF_ID_SPARING,
-                                                              strlen
-                                                              (UDF_ID_SPARING)))
-                                               {
-                                                       brelse(UDF_SB_TYPESPAR
-                                                              (sb,
-                                                               i).
-                                                              s_spar_map[j]);
-                                                       UDF_SB_TYPESPAR(sb,
-                                                                       i).
-                                                           s_spar_map[j] =
-                                                           NULL;
+                                       loc = le32_to_cpu(spm->locSparingTable[j]);
+                                       UDF_SB_TYPESPAR(sb,i).s_spar_map[j] =
+                                               udf_read_tagged(sb, loc, loc, &ident);
+                                       if (UDF_SB_TYPESPAR(sb,i).s_spar_map[j] != NULL) {
+                                               st = (struct sparingTable *)UDF_SB_TYPESPAR(sb,i).s_spar_map[j]->b_data;
+                                               if (ident != 0 ||
+                                                   strncmp(st->sparingIdent.ident, UDF_ID_SPARING, strlen(UDF_ID_SPARING))) {
+                                                       brelse(UDF_SB_TYPESPAR(sb,i).s_spar_map[j]);
+                                                       UDF_SB_TYPESPAR(sb,i).s_spar_map[j] = NULL;
                                                }
                                        }
                                }
-                               UDF_SB_PARTFUNC(sb, i) = udf_get_pblock_spar15;
+                               UDF_SB_PARTFUNC(sb,i) = udf_get_pblock_spar15;
                        } else {
-                               udf_debug("Unknown ident: %s\n",
-                                         upm2->partIdent.ident);
+                               udf_debug("Unknown ident: %s\n", upm2->partIdent.ident);
                                continue;
                        }
-                       UDF_SB_PARTVSN(sb, i) = le16_to_cpu(upm2->volSeqNum);
-                       UDF_SB_PARTNUM(sb, i) = le16_to_cpu(upm2->partitionNum);
+                       UDF_SB_PARTVSN(sb,i) = le16_to_cpu(upm2->volSeqNum);
+                       UDF_SB_PARTNUM(sb,i) = le16_to_cpu(upm2->partitionNum);
                }
                udf_debug("Partition (%d:%d) type %d on volume %d\n",
-                         i, UDF_SB_PARTNUM(sb, i), type, UDF_SB_PARTVSN(sb,
-                                                                        i));
+                         i, UDF_SB_PARTNUM(sb,i), type, UDF_SB_PARTVSN(sb,i));
        }
 
        if (fileset) {
-               long_ad *la = (long_ad *) & (lvd->logicalVolContentsUse[0]);
+               long_ad *la = (long_ad *)&(lvd->logicalVolContentsUse[0]);
 
                *fileset = lelb_to_cpu(la->extLocation);
-               udf_debug
-                   ("FileSet found in LogicalVolDesc at block=%d, partition=%d\n",
-                    fileset->logicalBlockNum, fileset->partitionReferenceNum);
+               udf_debug("FileSet found in LogicalVolDesc at block=%d, partition=%d\n",
+                         fileset->logicalBlockNum,
+                         fileset->partitionReferenceNum);
        }
        if (lvd->integritySeqExt.extLength)
                udf_load_logicalvolint(sb, leea_to_cpu(lvd->integritySeqExt));
+
        return 0;
 }
 
@@ -1219,9 +1071,7 @@ static void udf_load_logicalvolint(struct super_block *sb, kernel_extent_ad loc)
                UDF_SB_LVIDBH(sb) = bh;
 
                if (UDF_SB_LVID(sb)->nextIntegrityExt.extLength)
-                       udf_load_logicalvolint(sb,
-                                              leea_to_cpu(UDF_SB_LVID(sb)->
-                                                          nextIntegrityExt));
+                       udf_load_logicalvolint(sb, leea_to_cpu(UDF_SB_LVID(sb)->nextIntegrityExt));
 
                if (UDF_SB_LVIDBH(sb) != bh)
                        brelse(bh);
@@ -1247,9 +1097,8 @@ static void udf_load_logicalvolint(struct super_block *sb, kernel_extent_ad loc)
  *     July 1, 1997 - Andrew E. Mileski
  *     Written, tested, and released.
  */
-static int
-udf_process_sequence(struct super_block *sb, long block, long lastblock,
-                    kernel_lb_addr * fileset)
+static int udf_process_sequence(struct super_block *sb, long block, long lastblock,
+                                kernel_lb_addr *fileset)
 {
        struct buffer_head *bh = NULL;
        struct udf_vds_record vds[VDS_POS_LENGTH];
@@ -1274,86 +1123,82 @@ udf_process_sequence(struct super_block *sb, long block, long lastblock,
                gd = (struct generic_desc *)bh->b_data;
                vdsn = le32_to_cpu(gd->volDescSeqNum);
                switch (ident) {
-               case TAG_IDENT_PVD:     /* ISO 13346 3/10.1 */
+               case TAG_IDENT_PVD: /* ISO 13346 3/10.1 */
                        if (vdsn >= vds[VDS_POS_PRIMARY_VOL_DESC].volDescSeqNum) {
-                               vds[VDS_POS_PRIMARY_VOL_DESC].volDescSeqNum =
-                                   vdsn;
+                               vds[VDS_POS_PRIMARY_VOL_DESC].volDescSeqNum = vdsn;
                                vds[VDS_POS_PRIMARY_VOL_DESC].block = block;
                        }
                        break;
-               case TAG_IDENT_VDP:     /* ISO 13346 3/10.3 */
+               case TAG_IDENT_VDP: /* ISO 13346 3/10.3 */
                        if (vdsn >= vds[VDS_POS_VOL_DESC_PTR].volDescSeqNum) {
                                vds[VDS_POS_VOL_DESC_PTR].volDescSeqNum = vdsn;
                                vds[VDS_POS_VOL_DESC_PTR].block = block;
 
                                vdp = (struct volDescPtr *)bh->b_data;
-                               next_s =
-                                   le32_to_cpu(vdp->nextVolDescSeqExt.
-                                               extLocation);
-                               next_e =
-                                   le32_to_cpu(vdp->nextVolDescSeqExt.
-                                               extLength);
+                               next_s = le32_to_cpu(vdp->nextVolDescSeqExt.extLocation);
+                               next_e = le32_to_cpu(vdp->nextVolDescSeqExt.extLength);
                                next_e = next_e >> sb->s_blocksize_bits;
                                next_e += next_s;
                        }
                        break;
-               case TAG_IDENT_IUVD:    /* ISO 13346 3/10.4 */
+               case TAG_IDENT_IUVD: /* ISO 13346 3/10.4 */
                        if (vdsn >= vds[VDS_POS_IMP_USE_VOL_DESC].volDescSeqNum) {
-                               vds[VDS_POS_IMP_USE_VOL_DESC].volDescSeqNum =
-                                   vdsn;
+                               vds[VDS_POS_IMP_USE_VOL_DESC].volDescSeqNum = vdsn;
                                vds[VDS_POS_IMP_USE_VOL_DESC].block = block;
                        }
                        break;
-               case TAG_IDENT_PD:      /* ISO 13346 3/10.5 */
+               case TAG_IDENT_PD: /* ISO 13346 3/10.5 */
                        if (!vds[VDS_POS_PARTITION_DESC].block)
                                vds[VDS_POS_PARTITION_DESC].block = block;
                        break;
-               case TAG_IDENT_LVD:     /* ISO 13346 3/10.6 */
+               case TAG_IDENT_LVD: /* ISO 13346 3/10.6 */
                        if (vdsn >= vds[VDS_POS_LOGICAL_VOL_DESC].volDescSeqNum) {
-                               vds[VDS_POS_LOGICAL_VOL_DESC].volDescSeqNum =
-                                   vdsn;
+                               vds[VDS_POS_LOGICAL_VOL_DESC].volDescSeqNum = vdsn;
                                vds[VDS_POS_LOGICAL_VOL_DESC].block = block;
                        }
                        break;
-               case TAG_IDENT_USD:     /* ISO 13346 3/10.8 */
-                       if (vdsn >=
-                           vds[VDS_POS_UNALLOC_SPACE_DESC].volDescSeqNum) {
-                               vds[VDS_POS_UNALLOC_SPACE_DESC].volDescSeqNum =
-                                   vdsn;
+               case TAG_IDENT_USD: /* ISO 13346 3/10.8 */
+                       if (vdsn >= vds[VDS_POS_UNALLOC_SPACE_DESC].volDescSeqNum) {
+                               vds[VDS_POS_UNALLOC_SPACE_DESC].volDescSeqNum = vdsn;
                                vds[VDS_POS_UNALLOC_SPACE_DESC].block = block;
                        }
                        break;
-               case TAG_IDENT_TD:      /* ISO 13346 3/10.9 */
+               case TAG_IDENT_TD: /* ISO 13346 3/10.9 */
                        vds[VDS_POS_TERMINATING_DESC].block = block;
                        if (next_e) {
                                block = next_s;
                                lastblock = next_e;
                                next_s = next_e = 0;
-                       } else
+                       } else {
                                done = 1;
+                       }
                        break;
                }
                brelse(bh);
        }
        for (i = 0; i < VDS_POS_LENGTH; i++) {
                if (vds[i].block) {
-                       bh = udf_read_tagged(sb, vds[i].block, vds[i].block,
-                                            &ident);
+                       bh = udf_read_tagged(sb, vds[i].block, vds[i].block, &ident);
 
-                       if (i == VDS_POS_PRIMARY_VOL_DESC)
+                       if (i == VDS_POS_PRIMARY_VOL_DESC) {
                                udf_load_pvoldesc(sb, bh);
-                       else if (i == VDS_POS_LOGICAL_VOL_DESC)
+                       } else if (i == VDS_POS_LOGICAL_VOL_DESC) {
                                udf_load_logicalvol(sb, bh, fileset);
-                       else if (i == VDS_POS_PARTITION_DESC) {
+                       else if (i == VDS_POS_PARTITION_DESC) {
                                struct buffer_head *bh2 = NULL;
-                               udf_load_partdesc(sb, bh);
-                               for (j = vds[i].block + 1;
-                                    j < vds[VDS_POS_TERMINATING_DESC].block;
-                                    j++) {
+                               if (udf_load_partdesc(sb, bh)) {
+                                       brelse(bh);
+                                       return 1;
+                               }
+                               for (j = vds[i].block + 1; j <  vds[VDS_POS_TERMINATING_DESC].block; j++) {
                                        bh2 = udf_read_tagged(sb, j, j, &ident);
                                        gd = (struct generic_desc *)bh2->b_data;
                                        if (ident == TAG_IDENT_PD)
-                                               udf_load_partdesc(sb, bh2);
+                                               if (udf_load_partdesc(sb, bh2)) {
+                                                       brelse(bh);
+                                                       brelse(bh2);
+                                                       return 1;
+                                               }
                                        brelse(bh2);
                                }
                        }
@@ -1378,16 +1223,17 @@ static int udf_check_valid(struct super_block *sb, int novrs, int silent)
        /* Check that it is NSR02 compliant */
        /* Process any "CD-ROM Volume Descriptor Set" (ECMA 167 2/8.3.1) */
        else if ((block = udf_vrs(sb, silent)) == -1) {
-               udf_debug
-                   ("Failed to read byte 32768. Assuming open disc. Skipping validity check\n");
+               udf_debug("Failed to read byte 32768. Assuming open disc. "
+                         "Skipping validity check\n");
                if (!UDF_SB_LASTBLOCK(sb))
                        UDF_SB_LASTBLOCK(sb) = udf_get_last_block(sb);
                return 0;
-       } else
+       } else {
                return !block;
+       }
 }
 
-static int udf_load_partition(struct super_block *sb, kernel_lb_addr * fileset)
+static int udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
 {
        struct anchorVolDescPtr *anchor;
        uint16_t ident;
@@ -1399,28 +1245,20 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr * fileset)
                return 1;
 
        for (i = 0; i < ARRAY_SIZE(UDF_SB_ANCHOR(sb)); i++) {
-               if (UDF_SB_ANCHOR(sb)[i] && (bh = udf_read_tagged(sb,
-                                                                 UDF_SB_ANCHOR
-                                                                 (sb)[i],
-                                                                 UDF_SB_ANCHOR
-                                                                 (sb)[i],
-                                                                 &ident))) {
+               if (UDF_SB_ANCHOR(sb)[i] &&
+                   (bh = udf_read_tagged(sb, UDF_SB_ANCHOR(sb)[i],
+                                         UDF_SB_ANCHOR(sb)[i], &ident))) {
                        anchor = (struct anchorVolDescPtr *)bh->b_data;
 
                        /* Locate the main sequence */
-                       main_s =
-                           le32_to_cpu(anchor->mainVolDescSeqExt.extLocation);
-                       main_e =
-                           le32_to_cpu(anchor->mainVolDescSeqExt.extLength);
+                       main_s = le32_to_cpu(anchor->mainVolDescSeqExt.extLocation);
+                       main_e = le32_to_cpu(anchor->mainVolDescSeqExt.extLength );
                        main_e = main_e >> sb->s_blocksize_bits;
                        main_e += main_s;
 
                        /* Locate the reserve sequence */
-                       reserve_s =
-                           le32_to_cpu(anchor->reserveVolDescSeqExt.
-                                       extLocation);
-                       reserve_e =
-                           le32_to_cpu(anchor->reserveVolDescSeqExt.extLength);
+                       reserve_s = le32_to_cpu(anchor->reserveVolDescSeqExt.extLocation);
+                       reserve_e = le32_to_cpu(anchor->reserveVolDescSeqExt.extLength);
                        reserve_e = reserve_e >> sb->s_blocksize_bits;
                        reserve_e += reserve_s;
 
@@ -1428,10 +1266,8 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr * fileset)
 
                        /* Process the main & reserve sequences */
                        /* responsible for finding the PartitionDesc(s) */
-                       if (!
-                           (udf_process_sequence(sb, main_s, main_e, fileset)
-                            && udf_process_sequence(sb, reserve_s, reserve_e,
-                                                    fileset))) {
+                       if (!(udf_process_sequence(sb, main_s, main_e, fileset) &&
+                             udf_process_sequence(sb, reserve_s, reserve_e, fileset))) {
                                break;
                        }
                }
@@ -1444,81 +1280,60 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr * fileset)
                udf_debug("Using anchor in block %d\n", UDF_SB_ANCHOR(sb)[i]);
 
        for (i = 0; i < UDF_SB_NUMPARTS(sb); i++) {
+               kernel_lb_addr uninitialized_var(ino);
                switch (UDF_SB_PARTTYPE(sb, i)) {
                case UDF_VIRTUAL_MAP15:
                case UDF_VIRTUAL_MAP20:
-                       {
-                               kernel_lb_addr uninitialized_var(ino);
+                       if (!UDF_SB_LASTBLOCK(sb)) {
+                               UDF_SB_LASTBLOCK(sb) = udf_get_last_block(sb);
+                               udf_find_anchor(sb);
+                       }
 
-                               if (!UDF_SB_LASTBLOCK(sb)) {
-                                       UDF_SB_LASTBLOCK(sb) =
-                                           udf_get_last_block(sb);
-                                       udf_find_anchor(sb);
-                               }
+                       if (!UDF_SB_LASTBLOCK(sb)) {
+                               udf_debug("Unable to determine Lastblock (For "
+                                         "Virtual Partition)\n");
+                               return 1;
+                       }
 
-                               if (!UDF_SB_LASTBLOCK(sb)) {
-                                       udf_debug
-                                           ("Unable to determine Lastblock (For Virtual Partition)\n");
-                                       return 1;
+                       for (j = 0; j < UDF_SB_NUMPARTS(sb); j++) {
+                               if (j != i &&
+                                   UDF_SB_PARTVSN(sb, i) == UDF_SB_PARTVSN(sb, j) &&
+                                   UDF_SB_PARTNUM(sb, i) == UDF_SB_PARTNUM(sb, j)) {
+                                       ino.partitionReferenceNum = j;
+                                       ino.logicalBlockNum = UDF_SB_LASTBLOCK(sb) - UDF_SB_PARTROOT(sb, j);
+                                       break;
                                }
+                       }
 
-                               for (j = 0; j < UDF_SB_NUMPARTS(sb); j++) {
-                                       if (j != i &&
-                                           UDF_SB_PARTVSN(sb,
-                                                          i) ==
-                                           UDF_SB_PARTVSN(sb, j)
-                                           && UDF_SB_PARTNUM(sb,
-                                                             i) ==
-                                           UDF_SB_PARTNUM(sb, j)) {
-                                               ino.partitionReferenceNum = j;
-                                               ino.logicalBlockNum =
-                                                   UDF_SB_LASTBLOCK(sb) -
-                                                   UDF_SB_PARTROOT(sb, j);
-                                               break;
-                                       }
-                               }
+                       if (j == UDF_SB_NUMPARTS(sb))
+                               return 1;
 
-                               if (j == UDF_SB_NUMPARTS(sb))
-                                       return 1;
+                       if (!(UDF_SB_VAT(sb) = udf_iget(sb, ino)))
+                               return 1;
 
-                               if (!(UDF_SB_VAT(sb) = udf_iget(sb, ino)))
-                                       return 1;
+                       if (UDF_SB_PARTTYPE(sb, i) == UDF_VIRTUAL_MAP15) {
+                               UDF_SB_TYPEVIRT(sb, i).s_start_offset =
+                                       udf_ext0_offset(UDF_SB_VAT(sb));
+                               UDF_SB_TYPEVIRT(sb, i).s_num_entries =
+                                       (UDF_SB_VAT(sb)->i_size - 36) >> 2;
+                       } else if (UDF_SB_PARTTYPE(sb, i) == UDF_VIRTUAL_MAP20) {
+                               struct buffer_head *bh = NULL;
+                               uint32_t pos;
 
-                               if (UDF_SB_PARTTYPE(sb, i) == UDF_VIRTUAL_MAP15) {
-                                       UDF_SB_TYPEVIRT(sb, i).s_start_offset =
-                                           udf_ext0_offset(UDF_SB_VAT(sb));
-                                       UDF_SB_TYPEVIRT(sb, i).s_num_entries =
-                                           (UDF_SB_VAT(sb)->i_size - 36) >> 2;
-                               } else if (UDF_SB_PARTTYPE(sb, i) ==
-                                          UDF_VIRTUAL_MAP20) {
-                                       struct buffer_head *bh = NULL;
-                                       uint32_t pos;
-
-                                       pos = udf_block_map(UDF_SB_VAT(sb), 0);
-                                       bh = sb_bread(sb, pos);
-                                       if (!bh)
-                                               return 1;
-                                       UDF_SB_TYPEVIRT(sb, i).s_start_offset =
-                                           le16_to_cpu(((struct
-                                                         virtualAllocationTable20
-                                                         *)bh->b_data +
-                                                        udf_ext0_offset
-                                                        (UDF_SB_VAT(sb)))->
-                                                       lengthHeader) +
-                                           udf_ext0_offset(UDF_SB_VAT(sb));
-                                       UDF_SB_TYPEVIRT(sb, i).s_num_entries =
-                                           (UDF_SB_VAT(sb)->i_size -
-                                            UDF_SB_TYPEVIRT(sb,
-                                                            i).
-                                            s_start_offset) >> 2;
-                                       brelse(bh);
-                               }
-                               UDF_SB_PARTROOT(sb, i) =
-                                   udf_get_pblock(sb, 0, i, 0);
-                               UDF_SB_PARTLEN(sb, i) =
-                                   UDF_SB_PARTLEN(sb,
-                                                  ino.partitionReferenceNum);
+                               pos = udf_block_map(UDF_SB_VAT(sb), 0);
+                               bh = sb_bread(sb, pos);
+                               if (!bh)
+                                       return 1;
+                               UDF_SB_TYPEVIRT(sb, i).s_start_offset =
+                                       le16_to_cpu(((struct virtualAllocationTable20 *)bh->b_data +
+                                                    udf_ext0_offset(UDF_SB_VAT(sb)))->lengthHeader) +
+                                       udf_ext0_offset(UDF_SB_VAT(sb));
+                               UDF_SB_TYPEVIRT(sb, i).s_num_entries = (UDF_SB_VAT(sb)->i_size -
+                                                                       UDF_SB_TYPEVIRT(sb, i).s_start_offset) >> 2;
+                               brelse(bh);
                        }
+                       UDF_SB_PARTROOT(sb, i) = udf_get_pblock(sb, 0, i, 0);
+                       UDF_SB_PARTLEN(sb, i) = UDF_SB_PARTLEN(sb, ino.partitionReferenceNum);
                }
        }
        return 0;
@@ -1533,21 +1348,17 @@ static void udf_open_lvid(struct super_block *sb)
                UDF_SB_LVIDIU(sb)->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
                UDF_SB_LVIDIU(sb)->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
                if (udf_time_to_stamp(&cpu_time, CURRENT_TIME))
-                       UDF_SB_LVID(sb)->recordingDateAndTime =
-                           cpu_to_lets(cpu_time);
+                       UDF_SB_LVID(sb)->recordingDateAndTime = cpu_to_lets(cpu_time);
                UDF_SB_LVID(sb)->integrityType = LVID_INTEGRITY_TYPE_OPEN;
 
-               UDF_SB_LVID(sb)->descTag.descCRC =
-                   cpu_to_le16(udf_crc((char *)UDF_SB_LVID(sb) + sizeof(tag),
-                                       le16_to_cpu(UDF_SB_LVID(sb)->descTag.
-                                                   descCRCLength), 0));
+               UDF_SB_LVID(sb)->descTag.descCRC = cpu_to_le16(udf_crc((char *)UDF_SB_LVID(sb) + sizeof(tag),
+                                                                      le16_to_cpu(UDF_SB_LVID(sb)->descTag.descCRCLength), 0));
 
                UDF_SB_LVID(sb)->descTag.tagChecksum = 0;
                for (i = 0; i < 16; i++)
                        if (i != 4)
                                UDF_SB_LVID(sb)->descTag.tagChecksum +=
-                                   ((uint8_t *) &
-                                    (UDF_SB_LVID(sb)->descTag))[i];
+                                       ((uint8_t *) &(UDF_SB_LVID(sb)->descTag))[i];
 
                mark_buffer_dirty(UDF_SB_LVIDBH(sb));
        }
@@ -1555,42 +1366,32 @@ static void udf_open_lvid(struct super_block *sb)
 
 static void udf_close_lvid(struct super_block *sb)
 {
+       kernel_timestamp cpu_time;
+       int i;
+
        if (UDF_SB_LVIDBH(sb) &&
            UDF_SB_LVID(sb)->integrityType == LVID_INTEGRITY_TYPE_OPEN) {
-               int i;
-               kernel_timestamp cpu_time;
-
                UDF_SB_LVIDIU(sb)->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
                UDF_SB_LVIDIU(sb)->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
                if (udf_time_to_stamp(&cpu_time, CURRENT_TIME))
-                       UDF_SB_LVID(sb)->recordingDateAndTime =
-                           cpu_to_lets(cpu_time);
-               if (UDF_MAX_WRITE_VERSION >
-                   le16_to_cpu(UDF_SB_LVIDIU(sb)->maxUDFWriteRev))
-                       UDF_SB_LVIDIU(sb)->maxUDFWriteRev =
-                           cpu_to_le16(UDF_MAX_WRITE_VERSION);
-               if (UDF_SB_UDFREV(sb) >
-                   le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFReadRev))
-                       UDF_SB_LVIDIU(sb)->minUDFReadRev =
-                           cpu_to_le16(UDF_SB_UDFREV(sb));
-               if (UDF_SB_UDFREV(sb) >
-                   le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFWriteRev))
-                       UDF_SB_LVIDIU(sb)->minUDFWriteRev =
-                           cpu_to_le16(UDF_SB_UDFREV(sb));
-               UDF_SB_LVID(sb)->integrityType =
-                   cpu_to_le32(LVID_INTEGRITY_TYPE_CLOSE);
+                       UDF_SB_LVID(sb)->recordingDateAndTime = cpu_to_lets(cpu_time);
+               if (UDF_MAX_WRITE_VERSION > le16_to_cpu(UDF_SB_LVIDIU(sb)->maxUDFWriteRev))
+                       UDF_SB_LVIDIU(sb)->maxUDFWriteRev = cpu_to_le16(UDF_MAX_WRITE_VERSION);
+               if (UDF_SB_UDFREV(sb) > le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFReadRev))
+                       UDF_SB_LVIDIU(sb)->minUDFReadRev = cpu_to_le16(UDF_SB_UDFREV(sb));
+               if (UDF_SB_UDFREV(sb) > le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFWriteRev))
+                       UDF_SB_LVIDIU(sb)->minUDFWriteRev = cpu_to_le16(UDF_SB_UDFREV(sb));
+               UDF_SB_LVID(sb)->integrityType = cpu_to_le32(LVID_INTEGRITY_TYPE_CLOSE);
 
                UDF_SB_LVID(sb)->descTag.descCRC =
-                   cpu_to_le16(udf_crc((char *)UDF_SB_LVID(sb) + sizeof(tag),
-                                       le16_to_cpu(UDF_SB_LVID(sb)->descTag.
-                                                   descCRCLength), 0));
+                       cpu_to_le16(udf_crc((char *)UDF_SB_LVID(sb) + sizeof(tag),
+                                           le16_to_cpu(UDF_SB_LVID(sb)->descTag.descCRCLength), 0));
 
                UDF_SB_LVID(sb)->descTag.tagChecksum = 0;
                for (i = 0; i < 16; i++)
                        if (i != 4)
                                UDF_SB_LVID(sb)->descTag.tagChecksum +=
-                                   ((uint8_t *) &
-                                    (UDF_SB_LVID(sb)->descTag))[i];
+                                       ((uint8_t *)&(UDF_SB_LVID(sb)->descTag))[i];
 
                mark_buffer_dirty(UDF_SB_LVIDBH(sb));
        }
@@ -1628,6 +1429,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        sbi = kmalloc(sizeof(struct udf_sb_info), GFP_KERNEL);
        if (!sbi)
                return -ENOMEM;
+
        sb->s_fs_info = sbi;
        memset(UDF_SB(sb), 0x00, sizeof(struct udf_sb_info));
 
@@ -1679,7 +1481,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        UDF_SB_ANCHOR(sb)[2] = uopt.anchor;
        UDF_SB_ANCHOR(sb)[3] = 256;
 
-       if (udf_check_valid(sb, uopt.novrs, silent)) {  /* read volume recognition sequences */
+       if (udf_check_valid(sb, uopt.novrs, silent)) { /* read volume recognition sequences */
                printk("UDF-fs: No VRS found\n");
                goto error_out;
        }
@@ -1701,10 +1503,8 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        udf_debug("Lastblock=%d\n", UDF_SB_LASTBLOCK(sb));
 
        if (UDF_SB_LVIDBH(sb)) {
-               uint16_t minUDFReadRev =
-                   le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFReadRev);
-               uint16_t minUDFWriteRev =
-                   le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFWriteRev);
+               uint16_t minUDFReadRev = le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFReadRev);
+               uint16_t minUDFWriteRev = le16_to_cpu(UDF_SB_LVIDIU(sb)->minUDFWriteRev);
                /* uint16_t maxUDFWriteRev = le16_to_cpu(UDF_SB_LVIDIU(sb)->maxUDFWriteRev); */
 
                if (minUDFReadRev > UDF_MAX_READ_VERSION) {
@@ -1729,10 +1529,8 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
                goto error_out;
        }
 
-       if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-           UDF_PART_FLAG_READ_ONLY) {
-               printk
-                   ("UDF-fs: Partition marked readonly; forcing readonly mount\n");
+       if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_READ_ONLY) {
+               printk("UDF-fs: Partition marked readonly; forcing readonly mount\n");
                sb->s_flags |= MS_RDONLY;
        }
 
@@ -1744,10 +1542,11 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        if (!silent) {
                kernel_timestamp ts;
                udf_time_to_stamp(&ts, UDF_SB_RECORDTIME(sb));
-               udf_info
-                   ("UDF %s (%s) Mounting volume '%s', timestamp %04u/%02u/%02u %02u:%02u (%x)\n",
-                    UDFFS_VERSION, UDFFS_DATE, UDF_SB_VOLIDENT(sb), ts.year,
-                    ts.month, ts.day, ts.hour, ts.minute, ts.typeAndTimezone);
+               udf_info("UDF %s (%s) Mounting volume '%s', "
+                        "timestamp %04u/%02u/%02u %02u:%02u (%x)\n",
+                        UDFFS_VERSION, UDFFS_DATE,
+                        UDF_SB_VOLIDENT(sb), ts.year, ts.month, ts.day, ts.hour, ts.minute,
+                        ts.typeAndTimezone);
        }
        if (!(sb->s_flags & MS_RDONLY))
                udf_open_lvid(sb);
@@ -1772,30 +1571,21 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        sb->s_maxbytes = MAX_LFS_FILESIZE;
        return 0;
 
-      error_out:
+error_out:
        if (UDF_SB_VAT(sb))
                iput(UDF_SB_VAT(sb));
        if (UDF_SB_NUMPARTS(sb)) {
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_UNALLOC_TABLE)
-                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_uspace.
-                            s_table);
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_FREED_TABLE)
-                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_fspace.
-                            s_table);
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_UNALLOC_BITMAP)
-                       UDF_SB_FREE_BITMAP(sb, UDF_SB_PARTITION(sb), s_uspace);
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_FREED_BITMAP)
-                       UDF_SB_FREE_BITMAP(sb, UDF_SB_PARTITION(sb), s_fspace);
-               if (UDF_SB_PARTTYPE(sb, UDF_SB_PARTITION(sb)) ==
-                   UDF_SPARABLE_MAP15) {
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_UNALLOC_TABLE)
+                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_uspace.s_table);
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_FREED_TABLE)
+                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_fspace.s_table);
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_UNALLOC_BITMAP)
+                       UDF_SB_FREE_BITMAP(sb,UDF_SB_PARTITION(sb), s_uspace);
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_FREED_BITMAP)
+                       UDF_SB_FREE_BITMAP(sb,UDF_SB_PARTITION(sb), s_fspace);
+               if (UDF_SB_PARTTYPE(sb, UDF_SB_PARTITION(sb)) == UDF_SPARABLE_MAP15) {
                        for (i = 0; i < 4; i++)
-                               brelse(UDF_SB_TYPESPAR
-                                      (sb,
-                                       UDF_SB_PARTITION(sb)).s_spar_map[i]);
+                               brelse(UDF_SB_TYPESPAR(sb, UDF_SB_PARTITION(sb)).s_spar_map[i]);
                }
        }
 #ifdef CONFIG_UDF_NLS
@@ -1808,6 +1598,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        UDF_SB_FREE(sb);
        kfree(sbi);
        sb->s_fs_info = NULL;
+
        return -EINVAL;
 }
 
@@ -1823,8 +1614,8 @@ void udf_error(struct super_block *sb, const char *function,
        va_start(args, fmt);
        vsnprintf(error_buf, sizeof(error_buf), fmt, args);
        va_end(args);
-       printk(KERN_CRIT "UDF-fs error (device %s): %s: %s\n",
-              sb->s_id, function, error_buf);
+       printk (KERN_CRIT "UDF-fs error (device %s): %s: %s\n",
+               sb->s_id, function, error_buf);
 }
 
 void udf_warning(struct super_block *sb, const char *function,
@@ -1859,26 +1650,17 @@ static void udf_put_super(struct super_block *sb)
        if (UDF_SB_VAT(sb))
                iput(UDF_SB_VAT(sb));
        if (UDF_SB_NUMPARTS(sb)) {
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_UNALLOC_TABLE)
-                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_uspace.
-                            s_table);
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_FREED_TABLE)
-                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_fspace.
-                            s_table);
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_UNALLOC_BITMAP)
-                       UDF_SB_FREE_BITMAP(sb, UDF_SB_PARTITION(sb), s_uspace);
-               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-                   UDF_PART_FLAG_FREED_BITMAP)
-                       UDF_SB_FREE_BITMAP(sb, UDF_SB_PARTITION(sb), s_fspace);
-               if (UDF_SB_PARTTYPE(sb, UDF_SB_PARTITION(sb)) ==
-                   UDF_SPARABLE_MAP15) {
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_UNALLOC_TABLE)
+                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_uspace.s_table);
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_FREED_TABLE)
+                       iput(UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_fspace.s_table);
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_UNALLOC_BITMAP)
+                       UDF_SB_FREE_BITMAP(sb,UDF_SB_PARTITION(sb), s_uspace);
+               if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_FREED_BITMAP)
+                       UDF_SB_FREE_BITMAP(sb,UDF_SB_PARTITION(sb), s_fspace);
+               if (UDF_SB_PARTTYPE(sb, UDF_SB_PARTITION(sb)) == UDF_SPARABLE_MAP15) {
                        for (i = 0; i < 4; i++)
-                               brelse(UDF_SB_TYPESPAR
-                                      (sb,
-                                       UDF_SB_PARTITION(sb)).s_spar_map[i]);
+                               brelse(UDF_SB_TYPESPAR(sb, UDF_SB_PARTITION(sb)).s_spar_map[i]);
                }
        }
 #ifdef CONFIG_UDF_NLS
@@ -1917,8 +1699,7 @@ static int udf_statfs(struct dentry *dentry, struct kstatfs *buf)
        buf->f_bavail = buf->f_bfree;
        buf->f_files = (UDF_SB_LVIDBH(sb) ?
                        (le32_to_cpu(UDF_SB_LVIDIU(sb)->numFiles) +
-                        le32_to_cpu(UDF_SB_LVIDIU(sb)->numDirs)) : 0) +
-           buf->f_bfree;
+                        le32_to_cpu(UDF_SB_LVIDIU(sb)->numDirs)) : 0) + buf->f_bfree;
        buf->f_ffree = buf->f_bfree;
        /* __kernel_fsid_t f_fsid */
        buf->f_namelen = UDF_NAME_LEN - 2;
@@ -1930,8 +1711,7 @@ static unsigned char udf_bitmap_lookup[16] = {
        0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4
 };
 
-static unsigned int
-udf_count_free_bitmap(struct super_block *sb, struct udf_bitmap *bitmap)
+static unsigned int udf_count_free_bitmap(struct super_block *sb, struct udf_bitmap *bitmap)
 {
        struct buffer_head *bh = NULL;
        unsigned int accum = 0;
@@ -1961,8 +1741,8 @@ udf_count_free_bitmap(struct super_block *sb, struct udf_bitmap *bitmap)
 
        bm = (struct spaceBitmapDesc *)bh->b_data;
        bytes = le32_to_cpu(bm->numOfBytes);
-       index = sizeof(struct spaceBitmapDesc); /* offset in first block only */
-       ptr = (uint8_t *) bh->b_data;
+       index = sizeof(struct spaceBitmapDesc); /* offset in first block only */
+       ptr = (uint8_t *)bh->b_data;
 
        while (bytes > 0) {
                while ((bytes > 0) && (index < sb->s_blocksize)) {
@@ -1981,19 +1761,18 @@ udf_count_free_bitmap(struct super_block *sb, struct udf_bitmap *bitmap)
                                goto out;
                        }
                        index = 0;
-                       ptr = (uint8_t *) bh->b_data;
+                       ptr = (uint8_t *)bh->b_data;
                }
        }
        brelse(bh);
 
-      out:
+out:
        unlock_kernel();
 
        return accum;
 }
 
-static unsigned int
-udf_count_free_table(struct super_block *sb, struct inode *table)
+static unsigned int udf_count_free_table(struct super_block *sb, struct inode *table)
 {
        unsigned int accum = 0;
        uint32_t elen;
@@ -2007,8 +1786,9 @@ udf_count_free_table(struct super_block *sb, struct inode *table)
        epos.offset = sizeof(struct unallocSpaceEntry);
        epos.bh = NULL;
 
-       while ((etype = udf_next_aext(table, &epos, &eloc, &elen, 1)) != -1)
+       while ((etype = udf_next_aext(table, &epos, &eloc, &elen, 1)) != -1) {
                accum += (elen >> table->i_sb->s_blocksize_bits);
+       }
        brelse(epos.bh);
 
        unlock_kernel();
@@ -2021,12 +1801,8 @@ static unsigned int udf_count_free(struct super_block *sb)
        unsigned int accum = 0;
 
        if (UDF_SB_LVIDBH(sb)) {
-               if (le32_to_cpu(UDF_SB_LVID(sb)->numOfPartitions) >
-                   UDF_SB_PARTITION(sb)) {
-                       accum =
-                           le32_to_cpu(UDF_SB_LVID(sb)->
-                                       freeSpaceTable[UDF_SB_PARTITION(sb)]);
-
+               if (le32_to_cpu(UDF_SB_LVID(sb)->numOfPartitions) > UDF_SB_PARTITION(sb)) {
+                       accum = le32_to_cpu(UDF_SB_LVID(sb)->freeSpaceTable[UDF_SB_PARTITION(sb)]);
                        if (accum == 0xFFFFFFFF)
                                accum = 0;
                }
@@ -2035,40 +1811,24 @@ static unsigned int udf_count_free(struct super_block *sb)
        if (accum)
                return accum;
 
-       if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-           UDF_PART_FLAG_UNALLOC_BITMAP) {
-               accum +=
-                   udf_count_free_bitmap(sb,
-                                         UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION
-                                                             (sb)].s_uspace.
-                                         s_bitmap);
+       if (UDF_SB_PARTFLAGS(sb,UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_UNALLOC_BITMAP) {
+               accum += udf_count_free_bitmap(sb,
+                                              UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_uspace.s_bitmap);
        }
-       if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-           UDF_PART_FLAG_FREED_BITMAP) {
-               accum +=
-                   udf_count_free_bitmap(sb,
-                                         UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION
-                                                             (sb)].s_fspace.
-                                         s_bitmap);
+       if (UDF_SB_PARTFLAGS(sb,UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_FREED_BITMAP) {
+               accum += udf_count_free_bitmap(sb,
+                                              UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_fspace.s_bitmap);
        }
        if (accum)
                return accum;
 
-       if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-           UDF_PART_FLAG_UNALLOC_TABLE) {
-               accum +=
-                   udf_count_free_table(sb,
-                                        UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION
-                                                            (sb)].s_uspace.
-                                        s_table);
+       if (UDF_SB_PARTFLAGS(sb,UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_UNALLOC_TABLE) {
+               accum += udf_count_free_table(sb,
+                                             UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_uspace.s_table);
        }
-       if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) &
-           UDF_PART_FLAG_FREED_TABLE) {
-               accum +=
-                   udf_count_free_table(sb,
-                                        UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION
-                                                            (sb)].s_fspace.
-                                        s_table);
+       if (UDF_SB_PARTFLAGS(sb,UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_FREED_TABLE) {
+               accum += udf_count_free_table(sb,
+                                             UDF_SB_PARTMAPS(sb)[UDF_SB_PARTITION(sb)].s_fspace.s_table);
        }
 
        return accum;