]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - fs/udf/super.c
udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps
[linux-2.6-omap-h63xx.git] / fs / udf / super.c
index 3cd5a855033b3eba3fef3c27ec686b4f5157fa1e..4d2ecee1970b5313ad5c56cbd293bf58d9a7286b 100644 (file)
 #include <linux/vfs.h>
 #include <linux/vmalloc.h>
 #include <linux/errno.h>
+#include <linux/mount.h>
+#include <linux/seq_file.h>
+#include <linux/bitmap.h>
 #include <asm/byteorder.h>
 
-#include <linux/udf_fs.h>
 #include "udf_sb.h"
 #include "udf_i.h"
 
@@ -71,6 +73,8 @@
 #define VDS_POS_TERMINATING_DESC       6
 #define VDS_POS_LENGTH                 7
 
+#define UDF_DEFAULT_BLOCKSIZE 2048
+
 static char error_buf[1024];
 
 /* These are the "meat" - everything else is stuffing */
@@ -95,12 +99,17 @@ static void udf_open_lvid(struct super_block *);
 static void udf_close_lvid(struct super_block *);
 static unsigned int udf_count_free(struct super_block *);
 static int udf_statfs(struct dentry *, struct kstatfs *);
+static int udf_show_options(struct seq_file *, struct vfsmount *);
+static void udf_error(struct super_block *sb, const char *function,
+                     const char *fmt, ...);
 
 struct logicalVolIntegrityDescImpUse *udf_sb_lvidiu(struct udf_sb_info *sbi)
 {
-       struct logicalVolIntegrityDesc *lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
+       struct logicalVolIntegrityDesc *lvid =
+               (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
        __u32 number_of_partitions = le32_to_cpu(lvid->numOfPartitions);
-       __u32 offset = number_of_partitions * 2 * sizeof(uint32_t)/sizeof(uint8_t);
+       __u32 offset = number_of_partitions * 2 *
+                               sizeof(uint32_t)/sizeof(uint8_t);
        return (struct logicalVolIntegrityDescImpUse *)&(lvid->impUse[offset]);
 }
 
@@ -179,6 +188,7 @@ static const struct super_operations udf_sb_ops = {
        .write_super    = udf_write_super,
        .statfs         = udf_statfs,
        .remount_fs     = udf_remount_fs,
+       .show_options   = udf_show_options,
 };
 
 struct udf_options {
@@ -245,6 +255,61 @@ static int udf_sb_alloc_partition_maps(struct super_block *sb, u32 count)
        return 0;
 }
 
+static int udf_show_options(struct seq_file *seq, struct vfsmount *mnt)
+{
+       struct super_block *sb = mnt->mnt_sb;
+       struct udf_sb_info *sbi = UDF_SB(sb);
+
+       if (!UDF_QUERY_FLAG(sb, UDF_FLAG_STRICT))
+               seq_puts(seq, ",nostrict");
+       if (sb->s_blocksize != UDF_DEFAULT_BLOCKSIZE)
+               seq_printf(seq, ",bs=%lu", sb->s_blocksize);
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_UNHIDE))
+               seq_puts(seq, ",unhide");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_UNDELETE))
+               seq_puts(seq, ",undelete");
+       if (!UDF_QUERY_FLAG(sb, UDF_FLAG_USE_AD_IN_ICB))
+               seq_puts(seq, ",noadinicb");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_USE_SHORT_AD))
+               seq_puts(seq, ",shortad");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_UID_FORGET))
+               seq_puts(seq, ",uid=forget");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_UID_IGNORE))
+               seq_puts(seq, ",uid=ignore");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_GID_FORGET))
+               seq_puts(seq, ",gid=forget");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_GID_IGNORE))
+               seq_puts(seq, ",gid=ignore");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_UID_SET))
+               seq_printf(seq, ",uid=%u", sbi->s_uid);
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_GID_SET))
+               seq_printf(seq, ",gid=%u", sbi->s_gid);
+       if (sbi->s_umask != 0)
+               seq_printf(seq, ",umask=%o", sbi->s_umask);
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_SESSION_SET))
+               seq_printf(seq, ",session=%u", sbi->s_session);
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_LASTBLOCK_SET))
+               seq_printf(seq, ",lastblock=%u", sbi->s_last_block);
+       /*
+        * s_anchor[2] could be zeroed out in case there is no anchor
+        * in the specified block, but then the "anchor=N" option
+        * originally given by the user wasn't effective, so it's OK
+        * if we don't show it.
+        */
+       if (sbi->s_anchor[2] != 0)
+               seq_printf(seq, ",anchor=%u", sbi->s_anchor[2]);
+       /*
+        * volume, partition, fileset and rootdir seem to be ignored
+        * currently
+        */
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_UTF8))
+               seq_puts(seq, ",utf8");
+       if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP) && sbi->s_nls_map)
+               seq_printf(seq, ",iocharset=%s", sbi->s_nls_map->charset);
+
+       return 0;
+}
+
 /*
  * udf_parse_options
  *
@@ -337,13 +402,14 @@ static match_table_t tokens = {
        {Opt_err,       NULL}
 };
 
-static int udf_parse_options(char *options, struct udf_options *uopt)
+static int udf_parse_options(char *options, struct udf_options *uopt,
+                            bool remount)
 {
        char *p;
        int option;
 
        uopt->novrs = 0;
-       uopt->blocksize = 2048;
+       uopt->blocksize = UDF_DEFAULT_BLOCKSIZE;
        uopt->partition = 0xFFFF;
        uopt->session = 0xFFFFFFFF;
        uopt->lastblock = 0;
@@ -413,11 +479,15 @@ static int udf_parse_options(char *options, struct udf_options *uopt)
                        if (match_int(args, &option))
                                return 0;
                        uopt->session = option;
+                       if (!remount)
+                               uopt->flags |= (1 << UDF_FLAG_SESSION_SET);
                        break;
                case Opt_lastblock:
                        if (match_int(args, &option))
                                return 0;
                        uopt->lastblock = option;
+                       if (!remount)
+                               uopt->flags |= (1 << UDF_FLAG_LASTBLOCK_SET);
                        break;
                case Opt_anchor:
                        if (match_int(args, &option))
@@ -495,7 +565,7 @@ static int udf_remount_fs(struct super_block *sb, int *flags, char *options)
        uopt.gid   = sbi->s_gid;
        uopt.umask = sbi->s_umask;
 
-       if (!udf_parse_options(options, &uopt))
+       if (!udf_parse_options(options, &uopt, true))
                return -EINVAL;
 
        sbi->s_flags = uopt.flags;
@@ -519,44 +589,6 @@ static int udf_remount_fs(struct super_block *sb, int *flags, char *options)
        return 0;
 }
 
-/*
- * udf_set_blocksize
- *
- * PURPOSE
- *     Set the block size to be used in all transfers.
- *
- * DESCRIPTION
- *     To allow room for a DMA transfer, it is best to guess big when unsure.
- *     This routine picks 2048 bytes as the blocksize when guessing. This
- *     should be adequate until devices with larger block sizes become common.
- *
- *     Note that the Linux kernel can currently only deal with blocksizes of
- *     512, 1024, 2048, 4096, and 8192 bytes.
- *
- * PRE-CONDITIONS
- *     sb                      Pointer to _locked_ superblock.
- *
- * POST-CONDITIONS
- *     sb->s_blocksize         Blocksize.
- *     sb->s_blocksize_bits    log2 of blocksize.
- *     <return>        0       Blocksize is valid.
- *     <return>        1       Blocksize is invalid.
- *
- * HISTORY
- *     July 1, 1997 - Andrew E. Mileski
- *     Written, tested, and released.
- */
-static int udf_set_blocksize(struct super_block *sb, int bsize)
-{
-       if (!sb_min_blocksize(sb, bsize)) {
-               udf_debug("Bad block size (%d)\n", bsize);
-               printk(KERN_ERR "udf: bad block size (%d)\n", bsize);
-               return 0;
-       }
-
-       return sb->s_blocksize;
-}
-
 static int udf_vrs(struct super_block *sb, int silent)
 {
        struct volStructDesc *vsd = NULL;
@@ -713,16 +745,23 @@ static void udf_find_anchor(struct super_block *sb)
                                        lastblock = last[i] - sbi->s_session;
                                        sbi->s_anchor[0] = lastblock;
                                        sbi->s_anchor[1] = lastblock - 256;
-                               } else if (location == udf_variable_to_fixed(last[i]) - sbi->s_session) {
+                               } else if (location ==
+                                               udf_variable_to_fixed(last[i]) -
+                                                       sbi->s_session) {
                                        UDF_SET_FLAG(sb, UDF_FLAG_VARCONV);
-                                       lastblock = udf_variable_to_fixed(last[i]) - sbi->s_session;
+                                       lastblock =
+                                               udf_variable_to_fixed(last[i]) -
+                                                       sbi->s_session;
                                        sbi->s_anchor[0] = lastblock;
-                                       sbi->s_anchor[1] = lastblock - 256 - sbi->s_session;
+                                       sbi->s_anchor[1] = lastblock - 256 -
+                                                               sbi->s_session;
                                } else {
-                                       udf_debug("Anchor found at block %d, location mismatch %d.\n",
+                                       udf_debug("Anchor found at block %d, "
+                                                 "location mismatch %d.\n",
                                                  last[i], location);
                                }
-                       } else if (ident == TAG_IDENT_FE || ident == TAG_IDENT_EFE) {
+                       } else if (ident == TAG_IDENT_FE ||
+                                       ident == TAG_IDENT_EFE) {
                                lastblock = last[i];
                                sbi->s_anchor[3] = 512;
                        } else {
@@ -731,31 +770,40 @@ static void udf_find_anchor(struct super_block *sb)
                                        bh = sb_bread(sb, last[i] - 256);
                                        if (bh) {
                                                tag *t = (tag *)bh->b_data;
-                                               ident = le16_to_cpu(t->tagIdent);
-                                               location = le32_to_cpu(t->tagLocation);
+                                               ident = le16_to_cpu(
+                                                               t->tagIdent);
+                                               location = le32_to_cpu(
+                                                               t->tagLocation);
                                                brelse(bh);
                                        }
                                }
 
                                if (ident == TAG_IDENT_AVDP &&
-                                   location == last[i] - 256 - sbi->s_session) {
+                                   location == last[i] - 256 -
+                                               sbi->s_session) {
                                        lastblock = last[i];
                                        sbi->s_anchor[1] = last[i] - 256;
                                } else {
                                        ident = location = 0;
                                        if (last[i] >= 312 + sbi->s_session) {
-                                               bh = sb_bread(sb, last[i] - 312 - sbi->s_session);
+                                               bh = sb_bread(sb,
+                                                               last[i] - 312 -
+                                                               sbi->s_session);
                                                if (bh) {
-                                                       tag *t = (tag *)bh->b_data;
-                                                       ident = le16_to_cpu(t->tagIdent);
-                                                       location = le32_to_cpu(t->tagLocation);
+                                                       tag *t = (tag *)
+                                                                bh->b_data;
+                                                       ident = le16_to_cpu(
+                                                               t->tagIdent);
+                                                       location = le32_to_cpu(
+                                                               t->tagLocation);
                                                        brelse(bh);
                                                }
                                        }
 
                                        if (ident == TAG_IDENT_AVDP &&
                                            location == udf_variable_to_fixed(last[i]) - 256) {
-                                               UDF_SET_FLAG(sb, UDF_FLAG_VARCONV);
+                                               UDF_SET_FLAG(sb,
+                                                            UDF_FLAG_VARCONV);
                                                lastblock = udf_variable_to_fixed(last[i]);
                                                sbi->s_anchor[1] = lastblock - 256;
                                        }
@@ -787,7 +835,8 @@ static void udf_find_anchor(struct super_block *sb)
                        else {
                                brelse(bh);
                                if ((ident != TAG_IDENT_AVDP) &&
-                                   (i || (ident != TAG_IDENT_FE && ident != TAG_IDENT_EFE)))
+                                   (i || (ident != TAG_IDENT_FE &&
+                                          ident != TAG_IDENT_EFE)))
                                        sbi->s_anchor[i] = 0;
                        }
                }
@@ -848,11 +897,12 @@ static int udf_find_fileset(struct super_block *sb,
                                case TAG_IDENT_SBD:
                                {
                                        struct spaceBitmapDesc *sp;
-                                       sp = (struct spaceBitmapDesc *)bh->b_data;
+                                       sp = (struct spaceBitmapDesc *)
+                                                               bh->b_data;
                                        newfileset.logicalBlockNum += 1 +
                                                ((le32_to_cpu(sp->numOfBytes) +
-                                                 sizeof(struct spaceBitmapDesc) - 1)
-                                                >> sb->s_blocksize_bits);
+                                                 sizeof(struct spaceBitmapDesc)
+                                                 - 1) >> sb->s_blocksize_bits);
                                        brelse(bh);
                                        break;
                                }
@@ -888,38 +938,32 @@ static int udf_find_fileset(struct super_block *sb,
 static void udf_load_pvoldesc(struct super_block *sb, struct buffer_head *bh)
 {
        struct primaryVolDesc *pvoldesc;
-       time_t recording;
-       long recording_usec;
        struct ustr instr;
        struct ustr outstr;
 
        pvoldesc = (struct primaryVolDesc *)bh->b_data;
 
-       if (udf_stamp_to_time(&recording, &recording_usec,
-                             lets_to_cpu(pvoldesc->recordingDateAndTime))) {
+       if (udf_disk_stamp_to_time(&UDF_SB(sb)->s_record_time,
+                             pvoldesc->recordingDateAndTime)) {
                kernel_timestamp ts;
                ts = lets_to_cpu(pvoldesc->recordingDateAndTime);
-               udf_debug("recording time %ld/%ld, %04u/%02u/%02u"
+               udf_debug("recording time %04u/%02u/%02u"
                          " %02u:%02u (%x)\n",
-                         recording, recording_usec,
                          ts.year, ts.month, ts.day, ts.hour,
                          ts.minute, ts.typeAndTimezone);
-               UDF_SB(sb)->s_record_time.tv_sec = recording;
-               UDF_SB(sb)->s_record_time.tv_nsec = recording_usec * 1000;
        }
 
-       if (!udf_build_ustr(&instr, pvoldesc->volIdent, 32)) {
+       if (!udf_build_ustr(&instr, pvoldesc->volIdent, 32))
                if (udf_CS0toUTF8(&outstr, &instr)) {
                        strncpy(UDF_SB(sb)->s_volume_ident, outstr.u_name,
                                outstr.u_len > 31 ? 31 : outstr.u_len);
-                       udf_debug("volIdent[] = '%s'\n", UDF_SB(sb)->s_volume_ident);
+                       udf_debug("volIdent[] = '%s'\n",
+                                       UDF_SB(sb)->s_volume_ident);
                }
-       }
 
-       if (!udf_build_ustr(&instr, pvoldesc->volSetIdent, 128)) {
+       if (!udf_build_ustr(&instr, pvoldesc->volSetIdent, 128))
                if (udf_CS0toUTF8(&outstr, &instr))
                        udf_debug("volSetIdent[] = '%s'\n", outstr.u_name);
-       }
 }
 
 static void udf_load_fileset(struct super_block *sb, struct buffer_head *bh,
@@ -940,10 +984,9 @@ static void udf_load_fileset(struct super_block *sb, struct buffer_head *bh,
 int udf_compute_nr_groups(struct super_block *sb, u32 partition)
 {
        struct udf_part_map *map = &UDF_SB(sb)->s_partmaps[partition];
-       return (map->s_partition_len +
-               (sizeof(struct spaceBitmapDesc) << 3) +
-               (sb->s_blocksize * 8) - 1) /
-               (sb->s_blocksize * 8);
+       return DIV_ROUND_UP(map->s_partition_len +
+                           (sizeof(struct spaceBitmapDesc) << 3),
+                           sb->s_blocksize * 8);
 }
 
 static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index)
@@ -987,18 +1030,30 @@ static int udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
        for (i = 0; i < sbi->s_partitions; i++) {
                map = &sbi->s_partmaps[i];
                udf_debug("Searching map: (%d == %d)\n",
-                         map->s_partition_num, le16_to_cpu(p->partitionNumber));
-               if (map->s_partition_num == le16_to_cpu(p->partitionNumber)) {
-                       map->s_partition_len = le32_to_cpu(p->partitionLength); /* blocks */
-                       map->s_partition_root = le32_to_cpu(p->partitionStartingLocation);
-                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_READ_ONLY)
-                               map->s_partition_flags |= UDF_PART_FLAG_READ_ONLY;
-                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_WRITE_ONCE)
-                               map->s_partition_flags |= UDF_PART_FLAG_WRITE_ONCE;
-                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_REWRITABLE)
-                               map->s_partition_flags |= UDF_PART_FLAG_REWRITABLE;
-                       if (le32_to_cpu(p->accessType) == PD_ACCESS_TYPE_OVERWRITABLE)
-                               map->s_partition_flags |= UDF_PART_FLAG_OVERWRITABLE;
+                         map->s_partition_num,
+                         le16_to_cpu(p->partitionNumber));
+               if (map->s_partition_num ==
+                               le16_to_cpu(p->partitionNumber)) {
+                       map->s_partition_len =
+                               le32_to_cpu(p->partitionLength); /* blocks */
+                       map->s_partition_root =
+                               le32_to_cpu(p->partitionStartingLocation);
+                       if (p->accessType ==
+                                       cpu_to_le32(PD_ACCESS_TYPE_READ_ONLY))
+                               map->s_partition_flags |=
+                                               UDF_PART_FLAG_READ_ONLY;
+                       if (p->accessType ==
+                                       cpu_to_le32(PD_ACCESS_TYPE_WRITE_ONCE))
+                               map->s_partition_flags |=
+                                               UDF_PART_FLAG_WRITE_ONCE;
+                       if (p->accessType ==
+                                       cpu_to_le32(PD_ACCESS_TYPE_REWRITABLE))
+                               map->s_partition_flags |=
+                                               UDF_PART_FLAG_REWRITABLE;
+                       if (p->accessType ==
+                                   cpu_to_le32(PD_ACCESS_TYPE_OVERWRITABLE))
+                               map->s_partition_flags |=
+                                               UDF_PART_FLAG_OVERWRITABLE;
 
                        if (!strcmp(p->partitionContents.ident,
                                    PD_PARTITION_CONTENTS_NSR02) ||
@@ -1006,7 +1061,8 @@ static int udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
                                    PD_PARTITION_CONTENTS_NSR03)) {
                                struct partitionHeaderDesc *phd;
 
-                               phd = (struct partitionHeaderDesc *)(p->partitionContentsUse);
+                               phd = (struct partitionHeaderDesc *)
+                                               (p->partitionContentsUse);
                                if (phd->unallocSpaceTable.extLength) {
                                        kernel_lb_addr loc = {
                                                .logicalBlockNum = le32_to_cpu(phd->unallocSpaceTable.extPosition),
@@ -1019,20 +1075,23 @@ static int udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
                                                udf_debug("cannot load unallocSpaceTable (part %d)\n", i);
                                                return 1;
                                        }
-                                       map->s_partition_flags |= UDF_PART_FLAG_UNALLOC_TABLE;
+                                       map->s_partition_flags |=
+                                               UDF_PART_FLAG_UNALLOC_TABLE;
                                        udf_debug("unallocSpaceTable (part %d) @ %ld\n",
                                                  i, map->s_uspace.s_table->i_ino);
                                }
                                if (phd->unallocSpaceBitmap.extLength) {
-                                       map->s_uspace.s_bitmap = udf_sb_alloc_bitmap(sb, i);
-                                       if (map->s_uspace.s_bitmap != NULL) {
-                                               map->s_uspace.s_bitmap->s_extLength =
+                                       struct udf_bitmap *bitmap =
+                                               udf_sb_alloc_bitmap(sb, i);
+                                       map->s_uspace.s_bitmap = bitmap;
+                                       if (bitmap != NULL) {
+                                               bitmap->s_extLength =
                                                        le32_to_cpu(phd->unallocSpaceBitmap.extLength);
-                                               map->s_uspace.s_bitmap->s_extPosition =
+                                               bitmap->s_extPosition =
                                                        le32_to_cpu(phd->unallocSpaceBitmap.extPosition);
                                                map->s_partition_flags |= UDF_PART_FLAG_UNALLOC_BITMAP;
                                                udf_debug("unallocSpaceBitmap (part %d) @ %d\n",
-                                                         i, map->s_uspace.s_bitmap->s_extPosition);
+                                                         i, bitmap->s_extPosition);
                                        }
                                }
                                if (phd->partitionIntegrityTable.extLength)
@@ -1049,37 +1108,39 @@ static int udf_load_partdesc(struct super_block *sb, struct buffer_head *bh)
                                                udf_debug("cannot load freedSpaceTable (part %d)\n", i);
                                                return 1;
                                        }
-                                       map->s_partition_flags |= UDF_PART_FLAG_FREED_TABLE;
+                                       map->s_partition_flags |=
+                                               UDF_PART_FLAG_FREED_TABLE;
                                        udf_debug("freedSpaceTable (part %d) @ %ld\n",
                                                  i, map->s_fspace.s_table->i_ino);
                                }
                                if (phd->freedSpaceBitmap.extLength) {
-                                       map->s_fspace.s_bitmap = udf_sb_alloc_bitmap(sb, i);
-                                       if (map->s_fspace.s_bitmap != NULL) {
-                                               map->s_fspace.s_bitmap->s_extLength =
+                                       struct udf_bitmap *bitmap =
+                                               udf_sb_alloc_bitmap(sb, i);
+                                       map->s_fspace.s_bitmap = bitmap;
+                                       if (bitmap != NULL) {
+                                               bitmap->s_extLength =
                                                        le32_to_cpu(phd->freedSpaceBitmap.extLength);
-                                               map->s_fspace.s_bitmap->s_extPosition =
+                                               bitmap->s_extPosition =
                                                        le32_to_cpu(phd->freedSpaceBitmap.extPosition);
                                                map->s_partition_flags |= UDF_PART_FLAG_FREED_BITMAP;
                                                udf_debug("freedSpaceBitmap (part %d) @ %d\n",
-                                                         i, map->s_fspace.s_bitmap->s_extPosition);
+                                                         i, bitmap->s_extPosition);
                                        }
                                }
                        }
                        break;
                }
        }
-       if (i == sbi->s_partitions) {
+       if (i == sbi->s_partitions)
                udf_debug("Partition (%d) not found in partition map\n",
                          le16_to_cpu(p->partitionNumber));
-       } else {
+       else
                udf_debug("Partition (%d:%d type %x) starts at physical %d, "
                          "block length %d\n",
                          le16_to_cpu(p->partitionNumber), i,
                          map->s_partition_type,
                          map->s_partition_root,
                          map->s_partition_len);
-       }
        return 0;
 }
 
@@ -1090,6 +1151,7 @@ static int udf_load_logicalvol(struct super_block *sb, struct buffer_head *bh,
        int i, j, offset;
        uint8_t type;
        struct udf_sb_info *sbi = UDF_SB(sb);
+       struct genericPartitionMap *gpm;
 
        lvd = (struct logicalVolDesc *)bh->b_data;
 
@@ -1099,43 +1161,71 @@ static int udf_load_logicalvol(struct super_block *sb, struct buffer_head *bh,
 
        for (i = 0, offset = 0;
             i < sbi->s_partitions && offset < le32_to_cpu(lvd->mapTableLength);
-            i++, offset += ((struct genericPartitionMap *)&(lvd->partitionMaps[offset]))->partitionMapLength) {
-               struct udf_part_map *map = &sbi->s_partmaps[i];
-               type = ((struct genericPartitionMap *)&(lvd->partitionMaps[offset]))->partitionMapType;
+            i++, offset += gpm->partitionMapLength) {
+               struct udf_part_map *map = &sbi->s_partmaps[i];
+               gpm = (struct genericPartitionMap *)
+                               &(lvd->partitionMaps[offset]);
+               type = gpm->partitionMapType;
                if (type == 1) {
-                       struct genericPartitionMap1 *gpm1 = (struct genericPartitionMap1 *)&(lvd->partitionMaps[offset]);
+                       struct genericPartitionMap1 *gpm1 =
+                               (struct genericPartitionMap1 *)gpm;
                        map->s_partition_type = UDF_TYPE1_MAP15;
                        map->s_volumeseqnum = le16_to_cpu(gpm1->volSeqNum);
                        map->s_partition_num = le16_to_cpu(gpm1->partitionNum);
                        map->s_partition_func = NULL;
                } else if (type == 2) {
-                       struct udfPartitionMap2 *upm2 = (struct udfPartitionMap2 *)&(lvd->partitionMaps[offset]);
-                       if (!strncmp(upm2->partIdent.ident, UDF_ID_VIRTUAL, strlen(UDF_ID_VIRTUAL))) {
-                               if (le16_to_cpu(((__le16 *)upm2->partIdent.identSuffix)[0]) == 0x0150) {
-                                       map->s_partition_type = UDF_VIRTUAL_MAP15;
-                                       map->s_partition_func = udf_get_pblock_virt15;
-                               } else if (le16_to_cpu(((__le16 *)upm2->partIdent.identSuffix)[0]) == 0x0200) {
-                                       map->s_partition_type = UDF_VIRTUAL_MAP20;
-                                       map->s_partition_func = udf_get_pblock_virt20;
+                       struct udfPartitionMap2 *upm2 =
+                                               (struct udfPartitionMap2 *)gpm;
+                       if (!strncmp(upm2->partIdent.ident, UDF_ID_VIRTUAL,
+                                               strlen(UDF_ID_VIRTUAL))) {
+                               u16 suf =
+                                       le16_to_cpu(((__le16 *)upm2->partIdent.
+                                                       identSuffix)[0]);
+                               if (suf == 0x0150) {
+                                       map->s_partition_type =
+                                                       UDF_VIRTUAL_MAP15;
+                                       map->s_partition_func =
+                                                       udf_get_pblock_virt15;
+                               } else if (suf == 0x0200) {
+                                       map->s_partition_type =
+                                                       UDF_VIRTUAL_MAP20;
+                                       map->s_partition_func =
+                                                       udf_get_pblock_virt20;
                                }
-                       } else if (!strncmp(upm2->partIdent.ident, UDF_ID_SPARABLE, strlen(UDF_ID_SPARABLE))) {
+                       } else if (!strncmp(upm2->partIdent.ident,
+                                               UDF_ID_SPARABLE,
+                                               strlen(UDF_ID_SPARABLE))) {
                                uint32_t loc;
                                uint16_t ident;
                                struct sparingTable *st;
-                               struct sparablePartitionMap *spm = (struct sparablePartitionMap *)&(lvd->partitionMaps[offset]);
+                               struct sparablePartitionMap *spm =
+                                       (struct sparablePartitionMap *)gpm;
 
                                map->s_partition_type = UDF_SPARABLE_MAP15;
-                               map->s_type_specific.s_sparing.s_packet_len = le16_to_cpu(spm->packetLength);
+                               map->s_type_specific.s_sparing.s_packet_len =
+                                               le16_to_cpu(spm->packetLength);
                                for (j = 0; j < spm->numSparingTables; j++) {
-                                       loc = le32_to_cpu(spm->locSparingTable[j]);
-                                       map->s_type_specific.s_sparing.s_spar_map[j] =
-                                               udf_read_tagged(sb, loc, loc, &ident);
-                                       if (map->s_type_specific.s_sparing.s_spar_map[j] != NULL) {
-                                               st = (struct sparingTable *)map->s_type_specific.s_sparing.s_spar_map[j]->b_data;
-                                               if (ident != 0 ||
-                                                   strncmp(st->sparingIdent.ident, UDF_ID_SPARING, strlen(UDF_ID_SPARING))) {
-                                                       brelse(map->s_type_specific.s_sparing.s_spar_map[j]);
-                                                       map->s_type_specific.s_sparing.s_spar_map[j] = NULL;
+                                       struct buffer_head *bh2;
+
+                                       loc = le32_to_cpu(
+                                               spm->locSparingTable[j]);
+                                       bh2 = udf_read_tagged(sb, loc, loc,
+                                                            &ident);
+                                       map->s_type_specific.s_sparing.
+                                                       s_spar_map[j] = bh2;
+
+                                       if (bh2 != NULL) {
+                                               st = (struct sparingTable *)
+                                                               bh2->b_data;
+                                               if (ident != 0 || strncmp(
+                                                       st->sparingIdent.ident,
+                                                       UDF_ID_SPARING,
+                                                       strlen(UDF_ID_SPARING))) {
+                                                       brelse(bh2);
+                                                       map->s_type_specific.
+                                                               s_sparing.
+                                                               s_spar_map[j] =
+                                                                       NULL;
                                                }
                                        }
                                }
@@ -1218,6 +1308,7 @@ static int udf_process_sequence(struct super_block *sb, long block,
 {
        struct buffer_head *bh = NULL;
        struct udf_vds_record vds[VDS_POS_LENGTH];
+       struct udf_vds_record *curr;
        struct generic_desc *gd;
        struct volDescPtr *vdp;
        int done = 0;
@@ -1240,43 +1331,51 @@ static int udf_process_sequence(struct super_block *sb, long block,
                vdsn = le32_to_cpu(gd->volDescSeqNum);
                switch (ident) {
                case TAG_IDENT_PVD: /* ISO 13346 3/10.1 */
-                       if (vdsn >= vds[VDS_POS_PRIMARY_VOL_DESC].volDescSeqNum) {
-                               vds[VDS_POS_PRIMARY_VOL_DESC].volDescSeqNum = vdsn;
-                               vds[VDS_POS_PRIMARY_VOL_DESC].block = block;
+                       curr = &vds[VDS_POS_PRIMARY_VOL_DESC];
+                       if (vdsn >= curr->volDescSeqNum) {
+                               curr->volDescSeqNum = vdsn;
+                               curr->block = block;
                        }
                        break;
                case TAG_IDENT_VDP: /* ISO 13346 3/10.3 */
-                       if (vdsn >= vds[VDS_POS_VOL_DESC_PTR].volDescSeqNum) {
-                               vds[VDS_POS_VOL_DESC_PTR].volDescSeqNum = vdsn;
-                               vds[VDS_POS_VOL_DESC_PTR].block = block;
+                       curr = &vds[VDS_POS_VOL_DESC_PTR];
+                       if (vdsn >= curr->volDescSeqNum) {
+                               curr->volDescSeqNum = vdsn;
+                               curr->block = block;
 
                                vdp = (struct volDescPtr *)bh->b_data;
-                               next_s = le32_to_cpu(vdp->nextVolDescSeqExt.extLocation);
-                               next_e = le32_to_cpu(vdp->nextVolDescSeqExt.extLength);
+                               next_s = le32_to_cpu(
+                                       vdp->nextVolDescSeqExt.extLocation);
+                               next_e = le32_to_cpu(
+                                       vdp->nextVolDescSeqExt.extLength);
                                next_e = next_e >> sb->s_blocksize_bits;
                                next_e += next_s;
                        }
                        break;
                case TAG_IDENT_IUVD: /* ISO 13346 3/10.4 */
-                       if (vdsn >= vds[VDS_POS_IMP_USE_VOL_DESC].volDescSeqNum) {
-                               vds[VDS_POS_IMP_USE_VOL_DESC].volDescSeqNum = vdsn;
-                               vds[VDS_POS_IMP_USE_VOL_DESC].block = block;
+                       curr = &vds[VDS_POS_IMP_USE_VOL_DESC];
+                       if (vdsn >= curr->volDescSeqNum) {
+                               curr->volDescSeqNum = vdsn;
+                               curr->block = block;
                        }
                        break;
                case TAG_IDENT_PD: /* ISO 13346 3/10.5 */
-                       if (!vds[VDS_POS_PARTITION_DESC].block)
-                               vds[VDS_POS_PARTITION_DESC].block = block;
+                       curr = &vds[VDS_POS_PARTITION_DESC];
+                       if (!curr->block)
+                               curr->block = block;
                        break;
                case TAG_IDENT_LVD: /* ISO 13346 3/10.6 */
-                       if (vdsn >= vds[VDS_POS_LOGICAL_VOL_DESC].volDescSeqNum) {
-                               vds[VDS_POS_LOGICAL_VOL_DESC].volDescSeqNum = vdsn;
-                               vds[VDS_POS_LOGICAL_VOL_DESC].block = block;
+                       curr = &vds[VDS_POS_LOGICAL_VOL_DESC];
+                       if (vdsn >= curr->volDescSeqNum) {
+                               curr->volDescSeqNum = vdsn;
+                               curr->block = block;
                        }
                        break;
                case TAG_IDENT_USD: /* ISO 13346 3/10.8 */
-                       if (vdsn >= vds[VDS_POS_UNALLOC_SPACE_DESC].volDescSeqNum) {
-                               vds[VDS_POS_UNALLOC_SPACE_DESC].volDescSeqNum = vdsn;
-                               vds[VDS_POS_UNALLOC_SPACE_DESC].block = block;
+                       curr = &vds[VDS_POS_UNALLOC_SPACE_DESC];
+                       if (vdsn >= curr->volDescSeqNum) {
+                               curr->volDescSeqNum = vdsn;
+                               curr->block = block;
                        }
                        break;
                case TAG_IDENT_TD: /* ISO 13346 3/10.9 */
@@ -1285,9 +1384,8 @@ static int udf_process_sequence(struct super_block *sb, long block,
                                block = next_s;
                                lastblock = next_e;
                                next_s = next_e = 0;
-                       } else {
+                       } else
                                done = 1;
-                       }
                        break;
                }
                brelse(bh);
@@ -1373,38 +1471,45 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
        sbi = UDF_SB(sb);
 
        for (i = 0; i < ARRAY_SIZE(sbi->s_anchor); i++) {
-               if (sbi->s_anchor[i] &&
-                   (bh = udf_read_tagged(sb, sbi->s_anchor[i],
-                                         sbi->s_anchor[i], &ident))) {
-                       anchor = (struct anchorVolDescPtr *)bh->b_data;
-
-                       /* Locate the main sequence */
-                       main_s = le32_to_cpu(anchor->mainVolDescSeqExt.extLocation);
-                       main_e = le32_to_cpu(anchor->mainVolDescSeqExt.extLength);
-                       main_e = main_e >> sb->s_blocksize_bits;
-                       main_e += main_s;
-
-                       /* Locate the reserve sequence */
-                       reserve_s = le32_to_cpu(anchor->reserveVolDescSeqExt.extLocation);
-                       reserve_e = le32_to_cpu(anchor->reserveVolDescSeqExt.extLength);
-                       reserve_e = reserve_e >> sb->s_blocksize_bits;
-                       reserve_e += reserve_s;
+               if (!sbi->s_anchor[i])
+                       continue;
+               bh = udf_read_tagged(sb, sbi->s_anchor[i], sbi->s_anchor[i],
+                                    &ident);
+               if (!bh)
+                       continue;
 
-                       brelse(bh);
+               anchor = (struct anchorVolDescPtr *)bh->b_data;
 
-                       /* Process the main & reserve sequences */
-                       /* responsible for finding the PartitionDesc(s) */
-                       if (!(udf_process_sequence(sb, main_s, main_e, fileset) &&
-                             udf_process_sequence(sb, reserve_s, reserve_e, fileset)))
-                               break;
-               }
+               /* Locate the main sequence */
+               main_s = le32_to_cpu(anchor->mainVolDescSeqExt.extLocation);
+               main_e = le32_to_cpu(anchor->mainVolDescSeqExt.extLength);
+               main_e = main_e >> sb->s_blocksize_bits;
+               main_e += main_s;
+
+               /* Locate the reserve sequence */
+               reserve_s = le32_to_cpu(
+                               anchor->reserveVolDescSeqExt.extLocation);
+               reserve_e = le32_to_cpu(
+                               anchor->reserveVolDescSeqExt.extLength);
+               reserve_e = reserve_e >> sb->s_blocksize_bits;
+               reserve_e += reserve_s;
+
+               brelse(bh);
+
+               /* Process the main & reserve sequences */
+               /* responsible for finding the PartitionDesc(s) */
+               if (!(udf_process_sequence(sb, main_s, main_e,
+                                          fileset) &&
+                     udf_process_sequence(sb, reserve_s, reserve_e,
+                                          fileset)))
+                       break;
        }
 
        if (i == ARRAY_SIZE(sbi->s_anchor)) {
                udf_debug("No Anchor block found\n");
                return 1;
-       } else
-               udf_debug("Using anchor in block %d\n", sbi->s_anchor[i]);
+       }
+       udf_debug("Using anchor in block %d\n", sbi->s_anchor[i]);
 
        for (i = 0; i < sbi->s_partitions; i++) {
                kernel_lb_addr uninitialized_var(ino);
@@ -1426,10 +1531,14 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
                        for (j = 0; j < sbi->s_partitions; j++) {
                                struct udf_part_map *map2 = &sbi->s_partmaps[j];
                                if (j != i &&
-                                   map->s_volumeseqnum == map2->s_volumeseqnum &&
-                                   map->s_partition_num == map2->s_partition_num) {
+                                   map->s_volumeseqnum ==
+                                               map2->s_volumeseqnum &&
+                                   map->s_partition_num ==
+                                               map2->s_partition_num) {
                                        ino.partitionReferenceNum = j;
-                                       ino.logicalBlockNum = sbi->s_last_block - map2->s_partition_root;
+                                       ino.logicalBlockNum =
+                                               sbi->s_last_block -
+                                                       map2->s_partition_root;
                                        break;
                                }
                        }
@@ -1448,17 +1557,22 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
                                        (sbi->s_vat_inode->i_size - 36) >> 2;
                        } else if (map->s_partition_type == UDF_VIRTUAL_MAP20) {
                                uint32_t pos;
+                               struct virtualAllocationTable20 *vat20;
 
                                pos = udf_block_map(sbi->s_vat_inode, 0);
                                bh = sb_bread(sb, pos);
                                if (!bh)
                                        return 1;
+                               vat20 = (struct virtualAllocationTable20 *)
+                                       bh->b_data +
+                                       udf_ext0_offset(sbi->s_vat_inode);
                                map->s_type_specific.s_virtual.s_start_offset =
-                                       le16_to_cpu(((struct virtualAllocationTable20 *)bh->b_data +
-                                                    udf_ext0_offset(sbi->s_vat_inode))->lengthHeader) +
+                                       le16_to_cpu(vat20->lengthHeader) +
                                        udf_ext0_offset(sbi->s_vat_inode);
-                               map->s_type_specific.s_virtual.s_num_entries = (sbi->s_vat_inode->i_size -
-                                                                       map->s_type_specific.s_virtual.s_start_offset) >> 2;
+                               map->s_type_specific.s_virtual.s_num_entries =
+                                       (sbi->s_vat_inode->i_size -
+                                        map->s_type_specific.s_virtual.
+                                                       s_start_offset) >> 2;
                                brelse(bh);
                        }
                        map->s_partition_root = udf_get_pblock(sb, 0, i, 0);
@@ -1475,34 +1589,29 @@ static void udf_open_lvid(struct super_block *sb)
        struct udf_sb_info *sbi = UDF_SB(sb);
        struct buffer_head *bh = sbi->s_lvid_bh;
        if (bh) {
-               int i;
-               kernel_timestamp cpu_time;
-               struct logicalVolIntegrityDesc *lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
-               struct logicalVolIntegrityDescImpUse *lvidiu = udf_sb_lvidiu(sbi);
+               struct logicalVolIntegrityDesc *lvid =
+                               (struct logicalVolIntegrityDesc *)bh->b_data;
+               struct logicalVolIntegrityDescImpUse *lvidiu =
+                                                       udf_sb_lvidiu(sbi);
 
                lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
                lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
-               if (udf_time_to_stamp(&cpu_time, CURRENT_TIME))
-                       lvid->recordingDateAndTime = cpu_to_lets(cpu_time);
+               udf_time_to_disk_stamp(&lvid->recordingDateAndTime,
+                                       CURRENT_TIME);
                lvid->integrityType = LVID_INTEGRITY_TYPE_OPEN;
 
-               lvid->descTag.descCRC = cpu_to_le16(udf_crc((char *)lvid + sizeof(tag),
-                                                                      le16_to_cpu(lvid->descTag.descCRCLength), 0));
-
-               lvid->descTag.tagChecksum = 0;
-               for (i = 0; i < 16; i++)
-                       if (i != 4)
-                               lvid->descTag.tagChecksum +=
-                                       ((uint8_t *) &(lvid->descTag))[i];
+               lvid->descTag.descCRC = cpu_to_le16(
+                       udf_crc((char *)lvid + sizeof(tag),
+                               le16_to_cpu(lvid->descTag.descCRCLength),
+                               0));
 
+               lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);
                mark_buffer_dirty(bh);
        }
 }
 
 static void udf_close_lvid(struct super_block *sb)
 {
-       kernel_timestamp cpu_time;
-       int i;
        struct udf_sb_info *sbi = UDF_SB(sb);
        struct buffer_head *bh = sbi->s_lvid_bh;
        struct logicalVolIntegrityDesc *lvid;
@@ -1513,29 +1622,27 @@ static void udf_close_lvid(struct super_block *sb)
        lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
 
        if (lvid->integrityType == LVID_INTEGRITY_TYPE_OPEN) {
-               struct logicalVolIntegrityDescImpUse *lvidiu = udf_sb_lvidiu(sbi);
+               struct logicalVolIntegrityDescImpUse *lvidiu =
+                                                       udf_sb_lvidiu(sbi);
                lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
                lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
-               if (udf_time_to_stamp(&cpu_time, CURRENT_TIME))
-                       lvid->recordingDateAndTime = cpu_to_lets(cpu_time);
+               udf_time_to_disk_stamp(&lvid->recordingDateAndTime,
+                                       CURRENT_TIME);
                if (UDF_MAX_WRITE_VERSION > le16_to_cpu(lvidiu->maxUDFWriteRev))
-                       lvidiu->maxUDFWriteRev = cpu_to_le16(UDF_MAX_WRITE_VERSION);
+                       lvidiu->maxUDFWriteRev =
+                                       cpu_to_le16(UDF_MAX_WRITE_VERSION);
                if (sbi->s_udfrev > le16_to_cpu(lvidiu->minUDFReadRev))
                        lvidiu->minUDFReadRev = cpu_to_le16(sbi->s_udfrev);
                if (sbi->s_udfrev > le16_to_cpu(lvidiu->minUDFWriteRev))
                        lvidiu->minUDFWriteRev = cpu_to_le16(sbi->s_udfrev);
                lvid->integrityType = cpu_to_le32(LVID_INTEGRITY_TYPE_CLOSE);
 
-               lvid->descTag.descCRC =
-                       cpu_to_le16(udf_crc((char *)lvid + sizeof(tag),
-                                           le16_to_cpu(lvid->descTag.descCRCLength), 0));
-
-               lvid->descTag.tagChecksum = 0;
-               for (i = 0; i < 16; i++)
-                       if (i != 4)
-                               lvid->descTag.tagChecksum +=
-                                       ((uint8_t *)&(lvid->descTag))[i];
+               lvid->descTag.descCRC = cpu_to_le16(
+                       udf_crc((char *)lvid + sizeof(tag),
+                               le16_to_cpu(lvid->descTag.descCRCLength),
+                               0));
 
+               lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);
                mark_buffer_dirty(bh);
        }
 }
@@ -1544,7 +1651,8 @@ static void udf_sb_free_bitmap(struct udf_bitmap *bitmap)
 {
        int i;
        int nr_groups = bitmap->s_nr_groups;
-       int size = sizeof(struct udf_bitmap) + (sizeof(struct buffer_head *) * nr_groups);
+       int size = sizeof(struct udf_bitmap) + (sizeof(struct buffer_head *) *
+                                               nr_groups);
 
        for (i = 0; i < nr_groups; i++)
                if (bitmap->s_block_bitmap[i])
@@ -1556,22 +1664,6 @@ static void udf_sb_free_bitmap(struct udf_bitmap *bitmap)
                vfree(bitmap);
 }
 
-/*
- * udf_read_super
- *
- * PURPOSE
- *     Complete the specified super block.
- *
- * PRE-CONDITIONS
- *     sb                      Pointer to superblock to complete - never NULL.
- *     sb->s_dev               Device to read suberblock from.
- *     options                 Pointer to mount options.
- *     silent                  Silent flag.
- *
- * HISTORY
- *     July 1, 1997 - Andrew E. Mileski
- *     Written, tested, and released.
- */
 static int udf_fill_super(struct super_block *sb, void *options, int silent)
 {
        int i;
@@ -1593,7 +1685,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
 
        mutex_init(&sbi->s_alloc_mutex);
 
-       if (!udf_parse_options((char *)options, &uopt))
+       if (!udf_parse_options((char *)options, &uopt, false))
                goto error_out;
 
        if (uopt.flags & (1 << UDF_FLAG_UTF8) &&
@@ -1624,8 +1716,11 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        sbi->s_nls_map = uopt.nls_map;
 
        /* Set the block size for all transfers */
-       if (!udf_set_blocksize(sb, uopt.blocksize))
+       if (!sb_min_blocksize(sb, uopt.blocksize)) {
+               udf_debug("Bad block size (%d)\n", uopt.blocksize);
+               printk(KERN_ERR "udf: bad block size (%d)\n", uopt.blocksize);
                goto error_out;
+       }
 
        if (uopt.session == 0xFFFFFFFF)
                sbi->s_session = udf_get_last_session(sb);
@@ -1662,19 +1757,21 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        udf_debug("Lastblock=%d\n", sbi->s_last_block);
 
        if (sbi->s_lvid_bh) {
-               struct logicalVolIntegrityDescImpUse *lvidiu = udf_sb_lvidiu(sbi);
+               struct logicalVolIntegrityDescImpUse *lvidiu =
+                                                       udf_sb_lvidiu(sbi);
                uint16_t minUDFReadRev = le16_to_cpu(lvidiu->minUDFReadRev);
                uint16_t minUDFWriteRev = le16_to_cpu(lvidiu->minUDFWriteRev);
-               /* uint16_t maxUDFWriteRev = le16_to_cpu(lvidiu->maxUDFWriteRev); */
+               /* uint16_t maxUDFWriteRev =
+                               le16_to_cpu(lvidiu->maxUDFWriteRev); */
 
                if (minUDFReadRev > UDF_MAX_READ_VERSION) {
-                       printk(KERN_ERR "UDF-fs: minUDFReadRev=%x (max is %x)\n",
+                       printk(KERN_ERR "UDF-fs: minUDFReadRev=%x "
+                                       "(max is %x)\n",
                               le16_to_cpu(lvidiu->minUDFReadRev),
                               UDF_MAX_READ_VERSION);
                        goto error_out;
-               } else if (minUDFWriteRev > UDF_MAX_WRITE_VERSION) {
+               } else if (minUDFWriteRev > UDF_MAX_WRITE_VERSION)
                        sb->s_flags |= MS_RDONLY;
-               }
 
                sbi->s_udfrev = minUDFWriteRev;
 
@@ -1689,8 +1786,10 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
                goto error_out;
        }
 
-       if (sbi->s_partmaps[sbi->s_partition].s_partition_flags & UDF_PART_FLAG_READ_ONLY) {
-               printk(KERN_NOTICE "UDF-fs: Partition marked readonly; forcing readonly mount\n");
+       if (sbi->s_partmaps[sbi->s_partition].s_partition_flags &
+                       UDF_PART_FLAG_READ_ONLY) {
+               printk(KERN_NOTICE "UDF-fs: Partition marked readonly; "
+                                  "forcing readonly mount\n");
                sb->s_flags |= MS_RDONLY;
        }
 
@@ -1700,13 +1799,12 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        }
 
        if (!silent) {
-               kernel_timestamp ts;
-               udf_time_to_stamp(&ts, sbi->s_record_time);
-               udf_info("UDF %s (%s) Mounting volume '%s', "
+               timestamp ts;
+               udf_time_to_disk_stamp(&ts, sbi->s_record_time);
+               udf_info("UDF: Mounting volume '%s', "
                         "timestamp %04u/%02u/%02u %02u:%02u (%x)\n",
-                        UDFFS_VERSION, UDFFS_DATE,
-                        sbi->s_volume_ident, ts.year, ts.month, ts.day,
-                        ts.hour, ts.minute, ts.typeAndTimezone);
+                        sbi->s_volume_ident, le16_to_cpu(ts.year), ts.month, ts.day,
+                        ts.hour, ts.minute, le16_to_cpu(ts.typeAndTimezone));
        }
        if (!(sb->s_flags & MS_RDONLY))
                udf_open_lvid(sb);
@@ -1716,7 +1814,8 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        /* perhaps it's not extensible enough, but for now ... */
        inode = udf_iget(sb, rootdir);
        if (!inode) {
-               printk(KERN_ERR "UDF-fs: Error in udf_iget, block=%d, partition=%d\n",
+               printk(KERN_ERR "UDF-fs: Error in udf_iget, block=%d, "
+                               "partition=%d\n",
                       rootdir.logicalBlockNum, rootdir.partitionReferenceNum);
                goto error_out;
        }
@@ -1746,7 +1845,8 @@ error_out:
                        udf_sb_free_bitmap(map->s_fspace.s_bitmap);
                if (map->s_partition_type == UDF_SPARABLE_MAP15)
                        for (i = 0; i < 4; i++)
-                               brelse(map->s_type_specific.s_sparing.s_spar_map[i]);
+                               brelse(map->s_type_specific.s_sparing.
+                                               s_spar_map[i]);
        }
 #ifdef CONFIG_UDF_NLS
        if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
@@ -1763,8 +1863,8 @@ error_out:
        return -EINVAL;
 }
 
-void udf_error(struct super_block *sb, const char *function,
-              const char *fmt, ...)
+static void udf_error(struct super_block *sb, const char *function,
+                     const char *fmt, ...)
 {
        va_list args;
 
@@ -1791,19 +1891,6 @@ void udf_warning(struct super_block *sb, const char *function,
               sb->s_id, function, error_buf);
 }
 
-/*
- * udf_put_super
- *
- * PURPOSE
- *     Prepare for destruction of the superblock.
- *
- * DESCRIPTION
- *     Called before the filesystem is unmounted.
- *
- * HISTORY
- *     July 1, 1997 - Andrew E. Mileski
- *     Written, tested, and released.
- */
 static void udf_put_super(struct super_block *sb)
 {
        int i;
@@ -1824,7 +1911,8 @@ static void udf_put_super(struct super_block *sb)
                        udf_sb_free_bitmap(map->s_fspace.s_bitmap);
                if (map->s_partition_type == UDF_SPARABLE_MAP15)
                        for (i = 0; i < 4; i++)
-                               brelse(map->s_type_specific.s_sparing.s_spar_map[i]);
+                               brelse(map->s_type_specific.s_sparing.
+                                               s_spar_map[i]);
        }
 #ifdef CONFIG_UDF_NLS
        if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
@@ -1838,19 +1926,6 @@ static void udf_put_super(struct super_block *sb)
        sb->s_fs_info = NULL;
 }
 
-/*
- * udf_stat_fs
- *
- * PURPOSE
- *     Return info about the filesystem.
- *
- * DESCRIPTION
- *     Called by sys_statfs()
- *
- * HISTORY
- *     July 1, 1997 - Andrew E. Mileski
- *     Written, tested, and released.
- */
 static int udf_statfs(struct dentry *dentry, struct kstatfs *buf)
 {
        struct super_block *sb = dentry->d_sb;
@@ -1877,11 +1952,8 @@ static int udf_statfs(struct dentry *dentry, struct kstatfs *buf)
        return 0;
 }
 
-static unsigned char udf_bitmap_lookup[16] = {
-       0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4
-};
-
-static unsigned int udf_count_free_bitmap(struct super_block *sb, struct udf_bitmap *bitmap)
+static unsigned int udf_count_free_bitmap(struct super_block *sb,
+                                         struct udf_bitmap *bitmap)
 {
        struct buffer_head *bh = NULL;
        unsigned int accum = 0;
@@ -1889,7 +1961,6 @@ static unsigned int udf_count_free_bitmap(struct super_block *sb, struct udf_bit
        int block = 0, newblock;
        kernel_lb_addr loc;
        uint32_t bytes;
-       uint8_t value;
        uint8_t *ptr;
        uint16_t ident;
        struct spaceBitmapDesc *bm;
@@ -1915,13 +1986,10 @@ static unsigned int udf_count_free_bitmap(struct super_block *sb, struct udf_bit
        ptr = (uint8_t *)bh->b_data;
 
        while (bytes > 0) {
-               while ((bytes > 0) && (index < sb->s_blocksize)) {
-                       value = ptr[index];
-                       accum += udf_bitmap_lookup[value & 0x0f];
-                       accum += udf_bitmap_lookup[value >> 4];
-                       index++;
-                       bytes--;
-               }
+               u32 cur_bytes = min_t(u32, bytes, sb->s_blocksize - index);
+               accum += bitmap_weight((const unsigned long *)(ptr + index),
+                                       cur_bytes * 8);
+               bytes -= cur_bytes;
                if (bytes) {
                        brelse(bh);
                        newblock = udf_get_lb_pblock(sb, loc, ++block);
@@ -1942,7 +2010,8 @@ out:
        return accum;
 }
 
-static unsigned int udf_count_free_table(struct super_block *sb, struct inode *table)
+static unsigned int udf_count_free_table(struct super_block *sb,
+                                        struct inode *table)
 {
        unsigned int accum = 0;
        uint32_t elen;
@@ -1952,7 +2021,7 @@ static unsigned int udf_count_free_table(struct super_block *sb, struct inode *t
 
        lock_kernel();
 
-       epos.block = UDF_I_LOCATION(table);
+       epos.block = UDF_I(table)->i_location;
        epos.offset = sizeof(struct unallocSpaceEntry);
        epos.bh = NULL;
 
@@ -1974,9 +2043,12 @@ static unsigned int udf_count_free(struct super_block *sb)
 
        sbi = UDF_SB(sb);
        if (sbi->s_lvid_bh) {
-               struct logicalVolIntegrityDesc *lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
+               struct logicalVolIntegrityDesc *lvid =
+                       (struct logicalVolIntegrityDesc *)
+                       sbi->s_lvid_bh->b_data;
                if (le32_to_cpu(lvid->numOfPartitions) > sbi->s_partition) {
-                       accum = le32_to_cpu(lvid->freeSpaceTable[sbi->s_partition]);
+                       accum = le32_to_cpu(
+                                       lvid->freeSpaceTable[sbi->s_partition]);
                        if (accum == 0xFFFFFFFF)
                                accum = 0;
                }