]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - net/9p/trans_fd.c
9p: remove duplicate client state
[linux-2.6-omap-h63xx.git] / net / 9p / trans_fd.c
index cdf137af7adc87d580280fbbce9b3c2d64b9dc82..bc5b6965981b9a34958659fa5eb74c4dd8beca53 100644 (file)
 #include <linux/file.h>
 #include <linux/parser.h>
 #include <net/9p/9p.h>
+#include <net/9p/client.h>
 #include <net/9p/transport.h>
 
 #define P9_PORT 564
 #define MAX_SOCK_BUF (64*1024)
 #define ERREQFLUSH     1
-#define SCHED_TIMEOUT  10
 #define MAXPOLLWADDR   2
 
 /**
@@ -86,7 +86,7 @@ enum {
        Opt_port, Opt_rfdno, Opt_wfdno, Opt_err,
 };
 
-static match_table_t tokens = {
+static const match_table_t tokens = {
        {Opt_port, "port=%u"},
        {Opt_rfdno, "rfdno=%u"},
        {Opt_wfdno, "wfdno=%u"},
@@ -135,23 +135,19 @@ struct p9_req {
        struct list_head req_list;
 };
 
-struct p9_mux_poll_task {
-       struct task_struct *task;
-       struct list_head mux_list;
-       int muxnum;
+struct p9_poll_wait {
+       struct p9_conn *conn;
+       wait_queue_t wait;
+       wait_queue_head_t *wait_addr;
 };
 
 /**
  * struct p9_conn - fd mux connection state information
  * @lock: protects mux_list (?)
  * @mux_list: list link for mux to manage multiple connections (?)
- * @poll_task: task polling on this connection
- * @msize: maximum size for connection (dup)
- * @extended: 9p2000.u flag (dup)
- * @trans: reference to transport instance for this connection
+ * @client: reference to client instance for this connection
  * @tagpool: id accounting for transactions
  * @err: error state
- * @equeue: event wait_q (?)
  * @req_list: accounting for requests which have been sent
  * @unsent_req_list: accounting for requests that haven't been sent
  * @rcall: current response &p9_fcall structure
@@ -172,13 +168,9 @@ struct p9_mux_poll_task {
 struct p9_conn {
        spinlock_t lock; /* protect lock structure */
        struct list_head mux_list;
-       struct p9_mux_poll_task *poll_task;
-       int msize;
-       unsigned char extended;
-       struct p9_trans *trans;
+       struct p9_client *client;
        struct p9_idpool *tagpool;
        int err;
-       wait_queue_head_t equeue;
        struct list_head req_list;
        struct list_head unsent_req_list;
        struct p9_fcall *rcall;
@@ -187,8 +179,8 @@ struct p9_conn {
        int wpos;
        int wsize;
        char *wbuf;
-       wait_queue_t poll_wait[MAXPOLLWADDR];
-       wait_queue_head_t *poll_waddr[MAXPOLLWADDR];
+       struct list_head poll_pending_link;
+       struct p9_poll_wait poll_wait[MAXPOLLWADDR];
        poll_table pt;
        struct work_struct rq;
        struct work_struct wq;
@@ -219,18 +211,16 @@ static void p9_read_work(struct work_struct *work);
 static void p9_write_work(struct work_struct *work);
 static void p9_pollwait(struct file *filp, wait_queue_head_t *wait_address,
                                                                poll_table *p);
-static int p9_fd_write(struct p9_trans *trans, void *v, int len);
-static int p9_fd_read(struct p9_trans *trans, void *v, int len);
+static int p9_fd_write(struct p9_client *client, void *v, int len);
+static int p9_fd_read(struct p9_client *client, void *v, int len);
 
-static DEFINE_MUTEX(p9_mux_task_lock);
+static DEFINE_SPINLOCK(p9_poll_lock);
+static LIST_HEAD(p9_poll_pending_list);
 static struct workqueue_struct *p9_mux_wq;
-
-static int p9_mux_num;
-static int p9_mux_poll_task_num;
-static struct p9_mux_poll_task p9_mux_poll_tasks[100];
+static struct task_struct *p9_poll_task;
 
 static void p9_conn_destroy(struct p9_conn *);
-static unsigned int p9_fd_poll(struct p9_trans *trans,
+static unsigned int p9_fd_poll(struct p9_client *client,
                                                struct poll_table_struct *pt);
 
 #ifdef P9_NONBLOCK
@@ -240,22 +230,6 @@ static int p9_conn_rpcnb(struct p9_conn *m, struct p9_fcall *tc,
 
 static void p9_conn_cancel(struct p9_conn *m, int err);
 
-static int p9_mux_global_init(void)
-{
-       int i;
-
-       for (i = 0; i < ARRAY_SIZE(p9_mux_poll_tasks); i++)
-               p9_mux_poll_tasks[i].task = NULL;
-
-       p9_mux_wq = create_workqueue("v9fs");
-       if (!p9_mux_wq) {
-               printk(KERN_WARNING "v9fs: mux: creating workqueue failed\n");
-               return -ENOMEM;
-       }
-
-       return 0;
-}
-
 static u16 p9_mux_get_tag(struct p9_conn *m)
 {
        int tag;
@@ -273,183 +247,59 @@ static void p9_mux_put_tag(struct p9_conn *m, u16 tag)
                p9_idpool_put(tag, m->tagpool);
 }
 
-/**
- * p9_mux_calc_poll_procs - calculates the number of polling procs
- * @muxnum: number of mounts
- *
- * Calculation is based on the number of mounted v9fs filesystems.
- * The current implementation returns sqrt of the number of mounts.
- */
-
-static int p9_mux_calc_poll_procs(int muxnum)
-{
-       int n;
-
-       if (p9_mux_poll_task_num)
-               n = muxnum / p9_mux_poll_task_num +
-                   (muxnum % p9_mux_poll_task_num ? 1 : 0);
-       else
-               n = 1;
-
-       if (n > ARRAY_SIZE(p9_mux_poll_tasks))
-               n = ARRAY_SIZE(p9_mux_poll_tasks);
-
-       return n;
-}
-
-static int p9_mux_poll_start(struct p9_conn *m)
+static void p9_mux_poll_stop(struct p9_conn *m)
 {
-       int i, n;
-       struct p9_mux_poll_task *vpt, *vptlast;
-       struct task_struct *pproc;
-
-       P9_DPRINTK(P9_DEBUG_MUX, "mux %p muxnum %d procnum %d\n", m, p9_mux_num,
-               p9_mux_poll_task_num);
-       mutex_lock(&p9_mux_task_lock);
-
-       n = p9_mux_calc_poll_procs(p9_mux_num + 1);
-       if (n > p9_mux_poll_task_num) {
-               for (i = 0; i < ARRAY_SIZE(p9_mux_poll_tasks); i++) {
-                       if (p9_mux_poll_tasks[i].task == NULL) {
-                               vpt = &p9_mux_poll_tasks[i];
-                               P9_DPRINTK(P9_DEBUG_MUX, "create proc %p\n",
-                                                                       vpt);
-                               pproc = kthread_create(p9_poll_proc, vpt,
-                                                               "v9fs-poll");
-
-                               if (!IS_ERR(pproc)) {
-                                       vpt->task = pproc;
-                                       INIT_LIST_HEAD(&vpt->mux_list);
-                                       vpt->muxnum = 0;
-                                       p9_mux_poll_task_num++;
-                                       wake_up_process(vpt->task);
-                               }
-                               break;
-                       }
-               }
-
-               if (i >= ARRAY_SIZE(p9_mux_poll_tasks))
-                       P9_DPRINTK(P9_DEBUG_ERROR,
-                                       "warning: no free poll slots\n");
-       }
+       unsigned long flags;
+       int i;
 
-       n = (p9_mux_num + 1) / p9_mux_poll_task_num +
-           ((p9_mux_num + 1) % p9_mux_poll_task_num ? 1 : 0);
-
-       vptlast = NULL;
-       for (i = 0; i < ARRAY_SIZE(p9_mux_poll_tasks); i++) {
-               vpt = &p9_mux_poll_tasks[i];
-               if (vpt->task != NULL) {
-                       vptlast = vpt;
-                       if (vpt->muxnum < n) {
-                               P9_DPRINTK(P9_DEBUG_MUX, "put in proc %d\n", i);
-                               list_add(&m->mux_list, &vpt->mux_list);
-                               vpt->muxnum++;
-                               m->poll_task = vpt;
-                               memset(&m->poll_waddr, 0,
-                                                       sizeof(m->poll_waddr));
-                               init_poll_funcptr(&m->pt, p9_pollwait);
-                               break;
-                       }
-               }
-       }
+       for (i = 0; i < ARRAY_SIZE(m->poll_wait); i++) {
+               struct p9_poll_wait *pwait = &m->poll_wait[i];
 
-       if (i >= ARRAY_SIZE(p9_mux_poll_tasks)) {
-               if (vptlast == NULL) {
-                       mutex_unlock(&p9_mux_task_lock);
-                       return -ENOMEM;
+               if (pwait->wait_addr) {
+                       remove_wait_queue(pwait->wait_addr, &pwait->wait);
+                       pwait->wait_addr = NULL;
                }
-
-               P9_DPRINTK(P9_DEBUG_MUX, "put in proc %d\n", i);
-               list_add(&m->mux_list, &vptlast->mux_list);
-               vptlast->muxnum++;
-               m->poll_task = vptlast;
-               memset(&m->poll_waddr, 0, sizeof(m->poll_waddr));
-               init_poll_funcptr(&m->pt, p9_pollwait);
        }
 
-       p9_mux_num++;
-       mutex_unlock(&p9_mux_task_lock);
-
-       return 0;
-}
-
-static void p9_mux_poll_stop(struct p9_conn *m)
-{
-       int i;
-       struct p9_mux_poll_task *vpt;
-
-       mutex_lock(&p9_mux_task_lock);
-       vpt = m->poll_task;
-       list_del(&m->mux_list);
-       for (i = 0; i < ARRAY_SIZE(m->poll_waddr); i++) {
-               if (m->poll_waddr[i] != NULL) {
-                       remove_wait_queue(m->poll_waddr[i], &m->poll_wait[i]);
-                       m->poll_waddr[i] = NULL;
-               }
-       }
-       vpt->muxnum--;
-       if (!vpt->muxnum) {
-               P9_DPRINTK(P9_DEBUG_MUX, "destroy proc %p\n", vpt);
-               kthread_stop(vpt->task);
-               vpt->task = NULL;
-               p9_mux_poll_task_num--;
-       }
-       p9_mux_num--;
-       mutex_unlock(&p9_mux_task_lock);
+       spin_lock_irqsave(&p9_poll_lock, flags);
+       list_del_init(&m->poll_pending_link);
+       spin_unlock_irqrestore(&p9_poll_lock, flags);
 }
 
 /**
  * p9_conn_create - allocate and initialize the per-session mux data
- * @trans: transport structure
+ * @client: client instance
  *
  * Note: Creates the polling task if this is the first session.
  */
 
-static struct p9_conn *p9_conn_create(struct p9_trans *trans)
+static struct p9_conn *p9_conn_create(struct p9_client *client)
 {
        int i, n;
-       struct p9_conn *m, *mtmp;
+       struct p9_conn *m;
 
-       P9_DPRINTK(P9_DEBUG_MUX, "transport %p msize %d\n", trans,
-                                                               trans->msize);
-       m = kmalloc(sizeof(struct p9_conn), GFP_KERNEL);
+       P9_DPRINTK(P9_DEBUG_MUX, "client %p msize %d\n", client, client->msize);
+       m = kzalloc(sizeof(struct p9_conn), GFP_KERNEL);
        if (!m)
                return ERR_PTR(-ENOMEM);
 
        spin_lock_init(&m->lock);
        INIT_LIST_HEAD(&m->mux_list);
-       m->msize = trans->msize;
-       m->extended = trans->extended;
-       m->trans = trans;
+       m->client = client;
        m->tagpool = p9_idpool_create();
        if (IS_ERR(m->tagpool)) {
-               mtmp = ERR_PTR(-ENOMEM);
                kfree(m);
-               return mtmp;
+               return ERR_PTR(-ENOMEM);
        }
 
-       m->err = 0;
-       init_waitqueue_head(&m->equeue);
        INIT_LIST_HEAD(&m->req_list);
        INIT_LIST_HEAD(&m->unsent_req_list);
-       m->rcall = NULL;
-       m->rpos = 0;
-       m->rbuf = NULL;
-       m->wpos = m->wsize = 0;
-       m->wbuf = NULL;
        INIT_WORK(&m->rq, p9_read_work);
        INIT_WORK(&m->wq, p9_write_work);
-       m->wsched = 0;
-       memset(&m->poll_waddr, 0, sizeof(m->poll_waddr));
-       m->poll_task = NULL;
-       n = p9_mux_poll_start(m);
-       if (n) {
-               kfree(m);
-               return ERR_PTR(n);
-       }
+       INIT_LIST_HEAD(&m->poll_pending_link);
+       init_poll_funcptr(&m->pt, p9_pollwait);
 
-       n = p9_fd_poll(trans, &m->pt);
+       n = p9_fd_poll(client, &m->pt);
        if (n & POLLIN) {
                P9_DPRINTK(P9_DEBUG_MUX, "mux %p can read\n", m);
                set_bit(Rpending, &m->wsched);
@@ -460,13 +310,12 @@ static struct p9_conn *p9_conn_create(struct p9_trans *trans)
                set_bit(Wpending, &m->wsched);
        }
 
-       for (i = 0; i < ARRAY_SIZE(m->poll_waddr); i++) {
-               if (IS_ERR(m->poll_waddr[i])) {
+       for (i = 0; i < ARRAY_SIZE(m->poll_wait); i++) {
+               if (IS_ERR(m->poll_wait[i].wait_addr)) {
                        p9_mux_poll_stop(m);
-                       mtmp = (void *)m->poll_waddr;   /* the error code */
                        kfree(m);
-                       m = mtmp;
-                       break;
+                       /* return the error code */
+                       return (void *)m->poll_wait[i].wait_addr;
                }
        }
 
@@ -483,23 +332,35 @@ static void p9_conn_destroy(struct p9_conn *m)
 {
        P9_DPRINTK(P9_DEBUG_MUX, "mux %p prev %p next %p\n", m,
                m->mux_list.prev, m->mux_list.next);
-       p9_conn_cancel(m, -ECONNRESET);
-
-       if (!list_empty(&m->req_list)) {
-               /* wait until all processes waiting on this session exit */
-               P9_DPRINTK(P9_DEBUG_MUX,
-                       "mux %p waiting for empty request queue\n", m);
-               wait_event_timeout(m->equeue, (list_empty(&m->req_list)), 5000);
-               P9_DPRINTK(P9_DEBUG_MUX, "mux %p request queue empty: %d\n", m,
-                       list_empty(&m->req_list));
-       }
 
        p9_mux_poll_stop(m);
-       m->trans = NULL;
+       cancel_work_sync(&m->rq);
+       cancel_work_sync(&m->wq);
+
+       p9_conn_cancel(m, -ECONNRESET);
+
+       m->client = NULL;
        p9_idpool_destroy(m->tagpool);
        kfree(m);
 }
 
+static int p9_pollwake(wait_queue_t *wait, unsigned mode, int sync, void *key)
+{
+       struct p9_poll_wait *pwait =
+               container_of(wait, struct p9_poll_wait, wait);
+       struct p9_conn *m = pwait->conn;
+       unsigned long flags;
+       DECLARE_WAITQUEUE(dummy_wait, p9_poll_task);
+
+       spin_lock_irqsave(&p9_poll_lock, flags);
+       if (list_empty(&m->poll_pending_link))
+               list_add_tail(&m->poll_pending_link, &p9_poll_pending_list);
+       spin_unlock_irqrestore(&p9_poll_lock, flags);
+
+       /* perform the default wake up operation */
+       return default_wake_function(&dummy_wait, mode, sync, key);
+}
+
 /**
  * p9_pollwait - add poll task to the wait queue
  * @filp: file pointer being polled
@@ -512,29 +373,32 @@ static void p9_conn_destroy(struct p9_conn *m)
 static void
 p9_pollwait(struct file *filp, wait_queue_head_t *wait_address, poll_table *p)
 {
+       struct p9_conn *m = container_of(p, struct p9_conn, pt);
+       struct p9_poll_wait *pwait = NULL;
        int i;
-       struct p9_conn *m;
 
-       m = container_of(p, struct p9_conn, pt);
-       for (i = 0; i < ARRAY_SIZE(m->poll_waddr); i++)
-               if (m->poll_waddr[i] == NULL)
+       for (i = 0; i < ARRAY_SIZE(m->poll_wait); i++) {
+               if (m->poll_wait[i].wait_addr == NULL) {
+                       pwait = &m->poll_wait[i];
                        break;
+               }
+       }
 
-       if (i >= ARRAY_SIZE(m->poll_waddr)) {
+       if (!pwait) {
                P9_DPRINTK(P9_DEBUG_ERROR, "not enough wait_address slots\n");
                return;
        }
 
-       m->poll_waddr[i] = wait_address;
-
        if (!wait_address) {
                P9_DPRINTK(P9_DEBUG_ERROR, "no wait_address\n");
-               m->poll_waddr[i] = ERR_PTR(-EIO);
+               pwait->wait_addr = ERR_PTR(-EIO);
                return;
        }
 
-       init_waitqueue_entry(&m->poll_wait[i], m->poll_task->task);
-       add_wait_queue(wait_address, &m->poll_wait[i]);
+       pwait->conn = m;
+       pwait->wait_addr = wait_address;
+       init_waitqueue_func_entry(&pwait->wait, p9_pollwake);
+       add_wait_queue(wait_address, &pwait->wait);
 }
 
 /**
@@ -550,7 +414,7 @@ static void p9_poll_mux(struct p9_conn *m)
        if (m->err < 0)
                return;
 
-       n = p9_fd_poll(m->trans, NULL);
+       n = p9_fd_poll(m->client, NULL);
        if (n < 0 || n & (POLLERR | POLLHUP | POLLNVAL)) {
                P9_DPRINTK(P9_DEBUG_MUX, "error mux %p err %d\n", m, n);
                if (n >= 0)
@@ -589,23 +453,34 @@ static void p9_poll_mux(struct p9_conn *m)
 
 static int p9_poll_proc(void *a)
 {
-       struct p9_conn *m, *mtmp;
-       struct p9_mux_poll_task *vpt;
+       unsigned long flags;
 
-       vpt = a;
-       P9_DPRINTK(P9_DEBUG_MUX, "start %p %p\n", current, vpt);
-       while (!kthread_should_stop()) {
-               set_current_state(TASK_INTERRUPTIBLE);
+       P9_DPRINTK(P9_DEBUG_MUX, "start %p\n", current);
+ repeat:
+       spin_lock_irqsave(&p9_poll_lock, flags);
+       while (!list_empty(&p9_poll_pending_list)) {
+               struct p9_conn *conn = list_first_entry(&p9_poll_pending_list,
+                                                       struct p9_conn,
+                                                       poll_pending_link);
+               list_del_init(&conn->poll_pending_link);
+               spin_unlock_irqrestore(&p9_poll_lock, flags);
 
-               list_for_each_entry_safe(m, mtmp, &vpt->mux_list, mux_list) {
-                       p9_poll_mux(m);
-               }
+               p9_poll_mux(conn);
 
-               P9_DPRINTK(P9_DEBUG_MUX, "sleeping...\n");
-               schedule_timeout(SCHED_TIMEOUT * HZ);
+               spin_lock_irqsave(&p9_poll_lock, flags);
        }
+       spin_unlock_irqrestore(&p9_poll_lock, flags);
 
+       set_current_state(TASK_INTERRUPTIBLE);
+       if (list_empty(&p9_poll_pending_list)) {
+               P9_DPRINTK(P9_DEBUG_MUX, "sleeping...\n");
+               schedule();
+       }
        __set_current_state(TASK_RUNNING);
+
+       if (!kthread_should_stop())
+               goto repeat;
+
        P9_DPRINTK(P9_DEBUG_MUX, "finish\n");
        return 0;
 }
@@ -652,7 +527,7 @@ again:
        P9_DPRINTK(P9_DEBUG_MUX, "mux %p pos %d size %d\n", m, m->wpos,
                                                                m->wsize);
        clear_bit(Wpending, &m->wsched);
-       err = p9_fd_write(m->trans, m->wbuf + m->wpos, m->wsize - m->wpos);
+       err = p9_fd_write(m->client, m->wbuf + m->wpos, m->wsize - m->wpos);
        P9_DPRINTK(P9_DEBUG_MUX, "mux %p sent %d bytes\n", m, err);
        if (err == -EAGAIN) {
                clear_bit(Wworksched, &m->wsched);
@@ -674,7 +549,7 @@ again:
                if (test_and_clear_bit(Wpending, &m->wsched))
                        n = POLLOUT;
                else
-                       n = p9_fd_poll(m->trans, NULL);
+                       n = p9_fd_poll(m->client, NULL);
 
                if (n & POLLOUT) {
                        P9_DPRINTK(P9_DEBUG_MUX, "schedule write work %p\n", m);
@@ -703,7 +578,7 @@ static void process_request(struct p9_conn *m, struct p9_req *req)
                P9_DPRINTK(P9_DEBUG_MUX, "Rerror %.*s\n", ename->len,
                                                                ename->str);
 
-               if (m->extended)
+               if (m->client->dotu)
                        req->err = -ecode;
 
                if (!req->err) {
@@ -748,7 +623,8 @@ static void p9_read_work(struct work_struct *work)
 
        if (!m->rcall) {
                m->rcall =
-                   kmalloc(sizeof(struct p9_fcall) + m->msize, GFP_KERNEL);
+                   kmalloc(sizeof(struct p9_fcall) + m->client->msize,
+                                                               GFP_KERNEL);
                if (!m->rcall) {
                        err = -ENOMEM;
                        goto error;
@@ -759,7 +635,8 @@ static void p9_read_work(struct work_struct *work)
        }
 
        clear_bit(Rpending, &m->wsched);
-       err = p9_fd_read(m->trans, m->rbuf + m->rpos, m->msize - m->rpos);
+       err = p9_fd_read(m->client, m->rbuf + m->rpos,
+                                               m->client->msize - m->rpos);
        P9_DPRINTK(P9_DEBUG_MUX, "mux %p got %d bytes\n", m, err);
        if (err == -EAGAIN) {
                clear_bit(Rworksched, &m->wsched);
@@ -772,7 +649,7 @@ static void p9_read_work(struct work_struct *work)
        m->rpos += err;
        while (m->rpos > 4) {
                n = le32_to_cpu(*(__le32 *) m->rbuf);
-               if (n >= m->msize) {
+               if (n >= m->client->msize) {
                        P9_DPRINTK(P9_DEBUG_ERROR,
                                "requested packet size too big: %d\n", n);
                        err = -EIO;
@@ -783,7 +660,7 @@ static void p9_read_work(struct work_struct *work)
                        break;
 
                err =
-                   p9_deserialize_fcall(m->rbuf, n, m->rcall, m->extended);
+                   p9_deserialize_fcall(m->rbuf, n, m->rcall, m->client->dotu);
                if (err < 0)
                        goto error;
 
@@ -792,7 +669,7 @@ static void p9_read_work(struct work_struct *work)
                        char buf[150];
 
                        p9_printfcall(buf, sizeof(buf), m->rcall,
-                               m->extended);
+                               m->client->dotu);
                        printk(KERN_NOTICE ">>> %p %s\n", m, buf);
                }
 #endif
@@ -800,8 +677,8 @@ static void p9_read_work(struct work_struct *work)
                rcall = m->rcall;
                rbuf = m->rbuf;
                if (m->rpos > n) {
-                       m->rcall = kmalloc(sizeof(struct p9_fcall) + m->msize,
-                                          GFP_KERNEL);
+                       m->rcall = kmalloc(sizeof(struct p9_fcall) +
+                                               m->client->msize, GFP_KERNEL);
                        if (!m->rcall) {
                                err = -ENOMEM;
                                goto error;
@@ -840,8 +717,6 @@ static void p9_read_work(struct work_struct *work)
                                        (*req->cb) (req, req->cba);
                                else
                                        kfree(req->rcall);
-
-                               wake_up(&m->equeue);
                        }
                } else {
                        if (err >= 0 && rcall->id != P9_RFLUSH)
@@ -856,7 +731,7 @@ static void p9_read_work(struct work_struct *work)
                if (test_and_clear_bit(Rpending, &m->wsched))
                        n = POLLIN;
                else
-                       n = p9_fd_poll(m->trans, NULL);
+                       n = p9_fd_poll(m->client, NULL);
 
                if (n & POLLIN) {
                        P9_DPRINTK(P9_DEBUG_MUX, "schedule read work %p\n", m);
@@ -908,8 +783,10 @@ static struct p9_req *p9_send_request(struct p9_conn *m,
        else
                n = p9_mux_get_tag(m);
 
-       if (n < 0)
+       if (n < 0) {
+               kfree(req);
                return ERR_PTR(-ENOMEM);
+       }
 
        p9_set_tag(tc, n);
 
@@ -917,7 +794,7 @@ static struct p9_req *p9_send_request(struct p9_conn *m,
        if ((p9_debug_level&P9_DEBUG_FCALL) == P9_DEBUG_FCALL) {
                char buf[150];
 
-               p9_printfcall(buf, sizeof(buf), tc, m->extended);
+               p9_printfcall(buf, sizeof(buf), tc, m->client->dotu);
                printk(KERN_NOTICE "<<< %p %s\n", m, buf);
        }
 #endif
@@ -938,7 +815,7 @@ static struct p9_req *p9_send_request(struct p9_conn *m,
        if (test_and_clear_bit(Wpending, &m->wsched))
                n = POLLOUT;
        else
-               n = p9_fd_poll(m->trans, NULL);
+               n = p9_fd_poll(m->client, NULL);
 
        if (n & POLLOUT && !test_and_set_bit(Wworksched, &m->wsched))
                queue_work(p9_mux_wq, &m->wq);
@@ -984,8 +861,6 @@ static void p9_mux_flush_cb(struct p9_req *freq, void *a)
                        (*req->cb) (req, req->cba);
                else
                        kfree(req->rcall);
-
-               wake_up(&m->equeue);
        }
 
        kfree(freq->tcall);
@@ -1054,16 +929,16 @@ p9_conn_rpc_cb(struct p9_req *req, void *a)
 /**
  * p9_fd_rpc- sends 9P request and waits until a response is available.
  *     The function can be interrupted.
- * @t: transport data
+ * @client: client instance
  * @tc: request to be sent
  * @rc: pointer where a pointer to the response is stored
  *
  */
 
 int
-p9_fd_rpc(struct p9_trans *t, struct p9_fcall *tc, struct p9_fcall **rc)
+p9_fd_rpc(struct p9_client *client, struct p9_fcall *tc, struct p9_fcall **rc)
 {
-       struct p9_trans_fd *p = t->priv;
+       struct p9_trans_fd *p = client->trans;
        struct p9_conn *m = p->conn;
        int err, sigpending;
        unsigned long flags;
@@ -1096,7 +971,7 @@ p9_fd_rpc(struct p9_trans *t, struct p9_fcall *tc, struct p9_fcall **rc)
        if (r.err < 0)
                err = r.err;
 
-       if (err == -ERESTARTSYS && m->trans->status == Connected
+       if (err == -ERESTARTSYS && client->status == Connected
                                                        && m->err == 0) {
                if (p9_mux_flush_request(m, req)) {
                        /* wait until we get response of the flush message */
@@ -1105,7 +980,7 @@ p9_fd_rpc(struct p9_trans *t, struct p9_fcall *tc, struct p9_fcall **rc)
                                err = wait_event_interruptible(r.wqueue,
                                        r.rcall || r.err);
                        } while (!r.rcall && !r.err && err == -ERESTARTSYS &&
-                               m->trans->status == Connected && !m->err);
+                               client->status == Connected && !m->err);
 
                        err = -ERESTARTSYS;
                }
@@ -1191,8 +1066,6 @@ void p9_conn_cancel(struct p9_conn *m, int err)
                else
                        kfree(req->rcall);
        }
-
-       wake_up(&m->equeue);
 }
 
 /**
@@ -1256,7 +1129,7 @@ static int parse_opts(char *params, struct p9_fd_opts *opts)
        return 0;
 }
 
-static int p9_fd_open(struct p9_trans *trans, int rfd, int wfd)
+static int p9_fd_open(struct p9_client *client, int rfd, int wfd)
 {
        struct p9_trans_fd *ts = kmalloc(sizeof(struct p9_trans_fd),
                                           GFP_KERNEL);
@@ -1274,13 +1147,13 @@ static int p9_fd_open(struct p9_trans *trans, int rfd, int wfd)
                return -EIO;
        }
 
-       trans->priv = ts;
-       trans->status = Connected;
+       client->trans = ts;
+       client->status = Connected;
 
        return 0;
 }
 
-static int p9_socket_open(struct p9_trans *trans, struct socket *csocket)
+static int p9_socket_open(struct p9_client *client, struct socket *csocket)
 {
        int fd, ret;
 
@@ -1291,33 +1164,33 @@ static int p9_socket_open(struct p9_trans *trans, struct socket *csocket)
                return fd;
        }
 
-       ret = p9_fd_open(trans, fd, fd);
+       ret = p9_fd_open(client, fd, fd);
        if (ret < 0) {
                P9_EPRINTK(KERN_ERR, "p9_socket_open: failed to open fd\n");
                sockfd_put(csocket);
                return ret;
        }
 
-       ((struct p9_trans_fd *)trans->priv)->rd->f_flags |= O_NONBLOCK;
+       ((struct p9_trans_fd *)client->trans)->rd->f_flags |= O_NONBLOCK;
 
        return 0;
 }
 
 /**
  * p9_fd_read- read from a fd
- * @trans: transport instance state
+ * @client: client instance
  * @v: buffer to receive data into
  * @len: size of receive buffer
  *
  */
 
-static int p9_fd_read(struct p9_trans *trans, void *v, int len)
+static int p9_fd_read(struct p9_client *client, void *v, int len)
 {
        int ret;
        struct p9_trans_fd *ts = NULL;
 
-       if (trans && trans->status != Disconnected)
-               ts = trans->priv;
+       if (client && client->status != Disconnected)
+               ts = client->trans;
 
        if (!ts)
                return -EREMOTEIO;
@@ -1327,26 +1200,26 @@ static int p9_fd_read(struct p9_trans *trans, void *v, int len)
 
        ret = kernel_read(ts->rd, ts->rd->f_pos, v, len);
        if (ret <= 0 && ret != -ERESTARTSYS && ret != -EAGAIN)
-               trans->status = Disconnected;
+               client->status = Disconnected;
        return ret;
 }
 
 /**
  * p9_fd_write - write to a socket
- * @trans: transport instance state
+ * @client: client instance
  * @v: buffer to send data from
  * @len: size of send buffer
  *
  */
 
-static int p9_fd_write(struct p9_trans *trans, void *v, int len)
+static int p9_fd_write(struct p9_client *client, void *v, int len)
 {
        int ret;
        mm_segment_t oldfs;
        struct p9_trans_fd *ts = NULL;
 
-       if (trans && trans->status != Disconnected)
-               ts = trans->priv;
+       if (client && client->status != Disconnected)
+               ts = client->trans;
 
        if (!ts)
                return -EREMOTEIO;
@@ -1361,19 +1234,18 @@ static int p9_fd_write(struct p9_trans *trans, void *v, int len)
        set_fs(oldfs);
 
        if (ret <= 0 && ret != -ERESTARTSYS && ret != -EAGAIN)
-               trans->status = Disconnected;
+               client->status = Disconnected;
        return ret;
 }
 
 static unsigned int
-p9_fd_poll(struct p9_trans *trans, struct poll_table_struct *pt)
+p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt)
 {
        int ret, n;
        struct p9_trans_fd *ts = NULL;
-       mm_segment_t oldfs;
 
-       if (trans && trans->status == Connected)
-               ts = trans->priv;
+       if (client && client->status == Connected)
+               ts = client->trans;
 
        if (!ts)
                return -EREMOTEIO;
@@ -1384,52 +1256,46 @@ p9_fd_poll(struct p9_trans *trans, struct poll_table_struct *pt)
        if (!ts->wr->f_op || !ts->wr->f_op->poll)
                return -EIO;
 
-       oldfs = get_fs();
-       set_fs(get_ds());
-
        ret = ts->rd->f_op->poll(ts->rd, pt);
        if (ret < 0)
-               goto end;
+               return ret;
 
        if (ts->rd != ts->wr) {
                n = ts->wr->f_op->poll(ts->wr, pt);
-               if (n < 0) {
-                       ret = n;
-                       goto end;
-               }
+               if (n < 0)
+                       return n;
                ret = (ret & ~POLLOUT) | (n & ~POLLIN);
        }
 
-end:
-       set_fs(oldfs);
        return ret;
 }
 
 /**
- * p9_fd_close - shutdown socket
- * @trans: private socket structure
+ * p9_fd_close - shutdown file descriptor transport
+ * @client: client instance
  *
  */
 
-static void p9_fd_close(struct p9_trans *trans)
+static void p9_fd_close(struct p9_client *client)
 {
        struct p9_trans_fd *ts;
 
-       if (!trans)
+       if (!client)
                return;
 
-       ts = xchg(&trans->priv, NULL);
-
+       ts = client->trans;
        if (!ts)
                return;
 
+       client->status = Disconnected;
+
        p9_conn_destroy(ts->conn);
 
-       trans->status = Disconnected;
        if (ts->rd)
                fput(ts->rd);
        if (ts->wr)
                fput(ts->wr);
+
        kfree(ts);
 }
 
@@ -1450,31 +1316,23 @@ static inline int valid_ipaddr4(const char *buf)
        return 0;
 }
 
-static struct p9_trans *
-p9_trans_create_tcp(const char *addr, char *args, int msize, unsigned char dotu)
+static int
+p9_fd_create_tcp(struct p9_client *client, const char *addr, char *args)
 {
        int err;
-       struct p9_trans *trans;
        struct socket *csocket;
        struct sockaddr_in sin_server;
        struct p9_fd_opts opts;
-       struct p9_trans_fd *p;
+       struct p9_trans_fd *p = NULL; /* this gets allocated in p9_fd_open */
 
        err = parse_opts(args, &opts);
        if (err < 0)
-               return ERR_PTR(err);
+               return err;
 
        if (valid_ipaddr4(addr) < 0)
-               return ERR_PTR(-EINVAL);
+               return -EINVAL;
 
        csocket = NULL;
-       trans = kmalloc(sizeof(struct p9_trans), GFP_KERNEL);
-       if (!trans)
-               return ERR_PTR(-ENOMEM);
-       trans->msize = msize;
-       trans->extended = dotu;
-       trans->rpc = p9_fd_rpc;
-       trans->close = p9_fd_close;
 
        sin_server.sin_family = AF_INET;
        sin_server.sin_addr.s_addr = in_aton(addr);
@@ -1497,45 +1355,38 @@ p9_trans_create_tcp(const char *addr, char *args, int msize, unsigned char dotu)
                goto error;
        }
 
-       err = p9_socket_open(trans, csocket);
+       err = p9_socket_open(client, csocket);
        if (err < 0)
                goto error;
 
-       p = (struct p9_trans_fd *) trans->priv;
-       p->conn = p9_conn_create(trans);
+       p = (struct p9_trans_fd *) client->trans;
+       p->conn = p9_conn_create(client);
        if (IS_ERR(p->conn)) {
                err = PTR_ERR(p->conn);
                p->conn = NULL;
                goto error;
        }
 
-       return trans;
+       return 0;
 
 error:
        if (csocket)
                sock_release(csocket);
 
-       kfree(trans);
-       return ERR_PTR(err);
+       kfree(p);
+
+       return err;
 }
 
-static struct p9_trans *
-p9_trans_create_unix(const char *addr, char *args, int msize,
-                                                       unsigned char dotu)
+static int
+p9_fd_create_unix(struct p9_client *client, const char *addr, char *args)
 {
        int err;
        struct socket *csocket;
        struct sockaddr_un sun_server;
-       struct p9_trans *trans;
-       struct p9_trans_fd *p;
+       struct p9_trans_fd *p = NULL; /* this gets allocated in p9_fd_open */
 
        csocket = NULL;
-       trans = kmalloc(sizeof(struct p9_trans), GFP_KERNEL);
-       if (!trans)
-               return ERR_PTR(-ENOMEM);
-
-       trans->rpc = p9_fd_rpc;
-       trans->close = p9_fd_close;
 
        if (strlen(addr) > UNIX_PATH_MAX) {
                P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n",
@@ -1556,101 +1407,104 @@ p9_trans_create_unix(const char *addr, char *args, int msize,
                goto error;
        }
 
-       err = p9_socket_open(trans, csocket);
+       err = p9_socket_open(client, csocket);
        if (err < 0)
                goto error;
 
-       trans->msize = msize;
-       trans->extended = dotu;
-       p = (struct p9_trans_fd *) trans->priv;
-       p->conn = p9_conn_create(trans);
+       p = (struct p9_trans_fd *) client->trans;
+       p->conn = p9_conn_create(client);
        if (IS_ERR(p->conn)) {
                err = PTR_ERR(p->conn);
                p->conn = NULL;
                goto error;
        }
 
-       return trans;
+       return 0;
 
 error:
        if (csocket)
                sock_release(csocket);
 
-       kfree(trans);
-       return ERR_PTR(err);
+       kfree(p);
+       return err;
 }
 
-static struct p9_trans *
-p9_trans_create_fd(const char *name, char *args, int msize,
-                                                       unsigned char extended)
+static int
+p9_fd_create(struct p9_client *client, const char *addr, char *args)
 {
        int err;
-       struct p9_trans *trans;
        struct p9_fd_opts opts;
-       struct p9_trans_fd *p;
+       struct p9_trans_fd *p = NULL; /* this get allocated in p9_fd_open */
 
        parse_opts(args, &opts);
 
        if (opts.rfd == ~0 || opts.wfd == ~0) {
                printk(KERN_ERR "v9fs: Insufficient options for proto=fd\n");
-               return ERR_PTR(-ENOPROTOOPT);
+               return -ENOPROTOOPT;
        }
 
-       trans = kmalloc(sizeof(struct p9_trans), GFP_KERNEL);
-       if (!trans)
-               return ERR_PTR(-ENOMEM);
-
-       trans->rpc = p9_fd_rpc;
-       trans->close = p9_fd_close;
-
-       err = p9_fd_open(trans, opts.rfd, opts.wfd);
+       err = p9_fd_open(client, opts.rfd, opts.wfd);
        if (err < 0)
                goto error;
 
-       trans->msize = msize;
-       trans->extended = extended;
-       p = (struct p9_trans_fd *) trans->priv;
-       p->conn = p9_conn_create(trans);
+       p = (struct p9_trans_fd *) client->trans;
+       p->conn = p9_conn_create(client);
        if (IS_ERR(p->conn)) {
                err = PTR_ERR(p->conn);
                p->conn = NULL;
                goto error;
        }
 
-       return trans;
+       return 0;
 
 error:
-       kfree(trans);
-       return ERR_PTR(err);
+       kfree(p);
+       return err;
 }
 
 static struct p9_trans_module p9_tcp_trans = {
        .name = "tcp",
        .maxsize = MAX_SOCK_BUF,
        .def = 1,
-       .create = p9_trans_create_tcp,
+       .create = p9_fd_create_tcp,
+       .close = p9_fd_close,
+       .rpc = p9_fd_rpc,
+       .owner = THIS_MODULE,
 };
 
 static struct p9_trans_module p9_unix_trans = {
        .name = "unix",
        .maxsize = MAX_SOCK_BUF,
        .def = 0,
-       .create = p9_trans_create_unix,
+       .create = p9_fd_create_unix,
+       .close = p9_fd_close,
+       .rpc = p9_fd_rpc,
+       .owner = THIS_MODULE,
 };
 
 static struct p9_trans_module p9_fd_trans = {
        .name = "fd",
        .maxsize = MAX_SOCK_BUF,
        .def = 0,
-       .create = p9_trans_create_fd,
+       .create = p9_fd_create,
+       .close = p9_fd_close,
+       .rpc = p9_fd_rpc,
+       .owner = THIS_MODULE,
 };
 
 int p9_trans_fd_init(void)
 {
-       int ret = p9_mux_global_init();
-       if (ret) {
-               printk(KERN_WARNING "9p: starting mux failed\n");
-               return ret;
+       p9_mux_wq = create_workqueue("v9fs");
+       if (!p9_mux_wq) {
+               printk(KERN_WARNING "v9fs: mux: creating workqueue failed\n");
+               return -ENOMEM;
+       }
+
+       p9_poll_task = kthread_run(p9_poll_proc, NULL, "v9fs-poll");
+       if (IS_ERR(p9_poll_task)) {
+               destroy_workqueue(p9_mux_wq);
+               printk(KERN_WARNING "v9fs: mux: creating poll task failed\n");
+               return PTR_ERR(p9_poll_task);
        }
 
        v9fs_register_trans(&p9_tcp_trans);
@@ -1659,4 +1513,13 @@ int p9_trans_fd_init(void)
 
        return 0;
 }
-EXPORT_SYMBOL(p9_trans_fd_init);
+
+void p9_trans_fd_exit(void)
+{
+       kthread_stop(p9_poll_task);
+       v9fs_unregister_trans(&p9_tcp_trans);
+       v9fs_unregister_trans(&p9_unix_trans);
+       v9fs_unregister_trans(&p9_fd_trans);
+
+       destroy_workqueue(p9_mux_wq);
+}