]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - net/mac80211/ieee80211_sta.c
[MAC80211]: make assoc_ap a flag
[linux-2.6-omap-h63xx.git] / net / mac80211 / ieee80211_sta.c
index 7ba352e3ffe0d451ad2bca62852e84a5b79b5d2e..1b4ebe81191c38fb0692e694553aae86a496ebdc 100644 (file)
@@ -234,7 +234,6 @@ static int ecw2cw(int ecw)
        return cw - 1;
 }
 
-
 static void ieee80211_sta_wmm_params(struct net_device *dev,
                                     struct ieee80211_if_sta *ifsta,
                                     u8 *wmm_param, size_t wmm_param_len)
@@ -318,8 +317,10 @@ static void ieee80211_handle_erp_ie(struct net_device *dev, u8 erp_value)
        struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
        struct ieee80211_if_sta *ifsta = &sdata->u.sta;
        int use_protection = (erp_value & WLAN_ERP_USE_PROTECTION) != 0;
+       int preamble_mode = (erp_value & WLAN_ERP_BARKER_PREAMBLE) != 0;
+       u8 changes = 0;
 
-       if (use_protection != sdata->use_protection) {
+       if (use_protection != !!(sdata->flags & IEEE80211_SDATA_USE_PROTECTION)) {
                if (net_ratelimit()) {
                        printk(KERN_DEBUG "%s: CTS protection %s (BSSID="
                               MAC_FMT ")\n",
@@ -327,8 +328,31 @@ static void ieee80211_handle_erp_ie(struct net_device *dev, u8 erp_value)
                               use_protection ? "enabled" : "disabled",
                               MAC_ARG(ifsta->bssid));
                }
-               sdata->use_protection = use_protection;
+               if (use_protection)
+                       sdata->flags |= IEEE80211_SDATA_USE_PROTECTION;
+               else
+                       sdata->flags &= ~IEEE80211_SDATA_USE_PROTECTION;
+               changes |= IEEE80211_ERP_CHANGE_PROTECTION;
+       }
+
+       if (preamble_mode != !(sdata->flags & IEEE80211_SDATA_SHORT_PREAMBLE)) {
+               if (net_ratelimit()) {
+                       printk(KERN_DEBUG "%s: switched to %s barker preamble"
+                              " (BSSID=" MAC_FMT ")\n",
+                              dev->name,
+                              (preamble_mode == WLAN_ERP_PREAMBLE_SHORT) ?
+                                       "short" : "long",
+                              MAC_ARG(ifsta->bssid));
+               }
+               if (preamble_mode)
+                       sdata->flags &= ~IEEE80211_SDATA_SHORT_PREAMBLE;
+               else
+                       sdata->flags |= IEEE80211_SDATA_SHORT_PREAMBLE;
+               changes |= IEEE80211_ERP_CHANGE_PREAMBLE;
        }
+
+       if (changes)
+               ieee80211_erp_info_change_notify(dev, changes);
 }
 
 
@@ -344,7 +368,7 @@ static void ieee80211_sta_send_associnfo(struct net_device *dev,
                return;
 
        buf = kmalloc(50 + 2 * (ifsta->assocreq_ies_len +
-                               ifsta->assocresp_ies_len), GFP_ATOMIC);
+                               ifsta->assocresp_ies_len), GFP_KERNEL);
        if (!buf)
                return;
 
@@ -384,19 +408,20 @@ static void ieee80211_sta_send_associnfo(struct net_device *dev,
 
 
 static void ieee80211_set_associated(struct net_device *dev,
-                                    struct ieee80211_if_sta *ifsta, int assoc)
+                                    struct ieee80211_if_sta *ifsta,
+                                    unsigned int assoc)
 {
        union iwreq_data wrqu;
-       struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
 
-       if (ifsta->associated == assoc)
+       if (!!(ifsta->flags & IEEE80211_STA_ASSOCIATED) == assoc)
                return;
 
-       ifsta->associated = assoc;
-
        if (assoc) {
                struct ieee80211_sub_if_data *sdata;
                struct ieee80211_sta_bss *bss;
+
+               ifsta->flags |= IEEE80211_STA_ASSOCIATED;
+
                sdata = IEEE80211_DEV_TO_SUB_IF(dev);
                if (sdata->type != IEEE80211_IF_TYPE_STA)
                        return;
@@ -409,13 +434,15 @@ static void ieee80211_set_associated(struct net_device *dev,
                }
 
                netif_carrier_on(dev);
-               ifsta->prev_bssid_set = 1;
+               ifsta->flags |= IEEE80211_STA_PREV_BSSID_SET;
                memcpy(ifsta->prev_bssid, sdata->u.sta.bssid, ETH_ALEN);
                memcpy(wrqu.ap_addr.sa_data, sdata->u.sta.bssid, ETH_ALEN);
                ieee80211_sta_send_associnfo(dev, ifsta);
        } else {
+               ifsta->flags &= ~IEEE80211_STA_ASSOCIATED;
+
                netif_carrier_off(dev);
-               sdata->use_protection = 0;
+               ieee80211_reset_erp_info(dev);
                memset(wrqu.ap_addr.sa_data, 0, ETH_ALEN);
        }
        wrqu.ap_addr.sa_family = ARPHRD_ETHER;
@@ -447,8 +474,10 @@ static void ieee80211_sta_tx(struct net_device *dev, struct sk_buff *skb,
        pkt_data = (struct ieee80211_tx_packet_data *) skb->cb;
        memset(pkt_data, 0, sizeof(struct ieee80211_tx_packet_data));
        pkt_data->ifindex = sdata->dev->ifindex;
-       pkt_data->mgmt_iface = (sdata->type == IEEE80211_IF_TYPE_MGMT);
-       pkt_data->do_not_encrypt = !encrypt;
+       if (sdata->type == IEEE80211_IF_TYPE_MGMT)
+               pkt_data->flags |= IEEE80211_TXPD_MGMT_IFACE;
+       if (!encrypt)
+               pkt_data->flags |= IEEE80211_TXPD_DO_NOT_ENCRYPT;
 
        dev_queue_xmit(skb);
 }
@@ -559,7 +588,7 @@ static void ieee80211_send_assoc(struct net_device *dev,
        memcpy(mgmt->sa, dev->dev_addr, ETH_ALEN);
        memcpy(mgmt->bssid, ifsta->bssid, ETH_ALEN);
 
-       if (ifsta->prev_bssid_set) {
+       if (ifsta->flags & IEEE80211_STA_PREV_BSSID_SET) {
                skb_put(skb, 10);
                mgmt->frame_control = IEEE80211_FC(IEEE80211_FTYPE_MGMT,
                                                   IEEE80211_STYPE_REASSOC_REQ);
@@ -611,7 +640,7 @@ static void ieee80211_send_assoc(struct net_device *dev,
                memcpy(pos, ifsta->extra_ie, ifsta->extra_ie_len);
        }
 
-       if (wmm && ifsta->wmm_enabled) {
+       if (wmm && (ifsta->flags & IEEE80211_STA_WMM_ENABLED)) {
                pos = skb_put(skb, 9);
                *pos++ = WLAN_EID_VENDOR_SPECIFIC;
                *pos++ = 7; /* len */
@@ -626,7 +655,7 @@ static void ieee80211_send_assoc(struct net_device *dev,
 
        kfree(ifsta->assocreq_ies);
        ifsta->assocreq_ies_len = (skb->data + skb->len) - ies;
-       ifsta->assocreq_ies = kmalloc(ifsta->assocreq_ies_len, GFP_ATOMIC);
+       ifsta->assocreq_ies = kmalloc(ifsta->assocreq_ies_len, GFP_KERNEL);
        if (ifsta->assocreq_ies)
                memcpy(ifsta->assocreq_ies, ies, ifsta->assocreq_ies_len);
 
@@ -698,8 +727,8 @@ static int ieee80211_privacy_mismatch(struct net_device *dev,
        struct ieee80211_sta_bss *bss;
        int res = 0;
 
-       if (!ifsta || ifsta->mixed_cell ||
-           ifsta->key_mgmt != IEEE80211_KEY_MGMT_NONE)
+       if (!ifsta || (ifsta->flags & IEEE80211_STA_MIXED_CELL) ||
+           ifsta->key_management_enabled)
                return 0;
 
        bss = ieee80211_rx_bss_get(dev, ifsta->bssid);
@@ -767,22 +796,20 @@ static void ieee80211_associated(struct net_device *dev,
                disassoc = 0;
                if (time_after(jiffies,
                               sta->last_rx + IEEE80211_MONITORING_INTERVAL)) {
-                       if (ifsta->probereq_poll) {
+                       if (ifsta->flags & IEEE80211_STA_PROBEREQ_POLL) {
                                printk(KERN_DEBUG "%s: No ProbeResp from "
                                       "current AP " MAC_FMT " - assume out of "
                                       "range\n",
                                       dev->name, MAC_ARG(ifsta->bssid));
                                disassoc = 1;
-                               sta_info_free(sta, 0);
-                               ifsta->probereq_poll = 0;
-                       } else {
+                               sta_info_free(sta);
+                       } else
                                ieee80211_send_probe_req(dev, ifsta->bssid,
                                                         local->scan_ssid,
                                                         local->scan_ssid_len);
-                               ifsta->probereq_poll = 1;
-                       }
+                       ifsta->flags ^= IEEE80211_STA_PROBEREQ_POLL;
                } else {
-                       ifsta->probereq_poll = 0;
+                       ifsta->flags &= ~IEEE80211_STA_PROBEREQ_POLL;
                        if (time_after(jiffies, ifsta->last_probe +
                                       IEEE80211_PROBE_INTERVAL)) {
                                ifsta->last_probe = jiffies;
@@ -876,7 +903,7 @@ static int ieee80211_sta_wep_configured(struct net_device *dev)
 {
        struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
        if (!sdata || !sdata->default_key ||
-           sdata->default_key->alg != ALG_WEP)
+           sdata->default_key->conf.alg != ALG_WEP)
                return 0;
        return 1;
 }
@@ -886,7 +913,7 @@ static void ieee80211_auth_completed(struct net_device *dev,
                                     struct ieee80211_if_sta *ifsta)
 {
        printk(KERN_DEBUG "%s: authenticated\n", dev->name);
-       ifsta->authenticated = 1;
+       ifsta->flags |= IEEE80211_STA_AUTHENTICATED;
        ieee80211_associate(dev, ifsta);
 }
 
@@ -1073,7 +1100,7 @@ static void ieee80211_rx_mgmt_deauth(struct net_device *dev,
               " (reason=%d)\n",
               dev->name, MAC_ARG(mgmt->sa), reason_code);
 
-       if (ifsta->authenticated) {
+       if (ifsta->flags & IEEE80211_STA_AUTHENTICATED) {
                printk(KERN_DEBUG "%s: deauthenticated\n", dev->name);
        }
 
@@ -1086,7 +1113,7 @@ static void ieee80211_rx_mgmt_deauth(struct net_device *dev,
        }
 
        ieee80211_set_disassoc(dev, ifsta, 1);
-       ifsta->authenticated = 0;
+       ifsta->flags &= ~IEEE80211_STA_AUTHENTICATED;
 }
 
 
@@ -1118,7 +1145,7 @@ static void ieee80211_rx_mgmt_disassoc(struct net_device *dev,
               " (reason=%d)\n",
               dev->name, MAC_ARG(mgmt->sa), reason_code);
 
-       if (ifsta->associated)
+       if (ifsta->flags & IEEE80211_STA_ASSOCIATED)
                printk(KERN_DEBUG "%s: disassociated\n", dev->name);
 
        if (ifsta->state == IEEE80211_ASSOCIATED) {
@@ -1187,8 +1214,10 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
        if (status_code != WLAN_STATUS_SUCCESS) {
                printk(KERN_DEBUG "%s: AP denied association (code=%d)\n",
                       dev->name, status_code);
-               if (status_code == WLAN_STATUS_REASSOC_NO_ASSOC)
-                       ifsta->prev_bssid_set = 0;
+               /* if this was a reassociation, ensure we try a "full"
+                * association next time. This works around some broken APs
+                * which do not correctly reject reassociation requests. */
+               ifsta->flags &= ~IEEE80211_STA_PREV_BSSID_SET;
                return;
        }
 
@@ -1224,7 +1253,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
 
        kfree(ifsta->assocresp_ies);
        ifsta->assocresp_ies_len = len - (pos - (u8 *) mgmt);
-       ifsta->assocresp_ies = kmalloc(ifsta->assocresp_ies_len, GFP_ATOMIC);
+       ifsta->assocresp_ies = kmalloc(ifsta->assocresp_ies_len, GFP_KERNEL);
        if (ifsta->assocresp_ies)
                memcpy(ifsta->assocresp_ies, pos, ifsta->assocresp_ies_len);
 
@@ -1234,7 +1263,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
        sta = sta_info_get(local, ifsta->bssid);
        if (!sta) {
                struct ieee80211_sta_bss *bss;
-               sta = sta_info_add(local, dev, ifsta->bssid, GFP_ATOMIC);
+               sta = sta_info_add(local, dev, ifsta->bssid, GFP_KERNEL);
                if (!sta) {
                        printk(KERN_DEBUG "%s: failed to add STA entry for the"
                               " AP\n", dev->name);
@@ -1250,8 +1279,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
        }
 
        sta->dev = dev;
-       sta->flags |= WLAN_STA_AUTH | WLAN_STA_ASSOC;
-       sta->assoc_ap = 1;
+       sta->flags |= WLAN_STA_AUTH | WLAN_STA_ASSOC | WLAN_STA_ASSOC_AP;
 
        rates = 0;
        mode = local->oper_hw_mode;
@@ -1275,7 +1303,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
 
        rate_control_rate_init(sta, local);
 
-       if (elems.wmm_param && ifsta->wmm_enabled) {
+       if (elems.wmm_param && (ifsta->flags & IEEE80211_STA_WMM_ENABLED)) {
                sta->flags |= WLAN_STA_WME;
                ieee80211_sta_wmm_params(dev, ifsta, elems.wmm_param,
                                         elems.wmm_param_len);
@@ -1672,7 +1700,7 @@ static void ieee80211_rx_mgmt_beacon(struct net_device *dev,
                return;
        ifsta = &sdata->u.sta;
 
-       if (!ifsta->associated ||
+       if (!(ifsta->flags & IEEE80211_STA_ASSOCIATED) ||
            memcmp(ifsta->bssid, mgmt->bssid, ETH_ALEN) != 0)
                return;
 
@@ -1688,7 +1716,7 @@ static void ieee80211_rx_mgmt_beacon(struct net_device *dev,
        if (elems.erp_info && elems.erp_info_len >= 1)
                ieee80211_handle_erp_ie(dev, elems.erp_info[0]);
 
-       if (elems.wmm_param && ifsta->wmm_enabled) {
+       if (elems.wmm_param && (ifsta->flags & IEEE80211_STA_WMM_ENABLED)) {
                ieee80211_sta_wmm_params(dev, ifsta, elems.wmm_param,
                                         elems.wmm_param_len);
        }
@@ -1751,7 +1779,7 @@ static void ieee80211_rx_mgmt_probe_req(struct net_device *dev,
        }
 
        /* Reply with ProbeResp */
-       skb = skb_copy(ifsta->probe_resp, GFP_ATOMIC);
+       skb = skb_copy(ifsta->probe_resp, GFP_KERNEL);
        if (!skb)
                return;
 
@@ -1890,7 +1918,7 @@ static int ieee80211_sta_active_ibss(struct net_device *dev)
        int active = 0;
        struct sta_info *sta;
 
-       spin_lock_bh(&local->sta_lock);
+       read_lock_bh(&local->sta_lock);
        list_for_each_entry(sta, &local->sta_list, list) {
                if (sta->dev == dev &&
                    time_after(sta->last_rx + IEEE80211_IBSS_MERGE_INTERVAL,
@@ -1899,7 +1927,7 @@ static int ieee80211_sta_active_ibss(struct net_device *dev)
                        break;
                }
        }
-       spin_unlock_bh(&local->sta_lock);
+       read_unlock_bh(&local->sta_lock);
 
        return active;
 }
@@ -1909,16 +1937,24 @@ static void ieee80211_sta_expire(struct net_device *dev)
 {
        struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
        struct sta_info *sta, *tmp;
+       LIST_HEAD(tmp_list);
 
-       spin_lock_bh(&local->sta_lock);
+       write_lock_bh(&local->sta_lock);
        list_for_each_entry_safe(sta, tmp, &local->sta_list, list)
                if (time_after(jiffies, sta->last_rx +
                               IEEE80211_IBSS_INACTIVITY_LIMIT)) {
                        printk(KERN_DEBUG "%s: expiring inactive STA " MAC_FMT
                               "\n", dev->name, MAC_ARG(sta->addr));
-                       sta_info_free(sta, 1);
+                       __sta_info_get(sta);
+                       sta_info_remove(sta);
+                       list_add(&sta->list, &tmp_list);
                }
-       spin_unlock_bh(&local->sta_lock);
+       write_unlock_bh(&local->sta_lock);
+
+       list_for_each_entry_safe(sta, tmp, &tmp_list, list) {
+               sta_info_free(sta);
+               sta_info_put(sta);
+       }
 }
 
 
@@ -2047,7 +2083,8 @@ static void ieee80211_sta_reset_auth(struct net_device *dev,
        printk(KERN_DEBUG "%s: Initial auth_alg=%d\n", dev->name,
               ifsta->auth_alg);
        ifsta->auth_transaction = -1;
-       ifsta->associated = ifsta->auth_tries = ifsta->assoc_tries = 0;
+       ifsta->flags &= ~IEEE80211_STA_ASSOCIATED;
+       ifsta->auth_tries = ifsta->assoc_tries = 0;
        netif_carrier_off(dev);
 }
 
@@ -2061,8 +2098,10 @@ void ieee80211_sta_req_auth(struct net_device *dev,
        if (sdata->type != IEEE80211_IF_TYPE_STA)
                return;
 
-       if ((ifsta->bssid_set || ifsta->auto_bssid_sel) &&
-           (ifsta->ssid_set || ifsta->auto_ssid_sel)) {
+       if ((ifsta->flags & (IEEE80211_STA_BSSID_SET |
+                               IEEE80211_STA_AUTO_BSSID_SEL)) &&
+           (ifsta->flags & (IEEE80211_STA_SSID_SET |
+                               IEEE80211_STA_AUTO_SSID_SEL))) {
                set_bit(IEEE80211_STA_REQ_AUTH, &ifsta->request);
                queue_work(local->hw.workqueue, &ifsta->work);
        }
@@ -2076,7 +2115,7 @@ static int ieee80211_sta_match_ssid(struct ieee80211_if_sta *ifsta,
        if (!memcmp(ifsta->ssid, ssid, ssid_len))
                return 1;
 
-       if (ifsta->auto_bssid_sel)
+       if (ifsta->flags & IEEE80211_STA_AUTO_BSSID_SEL)
                return 0;
 
        hidden_ssid = 1;
@@ -2105,8 +2144,8 @@ static int ieee80211_sta_config_auth(struct net_device *dev,
        struct ieee80211_sta_bss *bss, *selected = NULL;
        int top_rssi = 0, freq;
 
-       if (!ifsta->auto_channel_sel && !ifsta->auto_bssid_sel &&
-           !ifsta->auto_ssid_sel) {
+       if (!(ifsta->flags & (IEEE80211_STA_AUTO_SSID_SEL |
+           IEEE80211_STA_AUTO_BSSID_SEL | IEEE80211_STA_AUTO_CHANNEL_SEL))) {
                ifsta->state = IEEE80211_AUTHENTICATE;
                ieee80211_sta_reset_auth(dev, ifsta);
                return 0;
@@ -2122,14 +2161,15 @@ static int ieee80211_sta_config_auth(struct net_device *dev,
                    !!sdata->default_key)
                        continue;
 
-               if (!ifsta->auto_channel_sel && bss->freq != freq)
+               if (!(ifsta->flags & IEEE80211_STA_AUTO_CHANNEL_SEL) &&
+                   bss->freq != freq)
                        continue;
 
-               if (!ifsta->auto_bssid_sel &&
+               if (!(ifsta->flags & IEEE80211_STA_AUTO_BSSID_SEL) &&
                    memcmp(bss->bssid, ifsta->bssid, ETH_ALEN))
                        continue;
 
-               if (!ifsta->auto_ssid_sel &&
+               if (!(ifsta->flags & IEEE80211_STA_AUTO_SSID_SEL) &&
                    !ieee80211_sta_match_ssid(ifsta, bss->ssid, bss->ssid_len))
                        continue;
 
@@ -2144,7 +2184,7 @@ static int ieee80211_sta_config_auth(struct net_device *dev,
 
        if (selected) {
                ieee80211_set_channel(local, -1, selected->freq);
-               if (!ifsta->ssid_set)
+               if (!(ifsta->flags & IEEE80211_STA_SSID_SET))
                        ieee80211_sta_set_ssid(dev, selected->ssid,
                                               selected->ssid_len);
                ieee80211_sta_set_bssid(dev, selected->bssid);
@@ -2154,7 +2194,11 @@ static int ieee80211_sta_config_auth(struct net_device *dev,
                return 0;
        } else {
                if (ifsta->state != IEEE80211_AUTHENTICATE) {
-                       ieee80211_sta_start_scan(dev, NULL, 0);
+                       if (ifsta->flags & IEEE80211_STA_AUTO_SSID_SEL)
+                               ieee80211_sta_start_scan(dev, NULL, 0);
+                       else
+                               ieee80211_sta_start_scan(dev, ifsta->ssid,
+                                                        ifsta->ssid_len);
                        ifsta->state = IEEE80211_AUTHENTICATE;
                        set_bit(IEEE80211_STA_REQ_AUTH, &ifsta->request);
                } else
@@ -2267,8 +2311,9 @@ static int ieee80211_sta_join_ibss(struct net_device *dev,
                               "for IBSS beacon\n", dev->name);
                        break;
                }
-               control.tx_rate = (local->short_preamble &&
-                                  (rate->flags & IEEE80211_RATE_PREAMBLE2)) ?
+               control.tx_rate =
+                       ((sdata->flags & IEEE80211_SDATA_SHORT_PREAMBLE) &&
+                       (rate->flags & IEEE80211_RATE_PREAMBLE2)) ?
                        rate->val2 : rate->val;
                control.antenna_sel_tx = local->hw.conf.antenna_sel_tx;
                control.power_level = local->hw.conf.power_level;
@@ -2447,10 +2492,10 @@ static int ieee80211_sta_find_ibss(struct net_device *dev,
 
                if (time_after(jiffies, ifsta->ibss_join_req +
                               IEEE80211_IBSS_JOIN_TIMEOUT)) {
-                       if (ifsta->create_ibss &&
+                       if ((ifsta->flags & IEEE80211_STA_CREATE_IBSS) &&
                            local->oper_channel->flag & IEEE80211_CHAN_W_IBSS)
                                return ieee80211_sta_create_ibss(dev, ifsta);
-                       if (ifsta->create_ibss) {
+                       if (ifsta->flags & IEEE80211_STA_CREATE_IBSS) {
                                printk(KERN_DEBUG "%s: IBSS not allowed on the"
                                       " configured channel %d (%d MHz)\n",
                                       dev->name, local->hw.conf.channel,
@@ -2511,13 +2556,17 @@ int ieee80211_sta_set_ssid(struct net_device *dev, char *ssid, size_t len)
        ifsta = &sdata->u.sta;
 
        if (ifsta->ssid_len != len || memcmp(ifsta->ssid, ssid, len) != 0)
-               ifsta->prev_bssid_set = 0;
+               ifsta->flags &= ~IEEE80211_STA_PREV_BSSID_SET;
        memcpy(ifsta->ssid, ssid, len);
        memset(ifsta->ssid + len, 0, IEEE80211_MAX_SSID_LEN - len);
        ifsta->ssid_len = len;
 
-       ifsta->ssid_set = len ? 1 : 0;
-       if (sdata->type == IEEE80211_IF_TYPE_IBSS && !ifsta->bssid_set) {
+       if (len)
+               ifsta->flags |= IEEE80211_STA_SSID_SET;
+       else
+               ifsta->flags &= ~IEEE80211_STA_SSID_SET;
+       if (sdata->type == IEEE80211_IF_TYPE_IBSS &&
+           !(ifsta->flags & IEEE80211_STA_BSSID_SET)) {
                ifsta->ibss_join_req = jiffies;
                ifsta->state = IEEE80211_IBSS_SEARCH;
                return ieee80211_sta_find_ibss(dev, ifsta);
@@ -2555,10 +2604,11 @@ int ieee80211_sta_set_bssid(struct net_device *dev, u8 *bssid)
                }
        }
 
-       if (!is_valid_ether_addr(bssid))
-               ifsta->bssid_set = 0;
+       if (is_valid_ether_addr(bssid))
+               ifsta->flags |= IEEE80211_STA_BSSID_SET;
        else
-               ifsta->bssid_set = 1;
+               ifsta->flags &= ~IEEE80211_STA_BSSID_SET;
+
        return 0;
 }
 
@@ -2625,7 +2675,7 @@ void ieee80211_scan_completed(struct ieee80211_hw *hw)
                        continue;
 
                if (sdata->type == IEEE80211_IF_TYPE_STA) {
-                       if (sdata->u.sta.associated)
+                       if (sdata->u.sta.flags & IEEE80211_STA_ASSOCIATED)
                                ieee80211_send_nullfunc(local, sdata, 0);
                        ieee80211_sta_timer((unsigned long)sdata);
                }
@@ -2637,7 +2687,7 @@ void ieee80211_scan_completed(struct ieee80211_hw *hw)
        sdata = IEEE80211_DEV_TO_SUB_IF(dev);
        if (sdata->type == IEEE80211_IF_TYPE_IBSS) {
                struct ieee80211_if_sta *ifsta = &sdata->u.sta;
-               if (!ifsta->bssid_set ||
+               if (!(ifsta->flags & IEEE80211_STA_BSSID_SET) ||
                    (!ifsta->state == IEEE80211_IBSS_JOINED &&
                    !ieee80211_sta_active_ibss(dev)))
                        ieee80211_sta_find_ibss(dev, ifsta);
@@ -2779,7 +2829,7 @@ static int ieee80211_sta_start_scan(struct net_device *dev,
 
                netif_stop_queue(sdata->dev);
                if (sdata->type == IEEE80211_IF_TYPE_STA &&
-                   sdata->u.sta.associated)
+                   (sdata->u.sta.flags & IEEE80211_STA_ASSOCIATED))
                        ieee80211_send_nullfunc(local, sdata, 1);
        }
        read_unlock(&local->sub_if_lock);
@@ -3092,7 +3142,7 @@ int ieee80211_sta_disassociate(struct net_device *dev, u16 reason)
        if (sdata->type != IEEE80211_IF_TYPE_STA)
                return -EINVAL;
 
-       if (!ifsta->associated)
+       if (!(ifsta->flags & IEEE80211_STA_ASSOCIATED))
                return -1;
 
        ieee80211_send_disassoc(dev, ifsta, reason);