]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - security/selinux/ss/ebitmap.c
Merge branch 'release' of git://lm-sensors.org/kernel/mhoffman/hwmon-2.6
[linux-2.6-omap-h63xx.git] / security / selinux / ss / ebitmap.c
index d539346ab3a2b5143f1d2232239ee8bdc217e4c8..920b5e36a1af97c00ea6294370a4717651a738aa 100644 (file)
@@ -6,14 +6,19 @@
 /*
  * Updated: Hewlett-Packard <paul.moore@hp.com>
  *
- *      Added ebitmap_export() and ebitmap_import()
+ *      Added support to import/export the NetLabel category bitmap
  *
  * (c) Copyright Hewlett-Packard Development Company, L.P., 2006
  */
+/*
+ * Updated: KaiGai Kohei <kaigai@ak.jp.nec.com>
+ *      Applied standard bit operations to improve bitmap scanning.
+ */
 
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/errno.h>
+#include <net/netlabel.h>
 #include "ebitmap.h"
 #include "policydb.h"
 
@@ -28,7 +33,7 @@ int ebitmap_cmp(struct ebitmap *e1, struct ebitmap *e2)
        n2 = e2->node;
        while (n1 && n2 &&
               (n1->startbit == n2->startbit) &&
-              (n1->map == n2->map)) {
+              !memcmp(n1->maps, n2->maps, EBITMAP_SIZE / 8)) {
                n1 = n1->next;
                n2 = n2->next;
        }
@@ -53,7 +58,7 @@ int ebitmap_cpy(struct ebitmap *dst, struct ebitmap *src)
                        return -ENOMEM;
                }
                new->startbit = n->startbit;
-               new->map = n->map;
+               memcpy(new->maps, n->maps, EBITMAP_SIZE / 8);
                new->next = NULL;
                if (prev)
                        prev->next = new;
@@ -67,145 +72,149 @@ int ebitmap_cpy(struct ebitmap *dst, struct ebitmap *src)
        return 0;
 }
 
+#ifdef CONFIG_NETLABEL
 /**
- * ebitmap_export - Export an ebitmap to a unsigned char bitmap string
- * @src: the ebitmap to export
- * @dst: the resulting bitmap string
- * @dst_len: length of dst in bytes
+ * ebitmap_netlbl_export - Export an ebitmap into a NetLabel category bitmap
+ * @ebmap: the ebitmap to export
+ * @catmap: the NetLabel category bitmap
  *
  * Description:
- * Allocate a buffer at least src->highbit bits long and export the extensible
- * bitmap into the buffer.  The bitmap string will be in little endian format,
- * i.e. LSB first.  The value returned in dst_len may not the true size of the
- * buffer as the length of the buffer is rounded up to a multiple of MAPTYPE.
- * The caller must free the buffer when finished. Returns zero on success,
- * negative values on failure.
+ * Export a SELinux extensibile bitmap into a NetLabel category bitmap.
+ * Returns zero on success, negative values on error.
  *
  */
-int ebitmap_export(const struct ebitmap *src,
-                  unsigned char **dst,
-                  size_t *dst_len)
+int ebitmap_netlbl_export(struct ebitmap *ebmap,
+                         struct netlbl_lsm_secattr_catmap **catmap)
 {
-       size_t bitmap_len;
-       unsigned char *bitmap;
-       struct ebitmap_node *iter_node;
-       MAPTYPE node_val;
-       size_t bitmap_byte;
-       unsigned char bitmask;
-
-       if (src->highbit == 0) {
-               *dst = NULL;
-               *dst_len = 0;
+       struct ebitmap_node *e_iter = ebmap->node;
+       struct netlbl_lsm_secattr_catmap *c_iter;
+       u32 cmap_idx, cmap_sft;
+       int i;
+
+       /* NetLabel's NETLBL_CATMAP_MAPTYPE is defined as an array of u64,
+        * however, it is not always compatible with an array of unsigned long
+        * in ebitmap_node.
+        * In addition, you should pay attention the following implementation
+        * assumes unsigned long has a width equal with or less than 64-bit.
+        */
+
+       if (e_iter == NULL) {
+               *catmap = NULL;
                return 0;
        }
 
-       bitmap_len = src->highbit / 8;
-       if (src->highbit % 7)
-               bitmap_len += 1;
-
-       bitmap = kzalloc((bitmap_len & ~(sizeof(MAPTYPE) - 1)) +
-                        sizeof(MAPTYPE),
-                        GFP_ATOMIC);
-       if (bitmap == NULL)
+       c_iter = netlbl_secattr_catmap_alloc(GFP_ATOMIC);
+       if (c_iter == NULL)
                return -ENOMEM;
-
-       iter_node = src->node;
-       do {
-               bitmap_byte = iter_node->startbit / 8;
-               bitmask = 0x80;
-               node_val = iter_node->map;
-               do {
-                       if (bitmask == 0) {
-                               bitmap_byte++;
-                               bitmask = 0x80;
+       *catmap = c_iter;
+       c_iter->startbit = e_iter->startbit & ~(NETLBL_CATMAP_SIZE - 1);
+
+       while (e_iter != NULL) {
+               for (i = 0; i < EBITMAP_UNIT_NUMS; i++) {
+                       unsigned int delta, e_startbit, c_endbit;
+
+                       e_startbit = e_iter->startbit + i * EBITMAP_UNIT_SIZE;
+                       c_endbit = c_iter->startbit + NETLBL_CATMAP_SIZE;
+                       if (e_startbit >= c_endbit) {
+                               c_iter->next
+                                 = netlbl_secattr_catmap_alloc(GFP_ATOMIC);
+                               if (c_iter->next == NULL)
+                                       goto netlbl_export_failure;
+                               c_iter = c_iter->next;
+                               c_iter->startbit
+                                 = e_startbit & ~(NETLBL_CATMAP_SIZE - 1);
                        }
-                       if (node_val & (MAPTYPE)0x01)
-                               bitmap[bitmap_byte] |= bitmask;
-                       node_val >>= 1;
-                       bitmask >>= 1;
-               } while (node_val > 0);
-               iter_node = iter_node->next;
-       } while (iter_node);
-
-       *dst = bitmap;
-       *dst_len = bitmap_len;
+                       delta = e_startbit - c_iter->startbit;
+                       cmap_idx = delta / NETLBL_CATMAP_MAPSIZE;
+                       cmap_sft = delta % NETLBL_CATMAP_MAPSIZE;
+                       c_iter->bitmap[cmap_idx]
+                               |= e_iter->maps[cmap_idx] << cmap_sft;
+               }
+               e_iter = e_iter->next;
+       }
+
        return 0;
+
+netlbl_export_failure:
+       netlbl_secattr_catmap_free(*catmap);
+       return -ENOMEM;
 }
 
 /**
- * ebitmap_import - Import an unsigned char bitmap string into an ebitmap
- * @src: the bitmap string
- * @src_len: the bitmap length in bytes
- * @dst: the empty ebitmap
+ * ebitmap_netlbl_import - Import a NetLabel category bitmap into an ebitmap
+ * @ebmap: the ebitmap to import
+ * @catmap: the NetLabel category bitmap
  *
  * Description:
- * This function takes a little endian bitmap string in src and imports it into
- * the ebitmap pointed to by dst.  Returns zero on success, negative values on
- * failure.
+ * Import a NetLabel category bitmap into a SELinux extensibile bitmap.
+ * Returns zero on success, negative values on error.
  *
  */
-int ebitmap_import(const unsigned char *src,
-                  size_t src_len,
-                  struct ebitmap *dst)
+int ebitmap_netlbl_import(struct ebitmap *ebmap,
+                         struct netlbl_lsm_secattr_catmap *catmap)
 {
-       size_t src_off = 0;
-       size_t node_limit;
-       struct ebitmap_node *node_new;
-       struct ebitmap_node *node_last = NULL;
-       u32 i_byte;
-       u32 i_bit;
-       unsigned char src_byte;
-
-       while (src_off < src_len) {
-               if (src_len - src_off >= sizeof(MAPTYPE)) {
-                       if (*(MAPTYPE *)&src[src_off] == 0) {
-                               src_off += sizeof(MAPTYPE);
+       struct ebitmap_node *e_iter = NULL;
+       struct ebitmap_node *emap_prev = NULL;
+       struct netlbl_lsm_secattr_catmap *c_iter = catmap;
+       u32 c_idx, c_pos, e_idx, e_sft;
+
+       /* NetLabel's NETLBL_CATMAP_MAPTYPE is defined as an array of u64,
+        * however, it is not always compatible with an array of unsigned long
+        * in ebitmap_node.
+        * In addition, you should pay attention the following implementation
+        * assumes unsigned long has a width equal with or less than 64-bit.
+        */
+
+       do {
+               for (c_idx = 0; c_idx < NETLBL_CATMAP_MAPCNT; c_idx++) {
+                       unsigned int delta;
+                       u64 map = c_iter->bitmap[c_idx];
+
+                       if (!map)
                                continue;
-                       }
-                       node_limit = sizeof(MAPTYPE);
-               } else {
-                       for (src_byte = 0, i_byte = src_off;
-                            i_byte < src_len && src_byte == 0;
-                            i_byte++)
-                               src_byte |= src[i_byte];
-                       if (src_byte == 0)
-                               break;
-                       node_limit = src_len - src_off;
-               }
 
-               node_new = kzalloc(sizeof(*node_new), GFP_ATOMIC);
-               if (unlikely(node_new == NULL)) {
-                       ebitmap_destroy(dst);
-                       return -ENOMEM;
-               }
-               node_new->startbit = src_off * 8;
-               for (i_byte = 0; i_byte < node_limit; i_byte++) {
-                       src_byte = src[src_off++];
-                       for (i_bit = i_byte * 8; src_byte != 0; i_bit++) {
-                               if (src_byte & 0x80)
-                                       node_new->map |= MAPBIT << i_bit;
-                               src_byte <<= 1;
+                       c_pos = c_iter->startbit
+                               + c_idx * NETLBL_CATMAP_MAPSIZE;
+                       if (!e_iter
+                           || c_pos >= e_iter->startbit + EBITMAP_SIZE) {
+                               e_iter = kzalloc(sizeof(*e_iter), GFP_ATOMIC);
+                               if (!e_iter)
+                                       goto netlbl_import_failure;
+                               e_iter->startbit
+                                       = c_pos - (c_pos % EBITMAP_SIZE);
+                               if (emap_prev == NULL)
+                                       ebmap->node = e_iter;
+                               else
+                                       emap_prev->next = e_iter;
+                               emap_prev = e_iter;
+                       }
+                       delta = c_pos - e_iter->startbit;
+                       e_idx = delta / EBITMAP_UNIT_SIZE;
+                       e_sft = delta % EBITMAP_UNIT_SIZE;
+                       while (map) {
+                               e_iter->maps[e_idx++] |= map & (-1UL);
+                               map = EBITMAP_SHIFT_UNIT_SIZE(map);
                        }
                }
-
-               if (node_last != NULL)
-                       node_last->next = node_new;
-               else
-                       dst->node = node_new;
-               node_last = node_new;
-       }
-
-       if (likely(node_last != NULL))
-               dst->highbit = node_last->startbit + MAPSIZE;
+               c_iter = c_iter->next;
+       } while (c_iter != NULL);
+       if (e_iter != NULL)
+               ebmap->highbit = e_iter->startbit + EBITMAP_SIZE;
        else
-               ebitmap_init(dst);
+               ebitmap_destroy(ebmap);
 
        return 0;
+
+netlbl_import_failure:
+       ebitmap_destroy(ebmap);
+       return -ENOMEM;
 }
+#endif /* CONFIG_NETLABEL */
 
 int ebitmap_contains(struct ebitmap *e1, struct ebitmap *e2)
 {
        struct ebitmap_node *n1, *n2;
+       int i;
 
        if (e1->highbit < e2->highbit)
                return 0;
@@ -217,8 +226,10 @@ int ebitmap_contains(struct ebitmap *e1, struct ebitmap *e2)
                        n1 = n1->next;
                        continue;
                }
-               if ((n1->map & n2->map) != n2->map)
-                       return 0;
+               for (i = 0; i < EBITMAP_UNIT_NUMS; i++) {
+                       if ((n1->maps[i] & n2->maps[i]) != n2->maps[i])
+                               return 0;
+               }
 
                n1 = n1->next;
                n2 = n2->next;
@@ -239,12 +250,8 @@ int ebitmap_get_bit(struct ebitmap *e, unsigned long bit)
 
        n = e->node;
        while (n && (n->startbit <= bit)) {
-               if ((n->startbit + MAPSIZE) > bit) {
-                       if (n->map & (MAPBIT << (bit - n->startbit)))
-                               return 1;
-                       else
-                               return 0;
-               }
+               if ((n->startbit + EBITMAP_SIZE) > bit)
+                       return ebitmap_node_get_bit(n, bit);
                n = n->next;
        }
 
@@ -258,31 +265,35 @@ int ebitmap_set_bit(struct ebitmap *e, unsigned long bit, int value)
        prev = NULL;
        n = e->node;
        while (n && n->startbit <= bit) {
-               if ((n->startbit + MAPSIZE) > bit) {
+               if ((n->startbit + EBITMAP_SIZE) > bit) {
                        if (value) {
-                               n->map |= (MAPBIT << (bit - n->startbit));
+                               ebitmap_node_set_bit(n, bit);
                        } else {
-                               n->map &= ~(MAPBIT << (bit - n->startbit));
-                               if (!n->map) {
-                                       /* drop this node from the bitmap */
-
-                                       if (!n->next) {
-                                               /*
-                                                * this was the highest map
-                                                * within the bitmap
-                                                */
-                                               if (prev)
-                                                       e->highbit = prev->startbit + MAPSIZE;
-                                               else
-                                                       e->highbit = 0;
-                                       }
+                               unsigned int s;
+
+                               ebitmap_node_clr_bit(n, bit);
+
+                               s = find_first_bit(n->maps, EBITMAP_SIZE);
+                               if (s < EBITMAP_SIZE)
+                                       return 0;
+
+                               /* drop this node from the bitmap */
+                               if (!n->next) {
+                                       /*
+                                        * this was the highest map
+                                        * within the bitmap
+                                        */
                                        if (prev)
-                                               prev->next = n->next;
+                                               e->highbit = prev->startbit
+                                                            + EBITMAP_SIZE;
                                        else
-                                               e->node = n->next;
-
-                                       kfree(n);
+                                               e->highbit = 0;
                                }
+                               if (prev)
+                                       prev->next = n->next;
+                               else
+                                       e->node = n->next;
+                               kfree(n);
                        }
                        return 0;
                }
@@ -297,12 +308,12 @@ int ebitmap_set_bit(struct ebitmap *e, unsigned long bit, int value)
        if (!new)
                return -ENOMEM;
 
-       new->startbit = bit & ~(MAPSIZE - 1);
-       new->map = (MAPBIT << (bit - new->startbit));
+       new->startbit = bit - (bit % EBITMAP_SIZE);
+       ebitmap_node_set_bit(new, bit);
 
        if (!n)
                /* this node will be the highest map within the bitmap */
-               e->highbit = new->startbit + MAPSIZE;
+               e->highbit = new->startbit + EBITMAP_SIZE;
 
        if (prev) {
                new->next = prev->next;
@@ -336,11 +347,11 @@ void ebitmap_destroy(struct ebitmap *e)
 
 int ebitmap_read(struct ebitmap *e, void *fp)
 {
-       int rc;
-       struct ebitmap_node *n, *l;
+       struct ebitmap_node *n = NULL;
+       u32 mapunit, count, startbit, index;
+       u64 map;
        __le32 buf[3];
-       u32 mapsize, count, i;
-       __le64 map;
+       int rc, i;
 
        ebitmap_init(e);
 
@@ -348,85 +359,88 @@ int ebitmap_read(struct ebitmap *e, void *fp)
        if (rc < 0)
                goto out;
 
-       mapsize = le32_to_cpu(buf[0]);
+       mapunit = le32_to_cpu(buf[0]);
        e->highbit = le32_to_cpu(buf[1]);
        count = le32_to_cpu(buf[2]);
 
-       if (mapsize != MAPSIZE) {
+       if (mapunit != sizeof(u64) * 8) {
                printk(KERN_ERR "security: ebitmap: map size %u does not "
-                      "match my size %Zd (high bit was %d)\n", mapsize,
-                      MAPSIZE, e->highbit);
+                      "match my size %Zd (high bit was %d)\n",
+                      mapunit, sizeof(u64) * 8, e->highbit);
                goto bad;
        }
+
+       /* round up e->highbit */
+       e->highbit += EBITMAP_SIZE - 1;
+       e->highbit -= (e->highbit % EBITMAP_SIZE);
+
        if (!e->highbit) {
                e->node = NULL;
                goto ok;
        }
-       if (e->highbit & (MAPSIZE - 1)) {
-               printk(KERN_ERR "security: ebitmap: high bit (%d) is not a "
-                      "multiple of the map size (%Zd)\n", e->highbit, MAPSIZE);
-               goto bad;
-       }
-       l = NULL;
+
        for (i = 0; i < count; i++) {
-               rc = next_entry(buf, fp, sizeof(u32));
+               rc = next_entry(&startbit, fp, sizeof(u32));
                if (rc < 0) {
                        printk(KERN_ERR "security: ebitmap: truncated map\n");
                        goto bad;
                }
-               n = kzalloc(sizeof(*n), GFP_KERNEL);
-               if (!n) {
-                       printk(KERN_ERR "security: ebitmap: out of memory\n");
-                       rc = -ENOMEM;
-                       goto bad;
-               }
-
-               n->startbit = le32_to_cpu(buf[0]);
+               startbit = le32_to_cpu(startbit);
 
-               if (n->startbit & (MAPSIZE - 1)) {
+               if (startbit & (mapunit - 1)) {
                        printk(KERN_ERR "security: ebitmap start bit (%d) is "
-                              "not a multiple of the map size (%Zd)\n",
-                              n->startbit, MAPSIZE);
-                       goto bad_free;
+                              "not a multiple of the map unit size (%u)\n",
+                              startbit, mapunit);
+                       goto bad;
                }
-               if (n->startbit > (e->highbit - MAPSIZE)) {
+               if (startbit > e->highbit - mapunit) {
                        printk(KERN_ERR "security: ebitmap start bit (%d) is "
-                              "beyond the end of the bitmap (%Zd)\n",
-                              n->startbit, (e->highbit - MAPSIZE));
-                       goto bad_free;
+                              "beyond the end of the bitmap (%u)\n",
+                              startbit, (e->highbit - mapunit));
+                       goto bad;
                }
+
+               if (!n || startbit >= n->startbit + EBITMAP_SIZE) {
+                       struct ebitmap_node *tmp;
+                       tmp = kzalloc(sizeof(*tmp), GFP_KERNEL);
+                       if (!tmp) {
+                               printk(KERN_ERR
+                                      "security: ebitmap: out of memory\n");
+                               rc = -ENOMEM;
+                               goto bad;
+                       }
+                       /* round down */
+                       tmp->startbit = startbit - (startbit % EBITMAP_SIZE);
+                       if (n) {
+                               n->next = tmp;
+                       } else {
+                               e->node = tmp;
+                       }
+                       n = tmp;
+               } else if (startbit <= n->startbit) {
+                       printk(KERN_ERR "security: ebitmap: start bit %d"
+                              " comes after start bit %d\n",
+                              startbit, n->startbit);
+                       goto bad;
+               }
+
                rc = next_entry(&map, fp, sizeof(u64));
                if (rc < 0) {
                        printk(KERN_ERR "security: ebitmap: truncated map\n");
-                       goto bad_free;
+                       goto bad;
                }
-               n->map = le64_to_cpu(map);
+               map = le64_to_cpu(map);
 
-               if (!n->map) {
-                       printk(KERN_ERR "security: ebitmap: null map in "
-                              "ebitmap (startbit %d)\n", n->startbit);
-                       goto bad_free;
+               index = (startbit - n->startbit) / EBITMAP_UNIT_SIZE;
+               while (map) {
+                       n->maps[index++] = map & (-1UL);
+                       map = EBITMAP_SHIFT_UNIT_SIZE(map);
                }
-               if (l) {
-                       if (n->startbit <= l->startbit) {
-                               printk(KERN_ERR "security: ebitmap: start "
-                                      "bit %d comes after start bit %d\n",
-                                      n->startbit, l->startbit);
-                               goto bad_free;
-                       }
-                       l->next = n;
-               } else
-                       e->node = n;
-
-               l = n;
        }
-
 ok:
        rc = 0;
 out:
        return rc;
-bad_free:
-       kfree(n);
 bad:
        if (!rc)
                rc = -EINVAL;