]> pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - sound/pci/oxygen/oxygen_lib.c
s390: types: use <asm-generic/int-*.h> for the s390 architecture
[linux-2.6-omap-h63xx.git] / sound / pci / oxygen / oxygen_lib.c
index 0927e04237777925abbff1313b1d25bd71da8359..897697d43506d2354b2ffc954f58232d97b3c556 100644 (file)
@@ -53,7 +53,8 @@ static irqreturn_t oxygen_interrupt(int dummy, void *dev_id)
                          OXYGEN_CHANNEL_MULTICH |
                          OXYGEN_CHANNEL_AC97 |
                          OXYGEN_INT_SPDIF_IN_DETECT |
-                         OXYGEN_INT_GPIO);
+                         OXYGEN_INT_GPIO |
+                         OXYGEN_INT_AC97);
        if (clear) {
                if (clear & OXYGEN_INT_SPDIF_IN_DETECT)
                        chip->interrupt_mask &= ~OXYGEN_INT_SPDIF_IN_DETECT;
@@ -74,7 +75,9 @@ static irqreturn_t oxygen_interrupt(int dummy, void *dev_id)
        if (status & OXYGEN_INT_SPDIF_IN_DETECT) {
                spin_lock(&chip->reg_lock);
                i = oxygen_read32(chip, OXYGEN_SPDIF_CONTROL);
-               if (i & OXYGEN_SPDIF_RATE_INT) {
+               if (i & (OXYGEN_SPDIF_SENSE_INT | OXYGEN_SPDIF_LOCK_INT |
+                        OXYGEN_SPDIF_RATE_INT)) {
+                       /* write the interrupt bit(s) to clear */
                        oxygen_write32(chip, OXYGEN_SPDIF_CONTROL, i);
                        schedule_work(&chip->spdif_input_bits_work);
                }
@@ -82,11 +85,14 @@ static irqreturn_t oxygen_interrupt(int dummy, void *dev_id)
        }
 
        if (status & OXYGEN_INT_GPIO)
-               ;
+               schedule_work(&chip->gpio_work);
 
        if ((status & OXYGEN_INT_MIDI) && chip->midi)
                snd_mpu401_uart_interrupt(0, chip->midi->private_data);
 
+       if (status & OXYGEN_INT_AC97)
+               wake_up(&chip->ac97_waitqueue);
+
        return IRQ_HANDLED;
 }
 
@@ -94,30 +100,46 @@ static void oxygen_spdif_input_bits_changed(struct work_struct *work)
 {
        struct oxygen *chip = container_of(work, struct oxygen,
                                           spdif_input_bits_work);
+       u32 reg;
 
-       spin_lock_irq(&chip->reg_lock);
-       oxygen_write32_masked(chip, OXYGEN_SPDIF_CONTROL,
-                             OXYGEN_SPDIF_IN_CLOCK_96,
-                             OXYGEN_SPDIF_IN_CLOCK_MASK);
-       spin_unlock_irq(&chip->reg_lock);
+       /*
+        * This function gets called when there is new activity on the SPDIF
+        * input, or when we lose lock on the input signal, or when the rate
+        * changes.
+        */
        msleep(1);
-       if (!(oxygen_read32(chip, OXYGEN_SPDIF_CONTROL)
-             & OXYGEN_SPDIF_LOCK_STATUS)) {
-               spin_lock_irq(&chip->reg_lock);
-               oxygen_write32_masked(chip, OXYGEN_SPDIF_CONTROL,
-                                     OXYGEN_SPDIF_IN_CLOCK_192,
-                                     OXYGEN_SPDIF_IN_CLOCK_MASK);
+       spin_lock_irq(&chip->reg_lock);
+       reg = oxygen_read32(chip, OXYGEN_SPDIF_CONTROL);
+       if ((reg & (OXYGEN_SPDIF_SENSE_STATUS |
+                   OXYGEN_SPDIF_LOCK_STATUS))
+           == OXYGEN_SPDIF_SENSE_STATUS) {
+               /*
+                * If we detect activity on the SPDIF input but cannot lock to
+                * a signal, the clock bit is likely to be wrong.
+                */
+               reg ^= OXYGEN_SPDIF_IN_CLOCK_MASK;
+               oxygen_write32(chip, OXYGEN_SPDIF_CONTROL, reg);
                spin_unlock_irq(&chip->reg_lock);
                msleep(1);
-               if (!(oxygen_read32(chip, OXYGEN_SPDIF_CONTROL)
-                     & OXYGEN_SPDIF_LOCK_STATUS)) {
-                       spin_lock_irq(&chip->reg_lock);
-                       oxygen_write32_masked(chip, OXYGEN_SPDIF_CONTROL,
-                                             OXYGEN_SPDIF_IN_CLOCK_96,
-                                             OXYGEN_SPDIF_IN_CLOCK_MASK);
-                       spin_unlock_irq(&chip->reg_lock);
+               spin_lock_irq(&chip->reg_lock);
+               reg = oxygen_read32(chip, OXYGEN_SPDIF_CONTROL);
+               if ((reg & (OXYGEN_SPDIF_SENSE_STATUS |
+                           OXYGEN_SPDIF_LOCK_STATUS))
+                   == OXYGEN_SPDIF_SENSE_STATUS) {
+                       /* nothing detected with either clock; give up */
+                       if ((reg & OXYGEN_SPDIF_IN_CLOCK_MASK)
+                           == OXYGEN_SPDIF_IN_CLOCK_192) {
+                               /*
+                                * Reset clock to <= 96 kHz because this is
+                                * more likely to be received next time.
+                                */
+                               reg &= ~OXYGEN_SPDIF_IN_CLOCK_MASK;
+                               reg |= OXYGEN_SPDIF_IN_CLOCK_96;
+                               oxygen_write32(chip, OXYGEN_SPDIF_CONTROL, reg);
+                       }
                }
        }
+       spin_unlock_irq(&chip->reg_lock);
 
        if (chip->controls[CONTROL_SPDIF_INPUT_BITS]) {
                spin_lock_irq(&chip->reg_lock);
@@ -126,11 +148,23 @@ static void oxygen_spdif_input_bits_changed(struct work_struct *work)
                               chip->interrupt_mask);
                spin_unlock_irq(&chip->reg_lock);
 
+               /*
+                * We don't actually know that any channel status bits have
+                * changed, but let's send a notification just to be sure.
+                */
                snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE,
                               &chip->controls[CONTROL_SPDIF_INPUT_BITS]->id);
        }
 }
 
+static void oxygen_gpio_changed(struct work_struct *work)
+{
+       struct oxygen *chip = container_of(work, struct oxygen, gpio_work);
+
+       if (chip->model->gpio_changed)
+               chip->model->gpio_changed(chip);
+}
+
 #ifdef CONFIG_PROC_FS
 static void oxygen_proc_read(struct snd_info_entry *entry,
                             struct snd_info_buffer *buffer)
@@ -170,7 +204,7 @@ static void oxygen_proc_read(struct snd_info_entry *entry,
        mutex_unlock(&chip->mutex);
 }
 
-static void __devinit oxygen_proc_init(struct oxygen *chip)
+static void oxygen_proc_init(struct oxygen *chip)
 {
        struct snd_info_entry *entry;
 
@@ -181,13 +215,14 @@ static void __devinit oxygen_proc_init(struct oxygen *chip)
 #define oxygen_proc_init(chip)
 #endif
 
-static void __devinit oxygen_init(struct oxygen *chip)
+static void oxygen_init(struct oxygen *chip)
 {
        unsigned int i;
 
        chip->dac_routing = 1;
        for (i = 0; i < 8; ++i)
-               chip->dac_volume[i] = 0xff;
+               chip->dac_volume[i] = chip->model->dac_volume_min;
+       chip->dac_mute = 1;
        chip->spdif_playback_enable = 1;
        chip->spdif_bits = OXYGEN_SPDIF_C | OXYGEN_SPDIF_ORIGINAL |
                (IEC958_AES1_CON_PCM_CODER << OXYGEN_SPDIF_CATEGORY_SHIFT);
@@ -206,36 +241,92 @@ static void __devinit oxygen_init(struct oxygen *chip)
        chip->has_ac97_0 = (i & OXYGEN_AC97_CODEC_0) != 0;
        chip->has_ac97_1 = (i & OXYGEN_AC97_CODEC_1) != 0;
 
-       oxygen_set_bits8(chip, OXYGEN_FUNCTION,
-                        OXYGEN_FUNCTION_RESET_CODEC |
-                        chip->model->function_flags);
+       oxygen_write8_masked(chip, OXYGEN_FUNCTION,
+                            OXYGEN_FUNCTION_RESET_CODEC |
+                            chip->model->function_flags,
+                            OXYGEN_FUNCTION_RESET_CODEC |
+                            OXYGEN_FUNCTION_2WIRE_SPI_MASK |
+                            OXYGEN_FUNCTION_ENABLE_SPI_4_5);
+       oxygen_write8(chip, OXYGEN_DMA_STATUS, 0);
+       oxygen_write8(chip, OXYGEN_DMA_PAUSE, 0);
+       oxygen_write8(chip, OXYGEN_PLAY_CHANNELS,
+                     OXYGEN_PLAY_CHANNELS_2 |
+                     OXYGEN_DMA_A_BURST_8 |
+                     OXYGEN_DMA_MULTICH_BURST_8);
+       oxygen_write16(chip, OXYGEN_INTERRUPT_MASK, 0);
+       oxygen_write8_masked(chip, OXYGEN_MISC,
+                            chip->model->misc_flags,
+                            OXYGEN_MISC_WRITE_PCI_SUBID |
+                            OXYGEN_MISC_REC_C_FROM_SPDIF |
+                            OXYGEN_MISC_REC_B_FROM_AC97 |
+                            OXYGEN_MISC_REC_A_FROM_MULTICH |
+                            OXYGEN_MISC_MIDI);
+       oxygen_write8(chip, OXYGEN_REC_FORMAT,
+                     (OXYGEN_FORMAT_16 << OXYGEN_REC_FORMAT_A_SHIFT) |
+                     (OXYGEN_FORMAT_16 << OXYGEN_REC_FORMAT_B_SHIFT) |
+                     (OXYGEN_FORMAT_16 << OXYGEN_REC_FORMAT_C_SHIFT));
+       oxygen_write8(chip, OXYGEN_PLAY_FORMAT,
+                     (OXYGEN_FORMAT_16 << OXYGEN_SPDIF_FORMAT_SHIFT) |
+                     (OXYGEN_FORMAT_16 << OXYGEN_MULTICH_FORMAT_SHIFT));
+       oxygen_write8(chip, OXYGEN_REC_CHANNELS, OXYGEN_REC_CHANNELS_2_2_2);
        oxygen_write16(chip, OXYGEN_I2S_MULTICH_FORMAT,
-                      OXYGEN_RATE_48000 | OXYGEN_I2S_FORMAT_LJUST |
-                      OXYGEN_I2S_MCLK_128 | OXYGEN_I2S_BITS_16 |
-                      OXYGEN_I2S_MASTER | OXYGEN_I2S_BCLK_64);
-       oxygen_write16(chip, OXYGEN_I2S_A_FORMAT,
-                      OXYGEN_RATE_48000 | OXYGEN_I2S_FORMAT_LJUST |
-                      OXYGEN_I2S_MCLK_128 | OXYGEN_I2S_BITS_16 |
-                      OXYGEN_I2S_MASTER | OXYGEN_I2S_BCLK_64);
-       oxygen_write16(chip, OXYGEN_I2S_B_FORMAT,
-                      OXYGEN_RATE_48000 | OXYGEN_I2S_FORMAT_LJUST |
-                      OXYGEN_I2S_MCLK_128 | OXYGEN_I2S_BITS_16 |
+                      OXYGEN_RATE_48000 | chip->model->dac_i2s_format |
+                      OXYGEN_I2S_MCLK_256 | OXYGEN_I2S_BITS_16 |
                       OXYGEN_I2S_MASTER | OXYGEN_I2S_BCLK_64);
+       if (chip->model->pcm_dev_cfg & CAPTURE_0_FROM_I2S_1)
+               oxygen_write16(chip, OXYGEN_I2S_A_FORMAT,
+                              OXYGEN_RATE_48000 | chip->model->adc_i2s_format |
+                              OXYGEN_I2S_MCLK_256 | OXYGEN_I2S_BITS_16 |
+                              OXYGEN_I2S_MASTER | OXYGEN_I2S_BCLK_64);
+       else
+               oxygen_write16(chip, OXYGEN_I2S_A_FORMAT,
+                              OXYGEN_I2S_MASTER | OXYGEN_I2S_MUTE_MCLK);
+       if (chip->model->pcm_dev_cfg & (CAPTURE_0_FROM_I2S_2 |
+                                       CAPTURE_2_FROM_I2S_2))
+               oxygen_write16(chip, OXYGEN_I2S_B_FORMAT,
+                              OXYGEN_RATE_48000 | chip->model->adc_i2s_format |
+                              OXYGEN_I2S_MCLK_256 | OXYGEN_I2S_BITS_16 |
+                              OXYGEN_I2S_MASTER | OXYGEN_I2S_BCLK_64);
+       else
+               oxygen_write16(chip, OXYGEN_I2S_B_FORMAT,
+                              OXYGEN_I2S_MASTER | OXYGEN_I2S_MUTE_MCLK);
        oxygen_write16(chip, OXYGEN_I2S_C_FORMAT,
-                      OXYGEN_RATE_48000 | OXYGEN_I2S_FORMAT_LJUST |
-                      OXYGEN_I2S_MCLK_128 | OXYGEN_I2S_BITS_16 |
-                      OXYGEN_I2S_MASTER | OXYGEN_I2S_BCLK_64);
-       oxygen_set_bits32(chip, OXYGEN_SPDIF_CONTROL, OXYGEN_SPDIF_RATE_MASK);
+                      OXYGEN_I2S_MASTER | OXYGEN_I2S_MUTE_MCLK);
+       oxygen_clear_bits32(chip, OXYGEN_SPDIF_CONTROL,
+                           OXYGEN_SPDIF_OUT_ENABLE |
+                           OXYGEN_SPDIF_LOOPBACK);
+       if (chip->model->pcm_dev_cfg & CAPTURE_1_FROM_SPDIF)
+               oxygen_write32_masked(chip, OXYGEN_SPDIF_CONTROL,
+                                     OXYGEN_SPDIF_SENSE_MASK |
+                                     OXYGEN_SPDIF_LOCK_MASK |
+                                     OXYGEN_SPDIF_RATE_MASK |
+                                     OXYGEN_SPDIF_LOCK_PAR |
+                                     OXYGEN_SPDIF_IN_CLOCK_96,
+                                     OXYGEN_SPDIF_SENSE_MASK |
+                                     OXYGEN_SPDIF_LOCK_MASK |
+                                     OXYGEN_SPDIF_RATE_MASK |
+                                     OXYGEN_SPDIF_SENSE_PAR |
+                                     OXYGEN_SPDIF_LOCK_PAR |
+                                     OXYGEN_SPDIF_IN_CLOCK_MASK);
+       else
+               oxygen_clear_bits32(chip, OXYGEN_SPDIF_CONTROL,
+                                   OXYGEN_SPDIF_SENSE_MASK |
+                                   OXYGEN_SPDIF_LOCK_MASK |
+                                   OXYGEN_SPDIF_RATE_MASK);
        oxygen_write32(chip, OXYGEN_SPDIF_OUTPUT_BITS, chip->spdif_bits);
+       oxygen_clear_bits8(chip, OXYGEN_MPU401_CONTROL, OXYGEN_MPU401_LOOPBACK);
+       oxygen_write8(chip, OXYGEN_GPI_INTERRUPT_MASK, 0);
+       oxygen_write16(chip, OXYGEN_GPIO_INTERRUPT_MASK, 0);
        oxygen_write16(chip, OXYGEN_PLAY_ROUTING,
-                      OXYGEN_PLAY_MULTICH_I2S_DAC | OXYGEN_PLAY_SPDIF_SPDIF |
+                      OXYGEN_PLAY_MULTICH_I2S_DAC |
+                      OXYGEN_PLAY_SPDIF_SPDIF |
                       (0 << OXYGEN_PLAY_DAC0_SOURCE_SHIFT) |
                       (1 << OXYGEN_PLAY_DAC1_SOURCE_SHIFT) |
                       (2 << OXYGEN_PLAY_DAC2_SOURCE_SHIFT) |
                       (3 << OXYGEN_PLAY_DAC3_SOURCE_SHIFT));
        oxygen_write8(chip, OXYGEN_REC_ROUTING,
                      OXYGEN_REC_A_ROUTE_I2S_ADC_1 |
-                     OXYGEN_REC_B_ROUTE_AC97_1 |
+                     OXYGEN_REC_B_ROUTE_I2S_ADC_2 |
                      OXYGEN_REC_C_ROUTE_SPDIF);
        oxygen_write8(chip, OXYGEN_ADC_MONITOR, 0);
        oxygen_write8(chip, OXYGEN_A_MONITOR_ROUTING,
@@ -244,23 +335,21 @@ static void __devinit oxygen_init(struct oxygen *chip)
                      (2 << OXYGEN_A_MONITOR_ROUTE_2_SHIFT) |
                      (3 << OXYGEN_A_MONITOR_ROUTE_3_SHIFT));
 
-       oxygen_write16(chip, OXYGEN_INTERRUPT_MASK, 0);
-       oxygen_write16(chip, OXYGEN_DMA_STATUS, 0);
-
-       oxygen_write8(chip, OXYGEN_AC97_INTERRUPT_MASK, 0);
-       if (chip->has_ac97_0) {
-               oxygen_clear_bits16(chip, OXYGEN_AC97_OUT_CONFIG,
-                                   OXYGEN_AC97_CODEC0_FRONTL |
-                                   OXYGEN_AC97_CODEC0_FRONTR |
-                                   OXYGEN_AC97_CODEC0_SIDEL |
-                                   OXYGEN_AC97_CODEC0_SIDER |
-                                   OXYGEN_AC97_CODEC0_CENTER |
-                                   OXYGEN_AC97_CODEC0_BASE |
-                                   OXYGEN_AC97_CODEC0_REARL |
-                                   OXYGEN_AC97_CODEC0_REARR);
-               oxygen_set_bits16(chip, OXYGEN_AC97_IN_CONFIG,
-                                 OXYGEN_AC97_CODEC0_LINEL |
-                                 OXYGEN_AC97_CODEC0_LINER);
+       if (chip->has_ac97_0 | chip->has_ac97_1)
+               oxygen_write8(chip, OXYGEN_AC97_INTERRUPT_MASK,
+                             OXYGEN_AC97_INT_READ_DONE |
+                             OXYGEN_AC97_INT_WRITE_DONE);
+       else
+               oxygen_write8(chip, OXYGEN_AC97_INTERRUPT_MASK, 0);
+       oxygen_write32(chip, OXYGEN_AC97_OUT_CONFIG, 0);
+       oxygen_write32(chip, OXYGEN_AC97_IN_CONFIG, 0);
+       if (!(chip->has_ac97_0 | chip->has_ac97_1))
+               oxygen_set_bits16(chip, OXYGEN_AC97_CONTROL,
+                                 OXYGEN_AC97_CLOCK_DISABLE);
+       if (!chip->has_ac97_0) {
+               oxygen_set_bits16(chip, OXYGEN_AC97_CONTROL,
+                                 OXYGEN_AC97_NO_CODEC_0);
+       } else {
                oxygen_write_ac97(chip, 0, AC97_RESET, 0);
                msleep(1);
                oxygen_ac97_set_bits(chip, 0, CM9780_GPIO_SETUP,
@@ -282,14 +371,33 @@ static void __devinit oxygen_init(struct oxygen *chip)
                oxygen_write_ac97(chip, 0, AC97_REC_GAIN, 0x8000);
                oxygen_write_ac97(chip, 0, AC97_CENTER_LFE_MASTER, 0x8080);
                oxygen_write_ac97(chip, 0, AC97_SURROUND_MASTER, 0x8080);
-               oxygen_ac97_clear_bits(chip, 0,
-                                      CM9780_GPIO_STATUS, CM9780_GPO0);
+               oxygen_ac97_clear_bits(chip, 0, CM9780_GPIO_STATUS,
+                                      CM9780_GPO0);
                /* power down unused ADCs and DACs */
                oxygen_ac97_set_bits(chip, 0, AC97_POWERDOWN,
                                     AC97_PD_PR0 | AC97_PD_PR1);
                oxygen_ac97_set_bits(chip, 0, AC97_EXTENDED_STATUS,
                                     AC97_EA_PRI | AC97_EA_PRJ | AC97_EA_PRK);
        }
+       if (chip->has_ac97_1) {
+               oxygen_set_bits32(chip, OXYGEN_AC97_OUT_CONFIG,
+                                 OXYGEN_AC97_CODEC1_SLOT3 |
+                                 OXYGEN_AC97_CODEC1_SLOT4);
+               oxygen_write_ac97(chip, 1, AC97_RESET, 0);
+               msleep(1);
+               oxygen_write_ac97(chip, 1, AC97_MASTER, 0x0000);
+               oxygen_write_ac97(chip, 1, AC97_HEADPHONE, 0x8000);
+               oxygen_write_ac97(chip, 1, AC97_PC_BEEP, 0x8000);
+               oxygen_write_ac97(chip, 1, AC97_MIC, 0x8808);
+               oxygen_write_ac97(chip, 1, AC97_LINE, 0x8808);
+               oxygen_write_ac97(chip, 1, AC97_CD, 0x8808);
+               oxygen_write_ac97(chip, 1, AC97_VIDEO, 0x8808);
+               oxygen_write_ac97(chip, 1, AC97_AUX, 0x8808);
+               oxygen_write_ac97(chip, 1, AC97_PCM, 0x0808);
+               oxygen_write_ac97(chip, 1, AC97_REC_SEL, 0x0000);
+               oxygen_write_ac97(chip, 1, AC97_REC_GAIN, 0x0000);
+               oxygen_ac97_set_bits(chip, 1, 0x6a, 0x0040);
+       }
 }
 
 static void oxygen_card_free(struct snd_card *card)
@@ -302,10 +410,8 @@ static void oxygen_card_free(struct snd_card *card)
        oxygen_write16(chip, OXYGEN_DMA_STATUS, 0);
        oxygen_write16(chip, OXYGEN_INTERRUPT_MASK, 0);
        spin_unlock_irq(&chip->reg_lock);
-       if (chip->irq >= 0) {
+       if (chip->irq >= 0)
                free_irq(chip->irq, chip);
-               synchronize_irq(chip->irq);
-       }
        flush_scheduled_work();
        chip->model->cleanup(chip);
        mutex_destroy(&chip->mutex);
@@ -313,8 +419,8 @@ static void oxygen_card_free(struct snd_card *card)
        pci_disable_device(chip->pci);
 }
 
-int __devinit oxygen_pci_probe(struct pci_dev *pci, int index, char *id,
-                              int midi, const struct oxygen_model *model)
+int oxygen_pci_probe(struct pci_dev *pci, int index, char *id,
+                    const struct oxygen_model *model)
 {
        struct snd_card *card;
        struct oxygen *chip;
@@ -335,6 +441,8 @@ int __devinit oxygen_pci_probe(struct pci_dev *pci, int index, char *id,
        mutex_init(&chip->mutex);
        INIT_WORK(&chip->spdif_input_bits_work,
                  oxygen_spdif_input_bits_changed);
+       INIT_WORK(&chip->gpio_work, oxygen_gpio_changed);
+       init_waitqueue_head(&chip->ac97_waitqueue);
 
        err = pci_enable_device(pci);
        if (err < 0)
@@ -384,9 +492,7 @@ int __devinit oxygen_pci_probe(struct pci_dev *pci, int index, char *id,
        if (err < 0)
                goto err_card;
 
-       oxygen_write8_masked(chip, OXYGEN_MISC,
-                            midi ? OXYGEN_MISC_MIDI : 0, OXYGEN_MISC_MIDI);
-       if (midi) {
+       if (model->misc_flags & OXYGEN_MISC_MIDI) {
                err = snd_mpu401_uart_new(card, 0, MPU401_HW_CMIPCI,
                                          chip->addr + OXYGEN_MPU401,
                                          MPU401_INFO_INTEGRATED, 0, 0,
@@ -398,7 +504,10 @@ int __devinit oxygen_pci_probe(struct pci_dev *pci, int index, char *id,
        oxygen_proc_init(chip);
 
        spin_lock_irq(&chip->reg_lock);
-       chip->interrupt_mask |= OXYGEN_INT_SPDIF_IN_DETECT;
+       if (chip->model->pcm_dev_cfg & CAPTURE_1_FROM_SPDIF)
+               chip->interrupt_mask |= OXYGEN_INT_SPDIF_IN_DETECT;
+       if (chip->has_ac97_0 | chip->has_ac97_1)
+               chip->interrupt_mask |= OXYGEN_INT_AC97;
        oxygen_write16(chip, OXYGEN_INTERRUPT_MASK, chip->interrupt_mask);
        spin_unlock_irq(&chip->reg_lock);
 
@@ -419,7 +528,7 @@ err_card:
 }
 EXPORT_SYMBOL(oxygen_pci_probe);
 
-void __devexit oxygen_pci_remove(struct pci_dev *pci)
+void oxygen_pci_remove(struct pci_dev *pci)
 {
        snd_card_free(pci_get_drvdata(pci));
        pci_set_drvdata(pci, NULL);